Re: [U-Boot] [PATCH] i2c: sh: Remove irq_wait function
Hello Nobuhiro, Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com wrote: irq_wait function is not referred to from anywhere. Reported-by: Albert ARIBAUD albert.u.b...@aribaud.net Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com --- drivers/i2c/sh_i2c.c | 16 1 file changed, 16 deletions(-) Good catch! Hmm.. for some reason, I could not find this patch in patchwork... Did you or Albert changed the state from it in patchwork? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] pull request for u-boot-tegra/next into ARM next
Hi Tom,
On Mon, 1 Oct 2012 13:26:19 -0700, Tom Warren
twarren.nvi...@gmail.com wrote:
Albert,
Please pull u-boot-tegra/next into ARM next as per the discussion
currently on-going with Lucas Stach on the list. Thanks!
./MAKEALL -s tegra20 runs OK, and checkpatch.pl is clean except for 1
bogus warning about a macro needing parens.
The following changes since commit 1c27059a2f7158a9c9a8778535b030935d75179d:
Albert ARIBAUD (1):
Merge remote-tracking branch 'u-boot/master'
are available in the git repository at:
git://git.denx.de/u-boot-tegra next
Lucas Stach (6):
tegra20: complete periph_id enum
tegra20: add clock_set_pllout function
tegra20: rework UART GPIO handling
tegra: add funcmux entry for NAND attached to KBC
tegra: clean up board include hell
tegra: nand: add board pinmux
Stephen Warren (1):
tegra: enable CONFIG_CMD_PART
Thierry Reding (2):
tegra: Update Avionic Design vendor prefix
tegra: Rename Medcom to Medcom-Wide
Tom Warren (2):
Tegra20: Move some code files to common directories for upcoming
Tegra30 patches.
Tegra20: Move some include files to arch-tegra for sharing with Tegra30
MAINTAINERS|2 +-
Makefile |2 +
arch/arm/cpu/arm720t/tegra-common/Makefile | 47 +++
.../cpu/arm720t/{tegra20 = tegra-common}/cpu.h|0
.../cpu/arm720t/{tegra20 = tegra-common}/spl.c| 18 +-
arch/arm/cpu/arm720t/tegra20/Makefile |1 -
arch/arm/cpu/arm720t/tegra20/cpu.c | 12 +-
arch/arm/cpu/armv7/tegra-common/Makefile | 48 +++
.../armv7/{tegra20 = tegra-common}/cmd_enterrcm.c |4 +-
arch/arm/cpu/armv7/tegra20/Makefile|1 -
arch/arm/cpu/armv7/tegra20/usb.c |8 +-
arch/arm/cpu/tegra-common/Makefile | 48 +++
.../{tegra20-common/ap20.c = tegra-common/ap.c} | 12 +-
.../cpu/{tegra20-common = tegra-common}/board.c |9 +-
.../lowlevel_init.S|0
.../{tegra20-common = tegra-common}/sys_info.c|0
.../cpu/{tegra20-common = tegra-common}/timer.c |4 +-
arch/arm/cpu/tegra20-common/Makefile |3 +-
arch/arm/cpu/tegra20-common/clock.c| 47 +++-
arch/arm/cpu/tegra20-common/emc.c |4 +-
arch/arm/cpu/tegra20-common/funcmux.c | 19 +-
arch/arm/cpu/tegra20-common/pinmux.c |4 +-
arch/arm/cpu/tegra20-common/pmu.c |8 +-
arch/arm/cpu/tegra20-common/warmboot.c | 18 +-
arch/arm/cpu/tegra20-common/warmboot_avp.c | 14 +-
.../asm/{arch-tegra20/ap20.h = arch-tegra/ap.h} |0
arch/arm/include/asm/arch-tegra/board.h| 48 +++
.../asm/{arch-tegra20 = arch-tegra}/clk_rst.h | 11 +-
arch/arm/include/asm/arch-tegra/clock.h| 265 +
.../asm/{arch-tegra20 = arch-tegra}/fuse.h|0
.../arm/include/asm/arch-tegra/gpio.h | 27 +-
.../include/asm/{arch-tegra20 = arch-tegra}/mmc.h |0
.../include/asm/{arch-tegra20 = arch-tegra}/pmc.h |0
.../include/asm/{arch-tegra20 = arch-tegra}/scu.h |0
.../asm/{arch-tegra20 = arch-tegra}/sys_proto.h |0
.../{arch-tegra20/tegra20.h = arch-tegra/tegra.h} | 14 +-
.../asm/{arch-tegra20 = arch-tegra}/tegra_i2c.h |4 +-
.../asm/{arch-tegra20 = arch-tegra}/tegra_mmc.h |0
.../asm/{arch-tegra20 = arch-tegra}/tegra_spi.h |0
.../asm/{arch-tegra20 = arch-tegra}/timer.h |0
.../asm/{arch-tegra20 = arch-tegra}/uart.h|0
.../asm/{arch-tegra20 = arch-tegra}/warmboot.h|0
arch/arm/include/asm/arch-tegra20/board.h | 30 --
arch/arm/include/asm/arch-tegra20/clock-tables.h | 196 ++
arch/arm/include/asm/arch-tegra20/clock.h | 388
+---
arch/arm/include/asm/arch-tegra20/funcmux.h|1 +
arch/arm/include/asm/arch-tegra20/gpio.h | 22 +-
.../board.h = include/asm/arch-tegra20/tegra.h} | 17 +-
board/avionic-design/common/tamonten.c | 20 +-
...{tegra20-medcom.dts = tegra20-medcom-wide.dts} |2 +-
board/avionic-design/dts/tegra20-plutux.dts|2 +-
board/avionic-design/dts/tegra20-tec.dts |2 +-
.../{medcom = medcom-wide}/Makefile |0
board/compal/paz00/paz00.c | 11 +-
board/compulab/trimslice/trimslice.c | 13 +-
board/nvidia/common/board.c| 42 ++-
board/nvidia/common/emc.c |8 +-
board/nvidia/common/uart-spi-switch.c |6 +-
board/nvidia/harmony/harmony.c | 11 +-
board/nvidia/seaboard/seaboard.c |6 +-
Re: [U-Boot] [PULL] u-boot-pxa/next
Hi Marek, On Wed, 3 Oct 2012 02:03:57 +0200, Marek Vasut ma...@denx.de wrote: The following changes since commit c7ee66a8222660b565e9240775efa4c82cb348c2: Merge branch 'next' of git://www.denx.de/git/u-boot-ppc4xx into next (2012-10-02 10:16:40 -0700) are available in the git repository at: git://git.denx.de/u-boot-pxa.git next for you to fetch changes up to 7b9b0eae55f211e449984bfa5c1f171d1f256813: pxa: Add code to examine cpu model and revision (2012-10-03 02:00:15 +0200) Lukasz Dalek (2): h2200: Add support for iPAQ h2200 palmtop pxa: Add code to examine cpu model and revision arch/arm/cpu/pxa/cpuinfo.c | 11 -- arch/arm/include/asm/arch-pxa/pxa.h | 13 +++ board/h2200/Makefile| 49 +++ board/h2200/h2200-header.S | 27 +++ board/h2200/h2200.c | 53 + boards.cfg |1 + include/configs/h2200.h | 156 7 files changed, 308 insertions(+), 2 deletions(-) create mode 100644 board/h2200/Makefile create mode 100644 board/h2200/h2200-header.S create mode 100644 board/h2200/h2200.c create mode 100644 include/configs/h2200.h ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot Applied to u-boot-arm/next, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [u-boot] Adding missing CONFIG_SYS_CACHELINE_SIZE to boards definitions
Hi Jens and Helmut,
On Thu, Aug 23, 2012 at 10:13:13PM -, Lukasz Majewski wrote:
The restoration of GPT table (both primary and secondary) is now
possible. Simple GUID generation is supported.
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
While the changes are fine, tt01 and eb_cpux9k2 use CONFIG_PART_EFI
and do not set CONFIG_SYS_CACHELINE_SIZE and so fail to build after
this patch. tt01 is easily fixable (it relies on a non-exported
define elsewhere to 32) but the eb_cpu9k2 please contact the listed
board maintainer to get the define added.
Would it be possible to add the CONFIG_SYS_CACHELINE_SIZE
definition to ./include/configs/{tty01|eb_cpux9k2} boards definition?
It would help improving cache alignment and GPT development.
Thanks in advance
--
Best regards,
Lukasz Majewski
Samsung Poland RD Center | Linux Platform Group
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ppc4xx/next
Hi Marek, On 10/03/2012 02:15 AM, Marek Vasut wrote: Stefan Roese (3): ppc4xx: Remove IOP480 support ppc4xx: Remove ML2 board support ppc4xx: Remove AP1000 board support [...] I see :-) Not many zombies removed ... any plans to continue this crusade? Not right now. Hard to determine which boards are unmaintained. Do you have idea on how to check for unmaintained boards? Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 2/8] SPL: Port SPL framework to powerpc
On 10/02/2012 10:08 PM, Scott Wood wrote:
+void __noreturn jump_to_image_linux(void *arg)
+{
+ debug(Entering kernel arg pointer: 0x%p\n, arg);
+ typedef void (*image_entry_arg_t)(void *, ulong r4, ulong r5,
ulong r6,
+ulong r7, ulong r8, ulong r9)
+ __attribute__ ((noreturn));
+ image_entry_arg_t image_entry =
+ (image_entry_arg_t)spl_image.entry_point;
+
+ image_entry(arg, 0, 0, EPAPR_MAGIC, CONFIG_SYS_BOOTMAPSZ, 0, 0);
+}
At what point does the image get cache-flushed?
Not at all right now. MPC5200 has dcache disabled, at least in the
SPL.
Other PowerPC architectures might add a cache flush here if needed at
some time. Okay?
Or they might forget to do so and have weird bugs.
Why not just call flush_cache() on the image now? Non-SPL does this in
common code, not even PPC-specific.
Okay, probably better to add this code now. But shouldn't we add this
code to the common SPL framework code then? Right before calling
jump_to_image_linux()?
Tom? Should I prepare a patch adding this cache flushing to
common/spl/spl.c?
Thanks,
Stefan
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] i2c: sh: Remove irq_wait function
Hi Heiko, On Thu, 04 Oct 2012 08:25:55 +0200 h...@denx.de wrote: Hello Nobuhiro, Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com wrote: irq_wait function is not referred to from anywhere. Reported-by: Albert ARIBAUD albert.u.b...@aribaud.net Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com --- drivers/i2c/sh_i2c.c | 16 1 file changed, 16 deletions(-) Good catch! Hmm.. for some reason, I could not find this patch in patchwork... Did you or Albert changed the state from it in patchwork? this patch is already in u-boot-arm.git tree and the state on patchwork is accepted. Albert applied it directly, it seems. Thanks, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 6/8] fdt: cmd_fdt: Call fdt_chosen() from fdt boardsetup
Hi Matthew, On 10/03/2012 02:57 AM, McClintock Matthew-B29882 wrote: On Tue, Oct 2, 2012 at 5:26 AM, Stefan Roese s...@denx.de wrote: On 09/27/2012 10:43 PM, McClintock Matthew-B29882 wrote: By calling fdt_chosen(), the chosen node will be updated / created by the fdt boardsetup command. This is useful for setting of the kernel commandline via the bootargs env variable. With this change, the fdt boardsetup can be used to prepare the DT blob for SPL booting. The patched DT blob can be saved to flash and can be used by the SPL U-Boot version directly for Linux booting. Signed-off-by: Stefan Roese s...@denx.de --- common/cmd_fdt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) There are possibly some workflows this breaks. I can't remember if for AMP boot we need to do something between ft_board_setup() and fdt_chosen() Could you please elaborate what exactly you fear here? Is this a NACK for this patch? Possibly. I've got to find our docs on how we do 2-core AMP booting sequence w/regards to device tree. See if this works: http://www.freescale.com/infocenter/index.jsp?topic=%2FQORIQSDK%2F2151493.html Kumar, did you find the time to check/test this? I would really like to know if this patch is okay with you. This should be fine. You are calling fdt_chosen(), but we can still run 'fdt chosen $initrd_start $initrd_end' after 'fdt boardsetup'. A quick glance at fdt_chosen() suggest it can be run multiple times without error. You might add a comment in the U_BOOT_CMD that mentions boardsetup calls chosen. Now I see that I don't need this patch at all. I can call fdt chosen after calling fdt boardsetup and everything is fine. So lets drop this patch completely. Sorry for the noise. Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] ARM: Add X600 board support (SPEAr600 based)
Hi Stefan, On Thu, 31 May 2012 10:59:08 +0200, Stefan Roese s...@denx.de wrote: This patch adds support for the X600 SPEAr600 based board. Its also the first SPEAr600 board that uses the newly introduced SPEAr600 SPL support. Xloader is not necessary any more. By using the new u-boot.spr make target, one image will generated containing both, U-Boot SPL (with mkimage header as needed by the SPEAr BootROM, and the main U-Boot with mkimage header. Signed-off-by: Stefan Roese s...@denx.de Cc: Amit Virdi amit.vi...@st.com Cc: Vipin Kumar vipin.ku...@st.com --- v2: - Add hush support - Add bootcount altbootcmd support MAINTAINERS |2 + board/spear/x600/Makefile | 47 +++ board/spear/x600/fpga.c | 280 + board/spear/x600/fpga.h | 23 +++ board/spear/x600/x600.c | 124 + boards.cfg|1 + include/configs/x600.h| 339 + 7 files changed, 816 insertions(+) create mode 100644 board/spear/x600/Makefile create mode 100644 board/spear/x600/fpga.c create mode 100644 board/spear/x600/fpga.h create mode 100644 board/spear/x600/x600.c create mode 100644 include/configs/x600.h diff --git a/MAINTAINERS b/MAINTAINERS index f796872..c55faff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -828,6 +828,8 @@ John Rigby jcri...@gmail.com Stefan Roese s...@denx.de + x600ARM926EJS (spear600 Soc) + pdnb3 xscale/ixp scpuxscale/ixp diff --git a/board/spear/x600/Makefile b/board/spear/x600/Makefile new file mode 100644 index 000..8c4e7e2 --- /dev/null +++ b/board/spear/x600/Makefile @@ -0,0 +1,47 @@ +# +# (C) Copyright 2000-2004 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +ifndef CONFIG_SPL_BUILD +COBJS:= fpga.o $(BOARD).o +endif +SOBJS:= + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS:= $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/spear/x600/fpga.c b/board/spear/x600/fpga.c new file mode 100644 index 000..85eb31b --- /dev/null +++ b/board/spear/x600/fpga.c @@ -0,0 +1,280 @@ +/* + * Copyright (C) 2012 Stefan Roese s...@denx.de + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#include common.h +#include spartan3.h +#include command.h +#include asm/gpio.h +#include asm/io.h +#include asm/arch/hardware.h +#include asm/arch/spr_misc.h +#include asm/arch/spr_ssp.h + +/* + * FPGA program pin configuration on X600: + * + * Only PROG and DONE are connected to GPIOs. INIT is not connected to the + * SoC at all. And CLOCK and DATA are connected to the SSP2 port. We use + * 16bit serial writes via this SSP port to write the data bits into the + * FPGA. + */ +#define CONFIG_SYS_FPGA_PROG 2 +#define CONFIG_SYS_FPGA_DONE 3 + +/* + * Set the active-low FPGA
Re: [U-Boot] [u-boot] Adding missing CONFIG_SYS_CACHELINE_SIZE to boards definitions
Dear Lukasz,
Hi Jens and Helmut,
On Thu, Aug 23, 2012 at 10:13:13PM -, Lukasz Majewski wrote:
The restoration of GPT table (both primary and secondary) is now
possible. Simple GUID generation is supported.
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
While the changes are fine, tt01 and eb_cpux9k2 use CONFIG_PART_EFI
and do not set CONFIG_SYS_CACHELINE_SIZE and so fail to build after
this patch. tt01 is easily fixable (it relies on a non-exported
define elsewhere to 32) but the eb_cpu9k2 please contact the listed
board maintainer to get the define added.
Would it be possible to add the CONFIG_SYS_CACHELINE_SIZE
definition to ./include/configs/{tty01|eb_cpux9k2} boards definition?
The eb_cpux9k2 board based on at91rm9200 soc. This soc has currently no cache
implementation. So I think your run in this error.
The attached patch sets the define to the soc default.
We can also set #define CONFIG_SYS_DCACHE_OFF
regards Jens
From fe0e5e6d93e7f709fb058e7c3e551fca20191ddb Mon Sep 17 00:00:00 2001
From: Jens Scharsig (BuS Elektronik) e...@bus-elektronik.de
Date: Thu, 4 Oct 2012 10:11:38 +0200
Subject: [PATCH 2/2] * add CONFIG_SYS_CACLELINE_SIZE to eb_cpux9k2 board
Cc: e...@bus-elektronik.de, js_at...@scharsoft.de
Signed-off-by: Jens Scharsig (BuS Elektronik) e...@bus-elektronik.de
---
include/configs/eb_cpux9k2.h |4 +++-
1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
index 9371ec3..6dcd605 100644
--- a/include/configs/eb_cpux9k2.h
+++ b/include/configs/eb_cpux9k2.h
@@ -43,6 +43,9 @@
#define MACH_TYPE_EB_CPUX9K2 1977
#define CONFIG_MACH_TYPE MACH_TYPE_EB_CPUX9K2
+
+#define CONFIG_SYS_CACHELINE_SIZE 32
+
/*--*/
#ifndef CONFIG_RAMBOOT
#define CONFIG_SYS_TEXT_BASE 0x
@@ -56,7 +59,6 @@
#define CONFIG_SYS_U_BOOT_BASE PHYS_FLASH_1
#define CONFIG_SYS_U_BOOT_SIZE 0x6 /* 384 KBytes */
-
#define CONFIG_BOOT_RETRY_TIME 30
#define CONFIG_CMDLINE_EDITING
--
1.7.10.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ARM: increase lmb stack space reservation to 4KB
Hi Rob, On Thu, 28 Jun 2012 08:54:11 -0500, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com The bootm initrd image copy to ram can collide with the stack in cases where the print buffer size is large (i.e. 1K). The result is intermittent initrd decompression errors depending on the initrd size MOD 4KB since the initrd start address is 4KB aligned. Cc: Albert ARIBAUD albert.u.b...@aribaud.net Signed-off-by: Rob Herring rob.herr...@calxeda.com --- arch/arm/lib/bootm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index 599547d..999f201 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -69,8 +69,8 @@ void arch_lmb_reserve(struct lmb *lmb) sp = get_sp(); debug(## Current stack ends at 0x%08lx , sp); - /* adjust sp by 1K to be safe */ - sp -= 1024; + /* adjust sp by 4K to be safe */ + sp -= 4096; lmb_reserve(lmb, sp, gd-bd-bi_dram[0].start + gd-bd-bi_dram[0].size - sp); } Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 5/7] MAINTAINERS: Add Tetsuyuki Kobayshi for kzm9g
Hi Nohiburo, Tetsuyuki, On Fri, 20 Jul 2012 08:51:29 +0900, Nobuhiro Iwamatsu iwama...@nigauri.org wrote: Applied to my arm/rmobile branch. Thank you. Best regards, Nobuhiro Actually this did does not seem to have been applied to arm/rmobile, and was not in my patchwork todo either. Should I apply the patch directly in arm/master? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] arm: work around assembler bug
Hi Allen, On Wed, 18 Jul 2012 16:45:53 -0700, Allen Martin amar...@nvidia.com wrote: Disable sibling call optimization based on binutils version. This is to work around a bug in the assember in binutils versions 2.22. Branches to weak symbols can be incorrectly optimized in thumb mode to a short branch (b.n instruction) that won't reach when the symbol gets preempted. http://sourceware.org/bugzilla/show_bug.cgi?id=12532 Signed-off-by: Allen Martin amar...@nvidia.com --- changes for v4: -removed warning print changes for v3: -split shell line to improve readability changes for v2: -changed GAS_BUG_12532 from yes/no to y/n to be consistent -added additional warning about code size increase --- arch/arm/config.mk | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/config.mk b/arch/arm/config.mk index 3f4453a..24b9d7c 100644 --- a/arch/arm/config.mk +++ b/arch/arm/config.mk @@ -87,3 +87,21 @@ endif ifndef CONFIG_NAND_SPL LDFLAGS_u-boot += -pie endif + +# +# FIXME: binutils versions 2.22 have a bug in the assembler where +# branches to weak symbols can be incorrectly optimized in thumb mode +# to a short branch (b.n instruction) that won't reach when the symbol +# gets preempted +# +# http://sourceware.org/bugzilla/show_bug.cgi?id=12532 +# +ifeq ($(CONFIG_SYS_THUMB_BUILD),y) +ifeq ($(GAS_BUG_12532),) +export GAS_BUG_12532:=$(shell if [ $(call binutils-version) -lt 0222 ] ; \ + then echo y; else echo n; fi) +endif +ifeq ($(GAS_BUG_12532),y) +PLATFORM_RELFLAGS += -fno-optimize-sibling-calls +endif +endif Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] lcd: Fix fb offset calculation for bpix == 16 in BMP display
Hi Simon,
On 09/29/2012 03:11 AM, Simon Glass wrote:
From: Tom Wai-Hong Tam waih...@chromium.org
For bpix == 16, each pixel is 2-byte. fb offset should shift more x bytes.
Signed-off-by: Tom Wai-Hong Tam waih...@chromium.org
Signed-off-by: Simon Glass s...@chromium.org
---
common/lcd.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/lcd.c b/common/lcd.c
index 7c6cb09..004a6be 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -775,8 +775,10 @@ int lcd_display_bitmap(ulong bmp_image, int x, int y)
height = panel_info.vl_row - y;
bmap = (uchar *)bmp + le32_to_cpu(bmp-header.data_offset);
- fb = (uchar *) (lcd_base +
- (y + height - 1) * lcd_line_length + x * bpix / 8);
+ fb = (uchar *) (lcd_base + (y + height - 1) * lcd_line_length + x);
+ /* additional fb shift for bpix == 16 since each pixel is 2-byte */
+ if (bpix == 16)
+ fb += x;
Why is this change necessary? if bpix == 16 then x * bpix / 8 == 2 * x
anyway.
switch (bmp_bpix) {
case 1: /* pass through */
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Add a new ini command
On 10/03/12 23:15, Joe Hershberger wrote: This allows you to read ini-formatted data from anywhere and then import one of the sections into the environment This is based on rev 16 at http://code.google.com/p/inih/ Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- Changes in v2: - Documented in README - Made all functions static - Changed if statments to ternary operator selected parameters - Return any errors from ini_parse() to the shell README | 1 + common/Makefile | 1 + common/cmd_ini.c | 247 +++ 3 files changed, 249 insertions(+) create mode 100644 common/cmd_ini.c [...] diff --git a/common/cmd_ini.c b/common/cmd_ini.c new file mode 100644 index 000..652e4f6 --- /dev/null +++ b/common/cmd_ini.c @@ -0,0 +1,247 @@ +/* + * inih -- simple .INI file parser + * + * inih is released under the New BSD license (see LICENSE.txt). Go to the + * project home page for more info: + * + * http://code.google.com/p/inih/ Hmmm, I'm wondering, is it the appropriate license for U-Boot code? [...] -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot] Adding missing CONFIG_SYS_CACHELINE_SIZE to boards definitions
On 10/04/2012 09:18 AM, Lukasz Majewski wrote:
Hi Jens and Helmut,
On Thu, Aug 23, 2012 at 10:13:13PM -, Lukasz Majewski wrote:
The restoration of GPT table (both primary and secondary) is now
possible. Simple GUID generation is supported.
Signed-off-by: Lukasz Majewskil.majew...@samsung.com
Signed-off-by: Kyungmin Parkkyungmin.p...@samsung.com
While the changes are fine, tt01 and eb_cpux9k2 use CONFIG_PART_EFI
and do not set CONFIG_SYS_CACHELINE_SIZE and so fail to build after
this patch. tt01 is easily fixable (it relies on a non-exported
define elsewhere to 32) but the eb_cpu9k2 please contact the listed
board maintainer to get the define added.
Would it be possible to add the CONFIG_SYS_CACHELINE_SIZE
definition to ./include/configs/{tty01|eb_cpux9k2} boards definition?
It would help improving cache alignment and GPT development.
Thanks in advance
Hi Lukasz,
feel free to do the appropriate changes in the TT-01 platform code
(explicitly setting CACHELINE_SIZE), I'm currently too busy to do any
rebasing and testing on the board, we'll have to give it a time slice in
the near future (to have a few platform things changed) anyway.
Helmut
--
Scanned by MailScanner.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/11] ks8695 (cm4008, cm41xx) bugfixes, constant removals, configuration generalized
Hi Yann, On Thu, 9 Aug 2012 15:33:06 +0200, Yann Vernier yann.vern...@orsoc.se wrote: On Fri, 6 Jul 2012 13:33:42 +0200 Albert ARIBAUD albert.u.b...@aribaud.net wrote: Always a problem, those board config patches... :) I'll take this one in u-boot-arm/next, but later this week-end. if by Monday I haven't sent an 'applied' mail, ping me. I haven't seen an applied mail, nor a commit in the git, so I figure this is still not merged. I've since made an attempt at cleaning up the magic constants. Since this is fairly intrusive I have a much larger patch affecting the same sections. I've attempted to split it up, though some combinations of these patches will likely not be very useful. Yann Vernier (11): arm: ks8695: use defined constants for UART arm: ks8695: more macros for register values arm: ks8695eth: Use MAC address from environment arm: cm4008, cm41xx: use common cfi_flash support arm: cm4008, cm41xx: set gd-ram_size in dram_init arm: cm4008, cm41xx: Fix ROM relocation arm: ks8695/cm4008/cm41xx: Parameterize SDRAM arm: cm4008, cm41xx: don't define to 1 arm: ks8695/cm4xxx: don't reconfigure switch arm: ks8695: document bus speed arm: cm4008, cm41xx: read MAC address from flash arch/arm/cpu/arm920t/ks8695/lowlevel_init.S | 95 +++--- arch/arm/include/asm/arch-ks8695/platform.h | 55 ++-- arch/arm/include/asm/arch-ks8695/regvalues.h | 112 +++ board/cm4008/Makefile|2 +- board/cm4008/cm4008.c| 17 +- board/cm4008/config.mk |1 - board/cm4008/flash.c | 410 -- board/cm41xx/Makefile|2 +- board/cm41xx/cm41xx.c| 17 +- board/cm41xx/config.mk |1 - board/cm41xx/flash.c | 410 -- drivers/net/ks8695eth.c | 38 +-- include/configs/cm4008.h | 38 ++- include/configs/cm41xx.h | 32 +- 14 files changed, 305 insertions(+), 925 deletions(-) create mode 100644 arch/arm/include/asm/arch-ks8695/regvalues.h delete mode 100644 board/cm4008/config.mk delete mode 100644 board/cm4008/flash.c delete mode 100644 board/cm41xx/config.mk delete mode 100644 board/cm41xx/flash.c Sorry it took me so long to crawl my backlog... This series was posted with long lines folded apparently, which makes it impossible to process and explains why patchwork did not have all of it. Can you please repost it, this time using 'git send-email'? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] armv7 cpu_init_crit: Simplify code
Hi Benoît, On Sat, 11 Aug 2012 00:05:16 +0200 (CEST), Benoît Thébaudeau benoit.thebaud...@advansee.com wrote: We don't need to return to cpu_init_crit after calling lowlevel_init, so lowlevel_init can directly return to the caller of cpu_init_crit. Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com Cc: Albert Aribaud albert.u.b...@aribaud.net --- .../arch/arm/cpu/armv7/start.S |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S u-boot-4d3c95f/arch/arm/cpu/armv7/start.S index aee27fd..e8e533e 100644 --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S +++ u-boot-4d3c95f/arch/arm/cpu/armv7/start.S @@ -357,10 +357,7 @@ ENTRY(cpu_init_crit) * basic memory. Go here to bump up clock rate and handle * wake up conditions. */ - mov ip, lr @ persevere link reg across call - bl lowlevel_init @ go setup pll,mux,memory - mov lr, ip @ restore link - mov pc, lr @ back to my caller + b lowlevel_init @ go setup pll,mux,memory ENDPROC(cpu_init_crit) #endif Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] trats: Enable EXT4 and EFI partitions support on Samsung's Trats board
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
include/configs/trats.h |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/configs/trats.h b/include/configs/trats.h
index b3b5a3d..aaf64eb 100644
--- a/include/configs/trats.h
+++ b/include/configs/trats.h
@@ -104,6 +104,9 @@
#define CONFIG_CMD_FAT
#define CONFIG_FAT_WRITE
+/* EXT4 */
+#define CONFIG_CMD_EXT4
+
/* USB Composite download gadget - g_dnl */
#define CONFIG_USBDOWNLOAD_GADGET
#define CONFIG_DFU_FUNCTION
@@ -167,7 +170,7 @@
meminfo=crashkernel=32M@0x5000\0 \
nfsroot=/nfsroot/arm\0 \
bootblock= CONFIG_BOOTBLOCK \0 \
- loaduimage=fatload mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 uImage\0 \
+ loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 uImage\0 \
mmcdev=0\0 \
mmcbootpart=2\0 \
mmcrootpart=3\0 \
@@ -208,6 +211,7 @@
#define CONFIG_ENV_OFFSET ((32 - 4) 10) /* 32KiB - 4KiB */
#define CONFIG_DOS_PARTITION
+#define CONFIG_EFI_PARTITION
#define CONFIG_SYS_INIT_SP_ADDR(CONFIG_SYS_LOAD_ADDR -
GENERATED_GBL_DATA_SIZE)
#define CONFIG_SYS_CACHELINE_SIZE 32
--
1.7.2.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MPC85xx: remove support for TQM85xx boards
On 10/04/2012 11:36 AM, Wolfgang Denk wrote: Due to grown code sizes the TQM85xx boards don't build any more with some older tool chains (like ELDK 4.2). As these boards have long reached EOL it seems a waste of effort trying to fix them. The vendor has agreed to drop support for them, too. So let's get rid of them. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Stefan Roese s...@denx.de cc: Kim Phillips kim.phill...@freescale.com Acked-by: Stefan Roese s...@denx.de Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4 V2] doc: kerneldoc: Implant DocBook from Linux kernel
Hi Marek, Comments based on the assumption that we want to sync with the Linux tools. General comment/hypothetical question: would it not be simpler to patch the existing Linux tools in-place so that we can use them on the U-Boot tree? Detailed comments below in this spirit; ignore if suggestion above is stupid/complicated/plain wrong/other(specify...or not). On Sat, 29 Sep 2012 04:43:04 +0200, Marek Vasut ma...@denx.de wrote: Pull slightly modified version of Documentation/DocBook, the related perl script scripts/kernel-doc and the scripts/docproc.c from Linux kernel and implant it into U-Boot. This will allow smooth generation of kerneldoc style documentation. It was necessary to modify the DocBook/Makefile to work with U-Boot build system. The changes were only minor though and involved replacing the kbuild specific parts. Is it possible to make replace these changes with an if/then/else conditional based on an external option? That would make it possible to try and backmerge them into the Linux version of kerneldoc. It was also necessary to replace use of variables like KERNEL_VERSION with U_BOOT_VERSION, strings like Linux kernel with U-Boot Bootloader etc. so the generated result actually matches. Maybe make this change more general, i.e. replace KERNEL_VERSION with PROJECT_VERSION with a default value assuming Linux, make magic constant strings variables with a linux-friendly default, and make all those variables overridable from command line? We'd just have to have a small script to provide the U-Boot-sensible values. Finally, it was necessary to adjust docproc.c, since the documentation in U-Boot is located in doc/DocBook instead of Documentation/DocBook as is in case of the Linux kernel. Does it not make sense to drop the change above and instead, symlink doc/ to Documentation/? We could keep the symlink for one release then switch to a true rename for the release after. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Sandbox: Add spi driver to sandbox
From: Viktor Krivak viktor.kri...@gmail.com
Signed-off-by: Viktor Krivak viktor.kri...@gmail.com
---
Simple spi driver which only cache input data and send them back
on next call. Usefull for high level testing in sandbox.
drivers/spi/Makefile |1 +
drivers/spi/sandbox.c | 162 +
include/configs/sandbox.h |3 +
3 files changed, 166 insertions(+)
create mode 100644 drivers/spi/sandbox.c
diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
index f0b82c6..a3b44fd 100644
--- a/drivers/spi/Makefile
+++ b/drivers/spi/Makefile
@@ -46,6 +46,7 @@ COBJS-$(CONFIG_SH_SPI) += sh_spi.o
COBJS-$(CONFIG_FSL_ESPI) += fsl_espi.o
COBJS-$(CONFIG_TEGRA_SPI) += tegra_spi.o
COBJS-$(CONFIG_XILINX_SPI) += xilinx_spi.o
+COBJS-$(CONFIG_SANDBOX_SPI) += sandbox.o
COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
diff --git a/drivers/spi/sandbox.c b/drivers/spi/sandbox.c
new file mode 100644
index 000..d76e38cf
--- /dev/null
+++ b/drivers/spi/sandbox.c
@@ -0,0 +1,162 @@
+/*
+ * (C) Copyright 2012
+ * Viktor Krivak viktor.kri...@gmail.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include linux/types.h
+#include asm/errno.h
+#include spi.h
+#include malloc.h
+
+#ifndef CONFIG_SANDBOX_SPI_BUS_NUM
+ #define CONFIG_SANDBOX_SPI_BUS_NUM 1
+#endif
+
+#ifndef CONFIG_SANDBOX_SPI_CS_NUM
+ #define CONFIG_SANDBOX_SPI_CS_NUM 1
+#endif
+
+#ifndef CONFIG_SANDBOX_SPI_BUFFER_LEN
+ #define CONFIG_SANDBOX_SPI_BUFFER_LEN 32
+#endif
+
+static unsigned char spi_bus_claimed[CONFIG_SANDBOX_SPI_BUS_NUM];
+static unsigned char *buffer[CONFIG_SANDBOX_SPI_BUFFER_LEN];
+
+/*
+ * spi_init() - Init spi
+ *
+ * Empty function. No init in sandbox.
+ */
+void spi_init(void)
+{
+ /* Do nothing */
+}
+
+/*
+ * spi_cs_is_valid() - Check if bus and cs are valid number
+ *
+ * @bus: Bus id
+ * @cs: Chip select id
+ *
+ * Compare bus and cs against defined constant. Return 0 if everything is ok
+ * and other value on error.
+ */
+int spi_cs_is_valid(unsigned int bus, unsigned int cs)
+{
+ if (!(bus CONFIG_SANDBOX_SPI_BUS_NUM ||
+ cs CONFIG_SANDBOX_SPI_CS_NUM))
+ return -EINVAL;
+ else
+ return 0;
+}
+
+/*
+ * spi_setup() - Setup spi
+ *
+ * @bus:Bus id
+ * @cs: Chip select id
+ * @max_hz: Maximum SCK rate in Hz (ignored)
+ * @mode: Clock polarity, clock phase and other parameters(ignored)
+ *
+ * Check if bus and cs are valid and allocate memory for slave structure.
+ * Return pointer to slave stucture of NULL if something fail.
+ */
+struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
+ unsigned int max_hz, unsigned int mode)
+{
+ struct spi_slave *slave;
+ if (spi_cs_is_valid(bus, cs))
+ return NULL;
+ slave = malloc(sizeof(slave));
+ if (!slave)
+ return NULL;
+ slave-bus = bus;
+ slave-cs = cs;
+ return slave;
+}
+
+/*
+ * spi_claim_bus() - Claim bus
+ *
+ * @slave: Pointer to slave struct
+ *
+ * Check if slave struct contain valid data and claim bus for it. If bus
+ * already claimed return error. If everything ok return 0.
+ */
+int spi_claim_bus(struct spi_slave *slave)
+{
+ if (spi_cs_is_valid(slave-bus, slave-cs))
+ return -EINVAL;
+ if (!spi_bus_claimed[slave-bus]) {
+ spi_bus_claimed[slave-bus] = 1;
+ return 0;
+ }
+ return -EBUSY;
+}
+
+/*
+ * spi_release_bus() - Release claim on bus
+ *
+ * @slave: Pointer to slave struct
+ *
+ * Release claim on bus defined in slave struct
+ */
+void spi_release_bus(struct spi_slave *slave)
+{
+ if (spi_cs_is_valid(slave-bus, slave-cs))
+ return;
+ spi_bus_claimed[slave-bus] = 0;
+}
+
+/*
+ * spi_xfer() - Send data throw SPI
+ *
+ * @slave: Pointer to slave struct
+ * @bitlen: Number of send or received bits
+ * @dout: Pointer to send buffer
+ * @din:Pointer to receive buffer
+ * @flags: Flags for SPI(ignored)
+ *
+ * Return data that was send in prevois call. Copy din to internal buffer and
+ * copy internal buffer to dout. Use temp variable for case when din = dout.
+ */
+int spi_xfer(struct
Re: [U-Boot] [PATCH V3 00/32] Add mx6solo/mx6duallite support
Hi Troy, On Wed, 3 Oct 2012 18:47:02 -0700, Troy Kisky troy.ki...@boundarydevices.com wrote: This series goal is to add support for mx6solo and mx6duallite variants of mx6qsabrelite board. The new targets are called mx6ssabrelite and mx6dlsabrelite. If the boards are known as 'mx6solo' and 'mx6duallite', they should be named so rather than called yet another nickname. The 1st 16 patches perform cleanup on imximage The final 2 patches add support for expressions to mkimage. If found not to be worth the effort, they can be omitted. Troy Kisky (32): imximage: check dcd_len as entries added imximage: remove redundant setting of app_dest_ptr imximage: move flash_offset check to common location imximage: fix size of image to load. imximage: delay setting of image size imximage: change parameters to set_imx_hdr imximage: make set_imx_hdr_v1/v2 easier to read imximage: make header variable length imximage: remove static imximage_version imximage: prepare to move static variables to struct data_src imximage: change parameters for set_dcd_val/set_imx_hdr imximage: move set_imx_hdr to struct data_src imximage: move set_dcd_val to struct data_src imximage: enable word writes for version2 header tools: add parse_helper file imximage: use parse_helper functions imximage.cfg: run files through C preprocessor mx6q_4x_mt41j128.cfg: use symbols instead of hardcoded constants mx6q_4x_mt41j128.cfg: add comments mx6q_4x_mt41j128.cfg: use ddr3 mode for reset mx6q_4x_mt41j128.cfg: skip initiailizing non-existent memory mx6q_4x_mt41j128.cfg: force ZQ calibration mx6: soc: update get_cpu_rev and get_imx_type for mx6solo/sololite mx6: use CONFIG_MX6 instead of CONFIG_MX6Q imx-common: cpu: add imx_ddr_size arch-mx6: add mx6dl_pins.h mx6qsabrelite: add support for mx6 solo/duallite mx6q_4x_mt41j128.cfg: add mx6 solo/duallite support Add boards for sabrelite variants mx6s(solo) and mx6dl(duallite) mx6qsabrelite: change CONFIG_SYS_PROMPT parse_helper: add expression evaluation imx-mkimage.h: use base + offset syntax Makefile |3 +- arch/arm/cpu/armv7/mx6/soc.c | 32 +- arch/arm/imx-common/cpu.c | 66 +++- arch/arm/include/asm/arch-mx5/sys_proto.h | 10 +- arch/arm/include/asm/arch-mx6/imx-mkimage.h | 133 +++ arch/arm/include/asm/arch-mx6/imx-regs.h |2 + arch/arm/include/asm/arch-mx6/mx6dl_pins.h| 118 ++ arch/arm/include/asm/arch-mx6/sys_proto.h | 10 +- board/esg/ima3-mx53/imximage.cfg | 120 +++--- board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg | 425 - board/freescale/mx25pdk/imximage.cfg | 77 ++-- board/freescale/mx51evk/imximage.cfg | 114 +++--- board/freescale/mx53ard/imximage_dd3.cfg | 83 +++-- board/freescale/mx53evk/imximage.cfg | 86 ++--- board/freescale/mx53loco/imximage.cfg | 83 +++-- board/freescale/mx53smd/imximage.cfg | 83 +++-- board/freescale/mx6qarm2/imximage.cfg | 88 ++--- board/freescale/mx6qsabrelite/mx6qsabrelite.c | 235 +++- board/freescale/mx6qsabrelite/pads.h | 172 + board/genesi/mx51_efikamx/imximage_mx.cfg | 132 +++ board/genesi/mx51_efikamx/imximage_sb.cfg | 126 --- board/ttcontrol/vision2/imximage_hynix.cfg| 295 --- boards.cfg|4 +- drivers/gpio/mxc_gpio.c |6 +- drivers/video/ipu_regs.h |2 +- include/configs/mx6qarm2.h|1 + include/configs/mx6qsabre_common.h|1 + include/configs/mx6qsabrelite.h |4 +- tools/Makefile|2 + tools/imximage.c | 487 ++--- tools/imximage.h | 39 +- tools/parse_helper.c | 325 + tools/parse_helper.h | 28 ++ 33 files changed, 2106 insertions(+), 1286 deletions(-) create mode 100644 arch/arm/include/asm/arch-mx6/imx-mkimage.h create mode 100644 arch/arm/include/asm/arch-mx6/mx6dl_pins.h create mode 100644 board/freescale/mx6qsabrelite/pads.h create mode 100644 tools/parse_helper.c create mode 100644 tools/parse_helper.h Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Booting through nand flash with other address
Dear all, Yes i am using P1020RDb board. Actually i have to make 2 boot(u-boot) B1 and B2 B1 is stored 0x_,B2 is stored in 0x010_ of nand flash. when 1 power cycle is given Board gets booted from 0x_ my requirement is to boot B2 from 0x010_ how can i do that? Regards Manukumar On Wed, 2012-10-03 at 10:22 -0500, Scott Wood wrote: On 10/03/2012 07:24:35 AM, Manukumar wrote: Dear all, In u-boot(u-boot-2010.12) That's almost two years old. Please upgrade. 1) The TEXT_BASE address is 11001000. Judging from this you seem to be using either P1010RDB or P1023RDS (or maybe some out-of-tree board?). Always let us know what board you're talking about. 2) Nand Flash Erasing at Address 0x 3) Nand Flash Writing u-boot-nand.bin at address 0x 4) When Power is switched On the booting happens. till this there is no issue, now i want to change the booting address to different location(ex:0x0200) Because you don't have as much RAM on this board, or some other reason? do i want to change the TEXT_BASE address accordingly to boot it from 0x0200. like below, 1) The TEXT_BASE address is 0x0200. 2) Nand Flash Erasing at Address 0x0200 3) Nand Flash writing u-boot-nand.bin at address 0x0200 . Did you update other relevant variables such as CONFIG_SYS_NAND_U_BOOT_DST and CONFIG_SYS_NAND_U_BOOT_START? Plus you really should leave that 0x1000 offset in there. On mpc85xx NAND boot, TEXT_BASE is 4K after the start of the image, since the boot page comes first. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] lsxl: set ncip to broadcast address
-Original Message-
From: Michael Walle [mailto:mich...@walle.cc]
Sent: 03 October 2012 21:15
To: u-boot@lists.denx.de
Cc: Michael Walle; Prafulla Wadaskar
Subject: [PATCH] lsxl: set ncip to broadcast address
Instead of using the serverip we get from the DHCP server, use the
broadcast address. That way it isn't necessary to use a special DHCP
configuration to set the netconsole peer.
Signed-off-by: Michael Walle mich...@walle.cc
Cc: Prafulla Wadaskar prafu...@marvell.com
---
Hi Prafulla,
although it isn't a bugfix, it would be nice, if this patch made it
into
the 2012.10 release.
include/configs/lsxl.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
index 0db559c..663c5e2 100644
--- a/include/configs/lsxl.h
+++ b/include/configs/lsxl.h
@@ -146,7 +146,7 @@
config_nc_dhcp=setenv autoload_old ${autoload}; \
setenv autoload no\
bootp \
- setenv ncip ${serverip}\
+ setenv ncip 255.255.255.255\
Michael
Hard coding an ip-address is not recommended in u-boot environment.
I would need ack from Joe and Wolfgang to pull this patch.
Regards...
Prafulla . . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mtest: Print dcache state
Hi Tom, On Wed, 3 Oct 2012 15:05:21 -0700, Tom Rini tr...@ti.com wrote: On Mon, Aug 13, 2012 at 12:59:12AM -, Beno??t Th??baudeau wrote: mtest tests many types of memory accesses in many different conditions. If dcache is enabled, memory accesses are likely bursts, and some memory accesses are simply skipped. Hence, mtest results may change depending on dcache state. This patch prints the dcache state at the beginning of mtest so as to keep the user informed of the test conditions. Signed-off-by: Mike Frysinger vap...@gentoo.org Tested-by: Beno??t Th??baudeau benoit.thebaud...@advansee.com Cc: Wolfgang Denk w...@denx.de Cc: Mike Frysinger vap...@gentoo.org NAK, this breaks x86 which has no dcache_status. IIRC the general idea of printing the cache status in mtest had already been NAKed (though not formally) by Wolfgang. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mtest: Print dcache state
Hi Albert, Tom, On Thursday, October 4, 2012 1:03:48 PM, Albert ARIBAUD wrote: Hi Tom, On Wed, 3 Oct 2012 15:05:21 -0700, Tom Rini tr...@ti.com wrote: On Mon, Aug 13, 2012 at 12:59:12AM -, Beno??t Th??baudeau wrote: mtest tests many types of memory accesses in many different conditions. If dcache is enabled, memory accesses are likely bursts, and some memory accesses are simply skipped. Hence, mtest results may change depending on dcache state. This patch prints the dcache state at the beginning of mtest so as to keep the user informed of the test conditions. Signed-off-by: Mike Frysinger vap...@gentoo.org Tested-by: Beno??t Th??baudeau benoit.thebaud...@advansee.com Cc: Wolfgang Denk w...@denx.de Cc: Mike Frysinger vap...@gentoo.org NAK, this breaks x86 which has no dcache_status. IIRC the general idea of printing the cache status in mtest had already been NAKed (though not formally) by Wolfgang. Indeed. This subject has already been closed. Perhaps the patch status had just not been updated in Patchwork. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] lsxl: set ncip to broadcast address
On Thu, October 4, 2012 12:47, Prafulla Wadaskar wrote:
-Original Message-
From: Michael Walle [mailto:mich...@walle.cc]
Sent: 03 October 2012 21:15
To: u-boot@lists.denx.de
Cc: Michael Walle; Prafulla Wadaskar
Subject: [PATCH] lsxl: set ncip to broadcast address
Instead of using the serverip we get from the DHCP server, use the
broadcast address. That way it isn't necessary to use a special DHCP
configuration to set the netconsole peer.
Signed-off-by: Michael Walle mich...@walle.cc
Cc: Prafulla Wadaskar prafu...@marvell.com
---
Hi Prafulla,
although it isn't a bugfix, it would be nice, if this patch made it
into
the 2012.10 release.
include/configs/lsxl.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
index 0db559c..663c5e2 100644
--- a/include/configs/lsxl.h
+++ b/include/configs/lsxl.h
@@ -146,7 +146,7 @@
config_nc_dhcp=setenv autoload_old ${autoload}; \
setenv autoload no\
bootp \
- setenv ncip ${serverip}\
+ setenv ncip 255.255.255.255\
Michael
Hard coding an ip-address is not recommended in u-boot environment.
I would need ack from Joe and Wolfgang to pull this patch.
Hi Prafulla,
i wouldn't call 255.255.255.255 an IP address ;) i could actually unset
ncip. In that case the netconsole driver itself implicitly assumes the
255.255.255.255 broadcast address. I found my solution more transparent,
because you see the used target IP address at first sight.
But if you see the broadcast address as an hardcoded IP address, i'll
prepare another version of the patch with setenv ncip (unset) this
evening.
--
michael
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] lsxl: set ncip to broadcast address
-Original Message-
From: Michael Walle [mailto:mich...@walle.cc]
Sent: 04 October 2012 16:45
To: Prafulla Wadaskar
Cc: Michael Walle; u-boot@lists.denx.de; Joe Hershberger; Wolfgang
Denk
Subject: RE: [PATCH] lsxl: set ncip to broadcast address
On Thu, October 4, 2012 12:47, Prafulla Wadaskar wrote:
-Original Message-
From: Michael Walle [mailto:mich...@walle.cc]
Sent: 03 October 2012 21:15
To: u-boot@lists.denx.de
Cc: Michael Walle; Prafulla Wadaskar
Subject: [PATCH] lsxl: set ncip to broadcast address
Instead of using the serverip we get from the DHCP server, use the
broadcast address. That way it isn't necessary to use a special
DHCP
configuration to set the netconsole peer.
Signed-off-by: Michael Walle mich...@walle.cc
Cc: Prafulla Wadaskar prafu...@marvell.com
---
Hi Prafulla,
although it isn't a bugfix, it would be nice, if this patch made it
into
the 2012.10 release.
include/configs/lsxl.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
index 0db559c..663c5e2 100644
--- a/include/configs/lsxl.h
+++ b/include/configs/lsxl.h
@@ -146,7 +146,7 @@
config_nc_dhcp=setenv autoload_old ${autoload}; \
setenv autoload no\
bootp \
- setenv ncip ${serverip}\
+ setenv ncip 255.255.255.255\
Michael
Hard coding an ip-address is not recommended in u-boot environment.
I would need ack from Joe and Wolfgang to pull this patch.
Hi Prafulla,
i wouldn't call 255.255.255.255 an IP address ;) i could actually
unset
ncip. In that case the netconsole driver itself implicitly assumes the
255.255.255.255 broadcast address. I found my solution more
transparent,
because you see the used target IP address at first sight.
But if you see the broadcast address as an hardcoded IP address, i'll
prepare another version of the patch with setenv ncip (unset) this
evening.
I think that would be good :-)
Regards...
Prafulla . . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] v2012.10-rc2 tar balls on ftp
Great, thanks. Regards, Stephane -Original Message- From: Tom Rini [mailto:tom.r...@gmail.com] On Behalf Of Tom Rini Sent: woensdag 3 oktober 2012 22:33 To: John Rigby Cc: Deltour, Stephane; u-boot@lists.denx.de Subject: Re: [U-Boot] v2012.10-rc2 tar balls on ftp On Wed, Oct 03, 2012 at 02:25:58PM -0600, John Rigby wrote: On Wed, Oct 3, 2012 at 1:20 AM, Deltour, Stephane stephane.delt...@barco.com wrote: Hi, Would it be possible to have the v2012.10-rc1 and v2012.10-rc2 tarballs on the ftp site ? Have you tried the snapshots feature on the git.denx.de website? Note that snapshots are not stable in that they get flushed after a certain timeframe and re-created when needed so md5/sha256/etc will change. I've poked Detlev about adding tarballs to the FTP site. -- Tom DISCLAIMER: Unless indicated otherwise, the information contained in this message is privileged and confidential, and is intended only for the use of the addressee(s) named above and others who have been specifically authorized to receive it. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message and/or attachments is strictly prohibited. The company accepts no liability for any damage caused by any virus transmitted by this email. Furthermore, the company does not warrant a proper and complete transmission of this information, nor does it accept liability for any delays. If you have received this message in error, please contact the sender and delete the message. Thank you. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [ARM] [NOTICE] Branch u-boot-arm/master to be force-pushed
Hello, I had applied only one of the two patches in the assembler bug detection series, which made two boards die when they should not have. Thus I will rollback ARM master, insert the missing patch and force-push. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ARM] [NOTICE] Branch u-boot-arm/master to be force-pushed
Hello again, On Thu, 4 Oct 2012 14:13:55 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Hello, I had applied only one of the two patches in the assembler bug detection series, which made two boards die when they should not have. Thus I will rollback ARM master, insert the missing patch and force-push. Amicalement, master repaired and force-pushed. Old, incorrect commit ID was 02feea45396d5f1224d8d36af977550696f19f0a New, correct commit ID is 63ee53a7e9f5ec38e6a8e485d2b5f0119ff1c6d1 Apologies for the inconvenience. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] v2012.10-rc2 is now released
Hey all, We wanted to let you know that we tested this version on our CM-T35 and CM-T37 modules, and everything was in order. The tests included: * Various network tests via Ethernet: DHCP, ping, downloading file with TFTP, switching between ethernet controllers. * NAND tests: writing (sw and hw ecc), reading, switching between ecc types in between writes. * Accessing an EEPROM via I2C, switching between I2C busses. * Reading from MMC card. -- Regards, Nikita. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] lsxl: set ncip to broadcast address
Dear Prafulla Wadaskar,
In message f766e4f80769bd478052fb6533fa745d235d228...@sc-vexch4.marvell.com
you wrote:
--- a/include/configs/lsxl.h
+++ b/include/configs/lsxl.h
@@ -146,7 +146,7 @@
config_nc_dhcp=3Dsetenv autoload_old ${autoload}; \
setenv autoload no\
bootp \
-setenv ncip ${serverip}\
+setenv ncip 255.255.255.255\
Michael
Hard coding an ip-address is not recommended in u-boot environment.
I would need ack from Joe and Wolfgang to pull this patch.
not recommended is an understatement. not permitted is more
correct.
NAK.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Probably the best operating system in the world is the [operating
system] made for the PDP-11 by Bell Laboratories.
- Ted Nelson, October 1977
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/72 V3] serial: Massive rework of the serial subsystem
Dear Marek Vasut, In message 1348955586-7109-1-git-send-email-ma...@denx.de you wrote: This patchset is a STAGE 1 of preparation of the stdio and serial subsys for the driver model. Formal complaint: There is no change log. Actually none of the patches has any marker that it is a resubmit of earlier versions. The V3 in the cover letter is totally useless as this is NOT recorded in patchwork. Also, I think we disussed before NOT to cross-post between u-boot and u-boot-dm, didn't we? Normally, I would reject such a series for educational reasons. You are lucky that I don't have time to do any reviews recently. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Life, loathe it or ignore it, you can't like it. - Marvin the paranoid android ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm1136: cosmetic: Remove double test on CONFIG_SYS_DCACHE_OFF
Hi Benoît, On Tue, 14 Aug 2012 15:17:09 +0200 (CEST), Benoît Thébaudeau benoit.thebaud...@advansee.com wrote: Remove a redundant '#ifndef CONFIG_SYS_DCACHE_OFF' nested in the same #ifndef. Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com Cc: Albert Aribaud albert.u.b...@aribaud.net --- .../arch/arm/cpu/arm1136/cpu.c |2 -- 1 file changed, 2 deletions(-) diff --git u-boot-4d3c95f.orig/arch/arm/cpu/arm1136/cpu.c u-boot-4d3c95f/arch/arm/cpu/arm1136/cpu.c index b98e3d9..1136c1d 100644 --- u-boot-4d3c95f.orig/arch/arm/cpu/arm1136/cpu.c +++ u-boot-4d3c95f/arch/arm/cpu/arm1136/cpu.c @@ -146,9 +146,7 @@ void enable_caches(void) #ifndef CONFIG_SYS_ICACHE_OFF icache_enable(); #endif -#ifndef CONFIG_SYS_DCACHE_OFF dcache_enable(); -#endif } #else /* #ifndef CONFIG_SYS_DCACHE_OFF */ I'll NAK this one because: 1) obviously the big #ifndef CONFIG_SYS_DCACHE_OFF / #else /#endif is there to provide either working D$ functions or empty ones; 2) enable_caches() exists only in the then branch, not at all in the else branch, which makes it a surprising exception; 3) enable_caches() is the only function in the if/then/else acting on I$ as well as D$; ... so I suspect it did not actually belong in the big if/then/else in the first place and should not be modified but moved after the #endif. Please provide a V2 patch, I promise it'll get processed faster than this V1. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] v2012.10-rc2 tar balls on ftp
Hi Tom, On Wed, Oct 03, 2012 at 02:25:58PM -0600, John Rigby wrote: On Wed, Oct 3, 2012 at 1:20 AM, Deltour, Stephane stephane.delt...@barco.com wrote: Hi, Would it be possible to have the v2012.10-rc1 and v2012.10-rc2 tarballs on the ftp site ? Have you tried the snapshots feature on the git.denx.de website? Note that snapshots are not stable in that they get flushed after a certain timeframe and re-created when needed so md5/sha256/etc will change. I've poked Detlev about adding tarballs to the FTP site. I uploaded tarballs to the server. Thanks Detlev -- Modern methods of production have given us the possibility of ease and security for all; we have chosen, instead, to have overwork for some and starvation for others. -- Bertrand Russell -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mtest: Print dcache state
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/04/12 04:13, Benoît Thébaudeau wrote: Hi Albert, Tom, On Thursday, October 4, 2012 1:03:48 PM, Albert ARIBAUD wrote: Hi Tom, On Wed, 3 Oct 2012 15:05:21 -0700, Tom Rini tr...@ti.com wrote: On Mon, Aug 13, 2012 at 12:59:12AM -, Beno??t Th??baudeau wrote: mtest tests many types of memory accesses in many different conditions. If dcache is enabled, memory accesses are likely bursts, and some memory accesses are simply skipped. Hence, mtest results may change depending on dcache state. This patch prints the dcache state at the beginning of mtest so as to keep the user informed of the test conditions. Signed-off-by: Mike Frysinger vap...@gentoo.org Tested-by: Beno??t Th??baudeau benoit.thebaud...@advansee.com Cc: Wolfgang Denk w...@denx.de Cc: Mike Frysinger vap...@gentoo.org NAK, this breaks x86 which has no dcache_status. IIRC the general idea of printing the cache status in mtest had already been NAKed (though not formally) by Wolfgang. Indeed. This subject has already been closed. Perhaps the patch status had just not been updated in Patchwork. OK, thanks guys. - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQbZoJAAoJENk4IS6UOR1WIdQQAIIAUt0PU0r4VFcTCX6/X4sz ZprsyLtoqZrP4NI3cdO0bWELrOlyniEVwXrw4gNs+c86M+W76o/6XI62ug/JZGeP g10F9KCjpiQm4Uy3nV6PsmpPTN0uHxeiFbZUlmS4lqsPCFGOW2wAUIIgHbnfykv6 a8CSuO1ATHF5rNFw+Kgj2TX+NbI2Rjf/83cJoawLKqznONJVDHcIW02hS0YDi+c9 yHiqkRVu3RcrJO19zVcWYMeBo+2GejzeioV2W3F+O5d3XXr/AusBdOkotAasDlrF 1hv4ty2CWXpS6jardevdT/awD2zBI6ofd/lGUc9eHsjCJBVc5YPKK77A1AYyEWuq eJ2K9rHGiGdWf50TPIkyxtupfzNWMmtDlKOhUFiSwkLexjIbIRpRxHoa6Aj9BW7G PyYjo45P2iXAahUkhijZuF23g2rVQTq+7dBFA/Saz0GA5GwPoavolfu5UAkuYtpO rNZoYcN/LNHWZ/NIto6o2oqcTIvlcr2NfV9vQmGm31fHxjFOTznprTT/8YfhTKlX Lnsav21HI/UE5KNYDVlVyXLzxUiBubEFj/jxC7b31g3sYF0fTZKZyEO3b+ZoqKB2 hNsF6S3uiMGAtArUB3PaSavncQaI/kabZLKTBbzXTMx0UMDNuCSutJTzqcmlY9wC aVi1eIjjEZt2JTHPHFIn =OpC9 -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS
Hi José, On Fri, 14 Sep 2012 18:28:52 +0100, José Miguel Gonçalves jose.goncal...@inov.pt wrote: Jumping to board_init_r is not performed due to a bug on address computation. Relocation offsets are not needed when building SPL. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt --- Changes for v2: - None --- arch/arm/cpu/arm926ejs/start.S |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/cpu/arm926ejs/start.S b/arch/arm/cpu/arm926ejs/start.S index 6f05f1a..2da5342 100644 --- a/arch/arm/cpu/arm926ejs/start.S +++ b/arch/arm/cpu/arm926ejs/start.S @@ -325,7 +325,7 @@ _nand_boot_ofs: .word nand_boot #else ldr r0, _board_init_r_ofs - ldr r1, _TEXT_BASE + adr r1, _start add lr, r0, r1 add lr, lr, r9 /* setup parameters for board_init_r */ @@ -338,12 +338,14 @@ _board_init_r_ofs: .word board_init_r - _start #endif +#ifndef CONFIG_SPL_BUILD _rel_dyn_start_ofs: .word __rel_dyn_start - _start _rel_dyn_end_ofs: .word __rel_dyn_end - _start _dynsym_start_ofs: .word __dynsym_start - _start +#endif /* * Deferring decision on this one until after 2012.10. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/72 V3] serial: Massive rework of the serial subsystem
Dear Wolfgang Denk, Dear Marek Vasut, In message 1348955586-7109-1-git-send-email-ma...@denx.de you wrote: This patchset is a STAGE 1 of preparation of the stdio and serial subsys for the driver model. Formal complaint: There is no change log. Actually none of the patches has any marker that it is a resubmit of earlier versions. The V3 in the cover letter is totally useless as this is NOT recorded in patchwork. Yep, we made a formal agreement with Albert yesterday about learning patman ... so I did. Thus this one shall be the last troublesome patchset. Also, I think we disussed before NOT to cross-post between u-boot and u-boot-dm, didn't we? I cross-posted only the cover letter to give others notification. Normally, I would reject such a series for educational reasons. You are lucky that I don't have time to do any reviews recently. Best regards, Wolfgang Denk Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 00/32] Add mx6solo/mx6duallite support
On 10/04/2012 03:18 AM, Albert ARIBAUD wrote: Hi Troy, On Wed, 3 Oct 2012 18:47:02 -0700, Troy Kisky troy.ki...@boundarydevices.com wrote: This series goal is to add support for mx6solo and mx6duallite variants of mx6qsabrelite board. The new targets are called mx6ssabrelite and mx6dlsabrelite. If the boards are known as 'mx6solo' and 'mx6duallite', they should be named so rather than called yet another nickname. Hi Albert, I'm not sure I understand your comment. mx6solo and mx6duallite are the CPU names, not the board names. mx6dlsabrelite is a version of the SABRE Lite board containing the mx6duallite CPU instead of the mx6quad. We'll also be offering Nitrogen6X in mx6solo and mx6duallite variants. Regards, Eric ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: Add CONFIG_OF_BOARD_SETUP support to bootm
Hi Joe, On Fri, 17 Aug 2012 15:28:50 -0500, Joe Hershberger joe.hershber...@ni.com wrote: ARM boards need to change device tree settings as well Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- arch/arm/lib/bootm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index 599547d..2e0b0c1 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -258,6 +258,9 @@ static int create_fdt(bootm_headers_t *images) fixup_memory_node(*of_flat_tree); fdt_fixup_ethernet(*of_flat_tree); fdt_initrd(*of_flat_tree, *initrd_start, *initrd_end, 1); +#ifdef CONFIG_OF_BOARD_SETUP + ft_board_setup(*of_flat_tree, gd-bd); +#endif return 0; } Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 00/32] Add mx6solo/mx6duallite support
Hi Troy, On 10/03/2012 06:47 PM, Troy Kisky wrote: This series goal is to add support for mx6solo and mx6duallite variants of mx6qsabrelite board. The new targets are called mx6ssabrelite and mx6dlsabrelite. The 1st 16 patches perform cleanup on imximage The final 2 patches add support for expressions to mkimage. If found not to be worth the effort, they can be omitted. Troy Kisky (32): imximage: check dcd_len as entries added imximage: remove redundant setting of app_dest_ptr imximage: move flash_offset check to common location imximage: fix size of image to load. imximage: delay setting of image size imximage: change parameters to set_imx_hdr imximage: make set_imx_hdr_v1/v2 easier to read imximage: make header variable length imximage: remove static imximage_version imximage: prepare to move static variables to struct data_src imximage: change parameters for set_dcd_val/set_imx_hdr imximage: move set_imx_hdr to struct data_src imximage: move set_dcd_val to struct data_src imximage: enable word writes for version2 header tools: add parse_helper file imximage: use parse_helper functions imximage.cfg: run files through C preprocessor mx6q_4x_mt41j128.cfg: use symbols instead of hardcoded constants mx6q_4x_mt41j128.cfg: add comments mx6q_4x_mt41j128.cfg: use ddr3 mode for reset mx6q_4x_mt41j128.cfg: skip initiailizing non-existent memory mx6q_4x_mt41j128.cfg: force ZQ calibration mx6: soc: update get_cpu_rev and get_imx_type for mx6solo/sololite mx6: use CONFIG_MX6 instead of CONFIG_MX6Q imx-common: cpu: add imx_ddr_size arch-mx6: add mx6dl_pins.h mx6qsabrelite: add support for mx6 solo/duallite mx6q_4x_mt41j128.cfg: add mx6 solo/duallite support Add boards for sabrelite variants mx6s(solo) and mx6dl(duallite) mx6qsabrelite: change CONFIG_SYS_PROMPT parse_helper: add expression evaluation imx-mkimage.h: use base + offset syntax Makefile |3 +- arch/arm/cpu/armv7/mx6/soc.c | 32 +- arch/arm/imx-common/cpu.c | 66 +++- arch/arm/include/asm/arch-mx5/sys_proto.h | 10 +- arch/arm/include/asm/arch-mx6/imx-mkimage.h | 133 +++ arch/arm/include/asm/arch-mx6/imx-regs.h |2 + arch/arm/include/asm/arch-mx6/mx6dl_pins.h| 118 ++ arch/arm/include/asm/arch-mx6/sys_proto.h | 10 +- board/esg/ima3-mx53/imximage.cfg | 120 +++--- board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg | 425 - board/freescale/mx25pdk/imximage.cfg | 77 ++-- board/freescale/mx51evk/imximage.cfg | 114 +++--- board/freescale/mx53ard/imximage_dd3.cfg | 83 +++-- board/freescale/mx53evk/imximage.cfg | 86 ++--- board/freescale/mx53loco/imximage.cfg | 83 +++-- board/freescale/mx53smd/imximage.cfg | 83 +++-- board/freescale/mx6qarm2/imximage.cfg | 88 ++--- board/freescale/mx6qsabrelite/mx6qsabrelite.c | 235 +++- board/freescale/mx6qsabrelite/pads.h | 172 + board/genesi/mx51_efikamx/imximage_mx.cfg | 132 +++ board/genesi/mx51_efikamx/imximage_sb.cfg | 126 --- board/ttcontrol/vision2/imximage_hynix.cfg| 295 --- boards.cfg|4 +- drivers/gpio/mxc_gpio.c |6 +- drivers/video/ipu_regs.h |2 +- include/configs/mx6qarm2.h|1 + include/configs/mx6qsabre_common.h|1 + include/configs/mx6qsabrelite.h |4 +- tools/Makefile|2 + tools/imximage.c | 487 ++--- tools/imximage.h | 39 +- tools/parse_helper.c | 325 + tools/parse_helper.h | 28 ++ 33 files changed, 2106 insertions(+), 1286 deletions(-) create mode 100644 arch/arm/include/asm/arch-mx6/imx-mkimage.h create mode 100644 arch/arm/include/asm/arch-mx6/mx6dl_pins.h create mode 100644 board/freescale/mx6qsabrelite/pads.h create mode 100644 tools/parse_helper.c create mode 100644 tools/parse_helper.h There's clearly a lot going on in this patch set. Does it make sense to split this into parts that can be reviewed and checked separately? It seems that there are - bug fixes to imximage - enhancements to imximage - enhancements to build for imximage.cfg (CPP) - core i.MX6 changes (cpu types, etc) - rework of imximage.cfg files to use CPP ... And there's that simple one changing the prompt we can probably get a quick ack/nak on ;) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] env default -f -a crash with 2012.10-rc2
Hi,
env default -f -a crashes on ARM with last tree.
The reason is due to commit
commit b64b7c3df7906342ca8abe8ae31c0c12ced3f401
Author: Gerlando Falauto gerlando.fala...@keymile.com
Date: Fri Aug 24 00:11:41 2012 +
env: make env default selective, check and apply
that calls set_env_default() with do_apply=1.
Really the crash happens in lib/hashtable.c due to changes in
152874b65b8060e7b026933ce332a9687256e28c:
commit 152874b65b8060e7b026933ce332a9687256e28c
Author: Gerlando Falauto gerlando.fala...@keymile.com
Date: Fri Aug 24 00:11:40 2012 +
env: check and apply changes on delete/destroy
Signed-off-by: Gerlando Falauto gerlando.fala...@keymile.com
Reviewed-by: Marek Vasut ma...@denx.de
if (do_apply htab-apply != NULL) {
/* deletion is always forced */
htab-apply(ep-key, ep-data, NULL,
H_FORCE);
}
When htab-apply is called in hdestroy_r, it crashes. Has anybody see
the same issue ? Gerlando, what do you think about it ?
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv7] ARM: Add Altera SOCFPGA Cyclone5
Hi dingu...@altera.com, On Wed, 3 Oct 2012 15:38:01 -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Add minimal support for Altera's SOCFPGA Cyclone 5 hardware. Signed-off-by: Dinh Nguyen dingu...@altera.com Signed-off-by: Chin Liang See cl...@altera.com Signed-off-by: Pavel Machek pa...@denx.de Reviewed-by: Marek Vasut ma...@denx.de Acked-by: Tom Trini tr...@ti.com Cc: Wolfgang Denx w...@denx.de Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Stefan Roese s...@denx.de v7: fix build warning in spl.c:45:38 Based on v2012.10-rc2 --- MAINTAINERS|5 + arch/arm/cpu/armv7/socfpga/Makefile| 51 + arch/arm/cpu/armv7/socfpga/config.mk | 16 ++ arch/arm/cpu/armv7/socfpga/lowlevel_init.S | 77 +++ arch/arm/cpu/armv7/socfpga/misc.c | 54 + arch/arm/cpu/armv7/socfpga/spl.c | 48 arch/arm/cpu/armv7/socfpga/timer.c | 105 + arch/arm/cpu/armv7/socfpga/u-boot-spl.lds | 60 + arch/arm/include/asm/arch-socfpga/reset_manager.h | 37 +++ .../include/asm/arch-socfpga/socfpga_base_addrs.h | 27 +++ arch/arm/include/asm/arch-socfpga/spl.h| 26 +++ arch/arm/include/asm/arch-socfpga/timer.h | 29 +++ board/altera/socfpga_cyclone5/Makefile | 50 + board/altera/socfpga_cyclone5/socfpga_cyclone5.c | 80 +++ boards.cfg |1 + include/common.h |2 +- include/configs/socfpga_cyclone5.h | 236 17 files changed, 903 insertions(+), 1 deletion(-) create mode 100644 arch/arm/cpu/armv7/socfpga/Makefile create mode 100644 arch/arm/cpu/armv7/socfpga/config.mk create mode 100644 arch/arm/cpu/armv7/socfpga/lowlevel_init.S create mode 100644 arch/arm/cpu/armv7/socfpga/misc.c create mode 100644 arch/arm/cpu/armv7/socfpga/spl.c create mode 100644 arch/arm/cpu/armv7/socfpga/timer.c create mode 100644 arch/arm/cpu/armv7/socfpga/u-boot-spl.lds create mode 100644 arch/arm/include/asm/arch-socfpga/reset_manager.h create mode 100644 arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h create mode 100644 arch/arm/include/asm/arch-socfpga/spl.h create mode 100644 arch/arm/include/asm/arch-socfpga/timer.h create mode 100644 board/altera/socfpga_cyclone5/Makefile create mode 100644 board/altera/socfpga_cyclone5/socfpga_cyclone5.c create mode 100644 include/configs/socfpga_cyclone5.h diff --git a/MAINTAINERS b/MAINTAINERS index aa54fe1..ee8cfb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -777,6 +777,11 @@ Nagendra T S nagen...@mistralsolutions.com am3517_craneARM ARMV7 (AM35x SoC) +Dinh Nguyen dingu...@altera.com +Chin Liang See cl...@altera.com + + socfpga socfpga_cyclone5 + Sandeep Paulraj s-paul...@ti.com davinci_dm355evmARM926EJS diff --git a/arch/arm/cpu/armv7/socfpga/Makefile b/arch/arm/cpu/armv7/socfpga/Makefile new file mode 100644 index 000..376a4bd --- /dev/null +++ b/arch/arm/cpu/armv7/socfpga/Makefile @@ -0,0 +1,51 @@ +# +# (C) Copyright 2000-2003 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# Copyright (C) 2012 Altera Corporation www.altera.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(SOC).o + +SOBJS:= lowlevel_init.o +COBJS-y := misc.o timer.o +COBJS-$(CONFIG_SPL_BUILD) += spl.o + +COBJS:= $(COBJS-y) +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS)) + +all: $(obj).depend $(LIB) + +$(LIB): $(OBJS) + $(call cmd_link_o_target, $(OBJS)) + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/arch/arm/cpu/armv7/socfpga/config.mk b/arch/arm/cpu/armv7/socfpga/config.mk new file mode 100644 index
[U-Boot] [PATCHv8] ARM: Add Altera SOCFPGA Cyclone5
From: Dinh Nguyen dingu...@altera.com Add minimal support for Altera's SOCFPGA Cyclone 5 hardware. Signed-off-by: Dinh Nguyen dingu...@altera.com Signed-off-by: Chin Liang See cl...@altera.com Signed-off-by: Pavel Machek pa...@denx.de Reviewed-by: Marek Vasut ma...@denx.de Acked-by: Tom Trini tr...@ti.com Cc: Wolfgang Denx w...@denx.de Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Stefan Roese s...@denx.de v8: Remove no_return attribute for reset_cpu Based on v2012.10-rc2 --- MAINTAINERS|5 + arch/arm/cpu/armv7/socfpga/Makefile| 51 + arch/arm/cpu/armv7/socfpga/config.mk | 16 ++ arch/arm/cpu/armv7/socfpga/lowlevel_init.S | 77 +++ arch/arm/cpu/armv7/socfpga/misc.c | 54 + arch/arm/cpu/armv7/socfpga/spl.c | 48 arch/arm/cpu/armv7/socfpga/timer.c | 105 + arch/arm/cpu/armv7/socfpga/u-boot-spl.lds | 60 + arch/arm/include/asm/arch-socfpga/reset_manager.h | 37 +++ .../include/asm/arch-socfpga/socfpga_base_addrs.h | 27 +++ arch/arm/include/asm/arch-socfpga/spl.h| 26 +++ arch/arm/include/asm/arch-socfpga/timer.h | 29 +++ board/altera/socfpga_cyclone5/Makefile | 50 + board/altera/socfpga_cyclone5/socfpga_cyclone5.c | 80 +++ boards.cfg |1 + include/configs/socfpga_cyclone5.h | 236 16 files changed, 902 insertions(+) create mode 100644 arch/arm/cpu/armv7/socfpga/Makefile create mode 100644 arch/arm/cpu/armv7/socfpga/config.mk create mode 100644 arch/arm/cpu/armv7/socfpga/lowlevel_init.S create mode 100644 arch/arm/cpu/armv7/socfpga/misc.c create mode 100644 arch/arm/cpu/armv7/socfpga/spl.c create mode 100644 arch/arm/cpu/armv7/socfpga/timer.c create mode 100644 arch/arm/cpu/armv7/socfpga/u-boot-spl.lds create mode 100644 arch/arm/include/asm/arch-socfpga/reset_manager.h create mode 100644 arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h create mode 100644 arch/arm/include/asm/arch-socfpga/spl.h create mode 100644 arch/arm/include/asm/arch-socfpga/timer.h create mode 100644 board/altera/socfpga_cyclone5/Makefile create mode 100644 board/altera/socfpga_cyclone5/socfpga_cyclone5.c create mode 100644 include/configs/socfpga_cyclone5.h diff --git a/MAINTAINERS b/MAINTAINERS index aa54fe1..ee8cfb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -777,6 +777,11 @@ Nagendra T S nagen...@mistralsolutions.com am3517_craneARM ARMV7 (AM35x SoC) +Dinh Nguyen dingu...@altera.com +Chin Liang See cl...@altera.com + + socfpga socfpga_cyclone5 + Sandeep Paulraj s-paul...@ti.com davinci_dm355evmARM926EJS diff --git a/arch/arm/cpu/armv7/socfpga/Makefile b/arch/arm/cpu/armv7/socfpga/Makefile new file mode 100644 index 000..376a4bd --- /dev/null +++ b/arch/arm/cpu/armv7/socfpga/Makefile @@ -0,0 +1,51 @@ +# +# (C) Copyright 2000-2003 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# Copyright (C) 2012 Altera Corporation www.altera.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(SOC).o + +SOBJS := lowlevel_init.o +COBJS-y:= misc.o timer.o +COBJS-$(CONFIG_SPL_BUILD) += spl.o + +COBJS := $(COBJS-y) +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS)) + +all:$(obj).depend $(LIB) + +$(LIB):$(OBJS) + $(call cmd_link_o_target, $(OBJS)) + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/arch/arm/cpu/armv7/socfpga/config.mk b/arch/arm/cpu/armv7/socfpga/config.mk new file mode 100644 index 000..b72ed1e --- /dev/null +++ b/arch/arm/cpu/armv7/socfpga/config.mk @@ -0,0 +1,16 @@ +# +# Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/ +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU
Re: [U-Boot] [PATCH] tegra: move common features to a common makefile
On Wed, Oct 03, 2012 at 04:26:28PM +0200, Marc Dietrich wrote: For Non-Nvidia boards to include newly added features (like emc clock scaling) it would be necessary to add each feature to their own board Makefile. This is because currently the top Makefile automaticly includes these features only for Nvidia boards. This patch adds a simple Makefile include so all new features become available for non-Nvidia board vendors. Cc: Stephen Warren swar...@wwwdotorg.org Cc: Tom Warren twar...@nvidia.com Cc: Thierry Reding thierry.red...@avionic-design.de Cc: Lucas Stach d...@lynxeye.de Signed-off-by: Marc Dietrich marvi...@gmx.de --- Passed: MAKEALL -s tegra20, booted on paz00 --- board/avionic-design/medcom-wide/Makefile |6 -- board/avionic-design/plutux/Makefile |6 -- board/avionic-design/tec/Makefile |6 -- board/compal/paz00/Makefile |6 -- board/compulab/trimslice/Makefile |6 -- board/nvidia/common/Makefile |4 +--- board/nvidia/common/common.mk |4 7 files changed, 25 insertions(+), 13 deletions(-) create mode 100644 board/nvidia/common/common.mk Acked-by: Thierry Reding thierry.red...@avionic-design.de pgppfiCQhCE0P.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC] ARM: prevent misaligned array inits
On Tue, Oct 02, 2012 at 08:46:04PM +0200, Albert ARIBAUD wrote: Under option -munaligned-access, gcc can perform local char or 16-bit array initializations using misaligned native accesses which will throw a data abort exception. Fix files where these array initializations were unneeded, and for files known to contain such initializations, enforce gcc option -mno-unaligned-access. Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- Please test this patch with gcc 4.7 on boards which do data aborts or resets due to misaligned accesses and report result to me. I've tested this on TEC, on top of Tom's tegra/next branch. Without the patch, U-Boot hangs right after: Loading Device Tree to 010f9000, end 010ff2d4 ... OK With the patch applied the system boots to the login prompt, so: Tested-by: Thierry Reding thierry.red...@avionic-design.de pgpvcgojA3AYf.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm1136: cosmetic: Remove double test on CONFIG_SYS_DCACHE_OFF
Hi Albert,
On Thursday, October 4, 2012 3:39:41 PM, Albert ARIBAUD wrote:
Hi Benoît,
On Tue, 14 Aug 2012 15:17:09 +0200 (CEST), Benoît Thébaudeau
benoit.thebaud...@advansee.com wrote:
Remove a redundant '#ifndef CONFIG_SYS_DCACHE_OFF' nested in the
same #ifndef.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Albert Aribaud albert.u.b...@aribaud.net
---
.../arch/arm/cpu/arm1136/cpu.c |2 --
1 file changed, 2 deletions(-)
diff --git u-boot-4d3c95f.orig/arch/arm/cpu/arm1136/cpu.c
u-boot-4d3c95f/arch/arm/cpu/arm1136/cpu.c
index b98e3d9..1136c1d 100644
--- u-boot-4d3c95f.orig/arch/arm/cpu/arm1136/cpu.c
+++ u-boot-4d3c95f/arch/arm/cpu/arm1136/cpu.c
@@ -146,9 +146,7 @@ void enable_caches(void)
#ifndef CONFIG_SYS_ICACHE_OFF
icache_enable();
#endif
-#ifndef CONFIG_SYS_DCACHE_OFF
dcache_enable();
-#endif
}
#else /* #ifndef CONFIG_SYS_DCACHE_OFF */
I'll NAK this one because:
1) obviously the big #ifndef CONFIG_SYS_DCACHE_OFF / #else /#endif is
there to provide either working D$ functions or empty ones;
2) enable_caches() exists only in the then branch, not at all in
the
else branch, which makes it a surprising exception;
3) enable_caches() is the only function in the if/then/else acting on
I$
as well as D$;
... so I suspect it did not actually belong in the big if/then/else
in
the first place and should not be modified but moved after the
#endif.
I agree, simply because with the current code, enable_caches() does not enable
icache if CONFIG_SYS_ICACHE_OFF is not defined but CONFIG_SYS_DCACHE_OFF is.
But is it enough to move it? We could indeed move it after the #endif, but also
change it to:
---
#if !defined(CONFIG_SYS_ICACHE_OFF) || !defined(CONFIG_SYS_DCACHE_OFF)
void enable_caches(void)
{
#ifndef CONFIG_SYS_ICACHE_OFF
icache_enable();
#endif
#ifndef CONFIG_SYS_DCACHE_OFF
dcache_enable();
#endif
}
#endif
---
In that way, the default __enable_caches() from cache.c (outputting
WARNING: Caches not enabled\n) would be linked if both CONFIG_SYS_ICACHE_OFF
and CONFIG_SYS_DCACHE_OFF are defined.
Do you agree?
Please provide a V2 patch, I promise it'll get processed faster than
this V1.
OK ;) , I'll do that after your answer to the question above.
Best regards,
Benoît
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] lsxl: unset ncip for rescue mode
Instead of using the serverip we get from the DHCP server, implicitly use
the broadcast address, which is automatically set when no ncip environment
variable is set. That way it isn't necessary to use a special DHCP
configuration to set the netconsole peer.
Signed-off-by: Michael Walle mich...@walle.cc
Cc: Prafulla Wadaskar prafu...@marvell.com
---
The original patch subject was lsxl: set ncip to broadcast address.
v2:
- don't hardcode IP address
- adjust comments in lsxl.c
board/buffalo/lsxl/lsxl.c |5 ++---
include/configs/lsxl.h|2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/board/buffalo/lsxl/lsxl.c b/board/buffalo/lsxl/lsxl.c
index b3f31d6..8756abf 100644
--- a/board/buffalo/lsxl/lsxl.c
+++ b/board/buffalo/lsxl/lsxl.c
@@ -49,9 +49,8 @@
* you can do this only with a working network connection. Therefore, a random
* ethernet address is generated if none is set and a DHCP request is sent.
* After a successful DHCP response is received, the network settings are
- * configured and the ncip parameter is set to the serverip. Eg. for a working
- * resuce mode, you should set 'next-server' to the host where the netconsole
- * client is started.
+ * configured and the ncip is unset. Therefore, all netconsole packets are
+ * broadcasted.
* Additionally, the bootsource is set to 'rescue'.
*/
diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h
index 0db559c..86c4bce 100644
--- a/include/configs/lsxl.h
+++ b/include/configs/lsxl.h
@@ -146,7 +146,7 @@
config_nc_dhcp=setenv autoload_old ${autoload}; \
setenv autoload no\
bootp \
-setenv ncip ${serverip}\
+setenv ncip\
setenv autoload ${autoload_old}; \
setenv autoload_old\0 \
standard_env=setenv ipaddr; setenv netmask; setenv serverip; \
--
1.7.2.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request: u-boot-arm/master
Hi Tom, The following changes since commit 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8: sandbox: Add asm/errno.h (2012-09-29 10:00:29 -0700) are available in the git repository at: git://git.denx.de/u-boot-arm master for you to fetch changes up to 777544085d2b417a36df50eb564bf037a044e60e: ARM: Add Altera SOCFPGA Cyclone5 (2012-10-04 18:11:52 +0200) Albert ARIBAUD (5): Merge remote-tracking branch 'u-boot-atmel/master' Merge remote-tracking branch 'u-boot-imx/master' Merge remote-tracking branch 'u-boot/master' edminiv2: increase malloc len to 256K Merge remote-tracking branch 'u-boot-marvell/master' Allen Martin (2): tools, config.mk: add binutils-version arm: work around assembler bug Andreas Bießmann (1): devkit8000: add rootwait to mmcboot option Bastian Ruppert (6): davinci: ea20: reorganisation LCD startup davinci: ea20: the console is always set to the serial line video: cfb_console: logo can be positioned via the splashpos variable video: cfb_console: add function to plot the logo area black da850/omap-l138: davinci_emac: Suppress auto negotiation if needed davinci: ea20: add some configs and default environmet variables Benoît Thébaudeau (3): mx51evk: Add CONFIG_REVISION_TAG KARO TX25: Fix NAND Flash R/W cycle times armv7 cpu_init_crit: Simplify code Bo Shen (3): spi: add atmel at25df321 serial flash support spiflash: at25: using common spi flash operation Atmel: sam9g10/9m10/9x5: Add support to boot DT kernel Dinh Nguyen (2): ARM: kirkwood/orion5x: Use reset_cpu definition in include/common.h ARM: Add Altera SOCFPGA Cyclone5 Eric Nelson (2): i.MX: mxc_ipuv3_fb: add ipuv3_fb_shutdown() routine to stop IPU frame buffer i.MX: shut down video before launch of O/S Fabio Estevam (1): mx28evk: Remove fecmxc_mii_postcall() Gabriel Huau (2): ARM : Add GPIO Driver and IOMUX definition for S3C2440 ARM : Add support for MINI2440 (s3c2440). Gerlando Falauto (2): kirkwood: implement kw_sdram_bs_set() kirkwood: implement kw_sdram_size_adjust Hideyuki Sano (1): arm: rmobile: Add support for ATMARK-TECHNO Armadillo-800EVA board Holger Brunck (2): kirkwood: use c-struct for access to SDRAM addr decode registers arm/km: use kw_sdram_size_adjust to adjust SDRAM size Ilya Yanok (4): net/bootp: add VCI support for BOOTP also OMAP: spl: call timer_init() from SPL am335x_evm: enable networking in SPL OMAP: networking support for SPL Joe Hershberger (1): arm: Add CONFIG_OF_BOARD_SETUP support to bootm Joel A Fernandes (1): am33xx: Fix fetching of mmc1 bootmode from bootrom for AM33XX Koen Kooi (1): am335x-evm config: decrease bootdelay to 1s and mount rootfs RO Luka Perkov (2): kirkwood: fix mpp.h coding style kirkwood: add support for Iomega iConnect board Michael Walle (1): lsxl: also turn off fan in power down mode Michal Simek (4): arm: Remove additional config flags serial: Add Zynq serial driver arm: Support new Xilinx Zynq platform xilinx: Add new Zynq board Nobuhiro Iwamatsu (23): ARMv7: Add register definition of global timer arm: rmobile: Add basic support for Renesas R-Mobile arm: rmobile: Add support Renesas SH73A0 arm: rmobile: Add support PFC of Renesas SH73A0 arm: rmobile: Add supoprt for KMC KZM-A9-GT board arm: rmobile: Support build with gcc-4.6 or later arm: rmobile: kzm9g: Add LIBFDT support arm: rmobile: kzm9g: remove unrelated config arm: rmobile: Change initializing ICCICR register arm: rmobile: Add support TMU base timer function arm: rmobile: kzm9g: Add CONFIG_GLOBAL_TIMER to board config file arm: rmobile: Add support Renesas R8A7740 arm: rmobile: Add support PFC of Renesas R8A7740 arm: rmobile: armadillo-800eva Remove board_eth_init arm: rmobile: Add cpu_eth_init function rmobile: armadillo-800eva: Change init function of SCIFA1 rmobile: armadillo-800eva: Add Support CONFIG_OF_LIBFDT rmobile: armadillo-800eva: Add Support NFS and BOOTZ command rmobile: armadillo-800eva: Remove CONFIG_SYS_NO_L2CACHE rmobile: Add README doc/git-mailrc: Add 'rmobile' alias i2c: sh: Remove irq_wait function rmobile: Fix build timer driver with BUILD_DIR Otavio Salvador (1): mx28evk: Add missing 'setexpr' command Peter Meerwald (1): omap4_panda: remove CONFIG_PANDA, not used Ramesh Chandrasekaran (1): snowball: Clear UART RX FIFO Rob Herring (1): ARM: increase lmb stack space reservation to 4KB Simon Baatz (1): kirkwood: ib62x0: Invert SATA activity LEDs Simon Guinot (3): lacie_kw: add support for EFI partitions ARM: add support for Network Space v2 Lite and Mini ARM: add support
Re: [U-Boot] [PATCH v3 2/8] SPL: Port SPL framework to powerpc
On 10/04/2012 02:36:34 AM, Stefan Roese wrote:
On 10/02/2012 10:08 PM, Scott Wood wrote:
+void __noreturn jump_to_image_linux(void *arg)
+{
+ debug(Entering kernel arg pointer: 0x%p\n, arg);
+ typedef void (*image_entry_arg_t)(void *, ulong r4,
ulong r5,
ulong r6,
+ ulong r7, ulong r8,
ulong r9)
+ __attribute__ ((noreturn));
+ image_entry_arg_t image_entry =
+ (image_entry_arg_t)spl_image.entry_point;
+
+ image_entry(arg, 0, 0, EPAPR_MAGIC,
CONFIG_SYS_BOOTMAPSZ, 0, 0);
+}
At what point does the image get cache-flushed?
Not at all right now. MPC5200 has dcache disabled, at least in the
SPL.
Other PowerPC architectures might add a cache flush here if needed
at
some time. Okay?
Or they might forget to do so and have weird bugs.
Why not just call flush_cache() on the image now? Non-SPL does
this in
common code, not even PPC-specific.
Okay, probably better to add this code now. But shouldn't we add this
code to the common SPL framework code then? Right before calling
jump_to_image_linux()?
Sure, I didn't mean it should go here (it needs to be somewhere that
knows the image start/end, not just the entry point). This is just the
patch that prompted me to ask the question.
-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Booting through nand flash with other address
On 10/04/2012 05:18:57 AM, Manukumar wrote: Dear all, Yes i am using P1020RDb board. Note that there are (at least) two variants of this board, one using P1_P2_RDB and the other p1_p2_rdb_pc. Actually i have to make 2 boot(u-boot) B1 and B2 B1 is stored 0x_,B2 is stored in 0x010_ of nand flash. when 1 power cycle is given Board gets booted from 0x_ my requirement is to boot B2 from 0x010_ how can i do that? You can't. That's not what TEXT_BASE means. The hardware is only capable of booting from the beginning of NAND flash. At best you could have one SPL at the beginning of NAND flash that chooses which main U-Boot to load, but that is something you'd have to implement yourself. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v1] env: fix crash using default -f -a
newval pointer is not checked before its usage,
inside env_check_apply().
Signed-off-by: Stefano Babic sba...@denx.de
CC: gerlando.fala...@keymile.com
---
common/cmd_nvedit.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 3474bc6..8144c85 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -272,7 +272,7 @@ int env_check_apply(const char *name, const char *oldval,
/*
* Switch to new baudrate if new baudrate is supported
*/
- if (strcmp(name, baudrate) == 0) {
+ if ((strcmp(name, baudrate) == 0) (newval != NULL)) {
int baudrate = simple_strtoul(newval, NULL, 10);
int i;
for (i = 0; i N_BAUDRATES; ++i) {
@@ -308,12 +308,12 @@ int env_check_apply(const char *name, const char *oldval,
* Some variables should be updated when the corresponding
* entry in the environment is changed
*/
- if (strcmp(name, loadaddr) == 0) {
+ if ((strcmp(name, loadaddr) == 0) (newval != NULL)) {
load_addr = simple_strtoul(newval, NULL, 16);
return 0;
}
#if defined(CONFIG_CMD_NET)
- else if (strcmp(name, bootfile) == 0) {
+ else if ((strcmp(name, bootfile) == 0) (newval != NULL)) {
copy_filename(BootFile, newval, sizeof(BootFile));
return 0;
}
--
1.7.9.5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/6] fdt: Check error codes returned from fdtlib when loading ITB
Hi Jerry, On Fri, Aug 17, 2012 at 3:34 PM, Joe Hershberger joe.hershber...@ni.com wrote: Before this patch, error codes returned from fdtlib were ignored and continued access would cause a crash. Now just check if the image is truncated and error if so. Signed-off-by: Joe Hershberger joe.hershber...@ni.com --- What's the progress on this series? I know Mike didn't like the last patch (6 of 6), but the first 5 should be good to go. I'd like them to be in the 2012.10 release. Are you able to apply them through your branch? Or maybe ack and go through Tom? Thanks, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] tools: Add a README note about fw_printenv lock file
Add a mention of the lock file to the README for the fw_printenv tool. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reported-by: Luka Perkov ub...@lukaperkov.net --- This patch is independent of the series, but should be applied afterward tools/env/README | 4 1 file changed, 4 insertions(+) diff --git a/tools/env/README b/tools/env/README index 3f0d77e..df020e4 100644 --- a/tools/env/README +++ b/tools/env/README @@ -55,3 +55,7 @@ partition where the environment resides. DEVICEx_ENVSECTORS defines the number of sectors that may be used for this environment instance. On NAND this is used to limit the range within which bad blocks are skipped, on NOR it is not used. + +To prevent losing changes to the environment and to prevent confusing the MTD +drivers, a lock file at /var/lock/fw_printenv.lock is used to serialize access +to the environment. -- 1.7.11.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-arm/master
On Thu, Oct 04, 2012 at 06:57:02PM +0200, Albert ARIBAUD wrote: Hi Tom, The following changes since commit 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8: sandbox: Add asm/errno.h (2012-09-29 10:00:29 -0700) are available in the git repository at: git://git.denx.de/u-boot-arm master for you to fetch changes up to 777544085d2b417a36df50eb564bf037a044e60e: ARM: Add Altera SOCFPGA Cyclone5 (2012-10-04 18:11:52 +0200) Albert ARIBAUD (5): Merge remote-tracking branch 'u-boot-atmel/master' Merge remote-tracking branch 'u-boot-imx/master' Merge remote-tracking branch 'u-boot/master' edminiv2: increase malloc len to 256K Merge remote-tracking branch 'u-boot-marvell/master' Allen Martin (2): tools, config.mk: add binutils-version arm: work around assembler bug Andreas Bie??mann (1): devkit8000: add rootwait to mmcboot option Bastian Ruppert (6): davinci: ea20: reorganisation LCD startup davinci: ea20: the console is always set to the serial line video: cfb_console: logo can be positioned via the splashpos variable video: cfb_console: add function to plot the logo area black da850/omap-l138: davinci_emac: Suppress auto negotiation if needed davinci: ea20: add some configs and default environmet variables Beno??t Th??baudeau (3): mx51evk: Add CONFIG_REVISION_TAG KARO TX25: Fix NAND Flash R/W cycle times armv7 cpu_init_crit: Simplify code Bo Shen (3): spi: add atmel at25df321 serial flash support spiflash: at25: using common spi flash operation Atmel: sam9g10/9m10/9x5: Add support to boot DT kernel Dinh Nguyen (2): ARM: kirkwood/orion5x: Use reset_cpu definition in include/common.h ARM: Add Altera SOCFPGA Cyclone5 Eric Nelson (2): i.MX: mxc_ipuv3_fb: add ipuv3_fb_shutdown() routine to stop IPU frame buffer i.MX: shut down video before launch of O/S Fabio Estevam (1): mx28evk: Remove fecmxc_mii_postcall() Gabriel Huau (2): ARM : Add GPIO Driver and IOMUX definition for S3C2440 ARM : Add support for MINI2440 (s3c2440). Gerlando Falauto (2): kirkwood: implement kw_sdram_bs_set() kirkwood: implement kw_sdram_size_adjust Hideyuki Sano (1): arm: rmobile: Add support for ATMARK-TECHNO Armadillo-800EVA board Holger Brunck (2): kirkwood: use c-struct for access to SDRAM addr decode registers arm/km: use kw_sdram_size_adjust to adjust SDRAM size Ilya Yanok (4): net/bootp: add VCI support for BOOTP also OMAP: spl: call timer_init() from SPL am335x_evm: enable networking in SPL OMAP: networking support for SPL Joe Hershberger (1): arm: Add CONFIG_OF_BOARD_SETUP support to bootm Joel A Fernandes (1): am33xx: Fix fetching of mmc1 bootmode from bootrom for AM33XX Koen Kooi (1): am335x-evm config: decrease bootdelay to 1s and mount rootfs RO Luka Perkov (2): kirkwood: fix mpp.h coding style kirkwood: add support for Iomega iConnect board Michael Walle (1): lsxl: also turn off fan in power down mode Michal Simek (4): arm: Remove additional config flags serial: Add Zynq serial driver arm: Support new Xilinx Zynq platform xilinx: Add new Zynq board Nobuhiro Iwamatsu (23): ARMv7: Add register definition of global timer arm: rmobile: Add basic support for Renesas R-Mobile arm: rmobile: Add support Renesas SH73A0 arm: rmobile: Add support PFC of Renesas SH73A0 arm: rmobile: Add supoprt for KMC KZM-A9-GT board arm: rmobile: Support build with gcc-4.6 or later arm: rmobile: kzm9g: Add LIBFDT support arm: rmobile: kzm9g: remove unrelated config arm: rmobile: Change initializing ICCICR register arm: rmobile: Add support TMU base timer function arm: rmobile: kzm9g: Add CONFIG_GLOBAL_TIMER to board config file arm: rmobile: Add support Renesas R8A7740 arm: rmobile: Add support PFC of Renesas R8A7740 arm: rmobile: armadillo-800eva Remove board_eth_init arm: rmobile: Add cpu_eth_init function rmobile: armadillo-800eva: Change init function of SCIFA1 rmobile: armadillo-800eva: Add Support CONFIG_OF_LIBFDT rmobile: armadillo-800eva: Add Support NFS and BOOTZ command rmobile: armadillo-800eva: Remove CONFIG_SYS_NO_L2CACHE rmobile: Add README doc/git-mailrc: Add 'rmobile' alias i2c: sh: Remove irq_wait function rmobile: Fix build timer driver with BUILD_DIR Otavio Salvador (1): mx28evk: Add missing 'setexpr' command Peter Meerwald (1): omap4_panda: remove CONFIG_PANDA, not used Ramesh Chandrasekaran (1): snowball: Clear UART RX FIFO Rob Herring (1): ARM: increase lmb stack space reservation to 4KB Simon
Re: [U-Boot] [RFC] ARM: prevent misaligned array inits
Hi Albert,
Am Dienstag, den 02.10.2012, 20:46 +0200 schrieb Albert ARIBAUD:
Under option -munaligned-access, gcc can perform local char
or 16-bit array initializations using misaligned native
accesses which will throw a data abort exception. Fix files
where these array initializations were unneeded, and for
files known to contain such initializations, enforce gcc
option -mno-unaligned-access.
Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net
---
Please test this patch with gcc 4.7 on boards which do data aborts
or resets due to misaligned accesses and report result to me.
Although, as you know, I don't like the general direction in which this
is heading you get a
Tested-by: Lucas Stach d...@lynxeye.de
As it at least allows for a booting machine in various configurations on
my Colibri T20.
arch/arm/cpu/arm926ejs/orion5x/cpu.c |4 +-
board/ti/omap2420h4/sys_info.c | 24 -
common/Makefile |3 ++
common/cmd_dfu.c |2 +-
doc/README.arm-unaligned-accesses| 95
++
fs/fat/Makefile |2 +
fs/ubifs/Makefile|3 ++
lib/Makefile |3 ++
8 files changed, 121 insertions(+), 15 deletions(-)
create mode 100644 doc/README.arm-unaligned-accesses
diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
index c3948d3..5a4775a 100644
--- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
+++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
@@ -194,8 +194,8 @@ u32 orion5x_device_rev(void)
*/
int print_cpuinfo(void)
{
- char dev_str[] = 0x;
- char rev_str[] = 0x00;
+ char dev_str[7]; /* room enough for 0x plus null byte */
+ char rev_str[5]; /* room enough for 0x00 plus null byte */
char *dev_name = NULL;
char *rev_name = NULL;
diff --git a/board/ti/omap2420h4/sys_info.c b/board/ti/omap2420h4/sys_info.c
index a9f7241..b462aa5 100644
--- a/board/ti/omap2420h4/sys_info.c
+++ b/board/ti/omap2420h4/sys_info.c
@@ -237,18 +237,18 @@ u32 wait_on_value(u32 read_bit_mask, u32 match_value,
u32 read_addr, u32 bound)
*/
void display_board_info(u32 btype)
{
- char cpu_2420[] = 2420; /* cpu type */
- char cpu_2422[] = 2422;
- char cpu_2423[] = 2423;
- char db_men[] = Menelaus; /* board type */
- char db_ip[] = IP;
- char mem_sdr[] = mSDR;/* memory type */
- char mem_ddr[] = mDDR;
- char t_tst[] = TST; /* security level */
- char t_emu[] = EMU;
- char t_hs[] = HS;
- char t_gp[] = GP;
- char unk[] = ?;
+ char *cpu_2420 = 2420; /* cpu type */
+ char *cpu_2422 = 2422;
+ char *cpu_2423 = 2423;
+ char *db_men = Menelaus; /* board type */
+ char *db_ip = IP;
+ char *mem_sdr = mSDR;/* memory type */
+ char *mem_ddr = mDDR;
+ char *t_tst = TST;/* security level */
+ char *t_emu = EMU;
+ char *t_hs = HS;
+ char *t_gp = GP;
+ char *unk = ?;
char *cpu_s, *db_s, *mem_s, *sec_s;
u32 cpu, rev, sec;
diff --git a/common/Makefile b/common/Makefile
index 125b2be..19b2130 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -227,6 +227,9 @@ $(obj)env_embedded.o: $(src)env_embedded.c
$(obj)../tools/envcrc
$(obj)../tools/envcrc:
$(MAKE) -C ../tools
+$(obj)hush.o: CFLAGS += -mno-unaligned-access
+$(obj)fdt_support.o: CFLAGS += -mno-unaligned-access
+
#
# defines $(obj).depend target
diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
index 62fb890..01d6b3a 100644
--- a/common/cmd_dfu.c
+++ b/common/cmd_dfu.c
@@ -30,7 +30,7 @@
static int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
const char *str_env;
- char s[] = dfu;
+ char *s = dfu;
char *env_bkp;
int ret;
diff --git a/doc/README.arm-unaligned-accesses
b/doc/README.arm-unaligned-accesses
new file mode 100644
index 000..00fb1c0
--- /dev/null
+++ b/doc/README.arm-unaligned-accesses
@@ -0,0 +1,95 @@
+Since U-Boot runs on a variety of hardware, some only able to perform
+unaligned accesses with a strong penalty, some unable to perform them
+at all, the policy regarding unaligned accesses is to not perform any,
+unless absolutely necessary because of hardware or standards.
+
+Also, on hardware which permits it, the core is configured to throw
+data abort exceptions on unaligned accesses in order to catch these
+unallowed accesses as early as possible.
+
+Until version 4.7, the gcc default for performing unaligned accesses
+(-mno-unaligned-access) is to emulate unaligned accesses using aligned
+loads and stores plus shifts and masks. Emulated unaligned accesses
+will not be caught by hardware. These
[U-Boot] [PATCH 2/3] nitrogen6x: configure and toggle PHY reset for Nitrogen6x
Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com
---
board/boundary/nitrogen6x/nitrogen6x.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/board/boundary/nitrogen6x/nitrogen6x.c
b/board/boundary/nitrogen6x/nitrogen6x.c
index e70871d..469a044 100644
--- a/board/boundary/nitrogen6x/nitrogen6x.c
+++ b/board/boundary/nitrogen6x/nitrogen6x.c
@@ -174,6 +174,7 @@ iomux_v3_cfg_t const enet_pads1[] = {
MX6Q_PAD_RGMII_RX_CTL__GPIO_6_24| MUX_PAD_CTRL(NO_PAD_CTRL),
/* pin 42 PHY nRST */
MX6Q_PAD_EIM_D23__GPIO_3_23 | MUX_PAD_CTRL(NO_PAD_CTRL),
+ MX6Q_PAD_ENET_RXD0__GPIO_1_27 | MUX_PAD_CTRL(NO_PAD_CTRL),
};
iomux_v3_cfg_t const enet_pads2[] = {
@@ -203,7 +204,8 @@ static iomux_v3_cfg_t const button_pads[] = {
static void setup_iomux_enet(void)
{
- gpio_direction_output(IMX_GPIO_NR(3, 23), 0);
+ gpio_direction_output(IMX_GPIO_NR(3, 23), 0); /* SABRE Lite PHY rst */
+ gpio_direction_output(IMX_GPIO_NR(1, 27), 0); /* Nitrogen6X PHY rst */
gpio_direction_output(IMX_GPIO_NR(6, 30), 1);
gpio_direction_output(IMX_GPIO_NR(6, 25), 1);
gpio_direction_output(IMX_GPIO_NR(6, 27), 1);
@@ -214,7 +216,8 @@ static void setup_iomux_enet(void)
/* Need delay 10ms according to KSZ9021 spec */
udelay(1000 * 10);
- gpio_set_value(IMX_GPIO_NR(3, 23), 1);
+ gpio_set_value(IMX_GPIO_NR(3, 23), 1); /* SABRE Lite PHY reset */
+ gpio_set_value(IMX_GPIO_NR(1, 27), 1); /* Nitrogen6X PHY reset */
imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
}
--
1.7.9
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/3] Add support for the Boundary Devices Nitrogen6x board
This series defines a board type for Nitrogen6X, an SBC from Boundary Devices. The board is closely related to the Freescale SABRE Lite board as discussed in this document. http://boundarydevices.com/differences-sabre-lite-nitrogen6x-and-som/ Because of the similarity, a Nitrogen6X U-Boot image will run on the SABRE Lite board, and auto-detection is included. This patch set is broken up into three pieces to expose the functional differences between the boards. The first patch essentially copies board/freescale/mx6qsabrelite to board/boundary/nitrogen6x but does alter the settings file include/configs/nitrogen6x to reflect boot-from-SPI and storage of environment variables in SPI NOR. It also contains an updated README describing the board's usage. The second patch reflects the change in PHY reset, and the third sets up the pads for the WL1271 Wi-Fi/Bluetooth option on a Nitrogen6x. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] nitrogen6x: initialize WL12XX pads, use to determine board type
Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com
---
board/boundary/nitrogen6x/nitrogen6x.c | 34 +++-
1 files changed, 33 insertions(+), 1 deletions(-)
diff --git a/board/boundary/nitrogen6x/nitrogen6x.c
b/board/boundary/nitrogen6x/nitrogen6x.c
index 469a044..16469b7 100644
--- a/board/boundary/nitrogen6x/nitrogen6x.c
+++ b/board/boundary/nitrogen6x/nitrogen6x.c
@@ -69,6 +69,18 @@ DECLARE_GLOBAL_DATA_PTR;
PAD_CTL_DSE_40ohm | PAD_CTL_HYS | \
PAD_CTL_ODE | PAD_CTL_SRE_FAST)
+#define WEAK_PULLUP(PAD_CTL_PKE | PAD_CTL_PUE |\
+ PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED | \
+ PAD_CTL_DSE_40ohm | PAD_CTL_HYS | \
+ PAD_CTL_SRE_SLOW)
+
+#define WEAK_PULLDOWN (PAD_CTL_PKE | PAD_CTL_PUE |\
+ PAD_CTL_PUS_100K_DOWN | PAD_CTL_SPEED_MED | \
+ PAD_CTL_DSE_40ohm | PAD_CTL_HYS | \
+ PAD_CTL_SRE_SLOW)
+
+#define OUTPUT_40OHM (PAD_CTL_SPEED_MED|PAD_CTL_DSE_40ohm)
+
int dram_init(void)
{
gd-ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
@@ -186,6 +198,16 @@ iomux_v3_cfg_t const enet_pads2[] = {
MX6Q_PAD_RGMII_RX_CTL__RGMII_RX_CTL | MUX_PAD_CTRL(ENET_PAD_CTRL),
};
+/* wl1271 pads on nitrogen6x */
+iomux_v3_cfg_t const wl12xx_pads[] = {
+ (MX6Q_PAD_NANDF_CS1__GPIO_6_14 ~MUX_PAD_CTRL_MASK) |
MUX_PAD_CTRL(WEAK_PULLDOWN),
+ (MX6Q_PAD_NANDF_CS2__GPIO_6_15 ~MUX_PAD_CTRL_MASK) |
MUX_PAD_CTRL(OUTPUT_40OHM),
+ (MX6Q_PAD_NANDF_CS3__GPIO_6_16 ~MUX_PAD_CTRL_MASK) |
MUX_PAD_CTRL(OUTPUT_40OHM),
+};
+#define WL12XX_WL_IRQ_GP IMX_GPIO_NR(6,14)
+#define WL12XX_WL_ENABLE_GPIMX_GPIO_NR(6,15)
+#define WL12XX_BT_ENABLE_GPIMX_GPIO_NR(6,16)
+
/* Button assignments for J14 */
static iomux_v3_cfg_t const button_pads[] = {
/* Menu */
@@ -695,6 +717,13 @@ static void setup_display(void)
int board_early_init_f(void)
{
setup_iomux_uart();
+
+ /* Disable wl1271 For Nitrogen6w */
+ gpio_direction_input(WL12XX_WL_IRQ_GP);
+ gpio_direction_output(WL12XX_WL_ENABLE_GP,0);
+ gpio_direction_output(WL12XX_BT_ENABLE_GP,0);
+
+ imx_iomux_v3_setup_multiple_pads(wl12xx_pads, ARRAY_SIZE(wl12xx_pads));
setup_buttons();
#if defined(CONFIG_VIDEO_IPUV3)
@@ -733,7 +762,10 @@ int board_init(void)
int checkboard(void)
{
- puts(Board: Nitrogen6X or MX6Q-Sabre Lite\n);
+ if (gpio_get_value(WL12XX_WL_IRQ_GP)) {
+ puts(Board: Nitrogen6X\n);
+ } else
+ puts(Board: SABRE Lite\n);
return 0;
}
--
1.7.9
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] Add nitrogen6x board
Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com --- board/boundary/nitrogen6x/Makefile | 41 ++ board/boundary/nitrogen6x/README | 77 +++ board/boundary/nitrogen6x/nitrogen6x.c | 840 boards.cfg |1 + include/configs/nitrogen6x.h | 242 + 5 files changed, 1201 insertions(+), 0 deletions(-) create mode 100644 board/boundary/nitrogen6x/Makefile create mode 100644 board/boundary/nitrogen6x/README create mode 100644 board/boundary/nitrogen6x/nitrogen6x.c create mode 100644 include/configs/nitrogen6x.h diff --git a/board/boundary/nitrogen6x/Makefile b/board/boundary/nitrogen6x/Makefile new file mode 100644 index 000..63da7d0 --- /dev/null +++ b/board/boundary/nitrogen6x/Makefile @@ -0,0 +1,41 @@ +# +# Copyright (C) 2012, Guennadi Liakhovetski l...@denx.de +# +# (C) Copyright 2012 Freescale Semiconductor, Inc. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).o + +COBJS := nitrogen6x.o + +SRCS := $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) + +$(LIB):$(obj).depend $(OBJS) + $(call cmd_link_o_target, $(OBJS)) + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/boundary/nitrogen6x/README b/board/boundary/nitrogen6x/README new file mode 100644 index 000..d67cdf0 --- /dev/null +++ b/board/boundary/nitrogen6x/README @@ -0,0 +1,77 @@ +U-Boot for the Boundary Devices Nitrogen6X and +Freescale i.MX6q SabreLite boards + +This file contains information for the port of +U-Boot to the Boundary Devices Nitrogen6X and +Freescale i.MX6q SabreLite boards. + +1. Boot source, boot from SPI NOR +- +The configuration in this directory supports both the +Nitrogen6X and Freescale SabreLite board, but in a +different fashion from Freescale's implementation in +board/freescale/mx6qsabrelite. + +In particular, this image supports booting from SPI NOR +and saving the environment to SPI NOR. + +It does not support 'boot from SD' at offset 0x400 +except through the 'bmode' command. + http://lists.denx.de/pipermail/u-boot/2012-August/131151.html + +2. Boots using 6q_bootscript on SATA or SD card +--- +The default bootcmd for these boards is configured +to look for and source a boot script named '6q_bootscript' +in the root of the first partition of the following +devices: + + sata 0 + mmc 0 + mmc 1 + +They're searched in the order listed above, trying both the +ext2 and fat filesystems. + +2. Maintaining the SPI NOR +-- +A couple of convenience commands + + clearenv - clear environment to factory default + upgradeu - look and source a boot script named + '6q_upgrade' to upgrade the U-Boot version + in SPI NOR. The search is the same as for + 6q_bootscript described above. + +3. Display support +-- +U-Boot support for the following displays is configured by +default: + +HDMI - 1024 x 768 for maximum compatibility +Hannstar-XGA - 1024 x 768 LVDS (Freescale part number MCIMX-LVDS1) +wsvga-lvds - 1024 x 600 LVDS (Boundary p/n Nit6X_1024x600) +wvga-rgb - 800 x 480 RGB (Boundary p/n Nit6X_800x480) + +Since the ipuv3_fb display driver currently supports only a single display, +this code auto-detects panel by probing the HDMI Phy for Hot Plug Detect +or the I2C touch controller of the LVDS and RGB displays in the priority +listed above. + +Setting 'panel' environment variable to one of the names above will +override auto-detection and force activation of the specified panel. + +4. Building + + +To build U-Boot for the Nitrogen6x or SabreLite board: + + make nitrogen6x_config + make u-boot.imx + +If you place the u-boot.imx into a single-partition SD card +along with a binary version of the boot script 6q_upgrade.txt, +you can program it using 'upgradeu': + + U-Boot run upgradeu + diff --git
Re: [U-Boot] [PATCH V3 00/32] Add mx6solo/mx6duallite support
Hi Eric, On Thu, 04 Oct 2012 07:36:45 -0700, Eric Nelson eric.nel...@boundarydevices.com wrote: On 10/04/2012 03:18 AM, Albert ARIBAUD wrote: Hi Troy, On Wed, 3 Oct 2012 18:47:02 -0700, Troy Kisky troy.ki...@boundarydevices.com wrote: This series goal is to add support for mx6solo and mx6duallite variants of mx6qsabrelite board. The new targets are called mx6ssabrelite and mx6dlsabrelite. If the boards are known as 'mx6solo' and 'mx6duallite', they should be named so rather than called yet another nickname. Hi Albert, I'm not sure I understand your comment. mx6solo and mx6duallite are the CPU names, not the board names. That's where the misunderstanding crept in: I thought these were board names, not CPU names. mx6dlsabrelite is a version of the SABRE Lite board containing the mx6duallite CPU instead of the mx6quad. We'll also be offering Nitrogen6X in mx6solo and mx6duallite variants. Understood now -- and disregard my initial comment. Regards, Eric Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv8] ARM: Add Altera SOCFPGA Cyclone5
Hi dingu...@altera.com, On Thu, 4 Oct 2012 10:46:02 -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Add minimal support for Altera's SOCFPGA Cyclone 5 hardware. Signed-off-by: Dinh Nguyen dingu...@altera.com Signed-off-by: Chin Liang See cl...@altera.com Signed-off-by: Pavel Machek pa...@denx.de Reviewed-by: Marek Vasut ma...@denx.de Acked-by: Tom Trini tr...@ti.com Cc: Wolfgang Denx w...@denx.de Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Stefan Roese s...@denx.de v8: Remove no_return attribute for reset_cpu Applied to u-boot-arm/master, thanks. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Improve license declaration for cmd_ini.h
Instead of referenceing the source webpage (which can change) include the license in the source file. Signed-off-by: Joe Hershberger joe.hershber...@ni.com Reported-by: Igor Grinberg grinb...@compulab.co.il Cc: Igor Grinberg grinb...@compulab.co.il Cc: Tom Rini tr...@ti.com Cc: Wolfgang Denk w...@denx.de --- common/cmd_ini.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/common/cmd_ini.c b/common/cmd_ini.c index 652e4f6..74481cb 100644 --- a/common/cmd_ini.c +++ b/common/cmd_ini.c @@ -1,9 +1,37 @@ /* * inih -- simple .INI file parser * - * inih is released under the New BSD license (see LICENSE.txt). Go to the - * project home page for more info: + * Copyright (c) 2009, Brush Technology + * Copyright (c) 2012: + * Joe Hershberger, National Instruments, joe.hershber...@ni.com + * All rights reserved. * + * The inih library is distributed under the following license, which is + * derived from and very similar to the 3-clause BSD license: + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of Brush Technology nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY BRUSH TECHNOLOGY ''AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL BRUSH TECHNOLOGY BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * Go to the project home page for more info: * http://code.google.com/p/inih/ */ -- 1.7.11.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] arm1136: Fix enable_caches()
enable_caches() did not enable icache if CONFIG_SYS_ICACHE_OFF was not defined
but CONFIG_SYS_DCACHE_OFF was.
Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com
Cc: Albert Aribaud albert.u.b...@aribaud.net
---
This patch supersedes http://patchwork.ozlabs.org/patch/177263/ .
Changes for v2:
- Move enable_caches() outside of the main #if in order to fix this icache
issue rather than doing only #if cosmetic cleanup.
.../arch/arm/cpu/arm1136/cpu.c | 22 +++-
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git u-boot-arm-1dfc916.orig/arch/arm/cpu/arm1136/cpu.c
u-boot-arm-1dfc916/arch/arm/cpu/arm1136/cpu.c
index b98e3d9..32a4c24 100644
--- u-boot-arm-1dfc916.orig/arch/arm/cpu/arm1136/cpu.c
+++ u-boot-arm-1dfc916/arch/arm/cpu/arm1136/cpu.c
@@ -141,16 +141,6 @@ void flush_cache(unsigned long start, unsigned long size)
flush_dcache_range(start, start + size);
}
-void enable_caches(void)
-{
-#ifndef CONFIG_SYS_ICACHE_OFF
- icache_enable();
-#endif
-#ifndef CONFIG_SYS_DCACHE_OFF
- dcache_enable();
-#endif
-}
-
#else /* #ifndef CONFIG_SYS_DCACHE_OFF */
void invalidate_dcache_all(void)
{
@@ -172,3 +162,15 @@ void flush_cache(unsigned long start, unsigned long size)
{
}
#endif /* #ifndef CONFIG_SYS_DCACHE_OFF */
+
+#if !defined(CONFIG_SYS_ICACHE_OFF) || !defined(CONFIG_SYS_DCACHE_OFF)
+void enable_caches(void)
+{
+#ifndef CONFIG_SYS_ICACHE_OFF
+ icache_enable();
+#endif
+#ifndef CONFIG_SYS_DCACHE_OFF
+ dcache_enable();
+#endif
+}
+#endif
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCHv8] ARM: Add Altera SOCFPGA Cyclone5
Hi Albert, On Thu, 2012-10-04 at 21:54 +0200, ZY - albert.u.boot wrote: Hi dingu...@altera.com, On Thu, 4 Oct 2012 10:46:02 -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Add minimal support for Altera's SOCFPGA Cyclone 5 hardware. Signed-off-by: Dinh Nguyen dingu...@altera.com Signed-off-by: Chin Liang See cl...@altera.com Signed-off-by: Pavel Machek pa...@denx.de Reviewed-by: Marek Vasut ma...@denx.de Acked-by: Tom Trini tr...@ti.com Cc: Wolfgang Denx w...@denx.de Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Stefan Roese s...@denx.de v8: Remove no_return attribute for reset_cpu Applied to u-boot-arm/master, thanks. Thanks alot! Dinh Amicalement, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC] ARM: prevent misaligned array inits
Hi Mark,
On Wed, 3 Oct 2012 09:29:09 +0200, Mark Marshall
mark.marsh...@omicron.at wrote:
I've just had a quick look at this in passing, but at least some of
these changes seem wrong to me. For example, the code in
board/ti/omap2420h4/sys_info.c :: display_board_info
should be:
void display_board_info(u32 btype)
{
static const char cpu_2420[] = 2420; /* cpu type */
static const char cpu_2422[] = 2422;
static const char cpu_2423[] = 2423;
static const char db_men[] = Menelaus; /* board type */
static const char db_ip[] = IP;
static const char mem_sdr[] = mSDR;/* memory type */
static const char mem_ddr[] = mDDR;
static const char t_tst[] = TST; /* security level */
static const char t_emu[] = EMU;
static const char t_hs[] = HS;
static const char t_gp[] = GP;
static const char unk[] = ?;
const char *cpu_s, *db_s, *mem_s, *sec_s;
u32 cpu, rev, sec;
This produces smaller code and is probably what the original
author wanted the compiler to do. I've only compile tested
this, not actually run it.
Original file:
Sections:
Idx Name Size VMA LMA File off Algn
0 .text 04b4 0034 2**2
CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE
1 .data 04e8 2**0
CONTENTS, ALLOC, LOAD, DATA
2 .bss 04e8 2**0
ALLOC
3 .rodata.str1.1 0072 04e8 2**0
CONTENTS, ALLOC, LOAD, READONLY, DATA
After my changes:
Sections:
Idx Name Size VMA LMA File off Algn
0 .text 03ac 0034 2**2
CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE
1 .data 03e0 2**0
CONTENTS, ALLOC, LOAD, DATA
2 .bss 03e0 2**0
ALLOC
3 .rodata 0048 03e0 2**2
CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
4 .rodata.str1.1 0047 0428 2**0
CONTENTS, ALLOC, LOAD, READONLY, DATA
Thanks Mike. Indeed, there is a range of choices to replace the
original local char arrays: global arrays, static local arrays,
char pointers, const char pointers, or even direct strings in code. I'd
originally gone for const chars because the idea was not optimizing but
getting rid of a compiler issue, however, with my toolchain, this led
to warnings about losing the const qualifier, so I went to simple char*.
I'll recheck with (const) static char[] and chose whetever gets the
best score.
Regards,
Mark Marshall.
Amicalement,
--
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ARM: prevent misaligned array inits
Under option -munaligned-access, gcc can perform local char
or 16-bit array initializations using misaligned native
accesses which will throw a data abort exception. Fix files
where these array initializations were unneeded, and for
files known to contain such initializations, enforce gcc
option -mno-unaligned-access.
Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net
---
arch/arm/cpu/arm926ejs/orion5x/cpu.c |4 +-
arch/arm/lib/interrupts.c|2 +-
board/ti/omap2420h4/sys_info.c | 28 -
common/Makefile |3 +
common/cmd_dfu.c |2 +-
doc/README.arm-unaligned-accesses| 110 ++
fs/fat/Makefile |2 +
fs/ubifs/Makefile|3 +
lib/Makefile |3 +
9 files changed, 139 insertions(+), 18 deletions(-)
create mode 100644 doc/README.arm-unaligned-accesses
diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
index c3948d3..5a4775a 100644
--- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
+++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
@@ -194,8 +194,8 @@ u32 orion5x_device_rev(void)
*/
int print_cpuinfo(void)
{
- char dev_str[] = 0x;
- char rev_str[] = 0x00;
+ char dev_str[7]; /* room enough for 0x plus null byte */
+ char rev_str[5]; /* room enough for 0x00 plus null byte */
char *dev_name = NULL;
char *rev_name = NULL;
diff --git a/arch/arm/lib/interrupts.c b/arch/arm/lib/interrupts.c
index 74ff5ce..2f97933 100644
--- a/arch/arm/lib/interrupts.c
+++ b/arch/arm/lib/interrupts.c
@@ -169,7 +169,7 @@ void do_prefetch_abort (struct pt_regs *pt_regs)
void do_data_abort (struct pt_regs *pt_regs)
{
- printf (data abort\n);
+ printf (data abort\n\nMAYBE you should read
doc/README.unaligned-access\n\n);
show_regs (pt_regs);
bad_mode ();
}
diff --git a/board/ti/omap2420h4/sys_info.c b/board/ti/omap2420h4/sys_info.c
index a9f7241..b12011e 100644
--- a/board/ti/omap2420h4/sys_info.c
+++ b/board/ti/omap2420h4/sys_info.c
@@ -237,20 +237,20 @@ u32 wait_on_value(u32 read_bit_mask, u32 match_value, u32
read_addr, u32 bound)
*/
void display_board_info(u32 btype)
{
- char cpu_2420[] = 2420; /* cpu type */
- char cpu_2422[] = 2422;
- char cpu_2423[] = 2423;
- char db_men[] = Menelaus; /* board type */
- char db_ip[] = IP;
- char mem_sdr[] = mSDR;/* memory type */
- char mem_ddr[] = mDDR;
- char t_tst[] = TST; /* security level */
- char t_emu[] = EMU;
- char t_hs[] = HS;
- char t_gp[] = GP;
- char unk[] = ?;
-
- char *cpu_s, *db_s, *mem_s, *sec_s;
+ static const char cpu_2420 [] = 2420; /* cpu type */
+ static const char cpu_2422 [] = 2422;
+ static const char cpu_2423 [] = 2423;
+ static const char db_men [] = Menelaus; /* board type */
+ static const char db_ip [] = IP;
+ static const char mem_sdr [] = mSDR;/* memory type */
+ static const char mem_ddr [] = mDDR;
+ static const char t_tst [] = TST; /* security level */
+ static const char t_emu [] = EMU;
+ static const char t_hs [] = HS;
+ static const char t_gp [] = GP;
+ static const char unk [] = ?;
+
+ const char *cpu_s, *db_s, *mem_s, *sec_s;
u32 cpu, rev, sec;
rev = get_cpu_rev();
diff --git a/common/Makefile b/common/Makefile
index 5442fbb..4a2027f 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -231,6 +231,9 @@ $(obj)env_embedded.o: $(src)env_embedded.c
$(obj)../tools/envcrc
$(obj)../tools/envcrc:
$(MAKE) -C ../tools
+$(obj)hush.o: CFLAGS += -mno-unaligned-access
+$(obj)fdt_support.o: CFLAGS += -mno-unaligned-access
+
#
# defines $(obj).depend target
diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
index 62fb890..01d6b3a 100644
--- a/common/cmd_dfu.c
+++ b/common/cmd_dfu.c
@@ -30,7 +30,7 @@
static int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
const char *str_env;
- char s[] = dfu;
+ char *s = dfu;
char *env_bkp;
int ret;
diff --git a/doc/README.arm-unaligned-accesses
b/doc/README.arm-unaligned-accesses
new file mode 100644
index 000..6f07436
--- /dev/null
+++ b/doc/README.arm-unaligned-accesses
@@ -0,0 +1,110 @@
+If you are reading this because of a data abort: the following MIGHT
+be relevant to your abort, if it was caused by an alignment violation.
+In order to determine this, use the PC from the abort dump along with
+an objdump -s -S of the u-boot ELF binary to locate the function where
+the abort happened; then compare this function with the exemples below.
+If they match, then you've been hit with a compiler generated unaligned
Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board
On 10/04/2012 05:42 PM, Sinan Akman wrote: On 10/04/2012 03:49 PM, Eric Nelson wrote: [..] +gpio_direction_output(IMX_GPIO_NR(6, 24), 1); + +/* Need delay 10ms according to KSZ9021 spec */ +udelay(1000 * 10); +gpio_set_value(IMX_GPIO_NR(3, 23), 1); Don't you need a gpio_set_value(IMX_GPIO_NR(1, 27), 1); here for Nitrogen6x ? Never mind, I just saw that this is in a separate patch. Sorry for the noise. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board
On Thu, Oct 4, 2012 at 4:49 PM, Eric Nelson eric.nel...@boundarydevices.com wrote: Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com --- board/boundary/nitrogen6x/Makefile | 41 ++ board/boundary/nitrogen6x/README | 77 +++ board/boundary/nitrogen6x/nitrogen6x.c | 840 boards.cfg |1 + include/configs/nitrogen6x.h | 242 + 5 files changed, 1201 insertions(+), 0 deletions(-) create mode 100644 board/boundary/nitrogen6x/Makefile create mode 100644 board/boundary/nitrogen6x/README create mode 100644 board/boundary/nitrogen6x/nitrogen6x.c create mode 100644 include/configs/nitrogen6x.h You missed an entry to MAINTAINERS file. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1] env: fix crash using default -f -a
On Thu, Oct 04, 2012 at 07:30:43PM +0200, Stefano Babic wrote: newval pointer is not checked before its usage, inside env_check_apply(). Signed-off-by: Stefano Babic sba...@denx.de CC: gerlando.fala...@keymile.com Some egg on my face for not catching this to start with, confirmed problem and fix here. Tested-by: Tom Rini tr...@ti.com -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MPC85xx: remove support for TQM85xx boards
On Thu, Oct 04, 2012 at 11:36:18AM +0200, Wolfgang Denk wrote: Due to grown code sizes the TQM85xx boards don't build any more with some older tool chains (like ELDK 4.2). As these boards have long reached EOL it seems a waste of effort trying to fix them. The vendor has agreed to drop support for them, too. So let's get rid of them. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Stefan Roese s...@denx.de cc: Kim Phillips kim.phill...@freescale.com To be consistent, I've asked for v2012.10 to be the last stop for various platforms. Given that it doesn't build however, and the maintainer doesn't want to fix the build problem, I'm going to remove them. I think that's consistent still. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 5/7] MAINTAINERS: Add Tetsuyuki Kobayshi for kzm9g
HI,
On Thu, Oct 4, 2012 at 5:45 PM, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Hi Nohiburo, Tetsuyuki,
On Fri, 20 Jul 2012 08:51:29 +0900, Nobuhiro Iwamatsu
iwama...@nigauri.org wrote:
Applied to my arm/rmobile branch.
Thank you.
Best regards,
Nobuhiro
Actually this did does not seem to have been applied to arm/rmobile,
and was not in my patchwork todo either. Should I apply the patch
directly in arm/master?
Yes, please apply to your repository.
Thanks!
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request: u-boot-sh/master
Hi Tom, Please pull u-boot-sh master branch. Best regards, Nobuhiro The following changes since commit 198166877768cf4d0197289a524df8a6ca0e2f19: Merge branch 'master' of git://git.denx.de/u-boot-arm (2012-10-04 10:00:42 -0700) are available in the git repository at: git://git.denx.de/u-boot-sh.git master for you to fetch changes up to 6f6ea814ed12e44d6a803fd47a2cbdbf2915ce7f: sh: ap_sh4a_4a: Fixed initialization value of DDR memory (2012-10-05 07:05:10 +0900) Nobuhiro Iwamatsu (1): sh: ap_sh4a_4a: Fixed initialization value of DDR memory board/alphaproject/ap_sh4a_4a/lowlevel_init.S |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board
On 10/04/2012 03:49 PM, Eric Nelson wrote:
[..]
+
+static void setup_iomux_enet(void)
+{
+ gpio_direction_output(IMX_GPIO_NR(3, 23), 0);
+ gpio_direction_output(IMX_GPIO_NR(6, 30), 1);
+ gpio_direction_output(IMX_GPIO_NR(6, 25), 1);
+ gpio_direction_output(IMX_GPIO_NR(6, 27), 1);
+ gpio_direction_output(IMX_GPIO_NR(6, 28), 1);
+ gpio_direction_output(IMX_GPIO_NR(6, 29), 1);
+ imx_iomux_v3_setup_multiple_pads(enet_pads1, ARRAY_SIZE(enet_pads1));
+ gpio_direction_output(IMX_GPIO_NR(6, 24), 1);
+
+ /* Need delay 10ms according to KSZ9021 spec */
+ udelay(1000 * 10);
+ gpio_set_value(IMX_GPIO_NR(3, 23), 1);
Don't you need a
gpio_set_value(IMX_GPIO_NR(1, 27), 1);
here for Nitrogen6x ?
+
+ imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
+}
[...]
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Sandbox: Add spi driver to sandbox
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/04/12 03:14, viktor.kri...@gmail.com wrote: From: Viktor Krivak viktor.kri...@gmail.com Signed-off-by: Viktor Krivak viktor.kri...@gmail.com [snip] +#ifndef CONFIG_SANDBOX_SPI_BUS_NUM + #define CONFIG_SANDBOX_SPI_BUS_NUM 1 +#endif + +#ifndef CONFIG_SANDBOX_SPI_CS_NUM + #define CONFIG_SANDBOX_SPI_CS_NUM 1 +#endif + +#ifndef CONFIG_SANDBOX_SPI_BUFFER_LEN +#define CONFIG_SANDBOX_SPI_BUFFER_LEN 32 +#endif Please just define these in the config file and fail to build when unset. [snip] +/* + * spi_cs_is_valid() - Check if bus and cs are valid number + * + * @bus: Bus id + * @cs:Chip select id + * + * Compare bus and cs against defined constant. Return 0 if everything is ok + * and other value on error. + */ Almost kernel-doc style, but that needs /**, please update globally. - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQbgxVAAoJENk4IS6UOR1Wo18P/jrHcuWPckQ+gLsxbT1lZXaV 3iNeozB6rZOvrrMhbt8HKn83GclUrA8Od6NCMtW9U0DRBPn1mEJL1HlUe4TwYlPO rtRQhvTQdaly1M9TFKCs4KKbedrJuypiQf9ToLW6qkHDC4ocDPg81Rsp2PtBdqB7 joFwd2xlpSAyaBxJpRk0+K98Qt6MxwU/C1c6pdZCgWCyaFAspg5VSEtX+Y6y3oG/ x1z9E8y/dVJqCyuMdXWch3fLsMFLFB/iFCyfgg649cNC40xuHc7rRO2rAdNDU9u7 wZ3aS/35Nm0iFL7JRL1sgcswUrPu0eqK24b+Mq+anfp+4z8vk0oh5pXYN0qi9uEW QCB0jqNzhJQS0ZzZI6hY40DGzGXHdYHNB56BUlR/TW19QYFjeLNJAizbTFsTxC3v u1U5u+vmZqoXo3VaX9G5WoxDpHYSLGMOon8B8aeU7BuBKLMZL+BE10Sfd2ubesto AHG9nXPSkDfnyOmZXsG3RrdNNo0x9klGnKrUKC1tROaDKzqvcVH6M8WrHRBU7nX4 5khTph/tZZ+ZShBAMa1EGA5E9htqswDi2P6S4CUIIHD4DrAInY/S0/3Y/Z7Bv2IJ r3okMqawaHOpwTklFHxJVFtlZIBnCHHlVD8BiUfAFR0IyOz5gMYuekPkrAJ8Mo4E AGH8N0JH/AmaFFpxvmF4 =bGe/ -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ppc4xx/next
Dear Stefan Roese, Hi Marek, On 10/03/2012 02:15 AM, Marek Vasut wrote: Stefan Roese (3): ppc4xx: Remove IOP480 support ppc4xx: Remove ML2 board support ppc4xx: Remove AP1000 board support [...] I see :-) Not many zombies removed ... any plans to continue this crusade? Not right now. Hard to determine which boards are unmaintained. Do you have idea on how to check for unmaintained boards? Can MAKEALL -M or MAKEALL -m help ? Thanks, Stefan Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 30/32] mx6qsabrelite: change CONFIG_SYS_PROMPT
On 10/3/2012 8:00 PM, Otavio Salvador wrote: On Wed, Oct 3, 2012 at 10:47 PM, Troy Kisky troy.ki...@boundarydevices.com wrote: The prompt is not appropriate if not running on a mx6q processor. Signed-off-by: Troy Kisky troy.ki...@boundarydevices.com But in this case the board name will change, no? No, patch 29/32 sets the new boards to use the same config file (mx6qsabrelite.h) only adding ,MX6DL or ,MX6S or ,MX6Q to the end of the line in boards.cfg Troy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3 27/32] mx6qsabrelite: add support for mx6 solo/duallite
On 10/3/2012 8:23 PM, Otavio Salvador wrote: On Wed, Oct 3, 2012 at 10:47 PM, Troy Kisky troy.ki...@boundarydevices.com wrote: Signed-off-by: Troy Kisky troy.ki...@boundarydevices.com --- board/freescale/mx6qsabrelite/mx6qsabrelite.c | 235 ++--- board/freescale/mx6qsabrelite/pads.h | 172 ++ I'd say mx6qsabrelite could be renamed to mx6sabrelite so it is not confusing. Both mx6qsabrelite.c and mx6qsabrelite.h should be renamed to drop the q. Also, the directory could be renamed ? I think a follow on patch later to reduced conflicts with others work would be appropriate. Troy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4 V2] doc: kerneldoc: Implant DocBook from Linux kernel
Dear Albert ARIBAUD, Hi Marek, Comments based on the assumption that we want to sync with the Linux tools. General comment/hypothetical question: would it not be simpler to patch the existing Linux tools in-place so that we can use them on the U-Boot tree? Yes, it is a good idea. I'll do that. The problem is, replies to my patches do documentation mailing lists are slow, that's for one thing. The other, much more grave and unpleasant is that we're way too far behind the DM schedule. I don't know what to do, but since pushing stuff upstream goes much slower than I expected, I will soon be left with no option other than forking u- boot, finishing the university project and -- at the end, without the team -- merge the stuff slowly back upstream. The patchsets are starting to depend one on another, so nothing gets in without something else etc ... Detailed comments below in this spirit; ignore if suggestion above is stupid/complicated/plain wrong/other(specify...or not). On Sat, 29 Sep 2012 04:43:04 +0200, Marek Vasut ma...@denx.de wrote: Pull slightly modified version of Documentation/DocBook, the related perl script scripts/kernel-doc and the scripts/docproc.c from Linux kernel and implant it into U-Boot. This will allow smooth generation of kerneldoc style documentation. It was necessary to modify the DocBook/Makefile to work with U-Boot build system. The changes were only minor though and involved replacing the kbuild specific parts. Is it possible to make replace these changes with an if/then/else conditional based on an external option? That would make it possible to try and backmerge them into the Linux version of kerneldoc. Yes, it would ... while I already see how Linux people would hate it. It was also necessary to replace use of variables like KERNEL_VERSION with U_BOOT_VERSION, strings like Linux kernel with U-Boot Bootloader etc. so the generated result actually matches. Maybe make this change more general, i.e. replace KERNEL_VERSION with PROJECT_VERSION with a default value assuming Linux, make magic constant strings variables with a linux-friendly default, and make all those variables overridable from command line? We'd just have to have a small script to provide the U-Boot-sensible values. Yes, this would be easy. But see above. Finally, it was necessary to adjust docproc.c, since the documentation in U-Boot is located in doc/DocBook instead of Documentation/DocBook as is in case of the Linux kernel. Does it not make sense to drop the change above and instead, symlink doc/ to Documentation/? We could keep the symlink for one release then switch to a true rename for the release after. I'd hate to do so ... is there any reason? An environment variable would be much easier, docproc already uses them a bit. Amicalement, Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Future direction of the x86 architecture in U-Boot
Hi All, You may have noticed a distinct lack of activity related to x86 code lately. There are a number of reasons for this, but none of them signify an end to x86 U-Boot. I've fielded a number of questions lately (mostly off list) and I want to bring the outcome of those discussions to some form of unified consensus. There are two predominant architectural decisions which I think are important to get out of the way: 1) Getting rid of 16-bit 'Real Mode' code (i.e. BIOS stub) and how to boot Linux as a result 2) Chain-loading U-Boot (from coreboot or GRUB for example) My position on #1 is pretty straightforward - I want to get rid of the 16-bit 'Real Mode' code (and, ergo, the BIOS code) entirely and forever. For me personally this is a bit of a pity as I had done a lot of hacking off-list learning how to seamlessly add 16-bit C code into U-Boot (including interrupt handling etc.) which would have allowed the BIOS code to be re-written in C. However, I think the better direction for U-Boot is for it to be as small and tight as possible with no unnecessary 'fluff'. I have proven to myself that a Linux kernel (with a little coercion of the bzImage) can be booted by U-Boot without the 'Real Mode' code. This greatly simplifies (and speeds up) the overall boot process. For reference, this may be a helpful link for the following discourse: http://lists.kernelnewbies.org/pipermail/kernelnewbies/2011-November/003906.html The main stumbling block with booting without a BIOS is how booting the x86 kernel relies on data in the 'Real Mode' stub (struct setup_header and struct boot_params) - The x86 kernel boot process has evolved into (IMHO) a monstrosity that make it nigh on impossible to deal with cleanly in a purely 32-bit protected mode environment (i.e. the Linux kernel pretty much assumes as a matter of course that it is being booted on a machine with a BIOS). So what has ended up happening is that the x86 bzImage contains three intrinsically interrelated components - A 'Real Mode' stub to probe BIOS, a 'Protected Mode' decompresser and the actual (compressed) kernel itself. One piece of information in particular that is in the setup header that is not (readily available?) in the compressed kernel image is the kernel version string. What I would ultimately like to do is have U-Boot do the kernel decompression itself (this would allow the x86 kernel image to be stored in the U-Boot image container). This could potentially save some unnecessary coping of the kernel. At the moment, bzImage needs to be copied 'low' in memory and then it is decompressed elsewhere into memory. By not using the Linux real-mode 'fluff', it is feasible to decompress the image directly from storage (NOR flash in particular) to it's final location in RAM. It may even be feasible to decompress straight from SD/MMC, HDD, NAND flash, etc. by utilising DMA (DMA block 'n' to RAM, start DMA'ing block 'n+1', decompress block 'n' while the DMA of block 'n + 1' is happening) In order for U-Boot to successfully boot an x86 kernel directly from protected mode would be vmlinux.bin and the matching setup header - something the current kernel build process does not readily give us. I have written a script that can strip the required data out of a bzImage, but this is a bit clunky. Right now I am open to suggestions on how to best achieve the end-goal of a BIOS-less U-Boot direct-booting a Linux kernel. Issue #2 follows on somewhat - Once all the 'Real Mode' code is removed, we are left with a pretty clean U-Boot.bin apart from the reset vector stub which, as recent patches have shown, is trivial to exclude from the build. U-Boot already supports direct execution from RAM by simply loading U-Boot.bin to CONFIG_SYS_TEXT_BASE and jump to CONFIG_SYS_TEXT_BASE. U-Boot will even relocate itself. But I think that there is some improvements that could be made. For example: - How to tell U-Boot the amount of memory available (or even the complete E820 memory map to be passed to Linux) - How to load U-Boot into upper-memory and perform the relocation adjustments directly (like the relocatable Linux kernel) - Passing hardware information (PCI interrupt routing etc) to U-Boot so U-Boot does not have to re-probe hardware The approach to chain loading U-Boot is still very open-ended to me, but we still need to keep in mind that U-Boot must remain capable of being the 'primary' bootloader for x86 platforms So in summary, I'm 'all ears' on suggestions - not only on the above, but on anything relating to the direction(s) x86 U-Boot should head. Any input is greatly appreciated Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4 V2] doc: kerneldoc: Implant DocBook from Linux kernel
Hi Marek, On Fri, Oct 5, 2012 at 10:28 AM, Marek Vasut ma...@denx.de wrote: Dear Albert ARIBAUD, Hi Marek, Comments based on the assumption that we want to sync with the Linux tools. General comment/hypothetical question: would it not be simpler to patch the existing Linux tools in-place so that we can use them on the U-Boot tree? Yes, it is a good idea. I'll do that. The problem is, replies to my patches do documentation mailing lists are slow, that's for one thing. The other, much more grave and unpleasant is that we're way too far behind the DM schedule. I don't know what to do, but since pushing stuff upstream goes much slower than I expected, I will soon be left with no option other than forking u- boot, finishing the university project and -- at the end, without the team -- merge the stuff slowly back upstream. If I were in your position, I would not hesitate for a minute to do a fork. The beauty of the FLOSS model of development is that forking is trivial and if the fork has worthy features, merging later will meet with general enthusiasm from the community. The merge will probably happen faster than you think (and may actually happen in parallel so that when your project finishes, more than half of your work has already been integrated) And once you fork, all the bottlenecks of global community approval disappear. Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4 V2] doc: kerneldoc: Implant DocBook from Linux kernel
Dear Graeme Russ, Hi Marek, On Fri, Oct 5, 2012 at 10:28 AM, Marek Vasut ma...@denx.de wrote: Dear Albert ARIBAUD, Hi Marek, Comments based on the assumption that we want to sync with the Linux tools. General comment/hypothetical question: would it not be simpler to patch the existing Linux tools in-place so that we can use them on the U-Boot tree? Yes, it is a good idea. I'll do that. The problem is, replies to my patches do documentation mailing lists are slow, that's for one thing. The other, much more grave and unpleasant is that we're way too far behind the DM schedule. I don't know what to do, but since pushing stuff upstream goes much slower than I expected, I will soon be left with no option other than forking u- boot, finishing the university project and -- at the end, without the team -- merge the stuff slowly back upstream. If I were in your position, I would not hesitate for a minute to do a fork. I do, bloody damnit! Just remember how it ended last time -- the result was a stupid useless piece of crap which was never merged back. Lot of wasted time etc. The beauty of the FLOSS model of development is that forking is trivial and if the fork has worthy features, merging later will meet with general enthusiasm from the community. The merge will probably happen faster than you think (and may actually happen in parallel so that when your project finishes, more than half of your work has already been integrated) See above. And once you fork, all the bottlenecks of global community approval disappear. And the fork will be sheets of crap, one on another ... because there'll be no proper review. My position is that I DO NOT WANT TO DO IT ... unless I'm pushed to do so by the circumstances. And I'm reaching that point :'-C Regards, Graeme Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] arm: rmobile: bugfix: wrong register saving in lowlevel_init
lowlevel_init() of rmobile badly assumed that ip register holds return address. The commit 63ee53a7 armv7 cpu_init_crit: Simplify code breaks this assumption. This patch removes this bad assumption and simplify code. Signed-off-by: Tetsuyuki Kobayashi k...@kmckk.co.jp --- Hello, Albert Hello, Tom Thank you for merging my patches. I checked current u-boot-master and found kzm9g board fails to boot because bug. This bugfix patch solves it. I think 2012.10 release should have this bugfix. Iwamatsu-san, could you double check this patch? arch/arm/cpu/armv7/rmobile/lowlevel_init.S | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/arch/arm/cpu/armv7/rmobile/lowlevel_init.S b/arch/arm/cpu/armv7/rmobile/lowlevel_init.S index 1bd391e..4fdca06 100644 --- a/arch/arm/cpu/armv7/rmobile/lowlevel_init.S +++ b/arch/arm/cpu/armv7/rmobile/lowlevel_init.S @@ -76,17 +76,7 @@ loop0: bne loop0 ldr sp, MERAM_STACK - - str ip, [sp]/* stash old link register */ - mov ip, lr /* save link reg across call */ - - bl s_init - - ldr ip, [sp]/* restore save ip */ - mov lr, ip /* restore link reg */ - - /* back to arch calling code */ - mov pc, lr + b s_init .pool .align 4 -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
