[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
Hi ALL, Could any buddy tell me how can I define bootcount value after each reset cycle, right now i am using SRAM but when boot loader pass the control to kernel, it reset Sram memory so i lost my bootcount value. please suggest me another idea for storing bootcount value... My another query is I want to increase my bootcount value when system is being reset by watchdog only.. Any pointer from you guys would be help me. Thanks ~Sumit Gemini On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki jagannadha.sutradharudu-t...@xilinx.com wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
Hi Il giorno 16/giu/2013 11:55, Sumit Gemini sumit.gemi...@gmail.com ha scritto: Hi ALL, Could any buddy tell me how can I define bootcount value after each reset cycle, right now i am using SRAM but when boot loader pass the control to kernel, it reset Sram memory so i lost my bootcount value. Is this your comment on the patch? I suggest to create a new thread and at describe your architecture. Michael please suggest me another idea for storing bootcount value... My another query is I want to increase my bootcount value when system is being reset by watchdog only.. Any pointer from you guys would be help me. Thanks ~Sumit Gemini On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki jagannadha.sutradharudu-t...@xilinx.com wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114
On Sat, Jun 15, 2013 at 11:28:25PM +0200, Marek Vasut wrote: Dear Thierry Reding, On Fri, Jun 14, 2013 at 06:41:40PM +0800, Jim Lin wrote: [...] diff --git a/board/nvidia/dts/tegra30-beaver.dts b/board/nvidia/dts/tegra30-beaver.dts [...] @@ -68,4 +69,9 @@ status = okay; bus-width = 8; }; + + usb@7d008000 { + nvidia,vbus-gpio = gpio 61 3; /* PH5, USB13_VBUS_PULLUP */ This doesn't work for me on Beaver. I need to turn the above line into this: nvidia,vbus-gpio = gpio 236 0; /* PDD4 */ PDD4 is the correct GPIO according to the schematics and the pin is high-active. Also as far as I can tell, 3 is not a meaningful value for the U-Boot GPIO bindings. Only the value 1 (low-active) is used. With that change applied on top of your patches I can see that a USB flash drive connected to USB3 is indeed powered. However I noticed something strange. When I try to use USB, I get this: Tegra30 (Beaver) # usb start (Re)start USB... USB0: set_host_mode: GPIO 236 high USB EHCI 1.00 scanning bus 0 for devices... 1 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 0 Ethernet Device(s) found So no storage device is detected, even though a USB flash drive is connected and powered properly. If I repeat the same command, however, the storage device is detected: Tegra30 (Beaver) # usb reset (Re)start USB... USB0: set_host_mode: GPIO 236 high USB EHCI 1.00 scanning bus 0 for devices... 2 USB Device(s) found scanning usb for storage devices... 1 Storage Device(s) found scanning usb for ethernet devices... 0 Ethernet Device(s) found Any idea what might be going on here? Try waiting a little after setting the GPIO maybe? The drive might need some time to settle. I can make it work on the first invocation of usb start by adding a rather long mdelay() at the very end of ehci_hcd_init() in the Tegra EHCI driver. The magic value seems to be 853 ms. 852 ms wasn't enough in any of the test runs. 853 ms always worked. However 850+ ms seems like a very long time for the device to settle, and keeping it in the driver probably isn't a good idea. Furthermore I cannot reproduce the same issue with a newer flash drive, which works fine with no additional delays. Thierry pgp0Btqnj21oy.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ANN] v2013.07-rc1
Hi Tom, Hey all, I've tagged and pushed v2013.07-rc1. Lots of things all over the place. If you've got changes outstanding still, please start gently poking custodians with patchwork links. I've got a good bit of stuff I need to deal with myself still, but please prod me all the same. I've just made a clean clone of u-boot/master and tried to build my board (after adding what's needed), and then also the omap5_uevm. In both cases the build fails with following error: gcc -g -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -include /Users/imac/Documents/UB2013.07/include/libfdt_env.h -idirafter /Users/imac/Documents/UB2013.07/include -idirafter /Users/imac/Documents/UB2013.07/include2 -idirafter /Users/imac/Documents/UB2013.07/include -I /Users/imac/Documents/UB2013.07/lib/libfdt -I /Users/imac/Documents/UB2013.07/tools -DCONFIG_SYS_TEXT_BASE=0x80E8 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -c -o image-fit.o /Users/imac/Documents/UB2013.07/common/image-fit.c /Users/imac/Documents/UB2013.07/common/image-fit.c: In function 'fit_image_load': /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: error: 'ENOMEDIUM' undeclared (first use in this function) /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [image-fit.o] Error 1 make: *** [tools] Error 2 Lubos-iMac:UB2013.07 imac$ All #include stuff seems OK. Any ideas? Regards, Lubo ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 0/6] Optimize ARM relocation
Hello Albert, On 06/13/2013 08:54 PM, Jeroen Hofstee wrote: binaries only use one type of relocation record, R_ARM_RELATIVE., then optimizing relocation code accordingly. fyi, I had a look at the clang build and it doesn't boot after these patches... When constant pointers are used without fpie, e.g. the arguments to printf, gcc will load the address with ldr / R_ARM_ABS32, clang sets the address with a movw / movt pair. ld -r will make the former relative, but the movw / movt cannot be fixed. So I set fpie for clang, which generates a couple of R_ARM_ABS32: Most notably a reference to do_bootd. Since it is no longer valid after this patch and used in command.c this crashes the board (unless there happens to be a valid address in it). gcc seems to always recalculate it using pc. Another symbol is _start, but that looks easily fixable. The last one looks similar like the do_bootd and I haven't bothered to check the details. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2] ARM: mxs: Consolidate configuration options
Pull all the duplicate configuration options into configs/mxs.h from the board configuration files. This reduces the files greatly and makes them somewhat more readable. Besides, we do no longer have such a horrible duplication of code. Note that the mx23evk grew in size slightly. This is due to the CONFIG_SYS_CBSIZE now being set to 1024 as it is on the rest of MXS systems. This patch also fixes the OCRAM size for i.MX23. The i.MX23 has only 32kB of OCRAM, while i.MX28 has 128kB of OCRAM. I verified the configuration didn't change for each of the boards, but I didn't boot-test it on the boards I do not have. I configured U-Boot for each board using the make ... board_config command and then ran cpp -I include -dM include/config.h , which dumped all the configuration options. I did this both before and after this patch and finally compared the results for each MXS board. Actually, the results do differ slightly, since the configs/mxs.h file now properly includes the correct iomux-mx23.h or iomux-mx28.h , so while comparing, I had to ignore these new defines. These have no impact on U-Boot configuration though. Signed-off-by: Marek Vasut ma...@denx.de Cc: Fabio Estevam fabio.este...@freescale.com Cc: Lauri Hintsala lauri.hints...@bluegiga.com Cc: Otavio Salvador ota...@ossystems.com.br Cc: Stefano Babic sba...@denx.de --- include/configs/apx4devkit.h | 120 include/configs/m28evk.h | 192 ++ include/configs/mx23_olinuxino.h | 142 +--- include/configs/mx23evk.h| 115 --- include/configs/mx28evk.h| 173 -- include/configs/mxs.h| 191 + include/configs/sc_sps_1.h | 139 --- 7 files changed, 340 insertions(+), 732 deletions(-) create mode 100644 include/configs/mxs.h V2: Clean up remaining multi-line comments in the config files and make them into single line comments. diff --git a/include/configs/apx4devkit.h b/include/configs/apx4devkit.h index 3242133..7081f37 100644 --- a/include/configs/apx4devkit.h +++ b/include/configs/apx4devkit.h @@ -19,34 +19,16 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ -#ifndef __CONFIG_H -#define __CONFIG_H +#ifndef __CONFIGS_APX4DEVKIT_H__ +#define __CONFIGS_APX4DEVKIT_H__ -/* SoC configurations */ +/* System configurations */ #define CONFIG_MX28/* i.MX28 SoC */ -#define CONFIG_MXS_GPIO/* GPIO control */ -#define CONFIG_SYS_HZ 1000/* Ticks per second */ - #define MACH_TYPE_APX4DEVKIT 3712 #define CONFIG_MACH_TYPE MACH_TYPE_APX4DEVKIT -#include asm/arch/regs-base.h - -#define CONFIG_SYS_NO_FLASH -#define CONFIG_BOARD_EARLY_INIT_F -#define CONFIG_ARCH_CPU_INIT -#define CONFIG_ARCH_MISC_INIT - -/* SPL */ -#define CONFIG_SPL -#define CONFIG_SPL_NO_CPU_SUPPORT_CODE -#define CONFIG_SPL_START_S_PATHarch/arm/cpu/arm926ejs/mxs -#define CONFIG_SPL_LDSCRIPTarch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds -#define CONFIG_SPL_LIBCOMMON_SUPPORT -#define CONFIG_SPL_LIBGENERIC_SUPPORT -#define CONFIG_SPL_GPIO_SUPPORT - /* U-Boot Commands */ +#define CONFIG_SYS_NO_FLASH #include config_cmd_default.h #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DOS_PARTITION @@ -66,78 +48,26 @@ #define CONFIG_CMD_SAVEENV #define CONFIG_CMD_USB -/* Memory configurations */ +/* Memory configuration */ #define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */ #define PHYS_SDRAM_1 0x4000 /* Base address */ #define PHYS_SDRAM_1_SIZE 0x2000 /* Max 512 MB RAM */ -#define CONFIG_SYS_MALLOC_LEN 0x0040 /* 4 MB for malloc */ -#define CONFIG_SYS_MEMTEST_START 0x4000 /* Memtest start adr */ -#define CONFIG_SYS_MEMTEST_END 0x4040 /* 4 MB RAM test */ #define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1 -/* Point initial SP in SRAM so SPL can use it too. */ -#define CONFIG_SYS_INIT_RAM_ADDR 0x -#define CONFIG_SYS_INIT_RAM_SIZE (128 * 1024) - -#define CONFIG_SYS_INIT_SP_OFFSET \ - (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) -#define CONFIG_SYS_INIT_SP_ADDR \ - (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET) - -/* - * We need to sacrifice first 4 bytes of RAM here to avoid triggering some - * strange BUG in ROM corrupting first 4 bytes of RAM when loading U-Boot - * binary. In case there was more of this mess, 0x100 bytes are skipped. - */ -#define CONFIG_SYS_TEXT_BASE 0x4100 +/* Environment */ #define CONFIG_ENV_OVERWRITE - -/* U-Boot general configurations */ -#define CONFIG_SYS_LONGHELP -#define CONFIG_SYS_PROMPT = -#define CONFIG_SYS_CBSIZE 1024/* Console I/O
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
On Sun, Jun 16, 2013 at 12:46:37PM +0530, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; Lets get this to come in via the kernel please, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] image: Use ENOENT instead of ENOMEDIUM for better compatibility
This error may not be defined on some platforms such as MacOS so host compilation will fail. Use one of the more common errors instead. Signed-off-by: Simon Glass s...@chromium.org --- common/image-fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/image-fit.c b/common/image-fit.c index 7bf82d3..f40f160 100644 --- a/common/image-fit.c +++ b/common/image-fit.c @@ -1557,7 +1557,7 @@ int fit_image_load(bootm_headers_t *images, const char *prop_name, ulong addr, if (fit_image_get_data(fit, noffset, buf, size)) { printf(Could not find %s subimage data!\n, prop_name); bootstage_error(bootstage_id + BOOTSTAGE_SUB_GET_DATA); - return -ENOMEDIUM; + return -ENOENT; } len = (ulong)size; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] sandbox: block driver using host file/device as backing store
HI Henrik, On Thu, May 16, 2013 at 9:53 PM, Simon Glass s...@chromium.org wrote: Hi Henrik, On Wed, May 15, 2013 at 6:09 PM, Henrik Nordström hen...@henriknordstrom.net wrote: ons 2013-05-15 klockan 15:20 -0700 skrev Simon Glass: Hi Henrik, On Wed, May 15, 2013 at 2:54 PM, Henrik Nordström hen...@henriknordstrom.net wrote: Version 2 of this patch addressing the code comments by Simon and adding some small missing pieces. Looks good. For change log, you should follow the standard approach - also instead of 'comments by Simon' it is good to list the things you changed. You might find patman useful for preparing and sending patches. Just looked into it and looks nice. Giving it a try for next version. Did you send a new version? I might have missed it. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ANN] v2013.07-rc1
Hi Lubo, On Sun, Jun 16, 2013 at 4:49 AM, Lubomir Popov lpo...@mm-sol.com wrote: Hi Tom, Hey all, I've tagged and pushed v2013.07-rc1. Lots of things all over the place. If you've got changes outstanding still, please start gently poking custodians with patchwork links. I've got a good bit of stuff I need to deal with myself still, but please prod me all the same. I've just made a clean clone of u-boot/master and tried to build my board (after adding what's needed), and then also the omap5_uevm. In both cases the build fails with following error: gcc -g -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -include /Users/imac/Documents/UB2013.07/include/libfdt_env.h -idirafter /Users/imac/Documents/UB2013.07/include -idirafter /Users/imac/Documents/UB2013.07/include2 -idirafter /Users/imac/Documents/UB2013.07/include -I /Users/imac/Documents/UB2013.07/lib/libfdt -I /Users/imac/Documents/UB2013.07/tools -DCONFIG_SYS_TEXT_BASE=0x80E8 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -c -o image-fit.o /Users/imac/Documents/UB2013.07/common/image-fit.c /Users/imac/Documents/UB2013.07/common/image-fit.c: In function 'fit_image_load': /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: error: 'ENOMEDIUM' undeclared (first use in this function) /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [image-fit.o] Error 1 make: *** [tools] Error 2 Lubos-iMac:UB2013.07 imac$ All #include stuff seems OK. Any ideas? That might be a MacOS thing - I haven't quite had the patience to get a dev environment going on a Mac yet. Please can you try this patch and see if it helps? http://patchwork.ozlabs.org/patch/251685/ Regards, Simon Regards, Lubo ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/10] PXE support updates
On Tue, May 14, 2013 at 3:32 PM, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Rob, On Tue, May 14, 2013 at 2:48 PM, Rob Herring robherri...@gmail.com wrote: On Sun, Dec 2, 2012 at 9:00 PM, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com This is a series of various enhancements and fixes for u-boot pxe support. These patches are a result of testing with server side tools like Cobbler and ubuntu MAAS. Rob Rob Herring (10): pxe: Use ethact setting for pxe pxe: make string parameters const pxe: fix handling of different localboot values bootz: un-staticize do_bootz pxe: use bootz instead of bootm when enabled pxe: always display a menu when present pxe: simplify menu display and selection pxe: add support for ontimeout token pxe: add support for per arch and SoC default paths pxe: add ipappend support common/cmd_bootm.c |2 +- common/cmd_pxe.c | 210 include/command.h |2 + 3 files changed, 132 insertions(+), 82 deletions(-) Is someone going to pick these patches up? The single comment by Wolfgang I've addressed. Yes... I'll pick these up... apologies for the delays. When can I expect to see these land? Rob ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
From: Joel A Fernandes [mailto:agnel.j...@gmail.com] Sent: 16 June 2013 21:15 To: Jagannadha Sutradharudu Teki Cc: u-boot@lists.denx.de; Tom Rini Subject: Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.plhttp://checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.plhttp://checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.plhttp://checkpatch.pl b/tools/checkpatch.plhttp://checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.plhttp://checkpatch.pl +++ b/tools/checkpatch.plhttp://checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl Would it not work to pass in the -w here? Yes it will not work just to pass -w It's taking -w as a file. Thanks, Jagan. Joel # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl Would it not work to pass in the -w here? Joel # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com javascript:; (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com javascript:; (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com javascript:; # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de javascript:; http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ANN] v2013.07-rc1
Hi Simon, Hi Lubo, On Sun, Jun 16, 2013 at 4:49 AM, Lubomir Popov lpo...@mm-sol.com wrote: Hi Tom, Hey all, I've tagged and pushed v2013.07-rc1. Lots of things all over the place. If you've got changes outstanding still, please start gently poking custodians with patchwork links. I've got a good bit of stuff I need to deal with myself still, but please prod me all the same. I've just made a clean clone of u-boot/master and tried to build my board (after adding what's needed), and then also the omap5_uevm. In both cases the build fails with following error: gcc -g -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -include /Users/imac/Documents/UB2013.07/include/libfdt_env.h -idirafter /Users/imac/Documents/UB2013.07/include -idirafter /Users/imac/Documents/UB2013.07/include2 -idirafter /Users/imac/Documents/UB2013.07/include -I /Users/imac/Documents/UB2013.07/lib/libfdt -I /Users/imac/Documents/UB2013.07/tools -DCONFIG_SYS_TEXT_BASE=0x80E8 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -c -o image-fit.o /Users/imac/Documents/UB2013.07/common/image-fit.c /Users/imac/Documents/UB2013.07/common/image-fit.c: In function 'fit_image_load': /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: error: 'ENOMEDIUM' undeclared (first use in this function) /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [image-fit.o] Error 1 make: *** [tools] Error 2 Lubos-iMac:UB2013.07 imac$ All #include stuff seems OK. Any ideas? That might be a MacOS thing - I haven't quite had the patience to get a dev environment going on a Mac yet. Please can you try this patch and see if it helps? http://patchwork.ozlabs.org/patch/251685/ Many thanks for the hint - I didn't realize immediately that this is host stuff. U-boot now builds normally (and runs on my board :)). BTW, until this release I've been using a Mac at home to build and run U-Boot without any major issues (actually only make distclean fails, which is not crucial). Thanks, Lubo Regards, Simon Regards, Lubo ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ANN] v2013.07-rc1
Hi Lubo, On Sun, Jun 16, 2013 at 9:35 AM, Lubomir Popov lpo...@mm-sol.com wrote: Hi Simon, Hi Lubo, On Sun, Jun 16, 2013 at 4:49 AM, Lubomir Popov lpo...@mm-sol.com wrote: Hi Tom, Hey all, I've tagged and pushed v2013.07-rc1. Lots of things all over the place. If you've got changes outstanding still, please start gently poking custodians with patchwork links. I've got a good bit of stuff I need to deal with myself still, but please prod me all the same. I've just made a clean clone of u-boot/master and tried to build my board (after adding what's needed), and then also the omap5_uevm. In both cases the build fails with following error: gcc -g -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -include /Users/imac/Documents/UB2013.07/include/libfdt_env.h -idirafter /Users/imac/Documents/UB2013.07/include -idirafter /Users/imac/Documents/UB2013.07/include2 -idirafter /Users/imac/Documents/UB2013.07/include -I /Users/imac/Documents/UB2013.07/lib/libfdt -I /Users/imac/Documents/UB2013.07/tools -DCONFIG_SYS_TEXT_BASE=0x80E8 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -c -o image-fit.o /Users/imac/Documents/UB2013.07/common/image-fit.c /Users/imac/Documents/UB2013.07/common/image-fit.c: In function 'fit_image_load': /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: error: 'ENOMEDIUM' undeclared (first use in this function) /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [image-fit.o] Error 1 make: *** [tools] Error 2 Lubos-iMac:UB2013.07 imac$ All #include stuff seems OK. Any ideas? That might be a MacOS thing - I haven't quite had the patience to get a dev environment going on a Mac yet. Please can you try this patch and see if it helps? http://patchwork.ozlabs.org/patch/251685/ Many thanks for the hint - I didn't realize immediately that this is host stuff. U-boot now builds normally (and runs on my board :)). BTW, until this release I've been using a Mac at home to build and run U-Boot without any major issues (actually only make distclean fails, which is not crucial). We have done a few fixes with 'make distclean' before - is this MacOS-specific, or s general bug? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ANN] v2013.07-rc1
Hello Lubomir, Simon, On 06/16/2013 06:41 PM, Simon Glass wrote: We have done a few fixes with 'make distclean' before - is this MacOS-specific, or s general bug? Regards, Simon it is on FreeBSD as well so it is likely a sed missing a colon or a find needing a dot. Never bothered enough to track it down though. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/10] MIPS: unify low-level assembly code
2013/6/13 Gabor Juhos juh...@openwrt.org: The patch-set changes some parts of the low-level assembly code in order to minimize the difference between the mips32, mips64 and xburst implementation. Do it in small steps to make review easier. The series is based on the testing branch of the MIPS custodian tree. Cc: Daniel Schwierzeck daniel.schwierz...@googlemail.com Gabor Juhos (10): MIPS: mips32/start.S: use t8 register for dynamic relocation MIPS: mips32/start.S: rework relocation info check MIPS: xburst/start.S: save relocation address in s2 register MIPS: xburst/start.S: save relocation offset in s1 register MIPS: xburst/start.S: save gd in s0 register MIPS: xburst/start.S: use t8 register for dynamic relocation MIPS: xburst/start.S: rework relocation info check MIPS: mips32/cache.S: save return address in t9 register MIPS: mips32/cache.S: store cache line size in t8 register MIPS: mips32/cache.S: use v1 register for indirect function calls arch/mips/cpu/mips32/cache.S | 16 arch/mips/cpu/mips32/start.S | 24 arch/mips/cpu/xburst/start.S | 41 ++--- 3 files changed, 42 insertions(+), 39 deletions(-) -- 1.7.10 all patches applied to u-boot-mips/next, thanks -- Best regards, Daniel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] image: Use ENOENT instead of ENOMEDIUM for better compatibility
Hello Simon, On 06/16/2013 04:46 PM, Simon Glass wrote: This error may not be defined on some platforms such as MacOS so host compilation will fail. Use one of the more common errors instead. Signed-off-by: Simon Glass s...@chromium.org --- common/image-fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/image-fit.c b/common/image-fit.c index 7bf82d3..f40f160 100644 --- a/common/image-fit.c +++ b/common/image-fit.c @@ -1557,7 +1557,7 @@ int fit_image_load(bootm_headers_t *images, const char *prop_name, ulong addr, if (fit_image_get_data(fit, noffset, buf, size)) { printf(Could not find %s subimage data!\n, prop_name); bootstage_error(bootstage_id + BOOTSTAGE_SUB_GET_DATA); - return -ENOMEDIUM; + return -ENOENT; } len = (ulong)size; This fixes building for FreeBSD as well, thanks. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ANN] v2013.07-rc1
Hi Simon, Hi Lubo, On Sun, Jun 16, 2013 at 9:35 AM, Lubomir Popov lpo...@mm-sol.com wrote: Hi Simon, Hi Lubo, On Sun, Jun 16, 2013 at 4:49 AM, Lubomir Popov lpo...@mm-sol.com wrote: Hi Tom, Hey all, I've tagged and pushed v2013.07-rc1. Lots of things all over the place. If you've got changes outstanding still, please start gently poking custodians with patchwork links. I've got a good bit of stuff I need to deal with myself still, but please prod me all the same. I've just made a clean clone of u-boot/master and tried to build my board (after adding what's needed), and then also the omap5_uevm. In both cases the build fails with following error: gcc -g -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -include /Users/imac/Documents/UB2013.07/include/libfdt_env.h -idirafter /Users/imac/Documents/UB2013.07/include -idirafter /Users/imac/Documents/UB2013.07/include2 -idirafter /Users/imac/Documents/UB2013.07/include -I /Users/imac/Documents/UB2013.07/lib/libfdt -I /Users/imac/Documents/UB2013.07/tools -DCONFIG_SYS_TEXT_BASE=0x80E8 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -c -o image-fit.o /Users/imac/Documents/UB2013.07/common/image-fit.c /Users/imac/Documents/UB2013.07/common/image-fit.c: In function 'fit_image_load': /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: error: 'ENOMEDIUM' undeclared (first use in this function) /Users/imac/Documents/UB2013.07/common/image-fit.c:1560:11: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [image-fit.o] Error 1 make: *** [tools] Error 2 Lubos-iMac:UB2013.07 imac$ All #include stuff seems OK. Any ideas? That might be a MacOS thing - I haven't quite had the patience to get a dev environment going on a Mac yet. Please can you try this patch and see if it helps? http://patchwork.ozlabs.org/patch/251685/ Many thanks for the hint - I didn't realize immediately that this is host stuff. U-boot now builds normally (and runs on my board :)). BTW, until this release I've been using a Mac at home to build and run U-Boot without any major issues (actually only make distclean fails, which is not crucial). We have done a few fixes with 'make distclean' before - is this MacOS-specific, or s general bug? Well, I'm not a UNIX expert (nor Linux; in fact I'm more in hardware). I get this: Lubos-iMac:UB2013.07 imac$ make CROSS_COMPILE= arm-none-eabi- distclean rm: SPL: is a directory make: *** [clobber] Error 1 Lubos-iMac:UB2013.07 imac$ For OMAP we don't have a 'SPL' file; there is the 'spl' directory however, and although MacOS is case-sensitive, this somehow produces the error in '@rm -f $(obj)SPL' (clobber: of main Makefile). Regards, Simon Best regards, Lubo ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114
Dear Thierry Reding, On Sat, Jun 15, 2013 at 11:28:25PM +0200, Marek Vasut wrote: Dear Thierry Reding, On Fri, Jun 14, 2013 at 06:41:40PM +0800, Jim Lin wrote: [...] diff --git a/board/nvidia/dts/tegra30-beaver.dts b/board/nvidia/dts/tegra30-beaver.dts [...] @@ -68,4 +69,9 @@ status = okay; bus-width = 8; }; + + usb@7d008000 { + nvidia,vbus-gpio = gpio 61 3; /* PH5, USB13_VBUS_PULLUP */ This doesn't work for me on Beaver. I need to turn the above line into this: nvidia,vbus-gpio = gpio 236 0; /* PDD4 */ PDD4 is the correct GPIO according to the schematics and the pin is high-active. Also as far as I can tell, 3 is not a meaningful value for the U-Boot GPIO bindings. Only the value 1 (low-active) is used. With that change applied on top of your patches I can see that a USB flash drive connected to USB3 is indeed powered. However I noticed something strange. When I try to use USB, I get this: Tegra30 (Beaver) # usb start (Re)start USB... USB0: set_host_mode: GPIO 236 high USB EHCI 1.00 scanning bus 0 for devices... 1 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 0 Ethernet Device(s) found So no storage device is detected, even though a USB flash drive is connected and powered properly. If I repeat the same command, however, the storage device is detected: Tegra30 (Beaver) # usb reset (Re)start USB... USB0: set_host_mode: GPIO 236 high USB EHCI 1.00 scanning bus 0 for devices... 2 USB Device(s) found scanning usb for storage devices... 1 Storage Device(s) found scanning usb for ethernet devices... 0 Ethernet Device(s) found Any idea what might be going on here? Try waiting a little after setting the GPIO maybe? The drive might need some time to settle. I can make it work on the first invocation of usb start by adding a rather long mdelay() at the very end of ehci_hcd_init() in the Tegra EHCI driver. The magic value seems to be 853 ms. 852 ms wasn't enough in any of the test runs. 853 ms always worked. However 850+ ms seems like a very long time for the device to settle, and keeping it in the driver probably isn't a good idea. Furthermore I cannot reproduce the same issue with a newer flash drive, which works fine with no additional delays. Try reverting 020bbcb usb: hub: Power-cycle on root-hub ports ... there's a thread in the ML that it caused issues. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 2/4] NET: macb: support sama5d3x devices
Hi Joe, On 5/24/2013 05:58, Joe Hershberger wrote: Hi, On Thu, May 23, 2013 at 1:51 AM, Andreas Bießmann andreas.de...@googlemail.com wrote: Hi Bo, On 22.05.13 10:45, Bo Shen wrote: Hi Andreas, On 5/14/2013 05:31, Joe Hershberger wrote: On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann andreas.de...@googlemail.com wrote: Dear Bo Shen, On 12.03.2013 07:15, Bo Shen wrote: Add macb support for sama5d3x devices Signed-off-by: Bo Shen voice.s...@atmel.com --- change in v2: No change --- drivers/net/macb.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8bacbda..9e7fbc6 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev, bd_t *bd) #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \ defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20) || \ defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \ - defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) + defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \ + defined(CONFIG_SAMA5D3) I would like to apply http://patchwork.ozlabs.org/patch/239064/ instead of this one. Joe, do you have any objections? Agreed. Just remind to take this patch: net: macb: using AT91FAMILY replace #ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb won't work with sama5d3xek board. I thought this would go through Joe's tree. There are some patches delegated to him regarding sama5 network too (gmac). I could pick up this single patch however, lets wait some days for Joe to work on the whole series. Yes, I hope to be getting to patches assigned to me in patchwork in the next week or so. When will these patches will be dealt. -Joe Best Regards, Bo Shen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Merge Window close date
Hello, web page maintainers. I saw Release Cycle page (http://www.denx.de/wiki/U-Boot/ReleaseCycle), and I noticed, The Merge Window for the next release (v2013.07) was closed on Sat, Feb 09, 2013 23:59:59 CEST ^^^ Could anyone fix it? Best Regards, Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] sandbox: block driver using host file/device as backing store
sön 2013-06-16 klockan 07:50 -0700 skrev Simon Glass: Did you send a new version? I might have missed it. Not yet. Work got in a bit of a panic mode and then been ill for a while. Not forgotten. Regards Henrik ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot,V2] MMC: DWMMC: Fix FIFO_DEPTH calculation
On 14/06/13 07:34, Andy Fleming wrote: On Fri, May 24, 2013 at 06:15:34PM +0530, Rajeshwari Shinde wrote: Current DWMMC driver used to give FIFO underrun/overrun error every 3rd time for mmc rescan command. In current code FIFO_DEPTH is getting calculated after reading the default FIFOTH register and extracting the RX_WMARK bits from it i.e (RX_WMARK = FIFO_DEPTH/2 -1). Instead of storing the correct value, we were recalculating the FIFO_DEPT each time which is not correct. Based on [PATCH V9 3/9] DWMMC: Initialise dwmci and resolve EMMC read write issues http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/160247 Signed-off-by: Hatim Ali hatim...@samsung.com Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com Acked-by: Simon Glass s...@chromium.org Tested-by: Simon Glass s...@chromium.org Acked-by: Jaehoon Chung jh80.ch...@samsung.com Acked-by: Andy Fleming aflem...@freescale.com Looks like the patch this is based on is already accepted, but not yet upstream, so I'm going to delegate the patch to Minkyu Kang applied to u-boot-samsung. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] please pull u-boot-samsung master
Dear Albert, The following changes since commit d0a51373131c4ba565a2391d5ed78b87c406ce98: at91sam9260ek: move board id setup to config header (2013-05-12 16:49:14 +0200) are available in the git repository at: git://git.denx.de/u-boot-samsung master for you to fetch changes up to ed7bdc03eb516fb698ccc12ec5b4b9f132d05c5f: MMC: DWMMC: Fix FIFO_DEPTH calculation (2013-06-17 11:03:42 +0900) Akshay Saraswat (2): Exynos5: clock: Update the equation to calculate PLL output frequency Exynos: uart: s5p: enabling the uart tx/rx fifo Amar (9): FDT: Add compatible string for DWMMC EXYNOS5: FDT: Add DWMMC device node data DWMMC: Initialise dwmci and resolve EMMC read write issues EXYNOS5: DWMMC: Added FDT support for DWMMC EXYNOS5: DWMMC: Initialise the local variable to avoid unwanted results. SMDK5250: Initialise and Enable DWMMC, support FDT and non-FDT MMC: APIs to support resize of EMMC boot partition SMDK5250: Enable EMMC booting COMMON: MMC: Command to support EMMC booting and to resize EMMC boot partition Arkadiusz Wlodarczyk (1): arm:trats: change auto-booting to boot kernel with separate device tree blob Inderpal Singh (3): exynos: move tzpc_init to armv7/exynos exynos: update tzpc to make it common for exynos4 and exynos5 exynos: Update origen and smdkv310 to use common tzpc_init Naveen Krishna Chatradhi (2): power: exynos-tmu: fix warnings and clean up code power: exynos-tmu: use the mux_addr bit fields in tmu_control register Rajeshwari Shinde (3): SF: Add driver for Gigabyte device GD25LQ and GD25Q64B SMDK5250: Enable SPI Gigabyte device. MMC: DWMMC: Fix FIFO_DEPTH calculation arch/arm/cpu/armv7/exynos/Makefile |2 +- arch/arm/cpu/armv7/exynos/clock.c | 10 +- .../arm/cpu/armv7/exynos/tzpc.c| 25 +- arch/arm/cpu/armv7/s5p-common/Makefile |2 + arch/arm/dts/exynos5250.dtsi | 33 ++ arch/arm/include/asm/arch-exynos/cpu.h |4 + arch/arm/include/asm/arch-exynos/dwmmc.h | 11 +- arch/arm/include/asm/arch-exynos/tmu.h | 58 ++- arch/arm/include/asm/arch-exynos/tzpc.h| 20 + board/samsung/dts/exynos5250-smdk5250.dts | 24 ++ board/samsung/origen/lowlevel_init.S | 44 +- board/samsung/origen/origen_setup.h| 25 -- board/samsung/smdk5250/Makefile|5 +- board/samsung/smdk5250/clock_init.c| 18 + board/samsung/smdk5250/clock_init.h|5 + board/samsung/smdk5250/exynos5-dt.c| 423 board/samsung/smdk5250/lowlevel_init.S |2 + board/samsung/smdk5250/setup.h | 25 -- board/samsung/smdk5250/smdk5250.c | 223 +++ board/samsung/smdk5250/spl_boot.c | 64 ++- board/samsung/smdkv310/lowlevel_init.S | 60 +-- common/cmd_mmc.c | 109 - doc/device-tree-bindings/exynos/dwmmc.txt | 54 +++ drivers/mmc/dw_mmc.c | 27 +- drivers/mmc/exynos_dw_mmc.c| 127 +- drivers/mmc/mmc.c | 134 +++ drivers/mtd/spi/Makefile |1 + drivers/mtd/spi/gigadevice.c | 81 drivers/mtd/spi/spi_flash.c|3 + drivers/mtd/spi/spi_flash_internal.h |1 + drivers/power/exynos-tmu.c | 123 +++--- drivers/serial/serial_s5p.c| 13 +- drivers/video/exynos_fb.c |4 +- include/configs/exynos5250-dt.h| 11 +- include/configs/origen.h |2 + include/configs/smdkv310.h |2 + include/configs/trats.h| 17 +- include/dwmmc.h|3 + include/fdtdec.h |1 + include/mmc.h | 26 ++ lib/fdtdec.c |1 + spl/Makefile |4 + 42 files changed, 1356 insertions(+), 471 deletions(-) rename board/samsung/smdk5250/tzpc_init.c = arch/arm/cpu/armv7/exynos/tzpc.c (69%) create mode 100644 board/samsung/smdk5250/exynos5-dt.c create mode 100644 doc/device-tree-bindings/exynos/dwmmc.txt create mode 100644 drivers/mtd/spi/gigadevice.c -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v2 2/4] NET: macb: support sama5d3x devices
Hi Bo, On Sun, Jun 16, 2013 at 8:11 PM, Bo Shen bard.s...@gmail.com wrote: Hi Joe, On 5/24/2013 05:58, Joe Hershberger wrote: Hi, On Thu, May 23, 2013 at 1:51 AM, Andreas Bießmann andreas.de...@googlemail.com wrote: Hi Bo, On 22.05.13 10:45, Bo Shen wrote: Hi Andreas, On 5/14/2013 05:31, Joe Hershberger wrote: On Sun, May 12, 2013 at 6:33 AM, Andreas Bießmann andreas.de...@googlemail.com wrote: Dear Bo Shen, On 12.03.2013 07:15, Bo Shen wrote: Add macb support for sama5d3x devices Signed-off-by: Bo Shen voice.s...@atmel.com --- change in v2: No change --- drivers/net/macb.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8bacbda..9e7fbc6 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -469,7 +469,8 @@ static int macb_init(struct eth_device *netdev, bd_t *bd) #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \ defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20) || \ defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) || \ - defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) + defined(CONFIG_AT91SAM9XE) || defined(CONFIG_AT91SAM9X5) || \ + defined(CONFIG_SAMA5D3) I would like to apply http://patchwork.ozlabs.org/patch/239064/ instead of this one. Joe, do you have any objections? Agreed. Just remind to take this patch: net: macb: using AT91FAMILY replace #ifdeferry (http://patchwork.ozlabs.org/patch/239064/). or else the macb won't work with sama5d3xek board. I thought this would go through Joe's tree. There are some patches delegated to him regarding sama5 network too (gmac). I could pick up this single patch however, lets wait some days for Joe to work on the whole series. Yes, I hope to be getting to patches assigned to me in patchwork in the next week or so. When will these patches will be dealt. I've got all the patches in my local repo and I'm build testing them. I'll likely send a PR by the end of today or tomorrow. Thanks, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/10] PXE support updates
Hi Rob, On Sun, Jun 16, 2013 at 10:24 AM, Rob Herring robherri...@gmail.com wrote: On Tue, May 14, 2013 at 3:32 PM, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Rob, On Tue, May 14, 2013 at 2:48 PM, Rob Herring robherri...@gmail.com wrote: On Sun, Dec 2, 2012 at 9:00 PM, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com This is a series of various enhancements and fixes for u-boot pxe support. These patches are a result of testing with server side tools like Cobbler and ubuntu MAAS. Rob Rob Herring (10): pxe: Use ethact setting for pxe pxe: make string parameters const pxe: fix handling of different localboot values bootz: un-staticize do_bootz pxe: use bootz instead of bootm when enabled pxe: always display a menu when present pxe: simplify menu display and selection pxe: add support for ontimeout token pxe: add support for per arch and SoC default paths pxe: add ipappend support common/cmd_bootm.c |2 +- common/cmd_pxe.c | 210 include/command.h |2 + 3 files changed, 132 insertions(+), 82 deletions(-) Is someone going to pick these patches up? The single comment by Wolfgang I've addressed. Yes... I'll pick these up... apologies for the delays. When can I expect to see these land? I've got these patches in my local repo and I'm build testing them. I'll likely send a PR by the end of today or tomorrow. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114
On Sun, 2013-06-16 at 03:46 +0800, Marek Vasut wrote: Dear Jim Lin, Add DT node for USB EHCI function. Add support for T30-Cardhu, T30-Beaver, T114-Dalmore boards. I'd like to get ACK from someone with the actual hardware. btw. How usable is the cardhu with current U-Boot ? That's the ASUS TF700, right? How can I install U-Boot on it, is there any howto? I know nothing about ASUS TF700. The T30-Cardhu board I have is a demo board. --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. --- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] board/p1010rdb: add pin mux and sdhc support in any boot
SDHC pins are multiplexed with IFC and ULPI interfaces. This patch intends to enable SDHC function in case of NOR/NAND/SPI boot aside from SD boot. If esdhc is configured in hwconfig, u-boot will configure multiplexing pins from default IFC to SDHC at runtime to enable SD function. And add minimal necessary mux command for ifc/sdhc/ulpi to conveniently configure multiplexing pins without reboot or updating u-boot. Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- v2: updated description. board/freescale/p1010rdb/p1010rdb.c | 128 +--- include/configs/P1010RDB.h | 11 ++-- 2 files changed, 125 insertions(+), 14 deletions(-) diff --git a/board/freescale/p1010rdb/p1010rdb.c b/board/freescale/p1010rdb/p1010rdb.c index 0c30d76..5a2f1f0 100644 --- a/board/freescale/p1010rdb/p1010rdb.c +++ b/board/freescale/p1010rdb/p1010rdb.c @@ -37,10 +37,8 @@ #include asm/fsl_serdes.h #include asm/fsl_ifc.h #include asm/fsl_pci.h - -#ifndef CONFIG_SDCARD #include hwconfig.h -#endif +#include i2c.h DECLARE_GLOBAL_DATA_PTR; @@ -49,6 +47,19 @@ DECLARE_GLOBAL_DATA_PTR; #define MUX_CPLD_TDM 0x01 #define MUX_CPLD_SPICS0_FLASH 0x00 #define MUX_CPLD_SPICS0_SLIC 0x02 +#define PMUXCR1_IFC_MASK 0x0000 +#define PMUXCR1_SDHC_MASK 0x00fff000 +#define PMUXCR1_SDHC_ENABLE0x00555000 +#define PMUXCR1_ULPI_MASK 0x00c0 +#define PMUXCR1_ULPI_ENABLE0x0080 + +enum { + MUX_TYPE_IFC, + MUX_TYPE_SDHC, + MUX_TYPE_ULPI, +}; + +uint pin_mux; #ifndef CONFIG_SDCARD struct cpld_data { @@ -262,6 +273,16 @@ void fdt_del_sdhc(void *blob) } } +void fdt_del_ifc(void *blob) +{ + int nodeoff = 0; + + while ((nodeoff = fdt_node_offset_by_compatible(blob, 0, + fsl,ifc)) = 0) { + fdt_del_node(blob, nodeoff); + } +} + void fdt_disable_uart1(void *blob) { int nodeoff; @@ -305,9 +326,13 @@ void ft_board_setup(void *blob, bd_t *bd) fdt_del_flexcan(blob); fdt_del_node_and_alias(blob, ethernet2); } -#ifndef CONFIG_SDCARD - /* disable sdhc due to sdhc bug */ - fdt_del_sdhc(blob); + + /* Delete IFC node as IFC pins are multiplexing with SDHC */ + if (pin_mux != MUX_TYPE_IFC) + fdt_del_ifc(blob); + else + fdt_del_sdhc(blob); + if (hwconfig_subarg_cmp(fsl_p1010mux, tdm_can, can)) { fdt_del_tdm(blob); fdt_del_spi_slic(blob); @@ -325,13 +350,72 @@ void ft_board_setup(void *blob, bd_t *bd) fdt_del_flexcan(blob); fdt_disable_uart1(blob); } -#endif } #endif +int config_pin_mux(int if_type) +{ + ccsr_gur_t __iomem *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); + u8 tmp; + uint orig_bus = i2c_get_bus_num(); + + i2c_set_bus_num(CONFIG_SYS_PCA9557_BUS_NUM); + tmp = 0xf0; + if (i2c_write(CONFIG_SYS_I2C_PCA9557_ADDR, 3, 1, tmp, 1) 0) + goto wr_err; + + switch (if_type) { + case MUX_TYPE_IFC: + tmp = 0x01; + if (i2c_write(CONFIG_SYS_I2C_PCA9557_ADDR, 1, 1, tmp, 1) 0) + goto wr_err; + pin_mux = MUX_TYPE_IFC; + clrbits_be32(gur-pmuxcr, PMUXCR1_IFC_MASK); + debug(pin mux is configured for IFC, SDHC disabled\n); + break; + case MUX_TYPE_SDHC: + tmp = 0x05; + if (i2c_write(CONFIG_SYS_I2C_PCA9557_ADDR, 1, 1, tmp, 1) 0) + goto wr_err; + pin_mux = MUX_TYPE_SDHC; + clrsetbits_be32(gur-pmuxcr, PMUXCR1_SDHC_MASK, + PMUXCR1_SDHC_ENABLE); + debug(pin mux is configured for SDHC, IFC disabled\n); + break; + case MUX_TYPE_ULPI: + tmp = 0x06; + if (i2c_write(CONFIG_SYS_I2C_PCA9557_ADDR, 1, 1, tmp, 1) 0) + goto wr_err; + pin_mux = MUX_TYPE_ULPI; + clrsetbits_be32(gur-pmuxcr, PMUXCR1_ULPI_MASK, + PMUXCR1_ULPI_ENABLE); + debug(pin mux is configured for ULPI, IFC SDHC disabled\n); + break; + default: + printf(wrong mux interface type\n); + i2c_set_bus_num(orig_bus); + return -1; + } + i2c_set_bus_num(orig_bus); + return 0; +wr_err: + printf(pca9557: i2c write failed\n); + i2c_set_bus_num(orig_bus); + return -1; +} + #ifndef CONFIG_SDCARD +void board_reset(void) +{ + /* mux to IFC to enable CPLD for reset */ + if (pin_mux != MUX_TYPE_IFC) + config_pin_mux(MUX_TYPE_IFC); +} +#endif + int misc_init_r(void) { +#ifndef CONFIG_SDCARD struct cpld_data *cpld_data = (void
[U-Boot] [PATCH v2] dfu, nand: before write a buffer to nand, erase the nand sectors
before writing the received buffer to nand, erase the nand sectors. If not doing this, nand write fails. See for more info here: http://lists.denx.de/pipermail/u-boot/2013-June/156361.html Signed-off-by: Heiko Schocher h...@denx.de Cc: Scott Wood scottw...@freescale.com Cc: Pantelis Antoniou pa...@antoniou-consulting.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek Vasut ma...@denx.de Cc: Tom Rini tr...@ti.com --- - changes for v2: - use opts.spread as Scott Wood suggested drivers/dfu/dfu_nand.c | 17 +++-- 1 Datei geändert, 15 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c index 7dc89b2..93db9bd 100644 --- a/drivers/dfu/dfu_nand.c +++ b/drivers/dfu/dfu_nand.c @@ -63,12 +63,25 @@ static int nand_block_op(enum dfu_nand_op op, struct dfu_entity *dfu, nand = nand_info[nand_curr_device]; - if (op == DFU_OP_READ) + if (op == DFU_OP_READ) { ret = nand_read_skip_bad(nand, start, count, actual, lim, buf); - else + } else { + nand_erase_options_t opts; + + memset(opts, 0, sizeof(opts)); + opts.offset = start; + opts.length = count; + opts.spread = 1; + opts.quiet = 1; + /* first erase */ + ret = nand_erase_opts(nand, opts); + if (ret) + return ret; + /* then write */ ret = nand_write_skip_bad(nand, start, count, actual, lim, buf, 0); + } if (ret != 0) { printf(%s: nand_%s_skip_bad call failed at %llx!\n, -- 1.7.11.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] video: lcd: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO
Hi Robert, On 06/14/13 20:00, Robert Winkler wrote: Create splash.c/h to put the function and any future common splash screen code in. Signed-off-by: Robert Winkler robert.wink...@boundarydevices.com Thanks for the effort! Several comments below... --- common/Makefile | 1 + common/lcd.c| 19 ++- common/splash.c | 37 + drivers/video/cfb_console.c | 8 ++-- include/lcd.h | 1 - include/splash.h| 30 ++ 6 files changed, 80 insertions(+), 16 deletions(-) create mode 100644 common/splash.c create mode 100644 include/splash.h diff --git a/common/Makefile b/common/Makefile index 0e0fff1..1d70584 100644 --- a/common/Makefile +++ b/common/Makefile @@ -203,6 +203,7 @@ COBJS-y += flash.o COBJS-$(CONFIG_CMD_KGDB) += kgdb.o kgdb_stubs.o COBJS-$(CONFIG_I2C_EDID) += edid.o COBJS-$(CONFIG_KALLSYMS) += kallsyms.o +COBJS-y += splash.o I think this should depend on CONFIG_SPLASH_SCREEN. COBJS-$(CONFIG_LCD) += lcd.o COBJS-$(CONFIG_LYNXKDI) += lynxkdi.o COBJS-$(CONFIG_MENU) += menu.o diff --git a/common/lcd.c b/common/lcd.c index 3a60484..4a85ebb 100644 --- a/common/lcd.c +++ b/common/lcd.c @@ -43,6 +43,11 @@ #include lcd.h #include watchdog.h +/* + * Include splash.h for splash_screen_prepare() etc. + */ I think this comment is meaningless, the below include is self explanatory. +#include splash.h + #if defined(CONFIG_CPU_PXA25X) || defined(CONFIG_CPU_PXA27X) || \ defined(CONFIG_CPU_MONAHANS) #define CONFIG_CPU_PXA @@ -1072,18 +1077,6 @@ int lcd_display_bitmap(ulong bmp_image, int x, int y) } #endif -#ifdef CONFIG_SPLASH_SCREEN_PREPARE -static inline int splash_screen_prepare(void) -{ - return board_splash_screen_prepare(); -} -#else -static inline int splash_screen_prepare(void) -{ - return 0; -} -#endif - static void *lcd_logo(void) { #ifdef CONFIG_SPLASH_SCREEN @@ -1096,7 +1089,7 @@ static void *lcd_logo(void) do_splash = 0; if (splash_screen_prepare()) - return (void *)gd-fb_base; + return (void *)lcd_base; addr = simple_strtoul (s, NULL, 16); #ifdef CONFIG_SPLASH_SCREEN_ALIGN diff --git a/common/splash.c b/common/splash.c new file mode 100644 index 000..fe13c69 --- /dev/null +++ b/common/splash.c @@ -0,0 +1,37 @@ +/* + * Copyright (C) 2013, Boundary Devices i...@boundarydevices.com + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA I would drop the postal address, as it changed in the past and probably will change in the future and then we will have a bunch of files with wrong address... + */ + +#include splash.h +#include config.h + +#ifdef CONFIG_SPLASH_SCREEN_PREPARE +int splash_screen_prepare(void) +{ + return board_splash_screen_prepare(); +} +#else +int splash_screen_prepare(void) +{ + printf(SPLASH_SCREEN_PREPARE not defined\n); + return 0; +} +#endif diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c index b769222..4543730 100644 --- a/drivers/video/cfb_console.c +++ b/drivers/video/cfb_console.c @@ -178,6 +178,11 @@ #include video_fb.h /* + * Include splash.h for splash_screen_prepare() etc. + */ Same here, the below include does not need any comment. +#include splash.h + +/* * some Macros */ #define VIDEO_VISIBLE_COLS (pGD-winSizeX) @@ -1991,10 +1996,9 @@ static void *video_logo(void) #ifdef CONFIG_SPLASH_SCREEN s = getenv(splashimage); if (s != NULL) { - + splash_screen_prepare(); addr = simple_strtoul(s, NULL, 16); - if (video_display_bitmap(addr, video_logo_xpos, video_logo_ypos) == 0) { diff --git a/include/lcd.h b/include/lcd.h index 30225ed..79bf13e 100644 --- a/include/lcd.h +++ b/include/lcd.h @@ -37,7 +37,6 @@ extern struct vidinfo panel_info; void lcd_ctrl_init(void *lcdbase); void lcd_enable(void); -int
Re: [U-Boot] [PATCH 0/2] video: lcd: splash screen prepare changes
On 06/14/13 20:00, Robert Winkler wrote: These 2 patches are the result of discussion in these threads: http://lists.denx.de/pipermail/u-boot/2013-May/155463.html http://lists.denx.de/pipermail/u-boot/2013-June/155630.html http://lists.denx.de/pipermail/u-boot/2013-June/155632.html The upshot is, move splash_screen_prepare to a common location so it can be used in cfb_console.c and (possibly) make it weak. These 2 patches do that and the first can be accepted without the second if we decide not to make it weak. One other note, I'm submitting this based on Anatolij's tree since it's video related but board/compulab/cm_t35 does not exist in his tree. That's because recently I've moved it from board/cm_t35 to board/compulab/cm_t35 and probably Anatolij has not updated his tree to the latest upstream. If the second patch is accepted, cm_t35 will have to change since it uses the non-weak method. I will submit an optional 3rd patch to Stefano's tree with the necessary changes. Robert Winkler (2): video: lcd: Add CONFIG_SPLASH_SCREEN_PREPARE support to CONFIG_VIDEO video: lcd: Make splash_screen_prepare weak, remove config macro README | 8 common/Makefile | 1 + common/lcd.c| 19 ++- common/splash.c | 31 +++ doc/README.splashprepare| 8 drivers/video/cfb_console.c | 8 ++-- include/lcd.h | 1 - include/splash.h| 30 ++ 8 files changed, 82 insertions(+), 24 deletions(-) create mode 100644 common/splash.c create mode 100644 doc/README.splashprepare create mode 100644 include/splash.h -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cm_t35: Fix cm_t35 for weak splash_screen_prepare
Hi Robert, We lack a commit message here... On 06/14/13 22:31, Robert Winkler wrote: Signed-off-by: Robert Winkler robert.wink...@boundarydevices.com --- Also, I would write here (not a part of commit message) that this patch should be applied only in case the patch: video: lcd: Make splash_screen_prepare weak, remove config macro is applied. May be it is even better to make this patch the 3rd in the series changing the splash prepare stuff? board/compulab/cm_t35/cm_t35.c | 2 +- include/configs/cm_t35.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c index b0b80e5..95098af 100644 --- a/board/compulab/cm_t35/cm_t35.c +++ b/board/compulab/cm_t35/cm_t35.c @@ -120,7 +120,7 @@ static inline int splash_load_from_nand(void) } #endif /* CONFIG_CMD_NAND */ -int board_splash_screen_prepare(void) +int splash_screen_prepare(void) { char *env_splashimage_value; u32 bmp_load_addr; diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h index c6e357a..b258da9 100644 --- a/include/configs/cm_t35.h +++ b/include/configs/cm_t35.h @@ -339,6 +339,5 @@ #define CONFIG_SPLASH_SCREEN #define CONFIG_CMD_BMP #define CONFIG_BMP_16BPP -#define CONFIG_SPLASH_SCREEN_PREPARE #endif /* __CONFIG_H */ -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot