[U-Boot] [PATCH 0/7] arm: add runtime envs describing build configuration
This patchset adds runtime variables for Samsung boards that describe build configuration (arch, soc, board, vendor). Additionally, more envs describing platform (soc and board revision) are added to Samsung common code. For boards Trats and Trats2, based on the added envs, 'fdtaddr' env is set and dual kernel boot is enabled: - with separated DTB if the DTB file is loaded successfully; - with DTB apppended to uImage if DTB file is not found; This is neccesssary for backward compatibilty. Piotr Wilczek (7): arm:exynos: add cpu revision arm:s5pc110: add cpu revision board:samsung:common: set envs with board unified information board:samsung:goni: add env variables describing platform board:samsung:universal: add env variables describing platform board:samsung:trats: enable boot with appended and separated DTB board:samsung:trats2: enable boot with appended and separated DTB arch/arm/include/asm/arch-exynos/cpu.h |8 ++-- arch/arm/include/asm/arch-s5pc1xx/cpu.h |7 +++ board/samsung/common/misc.c | 29 + board/samsung/goni/goni.c |5 + include/configs/s5p_goni.h |4 include/configs/s5pc210_universal.h |5 + include/configs/trats.h | 14 +++--- include/configs/trats2.h| 13 ++--- 8 files changed, 77 insertions(+), 8 deletions(-) -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/7] arm:exynos: add cpu revision
This patch enables to read cpu revision on Exynos CPU. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/include/asm/arch-exynos/cpu.h |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/arch-exynos/cpu.h b/arch/arm/include/asm/arch-exynos/cpu.h index 573f755..bccce63 100644 --- a/arch/arm/include/asm/arch-exynos/cpu.h +++ b/arch/arm/include/asm/arch-exynos/cpu.h @@ -185,9 +185,11 @@ static inline int s5p_get_cpu_rev(void) static inline void s5p_set_cpu_id(void) { - unsigned int pro_id = (readl(EXYNOS4_PRO_ID) 0x00FFF000) 12; + unsigned int pro_id = readl(EXYNOS4_PRO_ID); + unsigned int cpu_id = (pro_id 0x00FFF000) 12; + unsigned int cpu_rev = pro_id 0x00FF; - switch (pro_id) { + switch (cpu_id) { case 0x200: /* Exynos4210 EVT0 */ s5p_cpu_id = 0x4210; @@ -196,10 +198,12 @@ static inline void s5p_set_cpu_id(void) case 0x210: /* Exynos4210 EVT1 */ s5p_cpu_id = 0x4210; + s5p_cpu_rev = cpu_rev; break; case 0x412: /* Exynos4412 */ s5p_cpu_id = 0x4412; + s5p_cpu_rev = cpu_rev; break; case 0x520: /* Exynos5250 */ -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 6/7] board:samsung:trats: enable boot with appended and separated DTB
This patch adds variables describing platform (soc, board, vendor) to default environment and Samsung's common misc initialisation to provide additional board information in envs. This patch modifies envs to enable dual kernel boot - with separated DTB if the DTB file is loaded successfully; - with DTB apppended to uImage if DTB file is not found; This is neccesssary for backward compatibilty. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com --- include/configs/trats.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/configs/trats.h b/include/configs/trats.h index 0877142..71b1a4e 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -148,9 +148,16 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + #define CONFIG_EXTRA_ENV_SETTINGS \ bootk= \ - run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0 \ + run loaduimage; \ + if run loaddtb; then \ + bootm 0x40007FC0 - ${fdtaddr}; \ + fi; \ + bootm 0x40007FC0;\0 \ updatemmc= \ mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200; \ mmc boot 0 1 1 0\0 \ @@ -173,7 +180,7 @@ mmcboot= \ setenv bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} \ ${lpj} rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; \ - run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0 \ + run loaddtb; run bootk\0 \ bootchart=setenv opts init=/sbin/bootchartd; run bootcmd\0 \ boottrace=setenv opts initcall_debug; run bootcmd\0 \ mmcoops=mmc read 0 0x4000 0x40 8; md 0x4000 0x400\0 \ @@ -212,7 +219,6 @@ setenv spl_imgaddr; \ setenv spl_addr_tmp;\0 \ fdtaddr=4080\0 \ - fdtfile=exynos4210-trats.dtb\0 /* Miscellaneous configurable options */ @@ -254,6 +260,8 @@ #define CONFIG_DOS_PARTITION #define CONFIG_EFI_PARTITION +#define CONFIG_MISC_INIT_R + /* EXT4 */ #define CONFIG_CMD_EXT4 #define CONFIG_CMD_EXT4_WRITE -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/7] board:samsung:common: set envs with board unified information
This patch enables to set envs that describe board information. The following envs are set (but not saved): soc_id, soc_rev, board_rev. Based on this information, 'fdtaddr' env is set (not saved) as: fdtaddr=${soc_family}${soc_id}-${board}.dtb Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- board/samsung/common/misc.c | 29 + 1 file changed, 29 insertions(+) diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c index 3764d12..2d81df9 100644 --- a/board/samsung/common/misc.c +++ b/board/samsung/common/misc.c @@ -7,8 +7,37 @@ #include common.h +extern u32 get_board_rev(void); + +#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG +void set_board_info(void) +{ + char info[64]; + + snprintf(info, ARRAY_SIZE(info), %d.%d, s5p_cpu_rev 0x0f, +(s5p_cpu_rev 0xf0) 0x04); + setenv(soc_rev, info); + + snprintf(info, ARRAY_SIZE(info), %x, s5p_cpu_id); + setenv(soc_id, info); + + snprintf(info, ARRAY_SIZE(info), %x, get_board_rev()); + setenv(board_rev, info); + +#ifdef CONFIG_OF_LIBFDT + snprintf(info, ARRAY_SIZE(info), %s%x-%s.dtb, +CONFIG_SYS_SOC, s5p_cpu_id, CONFIG_SYS_BOARD); + setenv(fdtfile, info); +#endif +} +#endif + /* Common for Samsung boards */ int misc_init_r(void) { +#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + set_board_info(); +#endif + return 0; } -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform
This patch adds variables describing platform (soc, board, vendor) to default environment. Samsung's common misc imitialisation is enabled to provide additional board information in envs. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Przemyslaw Marczak p.marc...@samsung.com --- include/configs/s5pc210_universal.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index d9e4c56..5e5f8e0 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -124,6 +124,11 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define CONFIG_MISC_INIT_R + #define CONFIG_EXTRA_ENV_SETTINGS \ updateb= \ onenand erase 0x0 0x10; \ -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 7/7] board:samsung:trats2: enable boot with appended and separated DTB
This patch adds variables describing platform (soc, board, vendor) to default environment and Samsung's common misc initialisation to provide additional board information in envs. This patch modifies envs to enable dual kernel boot - with separated DTB if the DTB file is loaded successfully; - with DTB apppended to uImage if DTB file is not found; This is neccesssary for backward compatibilty. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/configs/trats2.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/include/configs/trats2.h b/include/configs/trats2.h index 7dfbe98..9d1b461 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -150,6 +150,9 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + /* Tizen - partitions definitions */ #define PARTS_CSA csa #define PARTS_BOOT boot @@ -177,7 +180,11 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ bootk= \ - run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0 \ + run loaduimage; \ + if run loaddtb; then \ + bootm 0x40007FC0 - ${fdtaddr}; \ + fi; \ + bootm 0x40007FC0;\0 \ updatemmc= \ mmc boot 0 1 1 1; mmc write 0x42008000 0 0x200; \ mmc boot 0 1 1 0\0 \ @@ -191,7 +198,7 @@ mmcboot= \ setenv bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} \ ${lpj} rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; \ - run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0 \ + run bootk\0 \ bootchart=set opts init=/sbin/bootchartd; run bootcmd\0 \ boottrace=setenv opts initcall_debug; run bootcmd\0 \ verify=n\0 \ @@ -232,7 +239,6 @@ setenv spl_imgaddr; \ setenv spl_addr_tmp;\0 \ fdtaddr=4080\0 \ - fdtfile=exynos4412-trats2.dtb\0 /* * Miscellaneous configurable options @@ -272,6 +278,7 @@ #define CONFIG_EFI_PARTITION #define CONFIG_PARTITION_UUIDS +#define CONFIG_MISC_INIT_R #define CONFIG_BOARD_EARLY_INIT_F /* I2C */ -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/7] arm:s5pc110: add cpu revision
This patch adds s5p_cpu_rev. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/include/asm/arch-s5pc1xx/cpu.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/include/asm/arch-s5pc1xx/cpu.h b/arch/arm/include/asm/arch-s5pc1xx/cpu.h index 4fc5a0c..5ae5c87 100644 --- a/arch/arm/include/asm/arch-s5pc1xx/cpu.h +++ b/arch/arm/include/asm/arch-s5pc1xx/cpu.h @@ -51,10 +51,17 @@ #include asm/io.h /* CPU detection macros */ extern unsigned int s5p_cpu_id; +extern unsigned int s5p_cpu_rev; + +static inline int s5p_get_cpu_rev(void) +{ + return s5p_cpu_rev; +} static inline void s5p_set_cpu_id(void) { s5p_cpu_id = readl(S5PC100_PRO_ID); + s5p_cpu_rev = s5p_cpu_id 0x00FF; s5p_cpu_id = 0xC000 | ((s5p_cpu_id 0x00FFF000) 12); } -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 4/7] board:samsung:goni: add env variables describing platform
This patch adds variables describing platform (soc, board, vendor) to default environment. Samsung's common misc imitialisation is enabled to provide additional board information in envs. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Mateusz Zalega m.zal...@samsung.com --- board/samsung/goni/goni.c |5 + include/configs/s5p_goni.h |4 2 files changed, 9 insertions(+) diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c index 366f648..fb0435e 100644 --- a/board/samsung/goni/goni.c +++ b/board/samsung/goni/goni.c @@ -17,6 +17,11 @@ DECLARE_GLOBAL_DATA_PTR; static struct s5pc110_gpio *s5pc110_gpio; +u32 get_board_rev(void) +{ + return 0; +} + int board_init(void) { /* Set Initial global variables */ diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h index 0590d20..82a8a8c 100644 --- a/include/configs/s5p_goni.h +++ b/include/configs/s5p_goni.h @@ -113,8 +113,12 @@ #define CONFIG_UBIFS_OPTIONrootflags=bulk_read,no_chk_data_crc +#define CONFIG_MISC_INIT_R + #define CONFIG_ENV_OVERWRITE #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG #define CONFIG_EXTRA_ENV_SETTINGS \ CONFIG_UPDATEB \ updatek= \ -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 04/12] samsung: misc: move display logo function to misc.c file.
Hello Jaehoon, On 01/14/2014 04:41 AM, Jaehoon Chung wrote: Dear Przemyslaw, On 01/10/2014 11:31 PM, Przemyslaw Marczak wrote: board/samsung/common/misc.c: - move draw_logo() function from exynos_fb.c - add get_tizen_logo_info() function call removed from board files boards: - update board files - add CONFIG_MISC_INIT_R to Universal, Trats and Trats2 Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Tested-by: Hyungwon Hwang human.hw...@samsung.com --- changes v2: - configs cleanup - add check logo address before display Changes v3: - none Changes v4: - none Changes v5: - none board/samsung/common/misc.c | 42 ++ board/samsung/trats/trats.c |3 --- board/samsung/trats2/trats2.c|4 --- board/samsung/universal_c210/universal.c |4 --- drivers/video/exynos_fb.c| 28 include/configs/s5pc210_universal.h |3 +++ include/configs/trats.h |3 +++ include/configs/trats2.h |3 +++ 8 files changed, 51 insertions(+), 39 deletions(-) diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c index 3764d12..6188e29 100644 --- a/board/samsung/common/misc.c +++ b/board/samsung/common/misc.c @@ -6,9 +6,51 @@ */ #include common.h +#include lcd.h +#include libtizen.h + +#ifdef CONFIG_CMD_BMP +static void draw_logo(void) +{ + int x, y; + ulong addr; + +#ifdef CONFIG_TIZEN + get_tizen_logo_info(panel_info); +#else + return; if CONFIG_TINZE didn't set, draw_logo should be just return, right? Then I think this point could be changed more readable. #ifdef CONFIG_TIZEN int x, y; ulong addr; get_tizen_logo_info(...); add = panel_info.logo_addr; ... bmp_display(addr, x, y); #endif how about? Best Regards, Jaehoon Chung You know, this file is common for all Samsung platforms, and I think this function should not depends only on Tizen logo. In this case user can choose other logo just by adding function like get_logo instead of the return statement. I also think that there is need for some common function which allows set proper logo by board config, but maybe not in this patch set? Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mini2440: remove board support
Hi Minkyu, On Tue, 14 Jan 2014 09:51:48 +0900, Minkyu Kang mk7.k...@samsung.com wrote: On 14/01/14 05:06, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- board/friendlyarm/mini2440/Makefile | 8 -- board/friendlyarm/mini2440/mini2440.c | 118 board/friendlyarm/mini2440/mini2440.h | 144 -- boards.cfg| 1 - doc/README.mini2440 | 28 --- doc/README.scrapyard | 5 +- 6 files changed, 3 insertions(+), 301 deletions(-) delete mode 100644 board/friendlyarm/mini2440/Makefile delete mode 100644 board/friendlyarm/mini2440/mini2440.c delete mode 100644 board/friendlyarm/mini2440/mini2440.h delete mode 100644 doc/README.mini2440 Acked-by: Minkyu Kang mk7.k...@samsung.com Thanks, Minkyu Kang. Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mx1ads: remove board support
Hi Stefano, On Mon, 13 Jan 2014 23:15:48 +0100, Stefano Babic sba...@denx.de wrote: On 13/01/2014 21:06, Albert ARIBAUD wrote: Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- board/mx1ads/Makefile| 16 --- board/mx1ads/lowlevel_init.S | 68 -- board/mx1ads/mx1ads.c| 178 - board/mx1ads/syncflash.c | 307 --- boards.cfg | 1 - doc/README.scrapyard | 1 + include/configs/mx1ads.h | 163 --- 7 files changed, 1 insertion(+), 733 deletions(-) delete mode 100644 board/mx1ads/Makefile delete mode 100644 board/mx1ads/lowlevel_init.S delete mode 100644 board/mx1ads/mx1ads.c delete mode 100644 board/mx1ads/syncflash.c delete mode 100644 include/configs/mx1ads.h diff --git a/board/mx1ads/Makefile b/board/mx1ads/Makefile deleted file mode 100644 index 6dfd18e..000 --- a/board/mx1ads/Makefile +++ /dev/null @@ -1,16 +0,0 @@ -# -# board/mx1ads/Makefile -# -# (C) Copyright 2006 -# Wolfgang Denk, DENX Software Engineering, w...@denx.de. -# -# (c) Copyright 2004 -# Techware Information Technology, Inc. -# http://www.techware.com.tw/ -# -# Ming-Len Wu minglen...@techware.com.tw -# -# SPDX-License-Identifier: GPL-2.0+ - -obj-y := mx1ads.o syncflash.o -obj-y += lowlevel_init.o diff --git a/board/mx1ads/lowlevel_init.S b/board/mx1ads/lowlevel_init.S deleted file mode 100644 index d1e472a..000 --- a/board/mx1ads/lowlevel_init.S +++ /dev/null @@ -1,68 +0,0 @@ -/* - * board/mx1ads/lowlevel_init.S - * - * (c) Copyright 2004 - * Techware Information Technology, Inc. - * http://www.techware.com.tw/ - * - * Ming-Len Wu minglen...@techware.com.tw - * - * SPDX-License-Identifier:GPL-2.0+ - */ - -#include config.h -#include version.h - -#define SDCTL0 0x221000 -#define SDCTL1 0x221004 - - -_TEXT_BASE: - .word CONFIG_SYS_TEXT_BASE - -.globl lowlevel_init -lowlevel_init: -/* memory controller init */ - - ldr r1, =SDCTL0 - -/* Set Precharge Command */ - - ldr r3, =0x92120200 -/* ldr r3, =0x92120251 -*/ - str r3, [r1] - -/* Issue Precharge All Commad */ - ldr r3, =0x820 - ldr r2, [r3] - -/* Set AutoRefresh Command */ - ldr r3, =0xA2120200 - str r3, [r1] - -/* Issue AutoRefresh Command */ - ldr r3, =0x800 - ldr r2, [r3] - ldr r2, [r3] - ldr r2, [r3] - ldr r2, [r3] - ldr r2, [r3] - ldr r2, [r3] - ldr r2, [r3] - ldr r2, [r3] - -/* Set Mode Register */ - ldr r3, =0xB2120200 - str r3, [r1] - -/* Issue Mode Register Command */ - ldr r3, =0x08111800/* Mode Register Value */ - ldr r2, [r3] - -/* Set Normal Mode */ - ldr r3, =0x82124200 - str r3, [r1] - -/* everything is fine now */ - mov pc, lr diff --git a/board/mx1ads/mx1ads.c b/board/mx1ads/mx1ads.c deleted file mode 100644 index 4266048..000 --- a/board/mx1ads/mx1ads.c +++ /dev/null @@ -1,178 +0,0 @@ -/* - * board/mx1ads/mx1ads.c - * - * (c) Copyright 2004 - * Techware Information Technology, Inc. - * http://www.techware.com.tw/ - * - * Ming-Len Wu minglen...@techware.com.tw - * - * SPDX-License-Identifier:GPL-2.0+ - */ - -#include common.h -#include netdev.h -/*#include mc9328.h*/ -#include asm/arch/imx-regs.h -#include asm/io.h - -DECLARE_GLOBAL_DATA_PTR; - -#define FCLK_SPEED 1 - -#if FCLK_SPEED==0 /* Fout = 203MHz, Fin = 12MHz for Audio */ -#define M_MDIV 0xC3 -#define M_PDIV 0x4 -#define M_SDIV 0x1 -#elif FCLK_SPEED==1/* Fout = 202.8MHz */ -#define M_MDIV 0xA1 -#define M_PDIV 0x3 -#define M_SDIV 0x1 -#endif - -#define USB_CLOCK 1 - -#if USB_CLOCK==0 -#define U_M_MDIV 0xA1 -#define U_M_PDIV 0x3 -#define U_M_SDIV 0x1 -#elif USB_CLOCK==1 -#define U_M_MDIV 0x48 -#define U_M_PDIV 0x3 -#define U_M_SDIV 0x2 -#endif - -#if 0 - -static inline void delay (unsigned long loops) -{ - __asm__ volatile (1:\n - subs %0, %1, #1\n - bne 1b:=r (loops):0 (loops)); -} - -#endif - -/* - * Miscellaneous platform dependent initialisations - */ - -void SetAsynchMode (void) -{ - __asm__ (mrc p15,0,r0,c1,c0,0 \n -mov r2, #0xC000 \n -orr r0,r2,r0 \n mcr p15,0,r0,c1,c0,0 \n); -} - -static u32 mc9328sid; - -int board_early_init_f(void) -{ - mc9328sid = SIDR; - - GPCR = 0x03AB; /* I/O pad driving strength */ - - /*
Re: [U-Boot] [PATCH] board:universal: fix i2c adapter
Hi, On 01/14/2014 08:15 AM, Piotr Wilczek wrote: Universal uses only one adapter I2C_0. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- board/samsung/universal_c210/universal.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c index 54d0e1e..3feef3f 100644 --- a/board/samsung/universal_c210/universal.c +++ b/board/samsung/universal_c210/universal.c @@ -49,7 +49,7 @@ int power_init_board(void) * For PMIC the I2C bus is named as I2C5, but it is connected * to logical I2C adapter 0 */ - ret = pmic_init(I2C_5); + ret = pmic_init(I2C_0); if (ret) return ret; Acked-by: Przemyslaw Marczak p.marc...@samsung.com Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] net/bootp: add CONFIG_BOOTP_BOOTFILE
In some cases the TFTP server provides a bootfile name, which does not expects our requirements. Make it possible to not store the TFTP provided bootfile in the environment. Signed-off-by: Christian Gmeiner christian.gmei...@gmail.com --- README |4 net/bootp.c |2 ++ 2 files changed, 6 insertions(+) diff --git a/README b/README index aea82be..dc5c153 100644 --- a/README +++ b/README @@ -1921,6 +1921,10 @@ CBFS (Coreboot Filesystem) support CONFIG_BOOTP_SERVERIP - TFTP server will be the serverip environment variable, not the BOOTP server. + CONFIG_BOOTP_BOOTFILE - TFTP bootfile will be the bootfile + environment variable, not the filename provided by + BOOTP server. + CONFIG_BOOTP_MAY_FAIL - If the DHCP server is not found after the configured retry count, the call will fail instead of starting over. This can be used to fail over diff --git a/net/bootp.c b/net/bootp.c index 4300f1c..5e76827 100644 --- a/net/bootp.c +++ b/net/bootp.c @@ -106,6 +106,7 @@ static void BootpCopyNetParams(struct Bootp_t *bp) memcpy(NetServerEther, ((struct ethernet_hdr *)NetRxPacket)-et_src, 6); #endif NetCopyIP(NetOurIP, bp-bp_yiaddr); +#if !defined(CONFIG_BOOTP_BOOTFILE) if (strlen(bp-bp_file) 0) copy_filename(BootFile, bp-bp_file, sizeof(BootFile)); @@ -117,6 +118,7 @@ static void BootpCopyNetParams(struct Bootp_t *bp) */ if (*BootFile) setenv(bootfile, BootFile); +#endif } static int truncate_sz(const char *name, int maxlen, int curlen) -- 1.7.10.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/9] kmp204x: support for QRIO1 bootcounter
Hi Stefan, On 01/14/2014 07:58 AM, Stefan Roese wrote: Hi Valentin, On 13.01.2014 17:29, Valentin Longchamp wrote: From: Rainer Boschung rainer.bosch...@keymile.com - make use of the QRIO1 32bit register at 0x20 as bootcounter register - check for BOOTCOUNT_MAGIC pattern when before bootcounter value is read Signed-off-by: Rainer Boschung rainer.bosch...@keymile.com Signed-off-by: Valentin Longchamp valentin.longch...@keymile.com Acked-by: Valentin Longchamp valentin.longch...@keymile.com --- board/keymile/kmp204x/kmp204x.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/board/keymile/kmp204x/kmp204x.c b/board/keymile/kmp204x/kmp204x.c index f02642a..b41929a 100644 --- a/board/keymile/kmp204x/kmp204x.c +++ b/board/keymile/kmp204x/kmp204x.c @@ -134,22 +134,25 @@ void qrio_prstcfg(u8 bit, u8 mode) } -#define BOOTCOUNT_OFF 0x12 +#define BOOTCOUNT_OFF 0x20 void bootcount_store(ulong counter) { -u8 val; void __iomem *qrio_base = (void *)CONFIG_SYS_QRIO_BASE; -val = (counter = 255) ? (u8)counter : 255; -out_8(qrio_base + BOOTCOUNT_OFF, val); +out_be32(qrio_base + BOOTCOUNT_OFF, counter); } ulong bootcount_load(void) { -u8 val; +u32 val; void __iomem *qrio_base = (void *)CONFIG_SYS_QRIO_BASE; -val = in_8(qrio_base + BOOTCOUNT_OFF); +val = in_be32(qrio_base + BOOTCOUNT_OFF + 4); + +if (val == BOOTCOUNT_MAGIC) +val = in_be32(qrio_base + BOOTCOUNT_OFF); +else +val = 0; return val; } Can't you just use the common bootcount driver (drivers/bootcount/bootcount.c) instead? Should be easy. Just define this in your config header: #define CONFIG_BOOTCOUNT_LIMIT #define CONFIG_SYS_BOOTCOUNT_ADDR (CONFIG_SYS_QRIO_BASE + 0x20) Thanks for the input, I will use this. Best regards Valentin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform
Hello Piotr, On 01/14/2014 08:59 AM, Piotr Wilczek wrote: This patch adds variables describing platform (soc, board, vendor) to default environment. Samsung's common misc imitialisation is enabled to provide additional board information in envs. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Przemyslaw Marczak p.marc...@samsung.com --- include/configs/s5pc210_universal.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index d9e4c56..5e5f8e0 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -124,6 +124,11 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define CONFIG_MISC_INIT_R + You depends on my patch set and here we have a conflict in universal, trats and trats2. My patchset defines CONFIG_MISC_INIT_R for these three boards, so you can remove it from configs. #define CONFIG_EXTRA_ENV_SETTINGS \ updateb= \ onenand erase 0x0 0x10; \ Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 04/12] samsung: misc: move display logo function to misc.c file.
Dear Przemyslaw Marczak, On 14/01/14 17:02, Przemyslaw Marczak wrote: Hello Jaehoon, On 01/14/2014 04:41 AM, Jaehoon Chung wrote: Dear Przemyslaw, On 01/10/2014 11:31 PM, Przemyslaw Marczak wrote: board/samsung/common/misc.c: - move draw_logo() function from exynos_fb.c - add get_tizen_logo_info() function call removed from board files boards: - update board files - add CONFIG_MISC_INIT_R to Universal, Trats and Trats2 Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Tested-by: Hyungwon Hwang human.hw...@samsung.com --- changes v2: - configs cleanup - add check logo address before display Changes v3: - none Changes v4: - none Changes v5: - none board/samsung/common/misc.c | 42 ++ board/samsung/trats/trats.c |3 --- board/samsung/trats2/trats2.c|4 --- board/samsung/universal_c210/universal.c |4 --- drivers/video/exynos_fb.c| 28 include/configs/s5pc210_universal.h |3 +++ include/configs/trats.h |3 +++ include/configs/trats2.h |3 +++ 8 files changed, 51 insertions(+), 39 deletions(-) diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c index 3764d12..6188e29 100644 --- a/board/samsung/common/misc.c +++ b/board/samsung/common/misc.c @@ -6,9 +6,51 @@ */ #include common.h +#include lcd.h +#include libtizen.h + +#ifdef CONFIG_CMD_BMP +static void draw_logo(void) +{ +int x, y; +ulong addr; + +#ifdef CONFIG_TIZEN +get_tizen_logo_info(panel_info); +#else +return; if CONFIG_TINZE didn't set, draw_logo should be just return, right? Then I think this point could be changed more readable. #ifdef CONFIG_TIZEN int x, y; ulong addr; get_tizen_logo_info(...); add = panel_info.logo_addr; ... bmp_display(addr, x, y); #endif how about? Best Regards, Jaehoon Chung You know, this file is common for all Samsung platforms,and I think this function should not depends only on Tizen logo. In this case user can choose other logo just by adding function like get_logo instead of the return statement. I also think that there is need for some common function which allows set proper logo by board config, but maybe not in this patch set? I agreed with you. You said that there is need for some common function which allows set proper logo by board config. At previous version of board files, you already have common function (init_panel_info - even though this function is not for the logo but I think, it's enough). @@ -484,10 +484,6 @@ void init_panel_info(vidinfo_t *vid) vid-resolution = HD_RESOLUTION; vid-rgb_mode = MODE_RGB_P; -#ifdef CONFIG_TIZEN - get_tizen_logo_info(vid); -#endif - /* for LD9040. */ vid-pclk_name = 1; /* MPLL */ vid-sclk_div = 1; If you remove this change at each boards, then you don't have add ifdef CONFIG_TIZEN at draw_logo function. It can be split common stuffs and board specific stuffs efficiently. How you think? Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] mmc: dwmmc: mode change to 0644
Don't know why but, file permission was changed Signed-off-by: Minkyu Kang mk7.k...@samsung.com --- 0 files changed mode change 100755 = 100644 drivers/mmc/dw_mmc.c diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c old mode 100755 new mode 100644 -- 1.7.9.5 -- Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Hi, Fenghua: Albert has merged arm64 patch set. I have tested and it works fine on Foundation Model. I have downloaded the latest u-boot source code. And compiled it with linaro released gcc: export ARCH=aarch64 export CROSS_COMPILE=/home/lion/ARMv8/gcc-linaro-aarch64/bin/aarch64-linux-gnu- make vexpress_aemv8a -- Then copy u-boot.bin to Foundation_v8's directory, and runs: ./Foundation_v8 --cores=4 --no-secure-memory --visualization --gicv3 --data=./bl1.bin@0x0 --data=./u-boot.bin@0x800 But it failed to jump to u-boot. It seems the Foundation_v8 has hang. What is wrong with it? Best wishes, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: exynos: change to use clrbits macro instead of readl/writel function
Hello Inha, On 01/14/2014 05:01 AM, Inha Song wrote: Use setbits/clrbits macro instead of readl/writel function Signed-off-by: Inha Song ideal.s...@samsung.com --- arch/arm/cpu/armv7/exynos/clock.c | 87 +++-- 1 file changed, 25 insertions(+), 62 deletions(-) diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c index 5bde9d1..eaabfb9 100644 --- a/arch/arm/cpu/armv7/exynos/clock.c +++ b/arch/arm/cpu/armv7/exynos/clock.c @@ -870,7 +870,6 @@ static void exynos4_set_mmc_clk(int dev_index, unsigned int div) struct exynos4_clock *clk = (struct exynos4_clock *)samsung_get_base_clock(); unsigned int addr; - unsigned int val; /* * CLK_DIV_FSYS1 @@ -890,10 +889,9 @@ static void exynos4_set_mmc_clk(int dev_index, unsigned int div) dev_index -= 2; } - val = readl(addr); - val = ~(0xff ((dev_index 4) + 8)); - val |= (div 0xff) ((dev_index 4) + 8); - writel(val, addr); + clrsetbits_le32(addr, + 0xff ((dev_index 4) + 8), + (div 0xff) ((dev_index 4) + 8)); } /* exynos4x12: set the mmc clock */ @@ -902,7 +900,6 @@ static void exynos4x12_set_mmc_clk(int dev_index, unsigned int div) struct exynos4x12_clock *clk = (struct exynos4x12_clock *)samsung_get_base_clock(); unsigned int addr; - unsigned int val; /* * CLK_DIV_FSYS1 @@ -917,10 +914,9 @@ static void exynos4x12_set_mmc_clk(int dev_index, unsigned int div) dev_index -= 2; } - val = readl(addr); - val = ~(0xff ((dev_index 4) + 8)); - val |= (div 0xff) ((dev_index 4) + 8); - writel(val, addr); + clrsetbits_le32(addr, + 0xff ((dev_index 4) + 8), + (div 0xff) ((dev_index 4) + 8)); } /* exynos5: set the mmc clock */ @@ -929,7 +925,6 @@ static void exynos5_set_mmc_clk(int dev_index, unsigned int div) struct exynos5_clock *clk = (struct exynos5_clock *)samsung_get_base_clock(); unsigned int addr; - unsigned int val; /* * CLK_DIV_FSYS1 @@ -944,10 +939,9 @@ static void exynos5_set_mmc_clk(int dev_index, unsigned int div) dev_index -= 2; } - val = readl(addr); - val = ~(0xff ((dev_index 4) + 8)); - val |= (div 0xff) ((dev_index 4) + 8); - writel(val, addr); + clrsetbits_le32(addr, + 0xff ((dev_index 4) + 8), + (div 0xff) ((dev_index 4) + 8)); } /* exynos5: set the mmc clock */ @@ -956,7 +950,7 @@ static void exynos5420_set_mmc_clk(int dev_index, unsigned int div) struct exynos5420_clock *clk = (struct exynos5420_clock *)samsung_get_base_clock(); unsigned int addr; - unsigned int val, shift; + unsigned int shift; /* * CLK_DIV_FSYS1 @@ -967,10 +961,9 @@ static void exynos5420_set_mmc_clk(int dev_index, unsigned int div) addr = (unsigned int)clk-div_fsys1; shift = dev_index * 10; - val = readl(addr); - val = ~(0x3ff shift); - val |= (div 0x3ff) shift; - writel(val, addr); + clrsetbits_le32(addr, + 0x3ff shift, + (div 0x3ff) shift); } /* get_lcd_clk: return lcd clock frequency */ @@ -1061,7 +1054,6 @@ void exynos4_set_lcd_clk(void) { struct exynos4_clock *clk = (struct exynos4_clock *)samsung_get_base_clock(); - unsigned int cfg = 0; /* * CLK_GATE_BLOCK @@ -1073,9 +1065,7 @@ void exynos4_set_lcd_clk(void) * CLK_LCD1 [5] * CLK_GPS [7] */ - cfg = readl(clk-gate_block); - cfg |= 1 4; - writel(cfg, clk-gate_block); + setbits_le32(clk-gate_block, 1 4); /* * CLK_SRC_LCD0 @@ -1085,10 +1075,7 @@ void exynos4_set_lcd_clk(void) * MIPI0_SEL[12:15] * set lcd0 src clock 0x6: SCLK_MPLL */ - cfg = readl(clk-src_lcd0); - cfg = ~(0xf); - cfg |= 0x6; - writel(cfg, clk-src_lcd0); + clrsetbits_le32(clk-src_lcd0, 0x9, 0x6); /* * CLK_GATE_IP_LCD0 @@ -1100,9 +1087,7 @@ void exynos4_set_lcd_clk(void) * CLK_PPMULCD0 [5] * Gating all clocks for FIMD0 */ - cfg = readl(clk-gate_ip_lcd0); - cfg |= 1 0; - writel(cfg, clk-gate_ip_lcd0); + setbits_le32(clk-gate_ip_lcd0, 1 0); /* * CLK_DIV_LCD0 @@ -1114,16 +1099,13 @@ void exynos4_set_lcd_clk(void) * MIPI0_PRE_RATIO [23:20] * set fimd ratio */ - cfg = ~(0xf); - cfg |= 0x1; - writel(cfg, clk-div_lcd0); + clrsetbits_le32(clk-div_lcd0, 0xe, 0x1); } void exynos5_set_lcd_clk(void) {
[U-Boot] [PULL] : Please pull u-boot-imx
Hi Albert, please pull from u-boot-imx, thanks. The following changes since commit 4b0561d84198f8d696fd51cfc27aeac8c7482a8c: Merge branch 'u-boot-samsung/master' into 'u-boot-arm/master' (2014-01-06 09:32:42 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-imx.git master for you to fetch changes up to a6bbee66197759f790de83181924bf1d2cf482b2: mx6slevk: Include mx6_common.h (2014-01-13 11:52:28 +0100) Christian Gmeiner (1): imx6: make use of lldiv(..) Fabio Estevam (7): wandboard: Return from cpu_eth_init() directly titanium: Return from cpu_eth_init() directly mx6qarm2: Remove unneeded error message when cpu_eth_init() fails mx6qsabreauto: Return from cpu_eth_init() directly mx6sabresd: Return from cpu_eth_init() directly mx6slevk: Return from cpu_eth_init() directly mx6slevk: Include mx6_common.h John Weber (1): wandboard: Set default environment to use zImage Otavio Salvador (1): mx6sabresd: Add eMMC specific environment to allow U-Boot update arch/arm/cpu/armv7/mx6/clock.c|3 ++- board/barco/titanium/titanium.c |8 +--- board/freescale/mx6qarm2/mx6qarm2.c |7 ++- board/freescale/mx6qsabreauto/mx6qsabreauto.c |8 +--- board/freescale/mx6sabresd/mx6sabresd.c |8 +--- board/freescale/mx6slevk/mx6slevk.c | 10 +- board/wandboard/wandboard.c |8 +--- include/configs/mx6sabre_common.h | 23 +++ include/configs/mx6sabresd.h |2 ++ include/configs/mx6slevk.h|1 + include/configs/wandboard.h | 20 ++-- 11 files changed, 45 insertions(+), 53 deletions(-) -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform
Hi Przemyslaw, -Original Message- From: Przemyslaw Marczak [mailto:p.marc...@samsung.com] Sent: Tuesday, January 14, 2014 9:48 AM To: u-boot@lists.denx.de Cc: Piotr Wilczek; Minkyu Kang; Kyungmin Park; Lukasz Majewski Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables describing platform Hello Piotr, On 01/14/2014 08:59 AM, Piotr Wilczek wrote: This patch adds variables describing platform (soc, board, vendor) to default environment. Samsung's common misc imitialisation is enabled to provide additional board information in envs. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Przemyslaw Marczak p.marc...@samsung.com --- include/configs/s5pc210_universal.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index d9e4c56..5e5f8e0 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -124,6 +124,11 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define CONFIG_MISC_INIT_R + You depends on my patch set and here we have a conflict in universal, trats and trats2. My patchset defines CONFIG_MISC_INIT_R for these three boards, so you can remove it from configs. Is the samsung/common/misc.c file reserved only for misc_init_r function? I think that CONFIG_MISC_INIT_R is misleading. #define CONFIG_EXTRA_ENV_SETTINGS \ updateb= \ onenand erase 0x0 0x10; \ Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com Best regards, Piotr Wilczek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] ARM: trats2: dfu: Enable default Poll Timeout for Trats2 board
On 14/01/14 16:02, Lukasz Majewski wrote: Provide default Poll Timeout value for Trats2 board. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - None Change-Id: I06ee5c228fa4f92ab445333cbdb12464944daa35 --- include/configs/trats2.h |1 + 1 file changed, 1 insertion(+) Acked-by: Minkyu Kang mk7.k...@samsung.com Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] config: Update envs for trats and trats2 - Disable L2 cache
On 14/01/14 16:02, Lukasz Majewski wrote: Disable L2 caches for Trats and Trats2 devices. It turns out that for data downloading with thordown command L2 cache disablement brings a significant speed improvement. rootfs - 400 MiB: - L2 cache enabled: 2.69 MiB/s - L2 cache disabled: 5.56 MiB/s Such improvement is possible due to reduction of the need to invalidate redundant data, which resides in L2 cache. Since the sent USB request size at once is 512B (L1 - 32 KiB in total) - one can be quite confident that it is already available in L1 and L2 can be disabled. Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- include/configs/trats.h |1 + include/configs/trats2.h |1 + 2 files changed, 2 insertions(+) Acked-by: Minkyu Kang mk7.k...@samsung.com Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] config: Update envs for trats and trats2 - new entries for new partitions
On 14/01/14 16:02, Lukasz Majewski wrote: This patch adds extra dfu_alt_info entries to support storing the whole BOOT , DATA and UMS partitions. This allows upgrade of uImage and device tree blob (dtb) files at once. Now it is also possible to store ext4 rootfs prepared with well established linux tools (like mkfs.ext4). Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - New partions added Change-Id: I97aaa95e2745736de417bd07dbe2433dfff0f02c --- include/configs/trats.h |5 - include/configs/trats2.h |5 - 2 files changed, 8 insertions(+), 2 deletions(-) Acked-by: Minkyu Kang mk7.k...@samsung.com Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform
Hello Piotr, On 01/14/2014 10:37 AM, Piotr Wilczek wrote: Hi Przemyslaw, -Original Message- From: Przemyslaw Marczak [mailto:p.marc...@samsung.com] Sent: Tuesday, January 14, 2014 9:48 AM To: u-boot@lists.denx.de Cc: Piotr Wilczek; Minkyu Kang; Kyungmin Park; Lukasz Majewski Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables describing platform Hello Piotr, On 01/14/2014 08:59 AM, Piotr Wilczek wrote: This patch adds variables describing platform (soc, board, vendor) to default environment. Samsung's common misc imitialisation is enabled to provide additional board information in envs. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Przemyslaw Marczak p.marc...@samsung.com --- include/configs/s5pc210_universal.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index d9e4c56..5e5f8e0 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -124,6 +124,11 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define CONFIG_MISC_INIT_R + You depends on my patch set and here we have a conflict in universal, trats and trats2. My patchset defines CONFIG_MISC_INIT_R for these three boards, so you can remove it from configs. Is the samsung/common/misc.c file reserved only for misc_init_r function? I think that CONFIG_MISC_INIT_R is misleading. No, it isn't reserved. Misc_init_r function is for various things and is called from board_init_r. In this function we can put any common code for our vendor boards. So why do you think it is bad? #define CONFIG_EXTRA_ENV_SETTINGS\ updateb= \ onenand erase 0x0 0x10; \ Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com Best regards, Piotr Wilczek Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere
Hi Simon, as I don't see any follow-up, allow me to jump in here even that late :) Hi Wolfgang, On Wed, Nov 6, 2013 at 1:24 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It is easy to misspell an #ifdef and there is not as much checking of this by the compiler. Multiple dependent #ifdefs are harder to do than with if..then..else. Variable declarations must be #idefed as well as the code that uses them, often much later in the file/function. #ifdef indents don't match code indents and have their own separate indent feature. Overall, excessive use of #idef hurts readability and makes the code harder to modify and refactor. For people coming newly into the code base, #ifdefs can be a big barrier. The use of #ifdef in U-Boot has possibly got a little out of hand. In an attempt to turn the tide, this series includes a patch which provides a way to make CONFIG macros available to C code without using the preprocessor. This makes it possible to use standard C conditional features such as if/then instead of #ifdef. A README update exhorts compliance. As mentioned before, I'm really interested in seeing something like this going into mainline, but I have some doubts about the actual implementation. To summarize: Your current proposal was to convert code snippets like this: #ifdef CONFIG_VERSION_VARIABLE setenv(ver, version_string); /* set version variable */ #endif into if (autoconf_version_variable()) setenv(ver, version_string); /* set version variable */ By chance I ran about include/linux/kconfig.h in the Linux kernel tree, which provides (among other things) the IS_ENABLED() macro that implements essentially the very same feature. Using this, the same code would be written as: if (IS_ENABLED(CONFIG_VERSION_VARIABLE)) setenv(ver, version_string); /* set version variable */ I agree that this does not solve some of the isses that have been raised about this change (indentation level increses - which may in turn require reformatting of bigger parts of the code; code becomes less readable), but on the other hand it avoids the need for a new autoconf header file, and it should be possible to introduce this easily step by step. And I really like the idea of re-using existing code that is already known to Linux hackers, especially as we we are currently having our eyes on the Kconfig stuff anyway. What do you think? Fair enough, sounds reasonable. The relevant kernel code is quite unusual... /* * Helper macros to use CONFIG_ options in C/CPP expressions. Note that * these only work with boolean and tristate options. */ /* * Getting something that works in C and CPP for an arg that may or may * not be defined is tricky. Here, if we have #define CONFIG_BOOGER 1 * we match on the placeholder define, insert the 0, for arg1 and generate * the triplet (0, 1, 0). Then the last step cherry picks the 2nd arg (a one). * When CONFIG_BOOGER is not defined, we generate a (... 1, 0) pair, and when * the last step cherry picks the 2nd arg, we get a zero. */ #define __ARG_PLACEHOLDER_1 0, #define config_enabled(cfg) _config_enabled(cfg) #define _config_enabled(value) __config_enabled(__ARG_PLACEHOLDER_##value) #define __config_enabled(arg1_or_junk) ___config_enabled(arg1_or_junk 1, 0) #define ___config_enabled(__ignored, val, ...) val /* * IS_ENABLED(CONFIG_FOO) evaluates to 1 if CONFIG_FOO is set to 'y' or 'm', * 0 otherwise. * */ #define IS_ENABLED(option) \ (config_enabled(option) || config_enabled(option##_MODULE)) I think the Linux code has two big advantages - for one, we increase the overlap with Linux kernel proper and secondly we keep the 'grep'ability of the names which I really missed in your proposal. Many of U-Boot's options are not just yes/no, so I'm not sure what will happen with those. Perhaps they just can't be used with this macro? Part of my intent was to allow any option to be used. In those cases the defines then are a shortcut to using a boolean + a value and we can make it work by introducing this boolean? I have no idea of how much work this would be, but it might be worthwhile getting some real numbers to that. So for example you can do this: struct { const char *str; u_int len; int retry; const char *conf; /* Configuration value */ } delaykey [] = { { str: getenv(bootdelaykey), retry: 1, conf: autoconf_autoboot_delay_str() }, { str: getenv(bootdelaykey2), retry: 1, conf: autoconf_autoboot_delay_str2() }, { str: getenv(bootstopkey), retry: 0, conf: autoconf_autoboot_stop_str() }, { str: getenv(bootstopkey2),
Re: [U-Boot] [PATCH] board: tec-ng: Do not make directories in a board Makefile
On Tue, 14 Jan 2014 10:55:02 +0900 Masahiro Yamada yamad...@jp.panasonic.com wrote: Commit e5c5301f refactored the build system not to make directories in board makefiles. But commit 8f380381 create directories again in board/avionic-design/tec-ng/Makefile. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Alban Bedel alban.be...@avionic-design.de Acked-by: Alban Bedel alban.be...@avionic-design.de Alban ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Hi, experts: I have tried to boot uefi bootloader with FVP model,it is ok! ./Foundation_v8 --cores=4 --no-secure-memory --visualization --gicv3 --data=./bl1.bin@0x0 --data=./uefi.fd@0x800 BL1--BL2--...uefi.fd But booting uboot.bin, it still failed. Best wishes, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of tiger...@viatech.com.cn Sent: Tuesday, January 14, 2014 4:13 PM To: feng...@phytium.com.cn Cc: tr...@ti.com; u-boot@lists.denx.de; Wood Scott-B07421 Subject: Re: [U-Boot] how to get u-boot code with arm64: core support Hi, experts: I have tried to boot uefi bootloader with FVP model,it is ok! ./Foundation_v8 --cores=4 --no-secure-memory --visualization --gicv3 --data=./bl1.bin@0x0 --data=./uefi.fd@0x800 Which ARMv8 foundation model version you are using. I one I have doesn't support GiCv3. UEFI supports both GiCv3 and v2 whereas I believe uboot is only tested for GiCv2. BL1--BL2--...uefi.fd But booting uboot.bin, it still failed. Best wishes, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] arm: put .hash, .got.plt and .machine_param back in binaries
On Mon, 13 Jan 2014 14:57:05 +0100, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Some targets will build fine but not boot if sections .hash and .got.plt are not present in the binary. Add them back. Also, Exynos machines require .machine_param section in SPL. Add it. Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net --- V3: rebase V2: remove SREC generation for SPL arch/arm/config.mk | 2 +- arch/arm/cpu/armv7/exynos/config.mk | 7 +++ arch/arm/cpu/u-boot.lds | 3 +-- spl/Makefile| 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) create mode 100644 arch/arm/cpu/armv7/exynos/config.mk diff --git a/arch/arm/config.mk b/arch/arm/config.mk index 329c7a7..cfa4209 100644 --- a/arch/arm/config.mk +++ b/arch/arm/config.mk @@ -109,5 +109,5 @@ endif ifdef CONFIG_ARM64 OBJCFLAGS += -j .text -j .rodata -j .data -j .u_boot_list -j .rela.dyn else -OBJCFLAGS += -j .text -j .rodata -j .data -j .u_boot_list -j .rel.dyn +OBJCFLAGS += -j .text -j .rodata -j .hash -j .data -j .got.plt -j .u_boot_list -j .rel.dyn endif diff --git a/arch/arm/cpu/armv7/exynos/config.mk b/arch/arm/cpu/armv7/exynos/config.mk new file mode 100644 index 000..ee0d2da --- /dev/null +++ b/arch/arm/cpu/armv7/exynos/config.mk @@ -0,0 +1,7 @@ +# +# Copyright (C) Albert ARIBAUD albert.u.b...@aribaud.net +# +# SPDX-License-Identifier: GPL-2.0+ +# + +SPL_OBJCFLAGS += -j .machine_param diff --git a/arch/arm/cpu/u-boot.lds b/arch/arm/cpu/u-boot.lds index 9463a33..4da5d24 100644 --- a/arch/arm/cpu/u-boot.lds +++ b/arch/arm/cpu/u-boot.lds @@ -92,8 +92,6 @@ SECTIONS } .dynsym _end : { *(.dynsym) } - .hash : { *(.hash) } - .got.plt : { *(.got.plt) } .dynbss : { *(.dynbss) } .dynstr : { *(.dynstr*) } .dynamic : { *(.dynamic*) } @@ -101,4 +99,5 @@ SECTIONS .interp : { *(.interp*) } .gnu : { *(.gnu*) } .ARM.exidx : { *(.ARM.exidx*) } + .gnu.linkonce.armexidx : { *(.gnu.linkonce.armexidx.*) } } diff --git a/spl/Makefile b/spl/Makefile index 003956e..5e5472d 100644 --- a/spl/Makefile +++ b/spl/Makefile @@ -165,7 +165,7 @@ $(obj)$(BOARD)-spl.bin: $(obj)u-boot-spl.bin endif $(obj)$(SPL_BIN).bin:$(obj)$(SPL_BIN) - $(OBJCOPY) $(OBJCFLAGS) -O binary $ $@ + $(OBJCOPY) $(OBJCFLAGS) $(SPL_OBJCFLAGS) -O binary $ $@ GEN_UBOOT = \ cd $(obj) $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) $(__START) \ Applied, with Rajeshwari's (hyphen-fixed) tested-by added, to u-boot-arm/master. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()
On 01/14/14 01:49, Minkyu Kang wrote: On 09/01/14 23:31, Mateusz Zalega wrote: In some cases MMC was still uninitialized while media capacity check, leading to broken ums command. Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com --- board/samsung/common/ums.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/board/samsung/common/ums.c b/board/samsung/common/ums.c index dc155ad..0d8f30d 100644 --- a/board/samsung/common/ums.c +++ b/board/samsung/common/ums.c @@ -37,6 +37,9 @@ static struct ums ums_dev = { static struct ums *ums_disk_init(struct mmc *mmc) { +if (mmc_init(mmc)) +return NULL; + uint64_t mmc_end_sector = mmc-capacity / SECTOR_SIZE; uint64_t ums_end_sector = UMS_NUM_SECTORS + UMS_START_SECTOR; Why don't you init the mmc before call this function? diff --git a/board/samsung/common/ums.c b/board/samsung/common/ums.c index dc155ad..7017c2a 100644 --- a/board/samsung/common/ums.c +++ b/board/samsung/common/ums.c @@ -72,5 +72,8 @@ struct ums *ums_init(unsigned int dev_num) if (!mmc) return NULL; + if (mmc_init(mmc)) + return NULL; + return ums_disk_init(mmc); } I agree, ACK. -- Mateusz Zalega Samsung RD Institute Poland ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Compiling fw_printenv tool
Hi Alexey, Dear Detlev, I ran $ make HOSTCC=arm-none-linux-gnueabi-gcc env and got the tools/env/fw_printenv executable. But the Make command returned error: strip: Unable to recognise the format of the input file `fw_printenv' make[1]: *** [fw_printenv] Error 1 I guess, HOSTSTRIP variable also has to be set. However, I uploaded the unstripped executable to my embedded device, and ran: $ chmod a+x fw_printenv $ ./fw_printenv -sh: ./fw_printenv: not found I tried also manually stripping the executable. What could be this error related to? Oops, I really missed that mail, sorry. This error message means that your cross-compiled binary does not run on the embedded device (maybe the device uses different libraries than your cross toolchain links agains). To troubleshoot that, start with a regular hello-world.c and continue to fw_printenv only if you have this working. Cheers Detlev -- The C++ STL, with its dyslexia-inducing syntax blizzard of colons and angle brackets, guarantees that if you try to declare any reasonable data structure, your first seven attempts will result in compiler errors of Wagnerian fierce- ness. -- James Mickens -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Hi, sharma: Which ARMv8 foundation model version you are using. I one I have doesn't support GiCv3. UEFI supports both GiCv3 and v2 whereas I believe uboot is only tested for GiCv2. I download FVP from ARM Ltd website: http://www.arm.com/products/tools/models/fast-models/foundation-model.ph p how to identify this FVP's version number? I tried to run : ./Foundation_v8 --cores=4 --no-secure-memory --visualization --data=./bl1.bin@0x0 --data=./u-boot.bin@0x800 Not use --gicv3 parameter, it still failed to jump to u-boot.bin Best wishes, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Hi, sharma: ./Foundation_v8 --cores=4 --no-secure-memory --visualization --data=./bl1.bin@0x0 --data=./u-boot.bin@0x800 Is the TEXT_BASE right? Best wishes, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
-Original Message- From: tiger...@viatech.com.cn [mailto:tiger...@viatech.com.cn] Sent: Tuesday, January 14, 2014 4:40 PM To: Sharma Bhupesh-B45370; feng...@phytium.com.cn Cc: tr...@ti.com; u-boot@lists.denx.de; Wood Scott-B07421 Subject: Re: Re: [U-Boot] how to get u-boot code with arm64: core support Hi, sharma: ./Foundation_v8 --cores=4 --no-secure-memory --visualization --data=./bl1.bin@0x0 --data=./u-boot.bin@0x800 Is the TEXT_BASE right? Can you try this command: ./Foundation_v8 --image ./u-boot --cores=4 --no-secure-memory Regards, Bhupesh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Hi,Sharma: Can you try this command: ./Foundation_v8 --image ./u-boot --cores=4 --no-secure-memory Error: terminal_1: Listening for serial connection on port 5000 terminal_2: Listening for serial connection on port 5001 terminal_0: Listening for serial connection on port 5002 terminal_3: Listening for serial connection on port 5003 ERROR: an unexpected exception error has occurred inside the model terminate called after throwing an instance of 'ObjectLoaderError' what(): ./u-boot.bin: error while loading 'AXYS 'in'-file' file: fgets: Success ./run.sh: line 3: 25702 Aborted ./Foundation_v8 --image ./u-boot.bin --cores=4 --no-secure-memory So, maybe current FVP's version is newer! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Not the u-boot.bin, only u-boot: ./Foundation_v8 --image ./u-boot --cores=4 --no-secure-memory Regards, Bhupesh -Original Message- From: tiger...@viatech.com.cn [mailto:tiger...@viatech.com.cn] Sent: Tuesday, January 14, 2014 4:52 PM To: Sharma Bhupesh-B45370; feng...@phytium.com.cn Cc: tr...@ti.com; u-boot@lists.denx.de; Wood Scott-B07421 Subject: Re: Re: [U-Boot] how to get u-boot code with arm64: core support Hi,Sharma: Can you try this command: ./Foundation_v8 --image ./u-boot --cores=4 --no-secure-memory Error: terminal_1: Listening for serial connection on port 5000 terminal_2: Listening for serial connection on port 5001 terminal_0: Listening for serial connection on port 5002 terminal_3: Listening for serial connection on port 5003 ERROR: an unexpected exception error has occurred inside the model terminate called after throwing an instance of 'ObjectLoaderError' what(): ./u-boot.bin: error while loading 'AXYS 'in'-file' file: fgets: Success ./run.sh: line 3: 25702 Aborted ./Foundation_v8 --image ./u-boot.bin --cores=4 --no-secure-memory So, maybe current FVP's version is newer! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Hi, sharma: Not the u-boot.bin, only u-boot: ./Foundation_v8 --image ./u-boot --cores=4 --no-secure-memory FVP model print: Simulation is started Then not run further. Based on arm open source firmware doc, should use Foundation_v8 as below format: ./Foundation_v8 \ --cores=4 \ --no-secure-memory\ --visualization \ --gicv3 \ --data=path to bl1.bin@0x0\ --data=path to UEFI binary@0x800 \ After compiled u-boot source code, there are 3 u-boot bin files: u-boot : 1.4MB u-boot.bin : 205KB u-boot.elf : 270KB So, we should use u-boot? Not u-boot.bin? Best wishes, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: use canonical sub mnemonic
Hi Andreas, On Wed, 27 Nov 2013 16:09:29 +0100, Andreas Bießmann andreas.de...@googlemail.com wrote: Building some arm boards with older binutils may produce errors like this: ---8--- crt0.S: Assembler messages: crt0.S:70: Error: register expected, not '#(184)' -- `sub sp,#(184)' ---8--- Use canonical version of the subtract mnemonic to avoid those issues. Reported-by: Alexey Smishlayev ale...@xtech2.lv Signed-off-by: Andreas Bießmann andreas.de...@googlemail.com --- arch/arm/cpu/armv7/lowlevel_init.S |2 +- arch/arm/lib/crt0.S|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/armv7/lowlevel_init.S b/arch/arm/cpu/armv7/lowlevel_init.S index 69e3053..f1aea05 100644 --- a/arch/arm/cpu/armv7/lowlevel_init.S +++ b/arch/arm/cpu/armv7/lowlevel_init.S @@ -24,7 +24,7 @@ ENTRY(lowlevel_init) #ifdef CONFIG_SPL_BUILD ldr r9, =gdata #else - sub sp, #GD_SIZE + sub sp, sp, #GD_SIZE bic sp, sp, #7 mov r9, sp #endif diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S index ac54b93..dfc2de9 100644 --- a/arch/arm/lib/crt0.S +++ b/arch/arm/lib/crt0.S @@ -67,7 +67,7 @@ ENTRY(_main) ldr sp, =(CONFIG_SYS_INIT_SP_ADDR) #endif bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ - sub sp, #GD_SIZE/* allocate one GD above SP */ + sub sp, sp, #GD_SIZE/* allocate one GD above SP */ bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ mov r9, sp /* GD is above SP */ mov r0, #0 Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Compiling fw_printenv tool
Hello Detlev, On 2014.01.14. 12:54, Detlev Zundel wrote: Hi Alexey, Dear Detlev, I ran $ make HOSTCC=arm-none-linux-gnueabi-gcc env and got the tools/env/fw_printenv executable. But the Make command returned error: strip: Unable to recognise the format of the input file `fw_printenv' make[1]: *** [fw_printenv] Error 1 I guess, HOSTSTRIP variable also has to be set. However, I uploaded the unstripped executable to my embedded device, and ran: $ chmod a+x fw_printenv $ ./fw_printenv -sh: ./fw_printenv: not found I tried also manually stripping the executable. What could be this error related to? Oops, I really missed that mail, sorry. This error message means that your cross-compiled binary does not run on the embedded device (maybe the device uses different libraries than your cross toolchain links agains). To troubleshoot that, start with a regular hello-world.c and continue to fw_printenv only if you have this working. Cheers Detlev I've googled it and sorted it out. The problem was that executable was dynamically linked and the *.so was not found on the embedded system. I compiled it with -static and it runs. Best regards, Alexey ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Bug in TOP860 code with gcc 4.8.1
Dear Wolfgang, Dear Reinhard, attempting to build the TOP860 code with a GCC 4.8.1 based tool chain (say ELDK v5.5 or Yocto 1.5) gives the following errors: - ./MAKEALL TOP860 Configuring for TOP860 board... textdata bss dec hex filename 165471 21020 17316 203807 31c1f ./u-boot ../common/flash.c: In function 'flash_init': ../common/flash.c:336:20: warning: iteration 128u invokes undefined behavior [-Waggressive-loop-optimizations] info-start[i] = (ulong)addr + 0x1 * i; ^ ../common/flash.c:334:4: note: containing loop for (i = 0; i info-sector_count; i++) ^ ... Can you please provide a fix - or is this old hardware and the code should be removed from the U-Boot tree? 1. on first and second glance I cannot see where this (simple!!) loop might invoke undefined behaviour. Seems like a compiler/optimizer bug to me... 2. should not the same issue arise with TOP5200 (using the same flash.c) ?? 3. nevertheless TOP860 can be removed. Best Regards, Reinhard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] mx6: Distinguish mx6dual from mx6quad
From: Fabio Estevam fabio.este...@freescale.com Currently when we boot a mx6dual U-boot reports that it is a mx6quad. Report it as MX6D instead: CPU: Freescale i.MX6D rev1.2 at 792 MHz Signed-off-by: Fabio Estevam fabio.este...@freescale.com Tested-by: Otavio Salvador ota...@ossystems.com.br --- arch/arm/cpu/armv7/mx6/soc.c | 14 +++--- arch/arm/imx-common/cpu.c | 2 ++ arch/arm/include/asm/arch-mx6/sys_proto.h | 1 + 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv7/mx6/soc.c b/arch/arm/cpu/armv7/mx6/soc.c index 009a644..a6fb6ab 100644 --- a/arch/arm/cpu/armv7/mx6/soc.c +++ b/arch/arm/cpu/armv7/mx6/soc.c @@ -43,14 +43,19 @@ u32 get_cpu_rev(void) if (type != MXC_CPU_MX6SL) { reg = readl(anatop-digprog); + struct scu_regs *scu = (struct scu_regs *)SCU_BASE_ADDR; + u32 cfg = readl(scu-config) 3; type = ((reg 16) 0xff); if (type == MXC_CPU_MX6DL) { - struct scu_regs *scu = (struct scu_regs *)SCU_BASE_ADDR; - u32 cfg = readl(scu-config) 3; - if (!cfg) type = MXC_CPU_MX6SOLO; } + + if (type == MXC_CPU_MX6Q) { + if (cfg == 1) + type = MXC_CPU_MX6D; + } + } reg = 0xff;/* mx6 silicon revision */ return (type 12) | (reg + 0x10); @@ -64,6 +69,9 @@ u32 __weak get_board_rev(void) if (type == MXC_CPU_MX6SOLO) cpurev = (MXC_CPU_MX6DL) 12 | (cpurev 0xFFF); + if (type == MXC_CPU_MX6D) + cpurev = (MXC_CPU_MX6Q) 12 | (cpurev 0xFFF); + return cpurev; } #endif diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c index 9231649..a77c4de 100644 --- a/arch/arm/imx-common/cpu.c +++ b/arch/arm/imx-common/cpu.c @@ -106,6 +106,8 @@ const char *get_imx_type(u32 imxtype) switch (imxtype) { case MXC_CPU_MX6Q: return 6Q;/* Quad-core version of the mx6 */ + case MXC_CPU_MX6D: + return 6D;/* Dual-core version of the mx6 */ case MXC_CPU_MX6DL: return 6DL; /* Dual Lite version of the mx6 */ case MXC_CPU_MX6SOLO: diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h index 17125a6..eda779e 100644 --- a/arch/arm/include/asm/arch-mx6/sys_proto.h +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h @@ -16,6 +16,7 @@ #define MXC_CPU_MX6DL 0x61 #define MXC_CPU_MX6SOLO0x62 #define MXC_CPU_MX6Q 0x63 +#define MXC_CPU_MX6D 0x64 #define is_soc_rev(rev)((get_cpu_rev() 0xFF) - rev) u32 get_cpu_rev(void); -- 1.8.1.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 0/24] Zynq DT changes
Hi Michal, On Fri, 3 Jan 2014 11:10:45 +0100, Michal Simek michal.si...@xilinx.com wrote: Hi, this is respin of Jagan v3 series sent here http://lists.denx.de/pipermail/u-boot/2013-December/169617.html + 2 patches v4 http://lists.denx.de/pipermail/u-boot/2013-December/169753.html http://lists.denx.de/pipermail/u-boot/2013-December/169752.html The purpose of this series was to synchronized configuration which we are using with mainline version with adding features which we are using. The major change, which I have done, is adding DT support for all zynq boards instead of board specification configurations. I have changed serial, gem, emaclite, mmc. i2c, spi already support bus selection. For more information please look at patches. All series are available here for easier testing. http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/zynq Thanks, Michal As Jagan's series has been pulled in, can you resubmit a v2 based on current ARM ToT? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform
Hi Przemyslaw, -Original Message- From: Przemyslaw Marczak [mailto:p.marc...@samsung.com] Sent: Tuesday, January 14, 2014 11:10 AM To: u-boot@lists.denx.de Cc: Piotr Wilczek; 'Minkyu Kang'; 'Kyungmin Park'; Lukasz Majewski Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables describing platform Hello Piotr, On 01/14/2014 10:37 AM, Piotr Wilczek wrote: Hi Przemyslaw, -Original Message- From: Przemyslaw Marczak [mailto:p.marc...@samsung.com] Sent: Tuesday, January 14, 2014 9:48 AM To: u-boot@lists.denx.de Cc: Piotr Wilczek; Minkyu Kang; Kyungmin Park; Lukasz Majewski Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables describing platform Hello Piotr, On 01/14/2014 08:59 AM, Piotr Wilczek wrote: This patch adds variables describing platform (soc, board, vendor) to default environment. Samsung's common misc imitialisation is enabled to provide additional board information in envs. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Przemyslaw Marczak p.marc...@samsung.com --- include/configs/s5pc210_universal.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index d9e4c56..5e5f8e0 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -124,6 +124,11 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG #define +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define CONFIG_MISC_INIT_R + You depends on my patch set and here we have a conflict in universal, trats and trats2. My patchset defines CONFIG_MISC_INIT_R for these three boards, so you can remove it from configs. Is the samsung/common/misc.c file reserved only for misc_init_r function? I think that CONFIG_MISC_INIT_R is misleading. No, it isn't reserved. Misc_init_r function is for various things and is called from board_init_r. In this function we can put any common code for our vendor boards. So why do you think it is bad? So the misc.c file is reserved for misc_init_r only. The file is only for CONFIG_MISC_INIT_R. I thought that in misc.c we can put some common code not necessarily called form misc_init_r but say from borad_late_init. But ok. To add some common code for board_late_init I need to add another file. #define CONFIG_EXTRA_ENV_SETTINGS \ updateb= \ onenand erase 0x0 0x10; \ Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com Best regards, Piotr Wilczek Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 0/24] Zynq DT changes
Hi Albert, On 01/14/2014 01:08 PM, Albert ARIBAUD wrote: Hi Michal, On Fri, 3 Jan 2014 11:10:45 +0100, Michal Simek michal.si...@xilinx.com wrote: Hi, this is respin of Jagan v3 series sent here http://lists.denx.de/pipermail/u-boot/2013-December/169617.html + 2 patches v4 http://lists.denx.de/pipermail/u-boot/2013-December/169753.html http://lists.denx.de/pipermail/u-boot/2013-December/169752.html The purpose of this series was to synchronized configuration which we are using with mainline version with adding features which we are using. The major change, which I have done, is adding DT support for all zynq boards instead of board specification configurations. I have changed serial, gem, emaclite, mmc. i2c, spi already support bus selection. For more information please look at patches. All series are available here for easier testing. http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/zynq Thanks, Michal As Jagan's series has been pulled in, can you resubmit a v2 based on current ARM ToT? yes. That was my plan. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP - KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform signature.asc Description: OpenPGP digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PULL] : Please pull u-boot-imx
Hi Stefano, On Tue, 14 Jan 2014 10:34:19 +0100, Stefano Babic sba...@denx.de wrote: Hi Albert, please pull from u-boot-imx, thanks. The following changes since commit 4b0561d84198f8d696fd51cfc27aeac8c7482a8c: Merge branch 'u-boot-samsung/master' into 'u-boot-arm/master' (2014-01-06 09:32:42 +0100) are available in the git repository at: git://www.denx.de/git/u-boot-imx.git master for you to fetch changes up to a6bbee66197759f790de83181924bf1d2cf482b2: mx6slevk: Include mx6_common.h (2014-01-13 11:52:28 +0100) Christian Gmeiner (1): imx6: make use of lldiv(..) Fabio Estevam (7): wandboard: Return from cpu_eth_init() directly titanium: Return from cpu_eth_init() directly mx6qarm2: Remove unneeded error message when cpu_eth_init() fails mx6qsabreauto: Return from cpu_eth_init() directly mx6sabresd: Return from cpu_eth_init() directly mx6slevk: Return from cpu_eth_init() directly mx6slevk: Include mx6_common.h John Weber (1): wandboard: Set default environment to use zImage Otavio Salvador (1): mx6sabresd: Add eMMC specific environment to allow U-Boot update arch/arm/cpu/armv7/mx6/clock.c|3 ++- board/barco/titanium/titanium.c |8 +--- board/freescale/mx6qarm2/mx6qarm2.c |7 ++- board/freescale/mx6qsabreauto/mx6qsabreauto.c |8 +--- board/freescale/mx6sabresd/mx6sabresd.c |8 +--- board/freescale/mx6slevk/mx6slevk.c | 10 +- board/wandboard/wandboard.c |8 +--- include/configs/mx6sabre_common.h | 23 +++ include/configs/mx6sabresd.h |2 ++ include/configs/mx6slevk.h|1 + include/configs/wandboard.h | 20 ++-- 11 files changed, 45 insertions(+), 53 deletions(-) Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request: u-boot-arm/master
Hello Tom, The following changes since commit 4efd69250f6118ebd783867b3809001a1886ce9e: ARM: pxa: Fix OneNAND window access on VPAC270 (2014-01-13 12:39:10 +0100) are available in the git repository at: git://git.denx.de/u-boot-arm master for you to fetch changes up to 6ba2bc8fa9be4bd09ec43e39cb8e666480ef010c: arm: use canonical sub mnemonic (2014-01-14 12:38:47 +0100) Albert ARIBAUD (4): mini2440: remove board support mx1ads: remove board support arm: put .hash, .got.plt and .machine_param back in binaries Merge 'u-boot-imx/master' into 'u-boot-arm/master' Andreas Bießmann (1): arm: use canonical sub mnemonic Christian Gmeiner (1): imx6: make use of lldiv(..) Fabio Estevam (7): wandboard: Return from cpu_eth_init() directly titanium: Return from cpu_eth_init() directly mx6qarm2: Remove unneeded error message when cpu_eth_init() fails mx6qsabreauto: Return from cpu_eth_init() directly mx6sabresd: Return from cpu_eth_init() directly mx6slevk: Return from cpu_eth_init() directly mx6slevk: Include mx6_common.h John Weber (1): wandboard: Set default environment to use zImage Otavio Salvador (1): mx6sabresd: Add eMMC specific environment to allow U-Boot update arch/arm/config.mk| 2 +- arch/arm/cpu/armv7/exynos/config.mk | 7 + arch/arm/cpu/armv7/lowlevel_init.S| 2 +- arch/arm/cpu/armv7/mx6/clock.c| 3 +- arch/arm/cpu/u-boot.lds | 3 +- arch/arm/lib/crt0.S | 2 +- board/barco/titanium/titanium.c | 8 +- board/freescale/mx6qarm2/mx6qarm2.c | 7 +- board/freescale/mx6qsabreauto/mx6qsabreauto.c | 8 +- board/freescale/mx6sabresd/mx6sabresd.c | 8 +- board/freescale/mx6slevk/mx6slevk.c | 10 +- board/friendlyarm/mini2440/Makefile | 8 - board/friendlyarm/mini2440/mini2440.c | 118 -- board/friendlyarm/mini2440/mini2440.h | 144 board/mx1ads/Makefile | 16 -- board/mx1ads/lowlevel_init.S | 68 -- board/mx1ads/mx1ads.c | 178 --- board/mx1ads/syncflash.c | 307 -- board/wandboard/wandboard.c | 8 +- boards.cfg| 2 - doc/README.mini2440 | 28 --- doc/README.scrapyard | 6 +- include/configs/mx1ads.h | 163 -- include/configs/mx6sabre_common.h | 23 ++ include/configs/mx6sabresd.h | 2 + include/configs/mx6slevk.h| 1 + include/configs/wandboard.h | 20 +- spl/Makefile | 2 +- 28 files changed, 61 insertions(+), 1093 deletions(-) create mode 100644 arch/arm/cpu/armv7/exynos/config.mk delete mode 100644 board/friendlyarm/mini2440/Makefile delete mode 100644 board/friendlyarm/mini2440/mini2440.c delete mode 100644 board/friendlyarm/mini2440/mini2440.h delete mode 100644 board/mx1ads/Makefile delete mode 100644 board/mx1ads/lowlevel_init.S delete mode 100644 board/mx1ads/mx1ads.c delete mode 100644 board/mx1ads/syncflash.c delete mode 100644 doc/README.mini2440 delete mode 100644 include/configs/mx1ads.h Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [ANN] v2014.01-rc3
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/13/2014 05:31 PM, Lukasz Majewski wrote: Hi Tom Hey all, I've put v2014.01-rc3 out and we should have a tarball soon. Here's where we're at, I feel. We got some big changes in, which had been due for a while, on Friday. I don't think it's a good idea to release today, so I'm going to push things out a week. Here's what I expect for the release, change-wise: - Any regressions people report - Either removal of mini2440 and mx1ads or CONFIG_SYS_HZ fixes for them (Albert is working a removal patch now, or soon). - Fixes for i.mx platforms using hardfp toolchains (which means do_div being called instead). The patch exists, lets get this through please. We have some fixes for Samsung's Trats and Trats2. Some of them had already been sent do mailing list (as explicit fixes for v2014.01) I've also prepared some tweaks for envs on those boards. Shall I sent them directly to you or ask Minkyu to pull them to u-boot-samsung? Well, Minkyu, can you get a pull request together for Albert today or tomorrow at the latest? Thanks! - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS1TfYAAoJENk4IS6UOR1WXCAP/j2GPU2lf83xvQ/5poovsqZR cdz/Lt+IDV7qcy0SigkE0jDkeBvWyzs641fYFj1JVBG/8OuLXvU9BT9rfgbqLIYf xvqHAN3vdoTaBp3mFBixMurO0JIyDZ8Nje7noWFiSpZJrf0BVtXhBlSBdqDkNMEC BNLagShhv/HvqYbo9q4TEWEsNLAwPj0/bRfUwSHW6SAX7cJmZLYtk8eoiRFIngT3 xHuRzdhVDOBCnFcZ/QCaYKjXDE4eGbkB/gJhKZU6HTMHV5AbpcDHfxvAU6+Q8lBV oH7sksCo1ViOyx18SfGbAQDyEX/DofCZZdGu/nWGaiHL4lsd6R31F/r0j1lZC8IV u+tbkRFIlKlncwAGSe+SdswXD3+idEmXvxWMq2d9GN4AsDN4qNKeb86lcasZSqco e+P+FRd+TTEbo3RLHoj9FU2rIgGaG9pOOl2A3WCfEKHoUnBQLdyDauluCzpfCM2U Cx5ltgzAF+obpaYBnZsgjEfeeGfCNMeF5lKFijA5pxt/X1g+DXGC3DF3VRBNFnIT P3OOI3aXQ4CWhUkwd7LSoDISPN4EmZWv0hupUp/GV17wJjBtGBhKGRZYfSpsCKpg UOLYqqFrVlxKIMy0zfu+EmO6VeQWrFCJpQq/y1kvLaWWiNMJuLaYAEdQQ9AleX5N 5R211Q8mZ4aFTK2c4sBW =pQk8 -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform
Hello Piotr, On 01/14/2014 01:33 PM, Piotr Wilczek wrote: Hi Przemyslaw, -Original Message- From: Przemyslaw Marczak [mailto:p.marc...@samsung.com] Sent: Tuesday, January 14, 2014 11:10 AM To: u-boot@lists.denx.de Cc: Piotr Wilczek; 'Minkyu Kang'; 'Kyungmin Park'; Lukasz Majewski Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables describing platform Hello Piotr, On 01/14/2014 10:37 AM, Piotr Wilczek wrote: Hi Przemyslaw, -Original Message- From: Przemyslaw Marczak [mailto:p.marc...@samsung.com] Sent: Tuesday, January 14, 2014 9:48 AM To: u-boot@lists.denx.de Cc: Piotr Wilczek; Minkyu Kang; Kyungmin Park; Lukasz Majewski Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables describing platform Hello Piotr, On 01/14/2014 08:59 AM, Piotr Wilczek wrote: This patch adds variables describing platform (soc, board, vendor) to default environment. Samsung's common misc imitialisation is enabled to provide additional board information in envs. Signed-off-by: Piotr Wilczek p.wilc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Przemyslaw Marczak p.marc...@samsung.com --- include/configs/s5pc210_universal.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index d9e4c56..5e5f8e0 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -124,6 +124,11 @@ #define CONFIG_SYS_CONSOLE_INFO_QUIET #define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_ENV_VARS_UBOOT_CONFIG #define +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG + +#define CONFIG_MISC_INIT_R + You depends on my patch set and here we have a conflict in universal, trats and trats2. My patchset defines CONFIG_MISC_INIT_R for these three boards, so you can remove it from configs. Is the samsung/common/misc.c file reserved only for misc_init_r function? I think that CONFIG_MISC_INIT_R is misleading. No, it isn't reserved. Misc_init_r function is for various things and is called from board_init_r. In this function we can put any common code for our vendor boards. So why do you think it is bad? So the misc.c file is reserved for misc_init_r only. The file is only for CONFIG_MISC_INIT_R. In this meaning - YES, will compile only for CONFIG_MISC I thought that in misc.c we can put some common code not necessarily called form misc_init_r but say from borad_late_init. But ok. To add some common code for board_late_init I need to add another file. That was in my first patch set. So maybe I remove the CONFIG_MISC_INIT_R dependency from Makefile. #define CONFIG_EXTRA_ENV_SETTINGS \ updateb= \ onenand erase 0x0 0x10; \ Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com Best regards, Piotr Wilczek Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com Thanks, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 03/12] samsung: common: Add misc file and common function misc_init_r().
Hello, In case of discussion with Piotr Wilczek maybe it is better to make some changes in this patch. On 01/10/2014 03:31 PM, Przemyslaw Marczak wrote: Config: CONFIG_MISC_INIT_R enables implementation of misc_init_r() in common file:: - board/samsung/common/misc.c Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Acked-by: Jaehoon Chung jh80.ch...@samsung.com --- Changes v2: - change CONFIG_SAMSUNG to CONFIG_MISC_INIT_R Changes v3: - fix merge conflict in board/samsung/common/Makefile Changes v4: - none Changes v5: - add acked-by board/samsung/common/Makefile |1 + board/samsung/common/misc.c | 14 ++ 2 files changed, 15 insertions(+) create mode 100644 board/samsung/common/misc.c diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile index 22bd6b1..79547a3 100644 --- a/board/samsung/common/Makefile +++ b/board/samsung/common/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o obj-$(CONFIG_THOR_FUNCTION) += thor.o obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o +obj-$(CONFIG_MISC_INIT_R) += misc.o here change to: obj-y += misc.o ifndef CONFIG_SPL_BUILD obj-$(CONFIG_BOARD_COMMON)+= board.o diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c new file mode 100644 index 000..3764d12 --- /dev/null +++ b/board/samsung/common/misc.c @@ -0,0 +1,14 @@ +/* + * Copyright (C) 2013 Samsung Electronics + * Przemyslaw Marczak p.marc...@samsung.com + * + * SPDX-License-Identifier:GPL-2.0+ + */ + +#include common.h + and here: #ifdef CONFIG_MISC_INIT_R +/* Common for Samsung boards */ +int misc_init_r(void) +{ + return 0; +} #endif In this way we can add other functions in the future even without CONFIG_MISC_INIT_R. Is it better solution? Thank you, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/3] net: phy: atheros: Fix the masks for AR8031/8035
Hi Joe, On Fri, Jan 3, 2014 at 3:55 PM, Fabio Estevam feste...@gmail.com wrote: From: Fabio Estevam fabio.este...@freescale.com Use the same masks as used in the kernel: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/net/phy/at803x.c?id=refs/tags/v3.12.6 With such changes Ethernet is functional on hummingboard solo. Cc: Joe Hershberger joe.hershber...@gmail.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Stefano Babic sba...@denx.de Any chance of getting this patch for 2014.01? Thanks, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] BCH8 support when we do not have ELM h/w engine.
Hi Pekon, 2014/1/13 Gupta, Pekon pe...@ti.com: Hi Enric, Hi Pekon, 2013/12/10 Gupta, Pekon pe...@ti.com: Hi Enric, Sorry I missed your earlier mail, so din't check this.. From: Enric Balletbo Serra [mailto:eballe...@gmail.com] I saw that the OOB layout is not the same when I flash the rootfs from the u-boot or from the kernel. For example: If the rootfs is flashed from the kernel the OOB data is like that: U-Boot # nand dump.oob 0x68 Page 0068 dump: OOB: ff ff 79 43 68 64 3b 80 b2 46 49 4d 58 2a 6d ff 52 3f 7d 2a 7f a2 98 70 57 32 30 35 c7 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff If the rootfs is flashed for the u-boot the OOB data is like data: Page 0068 dump: OOB: ff ff 79 43 68 64 3b 80 b2 46 49 4d 58 2a 6d 52 3f 7d 2a 7f a2 98 70 57 32 30 35 c7 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff Note that look the same except after byte number 16. In the first case is ff 52 3f 7d 2a 7f a2 98 70 and in the second case is 52 3f 7d 2a 7f a2 98 70 It's possible that something is wrong writting the OOB data ? Any clue ? I'm in the right direction or completely wrong ? Yes, there seems to be an mis-match between u-boot and kernel ecc-layout. Give me a day's time, and I'll try to root cause this. However, don't have OMAP3 boards, so I can test this only on other boards. with regards, pekon If I can help somehow just let me know. I have posted the patches to fix this regression between u-boot and kernel. And was expecting if you could test it confirm if this solves regression on your OMAP3 board. http://lists.infradead.org/pipermail/linux-mtd/2014-January/051384.html You can download the patch from [1] [1] http://lists.infradead.org/pipermail/linux-mtd/2013-December/050944.html with regards, pekon Thanks for the patches, I tested and worked for me on our OMAP3 based boards, I'll answer the mail that you sent to the linux-omap ML. Sorry for the delay, cheers, Enric ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] DRA7: Add support for ES1.1 silicon ID code
ES1.1 silicon is a very minor variant of ES1.0. Add priliminary support for ES1.1 IDCODE change. Signed-off-by: Nishanth Menon n...@ti.com Reviewed-by: Tom Rini tr...@ti.com --- arch/arm/cpu/armv7/omap-common/clocks-common.c |2 +- arch/arm/cpu/armv7/omap-common/emif-common.c |5 ++--- arch/arm/cpu/armv7/omap5/hw_data.c |2 ++ arch/arm/cpu/armv7/omap5/hwinit.c |3 +++ arch/arm/cpu/armv7/omap5/sdram.c |4 arch/arm/include/asm/arch-omap5/omap.h |1 + arch/arm/include/asm/omap_common.h |1 + 7 files changed, 14 insertions(+), 4 deletions(-) diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c b/arch/arm/cpu/armv7/omap-common/clocks-common.c index dfa3760..2883c1d 100644 --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c @@ -436,7 +436,7 @@ static void setup_non_essential_dplls(void) #ifdef CONFIG_SYS_OMAP_ABE_SYSCK abe_ref_clk = CM_ABE_PLL_REF_CLKSEL_CLKSEL_SYSCLK; - if (omap_revision() == DRA752_ES1_0) + if (is_dra7xx()) /* Select the sys clk for dpll_abe */ clrsetbits_le32((*prcm)-cm_abe_pll_sys_clksel, CM_CLKSEL_ABE_PLL_SYS_CLKSEL_MASK, diff --git a/arch/arm/cpu/armv7/omap-common/emif-common.c b/arch/arm/cpu/armv7/omap-common/emif-common.c index cd6289b..429c4be 100644 --- a/arch/arm/cpu/armv7/omap-common/emif-common.c +++ b/arch/arm/cpu/armv7/omap-common/emif-common.c @@ -179,8 +179,7 @@ void emif_update_timings(u32 base, const struct emif_regs *regs) writel(regs-temp_alert_config, emif-emif_temp_alert_config); writel(regs-emif_ddr_phy_ctlr_1, emif-emif_ddr_phy_ctrl_1_shdw); - if ((omap_revision() = OMAP5430_ES1_0) || - (omap_revision() == DRA752_ES1_0)) { + if ((omap_revision() = OMAP5430_ES1_0) || is_dra7xx()) { writel(EMIF_L3_CONFIG_VAL_SYS_10_MPU_5_LL_0, emif-emif_l3_config); } else if (omap_revision() = OMAP4460_ES1_0) { @@ -309,7 +308,7 @@ static void ddr3_init(u32 base, const struct emif_regs *regs) * The same sequence should work on OMAP5432 as well. But strange that * it is not working */ - if (omap_revision() == DRA752_ES1_0) { + if (is_dra7xx()) { do_ext_phy_settings(base, regs); writel(regs-sdram_config2, emif-emif_lpddr2_nvm_config); writel(regs-sdram_config_init, emif-emif_sdram_config); diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c index 5268a1f..e47b454 100644 --- a/arch/arm/cpu/armv7/omap5/hw_data.c +++ b/arch/arm/cpu/armv7/omap5/hw_data.c @@ -639,6 +639,7 @@ void hw_data_init(void) break; case DRA752_ES1_0: + case DRA752_ES1_1: *prcm = dra7xx_prcm; *dplls_data = dra7xx_dplls; *omap_vcores = dra752_volts; @@ -666,6 +667,7 @@ void get_ioregs(const struct ctrl_ioregs **regs) *regs = ioregs_omap5432_es2; break; case DRA752_ES1_0: + case DRA752_ES1_1: *regs = ioregs_dra7xx_es1; break; diff --git a/arch/arm/cpu/armv7/omap5/hwinit.c b/arch/arm/cpu/armv7/omap5/hwinit.c index 5386ae0..737d23c 100644 --- a/arch/arm/cpu/armv7/omap5/hwinit.c +++ b/arch/arm/cpu/armv7/omap5/hwinit.c @@ -333,6 +333,9 @@ void init_omap_revision(void) case DRA752_CONTROL_ID_CODE_ES1_0: *omap_si_rev = DRA752_ES1_0; break; + case DRA752_CONTROL_ID_CODE_ES1_1: + *omap_si_rev = DRA752_ES1_1; + break; default: *omap_si_rev = OMAP5430_SILICON_ID_INVALID; } diff --git a/arch/arm/cpu/armv7/omap5/sdram.c b/arch/arm/cpu/armv7/omap5/sdram.c index 2e18706..16a91f9 100644 --- a/arch/arm/cpu/armv7/omap5/sdram.c +++ b/arch/arm/cpu/armv7/omap5/sdram.c @@ -245,6 +245,7 @@ static void emif_get_reg_dump_sdp(u32 emif_nr, const struct emif_regs **regs) *regs = emif_regs_ddr3_532_mhz_1cs_es2; break; case DRA752_ES1_0: + case DRA752_ES1_1: switch (emif_nr) { case 1: *regs = emif_1_regs_ddr3_532_mhz_1cs_dra_es1; @@ -273,6 +274,7 @@ static void emif_get_dmm_regs_sdp(const struct dmm_lisa_map_regs *dmm_lisa_regs = lisa_map_4G_x_2_x_2; break; case DRA752_ES1_0: + case DRA752_ES1_1: default: *dmm_lisa_regs = lisa_map_2G_x_2_x_2_2G_x_1_x_2; } @@ -460,6 +462,7 @@ static void emif_get_ext_phy_ctrl_const_regs(u32 emif_nr, *size = ARRAY_SIZE(ddr3_ext_phy_ctrl_const_base_es2); break; case DRA752_ES1_0: + case DRA752_ES1_1: if (emif_nr == 1) { *regs =
[U-Boot] [PATCH v2] powerpc: mpc83xx: remove redundant CONFIG_MPC83xx definition
We do not have to define CONFIG_MPC83xx in board config headers because it is defined in arch/powerpc/cpu/mpc83xx/config.mk. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: - Fix a typo in the subject: s/redandant/redundant/ include/configs/MERGERBOX.h| 1 - include/configs/MPC8308RDB.h | 1 - include/configs/MPC8313ERDB.h | 1 - include/configs/MPC8315ERDB.h | 1 - include/configs/MPC8323ERDB.h | 1 - include/configs/MPC832XEMDS.h | 1 - include/configs/MPC8349EMDS.h | 1 - include/configs/MPC8349ITX.h | 1 - include/configs/MPC8360EMDS.h | 1 - include/configs/MPC8360ERDK.h | 1 - include/configs/MPC837XEMDS.h | 1 - include/configs/MPC837XERDB.h | 1 - include/configs/MVBLM7.h | 1 - include/configs/SIMPC8313.h| 1 - include/configs/TQM834x.h | 1 - include/configs/km/km8309-common.h | 1 - include/configs/mpc8308_p1m.h | 1 - include/configs/sbc8349.h | 1 - include/configs/ve8313.h | 1 - include/configs/vme8349.h | 1 - 20 files changed, 20 deletions(-) diff --git a/include/configs/MERGERBOX.h b/include/configs/MERGERBOX.h index 8a40029..3dcea0b 100644 --- a/include/configs/MERGERBOX.h +++ b/include/configs/MERGERBOX.h @@ -16,7 +16,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 -#define CONFIG_MPC83xx 1 #define CONFIG_MPC837x 1 #define CONFIG_MPC8377 1 diff --git a/include/configs/MPC8308RDB.h b/include/configs/MPC8308RDB.h index 0131b9c..bf974fd 100644 --- a/include/configs/MPC8308RDB.h +++ b/include/configs/MPC8308RDB.h @@ -13,7 +13,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 family */ -#define CONFIG_MPC83xx 1 /* MPC83xx family */ #define CONFIG_MPC830x 1 /* MPC830x family */ #define CONFIG_MPC8308 1 /* MPC8308 CPU specific */ #define CONFIG_MPC8308RDB 1 /* MPC8308RDB board specific */ diff --git a/include/configs/MPC8313ERDB.h b/include/configs/MPC8313ERDB.h index 07719e9..69b2cb1 100644 --- a/include/configs/MPC8313ERDB.h +++ b/include/configs/MPC8313ERDB.h @@ -14,7 +14,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 -#define CONFIG_MPC83xx 1 #define CONFIG_MPC831x 1 #define CONFIG_MPC8313 1 #define CONFIG_MPC8313ERDB 1 diff --git a/include/configs/MPC8315ERDB.h b/include/configs/MPC8315ERDB.h index aedb529..3dd52ce 100644 --- a/include/configs/MPC8315ERDB.h +++ b/include/configs/MPC8315ERDB.h @@ -35,7 +35,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 family */ -#define CONFIG_MPC83xx 1 /* MPC83xx family */ #define CONFIG_MPC831x 1 /* MPC831x CPU family */ #define CONFIG_MPC8315 1 /* MPC8315 CPU specific */ #define CONFIG_MPC8315ERDB 1 /* MPC8315ERDB board specific */ diff --git a/include/configs/MPC8323ERDB.h b/include/configs/MPC8323ERDB.h index c4c771b..65a63e2 100644 --- a/include/configs/MPC8323ERDB.h +++ b/include/configs/MPC8323ERDB.h @@ -14,7 +14,6 @@ */ #define CONFIG_E3001 /* E300 family */ #define CONFIG_QE 1 /* Has QE */ -#define CONFIG_MPC83xx 1 /* MPC83xx family */ #define CONFIG_MPC832x 1 /* MPC832x CPU specific */ #defineCONFIG_SYS_TEXT_BASE0xFE00 diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h index f5b6202..1735b3c 100644 --- a/include/configs/MPC832XEMDS.h +++ b/include/configs/MPC832XEMDS.h @@ -12,7 +12,6 @@ */ #define CONFIG_E3001 /* E300 family */ #define CONFIG_QE 1 /* Has QE */ -#define CONFIG_MPC83xx 1 /* MPC83xx family */ #define CONFIG_MPC832x 1 /* MPC832x CPU specific */ #define CONFIG_MPC832XEMDS 1 /* MPC832XEMDS board specific */ diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 7640d06..6b7d648 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -17,7 +17,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 Family */ -#define CONFIG_MPC83xx 1 /* MPC83xx family */ #define CONFIG_MPC834x 1 /* MPC834x family */ #define CONFIG_MPC8349 1 /* MPC8349 specific */ #define CONFIG_MPC8349EMDS 1 /* MPC8349EMDS board specific */ diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h index ffb9a15..398918a 100644 --- a/include/configs/MPC8349ITX.h +++ b/include/configs/MPC8349ITX.h @@ -47,7 +47,6 @@ /* * High Level Configuration Options */ -#define CONFIG_MPC83xx 1 #define CONFIG_MPC834x /* MPC834x family (8343, 8347, 8349) */ #define CONFIG_MPC8349 /* MPC8349 specific */ diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h index d4c82cd..aefde74 100644 ---
[U-Boot] [PATCH] .gitignore: ignore u-boot.elf and tools/relocate-rela
Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- .gitignore | 1 + tools/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 3b14c25..97f7db0 100644 --- a/.gitignore +++ b/.gitignore @@ -29,6 +29,7 @@ /SPL /System.map /u-boot +/u-boot.elf /u-boot.hex /u-boot.imx /u-boot-with-spl.imx diff --git a/tools/.gitignore b/tools/.gitignore index 930fa2e..cd2f041 100644 --- a/tools/.gitignore +++ b/tools/.gitignore @@ -10,6 +10,7 @@ /mxsboot /ncb /proftool +/relocate-rela /ubsha1 /xway-swap-bytes /*.exe -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] powerpc: mpc5xxx: remove redundant CONFIG_MPC5xxx definition
We do not have to define CONFIG_MPC5xxx in board config headers (and start.S) because it is defined in arch/powerpc/cpu/mpc5xxx/config.mk. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: - Fix a typo in the subject: s/redandant/redundant/ arch/powerpc/cpu/mpc5xxx/start.S | 2 -- include/configs/BC3450.h | 1 - include/configs/IceCube.h | 1 - include/configs/MVBC_P.h | 1 - include/configs/MVSMR.h| 1 - include/configs/PM520.h| 1 - include/configs/TB5200.h | 1 - include/configs/TOP5200.h | 1 - include/configs/TQM5200.h | 1 - include/configs/Total5200.h| 1 - include/configs/a3m071.h | 1 - include/configs/a4m072.h | 1 - include/configs/aev.h | 1 - include/configs/canmb.h| 1 - include/configs/cm5200.h | 1 - include/configs/cpci5200.h | 1 - include/configs/digsy_mtc.h| 1 - include/configs/galaxy5200.h | 1 - include/configs/hmi1001.h | 1 - include/configs/inka4x0.h | 1 - include/configs/ipek01.h | 1 - include/configs/jupiter.h | 1 - include/configs/manroland/mpc5200-common.h | 1 - include/configs/mcc200.h | 1 - include/configs/mecp5200.h | 1 - include/configs/motionpro.h| 1 - include/configs/munices.h | 1 - include/configs/o2dnt-common.h | 1 - include/configs/pcm030.h | 1 - include/configs/pf5200.h | 1 - include/configs/v38b.h | 1 - 31 files changed, 32 deletions(-) diff --git a/arch/powerpc/cpu/mpc5xxx/start.S b/arch/powerpc/cpu/mpc5xxx/start.S index 84ab41e..02c706e 100644 --- a/arch/powerpc/cpu/mpc5xxx/start.S +++ b/arch/powerpc/cpu/mpc5xxx/start.S @@ -14,8 +14,6 @@ #include mpc5xxx.h #include version.h -#define CONFIG_MPC5xxx 1 /* needed for Linux kernel header files */ - #include ppc_asm.tmpl #include ppc_defs.h diff --git a/include/configs/BC3450.h b/include/configs/BC3450.h index 377db7b..ad69d33 100644 --- a/include/configs/BC3450.h +++ b/include/configs/BC3450.h @@ -22,7 +22,6 @@ /* * High Level Configuration Options */ -#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ #define CONFIG_MPC5200 1 /* (more precisely a MPC5200 CPU) */ #define CONFIG_TQM5200 1 /* ... on a TQM5200 module */ diff --git a/include/configs/IceCube.h b/include/configs/IceCube.h index 52368f8..ca49a99 100644 --- a/include/configs/IceCube.h +++ b/include/configs/IceCube.h @@ -13,7 +13,6 @@ * (easy to change) */ -#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ #define CONFIG_MPC5200 1 /* (more precisely a MPC5200 CPU) */ #define CONFIG_ICECUBE 1 /* ... on IceCube board */ diff --git a/include/configs/MVBC_P.h b/include/configs/MVBC_P.h index 9d49de7..99e4e90 100644 --- a/include/configs/MVBC_P.h +++ b/include/configs/MVBC_P.h @@ -13,7 +13,6 @@ #include version.h -#define CONFIG_MPC5xxx 1 #define CONFIG_MPC5200 1 #ifndef CONFIG_SYS_TEXT_BASE diff --git a/include/configs/MVSMR.h b/include/configs/MVSMR.h index f69b9a8..bb565b6 100644 --- a/include/configs/MVSMR.h +++ b/include/configs/MVSMR.h @@ -13,7 +13,6 @@ #include version.h -#define CONFIG_MPC5xxx 1 #define CONFIG_MPC5200 1 #ifndef CONFIG_SYS_TEXT_BASE diff --git a/include/configs/PM520.h b/include/configs/PM520.h index 557a8ba..767ffdc 100644 --- a/include/configs/PM520.h +++ b/include/configs/PM520.h @@ -14,7 +14,6 @@ */ #define CONFIG_MPC5200 -#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ #define CONFIG_PM520 1 /* ... on PM520 board */ #defineCONFIG_SYS_TEXT_BASE0xfff0 diff --git a/include/configs/TB5200.h b/include/configs/TB5200.h index 90f7fc4..af550aa 100644 --- a/include/configs/TB5200.h +++ b/include/configs/TB5200.h @@ -16,7 +16,6 @@ * (easy to change) */ -#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ #define CONFIG_MPC5200 1 /* (more precisely an MPC5200 CPU) */ #define CONFIG_TQM5200 1 /* ... on TQM5200 module */ #define CONFIG_TB5200 1 /* ... on a TB5200 base board */ diff --git a/include/configs/TOP5200.h b/include/configs/TOP5200.h index 7aba009..e19201f 100644 --- a/include/configs/TOP5200.h +++ b/include/configs/TOP5200.h @@ -25,7 +25,6 @@ * (easy to change) */ -#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ #define CONFIG_MPC5200 1 /* More exactly a MPC5200 */ #define CONFIG_TOP5200 1 /* ... on TOP5200 board - we need this
[U-Boot] [PATCH v2] powerpc: ppc4xx: remove redundant CONFIG_4xx definition
We do not have to define CONFIG_4xx in board config headers because it is defined in arch/powerpc/cpu/ppc4xx/config.mk. include/configs/JSE.h defines CONFIG_4x, not CONFIG_4xx. I believe it is a typo because CONFIG_4x is not used at all in other files. So, I also deleted CONFIG_4x in include/configs/JSE.h. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: - Fix a typo in the subject: s/redandant/redundant/ include/configs/APC405.h | 1 - include/configs/AR405.h | 1 - include/configs/ASH405.h | 1 - include/configs/CATcenter.h | 1 - include/configs/CMS700.h | 1 - include/configs/CPCI2DP.h| 1 - include/configs/CPCI405.h| 1 - include/configs/CPCI4052.h | 1 - include/configs/CPCI405AB.h | 1 - include/configs/CPCI405DT.h | 1 - include/configs/CPCIISER4.h | 1 - include/configs/CRAYL1.h | 1 - include/configs/DP405.h | 1 - include/configs/DU405.h | 1 - include/configs/DU440.h | 1 - include/configs/G2000.h | 1 - include/configs/HH405.h | 1 - include/configs/HUB405.h | 1 - include/configs/JSE.h| 2 -- include/configs/KAREF.h | 1 - include/configs/METROBOX.h | 1 - include/configs/MIP405.h | 1 - include/configs/OCRTC.h | 1 - include/configs/PCI405.h | 1 - include/configs/PIP405.h | 1 - include/configs/PLU405.h | 1 - include/configs/PMC405.h | 1 - include/configs/PMC405DE.h | 1 - include/configs/PMC440.h | 1 - include/configs/PPChameleonEVB.h | 1 - include/configs/VOH405.h | 1 - include/configs/VOM405.h | 1 - include/configs/W7OLMC.h | 1 - include/configs/W7OLMG.h | 1 - include/configs/WUH405.h | 1 - include/configs/acadia.h | 1 - include/configs/alpr.h | 1 - include/configs/bamboo.h | 1 - include/configs/bluestone.h | 1 - include/configs/bubinga.h| 1 - include/configs/canyonlands.h| 1 - include/configs/csb272.h | 1 - include/configs/csb472.h | 1 - include/configs/dlvision-10g.h | 1 - include/configs/dlvision.h | 1 - include/configs/ebony.h | 1 - include/configs/gdppc440etx.h| 1 - include/configs/icon.h | 1 - include/configs/intip.h | 1 - include/configs/io.h | 1 - include/configs/io64.h | 1 - include/configs/iocon.h | 1 - include/configs/katmai.h | 1 - include/configs/kilauea.h| 1 - include/configs/korat.h | 1 - include/configs/luan.h | 1 - include/configs/lwmon5.h | 1 - include/configs/makalu.h | 1 - include/configs/neo.h| 1 - include/configs/ocotea.h | 1 - include/configs/p3p440.h | 1 - include/configs/pcs440ep.h | 1 - include/configs/quad100hd.h | 1 - include/configs/redwood.h| 1 - include/configs/sbc405.h | 1 - include/configs/sc3.h| 1 - include/configs/sequoia.h| 1 - include/configs/t3corp.h | 1 - include/configs/taihu.h | 1 - include/configs/taishan.h| 1 - include/configs/walnut.h | 1 - include/configs/xilinx-ppc405.h | 1 - include/configs/xilinx-ppc440.h | 1 - include/configs/xpedite1000.h| 1 - include/configs/yosemite.h | 1 - include/configs/yucca.h | 1 - include/configs/zeus.h | 1 - 77 files changed, 78 deletions(-) diff --git a/include/configs/APC405.h b/include/configs/APC405.h index afc9ae8..2678f50 100644 --- a/include/configs/APC405.h +++ b/include/configs/APC405.h @@ -19,7 +19,6 @@ * (easy to change) */ #define CONFIG_405GP 1 /* This is a PPC405 CPU */ -#define CONFIG_4xx 1 /* ...member of PPC4xx family */ #define CONFIG_APCG405 1 /* ...on a APC405 board */ #defineCONFIG_SYS_TEXT_BASE0xFFF8 diff --git a/include/configs/AR405.h b/include/configs/AR405.h index a4bd4b1..45dd46a 100644 --- a/include/configs/AR405.h +++ b/include/configs/AR405.h @@ -18,7 +18,6 @@ */ #define CONFIG_405GP 1 /* This is a PPC405GP CPU */ -#define CONFIG_4xx 1 /* ...member of PPC4xx family */ #define CONFIG_AR405 1 /* ...on a AR405 board */ #defineCONFIG_SYS_TEXT_BASE0xFFFA diff --git a/include/configs/ASH405.h b/include/configs/ASH405.h index 2f53407..2ff9b59 100644 --- a/include/configs/ASH405.h +++ b/include/configs/ASH405.h @@ -18,7 +18,6 @@ */ #define CONFIG_405EP 1 /* This is a PPC405 CPU */ -#define CONFIG_4xx 1 /* ...member of PPC4xx family */ #define CONFIG_ASH405 1 /* ...on a ASH405 board */ #defineCONFIG_SYS_TEXT_BASE0xFFFC diff --git a/include/configs/CATcenter.h
Re: [U-Boot] Compiling fw_printenv tool
Hello Detlev How do I cross compile it for my embedded system? Do I just set the HOSTCC environment variable in the Makefile? No changes in any makefiles are needed, just do make HOSTCC=arm-none-linuex-gnueabi-gcc env It looks weird to me. I think HOSTCC should be always gcc. In my understanding, tools/env/fw_printenv is not a host program but a one for the target embedded Linux. Is there any reason that we don't fix tools/env/Makefile? $(obj)fw_printenv: $(HOSTSRCS) $(HEADERS) $(HOSTCC) $(HOSTCFLAGS_NOPED) $(HOSTLDFLAGS) -o $@ $(HOSTSRCS) $(HOSTSTRIP) $@ to $(obj)fw_printenv: $(HOSTSRCS) $(HEADERS) $(CC) $(HOSTCFLAGS_NOPED) $(HOSTLDFLAGS) -o $@ $(HOSTSRCS) $(STRIP) $@ Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] board: tec-ng: Do not make directories in a board Makefile
Commit e5c5301f refactored the build system not to make directories in board makefiles. But commit 8f380381 create directories again in board/avionic-design/tec-ng/Makefile. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Alban Bedel alban.be...@avionic-design.de --- board/avionic-design/tec-ng/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/board/avionic-design/tec-ng/Makefile b/board/avionic-design/tec-ng/Makefile index f41eb30..79d8602 100644 --- a/board/avionic-design/tec-ng/Makefile +++ b/board/avionic-design/tec-ng/Makefile @@ -5,8 +5,6 @@ # SPDX-License-Identifier: GPL-2.0+ # -$(shell mkdir -p $(obj)../common $(obj)../../nvidia/common) - obj-y := ../common/tamonten-ng.o include ../../nvidia/common/common.mk -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] powerpc: mpc8xx: remove redundant CONFIG_8xx definition
We do not have to define CONFIG_8xx in source files because it is defined in arch/powerpc/cpu/mpc8xx/config.mk Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: - Fix a typo in the subject: s/redandant/redundant/ arch/powerpc/cpu/mpc8xx/kgdb.S | 2 -- arch/powerpc/cpu/mpc8xx/start.S | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/powerpc/cpu/mpc8xx/kgdb.S b/arch/powerpc/cpu/mpc8xx/kgdb.S index ac1fe8f..e774d1e 100644 --- a/arch/powerpc/cpu/mpc8xx/kgdb.S +++ b/arch/powerpc/cpu/mpc8xx/kgdb.S @@ -9,8 +9,6 @@ #include mpc8xx.h #include version.h -#define CONFIG_8xx 1 /* needed for Linux kernel header files */ - #include ppc_asm.tmpl #include ppc_defs.h diff --git a/arch/powerpc/cpu/mpc8xx/start.S b/arch/powerpc/cpu/mpc8xx/start.S index 99cafbd..f8aa93d 100644 --- a/arch/powerpc/cpu/mpc8xx/start.S +++ b/arch/powerpc/cpu/mpc8xx/start.S @@ -26,8 +26,6 @@ #include mpc8xx.h #include version.h -#define CONFIG_8xx 1 /* needed for Linux kernel header files */ - #include ppc_asm.tmpl #include ppc_defs.h -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Bug in TOP860 code with gcc 4.8.1
Hello Reinhard, On 01/14/2014 12:33 PM, Reinhard Meyer wrote: Dear Wolfgang, Dear Reinhard, attempting to build the TOP860 code with a GCC 4.8.1 based tool chain (say ELDK v5.5 or Yocto 1.5) gives the following errors: - ./MAKEALL TOP860 Configuring for TOP860 board... textdata bss dec hex filename 165471 21020 17316 203807 31c1f ./u-boot ../common/flash.c: In function 'flash_init': ../common/flash.c:336:20: warning: iteration 128u invokes undefined behavior [-Waggressive-loop-optimizations] info-start[i] = (ulong)addr + 0x1 * i; ^ ../common/flash.c:334:4: note: containing loop for (i = 0; i info-sector_count; i++) ^ ... Can you please provide a fix - or is this old hardware and the code should be removed from the U-Boot tree? 1. on first and second glance I cannot see where this (simple!!) loop might invoke undefined behaviour. Seems like a compiler/optimizer bug to me... 2. should not the same issue arise with TOP5200 (using the same flash.c) ?? 3. nevertheless TOP860 can be removed. It is out of bounds: include/configs/TOP860.h:#define CONFIG_SYS_MAX_FLASH_SECT128 /* max number of sectors on one chip*/ include/configs/TOP5200.h:#define CONFIG_SYS_MAX_FLASH_SECT 256/* max num of sects on one chip */ Removing will work as well of course ;) Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] DRA7: add ABB setup for MPU voltage domain
Patch adds modification to shared omap5 abb_setup() function, and proper registers definitions needed for ABB setup sequence. ABB is initialized for MPU voltage domain at OPP_NOM. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/cpu/armv7/omap5/abb.c | 13 ++--- arch/arm/cpu/armv7/omap5/prcm-regs.c |8 arch/arm/include/asm/arch-omap5/omap.h |2 ++ 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv7/omap5/abb.c b/arch/arm/cpu/armv7/omap5/abb.c index 31b6795..3bf8897 100644 --- a/arch/arm/cpu/armv7/omap5/abb.c +++ b/arch/arm/cpu/armv7/omap5/abb.c @@ -28,18 +28,25 @@ s8 abb_setup_ldovbb(u32 fuse, u32 ldovbb) { u32 vset; + u32 fuse_enable_mask = OMAP5_ABB_FUSE_ENABLE_MASK; + u32 fuse_vset_mask = OMAP5_ABB_FUSE_VSET_MASK; + if (!is_omap54xx()) { + /* DRA7 */ + fuse_enable_mask = DRA7_ABB_FUSE_ENABLE_MASK; + fuse_vset_mask = DRA7_ABB_FUSE_VSET_MASK; + } /* * ABB parameters must be properly fused * otherwise ABB should be disabled */ vset = readl(fuse); - if (!(vset OMAP5_ABB_FUSE_ENABLE_MASK)) + if (!(vset fuse_enable_mask)) return -1; /* prepare VSET value for LDOVBB mux register */ - vset = OMAP5_ABB_FUSE_VSET_MASK; - vset = ffs(OMAP5_ABB_FUSE_VSET_MASK) - 1; + vset = fuse_vset_mask; + vset = ffs(fuse_vset_mask) - 1; vset = ffs(OMAP5_ABB_LDOVBBMPU_VSET_OUT_MASK) - 1; vset |= OMAP5_ABB_LDOVBBMPU_MUX_CTRL_MASK; diff --git a/arch/arm/cpu/armv7/omap5/prcm-regs.c b/arch/arm/cpu/armv7/omap5/prcm-regs.c index 77c428b..ff32807 100644 --- a/arch/arm/cpu/armv7/omap5/prcm-regs.c +++ b/arch/arm/cpu/armv7/omap5/prcm-regs.c @@ -432,11 +432,13 @@ struct omap_sys_ctrl_regs const dra7xx_ctrl = { .control_srcomp_code_latch = 0x4A002E84, .control_ddr_control_ext_0 = 0x4A002E88, .control_padconf_core_base = 0x4A003400, + .control_std_fuse_opp_vdd_mpu_2 = 0x4A003B24, .control_port_emif1_sdram_config= 0x4AE0C110, .control_port_emif1_lpddr2_nvm_config = 0x4AE0C114, .control_port_emif2_sdram_config= 0x4AE0C118, .control_emif1_sdram_config_ext = 0x4AE0C144, .control_emif2_sdram_config_ext = 0x4AE0C148, + .control_wkup_ldovbb_mpu_voltage_ctrl = 0x4AE0C158, .control_padconf_mode = 0x4AE0C5A0, .control_xtal_oscillator= 0x4AE0C5A4, .control_i2c_2 = 0x4AE0C5A8, @@ -807,6 +809,9 @@ struct prcm_regs const dra7xx_prcm = { .cm_dsp_clkstctrl = 0x4a005400, .cm_dsp_dsp_clkctrl = 0x4a005420, + /* prm irqstatus regs */ + .prm_irqstatus_mpu_2= 0x4ae06014, + /* cm2.ckgen */ .cm_clksel_usb_60mhz= 0x4a008104, .cm_clkmode_dpll_per= 0x4a008140, @@ -967,4 +972,7 @@ struct prcm_regs const dra7xx_prcm = { .prm_vc_val_bypass = 0x4ae07da0, .prm_vc_cfg_i2c_mode= 0x4ae07db4, .prm_vc_cfg_i2c_clk = 0x4ae07db8, + + .prm_abbldo_mpu_setup = 0x4AE07DDC, + .prm_abbldo_mpu_ctrl= 0x4AE07DE0, }; diff --git a/arch/arm/include/asm/arch-omap5/omap.h b/arch/arm/include/asm/arch-omap5/omap.h index 34f6fc5..19fdece 100644 --- a/arch/arm/include/asm/arch-omap5/omap.h +++ b/arch/arm/include/asm/arch-omap5/omap.h @@ -205,6 +205,8 @@ struct s32ktimer { /* ABB efuse masks */ #define OMAP5_ABB_FUSE_VSET_MASK (0x1F 24) #define OMAP5_ABB_FUSE_ENABLE_MASK (0x1 29) +#define DRA7_ABB_FUSE_VSET_MASK(0x1F 20) +#define DRA7_ABB_FUSE_ENABLE_MASK (0x1 25) #define OMAP5_ABB_LDOVBBMPU_MUX_CTRL_MASK (0x1 10) #define OMAP5_ABB_LDOVBBMPU_VSET_OUT_MASK (0x1f 0) -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] DRA7: add ABB setup for MPU voltage domain
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/14/2014 01:27 PM, Nishanth Menon wrote: Patch adds modification to shared omap5 abb_setup() function, and proper registers definitions needed for ABB setup sequence. ABB is initialized for MPU voltage domain at OPP_NOM. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/cpu/armv7/omap5/abb.c | 13 ++--- arch/arm/cpu/armv7/omap5/prcm-regs.c |8 arch/arm/include/asm/arch-omap5/omap.h |2 ++ 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv7/omap5/abb.c b/arch/arm/cpu/armv7/omap5/abb.c index 31b6795..3bf8897 100644 --- a/arch/arm/cpu/armv7/omap5/abb.c +++ b/arch/arm/cpu/armv7/omap5/abb.c @@ -28,18 +28,25 @@ s8 abb_setup_ldovbb(u32 fuse, u32 ldovbb) { u32 vset; + u32 fuse_enable_mask = OMAP5_ABB_FUSE_ENABLE_MASK; + u32 fuse_vset_mask = OMAP5_ABB_FUSE_VSET_MASK; My only concern, which I know the answer to I think, is shouldn't we just have no default values here, and case in the right one for omap5/dra74x and then dra72x in the future, etc, etc. But we don't know enough really to know if future SoCs will need a different statement here, so it's good enough for now. Reviewed-by: Tom Rini tr...@ti.com - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS1YqfAAoJENk4IS6UOR1WG6YP/3p2A28HH96gnagf/Rd64OKS TpHF9bduHMyiu1BBSfoYuw2pWAhVrnTCTyhFRy6P+xFcU6+V7k+IK8D4CjOTdvvL udgY5fm9tYBJvr8j3GRE5VLoBo/tXFkeKkEhhXh5tNJ0ag5KmKiHqF/0zWkJmj0Y YRmKtrRudl29Ot2vX+zStg/0cdJm37e9/0VDMJnoM+Sc06jlc3MLulh2c+D23gkO IxSdAFHVlFn2YHoxYlE6Vhys49op6Wr41QryxRoLvzSRoTj80oJq9+rMLWul2jpA mjCsslUdOMGm7WaipcjulBTZvLV3Qz1XNgCwUdidBXrpQxhe2VmkTMGzyU49gAC+ QrT+wgXWTKpAIsvLIRZJQ9GJ3I9ZnDrHwRw4mbUX++ey5fwahR7DtafT2DgRxRwb zLU0JpCBh2W98sTzNBfuGda3kYVDoNWu4nGZDB3H2wSn1r+dFNbQPmyWqAzMdFYa aN9G+GeunOi0sU5W9pCXXMbjjA3Iq/SE0zUNqERPOoBusCrUpzo0u6n64iFGfq8i r0EM6Lf5OxCyvqGdUbuDwe1D/fKceInqFglVuFppz87dRunTbU0gr5iGw29i5nkX iSaSoaGHlOlJhF9x5lr2cyTpxdNO6SYsgjr6d57VP8KPs0BMosVQoQ9N+3Y4SwIa S2gO/eIMTP9oA+3PcUPY =v4DC -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/3] net: phy: atheros: Fix the masks for AR8031/8035
Hi Joe, On 14/01/2014 20:03, Joe Hershberger wrote: On Tue, Jan 14, 2014 at 8:13 AM, Fabio Estevam feste...@gmail.com wrote: Hi Joe, On Fri, Jan 3, 2014 at 3:55 PM, Fabio Estevam feste...@gmail.com wrote: From: Fabio Estevam fabio.este...@freescale.com Use the same masks as used in the kernel: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/net/phy/at803x.c?id=refs/tags/v3.12.6 With such changes Ethernet is functional on hummingboard solo. Cc: Joe Hershberger joe.hershber...@gmail.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Stefano Babic sba...@denx.de Any chance of getting this patch for 2014.01? Yes, I'll send the pull request shortly. Thanks - then I will pick up the Hummingbird's patches, too. Regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 3/3] net: phy: atheros: Fix the masks for AR8031/8035
On Tue, Jan 14, 2014 at 8:13 AM, Fabio Estevam feste...@gmail.com wrote: Hi Joe, On Fri, Jan 3, 2014 at 3:55 PM, Fabio Estevam feste...@gmail.com wrote: From: Fabio Estevam fabio.este...@freescale.com Use the same masks as used in the kernel: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/net/phy/at803x.c?id=refs/tags/v3.12.6 With such changes Ethernet is functional on hummingboard solo. Cc: Joe Hershberger joe.hershber...@gmail.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Stefano Babic sba...@denx.de Any chance of getting this patch for 2014.01? Yes, I'll send the pull request shortly. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request: u-boot-net.git master
The following changes since commit cddb6b8304bfbc34f43920051256de7fe6c4c0ab: Prepare v2014.01-rc3 (2014-01-13 14:36:17 -0500) are available in the git repository at: git://git.denx.de/u-boot-net.git master for you to fetch changes up to f66e3ded61aeafc67f3ebb6ab0302b455f102ce3: net: phy: atheros: Fix the masks for AR8031/8035 (2014-01-14 14:00:41 -0600) Fabio Estevam (1): net: phy: atheros: Fix the masks for AR8031/8035 drivers/net/phy/atheros.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
On Tue, 2014-01-14 at 05:23 -0600, Sharma Bhupesh-B45370 wrote: Not the u-boot.bin, only u-boot: ./Foundation_v8 --image ./u-boot --cores=4 --no-secure-memory You need to use u-boot.elf, not the unrelocated u-boot. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
Hello Scott, Pekon, On 01/13/2014 07:18 PM, Scott Wood wrote: The omap_gpmc allows switching ecc at runtime. Since the NAND_SUBPAGE_READ flag is only set, it is kept when switching to hw ecc, which is not correct. This leads to calling chip-ecc.read_subpage which is not a valid pointer. Therefore also clear the flag so reading in hw mode works again. Cc: Scott Wood scottw...@freescale.com Cc: Pekon Gupta pe...@ti.com Cc: Nikita Kiryanov nik...@compulab.co.il Signed-off-by: Jeroen Hofstee jer...@myspectrum.nl --- drivers/mtd/nand/nand_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 1ce55fd..0762a19 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -3354,6 +3354,8 @@ int nand_scan_tail(struct mtd_info *mtd) /* Large page NAND with SOFT_ECC should support subpage reads */ if ((chip-ecc.mode == NAND_ECC_SOFT) (chip-page_shift 9)) chip-options |= NAND_SUBPAGE_READ; + else + chip-options = ~NAND_SUBPAGE_READ; NACK; this breaks NAND_SUBPAGE_READ with hardware ECC for drivers that support it. There is something to argue in favour of that in general, but there are no such drivers in u-boot at the moment though (well at least not doing it on purpose). I don't mind moving it to gpmc, but for correctness, it doesn't break things at the moment... I don't think it's good to add OMAP specific changes to nand_base.c. It's better if you can add this as part of omap_select_ecc_scheme() in omap_gpmc.c Yes, clear it from the OMAP switching code if OMAP can't do subpage reads with hardware ECC. The gpmc will fail in hw ecc mode when trying to do subpage reads. Pekon any suggestion for the elm mode, or should this bit just be cleared unconditionally? Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
On Tue, 2014-01-14 at 21:11 +0100, Jeroen Hofstee wrote: Hello Scott, Pekon, On 01/13/2014 07:18 PM, Scott Wood wrote: The omap_gpmc allows switching ecc at runtime. Since the NAND_SUBPAGE_READ flag is only set, it is kept when switching to hw ecc, which is not correct. This leads to calling chip-ecc.read_subpage which is not a valid pointer. Therefore also clear the flag so reading in hw mode works again. Cc: Scott Wood scottw...@freescale.com Cc: Pekon Gupta pe...@ti.com Cc: Nikita Kiryanov nik...@compulab.co.il Signed-off-by: Jeroen Hofstee jer...@myspectrum.nl --- drivers/mtd/nand/nand_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 1ce55fd..0762a19 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -3354,6 +3354,8 @@ int nand_scan_tail(struct mtd_info *mtd) /* Large page NAND with SOFT_ECC should support subpage reads */ if ((chip-ecc.mode == NAND_ECC_SOFT) (chip-page_shift 9)) chip-options |= NAND_SUBPAGE_READ; + else + chip-options = ~NAND_SUBPAGE_READ; NACK; this breaks NAND_SUBPAGE_READ with hardware ECC for drivers that support it. There is something to argue in favour of that in general, but there are no such drivers in u-boot at the moment though (well at least not doing it on purpose). I don't mind moving it to gpmc, but for correctness, it doesn't break things at the moment... It doesn't matter if there are any such drivers at the moment. It's a bad change, and a gratuitous difference from Linux with which we share this common code. All the other cleanup required to change ECC modes is handled by the OMAP driver; why shouldn't this be as well? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
On 01/14/2014 09:21 PM, Scott Wood wrote: On Tue, 2014-01-14 at 21:11 +0100, Jeroen Hofstee wrote: Hello Scott, Pekon, On 01/13/2014 07:18 PM, Scott Wood wrote: The omap_gpmc allows switching ecc at runtime. Since the NAND_SUBPAGE_READ flag is only set, it is kept when switching to hw ecc, which is not correct. This leads to calling chip-ecc.read_subpage which is not a valid pointer. Therefore also clear the flag so reading in hw mode works again. Cc: Scott Wood scottw...@freescale.com Cc: Pekon Gupta pe...@ti.com Cc: Nikita Kiryanov nik...@compulab.co.il Signed-off-by: Jeroen Hofstee jer...@myspectrum.nl --- drivers/mtd/nand/nand_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 1ce55fd..0762a19 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -3354,6 +3354,8 @@ int nand_scan_tail(struct mtd_info *mtd) /* Large page NAND with SOFT_ECC should support subpage reads */ if ((chip-ecc.mode == NAND_ECC_SOFT) (chip-page_shift 9)) chip-options |= NAND_SUBPAGE_READ; + else + chip-options = ~NAND_SUBPAGE_READ; NACK; this breaks NAND_SUBPAGE_READ with hardware ECC for drivers that support it. There is something to argue in favour of that in general, but there are no such drivers in u-boot at the moment though (well at least not doing it on purpose). I don't mind moving it to gpmc, but for correctness, it doesn't break things at the moment... It doesn't matter if there are any such drivers at the moment. It's a bad change, and a gratuitous difference from Linux with which we share this common code. of course it does matter, you can chose not to support certain features, like subpage reads, interrupts, power management etc in a bootloader. As I said, moving it to gpmc is fine with me, so lets not making a long discussion of it. All the other cleanup required to change ECC modes is handled by the OMAP driver; why shouldn't this be as well? If there are more architectures, who think it is brilliant to switch ecc it will become a mesh if not coped with in general. And yes omap might be the exception for now, so lets put it there. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
On Tue, 2014-01-14 at 21:38 +0100, Jeroen Hofstee wrote: On 01/14/2014 09:21 PM, Scott Wood wrote: All the other cleanup required to change ECC modes is handled by the OMAP driver; why shouldn't this be as well? If there are more architectures, who think it is brilliant to switch ecc it will become a mesh if not coped with in general. And yes omap might be the exception for now, so lets put it there. Perhaps, but solving it in general should not happen via changes like this, but rather some sort of reset function that gives you a clean slate. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
On 01/14/2014 09:41 PM, Scott Wood wrote: On Tue, 2014-01-14 at 21:38 +0100, Jeroen Hofstee wrote: On 01/14/2014 09:21 PM, Scott Wood wrote: All the other cleanup required to change ECC modes is handled by the OMAP driver; why shouldn't this be as well? If there are more architectures, who think it is brilliant to switch ecc it will become a mesh if not coped with in general. And yes omap might be the exception for now, so lets put it there. Perhaps, but solving it in general should not happen via changes like this, but rather some sort of reset function that gives you a clean slate. I have no problem with a function call to nand_base resetting this flag, at least nand_base keeps in control of its own flag. I'll send you a patch for it. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mmc: dwmmc: mode change to 0644
On Tue, Jan 14, 2014 at 06:00:51PM +0900, Minkyu Kang wrote: Don't know why but, file permission was changed Signed-off-by: Minkyu Kang mk7.k...@samsung.com Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] board: nios2: Add CONFIG_CFI_FLASH_MTD guard to flash.h header include
On Fri, Dec 20, 2013 at 06:34:53PM -0300, Ezequiel Garcia wrote: Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] common, env: optimize boottime
On Thu, Dec 19, 2013 at 01:45:04PM +0100, Heiko Schocher wrote: when creating the hashtable, for each environmentvariable getenv(ENV_CALLBACK_VAR) and getenv(ENV_FLAGS_VAR) is called, which costs at this point a lot of time. So call this two getenv() calls only once. Boottime on the ids8313 board without this patch: 2013-12-19 13:38:22,894: NAND: 128 MiB 2013-12-19 13:38:27,659: In:serial (~4.8 sec) Bootime with this patch on the ids8313 board: 2013-12-19 13:40:25,332: NAND: 128 MiB 2013-12-19 13:40:25,546: In:serial (~0.2 sec) Signed-off-by: Heiko Schocher h...@denx.de Cc: Tom Rini tr...@ti.com Cc: Joe Hershberger joe.hershber...@ni.com Cc: Wolfgang Denk w...@denx.de Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-net.git master
On Tue, Jan 14, 2014 at 01:12:23PM -0600, Joe Hershberger wrote: The following changes since commit cddb6b8304bfbc34f43920051256de7fe6c4c0ab: Prepare v2014.01-rc3 (2014-01-13 14:36:17 -0500) are available in the git repository at: git://git.denx.de/u-boot-net.git master for you to fetch changes up to f66e3ded61aeafc67f3ebb6ab0302b455f102ce3: net: phy: atheros: Fix the masks for AR8031/8035 (2014-01-14 14:00:41 -0600) Fabio Estevam (1): net: phy: atheros: Fix the masks for AR8031/8035 drivers/net/phy/atheros.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] lzma: fix buffer bound check error
On Tue, Dec 31, 2013 at 02:57:01AM +0100, Antonios Vamporakis wrote: Variable uncompressedSize references the space available, while outSizeFull is the actual expected uncompressed size. Using the wrong value causes LzmaDecode to return SZ_ERROR_INPUT_EOF. Problem was introduced in commit afca294. While at it add additional debug message. Signed-off-by: Antonios Vamporakis a...@area128.com CC: Kees Cook keesc...@chromium.org CC: Simon Glass s...@chromium.org CC: Daniel Schwierzeck daniel.schwierz...@gmail.com CC: Luka Perkov l...@openwrt.org Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-arm/master
On Tue, Jan 14, 2014 at 02:04:08PM +0100, Albert ARIBAUD wrote: Hello Tom, The following changes since commit 4efd69250f6118ebd783867b3809001a1886ce9e: ARM: pxa: Fix OneNAND window access on VPAC270 (2014-01-13 12:39:10 +0100) are available in the git repository at: git://git.denx.de/u-boot-arm master for you to fetch changes up to 6ba2bc8fa9be4bd09ec43e39cb8e666480ef010c: arm: use canonical sub mnemonic (2014-01-14 12:38:47 +0100) Albert ARIBAUD (4): mini2440: remove board support mx1ads: remove board support arm: put .hash, .got.plt and .machine_param back in binaries Merge 'u-boot-imx/master' into 'u-boot-arm/master' Andreas Bießmann (1): arm: use canonical sub mnemonic Christian Gmeiner (1): imx6: make use of lldiv(..) Fabio Estevam (7): wandboard: Return from cpu_eth_init() directly titanium: Return from cpu_eth_init() directly mx6qarm2: Remove unneeded error message when cpu_eth_init() fails mx6qsabreauto: Return from cpu_eth_init() directly mx6sabresd: Return from cpu_eth_init() directly mx6slevk: Return from cpu_eth_init() directly mx6slevk: Include mx6_common.h John Weber (1): wandboard: Set default environment to use zImage Otavio Salvador (1): mx6sabresd: Add eMMC specific environment to allow U-Boot update arch/arm/config.mk| 2 +- arch/arm/cpu/armv7/exynos/config.mk | 7 + arch/arm/cpu/armv7/lowlevel_init.S| 2 +- arch/arm/cpu/armv7/mx6/clock.c| 3 +- arch/arm/cpu/u-boot.lds | 3 +- arch/arm/lib/crt0.S | 2 +- board/barco/titanium/titanium.c | 8 +- board/freescale/mx6qarm2/mx6qarm2.c | 7 +- board/freescale/mx6qsabreauto/mx6qsabreauto.c | 8 +- board/freescale/mx6sabresd/mx6sabresd.c | 8 +- board/freescale/mx6slevk/mx6slevk.c | 10 +- board/friendlyarm/mini2440/Makefile | 8 - board/friendlyarm/mini2440/mini2440.c | 118 -- board/friendlyarm/mini2440/mini2440.h | 144 board/mx1ads/Makefile | 16 -- board/mx1ads/lowlevel_init.S | 68 -- board/mx1ads/mx1ads.c | 178 --- board/mx1ads/syncflash.c | 307 -- board/wandboard/wandboard.c | 8 +- boards.cfg| 2 - doc/README.mini2440 | 28 --- doc/README.scrapyard | 6 +- include/configs/mx1ads.h | 163 -- include/configs/mx6sabre_common.h | 23 ++ include/configs/mx6sabresd.h | 2 + include/configs/mx6slevk.h| 1 + include/configs/wandboard.h | 20 +- spl/Makefile | 2 +- 28 files changed, 61 insertions(+), 1093 deletions(-) create mode 100644 arch/arm/cpu/armv7/exynos/config.mk delete mode 100644 board/friendlyarm/mini2440/Makefile delete mode 100644 board/friendlyarm/mini2440/mini2440.c delete mode 100644 board/friendlyarm/mini2440/mini2440.h delete mode 100644 board/mx1ads/Makefile delete mode 100644 board/mx1ads/lowlevel_init.S delete mode 100644 board/mx1ads/mx1ads.c delete mode 100644 board/mx1ads/syncflash.c delete mode 100644 doc/README.mini2440 delete mode 100644 include/configs/mx1ads.h Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] command.c: Fix auto-completion for the full commands list case
On Fri, Dec 27, 2013 at 10:05:14AM -0600, Andrew Gabbasov wrote: Compiling of full list of commands does not advance the counter, so it always results in an empty list. This seems to be (inadvertently?) introduced by commit 6c7c946cadfafdea80eb930e3181085b907a0362. Signed-off-by: Andrew Gabbasov andrew_gabba...@mentor.com Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot, v2] bootm: Reinstate special case for standalone images
On Thu, Dec 26, 2013 at 04:26:24PM -0700, Simon Glass wrote: For standalone images, bootm had a special case where the OS boot function was NULL but did actually exist. It was just called manually. This was removed by commit 35fc84fa which checks for the non-existence of this function before the special case is examined. There is no obvious reason why standalone is handled with a special case. Adjust the code so that standalone has a normal OS boot function. We still need a special case for when the function returns, but at least we can avoid the main problem. This is intended to fix the reported: ERROR: booting os 'U-Boot' (17) is not supported but needs testing. Signed-off-by: Simon Glass s...@chromium.org Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot, v2] fuelgauge: max17042: fix i2c read issue which causes infinity loop.
On Mon, Dec 30, 2013 at 11:24:32AM +0100, Przemyslaw Marczak wrote: Issues: - reading i2c data by passing u16 pointer causes errors in read data. - max17042 status register fields have not only Power On Reset meaning so using proper mask is required. Changes: - read i2c data to type u32 instead of u16 - avoids buffer overflow - compare FG status register using mask not just one bit value - add checking return value to functions fg read/write - add model lock and model check count - add debug msg Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] common/image.c: move VxWorks header string out of CONFIG_CMD_ELF
On Fri, Dec 27, 2013 at 04:01:50PM +0800, miao@windriver.com wrote: Otherwise, when booting VxWorks kernel, the incorrect message will be seen: ARM Unknown OS Kernel Image (uncompressed) Signed-off-by: Miao Yan miao@windriver.com Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
On Tue, 2014-01-14 at 21:56 +0100, Jeroen Hofstee wrote: On 01/14/2014 09:41 PM, Scott Wood wrote: On Tue, 2014-01-14 at 21:38 +0100, Jeroen Hofstee wrote: On 01/14/2014 09:21 PM, Scott Wood wrote: All the other cleanup required to change ECC modes is handled by the OMAP driver; why shouldn't this be as well? If there are more architectures, who think it is brilliant to switch ecc it will become a mesh if not coped with in general. And yes omap might be the exception for now, so lets put it there. Perhaps, but solving it in general should not happen via changes like this, but rather some sort of reset function that gives you a clean slate. I have no problem with a function call to nand_base resetting this flag, at least nand_base keeps in control of its own flag. I'll send you a patch for it. I meant a function that resets everything that might have been set automatically by the previous nand_scan_tail(), not just one flag. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
On Tue, 2014-01-14 at 22:15 +0100, Jeroen Hofstee wrote: On 01/14/2014 10:05 PM, Scott Wood wrote: I meant a function that resets everything that might have been set automatically by the previous nand_scan_tail(), not just one flag. Well I am talking about a single bit bricking my board. I thought you already said you were OK handling that in the OMAP driver, along with all the other stuff it does to fix things up? I was responding to your comment about eventually having proper support for ECC changing in common code, not suggesting this as a short term fix. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] nand: fix reading after switching ecc
On 01/14/2014 10:05 PM, Scott Wood wrote: I meant a function that resets everything that might have been set automatically by the previous nand_scan_tail(), not just one flag. Well I am talking about a single bit bricking my board. Not causing a problem otherwise, besides you falling about it. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] mxc_i2c driver
Troy, I am trying to use mxc_i2c driver with multiple buses. I didn't figure out how the bases are set. Can you shed some light on this? Thanks, York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mxc_i2c driver
On 01/14/2014 03:25 PM, Troy Kisky wrote: On 1/14/2014 2:26 PM, York Sun wrote: Troy, I am trying to use mxc_i2c driver with multiple buses. I didn't figure out how the bases are set. Can you shed some light on this? Thanks, York see board/boundary/nitrogen6x/nitrogen6x.c It calls setup_i2c(0, CONFIG_SYS_I2C_SPEED, 0x7f, i2c_pad_info0); setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, i2c_pad_info1); setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, i2c_pad_info2); which is in arch/arm/imx-common/i2c-mxv7.c This file has an array of base addresses static void * const i2c_bases[] = { (void *)I2C1_BASE_ADDR, (void *)I2C2_BASE_ADDR, #ifdef I2C3_BASE_ADDR (void *)I2C3_BASE_ADDR, #endif }; Great! Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers
Hi, Jagan. 2014/1/14 Jagan Teki jagannadh.t...@gmail.com: Hi Nobuhiro, On Tue, Jan 14, 2014 at 5:42 AM, Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com wrote: Hi, 2014/1/14 Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com: Hi, Jagan. 2014/1/9 Jagan Teki jagannadh.t...@gmail.com: Hi Nobuhiro, On Thu, Jan 9, 2014 at 9:49 AM, Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com wrote: Hi, This macro was changed by following patch. http://patchwork.ozlabs.org/patch/307934/ OK. I will pick this once Albert pop your PR. Or there is also a path you take in this patch. This patch is set. If you are not taken at the same time, this will not be build. OK. I will mark the reviewed-by tag on this patch so-that we can send PR all together to Albert. is it fine for you? Yes, it is fine to me. Thanks! Best regards, Nobuhiro Albert, do you think about this? Best regards, Nobuhiro Any more spi patches? I dont have SPI patches. Thank you. Best regards, Nobuhiro I should have been CC to you this. Best regards, Nobuhiro 2014/1/9 Jagan Teki jagannadh.t...@gmail.com: Hi Nobuhiro Iwamatsu, On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com wrote: Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com --- drivers/spi/sh_qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c index edeb42d..77ede6b 100644 --- a/drivers/spi/sh_qspi.c +++ b/drivers/spi/sh_qspi.c @@ -10,6 +10,7 @@ #include common.h #include malloc.h #include spi.h +#include asm/arch/rmobile.h #include asm/io.h /* SH QSPI register bit masks REG_BIT */ @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, return NULL; } - ss-regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE; + ss-regs = (struct sh_qspi_regs *)SH_QSPI_BASE; I really don't understand where you define this macro. -- Thanks, Jagan. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot -- Nobuhiro Iwamatsu ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mxc_i2c driver
On 1/14/2014 2:26 PM, York Sun wrote: Troy, I am trying to use mxc_i2c driver with multiple buses. I didn't figure out how the bases are set. Can you shed some light on this? Thanks, York see board/boundary/nitrogen6x/nitrogen6x.c It calls setup_i2c(0, CONFIG_SYS_I2C_SPEED, 0x7f, i2c_pad_info0); setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, i2c_pad_info1); setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, i2c_pad_info2); which is in arch/arm/imx-common/i2c-mxv7.c This file has an array of base addresses static void * const i2c_bases[] = { (void *)I2C1_BASE_ADDR, (void *)I2C2_BASE_ADDR, #ifdef I2C3_BASE_ADDR (void *)I2C3_BASE_ADDR, #endif }; ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get u-boot code with arm64: core support
Hi, Scott: You need to use u-boot.elf, not the unrelocated u-boot. Thanks a lot! After changing to u-boot.elf, it could be run in FVP model. Best wishes, ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc: mpc512x: remove redundant CONFIG_MPC512X definition
We do not have to define CONFIG_MPC512X in board config headers because it is defined in arch/powerpc/cpu/mpc512x/config.mk. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- include/configs/ac14xx.h | 1 - include/configs/aria.h | 1 - include/configs/mecp5123.h | 1 - include/configs/mpc5121ads.h | 1 - include/configs/pdm360ng.h | 1 - 5 files changed, 5 deletions(-) diff --git a/include/configs/ac14xx.h b/include/configs/ac14xx.h index d6cef88..aa584b7 100644 --- a/include/configs/ac14xx.h +++ b/include/configs/ac14xx.h @@ -27,7 +27,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 Family */ -#define CONFIG_MPC512X 1 /* MPC512X family */ #define CONFIG_SYS_TEXT_BASE 0xFFF0 diff --git a/include/configs/aria.h b/include/configs/aria.h index b8d955a..c36cf33 100644 --- a/include/configs/aria.h +++ b/include/configs/aria.h @@ -31,7 +31,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 Family */ -#define CONFIG_MPC512X 1 /* MPC512X family */ #define CONFIG_FSL_DIU_FB 1 /* FSL DIU */ #defineCONFIG_SYS_TEXT_BASE0xFFF0 diff --git a/include/configs/mecp5123.h b/include/configs/mecp5123.h index d415ecd..6c19817 100644 --- a/include/configs/mecp5123.h +++ b/include/configs/mecp5123.h @@ -29,7 +29,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 Family */ -#define CONFIG_MPC512X 1 /* MPC512X family */ #defineCONFIG_SYS_TEXT_BASE0xFFF0 diff --git a/include/configs/mpc5121ads.h b/include/configs/mpc5121ads.h index 38337b4..7de245b 100644 --- a/include/configs/mpc5121ads.h +++ b/include/configs/mpc5121ads.h @@ -29,7 +29,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 Family */ -#define CONFIG_MPC512X 1 /* MPC512X family */ #defineCONFIG_SYS_TEXT_BASE0xFFF0 diff --git a/include/configs/pdm360ng.h b/include/configs/pdm360ng.h index 2a54e5c..553eb8f 100644 --- a/include/configs/pdm360ng.h +++ b/include/configs/pdm360ng.h @@ -30,7 +30,6 @@ * High Level Configuration Options */ #define CONFIG_E3001 /* E300 Family */ -#define CONFIG_MPC512X 1 /* MPC512X family */ #define CONFIG_FSL_DIU_FB 1 /* FSL DIU */ #defineCONFIG_SYS_TEXT_BASE0xF000 -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc: mpc5xx: remove redundant CONFIG_5xx definition
We do not have to define CONFIG_5xx in a source file because it is defined in arch/powerpc/cpu/mpc5xx/config.mk. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/powerpc/cpu/mpc5xx/start.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/cpu/mpc5xx/start.S b/arch/powerpc/cpu/mpc5xx/start.S index 22fb274..6b196de 100644 --- a/arch/powerpc/cpu/mpc5xx/start.S +++ b/arch/powerpc/cpu/mpc5xx/start.S @@ -19,8 +19,6 @@ #include mpc5xx.h #include version.h -#define CONFIG_5xx 1 /* needed for Linux kernel header files */ - #include ppc_asm.tmpl #include ppc_defs.h -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc: mpc824x: remove redundant CONFIG_MPC824X definition
We do not have to define CONFIG_MPC824X in board config headers because it is defined in arch/powerpc/cpu/mpc824x/config.mk. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- include/configs/A3000.h | 1 - include/configs/CPC45.h | 1 - include/configs/CU824.h | 1 - include/configs/HIDDEN_DRAGON.h | 1 - include/configs/MOUSSE.h| 1 - include/configs/MUSENKI.h | 1 - include/configs/MVBLUE.h| 1 - include/configs/Sandpoint8240.h | 1 - include/configs/Sandpoint8245.h | 1 - include/configs/debris.h| 1 - include/configs/eXalion.h | 1 - include/configs/kvme080.h | 1 - include/configs/utx8245.h | 1 - 13 files changed, 13 deletions(-) diff --git a/include/configs/A3000.h b/include/configs/A3000.h index 8f3a672..35e3e6f 100644 --- a/include/configs/A3000.h +++ b/include/configs/A3000.h @@ -25,7 +25,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_A3000 1 diff --git a/include/configs/CPC45.h b/include/configs/CPC45.h index 764ca22..a75c52f 100644 --- a/include/configs/CPC45.h +++ b/include/configs/CPC45.h @@ -25,7 +25,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_CPC45 1 diff --git a/include/configs/CU824.h b/include/configs/CU824.h index 6864027..dc98a56 100644 --- a/include/configs/CU824.h +++ b/include/configs/CU824.h @@ -25,7 +25,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8240 1 #define CONFIG_CU824 1 diff --git a/include/configs/HIDDEN_DRAGON.h b/include/configs/HIDDEN_DRAGON.h index 62a7f93..e0a233b 100644 --- a/include/configs/HIDDEN_DRAGON.h +++ b/include/configs/HIDDEN_DRAGON.h @@ -22,7 +22,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_HIDDEN_DRAGON 1 diff --git a/include/configs/MOUSSE.h b/include/configs/MOUSSE.h index 1bf1bf8..e84d12f 100644 --- a/include/configs/MOUSSE.h +++ b/include/configs/MOUSSE.h @@ -29,7 +29,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8240 1 #define CONFIG_MOUSSE 1 diff --git a/include/configs/MUSENKI.h b/include/configs/MUSENKI.h index b24f6ee..c5c9290 100644 --- a/include/configs/MUSENKI.h +++ b/include/configs/MUSENKI.h @@ -25,7 +25,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_MUSENKI 1 diff --git a/include/configs/MVBLUE.h b/include/configs/MVBLUE.h index 4100b85..aa2d9c0 100644 --- a/include/configs/MVBLUE.h +++ b/include/configs/MVBLUE.h @@ -40,7 +40,6 @@ #define ERR_LED(code) #endif -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_MVBLUE 1 diff --git a/include/configs/Sandpoint8240.h b/include/configs/Sandpoint8240.h index 8a689b3..2c0cb89 100644 --- a/include/configs/Sandpoint8240.h +++ b/include/configs/Sandpoint8240.h @@ -19,7 +19,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8240 1 #define CONFIG_SANDPOINT 1 diff --git a/include/configs/Sandpoint8245.h b/include/configs/Sandpoint8245.h index a17f5ad..2664d5b 100644 --- a/include/configs/Sandpoint8245.h +++ b/include/configs/Sandpoint8245.h @@ -19,7 +19,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_SANDPOINT 1 diff --git a/include/configs/debris.h b/include/configs/debris.h index 621f895..4631b86 100644 --- a/include/configs/debris.h +++ b/include/configs/debris.h @@ -94,7 +94,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_DEBRIS 1 diff --git a/include/configs/eXalion.h b/include/configs/eXalion.h index ca9792c..940be1f 100644 --- a/include/configs/eXalion.h +++ b/include/configs/eXalion.h @@ -19,7 +19,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 /* #define CONFIG_MPC8240 1 */ #define CONFIG_MPC8245 1 #define CONFIG_EXALION 1 diff --git a/include/configs/kvme080.h b/include/configs/kvme080.h index 251327a..c352a1c 100644 --- a/include/configs/kvme080.h +++ b/include/configs/kvme080.h @@ -8,7 +8,6 @@ #ifndef __CONFIG_H #define __CONFIG_H -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_KVME080 1 diff --git a/include/configs/utx8245.h b/include/configs/utx8245.h index 8e6e246..5be62ec 100644 --- a/include/configs/utx8245.h +++ b/include/configs/utx8245.h @@ -30,7 +30,6 @@ * (easy to change) */ -#define CONFIG_MPC824X 1 #define CONFIG_MPC8245 1 #define CONFIG_UTX8245 1 -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de
[U-Boot] [PATCH] powerpc: mpc86xx: move CONFIG_MPC86xx definition to CPU config.mk
Define CONFIG_MPC86xx in arch/powerpc/cpu/mpc86xx/config.mk because all target boards with mpc86xx cpu define it. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/powerpc/cpu/mpc86xx/config.mk | 2 +- include/configs/MPC8610HPCD.h | 1 - include/configs/MPC8641HPCN.h | 1 - include/configs/sbc8641d.h | 1 - include/configs/xpedite517x.h | 1 - 5 files changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/powerpc/cpu/mpc86xx/config.mk b/arch/powerpc/cpu/mpc86xx/config.mk index 69a0b96..4c7235f 100644 --- a/arch/powerpc/cpu/mpc86xx/config.mk +++ b/arch/powerpc/cpu/mpc86xx/config.mk @@ -5,4 +5,4 @@ # SPDX-License-Identifier: GPL-2.0+ # -PLATFORM_CPPFLAGS += -mstring -maltivec -mabi=altivec -msoft-float +PLATFORM_CPPFLAGS += -DCONFIG_MPC86xx -mstring -maltivec -mabi=altivec -msoft-float diff --git a/include/configs/MPC8610HPCD.h b/include/configs/MPC8610HPCD.h index f930fcd..e6d570a 100644 --- a/include/configs/MPC8610HPCD.h +++ b/include/configs/MPC8610HPCD.h @@ -14,7 +14,6 @@ #define __CONFIG_H /* High Level Configuration Options */ -#define CONFIG_MPC86xx 1 /* MPC86xx */ #define CONFIG_MPC8610 1 /* MPC8610 specific */ #define CONFIG_MPC8610HPCD 1 /* MPC8610HPCD board specific */ #define CONFIG_LINUX_RESET_VEC 0x100 /* Reset vector used by Linux */ diff --git a/include/configs/MPC8641HPCN.h b/include/configs/MPC8641HPCN.h index 65d61c2..7443ace 100644 --- a/include/configs/MPC8641HPCN.h +++ b/include/configs/MPC8641HPCN.h @@ -17,7 +17,6 @@ #define __CONFIG_H /* High Level Configuration Options */ -#define CONFIG_MPC86xx 1 /* MPC86xx */ #define CONFIG_MPC8641 1 /* MPC8641 specific */ #define CONFIG_MPC8641HPCN 1 /* MPC8641HPCN board specific */ #define CONFIG_MP 1 /* support multiple processors */ diff --git a/include/configs/sbc8641d.h b/include/configs/sbc8641d.h index 78f8219..8eb7276 100644 --- a/include/configs/sbc8641d.h +++ b/include/configs/sbc8641d.h @@ -21,7 +21,6 @@ #define __CONFIG_H /* High Level Configuration Options */ -#define CONFIG_MPC86xx 1 /* MPC86xx */ #define CONFIG_MPC8641 1 /* MPC8641 specific */ #define CONFIG_SBC8641D1 /* SBC8641D board specific */ #define CONFIG_MP 1 /* support multiple processors */ diff --git a/include/configs/xpedite517x.h b/include/configs/xpedite517x.h index 88d7f88..cbf4b8e 100644 --- a/include/configs/xpedite517x.h +++ b/include/configs/xpedite517x.h @@ -14,7 +14,6 @@ /* * High Level Configuration Options */ -#define CONFIG_MPC86xx 1 /* MPC86xx */ #define CONFIG_MPC8641 1 /* MPC8641 specific */ #define CONFIG_XPEDITE5140 1 /* MPC8641HPCN board specific */ #define CONFIG_SYS_BOARD_NAME XPedite5170 -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] powerpc: mpc85xx: move CONFIG_MPC85xx definition to CPU config.mk
Define CONFIG_MPC85xx in arch/powerpc/cpu/mpc85xx/config.mk because all target boards with mpc85xx cpu define it. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/powerpc/cpu/mpc85xx/config.mk | 2 +- include/configs/B4860QDS.h | 1 - include/configs/BSC9131RDB.h| 1 - include/configs/BSC9132QDS.h| 1 - include/configs/C29XPCIE.h | 1 - include/configs/HWW1U1A.h | 1 - include/configs/MPC8536DS.h | 1 - include/configs/MPC8540ADS.h| 1 - include/configs/MPC8541CDS.h| 1 - include/configs/MPC8544DS.h | 1 - include/configs/MPC8548CDS.h| 1 - include/configs/MPC8555CDS.h| 1 - include/configs/MPC8560ADS.h| 1 - include/configs/MPC8568MDS.h| 1 - include/configs/MPC8569MDS.h| 1 - include/configs/MPC8572DS.h | 1 - include/configs/P1010RDB.h | 1 - include/configs/P1022DS.h | 1 - include/configs/P1023RDB.h | 1 - include/configs/P1023RDS.h | 1 - include/configs/P1_P2_RDB.h | 1 - include/configs/P2020COME.h | 1 - include/configs/P2020DS.h | 1 - include/configs/P2041RDB.h | 1 - include/configs/T1040QDS.h | 1 - include/configs/T1040RDB.h | 1 - include/configs/T1042RDB_PI.h | 1 - include/configs/T2080QDS.h | 1 - include/configs/controlcenterd.h| 1 - include/configs/corenet_ds.h| 1 - include/configs/km/kmp204x-common.h | 1 - include/configs/p1_p2_rdb_pc.h | 1 - include/configs/p1_twr.h| 1 - include/configs/sbc8548.h | 1 - include/configs/socrates.h | 1 - include/configs/stxgp3.h| 1 - include/configs/stxssa.h| 1 - include/configs/t4qds.h | 1 - include/configs/xpedite520x.h | 1 - include/configs/xpedite537x.h | 1 - include/configs/xpedite550x.h | 1 - 41 files changed, 1 insertion(+), 41 deletions(-) diff --git a/arch/powerpc/cpu/mpc85xx/config.mk b/arch/powerpc/cpu/mpc85xx/config.mk index 72c964c..1470f95 100644 --- a/arch/powerpc/cpu/mpc85xx/config.mk +++ b/arch/powerpc/cpu/mpc85xx/config.mk @@ -5,7 +5,7 @@ # SPDX-License-Identifier: GPL-2.0+ # -PLATFORM_CPPFLAGS += -Wa,-me500 -msoft-float -mno-string +PLATFORM_CPPFLAGS += -DCONFIG_MPC85xx -Wa,-me500 -msoft-float -mno-string # -mspe=yes is needed to have -mno-spe accepted by a buggy GCC; # see [PATCH,rs6000] make -mno-spe work as expected on diff --git a/include/configs/B4860QDS.h b/include/configs/B4860QDS.h index c182158..c1ab4ed 100644 --- a/include/configs/B4860QDS.h +++ b/include/configs/B4860QDS.h @@ -34,7 +34,6 @@ #define CONFIG_E500/* BOOKE e500 family */ #define CONFIG_E500MC /* BOOKE e500mc family */ #define CONFIG_SYS_BOOK3E_HV /* Category E.HV supported */ -#define CONFIG_MPC85xx /* MPC85xx/PQ3 platform */ #define CONFIG_MP /* support multiple processors */ #ifndef CONFIG_SYS_TEXT_BASE diff --git a/include/configs/BSC9131RDB.h b/include/configs/BSC9131RDB.h index 584aba8..f9317c9 100644 --- a/include/configs/BSC9131RDB.h +++ b/include/configs/BSC9131RDB.h @@ -55,7 +55,6 @@ /* High Level Configuration Options */ #define CONFIG_BOOKE /* BOOKE */ #define CONFIG_E500/* BOOKE e500 family */ -#define CONFIG_MPC85xx /* MPC8540/60/55/41/48/P1020/P2020/P1010,etc*/ #define CONFIG_FSL_IFC /* Enable IFC Support */ #define CONFIG_FSL_LAW /* Use common FSL init code */ diff --git a/include/configs/BSC9132QDS.h b/include/configs/BSC9132QDS.h index 6170cbc..ea07af3 100644 --- a/include/configs/BSC9132QDS.h +++ b/include/configs/BSC9132QDS.h @@ -71,7 +71,6 @@ /* High Level Configuration Options */ #define CONFIG_BOOKE /* BOOKE */ #define CONFIG_E500/* BOOKE e500 family */ -#define CONFIG_MPC85xx #define CONFIG_FSL_IFC /* Enable IFC Support */ #define CONFIG_SYS_HAS_SERDES /* common SERDES init code */ diff --git a/include/configs/C29XPCIE.h b/include/configs/C29XPCIE.h index 1cfb2c2..5ca6e9a 100644 --- a/include/configs/C29XPCIE.h +++ b/include/configs/C29XPCIE.h @@ -38,7 +38,6 @@ /* High Level Configuration Options */ #define CONFIG_BOOKE /* BOOKE */ #define CONFIG_E500/* BOOKE e500 family */ -#define CONFIG_MPC85xx #define CONFIG_FSL_IFC /* Enable IFC Support */ #define CONFIG_SYS_HAS_SERDES /* common SERDES init code */ diff --git a/include/configs/HWW1U1A.h b/include/configs/HWW1U1A.h index bbfee7d..6a3a11c 100644 --- a/include/configs/HWW1U1A.h +++ b/include/configs/HWW1U1A.h @@ -13,7 +13,6 @@ /* High-level system configuration options */ #define CONFIG_BOOKE /* Power/PowerPC Book-E */ #define CONFIG_E500/* e500 (Power ISA v2.03
Re: [U-Boot] [ANN] v2014.01-rc3
On 14/01/14 22:12, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/13/2014 05:31 PM, Lukasz Majewski wrote: Hi Tom Hey all, I've put v2014.01-rc3 out and we should have a tarball soon. Here's where we're at, I feel. We got some big changes in, which had been due for a while, on Friday. I don't think it's a good idea to release today, so I'm going to push things out a week. Here's what I expect for the release, change-wise: - Any regressions people report - Either removal of mini2440 and mx1ads or CONFIG_SYS_HZ fixes for them (Albert is working a removal patch now, or soon). - Fixes for i.mx platforms using hardfp toolchains (which means do_div being called instead). The patch exists, lets get this through please. We have some fixes for Samsung's Trats and Trats2. Some of them had already been sent do mailing list (as explicit fixes for v2014.01) I've also prepared some tweaks for envs on those boards. Shall I sent them directly to you or ask Minkyu to pull them to u-boot-samsung? Well, Minkyu, can you get a pull request together for Albert today or tomorrow at the latest? Thanks! It seems there are three patches. http://patchwork.ozlabs.org/patch/310477/ http://patchwork.ozlabs.org/patch/310478/ http://patchwork.ozlabs.org/patch/310479/ for reducing PR steps, it's better to apply those patches to u-boot-arm or u-boot directly. How you think? Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] A list of dead email addresses of board maintainers
Hello. When I CC board maintainers, it sometimes results in bounce mails. How should we modify boards.cfg? Delete the email? Or just mark as dead address ? I noticed at least the following email addresses are dead: y...@arabellasw.com travis.saw...@sandburst.com yusdi_sant...@adaptec.com d...@cray.com dog...@etinsys.com e...@nbase.co.il avoront...@ru.mvista.com u-boot-de...@blackfin.uclinux.org bluetech...@blackfin.uclinux.org The folloings are the snippet of returned mail notifier. - The following addresses had permanent fatal errors - y...@arabellasw.com - Transcript of session follows - y...@arabellasw.com... Deferred: Name server: arabellasw.com.: host name lookup failure Message could not be delivered for 3 days - The following addresses had permanent fatal errors - travis.saw...@sandburst.com (reason: 550 We don't handle mail for sandburst.com) - The following addresses had permanent fatal errors - yusdi_sant...@adaptec.com (reason: 550 5.1.1 yusdi_sant...@adaptec.com: Recipient address rejected: User unknown in virtual alias table) d...@cray.com (reason: 550 5.1.1 d...@cray.com... User unknown) dog...@etinsys.com (reason: 550 Host unknown) - The following addresses had permanent fatal errors - e...@nbase.co.il (reason: 550 Unknown user) avoront...@ru.mvista.com (reason: 550 5.2.1 The email account that you tried to reach is disabled. s7si55219360pae.98 - gsmtp) - The following addresses had permanent fatal errors - u-boot-de...@blackfin.uclinux.org bluetech...@blackfin.uclinux.org - Transcript of session follows - bluetech...@blackfin.uclinux.org,u-boot-de...@blackfin.uclinux.org... Deferred: Connection timed out with blackfin.uclinux.org. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] ARM: merge commonly-defined PLATFORM_RELFLAGS
Before this commit, all arch/arm/cpu/${CPU}/config.mk except ARMv8 had the same option: $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,)) This commit moves it into arch/arm/config.mk. If the compiler does not support the option, it is ignored by $(call cc-option,...). So this commit gives no harm to ARMv8. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- FYI: gcc 3.4.6 Manaul says -mno-alignment-traps Generate code that assumes that the MMU will not trap unaligned accesses. This produces better code when the target instruction set does not have half-word memory operations (i.e. implementations prior to ARMv4). Note that you cannot use this option to access unaligned word objects, since the processor will only fetch one 32-bit aligned object from memory. The default setting is -malignment-traps, since this produces code that will also run on processors implementing ARM architecture version 6 or later. This option is deprecated and will be removed in the next release of GCC. Changes in v2: - Rebase on the current u-boot/master arch/arm/config.mk | 3 ++- arch/arm/cpu/arm1136/config.mk | 7 --- arch/arm/cpu/arm1176/config.mk | 8 arch/arm/cpu/arm720t/config.mk | 8 arch/arm/cpu/arm920t/config.mk | 7 --- arch/arm/cpu/arm926ejs/config.mk | 7 --- arch/arm/cpu/arm946es/config.mk | 7 --- arch/arm/cpu/arm_intcm/config.mk | 7 --- arch/arm/cpu/armv7/config.mk | 8 arch/arm/cpu/ixp/config.mk | 8 arch/arm/cpu/pxa/config.mk | 7 --- arch/arm/cpu/sa1100/config.mk| 7 --- 12 files changed, 2 insertions(+), 82 deletions(-) diff --git a/arch/arm/config.mk b/arch/arm/config.mk index cfa4209..98c1253 100644 --- a/arch/arm/config.mk +++ b/arch/arm/config.mk @@ -18,7 +18,8 @@ endif LDFLAGS_FINAL += --gc-sections PLATFORM_RELFLAGS += -ffunction-sections -fdata-sections \ -fno-common -ffixed-r9 -PLATFORM_RELFLAGS += $(call cc-option, -msoft-float) +PLATFORM_RELFLAGS += $(call cc-option, -msoft-float) \ + $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,)) # Support generic board on ARM __HAVE_ARCH_GENERIC_BOARD := y diff --git a/arch/arm/cpu/arm1136/config.mk b/arch/arm/cpu/arm1136/config.mk index b4d396d..f74228c 100644 --- a/arch/arm/cpu/arm1136/config.mk +++ b/arch/arm/cpu/arm1136/config.mk @@ -7,13 +7,6 @@ # Make ARMv5 to allow more compilers to work, even though its v6. PLATFORM_CPPFLAGS += -march=armv5 -# = -# -# Supply options according to compiler version -# -# = -PF_RELFLAGS_SLB_AT := $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,)) -PLATFORM_RELFLAGS += $(PF_RELFLAGS_SLB_AT) ifneq ($(CONFIG_IMX_CONFIG),) ifdef CONFIG_SPL diff --git a/arch/arm/cpu/arm1176/config.mk b/arch/arm/cpu/arm1176/config.mk index f4631cb..5dc2ebb 100644 --- a/arch/arm/cpu/arm1176/config.mk +++ b/arch/arm/cpu/arm1176/config.mk @@ -7,11 +7,3 @@ # Make ARMv5 to allow more compilers to work, even though its v6. PLATFORM_CPPFLAGS += -march=armv5t -# = -# -# Supply options according to compiler version -# -# = -PF_RELFLAGS_SLB_AT := $(call cc-option,-mshort-load-bytes,\ - $(call cc-option,-malignment-traps,)) -PLATFORM_RELFLAGS += $(PF_RELFLAGS_SLB_AT) diff --git a/arch/arm/cpu/arm720t/config.mk b/arch/arm/cpu/arm720t/config.mk index 2581f0a..772fb41 100644 --- a/arch/arm/cpu/arm720t/config.mk +++ b/arch/arm/cpu/arm720t/config.mk @@ -7,11 +7,3 @@ # PLATFORM_CPPFLAGS += -march=armv4 -mtune=arm7tdmi -# = -# -# Supply options according to compiler version -# -# = -PF_RELFLAGS_SLB_AT := $(call cc-option,-mshort-load-bytes,\ - $(call cc-option,-malignment-traps,)) -PLATFORM_RELFLAGS += $(PF_RELFLAGS_SLB_AT) diff --git a/arch/arm/cpu/arm920t/config.mk b/arch/arm/cpu/arm920t/config.mk index 67537dc..799afff 100644 --- a/arch/arm/cpu/arm920t/config.mk +++ b/arch/arm/cpu/arm920t/config.mk @@ -6,10 +6,3 @@ # PLATFORM_CPPFLAGS += -march=armv4 -# = -# -# Supply options according to compiler version -# -# = -PF_RELFLAGS_SLB_AT := $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,)) -PLATFORM_RELFLAGS += $(PF_RELFLAGS_SLB_AT) diff --git a/arch/arm/cpu/arm926ejs/config.mk b/arch/arm/cpu/arm926ejs/config.mk index 12b0d09..4d9895f 100644 --- a/arch/arm/cpu/arm926ejs/config.mk +++
Re: [U-Boot] [PATCH] ARM: merge commonly-defined PLATFORM_RELFLAGS
Hello Albert, All arch/arm/cpu/${CPU}/config.mk had the same PLATFORM_RELFLAGS definitions. This commit merges them into arch/arm/config.mk. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- This does not apply cleanly on ARM tree. Can you please rebase and submit v2? I posted version2. http://patchwork.ozlabs.org/patch/310923/ Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 32/37] Makefile: refactor tools-all targets
Hello Gerhard. There is another issue for those who do make HOSTCC=${CROSS_COMPILE}gcc env (needs a HOSTSTRIP spec as well in recent mainline sources) to get an fw_printenv(1) binary that runs on the target (in contrast to the build machine). Some yocto recipes do this, to not re-invent how to build this tool or how to read and write the environment image. With your changes, the 'env' make target is gone, instead there is a 'tools-all' target but it has a wider scope, includes the BMP manipulation/conversion stuff and uses HOSTCC to build a bmp_logo(1) tool, which breaks in the mentioned use case (cross compiled bmp_logo(1) executable, empty bmp_logo.h header, aborted build sequence). I did not know how env target have been used. Your comments are highly appreciated! I will revive env target at v5. But whan I cannot understand is why HOSTCC must be tweaked. (I am also asking this question in Compiling fw_printenv tool thread) If fw_printenv must be always compiled with cross-tools, I'd like to suggest to use $(CC) instead of $(HOSTCC) in tools/env/Makefile. While testing your series I noticed a probably missing dependency: Running something different from 'make all' (or make without a target spec) after 'make board_config' won't work since the fixdeps(1) tool is missing. It's a byproduct of 'make all', afterwards other targets can get built separately. Is there a preparation step that one needs to take if not calling 'make all' immediately after configuration? Good catch! I will fix this problem at v5. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot