Re: [U-Boot] [PATCH 2/7] arm: socfpga: Convert FPGA configuration to Kconfig method.

[Chee, Tien Fong]

On Isn, 2017-05-08 at 11:57 +0200, Marek Vasut wrote:
> On 05/08/2017 05:02 AM, Chee, Tien Fong wrote:
> > 
> > On Jum, 2017-05-05 at 13:11 +0200, Marek Vasut wrote:
> > > 
> > > On 05/05/2017 12:26 PM, tien.fong.c...@intel.com wrote:
> > > > 
> > > > 
> > > > From: Tien Fong Chee 
> > > > 
> > > > Convert Macro #define configuration to Kconfig method. All FPGA
> > > > devices
> > > > enable configuration based on CONFIG_FPGA_ALTERA.
> > > > 
> > > > Signed-off-by: Tien Fong Chee 
> > > > ---
> > > >  drivers/fpga/Kconfig |5 -
> > > >  drivers/fpga/Makefile|3 +--
> > > >  include/altera.h |2 +-
> > > >  include/configs/socfpga_common.h |3 ---
> > > >  4 files changed, 6 insertions(+), 7 deletions(-)
> > > > 
> > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > > index a760944..fc4ea0d 100644
> > > > --- a/drivers/fpga/Kconfig
> > > > +++ b/drivers/fpga/Kconfig
> > > > @@ -2,12 +2,15 @@ menu "FPGA support"
> > > >  
> > > >  config FPGA
> > > >     bool
> > > > +   help
> > > > +     Enable FPGA driver build.
> > > Separate patch please , also this is not driver, but framework .
> > > There's
> > > not just drivers here IMO.
> > > 
> > ohh...okay, so you prefer i revert the changes, or better
> > explanation
> > in separate patch? if for later,what is your suggestion? Thanks.
> Turning this whole FPGA subsystem into Kconfig should be a separat
> patch. There's a script for that too and you need to convert and
> build
> test all the boards which define CONFIG_FPGA .
> 
Okay, this patch is specific for turning whole FPGA sybsytem into
Kconfig. I will use moveconfig.py for this. thanks.
> > 
> > > 
> > > > 
> > > >  config FPGA_ALTERA
> > > >     bool "Enable Altera FPGA drivers"
> > > > +   default y if TARGET_SOCFPGA_GEN5 && CMD_FPGA
> > > Should be selected by arch code, drop this.
> > > 
> > just for clarity, are you means defconfig == "selected by arch
> > code"?
> I mean arch/arm/mach-socfpga/Kconfig
> 
With moveconfig.py, i think this change is not required.
> > 
> > > 
> > > > 
> > > > 
> > > >     select FPGA
> > > >     help
> > > > -     Say Y here to enable the Altera FPGA driver
> > > > +     Default Y here to enable the Altera FPGA driver
> > > Keep as is, it's up to user to decide.
> > > 
> > I found that all users enable it, so that is why i set this as
> > default,
> You set it as default in arch/arm/mach-socfpga/Kconfig , no need to
> modify the text.
> 
> > 
> > otherwise i have to add this into their defconfig one by one. Users
> > who
> > don't want enable it, they can set "N" in their defconfig. What do
> > you
> > think?
> > > 
> > > > 
> > > > 
> > > >       This provides basic infrastructure to support Altera
> > > > FPGA devices.
> > > >       Enable Altera FPGA specific functions which includes
> > > > bitstream
> > > > diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile
> > > > index 06f..84e7605 100644
> > > > --- a/drivers/fpga/Makefile
> > > > +++ b/drivers/fpga/Makefile
> > > > @@ -14,10 +14,9 @@ obj-$(CONFIG_FPGA_ZYNQMPPL) += zynqmppl.o
> > > >  obj-$(CONFIG_FPGA_XILINX) += xilinx.o
> > > >  obj-$(CONFIG_FPGA_LATTICE) += ivm_core.o lattice.o
> > > >  ifdef CONFIG_FPGA_ALTERA
> > > > -obj-y += altera.o
> > > > +obj-y += altera.o socfpga.o
> > > Now all the ancient systems which had the ancient Altera FPGAs
> > > will
> > > build-in the socfpga stuff too . That cannot work.
> > > 
> > Okay, i will revert the changes.
> > > 
> > > > 
> > > > 
> > > >  obj-$(CONFIG_FPGA_ACEX1K) += ACEX1K.o
> > > >  obj-$(CONFIG_FPGA_CYCLON2) += cyclon2.o
> > > >  obj-$(CONFIG_FPGA_STRATIX_II) += stratixII.o
> > > >  obj-$(CONFIG_FPGA_STRATIX_V) += stratixv.o
> > > > -obj-$(CONFIG_FPGA_SOCFPGA) += socfpga.o
> > > >  endif
> > > > diff --git a/include/altera.h b/include/altera.h
> > > > index 48d3eb7..a627b37 100644
> > > > --- a/include/altera.h
> > > > +++ b/include/altera.h
> > > > @@ -109,7 +109,7 @@ typedef struct {
> > > >     Altera_post_fn post;
> > > >  } altera_board_specific_func;
> > > >  
> > > > -#ifdef CONFIG_FPGA_SOCFPGA
> > > > +#ifdef CONFIG_FPGA_ALTERA
> > > >  int socfpga_load(Altera_desc *desc, const void *rbf_data,
> > > > size_t
> > > > rbf_size);
> > > >  #endif
> > > >  
> > > > diff --git a/include/configs/socfpga_common.h
> > > > b/include/configs/socfpga_common.h
> > > > index da7e4ad..1b79c03 100644
> > > > --- a/include/configs/socfpga_common.h
> > > > +++ b/include/configs/socfpga_common.h
> > > > @@ -107,9 +107,6 @@
> > > >   */
> > > >  #ifdef CONFIG_TARGET_SOCFPGA_GEN5
> > > >  #ifdef CONFIG_CMD_FPGA
> > > > -#define CONFIG_FPGA
> > > > -#define CONFIG_FPGA_ALTERA
> > > > -#define CONFIG_FPGA_SOCFPGA
> > > >  #define CONFIG_FPGA_COUNT  1
> > > >  #endif
> > > >  #endif
> > > > 
> 
___
U-Boot mailing list
U-Boot@lists.denx.de

[U-Boot] [PATCH] mmc: sdhci-cadence: import updates from Linux 4.12

[Masahiro Yamada]

This driver is a counterpart of drivers/mmc/host/sdhci-cadence.c
from Linux.  Some updates for v4.12-rc1 can be imported to U-Boot.

 - Fix value of SDHCI_CDNS_HRS04_RDATA_SHIFT
 - Add polling for ACK bit to be sure that data are written to
   the PHY register
 - Retrieve PHY values from DT properties instead of fixed data

The following is the list of upstream commits:

 - Linux commit 4e03f628b464e0580abadf5161eaa38c61d20943
   mmc: sdhci-cadence: fix bit shift of read data from PHY port

 - Linux commit a0f8243229ed071c8da0ea7cedc1b7bf1b1515da
   mmc: sdhci-cadence: Fix writing PHY delay

 - Linux a89c472d8b55c5afc4c79e6e3d1338730034eb01
   mmc: sdhci-cadence: Update PHY delay configuration

Signed-off-by: Masahiro Yamada 
---

 drivers/mmc/sdhci-cadence.c | 67 ++---
 1 file changed, 57 insertions(+), 10 deletions(-)

diff --git a/drivers/mmc/sdhci-cadence.c b/drivers/mmc/sdhci-cadence.c
index 2253bbc..dc86d10 100644
--- a/drivers/mmc/sdhci-cadence.c
+++ b/drivers/mmc/sdhci-cadence.c
@@ -7,8 +7,10 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -17,7 +19,7 @@
 #define   SDHCI_CDNS_HRS04_ACK BIT(26)
 #define   SDHCI_CDNS_HRS04_RD  BIT(25)
 #define   SDHCI_CDNS_HRS04_WR  BIT(24)
-#define   SDHCI_CDNS_HRS04_RDATA_SHIFT 12
+#define   SDHCI_CDNS_HRS04_RDATA_SHIFT 16
 #define   SDHCI_CDNS_HRS04_WDATA_SHIFT 8
 #define   SDHCI_CDNS_HRS04_ADDR_SHIFT  0
 
@@ -34,6 +36,9 @@
 #define SDHCI_CDNS_PHY_DLY_EMMC_LEGACY 0x06
 #define SDHCI_CDNS_PHY_DLY_EMMC_SDR0x07
 #define SDHCI_CDNS_PHY_DLY_EMMC_DDR0x08
+#define SDHCI_CDNS_PHY_DLY_SDCLK   0x0b
+#define SDHCI_CDNS_PHY_DLY_HSMMC   0x0c
+#define SDHCI_CDNS_PHY_DLY_STROBE  0x0d
 
 struct sdhci_cdns_plat {
struct mmc_config cfg;
@@ -41,11 +46,31 @@ struct sdhci_cdns_plat {
void __iomem *hrs_addr;
 };
 
-static void sdhci_cdns_write_phy_reg(struct sdhci_cdns_plat *plat,
-u8 addr, u8 data)
+struct sdhci_cdns_phy_cfg {
+   const char *property;
+   u8 addr;
+};
+
+static const struct sdhci_cdns_phy_cfg sdhci_cdns_phy_cfgs[] = {
+   { "cdns,phy-input-delay-sd-highspeed", SDHCI_CDNS_PHY_DLY_SD_HS, },
+   { "cdns,phy-input-delay-legacy", SDHCI_CDNS_PHY_DLY_SD_DEFAULT, },
+   { "cdns,phy-input-delay-sd-uhs-sdr12", SDHCI_CDNS_PHY_DLY_UHS_SDR12, },
+   { "cdns,phy-input-delay-sd-uhs-sdr25", SDHCI_CDNS_PHY_DLY_UHS_SDR25, },
+   { "cdns,phy-input-delay-sd-uhs-sdr50", SDHCI_CDNS_PHY_DLY_UHS_SDR50, },
+   { "cdns,phy-input-delay-sd-uhs-ddr50", SDHCI_CDNS_PHY_DLY_UHS_DDR50, },
+   { "cdns,phy-input-delay-mmc-highspeed", SDHCI_CDNS_PHY_DLY_EMMC_SDR, },
+   { "cdns,phy-input-delay-mmc-ddr", SDHCI_CDNS_PHY_DLY_EMMC_DDR, },
+   { "cdns,phy-dll-delay-sdclk", SDHCI_CDNS_PHY_DLY_SDCLK, },
+   { "cdns,phy-dll-delay-sdclk-hsmmc", SDHCI_CDNS_PHY_DLY_HSMMC, },
+   { "cdns,phy-dll-delay-strobe", SDHCI_CDNS_PHY_DLY_STROBE, },
+};
+
+static int sdhci_cdns_write_phy_reg(struct sdhci_cdns_plat *plat,
+   u8 addr, u8 data)
 {
void __iomem *reg = plat->hrs_addr + SDHCI_CDNS_HRS04;
u32 tmp;
+   int ret;
 
tmp = (data << SDHCI_CDNS_HRS04_WDATA_SHIFT) |
  (addr << SDHCI_CDNS_HRS04_ADDR_SHIFT);
@@ -54,17 +79,36 @@ static void sdhci_cdns_write_phy_reg(struct sdhci_cdns_plat 
*plat,
tmp |= SDHCI_CDNS_HRS04_WR;
writel(tmp, reg);
 
+   ret = readl_poll_timeout(reg, tmp, tmp & SDHCI_CDNS_HRS04_ACK, 10);
+   if (ret)
+   return ret;
+
tmp &= ~SDHCI_CDNS_HRS04_WR;
writel(tmp, reg);
+
+   return 0;
 }
 
-static void sdhci_cdns_phy_init(struct sdhci_cdns_plat *plat)
+static int sdhci_cdns_phy_init(struct sdhci_cdns_plat *plat,
+   const void *fdt, int nodeoffset)
 {
-   sdhci_cdns_write_phy_reg(plat, SDHCI_CDNS_PHY_DLY_SD_HS, 4);
-   sdhci_cdns_write_phy_reg(plat, SDHCI_CDNS_PHY_DLY_SD_DEFAULT, 4);
-   sdhci_cdns_write_phy_reg(plat, SDHCI_CDNS_PHY_DLY_EMMC_LEGACY, 9);
-   sdhci_cdns_write_phy_reg(plat, SDHCI_CDNS_PHY_DLY_EMMC_SDR, 2);
-   sdhci_cdns_write_phy_reg(plat, SDHCI_CDNS_PHY_DLY_EMMC_DDR, 3);
+   const u32 *prop;
+   int ret, i;
+
+   for (i = 0; i < ARRAY_SIZE(sdhci_cdns_phy_cfgs); i++) {
+   prop = fdt_getprop(fdt, nodeoffset,
+  sdhci_cdns_phy_cfgs[i].property, NULL);
+   if (!prop)
+   continue;
+
+   ret = sdhci_cdns_write_phy_reg(plat,
+  sdhci_cdns_phy_cfgs[i].addr,
+  fdt32_to_cpu(*prop));
+   if (ret)
+   return ret;
+   }
+
+   return 0;
 }
 
 static int sdhci_cdns_bind(struct 

Re: [U-Boot] [PATCH 4/5 v2] x86: bootm: Add dm_remove_devices_flags() call to bootm_announce_and_cleanup()

[Bin Meng]

On Mon, Apr 24, 2017 at 3:48 PM, Stefan Roese  wrote:
> This patch adds a call to dm_remove_devices_flags() to
> bootm_announce_and_cleanup() so that drivers that have one of the removal
> flags set (e.g. DM_FLAG_ACTIVE_DMA_REMOVE) in their driver struct, may
> do some last-stage cleanup before the OS is started.
>
> Signed-off-by: Stefan Roese 
> Cc: Bin Meng 
> Reviewed-by: Simon Glass 
> ---
> v2:
> - Added Simons RB line
>
>  arch/x86/lib/bootm.c | 9 +
>  1 file changed, 9 insertions(+)
>

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/5 v2] dm: core: Add DM_FLAG_OS_PREPARE flag

[Bin Meng]

On Mon, Apr 24, 2017 at 3:48 PM, Stefan Roese  wrote:
> This new flag can be added to DM device drivers, which need to do some
> final configuration before U-Boot exits and the OS (e.g. Linux) is
> started. The remove functions of those drivers will get called at
> this stage to do these last-stage configuration steps.
>
> Signed-off-by: Stefan Roese 
> Reviewed-by: Simon Glass 
> Cc: Bin Meng 
> ---
> - Renamed flag to DM_FLAG_OS_PREPARE
>
>  drivers/core/device-remove.c | 16 +++-
>  include/dm/device.h  | 11 ++-
>  2 files changed, 21 insertions(+), 6 deletions(-)
>

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 5/5 v2] spi: ich: Configure SPI BIOS parameters for Linux upon U-Boot exit

[Bin Meng]

On Mon, Apr 24, 2017 at 3:48 PM, Stefan Roese  wrote:
> This patch adds a remove function to the Intel ICH SPI driver, that will
> be called upon U-Boot exit, directly before the OS (Linux) is started.
> This function takes care of configuring the BIOS registers in the SPI
> controller (similar to what a "standard" BIOS or coreboot does), so that
> the Linux MTD device driver is able to correctly read/write to the SPI
> NOR chip. Without this, the chip is not detected at all.
>
> Signed-off-by: Stefan Roese 
> Reviewed-by: Simon Glass 
> Cc: Bin Meng 
> Cc: Jagan Teki 
> ---
> v2:
> - Added Simons RB line
>
>  drivers/spi/ich.c | 18 ++
>  drivers/spi/ich.h | 54 +++---
>  2 files changed, 65 insertions(+), 7 deletions(-)
>

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/5 v2] serial: serial-uclass: Use force parameter in stdio_deregister_dev()

[Bin Meng]

On Sat, Apr 29, 2017 at 8:26 AM, Simon Glass  wrote:
> On 24 April 2017 at 01:48, Stefan Roese  wrote:
>> On my x86 platform I've noticed, that calling dm_uninit() or the new
>> function dm_remove_devices_flags() does not remove the desired device at
>> all. Debugging showed, that the serial uclass returns -EPERM in
>> serial_pre_remove(). This patch sets the force parameter when calling
>> stdio_deregister_dev() resulting in a removal of the device.
>>
>> Signed-off-by: Stefan Roese 
>> Cc: Simon Glass 
>> Cc: Bin Meng 
>> ---
>> v2:
>> - New patch
>>
>>  drivers/serial/serial-uclass.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass 

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/7] arm: socfpga: Remove unused passing parameter of socfpga_bridges_reset

[Chee, Tien Fong]

On Isn, 2017-05-08 at 11:52 +0200, Marek Vasut wrote:
> On 05/08/2017 06:17 AM, Chee, Tien Fong wrote:
> > 
> > On Jum, 2017-05-05 at 13:09 +0200, Marek Vasut wrote:
> > > 
> > > On 05/05/2017 12:26 PM, tien.fong.c...@intel.com wrote:
> > > > 
> > > > 
> > > > From: Tien Fong Chee 
> > > > 
> > > > Remove unused passing parameter of socfpga_bridges_reset
> > > > function
> > > > in
> > > > SoCFPGA Arria10.
> > > So how do you un-reset the bridges if you drop this $enable
> > > argument
> > > ?
> > > 
> > This socfpga_reset_deassert_bridges_handoff() would be called,
> > bridges
> > are released based on DTS. 
> Seems the naming needs some work, it's quite chaotic and inobvious
> then.
> 
It is okay for "socfpga_bridges_unreset_byfdt()?
> > 
> > > 
> > > > 
> > > > 
> > > > Signed-off-by: Tien Fong Chee 
> > > > ---
> > > >  .../include/mach/reset_manager_arria10.h   |2 +-
> > > >  arch/arm/mach-socfpga/reset_manager_arria10.c  |4 ++--
> > > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/arch/arm/mach-
> > > > socfpga/include/mach/reset_manager_arria10.h b/arch/arm/mach-
> > > > socfpga/include/mach/reset_manager_arria10.h
> > > > index 7922db8..b6d7f4f 100644
> > > > --- a/arch/arm/mach-
> > > > socfpga/include/mach/reset_manager_arria10.h
> > > > +++ b/arch/arm/mach-
> > > > socfpga/include/mach/reset_manager_arria10.h
> > > > @@ -17,7 +17,7 @@ int
> > > > socfpga_reset_deassert_bridges_handoff(void);
> > > >  void socfpga_reset_assert_fpga_connected_peripherals(void);
> > > >  void socfpga_reset_deassert_osc1wd0(void);
> > > >  void socfpga_reset_uart(int assert);
> > > > -int socfpga_bridges_reset(int enable);
> > > > +int socfpga_bridges_reset(void);
> > > >  
> > > >  struct socfpga_reset_manager {
> > > >     u32 stat;
> > > > diff --git a/arch/arm/mach-socfpga/reset_manager_arria10.c
> > > > b/arch/arm/mach-socfpga/reset_manager_arria10.c
> > > > index d8c858c..66f1ec2 100644
> > > > --- a/arch/arm/mach-socfpga/reset_manager_arria10.c
> > > > +++ b/arch/arm/mach-socfpga/reset_manager_arria10.c
> > > > @@ -318,13 +318,13 @@ void socfpga_per_reset_all(void)
> > > >  }
> > > >  
> > > >  #if defined(CONFIG_SOCFPGA_VIRTUAL_TARGET)
> > > > -int socfpga_bridges_reset(int enable)
> > > > +int socfpga_bridges_reset(void)
> > > >  {
> > > >     /* For SoCFPGA-VT, this is NOP. */
> > > >     return 0;
> > > >  }
> > > >  #else
> > > > -int socfpga_bridges_reset(int enable)
> > > > +int socfpga_bridges_reset(void)
> > > >  {
> > > >     int ret;
> > > >  
> > > > 
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/7] arm: socfpga: Restructure FPGA driver in the preparation to support A10.

[Chee, Tien Fong]

On Isn, 2017-05-08 at 12:16 +0200, Marek Vasut wrote:
> On 05/08/2017 06:39 AM, Chee, Tien Fong wrote:
> > 
> > On Jum, 2017-05-05 at 13:13 +0200, Marek Vasut wrote:
> > > 
> > > On 05/05/2017 12:26 PM, tien.fong.c...@intel.com wrote:
> > > > 
> > > > 
> > > > From: Tien Fong Chee 
> > > > 
> > > > Move FPGA driver which is Gen5 specific code into Gen5 files.
> > > > No functional change.
> > > It's a driver, so it should stay in drivers/ . If you need to
> > > split
> > > it,
> > > split it in drivers/fpga/ and add Kconfig option(s)
> > > 
> > I am confused here, all the FPGA drivers which i split into common
> > and
> > platform specific are still in the drivers/fpga/. Could you explain
> > more? Thanks.
> The driver code should be in drivers/fpga/ , so unless there's a good
> reason, don't move any of it into arch/arm/
> 
Yeah, i agree with you. Hence, the patch 3, patch 4 and patch 5 are for
moving all fpga drivers into drivers/fpga/, and header files into
include/intel_socfpga/ .
> > 
> > > 
> > > > 
> > > > 
> > > > Signed-off-by: Tien Fong Chee 
> > > > ---
> > > >  arch/arm/mach-socfpga/Makefile |2 +-
> > > >  arch/arm/mach-socfpga/include/mach/fpga_manager.h  |   65 +---
> > > > -
> > > >  .../mach/{fpga_manager.h => fpga_manager_gen5.h}   |   69 +++-
> > > > --
> > > >  drivers/Makefile   |1 +
> > > >  drivers/fpga/Makefile  |1 +
> > > >  drivers/fpga/socfpga.c |  267 +---
> > > > 
> > > > 
> > > >  drivers/fpga/{socfpga.c => socfpga_gen5.c} |   29 +--
> > > >  7 files changed, 48 insertions(+), 386 deletions(-)
> > > >  copy arch/arm/mach-socfpga/include/mach/{fpga_manager.h =>
> > > > fpga_manager_gen5.h} (57%)
> > > >  copy drivers/fpga/{socfpga.c => socfpga_gen5.c} (92%)
> > > > 
> > > > diff --git a/arch/arm/mach-socfpga/Makefile b/arch/arm/mach-
> > > > socfpga/Makefile
> > > > index 41b779c..286bfef 100644
> > > > --- a/arch/arm/mach-socfpga/Makefile
> > > > +++ b/arch/arm/mach-socfpga/Makefile
> > > > @@ -9,7 +9,6 @@
> > > >  
> > > >  obj-y  += board.o
> > > >  obj-y  += clock_manager.o
> > > > -obj-y  += fpga_manager.o
> > > >  obj-y  += misc.o
> > > >  obj-y  += reset_manager.o
> > > >  obj-y  += timer.o
> > > > @@ -21,6 +20,7 @@ obj-y += reset_manager_gen5.o
> > > >  obj-y  += scan_manager.o
> > > >  obj-y  += system_manager_gen5.o
> > > >  obj-y  += wrap_pll_config.o
> > > > +obj-y  += fpga_manager.o
> > > >  endif
> > > >  
> > > >  ifdef CONFIG_TARGET_SOCFPGA_ARRIA10
> > > > diff --git a/arch/arm/mach-socfpga/include/mach/fpga_manager.h
> > > > b/arch/arm/mach-socfpga/include/mach/fpga_manager.h
> > > > index a077e22..69d8613 100644
> > > > --- a/arch/arm/mach-socfpga/include/mach/fpga_manager.h
> > > > +++ b/arch/arm/mach-socfpga/include/mach/fpga_manager.h
> > > > @@ -1,5 +1,5 @@
> > > >  /*
> > > > - * Copyright (C) 2012 Altera Corporation 
> > > > + * Copyright (C) 2012-2017 Altera Corporation 
> > > >   * All rights reserved.
> > > >   *
> > > >   * SPDX-License-Identifier:BSD-3-Clause
> > > > @@ -10,58 +10,9 @@
> > > >  
> > > >  #include 
> > > >  
> > > > -struct socfpga_fpga_manager {
> > > > -   /* FPGA Manager Module */
> > > > -   u32 stat;   /* 0x00 */
> > > > -   u32 ctrl;
> > > > -   u32 dclkcnt;
> > > > -   u32 dclkstat;
> > > > -   u32 gpo;/* 0x10 */
> > > > -   u32 gpi;
> > > > -   u32 misci;  /* 0x18 */
> > > > -   u32 _pad_0x1c_0x82c[517];
> > > > -
> > > > -   /* Configuration Monitor (MON) Registers */
> > > > -   u32 gpio_inten; /* 0x830 */
> > > > -   u32 gpio_intmask;
> > > > -   u32 gpio_inttype_level;
> > > > -   u32 gpio_int_polarity;
> > > > -   u32 gpio_intstatus; /* 0x840 */
> > > > -   u32 gpio_raw_intstatus;
> > > > -   u32 _pad_0x848;
> > > > -   u32 gpio_porta_eoi;
> > > > -   u32 gpio_ext_porta; /* 0x850 */
> > > > -   u32 _pad_0x854_0x85c[3];
> > > > -   u32 gpio_1s_sync;   /* 0x860 */
> > > > -   u32 _pad_0x864_0x868[2];
> > > > -   u32 gpio_ver_id_code;
> > > > -   u32 gpio_config_reg2;   /* 0x870 */
> > > > -   u32 gpio_config_reg1;
> > > > -};
> > > > -
> > > > -#define FPGAMGRREGS_STAT_MODE_MASK 0x7
> > > > -#define FPGAMGRREGS_STAT_MSEL_MASK 0xf8
> > > > -#define FPGAMGRREGS_STAT_MSEL_LSB  3
> > > > -
> > > > -#define FPGAMGRREGS_CTRL_CFGWDTH_MASK  0x200
> > > > -#define FPGAMGRREGS_CTRL_AXICFGEN_MASK 0x100
> > > > -#define FPGAMGRREGS_CTRL_NCONFIGPULL_MASK  0x4
> > > > -#define FPGAMGRREGS_CTRL_NCE_MASK  0x2
> > > > -#define FPGAMGRREGS_CTRL_EN_MASK   0x1
> > > > -#define 

Re: [U-Boot] [PATCH 1/5 v2] dm: device_remove: Don't return in device_chld_remove() upon error

[Simon Glass]

Hi Stefan,

On 8 May 2017 at 01:35, Stefan Roese  wrote:
> Hi Simon,
>
> On 04.05.2017 18:50, Simon Glass wrote:
>
> 
>
> ... the current implementation to exit the loop over all children
> upon error and not remove the remaining children is wrong IMO. All
> devices should at least be tried to get removed, even if one fails
> to get removed. This is what this patch makes sure of.



 Yes I see that, but not being able to remove is actually an error. In
 the normal course of events, a device that will not remove itself is
 likely buggy.
>>>
>>>
>>>
>>> Isn't it enough then to just print an error message in this case
>>> in this loop - change debug() to printf() in this current patch
>>> version? Then "users" of this code will be aware of such remove
>>> failures and can take appropriate actions (fix bug etc in their
>>> setup).
>>
>>
>> Possibly, but programmatically it becomes impossible to detect a
>> failure. Say the USB fails to stop its DMA, we might want to reboot
>> rather than continue to boot Linux and crash.
>
>
> Okay, I see your point.
>
>>>
 What do you think about adding a new remove flag to indicate that
 failures should be skipped?
>>>
>>>
>>>
>>> I'm a bit afraid that this makes the code overly complex. But if
>>> you prefer to have it this way, then I can come up with such a
>>> version as well. Just let me know.
>>
>>
>> I don't think the complexity is too great. It does need a new test.
>> But I think we should hold the line on error checking even with
>> remove(), by default.
>
>
> Understood. How about doing it this way: You drop this patch from
> the series for now (it still works for us with the force remove of
> the serial driver) and apply the remaining patches. I'll try to get
> back to this skip-failures flag implementation in a few days / weeks.
>
> Is this okay for you?

Yes that's fine.

>
> Thanks,
> Stefan

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 02/17] rk3036: Fix unused variable warning

[Simon Glass]

On 8 May 2017 at 20:14, Tom Rini  wrote:
>
> The variable grf is only referenced if EARLY_DEBUG is defined so move the
> declaration to be under the existing guard.
>
> Cc: Simon Glass 
> Signed-off-by: Tom Rini 
> ---
>  arch/arm/mach-rockchip/rk3036-board-spl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Sorry, I'm not sure how that crept in. Thanks for fixing it.

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH V3 1/4] usb: rockchip: add the rockusb gadget

[Eddie Cai]

2017-05-09 0:38 GMT+08:00 Simon Glass :
> Hi Eddie,
>
> On 2 May 2017 at 02:47, Eddie Cai  wrote:
>>
>> Hi Simon
>>
>> 2017-04-30 11:49 GMT+08:00 Simon Glass :
>> > Hi Eddie,
>> >
>> > On 28 April 2017 at 18:41, Eddie Cai  wrote:
>> >> this patch implement rockusb protocol on the device side. this is based 
>> >> on USB
>> >> download gadget infrastructure. the rockusb function implements the rd, 
>> >> wl, rid
>> >> commands. it can work with rkdeveloptool.
>> >>
>> >> Signed-off-by: Eddie Cai 
>> >>
>> >> Changes in v3:
>> >> -split the macro to f_rockusb.h
>> >> -use ALLOC_CACHE_ALIGN_BUFFER to define cache safe struct inside the 
>> >> function.
>> >> -fix checkpatch error
>> >>
>> >> ---
>> >>  arch/arm/include/asm/arch-rockchip/f_rockusb.h | 104 
>> >>  drivers/usb/gadget/Makefile|   1 +
>> >>  drivers/usb/gadget/f_rockusb.c | 724 
>> >> +
>> >>  3 files changed, 829 insertions(+)
>> >>  create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
>> >>  create mode 100644 drivers/usb/gadget/f_rockusb.c
>
> [..]
>
>
>> >> +char *rockusb_dev_type = 0;
>> >> +int rockusb_dev_index = 0;
>> >
>> > Move to top
>> OK
>> >
>> > I wonder if you should group all your data in a struct?
>> this data is useless if we just want to talk to cpu, get cpu info etc.
>> So no need to group
>> it in a struct. i will make it static to avoid other module use it
>
> The thing is that we should convert USB gadgets to driver model at
> some point. When we do, we cannot have static local data - it all
> needs to go into a driver-model struct.
>
> So I think it is better to do this now, and have a single static
> struct locally, then pass it around between the functions in this
> file. That way we have less work to do with DM conversion.
OK, i will do it in next version
>
> Regards,
> Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 06/17] mx6ul_14x14_evk: Fix unused variable warning

[Peng Fan]

On Mon, May 08, 2017 at 10:14:24PM -0400, Tom Rini wrote:
>The variable usdhc1_pads is only referenced during SPL builds, add a guard.
>
>Cc: Stefano Babic 
>Cc: Peng Fan 
>Signed-off-by: Tom Rini 

Reviewed-by: Peng Fan 

>---
> board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c 
>b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
>index b28ce1049589..a5746fe08688 100644
>--- a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
>+++ b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
>@@ -225,6 +225,7 @@ static iomux_v3_cfg_t const uart1_pads[] = {
>   MX6_PAD_UART1_RX_DATA__UART1_DCE_RX | MUX_PAD_CTRL(UART_PAD_CTRL),
> };
> 
>+#ifndef CONFIG_SPL_BUILD
> static iomux_v3_cfg_t const usdhc1_pads[] = {
>   MX6_PAD_SD1_CLK__USDHC1_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>   MX6_PAD_SD1_CMD__USDHC1_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>@@ -240,6 +241,7 @@ static iomux_v3_cfg_t const usdhc1_pads[] = {
>   /* RST_B */
>   MX6_PAD_GPIO1_IO09__GPIO1_IO09 | MUX_PAD_CTRL(NO_PAD_CTRL),
> };
>+#endif
> 
> /*
>  * mx6ul_14x14_evk board default supports sd card. If want to use
>-- 
>1.9.1
>
>___
>U-Boot mailing list
>U-Boot@lists.denx.de
>https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 05/17] mx6slevk: Fix unused variable warning

[Peng Fan]

On Mon, May 08, 2017 at 10:14:23PM -0400, Tom Rini wrote:
>The variable usdhc1_pads is only referenced during SPL builds, add a
>guard.
>
>Cc: Fabio Estevam 
>Cc: Peng Fan 
>Cc: Stefano Babic 
>Signed-off-by: Tom Rini 

Reviewed-by: Peng Fan 

>---
> board/freescale/mx6slevk/mx6slevk.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/board/freescale/mx6slevk/mx6slevk.c 
>b/board/freescale/mx6slevk/mx6slevk.c
>index d49543315b92..228514b106a8 100644
>--- a/board/freescale/mx6slevk/mx6slevk.c
>+++ b/board/freescale/mx6slevk/mx6slevk.c
>@@ -66,6 +66,7 @@ static iomux_v3_cfg_t const uart1_pads[] = {
>   MX6_PAD_UART1_RXD__UART1_RXD | MUX_PAD_CTRL(UART_PAD_CTRL),
> };
> 
>+#ifdef CONFIG_SPL_BUILD
> static iomux_v3_cfg_t const usdhc1_pads[] = {
>   /* 8 bit SD */
>   MX6_PAD_SD1_CLK__USDHC1_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>@@ -106,6 +107,7 @@ static iomux_v3_cfg_t const usdhc3_pads[] = {
>   /*CD pin*/
>   MX6_PAD_REF_CLK_32K__GPIO_3_22 | MUX_PAD_CTRL(NO_PAD_CTRL),
> };
>+#endif
> 
> static iomux_v3_cfg_t const fec_pads[] = {
>   MX6_PAD_FEC_MDC__FEC_MDC | MUX_PAD_CTRL(ENET_PAD_CTRL),
>-- 
>1.9.1
>
>___
>U-Boot mailing list
>U-Boot@lists.denx.de
>https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH V2 2/2] asm-generic: global_data: change timebase_l/h to unsigned int

[Peng Fan]

Change type of timebase_l/h to unsigned int.
From lib/time.c: ((uint64_t)gd->timebase_h << 32) | gd->timebase_l;
This piece code is based on that timebase_h and timebase_l are
32bits width, so change the type to unsigned int.

Signed-off-by: Peng Fan 
Cc: Eddie Cai 
Cc: Jagan Teki 
Cc: York Sun 
Cc: "Robert P. J. Day" 
Cc: Michal Simek 
Cc: Tom Rini 
Reviewed-by: Simon Glass 
---

V2: Add more commit log, add Simon's review tag.

 include/asm-generic/global_data.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-generic/global_data.h 
b/include/asm-generic/global_data.h
index 1a77c98..51838b5 100644
--- a/include/asm-generic/global_data.h
+++ b/include/asm-generic/global_data.h
@@ -83,8 +83,8 @@ typedef struct global_data {
 #ifdef CONFIG_SYS_I2C_MXC
void *srdata[10];
 #endif
-   unsigned long timebase_h;
-   unsigned long timebase_l;
+   unsigned int timebase_h;
+   unsigned int timebase_l;
 #ifdef CONFIG_SYS_MALLOC_F_LEN
unsigned long malloc_base;  /* base address of early malloc() */
unsigned long malloc_limit; /* limit address */
-- 
2.6.6

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH V2 1/2] arm: change tbu/l type to unsigned int

[Peng Fan]

Change tbu/l type to unsigned int.
From the timer file for arm,
"(((unsigned long long)gd->arch.tbu) << 32) | gd->arch.tbl;" is used,
This piece code is based on tbu/tbl is 32bits, so change the type to
unsigned int.

Signed-off-by: Peng Fan 
Cc: Simon Glass 
Cc: Tom Rini 
---

V2: Add more commit log

 arch/arm/include/asm/global_data.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/global_data.h 
b/arch/arm/include/asm/global_data.h
index 1aab629..3cc0e5f 100644
--- a/arch/arm/include/asm/global_data.h
+++ b/arch/arm/include/asm/global_data.h
@@ -32,8 +32,8 @@ struct arch_global_data {
 #endif
/* "static data" needed by most of timer.c on ARM platforms */
unsigned long timer_rate_hz;
-   unsigned long tbu;
-   unsigned long tbl;
+   unsigned int tbu;
+   unsigned int tbl;
unsigned long lastinc;
unsigned long long timer_reset_value;
 #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
-- 
2.6.6

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] pci: avoid memory leak

[Bin Meng]

On Tue, May 9, 2017 at 2:40 AM, Heinrich Schuchardt  wrote:
> strdup uses malloc to allocate memory for str.
> If we cannot bind to the generic driver we should release
> the memory.
>
> The problem was indicated by clang scan-build.
>
> Signed-off-by: Heinrich Schuchardt 
> ---
>  drivers/pci/pci-uclass.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 10/17] apalis_imx6: Fix unused variable warning

[Tom Rini]

The variable vga_pads is never referenced, drop.

Cc: Max Krummenacher 
Signed-off-by: Tom Rini 
---
 board/toradex/apalis_imx6/apalis_imx6.c | 47 -
 1 file changed, 47 deletions(-)

diff --git a/board/toradex/apalis_imx6/apalis_imx6.c 
b/board/toradex/apalis_imx6/apalis_imx6.c
index 09bebeb71b01..45f1d5de3906 100644
--- a/board/toradex/apalis_imx6/apalis_imx6.c
+++ b/board/toradex/apalis_imx6/apalis_imx6.c
@@ -564,53 +564,6 @@ static iomux_v3_cfg_t const rgb_pads[] = {
MX6_PAD_EIM_D31__IPU1_DISP1_DATA20 | MUX_PAD_CTRL(OUTPUT_RGB),
 };
 
-static iomux_v3_cfg_t const vga_pads[] = {
-#ifdef FOR_DL_SOLO
-   /* DualLite/Solo doesn't have IPU2 */
-   MX6_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK,
-   MX6_PAD_DI0_PIN15__IPU1_DI0_PIN15,
-   MX6_PAD_DI0_PIN2__IPU1_DI0_PIN02,
-   MX6_PAD_DI0_PIN3__IPU1_DI0_PIN03,
-   MX6_PAD_DISP0_DAT0__IPU1_DISP0_DATA00,
-   MX6_PAD_DISP0_DAT1__IPU1_DISP0_DATA01,
-   MX6_PAD_DISP0_DAT2__IPU1_DISP0_DATA02,
-   MX6_PAD_DISP0_DAT3__IPU1_DISP0_DATA03,
-   MX6_PAD_DISP0_DAT4__IPU1_DISP0_DATA04,
-   MX6_PAD_DISP0_DAT5__IPU1_DISP0_DATA05,
-   MX6_PAD_DISP0_DAT6__IPU1_DISP0_DATA06,
-   MX6_PAD_DISP0_DAT7__IPU1_DISP0_DATA07,
-   MX6_PAD_DISP0_DAT8__IPU1_DISP0_DATA08,
-   MX6_PAD_DISP0_DAT9__IPU1_DISP0_DATA09,
-   MX6_PAD_DISP0_DAT10__IPU1_DISP0_DATA10,
-   MX6_PAD_DISP0_DAT11__IPU1_DISP0_DATA11,
-   MX6_PAD_DISP0_DAT12__IPU1_DISP0_DATA12,
-   MX6_PAD_DISP0_DAT13__IPU1_DISP0_DATA13,
-   MX6_PAD_DISP0_DAT14__IPU1_DISP0_DATA14,
-   MX6_PAD_DISP0_DAT15__IPU1_DISP0_DATA15,
-#else
-   MX6_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK,
-   MX6_PAD_DI0_PIN15__IPU2_DI0_PIN15,
-   MX6_PAD_DI0_PIN2__IPU2_DI0_PIN02,
-   MX6_PAD_DI0_PIN3__IPU2_DI0_PIN03,
-   MX6_PAD_DISP0_DAT0__IPU2_DISP0_DATA00,
-   MX6_PAD_DISP0_DAT1__IPU2_DISP0_DATA01,
-   MX6_PAD_DISP0_DAT2__IPU2_DISP0_DATA02,
-   MX6_PAD_DISP0_DAT3__IPU2_DISP0_DATA03,
-   MX6_PAD_DISP0_DAT4__IPU2_DISP0_DATA04,
-   MX6_PAD_DISP0_DAT5__IPU2_DISP0_DATA05,
-   MX6_PAD_DISP0_DAT6__IPU2_DISP0_DATA06,
-   MX6_PAD_DISP0_DAT7__IPU2_DISP0_DATA07,
-   MX6_PAD_DISP0_DAT8__IPU2_DISP0_DATA08,
-   MX6_PAD_DISP0_DAT9__IPU2_DISP0_DATA09,
-   MX6_PAD_DISP0_DAT10__IPU2_DISP0_DATA10,
-   MX6_PAD_DISP0_DAT11__IPU2_DISP0_DATA11,
-   MX6_PAD_DISP0_DAT12__IPU2_DISP0_DATA12,
-   MX6_PAD_DISP0_DAT13__IPU2_DISP0_DATA13,
-   MX6_PAD_DISP0_DAT14__IPU2_DISP0_DATA14,
-   MX6_PAD_DISP0_DAT15__IPU2_DISP0_DATA15,
-#endif
-};
-
 static void do_enable_hdmi(struct display_info_t const *dev)
 {
imx_enable_hdmi_phy();
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 17/17] m5253demo: Fix static variable in non-static inline function warning

[Tom Rini]

The function 'spin_wheel' is declared as inline, but not static and thus
we see warnings that 'w' and 'p' are declared static in a non-static
inline function.  Correct this by marking spin_wheel as static inline.

Cc: TsiChung Liew 
Signed-off-by: Tom Rini 
---
 board/freescale/m5253demo/flash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/freescale/m5253demo/flash.c 
b/board/freescale/m5253demo/flash.c
index 071701d23436..099decabb892 100644
--- a/board/freescale/m5253demo/flash.c
+++ b/board/freescale/m5253demo/flash.c
@@ -31,7 +31,7 @@ typedef volatile unsigned short FLASH_PORT_WIDTHV;
 ulong flash_get_size(FPWV * addr, flash_info_t * info);
 int flash_get_offsets(ulong base, flash_info_t * info);
 int write_word(flash_info_t * info, FPWV * dest, u16 data);
-void inline spin_wheel(void);
+static inline void spin_wheel(void);
 
 flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];
 
@@ -439,7 +439,7 @@ int write_word(flash_info_t * info, FPWV * dest, u16 data)
return (res);
 }
 
-void inline spin_wheel(void)
+static inline void spin_wheel(void)
 {
static int p = 0;
static char w[] = "\\/-";
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 14/17] net: phy: mv88e61xx: Fix uninitialized variable warning

[Tom Rini]

The variable 'res' may be unused uninitialized if our call to
mv88e61xx_port_read (register read) fails and we goto the error
handling section.  In this case we set 'res' to -EIO to indicate why we
failed.

Cc: Joe Hershberger 
Cc: Chris Packham 
Cc: Kevin Smith 
Cc: Prafulla Wadaskar 
Signed-off-by: Tom Rini 
---
 drivers/net/phy/mv88e61xx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/mv88e61xx.c b/drivers/net/phy/mv88e61xx.c
index a2fd1686fc3b..3d2f6b98ad0e 100644
--- a/drivers/net/phy/mv88e61xx.c
+++ b/drivers/net/phy/mv88e61xx.c
@@ -655,8 +655,10 @@ static int mv88e61xx_read_port_config(struct phy_device 
*phydev, u8 port)
do {
val = mv88e61xx_port_read(phydev, port,
  PORT_REG_STATUS);
-   if (val < 0)
+   if (val < 0) {
+   res = -EIO;
goto unforce;
+   }
if (val & PORT_REG_STATUS_LINK)
break;
} while (--timeout);
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 04/17] cgtqmx6eval: Fix unused variable warning

[Tom Rini]

The variable usdhc2_pads is only referenced during SPL builds, add a guard.

Cc: Otavio Salvador 
Signed-off-by: Tom Rini 
---
 board/congatec/cgtqmx6eval/cgtqmx6eval.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/congatec/cgtqmx6eval/cgtqmx6eval.c 
b/board/congatec/cgtqmx6eval/cgtqmx6eval.c
index a4a602943ed2..24956a8a94e5 100644
--- a/board/congatec/cgtqmx6eval/cgtqmx6eval.c
+++ b/board/congatec/cgtqmx6eval/cgtqmx6eval.c
@@ -71,6 +71,7 @@ static iomux_v3_cfg_t const uart2_pads[] = {
IOMUX_PADS(PAD_EIM_D27__UART2_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL)),
 };
 
+#ifndef CONFIG_SPL_BUILD
 static iomux_v3_cfg_t const usdhc2_pads[] = {
IOMUX_PADS(PAD_SD2_CLK__SD2_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),
IOMUX_PADS(PAD_SD2_CMD__SD2_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),
@@ -94,6 +95,7 @@ static iomux_v3_cfg_t const usdhc3_pads[] = {
IOMUX_PADS(PAD_SD3_DAT7__SD3_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),
IOMUX_PADS(PAD_SD3_RST__SD3_RESET | MUX_PAD_CTRL(USDHC_PAD_CTRL)),
 };
+#endif
 
 static iomux_v3_cfg_t const usdhc4_pads[] = {
IOMUX_PADS(PAD_SD4_CLK__SD4_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 03/17] ot1200: Fix unused variable warning

[Tom Rini]

The variable pwm_pad is never referenced, drop.

Cc: Christian Gmeiner 
Signed-off-by: Tom Rini 
---
 board/bachmann/ot1200/ot1200.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
index eeced7943ed4..c0a8b6423ee1 100644
--- a/board/bachmann/ot1200/ot1200.c
+++ b/board/bachmann/ot1200/ot1200.c
@@ -273,10 +273,6 @@ int board_mmc_init(bd_t *bis)
return 0;
 }
 
-static iomux_v3_cfg_t const pwm_pad[] = {
-   MX6_PAD_SD1_CMD__PWM4_OUT | MUX_PAD_CTRL(OUTPUT_40OHM),
-};
-
 static void leds_on(void)
 {
/* turn on all possible leds connected via GPIO expander */
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 07/17] gw_ventana: Fix unused variable warnings

[Tom Rini]

The variable nfc_pads is only referenced when CONFIG_CMD_NAND is set,
move the existing guard and drop a now redundant comment.  The variable
gwproto_gpio_pads is never referenced, remove it.

Cc: Tim Harvey 
Signed-off-by: Tom Rini 
---
 board/gateworks/gw_ventana/common.c | 27 ---
 board/gateworks/gw_ventana/gw_ventana.c |  3 +--
 2 files changed, 1 insertion(+), 29 deletions(-)

diff --git a/board/gateworks/gw_ventana/common.c 
b/board/gateworks/gw_ventana/common.c
index d27bd57648ca..186eb1804813 100644
--- a/board/gateworks/gw_ventana/common.c
+++ b/board/gateworks/gw_ventana/common.c
@@ -180,33 +180,6 @@ void setup_ventana_i2c(void)
 /*
  * Baseboard specific GPIO
  */
-
-/* prototype */
-static iomux_v3_cfg_t const gwproto_gpio_pads[] = {
-   /* RS232_EN# */
-   IOMUX_PADS(PAD_SD4_DAT3__GPIO2_IO11 | DIO_PAD_CFG),
-   /* PANLEDG# */
-   IOMUX_PADS(PAD_KEY_COL0__GPIO4_IO06 | DIO_PAD_CFG),
-   /* PANLEDR# */
-   IOMUX_PADS(PAD_KEY_ROW0__GPIO4_IO07 | DIO_PAD_CFG),
-   /* LOCLED# */
-   IOMUX_PADS(PAD_KEY_ROW4__GPIO4_IO15 | DIO_PAD_CFG),
-   /* RS485_EN */
-   IOMUX_PADS(PAD_SD3_DAT4__GPIO7_IO01 | DIO_PAD_CFG),
-   /* IOEXP_PWREN# */
-   IOMUX_PADS(PAD_EIM_A19__GPIO2_IO19 | DIO_PAD_CFG),
-   /* IOEXP_IRQ# */
-   IOMUX_PADS(PAD_EIM_A20__GPIO2_IO18 | MUX_PAD_CTRL(IRQ_PAD_CTRL)),
-   /* VID_EN */
-   IOMUX_PADS(PAD_EIM_D31__GPIO3_IO31 | DIO_PAD_CFG),
-   /* DIOI2C_DIS# */
-   IOMUX_PADS(PAD_GPIO_19__GPIO4_IO05 | DIO_PAD_CFG),
-   /* PCICK_SSON */
-   IOMUX_PADS(PAD_SD1_CLK__GPIO1_IO20 | DIO_PAD_CFG),
-   /* PCI_RST# */
-   IOMUX_PADS(PAD_ENET_TXD1__GPIO1_IO29 | DIO_PAD_CFG),
-};
-
 static iomux_v3_cfg_t const gw51xx_gpio_pads[] = {
/* PANLEDG# */
IOMUX_PADS(PAD_KEY_COL0__GPIO4_IO06 | DIO_PAD_CFG),
diff --git a/board/gateworks/gw_ventana/gw_ventana.c 
b/board/gateworks/gw_ventana/gw_ventana.c
index dc8cd883e904..c4c2d2353207 100644
--- a/board/gateworks/gw_ventana/gw_ventana.c
+++ b/board/gateworks/gw_ventana/gw_ventana.c
@@ -76,7 +76,7 @@ static iomux_v3_cfg_t const enet_pads[] = {
IOMUX_PADS(PAD_ENET_TXD0__GPIO1_IO30 | DIO_PAD_CFG),
 };
 
-/* NAND */
+#ifdef CONFIG_CMD_NAND
 static iomux_v3_cfg_t const nfc_pads[] = {
IOMUX_PADS(PAD_NANDF_CLE__NAND_CLE | MUX_PAD_CTRL(NO_PAD_CTRL)),
IOMUX_PADS(PAD_NANDF_ALE__NAND_ALE | MUX_PAD_CTRL(NO_PAD_CTRL)),
@@ -95,7 +95,6 @@ static iomux_v3_cfg_t const nfc_pads[] = {
IOMUX_PADS(PAD_NANDF_D7__NAND_DATA07   | MUX_PAD_CTRL(NO_PAD_CTRL)),
 };
 
-#ifdef CONFIG_CMD_NAND
 static void setup_gpmi_nand(void)
 {
struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 08/17] gdsys: P1022: Fix unused variable warnings

[Tom Rini]

The variables prg_stage2_prepare, prg_stage2_success and prg_stage_fail
are only referenced when CCDM_SECOND_STAGE is set, move these to be by
the existing guard.

Cc: Dirk Eibach 
Signed-off-by: Tom Rini 
---
 board/gdsys/p1022/controlcenterd-id.c | 49 +--
 1 file changed, 24 insertions(+), 25 deletions(-)

diff --git a/board/gdsys/p1022/controlcenterd-id.c 
b/board/gdsys/p1022/controlcenterd-id.c
index 1648f1334054..db8a91756373 100644
--- a/board/gdsys/p1022/controlcenterd-id.c
+++ b/board/gdsys/p1022/controlcenterd-id.c
@@ -156,33 +156,8 @@ static const uint8_t prg_stage1_prepare[] = {
0x81, 0x2e, 0x30, 0x00, /* opcode: LOAD PCR3, f3 */
 };
 
-static const uint8_t prg_stage2_prepare[] = {
-   0x00, 0x80, 0x00, 0x00, /* opcode: SYNC PCR0 */
-   0x00, 0x84, 0x00, 0x00, /* opcode: SYNC PCR1 */
-   0x00, 0x88, 0x00, 0x00, /* opcode: SYNC PCR2 */
-   0x00, 0x8c, 0x00, 0x00, /* opcode: SYNC PCR3 */
-   0x00, 0x90, 0x00, 0x00, /* opcode: SYNC PCR4 */
-};
-
-static const uint8_t prg_stage2_success[] = {
-   0x81, 0x02, 0x40, 0x14, /* opcode: LOAD PCR4, #<20B data> */
-   0x48, 0xfd, 0x95, 0x17, 0xe7, 0x54, 0x6b, 0x68, /* data */
-   0x92, 0x31, 0x18, 0x05, 0xf8, 0x58, 0x58, 0x3c, /* data */
-   0xe4, 0xd2, 0x81, 0xe0, /* data */
-};
-
-static const uint8_t prg_stage_fail[] = {
-   0x81, 0x01, 0x00, 0x14, /* opcode: LOAD v0, #<20B data> */
-   0xc0, 0x32, 0xad, 0xc1, 0xff, 0x62, 0x9c, 0x9b, /* data */
-   0x66, 0xf2, 0x27, 0x49, 0xad, 0x66, 0x7e, 0x6b, /* data */
-   0xea, 0xdf, 0x14, 0x4b, /* data */
-   0x81, 0x42, 0x30, 0x00, /* opcode: LOAD PCR3, v0 */
-   0x81, 0x42, 0x40, 0x00, /* opcode: LOAD PCR4, v0 */
-};
-
 static const uint8_t vendor[] = "Guntermann & Drunck";
 
-
 /**
  * @brief read a bunch of data from MMC into memory.
  *
@@ -1013,6 +988,30 @@ static int first_stage_init(void)
 #endif
 
 #ifdef CCDM_SECOND_STAGE
+static const uint8_t prg_stage2_prepare[] = {
+   0x00, 0x80, 0x00, 0x00, /* opcode: SYNC PCR0 */
+   0x00, 0x84, 0x00, 0x00, /* opcode: SYNC PCR1 */
+   0x00, 0x88, 0x00, 0x00, /* opcode: SYNC PCR2 */
+   0x00, 0x8c, 0x00, 0x00, /* opcode: SYNC PCR3 */
+   0x00, 0x90, 0x00, 0x00, /* opcode: SYNC PCR4 */
+};
+
+static const uint8_t prg_stage2_success[] = {
+   0x81, 0x02, 0x40, 0x14, /* opcode: LOAD PCR4, #<20B data> */
+   0x48, 0xfd, 0x95, 0x17, 0xe7, 0x54, 0x6b, 0x68, /* data */
+   0x92, 0x31, 0x18, 0x05, 0xf8, 0x58, 0x58, 0x3c, /* data */
+   0xe4, 0xd2, 0x81, 0xe0, /* data */
+};
+
+static const uint8_t prg_stage_fail[] = {
+   0x81, 0x01, 0x00, 0x14, /* opcode: LOAD v0, #<20B data> */
+   0xc0, 0x32, 0xad, 0xc1, 0xff, 0x62, 0x9c, 0x9b, /* data */
+   0x66, 0xf2, 0x27, 0x49, 0xad, 0x66, 0x7e, 0x6b, /* data */
+   0xea, 0xdf, 0x14, 0x4b, /* data */
+   0x81, 0x42, 0x30, 0x00, /* opcode: LOAD PCR3, v0 */
+   0x81, 0x42, 0x40, 0x00, /* opcode: LOAD PCR4, v0 */
+};
+
 static int second_stage_init(void)
 {
static const char mac_suffix[] = ".mac";
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 09/17] pcm058: Fix unused variable warnings

[Tom Rini]

The variable nfc_pads is only referenced when CONFIG_CMD_NAND is set,
add a gaurd.  The variable gpio_pads is never referenced, drop it.  The
variable usdhc4_pads are only referenced when we do not have
CONFIG_CMD_NAND set and we are not doing an SPL build, modify the
existing guard.

Cc: Stefano Babic 
Signed-off-by: Tom Rini 
---
 board/phytec/pcm058/pcm058.c | 9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/board/phytec/pcm058/pcm058.c b/board/phytec/pcm058/pcm058.c
index c3607daf4605..3dc8cbd6a50b 100644
--- a/board/phytec/pcm058/pcm058.c
+++ b/board/phytec/pcm058/pcm058.c
@@ -108,6 +108,7 @@ static iomux_v3_cfg_t const ecspi1_pads[] = {
MX6_PAD_EIM_D19__GPIO3_IO19 | MUX_PAD_CTRL(NO_PAD_CTRL),
 };
 
+#ifdef CONFIG_CMD_NAND
 /* NAND */
 static iomux_v3_cfg_t const nfc_pads[] = {
MX6_PAD_NANDF_CLE__NAND_CLE | MUX_PAD_CTRL(NAND_PAD_CTRL),
@@ -130,11 +131,7 @@ static iomux_v3_cfg_t const nfc_pads[] = {
MX6_PAD_NANDF_D7__NAND_DATA07   | MUX_PAD_CTRL(NAND_PAD_CTRL),
MX6_PAD_SD4_DAT0__NAND_DQS  | MUX_PAD_CTRL(NAND_PAD_CTRL),
 };
-
-
-/* GPIOS */
-static iomux_v3_cfg_t const gpios_pads[] = {
-};
+#endif
 
 static struct i2c_pads_info i2c_pad_info2 = {
.scl = {
@@ -167,7 +164,7 @@ static iomux_v3_cfg_t const usdhc1_pads[] = {
MX6_PAD_EIM_BCLK__GPIO6_IO31| MUX_PAD_CTRL(NO_PAD_CTRL), /* CD */
 };
 
-#ifndef CONFIG_CMD_NAND
+#if !defined(CONFIG_CMD_NAND) && !defined(CONFIG_SPL_BUILD)
 static iomux_v3_cfg_t const usdhc4_pads[] = {
MX6_PAD_SD4_CLK__SD4_CLK| MUX_PAD_CTRL(USDHC_PAD_CTRL),
MX6_PAD_SD4_CMD__SD4_CMD| MUX_PAD_CTRL(USDHC_PAD_CTRL),
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 12/17] video: ld9040: Fix unused variable warnings

[Tom Rini]

The variables SEQ_SWRESET, SEQ_ELVSS_ON, SEQ_TEMP_SWIRE, SEQ_APON and
SEQ_SLPIN are unreferenced, drop.

Cc: Anatolij Gustschin 
Signed-off-by: Tom Rini 
---
 drivers/video/ld9040.c | 16 
 1 file changed, 16 deletions(-)

diff --git a/drivers/video/ld9040.c b/drivers/video/ld9040.c
index 23fe783c8844..8a90c25797e8 100644
--- a/drivers/video/ld9040.c
+++ b/drivers/video/ld9040.c
@@ -10,10 +10,6 @@
 #include 
 #include 
 
-static const unsigned char SEQ_SWRESET[] = {
-   0x01,
-};
-
 static const unsigned char SEQ_USER_SETTING[] = {
0xF0, 0x5A, 0x5A
 };
@@ -22,10 +18,6 @@ static const unsigned char SEQ_ELVSS_ON[] = {
0xB1, 0x0D, 0x00, 0x16,
 };
 
-static const unsigned char SEQ_TEMP_SWIRE[] = {
-   0xB2, 0x06, 0x06, 0x06, 0x06,
-};
-
 static const unsigned char SEQ_GTCON[] = {
0xF7, 0x09, 0x00, 0x00,
 };
@@ -46,10 +38,6 @@ static const unsigned char SEQ_GAMMA_CTRL[] = {
0xFB, 0x02, 0x5A,
 };
 
-static const unsigned char SEQ_APON[] = {
-   0xF3, 0x00, 0x00, 0x00, 0x0A, 0x02,
-};
-
 static const unsigned char SEQ_DISPCTL[] = {
0xF2, 0x02, 0x08, 0x08, 0x10, 0x10,
 };
@@ -66,10 +54,6 @@ static const unsigned char SEQ_SLPOUT[] = {
0x11,
 };
 
-static const unsigned char SEQ_SLPIN[] = {
-   0x10,
-};
-
 static const unsigned char SEQ_DISPON[] = {
0x29,
 };
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 16/17] common: Only build cli_readline.o for CMDLINE on non-SPL

[Tom Rini]

With gcc-6 and later we may get a warning such as:
.../common/cli_readline.c:20:21: warning: ‘tab_seq’ defined but not used 
[-Wunused-const-variable=]
 static const char   tab_seq[] = ""; /* used to expand TABs */
 ^~~
.../common/cli_readline.c:19:19: warning: ‘erase_seq’ defined but not used 
[-Wunused-const-variable=]
 static const char erase_seq[] = "\b \b"; /* erase sequence */
   ^

Because in SPL we're normally not doing interactive commands anyhow, so
lets just not compile this at all in SPL.  This also means that we need
to correct the logic (and comment) about what the drivers/ddr/fsl/ and
CONFIG_FSL_DDR_INTERACTIVE requires and this will be included in SPL
there.

Signed-off-by: Tom Rini 
---
 common/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/common/Makefile b/common/Makefile
index 86225f1564bf..67035c3091a9 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -85,6 +85,7 @@ obj-$(CONFIG_SCSI) += scsi.o
 obj-$(CONFIG_UPDATE_TFTP) += update.o
 obj-$(CONFIG_DFU_TFTP) += update.o
 obj-$(CONFIG_USB_KEYBOARD) += usb_kbd.o
+obj-$(CONFIG_CMDLINE) += cli_readline.o cli_simple.o
 
 endif # !CONFIG_SPL_BUILD
 
@@ -168,11 +169,9 @@ endif
 ifdef CONFIG_CMD_EEPROM_LAYOUT
 obj-y += eeprom/eeprom_field.o eeprom/eeprom_layout.o
 endif
-# We always have this since drivers/ddr/fs/interactive.c needs it
-obj-$(CONFIG_CMDLINE) += cli_simple.o
 
 obj-y += cli.o
-obj-$(CONFIG_CMDLINE) += cli_readline.o
+obj-$(CONFIG_FSL_DDR_INTERACTIVE) += cli_simple.o cli_readline.o
 obj-$(CONFIG_CMD_DFU) += dfu.o
 obj-y += command.o
 obj-y += s_record.o
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 13/17] net: eepro100: Fix unused variable warning

[Tom Rini]

The variable i82557_config_cmd is never referenced, drop.

Cc: Joe Hershberger 
Signed-off-by: Tom Rini 
---
 drivers/net/eepro100.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/eepro100.c b/drivers/net/eepro100.c
index 0f350cba53e6..33d9fd6a57fd 100644
--- a/drivers/net/eepro100.c
+++ b/drivers/net/eepro100.c
@@ -207,12 +207,6 @@ static int tx_threshold;
  * There are so many options that it would be difficult to document
  * each bit. We mostly use the default or recommended settings.
  */
-static const char i82557_config_cmd[] = {
-   22, 0x08, 0, 0, 0, 0, 0x32, 0x03, 1,/* 1=Use MII  0=Use AUI */
-   0, 0x2E, 0, 0x60, 0,
-   0xf2, 0x48, 0, 0x40, 0xf2, 0x80,/* 0x40=Force full-duplex */
-   0x3f, 0x05,
-};
 static const char i82558_config_cmd[] = {
22, 0x08, 0, 1, 0, 0, 0x22, 0x03, 1,/* 1=Use MII  0=Use AUI */
0, 0x2E, 0, 0x60, 0x08, 0x88,
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 06/17] mx6ul_14x14_evk: Fix unused variable warning

[Tom Rini]

The variable usdhc1_pads is only referenced during SPL builds, add a guard.

Cc: Stefano Babic 
Cc: Peng Fan 
Signed-off-by: Tom Rini 
---
 board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c 
b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
index b28ce1049589..a5746fe08688 100644
--- a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
+++ b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
@@ -225,6 +225,7 @@ static iomux_v3_cfg_t const uart1_pads[] = {
MX6_PAD_UART1_RX_DATA__UART1_DCE_RX | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
+#ifndef CONFIG_SPL_BUILD
 static iomux_v3_cfg_t const usdhc1_pads[] = {
MX6_PAD_SD1_CLK__USDHC1_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
MX6_PAD_SD1_CMD__USDHC1_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
@@ -240,6 +241,7 @@ static iomux_v3_cfg_t const usdhc1_pads[] = {
/* RST_B */
MX6_PAD_GPIO1_IO09__GPIO1_IO09 | MUX_PAD_CTRL(NO_PAD_CTRL),
 };
+#endif
 
 /*
  * mx6ul_14x14_evk board default supports sd card. If want to use
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 15/17] net: uli526x: Fix unknown storage size error

[Tom Rini]

The variable netdev_ethtool_ops is not referenced, drop it.  However
with gcc-6 or later we fail to even compile as we do not have the
required struct definition in U-Boot.

Cc: Joe Hershberger 
Signed-off-by: Tom Rini 
---
 drivers/net/uli526x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/uli526x.c b/drivers/net/uli526x.c
index 47cdb858c773..d05ae9ea0cfd 100644
--- a/drivers/net/uli526x.c
+++ b/drivers/net/uli526x.c
@@ -166,7 +166,6 @@ static int mode = 8;
 
 /* function declaration -- */
 static int uli526x_start_xmit(struct eth_device *dev, void *packet, int 
length);
-static const struct ethtool_ops netdev_ethtool_ops;
 static u16 read_srom_word(long, int);
 static void uli526x_descriptor_init(struct uli526x_board_info *, unsigned 
long);
 static void allocate_rx_buffer(struct uli526x_board_info *);
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 11/17] colibri_imx7: Fix unused variable warning

[Tom Rini]

The variable usdhc3_emmc_pads is never referenced, drop.

Cc: Stefan Agner 
Signed-off-by: Tom Rini 
---
 board/toradex/colibri_imx7/colibri_imx7.c | 16 
 1 file changed, 16 deletions(-)

diff --git a/board/toradex/colibri_imx7/colibri_imx7.c 
b/board/toradex/colibri_imx7/colibri_imx7.c
index b2b12e451999..e54afa195260 100644
--- a/board/toradex/colibri_imx7/colibri_imx7.c
+++ b/board/toradex/colibri_imx7/colibri_imx7.c
@@ -111,22 +111,6 @@ static void setup_gpmi_nand(void)
 }
 #endif
 
-static iomux_v3_cfg_t const usdhc3_emmc_pads[] = {
-   MX7D_PAD_SD3_CLK__SD3_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_CMD__SD3_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA0__SD3_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA1__SD3_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA2__SD3_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA3__SD3_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA4__SD3_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA5__SD3_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA6__SD3_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_DATA7__SD3_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-   MX7D_PAD_SD3_STROBE__SD3_STROBE  | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-
-   MX7D_PAD_SD3_RESET_B__GPIO6_IO11 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-};
-
 #ifdef CONFIG_VIDEO_MXS
 static iomux_v3_cfg_t const lcd_pads[] = {
MX7D_PAD_LCD_CLK__LCD_CLK | MUX_PAD_CTRL(LCD_PAD_CTRL),
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 05/17] mx6slevk: Fix unused variable warning

[Tom Rini]

The variable usdhc1_pads is only referenced during SPL builds, add a
guard.

Cc: Fabio Estevam 
Cc: Peng Fan 
Cc: Stefano Babic 
Signed-off-by: Tom Rini 
---
 board/freescale/mx6slevk/mx6slevk.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/freescale/mx6slevk/mx6slevk.c 
b/board/freescale/mx6slevk/mx6slevk.c
index d49543315b92..228514b106a8 100644
--- a/board/freescale/mx6slevk/mx6slevk.c
+++ b/board/freescale/mx6slevk/mx6slevk.c
@@ -66,6 +66,7 @@ static iomux_v3_cfg_t const uart1_pads[] = {
MX6_PAD_UART1_RXD__UART1_RXD | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
+#ifdef CONFIG_SPL_BUILD
 static iomux_v3_cfg_t const usdhc1_pads[] = {
/* 8 bit SD */
MX6_PAD_SD1_CLK__USDHC1_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
@@ -106,6 +107,7 @@ static iomux_v3_cfg_t const usdhc3_pads[] = {
/*CD pin*/
MX6_PAD_REF_CLK_32K__GPIO_3_22 | MUX_PAD_CTRL(NO_PAD_CTRL),
 };
+#endif
 
 static iomux_v3_cfg_t const fec_pads[] = {
MX6_PAD_FEC_MDC__FEC_MDC | MUX_PAD_CTRL(ENET_PAD_CTRL),
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 02/17] rk3036: Fix unused variable warning

[Tom Rini]

The variable grf is only referenced if EARLY_DEBUG is defined so move the
declaration to be under the existing guard.

Cc: Simon Glass 
Signed-off-by: Tom Rini 
---
 arch/arm/mach-rockchip/rk3036-board-spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/rk3036-board-spl.c 
b/arch/arm/mach-rockchip/rk3036-board-spl.c
index 0522d6546742..7b8d0ee653f8 100644
--- a/arch/arm/mach-rockchip/rk3036-board-spl.c
+++ b/arch/arm/mach-rockchip/rk3036-board-spl.c
@@ -17,13 +17,13 @@
 DECLARE_GLOBAL_DATA_PTR;
 
 #define GRF_BASE   0x20008000
-static struct rk3036_grf * const grf = (void *)GRF_BASE;
 
 #define DEBUG_UART_BASE0x20068000
 
 void board_init_f(ulong dummy)
 {
 #ifdef EARLY_DEBUG
+   struct rk3036_grf * const grf = (void *)GRF_BASE;
/*
 * NOTE: sd card and debug uart use same iomux in rk3036,
 * so if you enable uart,
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 01/17] socrates: Fix a misleading indentation warning

[Tom Rini]

With gcc-6 and later we see a warning about the fact that we have a
construct of "if (test);\n\tstatement".  Upon reviewing the code, the
intention here is as the compiler suggests, we only want to execute the
indented statement if the test was true.

Cc: Sergei Poselenov 
Signed-off-by: Tom Rini 
---
 board/socrates/socrates.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/socrates/socrates.c b/board/socrates/socrates.c
index 8b34a80e8f72..fb691c22d961 100644
--- a/board/socrates/socrates.c
+++ b/board/socrates/socrates.c
@@ -378,7 +378,7 @@ static void board_backlight_brightness(int br)
 
/* LEDs on */
reg = in_be32((void *)(CONFIG_SYS_FPGA_BASE + 0x0c));
-   if (!(reg & BACKLIGHT_ENABLE));
+   if (!(reg & BACKLIGHT_ENABLE))
out_be32((void *)(CONFIG_SYS_FPGA_BASE + 0x0c),
 reg | BACKLIGHT_ENABLE);
} else {
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-sunxi/master

[Tom Rini]

On Mon, May 08, 2017 at 09:42:04PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit e8f86a026125ff2b2d6bd6eac73d2542852aab84:
> 
>   sunxi: fix the default value of CONS_INDEX on non-A23/A33 SUN8I (2017-04-25 
> 11:44:21 +0200)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-sunxi.git master
> 
> for you to fetch changes up to 5a49b2929c0c73e43470cc53b80a6dfa47b5efda:
> 
>   sunxi: add support for Banana Pi M2 Plus board (2017-05-04 19:46:23 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/next

[Tom Rini]

On Mon, May 08, 2017 at 09:46:41PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit ac6991fb5fc1a694b29f4ebd5e07baebf818d7cc:
> 
>   zynq: spi: Honour the activation / deactivation delay (2017-05-03 11:03:04 
> +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git next
> 
> for you to fetch changes up to 0b2e5bbe6a4f3d25522675198b8beb0093a2e750:
> 
>   env_sf: use DIV_ROUND_UP to calculate number of sectors to erase 
> (2017-05-03 11:18:20 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCHv4 3/3] ARM64: poplar: hi3798cv200: u-boot support for Poplar 96Boards

[Tom Rini]

On Mon, May 08, 2017 at 08:36:28PM +0200, Jorge Ramirez wrote:
> On 05/08/2017 07:29 PM, Tom Rini wrote:
> >On Mon, May 08, 2017 at 06:36:43PM +0200, Jorge Ramirez-Ortiz wrote:
> >
> >>This port adds support for:
> >> 1) Serial
> >> 2) eMMC
> >> 3) USB
> >[snip]
> >>  arch/arm/dts/hi3798cv200.dtsi  |   3 +
> >>  arch/arm/dts/poplar-uboot.dtsi |  24 +++
> >[snip]
> >>diff --git a/arch/arm/dts/hi3798cv200.dtsi b/arch/arm/dts/hi3798cv200.dtsi
> >>index 75865f8..caa17de 100644
> >>--- a/arch/arm/dts/hi3798cv200.dtsi
> >>+++ b/arch/arm/dts/hi3798cv200.dtsi
> >>@@ -409,3 +409,6 @@
> >>};
> >>};
> >>  };
> >>+
> >>+#include "poplar-uboot.dtsi"
> >NAK, that's not the mechanism, we have one that will automatically
> >include the right file.  IF it's needed.
> 
> yeah I thought so...still what about what is being done for the
> dragonboard? (that is what misled me really)
> seems to me that board needs fixing as well...

Yes, patches welcome ;)  Seriously tho, yes, dragonboard is a bad
example here, along with some exynos and broadcom parts, and should be
corrected.  I'd appreciate a patch there.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Patchset v3 Poplar 96Boards EE

[Tom Rini]

On Mon, May 08, 2017 at 10:56:53AM -0500, Alex Elder wrote:
> On 05/08/2017 10:20 AM, Tom Rini wrote:
> > On Mon, May 08, 2017 at 05:15:56PM +0200, Jorge Ramirez-Ortiz wrote:
> > 
> >> [PATCHv3 1/5] ARM64: dts: hi3798cv200-poplar: add device tree bindings
> >> [PATCHv3 2/5] ARM64: dts: poplar: add usb-ehci node
> >> [PATCHv3 3/5] ARM64: dts: poplar: add clock frequency to the console
> > 
> > So, let me try differently.  When is the board DT going into Linux
> > directly (well, likely anyhow).  v4.12?  Or later?  Also, are you adding
> 
> It will land in Linux in 4.12.  It's now in for-next in the arm-soc tree.
>   2f20182ed670 arm64: dts: hisilicon: add dts files for hi3798cv200-poplar 
> board
>   b96df86307c5 dt-bindings: arm: hisilicon: add bindings for hi3798cv200 SoC 
> and P
> oplar board
> It is not present yet in Linus' master branch.
> 
> I have verified that the files include here:
>   [PATCHv3 1/5] ARM64: dts: hi3798cv200-poplar: add device tree bindings
> are identical to those found in the arm-soc tree for-next branch.

OK, but what about enabling USB/UART?  Are those nodes also enabled in
what'll be in 4.12?  My overall concern here is that we don't need
anything U-Boot centric in the dts file, and want to be able to drop in
future updates as a simple drop-in.  Thanks again!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] sunxi: support NanoPi Neo2

[Patrick Wildt]

Hi,

this diff adds basic support for the NanoPi Neo2.  It's based on the
old NanoPi Neo support and the recent commit of the OrangePi PC2
support.  I'm not sure it's 100% correct, but it seems to be a good
start to me and makes the machine boot.  Tested with Andre's SPL FIT
patchset.

Patrick

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index f3f53f3..4a36036 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -310,6 +310,7 @@ dtb-$(CONFIG_MACH_SUN8I_R40) += \
 dtb-$(CONFIG_MACH_SUN8I_V3S) += \
sun8i-v3s-licheepi-zero.dtb
 dtb-$(CONFIG_MACH_SUN50I_H5) += \
+   sun50i-h5-nanopi-neo2.dtb \
sun50i-h5-orangepi-pc2.dtb
 dtb-$(CONFIG_MACH_SUN50I) += \
sun50i-a64-pine64-plus.dtb \
diff --git a/arch/arm/dts/sun50i-h5-nanopi-neo2.dts 
b/arch/arm/dts/sun50i-h5-nanopi-neo2.dts
new file mode 100644
index 000..4932855
--- /dev/null
+++ b/arch/arm/dts/sun50i-h5-nanopi-neo2.dts
@@ -0,0 +1,180 @@
+/*
+ * Copyright (C) 2016 James Pettigrew 
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "sun8i-h3.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include 
+#include 
+
+/ {
+   model = "FriendlyARM NanoPi NEO2";
+   compatible = "friendlyarm,nanopi-neo2", "allwinner,sun50i-h5";
+
+   cpus {
+   cpu@0 {
+   compatible = "arm,cortex-a53", "arm,armv8";
+   enable-method = "psci";
+   };
+   cpu@1 {
+   compatible = "arm,cortex-a53", "arm,armv8";
+   enable-method = "psci";
+   };
+   cpu@2 {
+   compatible = "arm,cortex-a53", "arm,armv8";
+   enable-method = "psci";
+   };
+   cpu@3 {
+   compatible = "arm,cortex-a53", "arm,armv8";
+   enable-method = "psci";
+   };
+   };
+
+   psci {
+   compatible = "arm,psci-0.2";
+   method = "smc";
+   };
+
+   timer {
+   compatible = "arm,armv8-timer";
+   };
+
+   chosen {
+   stdout-path = "serial0:115200n8";
+   };
+
+   memory {
+   reg = <0x4000 0x2000>;
+   };
+
+   aliases {
+   serial0 = 
+   };
+
+   leds {
+   compatible = "gpio-leds";
+   pinctrl-names = "default";
+   pinctrl-0 = <_opc>, <_r_opc>;
+
+   pwr {
+   label = "nanopi:green:pwr";
+   gpios = <_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */
+   default-state = "on";
+   };
+
+   status {
+   label = "nanopi:blue:status";
+   gpios = < 0 10 GPIO_ACTIVE_HIGH>; /* PA10 */
+   };
+   };
+
+   reg_usb0_vbus: usb0-vbus {
+   compatible = "regulator-fixed";
+   regulator-name = "usb0-vbus";
+   regulator-min-microvolt = 

Re: [U-Boot] Patchset v3 Poplar 96Boards EE

[Alex Elder]

On 05/08/2017 10:20 AM, Tom Rini wrote:
> On Mon, May 08, 2017 at 05:15:56PM +0200, Jorge Ramirez-Ortiz wrote:
> 
>> [PATCHv3 1/5] ARM64: dts: hi3798cv200-poplar: add device tree bindings
>> [PATCHv3 2/5] ARM64: dts: poplar: add usb-ehci node
>> [PATCHv3 3/5] ARM64: dts: poplar: add clock frequency to the console
> 
> So, let me try differently.  When is the board DT going into Linux
> directly (well, likely anyhow).  v4.12?  Or later?  Also, are you adding

It will land in Linux in 4.12.  It's now in for-next in the arm-soc tree.
  2f20182ed670 arm64: dts: hisilicon: add dts files for hi3798cv200-poplar board
  b96df86307c5 dt-bindings: arm: hisilicon: add bindings for hi3798cv200 SoC 
and P
oplar board
It is not present yet in Linus' master branch.

I have verified that the files include here:
  [PATCHv3 1/5] ARM64: dts: hi3798cv200-poplar: add device tree bindings
are identical to those found in the arm-soc tree for-next branch.

-Alex

> U-Boot specific nodes/etc to the DT?  If so, those go into a
> -u-boot.dtsi (git grep around for details) not the main one.  And we
> need to explain really why they're u-boot specific.  Thanks!
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v4,3/3] rtc: Add DM support to ds1307

[Tom Rini]

On Sat, Apr 29, 2017 at 03:20:29PM +1200, Chris Packham wrote:

> Add an implementation of the ds1307 driver that uses the driver model
> i2c APIs.
> 
> Signed-off-by: Chris Packham 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] pico-imx7d: Add initial support

[Jagan Teki]

Though the code look good and similar approach of existing boards, I'm
little concern of continue the same legacy and w/o trying new feature
like fdt.

We've few i.MX boards which uses fdt support please refer the same.
I'm commenting below what all the code can removed ans use it with
dts.

>
> diff --git a/arch/arm/cpu/armv7/mx7/Kconfig b/arch/arm/cpu/armv7/mx7/Kconfig
> index 8dfb4c9..366fd34 100644
> --- a/arch/arm/cpu/armv7/mx7/Kconfig
> +++ b/arch/arm/cpu/armv7/mx7/Kconfig
> @@ -23,6 +23,13 @@ config TARGET_MX7DSABRESD
> select DM
> select DM_THERMAL
>
> +config TARGET_PICO_IMX7D
> +   bool "pico-imx7d"
> +   select BOARD_LATE_INIT
> +   select MX7D
> +   select DM
> +   select DM_THERMAL
> +
>  config TARGET_WARP7
> bool "warp7"
> select BOARD_LATE_INIT
> @@ -43,6 +50,7 @@ config SYS_SOC
> default "mx7"
>
>  source "board/freescale/mx7dsabresd/Kconfig"
> +source "board/technexion/pico-imx7d/Kconfig"
>  source "board/toradex/colibri_imx7/Kconfig"
>  source "board/warp7/Kconfig"
>
> diff --git a/board/technexion/pico-imx7d/Kconfig 
> b/board/technexion/pico-imx7d/Kconfig
> new file mode 100644
> index 000..f4ae18c
> --- /dev/null
> +++ b/board/technexion/pico-imx7d/Kconfig
> @@ -0,0 +1,15 @@
> +if TARGET_PICO_IMX7D
> +
> +config SYS_BOARD
> +   default "pico-imx7d"
> +
> +config SYS_VENDOR
> +   default "technexion"
> +
> +config SYS_SOC
> +   default "mx7"
> +
> +config SYS_CONFIG_NAME
> +   default "pico-imx7d"
> +
> +endif
> diff --git a/board/technexion/pico-imx7d/MAINTAINERS 
> b/board/technexion/pico-imx7d/MAINTAINERS
> new file mode 100644
> index 000..276162a
> --- /dev/null
> +++ b/board/technexion/pico-imx7d/MAINTAINERS
> @@ -0,0 +1,7 @@
> +Technexion PICO-IMX7D board
> +M: Wig Cheng 
> +M: Vanessa Maegima 
> +S: Maintained
> +F: board/technexion/pico-imx7d/
> +F: include/configs/pico-imx7d.h
> +F: configs/pico-imx7d_defconfig
> diff --git a/board/technexion/pico-imx7d/Makefile 
> b/board/technexion/pico-imx7d/Makefile
> new file mode 100644
> index 000..42cca47
> --- /dev/null
> +++ b/board/technexion/pico-imx7d/Makefile
> @@ -0,0 +1,6 @@
> +# (C) Copyright 2017 NXP Semiconductors
> +#
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +
> +obj-y  := pico-imx7d.o
> diff --git a/board/technexion/pico-imx7d/README 
> b/board/technexion/pico-imx7d/README
> new file mode 100644
> index 000..a2805ee
> --- /dev/null
> +++ b/board/technexion/pico-imx7d/README
> @@ -0,0 +1,49 @@
> +How to update U-Boot on pico-imx7d board
> +
> +
> +Required software on the host PC:
> +
> +- imx_usb_loader: https://github.com/boundarydevices/imx_usb_loader
> +
> +Build U-Boot for pico:
> +
> +$ make mrproper
> +$ make pico-imx7d_defconfig
> +$ make
> +
> +This generates the U-Boot binary called u-boot.imx.
> +
> +Put pico board in USB download mode (refer to the PICO-iMX7D Quick Start 
> Guide
> +page 3)
> +
> +Connect a USB to serial adapter between the host PC and pico.
> +
> +Connect a USB cable between the OTG pico port and the host PC.
> +
> +Open a terminal program such as minicom.
> +
> +Copy u-boot.imx to the imx_usb_loader folder.
> +
> +Load u-boot.imx via USB:
> +
> +$ sudo ./imx_usb u-boot.imx
> +
> +Then U-Boot starts and its messages appear in the console program.
> +
> +Use the default environment variables:
> +
> +=> env default -f -a
> +=> saveenv
> +
> +Run the UMS command:
> +=> ums 0 mmc 0
> +
> +Transfer u-boot.imx to be flashed into the eMMC:
> +
> +$ sudo dd if=u-boot.imx of=/dev/sdX bs=1K seek=1; sync
> +
> +Remove power from the pico board.
> +
> +Put pico board into normal boot mode.
> +
> +Power up the board and the new updated U-Boot should boot from eMMC.
> diff --git a/board/technexion/pico-imx7d/imximage.cfg 
> b/board/technexion/pico-imx7d/imximage.cfg
> new file mode 100644
> index 000..202956a
> --- /dev/null
> +++ b/board/technexion/pico-imx7d/imximage.cfg
> @@ -0,0 +1,98 @@
> +/*
> + * Copyright (C) 2017 Freescale Semiconductor, Inc.
> + *
> + * SPDX-License-Identifier:GPL-2.0+
> + *
> + * Refer docs/README.imxmage for more details about how-to configure
> + * and create imximage boot image
> + *
> + * The syntax is taken as close as possible with the kwbimage
> + */
> +
> +#define __ASSEMBLY__
> +#include 
> +
> +/* image version */
> +
> +IMAGE_VERSION 2
> +
> +BOOT_FROM  sd
> +
> +/* Secure boot support */
> +#ifdef CONFIG_SECURE_BOOT
> +CSF CONFIG_CSF_SIZE
> +#endif
> +
> +/*
> + * Device Configuration Data (DCD)
> + *
> + * Each entry must have the format:
> + * Addr-type   AddressValue
> + *
> + * where:
> + * Addr-type register length (1,2 or 4 bytes)
> + * Address   absolute address of the register
> + * value value to be stored in the register
> + */
> +
> +DATA 4 0x30340004 0x4F45
> +/* Clear then set bit30 to ensure 

Re: [U-Boot] [U-Boot, 2/6] configs: am335x: Enable TI_COMMON_CMD_OPTIONS

[Tom Rini]

On Thu, Apr 27, 2017 at 03:43:59PM +0530, Lokesh Vutla wrote:

> Enable TI_COMMON_CMD_OPTIONS on all am335x platforms.
> Also sync with savedefconfig.
> 
> Signed-off-by: Lokesh Vutla 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 6/6] configs: ks2: Enable TI_COMMON_CMD_OPTIONS

[Tom Rini]

On Thu, Apr 27, 2017 at 03:44:03PM +0530, Lokesh Vutla wrote:

> Enable TI_COMMON_CMD_OPTIONS on all keystone2 platforms.
> Also sync with savedefconfig.
> 
> Signed-off-by: Lokesh Vutla 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 1/6] board: ti: Define Kconfig symbol for common cmd options

[Tom Rini]

On Thu, Apr 27, 2017 at 03:43:58PM +0530, Lokesh Vutla wrote:

> Instead of defining command options in every defconfig,
> define a common Kconfig symbol that consolidates all command
> options that are supported by any TI platform. Also use imply
> keyword so that that specific option can be disabled if
> not required.
> 
> Signed-off-by: Lokesh Vutla 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2, 3/7] mtd: nand: Consolidate nand spl loaders implementation

[Tom Rini]

On Sun, Apr 16, 2017 at 03:31:59PM +0200, Ladislav Michl wrote:

> nand_spl_load_image implementation was copied over into three
> different drivers and now with nand_spl_read_block used for
> ubispl situation gets even worse. For now use least intrusive
> solution and #include the same implementation to nand drivers.
> 
> Signed-off-by: Ladislav Michl 
> Tested-by: Pau Pajuelo 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 13/18] stm32f7: enable board info read from device tree

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:02PM -0700, Vikas Manocha wrote:

> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 09/15] aspeed: Enable Pinctrl Driver in AST2500 EVB

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:28PM -0700, max...@google.com wrote:

> Enable Pinctrl Driver in AST2500 Eval Board's defconfig
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 13/15] aspeed: Add support for Clocks needed by MACs

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:32PM -0700, max...@google.com wrote:

> Add support for clocks needed by MACs to ast2500 clock driver.
> The clocks are D2-PLL, which is used by both MACs and PCLK_MAC1 and
> PCLK_MAC2 for MAC1 and MAC2 respectively.
> 
> The rate of D2-PLL is hardcoded to 250MHz -- the value used in Aspeed
> SDK. It is not entirely clear from the datasheet how this clock is used
> by MACs, so not clear if the rate would ever need to be different. So,
> for now, hardcoding it is probably safer.
> 
> The rate of PCLK_MAC{1,2} is chosen based on MAC speed selected through
> hardware strapping.
> 
> So, the network driver would only need to enable these clocks, no need
> to configure the rate.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 07/18] stm32f7: sdram: use sdram device tree node to configure sdram controller

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:56PM -0700, Vikas Manocha wrote:

> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 14/18] stm32f7: sdram: correct sdram configuration as per micron sdram

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:03PM -0700, Vikas Manocha wrote:

> Actually the sdram memory on stm32f746 discovery board is micron part
> MT48LC_4M32_B2B5_6A. This patch does the modification required in the
> device tree node & driver for the same.
> 
> Also we are passing here all the timing parameters in terms of clock
> cycles, so no need to convert time(ns or ms) to cycles.
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 06/15] aspeed: Device Tree configuration for Reset Driver

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:25PM -0700, max...@google.com wrote:

> Add Reset Driver configuration to ast2500 SoC Device Tree and bindings
> for various reset signals
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 11/18] stm32f746: to switch on user LED1 & read user button

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:00PM -0700, Vikas Manocha wrote:

> All discovery boards have one user button & one user LED. Here we are
> just reading the button status & switching ON the user LED.
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] common: env: remove superfluous assignment

[Heinrich Schuchardt]

The value assigned to variable 'value' is never used.

The problem was indicated by clang scan-build.

Signed-off-by: Heinrich Schuchardt 
---
 cmd/nvedit.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cmd/nvedit.c b/cmd/nvedit.c
index 9ca5cb58a7..8f4e6bbe62 100644
--- a/cmd/nvedit.c
+++ b/cmd/nvedit.c
@@ -234,7 +234,6 @@ static int _do_env_set(int flag, int argc, char * const 
argv[], int env_flag)
}
debug("Final value for argc=%d\n", argc);
name = argv[1];
-   value = argv[2];
 
if (strchr(name, '=')) {
printf("## Error: illegal character '='"
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v1,12/15] aspeed: Enable I2C in EVB defconfig

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:31PM -0700, max...@google.com wrote:

> Enable I2C driver in ast2500 Eval Board defconfig.
> Also enable i2c command.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 14/15] aspeed: Refactor SCU to use consistent mask & shift

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:33PM -0700, max...@google.com wrote:

> Refactor SCU header to use consistent Mask & Shift values.
> Now, consistently, to read value from SCU register, mask needs
> to be applied before shift.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 08/18] dm: gpio: Add driver for stm32f7 gpio controller

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:57PM -0700, Vikas Manocha wrote:

> This patch adds gpio driver supporting driver model for stm32f7 gpio.
> 
> Signed-off-by: Vikas Manocha 
> Reviewed-by: Simon Glass 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 18/18] stm32f7: remove not needed configuration from board config

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:07PM -0700, Vikas Manocha wrote:

> This patch removes:
>   - CONFIG_CMD_MEM: enabled by default
>   - CONFIG_DESIGNWARE_ETH : not being used anywhere.
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 15/18] stm32f7: increase the max no of pin configuration to 70

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:04PM -0700, Vikas Manocha wrote:

> The number of pins to be configured could be more than 50 e.g. in case
> of sdram controller, there are about 56 pins (32 data lines, 12 address
> & some control signals).
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v1,01/15] aspeed: Update ast2500 Device Tree

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:20PM -0700, max...@google.com wrote:

> Pull in the Device Tree for ast2500 from the mainline Linux kernel.
> The file is copied from
> https://raw.githubusercontent.com/torvalds/linux/34ea5c9d/arch/arm/boot/dts/aspeed-g5.dtsi
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v1,05/15] aspeed: Reset Driver

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:24PM -0700, max...@google.com wrote:

> Add Reset Driver for ast2500 SoC. This driver uses Watchdog Timer to
> perform resets and thus depends on it. The actual Watchdog device used
> needs to be configured in Device Tree using "aspeed,wdt" property, which
> must be WDT phandle, for example:
> 
> rst: reset-controller {
> compatible = "aspeed,ast2500-reset";
> aspeed,wdt = <>;
> }
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v1,08/15] aspeed: AST2500 Pinctrl Driver

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:27PM -0700, max...@google.com wrote:

> This driver uses Generic Pinctrl framework and is compatible with
> the Linux driver for ast2500: it uses the same device tree
> configuration.
> 
> Not all pins are supported by the driver at the moment, so it actually
> compatible with ast2400. In general, however, there are differences that
> in the future would be easier to maintain separately.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 4/6] configs: am57xx: Enable TI_COMMON_CMD_OPTIONS

[Tom Rini]

On Thu, Apr 27, 2017 at 03:44:01PM +0530, Lokesh Vutla wrote:

> Enable TI_COMMON_CMD_OPTIONS on all am57xx platforms.
> Also sync with savedefconfig
> 
> Signed-off-by: Lokesh Vutla 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v1,11/15] aspeed: Add I2C Driver

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:30PM -0700, max...@google.com wrote:

> Add Device Model based I2C driver for ast2500/ast2400 SoCs.
> The driver is very limited, it only supports master mode and
> synchronous byte-by-byte reads/writes, no DMA or Pool Buffers.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 
> Acked-by: Heiko Schocher 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 06/18] stm32f7: use clock driver to enable sdram controller clock

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:55PM -0700, Vikas Manocha wrote:

> This patch also removes the sdram/fmc clock enable from board specific
> code.
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 2/4] tools: moveconfig: cleanup whitelist entries

[Tom Rini]

On Tue, May 02, 2017 at 09:30:47PM +1200, Chris Packham wrote:

> After moving to KConfig and removing from all headers options should be
> removed from config_whitelist.txt so the build starts complaining if
> someone adds them back.
> 
> Acked-by: Masahiro Yamada 
> Signed-off-by: Chris Packham 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 5/6] configs: dra7xx: Enable TI_COMMON_CMD_OPTIONS

[Tom Rini]

On Thu, Apr 27, 2017 at 03:44:02PM +0530, Lokesh Vutla wrote:

> Enable TI_COMMON_CMD_OPTIONS on all dra7xx platforms.
> Also sync with savedefconfig.
> 
> Signed-off-by: Lokesh Vutla 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 2/2] ARM: keystone2: Add support for getting external clock dynamically

[Tom Rini]

On Wed, May 03, 2017 at 04:58:26PM +0530, Lokesh Vutla wrote:

> One some keystone2 platforms like K2G ICE, there is an option
> to switch between 24MHz or 25MHz as sysclk. But the existing
> driver assumes it is always 24MHz. Add support for getting
> all reference clocks dynamically by reading boot pins.
> 
> Signed-off-by: Lokesh Vutla 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 04/15] aspeed: Make SCU lock/unlock functions part of SCU API

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:23PM -0700, max...@google.com wrote:

> Make functions for locking and unlocking SCU part of SCU API.
> Many drivers need to modify settings in SCU and thus need to unlock it
> first. This change makes it possible.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 10/15] aspeed: Add P-Bus clock in ast2500 clock driver

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:29PM -0700, max...@google.com wrote:

> Add P-Bus Clock support to ast2500 clock driver.
> This is the clock used by I2C devices.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v3,4/4] README: remove CONFIG_CMD_DATE

[Tom Rini]

On Tue, May 02, 2017 at 09:30:49PM +1200, Chris Packham wrote:

> CONFIG_CMD_DATE was recently moved to Kconfig. Remove the now duplicate
> description of the option.
> 
> Signed-off-by: Chris Packham 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v1,02/15] dm: Simple Watchdog uclass

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:21PM -0700, max...@google.com wrote:

> This is a simple uclass for Watchdog Timers. It has four operations:
> start, restart, reset, stop. Drivers must implement start, restart and
> stop operations, while implementing reset is optional: It's default
> implementation expires watchdog timer in one clock tick.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 09/18] ARM: DT: stm32f7: add gpio device tree nodes

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:58PM -0700, Vikas Manocha wrote:

> Also created alias for gpios for stm32f7 discovery board. Based on these
> aliases, it would be possible to get gpio devices by sequence.
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 3/4] tools: moveconfig: cleanup README entires

[Tom Rini]

On Tue, May 02, 2017 at 09:30:48PM +1200, Chris Packham wrote:

> The Kconfig description replaces the description in the README file so
> as options are migrated they can be removed from the README.
> 
> Signed-off-by: Chris Packham 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Add ARM errata workaround 852421 and 852423 for Cortex-A17

[Tom Rini]

On Wed, Apr 26, 2017 at 04:18:01PM -0500, Nisal Menuka wrote:

> ARM errata 852421 and 852423 applies to r1p0, r1p1 and r1p2
> revisions of Cortex-A17 processors. These workarounds
> exist in Linux kernel and I thought it would be better
> to add them in to U-Boot.
> 
> Signed-off-by: Nisal Menuka 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 3/6] configs: am43xx: Enable TI_COMMON_CMD_OPTIONS

[Tom Rini]

On Thu, Apr 27, 2017 at 03:44:00PM +0530, Lokesh Vutla wrote:

> Enable TI_COMMON_CMD_OPTIONS on all am43xx platforms.
> Also sync with savedefconfig.
> 
> Signed-off-by: Lokesh Vutla 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 16/18] stm32f7: move board specific pin muxing to dts

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:05PM -0700, Vikas Manocha wrote:

> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,5/7] igep003x: UBIize

[Tom Rini]

On Sat, Apr 01, 2017 at 05:17:57PM +0200, Ladislav Michl wrote:

> Convert IGEP board to use UBI volumes for U-Boot, its environment and
> kernel. With exception of first four sectors read by SoC BootROM whole
> NAND is UBI managed.
> 
> Signed-off-by: Ladislav Michl 
> Reviewed-by: Heiko Schocher
> Tested-by: Pau Pajuelo 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2] ARM: DT: STM32F746: add u-boot, dm-pre-reloc property to sub nodes

[Tom Rini]

On Wed, Apr 12, 2017 at 02:16:36PM -0700, Vikas Manocha wrote:

> This patch is required for correct SPL device tree creation by fdtgrep
> as fdtgrep looks for u-boot,dm-pre-reloc property of the node to include
> it in the spl device tree.
> 
> Not adding it in these subnodes ignores the pin muxing of peripherals
> which is almost always in the subnodes.
> 
> Signed-off-by: Vikas Manocha 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 04/18] ARM: DT: stm32f7: add sdram pin contol node

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:53PM -0700, Vikas Manocha wrote:

> Also added DT binding doc for stm32 fmc(flexible memory controller).
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 07/15] aspeed: Refactor AST2500 RAM Driver and Sysreset Driver

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:26PM -0700, max...@google.com wrote:

> This change switches all existing users of ast2500 Watchdog to Driver
> Model based Watchdog driver.
> 
> To perform system reset Sysreset Driver uses first Watchdog device found
> via uclass_first_device call. Since the system is going to be reset
> anyway it does not make much difference which watchdog is used.
> 
> Instead of using Watchdog to reset itself, SDRAM driver now uses Reset
> driver to do that.
> 
> These were the only users of the old Watchdog API, so that API is
> removed.
> 
> This all is done in one change to avoid having to maintain dual API for
> watchdog in between.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 1/4] tools: moveconfig: extract helper function for user confirmation

[Tom Rini]

On Tue, May 02, 2017 at 09:30:46PM +1200, Chris Packham wrote:

> Avoid repetitive code dealing with asking the user for confirmation.
> 
> Signed-off-by: Chris Packham 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 12/18] stm32f7: stm32f746-disco: read memory info from device tree

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:01PM -0700, Vikas Manocha wrote:

> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 10/18] stm32f7: use stm32f7 gpio driver supporting driver model

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:59PM -0700, Vikas Manocha wrote:

> With this gpio driver supporting DM, there is no need to enable clocks
> for different gpios (for pin muxing) in the board specific code.
> 
> Need to increase the allocatable area required before relocation from 0x400 to
> 0xC00 becuase of 10 new gpio devices(& new gpio class) added in device tree.
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 1/2] ARM: k2g: Add support for dynamic programming of PLL based on SYSCLK

[Tom Rini]

On Wed, May 03, 2017 at 04:58:25PM +0530, Lokesh Vutla wrote:

> K2G supports various sysclk frequencies which can be
> determined using sysboot pins. PLLs should be configured
> based on this sysclock frequency. Add PLL configurations
> for all supported sysclk frequencies.
> 
> Signed-off-by: Lokesh Vutla 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v1, 15/15] aspeed: Cleanup ast2500-u-boot.dtsi Device Tree

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:34PM -0700, max...@google.com wrote:

> Remove unnecessary apb and ahb nodes and just override necessary
> nodes/values.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 6/7] igep003x: Add support for IGEP SMARC AM335x

[Tom Rini]

On Sat, Apr 01, 2017 at 05:18:40PM +0200, Ladislav Michl wrote:

> From: Pau Pajuelo 
> 
> The IGEP SMARC AM335x is an industrial processor module with
> following highlights:
> 
>   o AM3352 TI processor (Up to AM3359)
>   o Cortex-A8 ARM CPU
>   o SMARC form factor module
>   o Up to 512 MB DDR3 SDRAM / 512 MB FLASH
>   o WiFi a/b/g/n and Bluetooth v4.0 on-board
>   o Ethernet 10/100/1000 Mbps and 10/100 Mbps controller on-board
>   o JTAG debug connector available
>   o Designed for industrial range purposes
> 
> Signed-off-by: Pau Pajuelo 
> Signed-off-by: Ladislav Michl 
> Tested-by: Pau Pajuelo 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,1/7] ARM: am33xx: fix typo in spl.h

[Tom Rini]

On Sat, Apr 01, 2017 at 05:14:28PM +0200, Ladislav Michl wrote:

> Signed-off-by: Ladislav Michl 
> Tested-by: Pau Pajuelo 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,v1,03/15] aspeed: Watchdog Timer Driver

[Tom Rini]

On Mon, Apr 17, 2017 at 12:00:22PM -0700, max...@google.com wrote:

> This driver supports ast2500 and ast2400 SoCs.
> Only ast2500 supports reset_mask and thus the option of resettting
> individual peripherals using WDT.
> 
> Signed-off-by: Maxim Sloyko 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 02/18] stm32f7: sdram: move sdram driver code to ram drivers area

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:51PM -0700, Vikas Manocha wrote:

> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 03/18] stm32f7: dm: add driver model support for sdram

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:52PM -0700, Vikas Manocha wrote:

> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] spl: make image arg or fdt blob address reconfigurable

[Tom Rini]

On Fri, Apr 07, 2017 at 03:38:13PM -0700, Vikas Manocha wrote:

> At present fdt blob or argument address being passed to kernel is fixed at
> compile time using macro CONFIG_SYS_SPL_ARGS_ADDR. FDT blob from
> different media like nand, nor flash are copied to the address pointed
> by the macro.
> The problem is, it makes args/fdt blob compulsory to copy which is not 
> required
> in cases like for NOR Flash. This patch removes this limitation.
> 
> Signed-off-by: Vikas Manocha 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 01/18] stm32f7: use clock driver to enable qspi controller clock

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:50PM -0700, Vikas Manocha wrote:

> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 17/18] stm32f7: add support for stm32f769 disco board

[Tom Rini]

On Mon, Apr 10, 2017 at 03:03:06PM -0700, Vikas Manocha wrote:

> This board support stm32f7 family device stm32f769-I with 2MB internal Flash &
> 512KB RAM.
> STM32F769 lines offer the performance of the Cortex-M7 core (with double
> precision floating point unit) running up to 216 MHz.
> 
> To compile for stm32f769 board, use same defconfig as stm32f746-disco,
> the only difference is to pass "DEVICE_TREE=stm32f769-disco".
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,4/7] igep0033: Rename to igep003x

[Tom Rini]

On Sat, Apr 01, 2017 at 05:17:16PM +0200, Ladislav Michl wrote:

> Rename igep0033 to igep003x as IGEP SMARC AM335x module (igep0034)
> can use the same source files.
> 
> Signed-off-by: Ladislav Michl 
> Tested-by: Pau Pajuelo 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,2/7] ARM: am33xx: define BOOT_DEVICE_ONENAND

[Tom Rini]

On Sat, Apr 01, 2017 at 05:15:04PM +0200, Ladislav Michl wrote:

> am33xx does not support OneNAND, but we need this define anyway
> to let UBI SPL code compile.
> 
> Signed-off-by: Ladislav Michl 
> Tested-by: Pau Pajuelo 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,7/7] igep003x: Add netboot support

[Tom Rini]

On Sat, Apr 01, 2017 at 05:19:43PM +0200, Ladislav Michl wrote:

> From: Pau Pajuelo 
> 
> netboot allows to boot an external image using TFTP and NFS protocols
> 
> Signed-off-by: Pau Pajuelo 
> Signed-off-by: Ladislav Michl 
> Tested-by: Pau Pajuelo 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 05/18] stm32f7: use driver model for sdram initialization

[Tom Rini]

On Mon, Apr 10, 2017 at 03:02:54PM -0700, Vikas Manocha wrote:

> As driver model takes care of pin control configuraion, this patch also
> removes the sdram/fmc pin configuration.
> 
> Signed-off-by: Vikas Manocha 
> cc: Christophe KERELLO 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 5/7] arm: am57xx: cl-som-am57x: fix USB scan

[Tom Rini]

On Thu, Feb 23, 2017 at 03:39:39PM +0200, Uri Mashiach wrote:

> USB bus scan attempt:

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 6/7] arm: am57xx: cl-som-am57x: enable USB storage

[Tom Rini]

On Thu, Feb 23, 2017 at 03:39:40PM +0200, Uri Mashiach wrote:

> Add CONFIG_USB_STORAGE to the defconfig file.
> 
> Signed-off-by: Uri Mashiach 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v4, 7/7] arm: am57xx: cl-som-am57x: enable USB commands

[Tom Rini]

On Thu, Feb 23, 2017 at 03:39:41PM +0200, Uri Mashiach wrote:

> Add CONFIG_CMD_USB to the defconfig file.
> 
> Signed-off-by: Uri Mashiach 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot