Re: [U-Boot] [PATCH] mtd: zynq: nand: Move board_nand_init() function to board.c

[Michal Simek]

On 8.11.2017 03:44, Wilson Lee wrote:
> Putting board_nand_init() function inside NAND driver was not appropriate
> due to it doesn't allow board vendor to customise their NAND
> initialization code such as adding NAND lock/unlock code.
> 
> This commit was to move the board_nand_init() function from NAND driver
> to board.c file. This allow customization of board_nand_init() function.
> 
> Signed-off-by: Wilson Lee 
> Cc: Joe Hershberger 
> Cc: Keng Soon Cheah 
> Cc: Chen Yee Chew 
> Cc: Albert Aribaud 
> Cc: Michal Simek 
> Cc: Siva Durga Prasad Paladugu 
> Cc: Scott Wood 
> ---
>  arch/arm/mach-zynq/include/mach/nand.h |  9 +
>  board/xilinx/zynq/board.c  | 10 ++
>  drivers/mtd/nand/zynq_nand.c   | 12 +---
>  3 files changed, 20 insertions(+), 11 deletions(-)
>  create mode 100644 arch/arm/mach-zynq/include/mach/nand.h
> 
> diff --git a/arch/arm/mach-zynq/include/mach/nand.h 
> b/arch/arm/mach-zynq/include/mach/nand.h
> new file mode 100644
> index 000..61ef45f
> --- /dev/null
> +++ b/arch/arm/mach-zynq/include/mach/nand.h
> @@ -0,0 +1,9 @@
> +/*
> + * Copyright (C) 2017 National Instruments Corp.
> + *
> + * SPDX-License-Identifier:  GPL-2.0+
> + */
> +
> +#include 
> +
> +void zynq_nand_init(void);
> diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c
> index 90ef542..8bcb830 100644
> --- a/board/xilinx/zynq/board.c
> +++ b/board/xilinx/zynq/board.c
> @@ -9,6 +9,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  
> @@ -156,3 +157,12 @@ int dram_init(void)
>   return 0;
>  }
>  #endif
> +
> +static struct nand_chip nand_chip[CONFIG_SYS_MAX_NAND_DEVICE];
> +void board_nand_init(void)
> +{
> + struct nand_chip *nand = _chip[0];
> +
> + if (zynq_nand_init(nand, 0))
> + puts("ZYNQ NAND init failed\n");
> +}

This is probably not enough for platforms which don't enable NAND.

> diff --git a/drivers/mtd/nand/zynq_nand.c b/drivers/mtd/nand/zynq_nand.c
> index dec2c41..9be6856 100644
> --- a/drivers/mtd/nand/zynq_nand.c
> +++ b/drivers/mtd/nand/zynq_nand.c
> @@ -1006,7 +1006,7 @@ static int zynq_nand_device_ready(struct mtd_info *mtd)
>   return 0;
>  }
>  
> -static int zynq_nand_init(struct nand_chip *nand_chip, int devnum)
> +int zynq_nand_init(struct nand_chip *nand_chip, int devnum)
>  {
>   struct zynq_nand_info *xnand;
>   struct mtd_info *mtd;
> @@ -1191,13 +1191,3 @@ fail:
>   free(xnand);
>   return err;
>  }
> -
> -static struct nand_chip nand_chip[CONFIG_SYS_MAX_NAND_DEVICE];
> -
> -void board_nand_init(void)
> -{
> - struct nand_chip *nand = _chip[0];
> -
> - if (zynq_nand_init(nand, 0))
> - puts("ZYNQ NAND init failed\n");
> -}
> 

What's the sequence which you want to add?
Isn't it better just to include this there or create a hook here?

Definitely some platforms moved this to board file and not a problem
with moving it because it shouldn't be in nand driver.

Thanks,
Michal

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] configs: dragonboard410c: Save environment data on eMMC

[Jorge Ramirez]

On 11/07/2017 11:50 PM, Tom Rini wrote:

On Mon, Nov 06, 2017 at 02:16:38PM +0100, Jorge Ramirez-Ortiz wrote:


Save the environment data at the end of the boot partition on emmc

Signed-off-by: Jorge Ramirez-Ortiz 
---
  arch/arm/dts/dragonboard410c-uboot.dtsi | 7 +++
  configs/dragonboard410c_defconfig   | 2 ++
  include/configs/dragonboard410c.h   | 1 +
  3 files changed, 10 insertions(+)

Implementation this seems fine.  Is there a reason to do this vs
ENV_IS_IN_FAT?  Or ENV_IS_IN_EXT ? And have it be in a filesystem
instead?  That usually seems to be best for eval/dev/etc style boards.


I think having it on a partition offset (a partition that typically just 
stores the uboot image) can be very convenient when having the 
filesystem on an NFS share.


It means that the user can completely ignore flashing and maintaining 
the filesystem until he is ready. The only issue I see is that it is up 
to the user - when he reprograms a new image or modifies the size of the 
environemnt- to make sure the environment and whatever image is in the 
partition dont overlap each other but I think that should be acceptable?
















___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] ni: Add NIZYNQ platform

[Michal Simek]

On 8.11.2017 03:54, Wilson Lee wrote:
> Initial platform creation for NIZYNQ.
> 
> Signed-off-by: Joe Hershberger 
> Signed-off-by: Keng Soon Cheah 
> Signed-off-by: Wilson Lee 
> Cc: Chen Yee Chew 
> Cc: Albert Aribaud 
> ---
>  arch/arm/Kconfig  | 15 +++
>  arch/arm/Makefile |  4 +++-
>  board/ni/Kconfig  | 13 +
>  3 files changed, 31 insertions(+), 1 deletion(-)
>  create mode 100644 board/ni/Kconfig
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 83b7aa5..ae34821 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -767,6 +767,20 @@ config ARCH_ZYNQMP
>   select DM_USB if USB
>   imply FAT_WRITE
>  
> +config NIZYNQ
> + bool "National Instruments zynq Platform"
> + select CPU_V7
> + select SUPPORT_SPL
> + select OF_CONTROL
> + select SPL_OF_CONTROL if SPL
> + select DM
> + select DM_ETH
> + select DM_GPIO
> + select SPL_DM if SPL
> + select DM_MMC
> + select DM_SERIAL
> + select SPL_SEPARATE_BSS if SPL
> +

What's the reason for this? You should reuse current ZYNQ fragment and
if this selects something what you don't want then we should change
that. Look at syzygy or topic boards which are using existing zynq
infrastructure.

Thanks,
Michal




signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/2] sunxi: restore PHYLIB for CONFIG_SUN4I_EMAC users

[Artturi Alm]

due misnaming of CONFIG_SUN4I_EMAC in include/configs/sunxi-common.h,
likely missed in:
commit 3146f0c017df ("Move PHYLIB to Kconfig")

Signed-off-by: Artturi Alm 
---

 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index c1ce54e..52555da 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -247,6 +247,7 @@ config SUN7I_GMAC
 config SUN4I_EMAC
bool "Allwinner Sun4i Ethernet MAC support"
depends on DM_ETH
+   select PHYLIB
help
  This driver supports the Allwinner based SUN4I Ethernet MAC.
 
-- 
2.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/2] sunxi: fix CONFIG_SUNXI_EMAC references

[Artturi Alm]

fixes CONFIG_SUNXI_EMAC references from drivers/net/Makefile and
include/configs/sunxi-common.h likely forgotten in:
commit abc3e4df59f5 ("sunxi: Convert SUNXI_EMAC to Kconfig")

Signed-off-by: Artturi Alm 
---

 drivers/net/Makefile   | 2 +-
 include/configs/sunxi-common.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 94a4fd8..ac5443c 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -21,7 +21,7 @@ obj-$(CONFIG_DNET) += dnet.o
 obj-$(CONFIG_E1000) += e1000.o
 obj-$(CONFIG_E1000_SPI) += e1000_spi.o
 obj-$(CONFIG_EEPRO100) += eepro100.o
-obj-$(CONFIG_SUNXI_EMAC) += sunxi_emac.o
+obj-$(CONFIG_SUN4I_EMAC) += sunxi_emac.o
 obj-$(CONFIG_SUN8I_EMAC) += sun8i_emac.o
 obj-$(CONFIG_ENC28J60) += enc28j60.o
 obj-$(CONFIG_EP93XX) += ep93xx_eth.o
diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 4207398..4391a8c 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -286,7 +286,7 @@ extern int soft_i2c_gpio_scl;
 #endif /* CONFIG_VIDEO_SUNXI */
 
 /* Ethernet support */
-#ifdef CONFIG_SUNXI_EMAC
+#ifdef CONFIG_SUN4I_EMAC
 #define CONFIG_PHY_ADDR1
 #define CONFIG_MII /* MII PHY management   */
 #endif
-- 
2.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] ni: Add NIZYNQ platform

[Wilson Lee]

Initial platform creation for NIZYNQ.

Signed-off-by: Joe Hershberger 
Signed-off-by: Keng Soon Cheah 
Signed-off-by: Wilson Lee 
Cc: Chen Yee Chew 
Cc: Albert Aribaud 
---
 arch/arm/Kconfig  | 15 +++
 arch/arm/Makefile |  4 +++-
 board/ni/Kconfig  | 13 +
 3 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 board/ni/Kconfig

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 83b7aa5..ae34821 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -767,6 +767,20 @@ config ARCH_ZYNQMP
select DM_USB if USB
imply FAT_WRITE
 
+config NIZYNQ
+   bool "National Instruments zynq Platform"
+   select CPU_V7
+   select SUPPORT_SPL
+   select OF_CONTROL
+   select SPL_OF_CONTROL if SPL
+   select DM
+   select DM_ETH
+   select DM_GPIO
+   select SPL_DM if SPL
+   select DM_MMC
+   select DM_SERIAL
+   select SPL_SEPARATE_BSS if SPL
+
 config TEGRA
bool "NVIDIA Tegra"
imply FAT_WRITE
@@ -1258,6 +1272,7 @@ source "board/hisilicon/hikey/Kconfig"
 source "board/hisilicon/poplar/Kconfig"
 source "board/imx31_phycore/Kconfig"
 source "board/isee/igep003x/Kconfig"
+source "board/ni/Kconfig"
 source "board/olimex/mx23_olinuxino/Kconfig"
 source "board/phytec/pcm051/Kconfig"
 source "board/ppcag/bg0900/Kconfig"
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 0e0ae77..fbc271a 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -74,7 +74,9 @@ machine-$(CONFIG_ARCH_ROCKCHIP)   += rockchip
 machine-$(CONFIG_STM32)+= stm32
 machine-$(CONFIG_TEGRA)+= tegra
 machine-$(CONFIG_ARCH_UNIPHIER)+= uniphier
-machine-$(CONFIG_ARCH_ZYNQ)+= zynq
+ifneq (,$(findstring y,$(CONFIG_ZYNQ)$(CONFIG_NIZYNQ)))
+machine-y  += zynq
+endif
 
 machdirs := $(patsubst %,arch/arm/mach-%/,$(machine-y))
 
diff --git a/board/ni/Kconfig b/board/ni/Kconfig
new file mode 100644
index 000..382a544
--- /dev/null
+++ b/board/ni/Kconfig
@@ -0,0 +1,13 @@
+if NIZYNQ
+choice
+   prompt "NI Zynq board select"
+
+endchoice
+
+config SYS_VENDOR
+   default "ni"
+
+config SYS_SOC
+   default "zynq"
+
+endif
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] mtd: zynq: nand: Move board_nand_init() function to board.c

[Wilson Lee]

Putting board_nand_init() function inside NAND driver was not appropriate
due to it doesn't allow board vendor to customise their NAND
initialization code such as adding NAND lock/unlock code.

This commit was to move the board_nand_init() function from NAND driver
to board.c file. This allow customization of board_nand_init() function.

Signed-off-by: Wilson Lee 
Cc: Joe Hershberger 
Cc: Keng Soon Cheah 
Cc: Chen Yee Chew 
Cc: Albert Aribaud 
Cc: Michal Simek 
Cc: Siva Durga Prasad Paladugu 
Cc: Scott Wood 
---
 arch/arm/mach-zynq/include/mach/nand.h |  9 +
 board/xilinx/zynq/board.c  | 10 ++
 drivers/mtd/nand/zynq_nand.c   | 12 +---
 3 files changed, 20 insertions(+), 11 deletions(-)
 create mode 100644 arch/arm/mach-zynq/include/mach/nand.h

diff --git a/arch/arm/mach-zynq/include/mach/nand.h 
b/arch/arm/mach-zynq/include/mach/nand.h
new file mode 100644
index 000..61ef45f
--- /dev/null
+++ b/arch/arm/mach-zynq/include/mach/nand.h
@@ -0,0 +1,9 @@
+/*
+ * Copyright (C) 2017 National Instruments Corp.
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include 
+
+void zynq_nand_init(void);
diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c
index 90ef542..8bcb830 100644
--- a/board/xilinx/zynq/board.c
+++ b/board/xilinx/zynq/board.c
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -156,3 +157,12 @@ int dram_init(void)
return 0;
 }
 #endif
+
+static struct nand_chip nand_chip[CONFIG_SYS_MAX_NAND_DEVICE];
+void board_nand_init(void)
+{
+   struct nand_chip *nand = _chip[0];
+
+   if (zynq_nand_init(nand, 0))
+   puts("ZYNQ NAND init failed\n");
+}
diff --git a/drivers/mtd/nand/zynq_nand.c b/drivers/mtd/nand/zynq_nand.c
index dec2c41..9be6856 100644
--- a/drivers/mtd/nand/zynq_nand.c
+++ b/drivers/mtd/nand/zynq_nand.c
@@ -1006,7 +1006,7 @@ static int zynq_nand_device_ready(struct mtd_info *mtd)
return 0;
 }
 
-static int zynq_nand_init(struct nand_chip *nand_chip, int devnum)
+int zynq_nand_init(struct nand_chip *nand_chip, int devnum)
 {
struct zynq_nand_info *xnand;
struct mtd_info *mtd;
@@ -1191,13 +1191,3 @@ fail:
free(xnand);
return err;
 }
-
-static struct nand_chip nand_chip[CONFIG_SYS_MAX_NAND_DEVICE];
-
-void board_nand_init(void)
-{
-   struct nand_chip *nand = _chip[0];
-
-   if (zynq_nand_init(nand, 0))
-   puts("ZYNQ NAND init failed\n");
-}
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] lib: sha1: Change uint8_t to unsigned char for sha1_der_prefix array.

[Wilson Lee]

uint8_t used in sha1_der_prefix array was not able to recognize by
compiler when try to build the tools using 'HOSTCC'. That is because,
uint8_t is undefined when 'HOSTCC' is defined because asm/type.h is not
included in that case. Use unsigned char for sha1_der_prefix[] array
instead.

This commit is to remove and change the uint8_t to unsigned char for
sha1_der_perfix[] array.

Signed-off-by: Wilson Lee 
Cc: Joe Hershberger 
Cc: Keng Soon Cheah 
Cc: Chen Yee Chew 
Cc: Andrew Duda 
Cc: Simon Glass 
---
 include/u-boot/sha1.h | 2 +-
 lib/sha1.c| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/u-boot/sha1.h b/include/u-boot/sha1.h
index 2634a29..b5e55fe 100644
--- a/include/u-boot/sha1.h
+++ b/include/u-boot/sha1.h
@@ -23,7 +23,7 @@ extern "C" {
 #define SHA1_SUM_LEN   20
 #define SHA1_DER_LEN   15
 
-extern const uint8_t sha1_der_prefix[];
+extern const unsigned char sha1_der_prefix[];
 
 /**
  * \brief SHA-1 context structure
diff --git a/lib/sha1.c b/lib/sha1.c
index f54bb5b..d5d58c4 100644
--- a/lib/sha1.c
+++ b/lib/sha1.c
@@ -26,7 +26,7 @@
 #include 
 #include 
 
-const uint8_t sha1_der_prefix[SHA1_DER_LEN] = {
+const unsigned char sha1_der_prefix[SHA1_DER_LEN] = {
0x30, 0x21, 0x30, 0x09, 0x06, 0x05, 0x2b, 0x0e,
0x03, 0x02, 0x1a, 0x05, 0x00, 0x04, 0x14
 };
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] net: dhcp: Allow "MAY_FAIL" to still try each adapter

[Wilson Lee]

From: Joe Hershberger 

This change allows the "MAY_FAIL" DHCP option to still attempt to
contact a DHCP server on each adapter and only give up once each
adapter has failed once.  To get the existing behavior, set the
already-existing ethrotate=no variable.

Signed-off-by: Joe Hershberger 
Cc: Keng Soon Cheah 
Cc: Chen Yee Chew 
---
 net/bootp.c | 17 -
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/net/bootp.c b/net/bootp.c
index 73370a1..cb724e9 100644
--- a/net/bootp.c
+++ b/net/bootp.c
@@ -387,12 +387,19 @@ static void bootp_timeout_handler(void)
 
if (time_taken >= time_taken_max) {
 #ifdef CONFIG_BOOTP_MAY_FAIL
-   puts("\nRetry time exceeded\n");
-   net_set_state(NETLOOP_FAIL);
-#else
-   puts("\nRetry time exceeded; starting again\n");
-   net_start_again();
+   char *ethrotate;
+
+   ethrotate = getenv("ethrotate");
+   if ((ethrotate != NULL && strcmp(ethrotate, "no") == 0) ||
+   net_restart_wrap) {
+   puts("\nRetry time exceeded\n");
+   net_set_state(NETLOOP_FAIL);
+   } else
 #endif
+   {
+   puts("\nRetry time exceeded; starting again\n");
+   net_start_again();
+   }
} else {
bootp_timeout *= 2;
if (bootp_timeout > 2000)
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] gpt: add part-uuid and part-num subcommands

[your name]

From: Andrey Yurovsky 

It is useful to be able to retrieve a partition UUID or number given
the partition label, for instance some systems use the partition label
to indicate the purpose of the partition (such as "rootfs0" being the
0th root file system in an A/B image scheme).

Add "gpt part-uuid" to retrieve the partition UUID for a given label and
"gpt part-num" to retrieve the partition number for a given label along
with some documentation.

Signed-off-by: Andrey Yurovsky 
---
 cmd/gpt.c  | 67 ++
 doc/README.gpt | 21 ++
 2 files changed, 88 insertions(+)

diff --git a/cmd/gpt.c b/cmd/gpt.c
index 707d861766..bef292230e 100644
--- a/cmd/gpt.c
+++ b/cmd/gpt.c
@@ -355,6 +355,64 @@ static int do_get_gpt_info(struct blk_desc *dev_desc)
}
return ret;
 }
+
+static struct disk_part *find_part_by_label(const char *label)
+{
+   struct disk_part *part = NULL;
+   struct disk_part *curr;
+
+   list_for_each_entry(curr, _partitions, list) {
+   /* Check for the first match of the label we're looking
+* for against the partition label */
+   if (!strcmp((const char*)curr->gpt_part_info.name,
+   label)) {
+   part = curr;
+   break;
+   }
+   }
+
+   return part;
+}
+
+/* Find a partition UUID by label and save that UUID to the environment
+ * variable specified */
+static int do_get_part_uuid(struct blk_desc *dev_desc, const char *label,
+   const char *namestr)
+{
+   int ret;
+
+   ret = get_gpt_info(dev_desc);
+   if (ret > 0) {
+   struct disk_part *part = find_part_by_label(label);
+   if (part) {
+   env_set(namestr, part->gpt_part_info.uuid);
+   ret = 0;
+   }
+
+   del_gpt_info();
+   }
+
+   return ret;
+}
+
+/* Find a partition number by label and save that number to the environment
+ * variable specified */
+static int do_get_part_num(struct blk_desc *dev_desc, const char *label,
+   const char *namestr)
+{
+   int ret = get_gpt_info(dev_desc);
+   if (ret > 0) {
+   struct disk_part *part = find_part_by_label(label);
+   if (part) {
+   env_set_ulong(namestr, part->partnum);
+   ret = 0;
+   }
+
+   del_gpt_info();
+   }
+
+   return ret;
+}
 #endif
 
 /**
@@ -851,6 +909,10 @@ static int do_gpt(cmd_tbl_t *cmdtp, int flag, int argc, 
char * const argv[])
 #ifdef CONFIG_CMD_GPT_RENAME
} else if (strcmp(argv[1], "read") == 0) {
ret = do_get_gpt_info(blk_dev_desc);
+   } else if (strcmp(argv[1], "part-uuid") == 0 && argc == 6) {
+   ret = do_get_part_uuid(blk_dev_desc, argv[4], argv[5]);
+   } else if (strcmp(argv[1], "part-num") == 0 && argc == 6) {
+   ret = do_get_part_num(blk_dev_desc, argv[4], argv[5]);
} else if ((strcmp(argv[1], "swap") == 0) ||
   (strcmp(argv[1], "rename") == 0)) {
ret = do_rename_gpt_parts(blk_dev_desc, argv[1], argv[4], 
argv[5]);
@@ -887,6 +949,11 @@ U_BOOT_CMD(gpt, CONFIG_SYS_MAXARGS, 1, do_gpt,
" gpt guid mmc 0\n"
" gpt guid mmc 0 varname\n"
 #ifdef CONFIG_CMD_GPT_RENAME
+   "gpt partition label commands:\n"
+   "gpt part-uuid\n"
+   "- set environment variable to UUID of label\n"
+   "gpt part-num\n"
+   "- set environment variable to partition number of label\n"
"gpt partition renaming commands:\n"
"gpt swap\n"
"- change all partitions named name1 to name2\n"
diff --git a/doc/README.gpt b/doc/README.gpt
index d3db8bce1c..edb99b6c68 100644
--- a/doc/README.gpt
+++ b/doc/README.gpt
@@ -275,6 +275,27 @@ Some strings can be also used at the place of known GUID :
 
 They are also used to display the type of partition in "part list" command.
 
+Identifying Partitions in U-Boot:
+=
+
+Two subcommands may be used to identify partitions by their label. This can be
+useful for determining which partition to use or for setting boot arguments.
+The 'gpt part-uuid' command looks up a partition UUID for a given label and
+stores it in an environment variable. The 'gpt part-num' command looks up a
+partition number for a given label and stores it in an environment variable.
+The first partition with a matching label is used.
+
+For example, to find the UUID of a partition named 'rootfs0' and then use it
+for boot arguments:
+
+U-BOOT> gpt part-uuid mmc 0 rootfs0 rootfsuuid
+U-BOOT> setenv bootargs root=PARTUUID=${rootfsuuid}
+
+Or, for example, to find the partition number for a partition named 'kernel'
+and load a file from it:
+
+U-BOOT> gpt part-num mmc 0 kernel 

Re: [U-Boot] Include FSP in u-boot.rom

[Bin Meng]

Hi,

On Wed, Nov 8, 2017 at 7:13 AM, Bin Meng  wrote:
> Hi,
>
> On Tue, Nov 7, 2017 at 10:13 PM, vnktux  wrote:
>> Hi guys,
>>
>> I need to generate a u-boot.rom image of exactly 8Mb that include only 
>> fsp.bin and vga.bin. The reason is because in my company we will use an 
>> Intel tool that already contain descriptor and intel ME for our platform.
>> Has been already 1 week that I am struggling to do this, if I specify the 
>> build command  BUILD_ROM=y u-boot keep asking for descriptor, fsp and 
>> me.bin. And anyway if I give all the blobs in imput the building doesnt 
>> succed and it complain that the rom file is bigger than my flash (which is 
>> impossible since fsp=1.5Mb, vga=400Kb, me=8Mb, and the selected flash size 
>> is 16Mb).
>> Can someone please help me with this?
>>
>
> Don't set BUILD_ROM=y and you should be able to generate a u-boot.rom
> with FSP and VGA images.

Sorry, just woke up.. I wanted to say:

Don't set CONFIG_HAVE_INTEL_ME and you should be able to generate a
u-boot.rom with FSP and VGA images.

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Include FSP in u-boot.rom

[Bin Meng]

Hi,

On Tue, Nov 7, 2017 at 10:13 PM, vnktux  wrote:
> Hi guys,
>
> I need to generate a u-boot.rom image of exactly 8Mb that include only 
> fsp.bin and vga.bin. The reason is because in my company we will use an Intel 
> tool that already contain descriptor and intel ME for our platform.
> Has been already 1 week that I am struggling to do this, if I specify the 
> build command  BUILD_ROM=y u-boot keep asking for descriptor, fsp and me.bin. 
> And anyway if I give all the blobs in imput the building doesnt succed and it 
> complain that the rom file is bigger than my flash (which is impossible since 
> fsp=1.5Mb, vga=400Kb, me=8Mb, and the selected flash size is 16Mb).
> Can someone please help me with this?
>

Don't set BUILD_ROM=y and you should be able to generate a u-boot.rom
with FSP and VGA images.

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] configs: dragonboard410c: Save environment data on eMMC

[Tom Rini]

On Mon, Nov 06, 2017 at 02:16:38PM +0100, Jorge Ramirez-Ortiz wrote:

> Save the environment data at the end of the boot partition on emmc
> 
> Signed-off-by: Jorge Ramirez-Ortiz 
> ---
>  arch/arm/dts/dragonboard410c-uboot.dtsi | 7 +++
>  configs/dragonboard410c_defconfig   | 2 ++
>  include/configs/dragonboard410c.h   | 1 +
>  3 files changed, 10 insertions(+)

Implementation this seems fine.  Is there a reason to do this vs
ENV_IS_IN_FAT?  Or ENV_IS_IN_EXT ? And have it be in a filesystem
instead?  That usually seems to be best for eval/dev/etc style boards.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [ANN] U-Boot v2017.11-rc4 released

[Tom Rini]

On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
> On 11/07/2017 12:28 AM, Tom Rini wrote:
> >Hey all,
> >
> >It's release day and v2017.11-rc4 is out.  It's a week until release
> >day.  Please let me know if you know of any regressions, thanks!
> 
> Hi Tom,
> 
> emmc accesses are broken for dragonboard410c
> I posted the fix [1] last week. will you merge it?

[1] is: https://patchwork.ozlabs.org/patch/833376/

Jaehoon, are you OK with this patch?  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PULL] Please pull u-boot-rockchip

[Tom Rini]

On Tue, Nov 07, 2017 at 09:20:20AM +0100, Dr. Philipp Tomsich wrote:

> Tom,
> 
> Here’s another pull-request for u-boot-rockchip for some last-minute 
> DTS-updates and
> config-changes for the upcoming release.
> 
> Regards,
> Philipp.
> 
> 
> The following changes since commit 7a69604bce9a9a9476753af64e5a1870880c1333:
> 
>   Prepare v2017.11-rc4 (2017-11-06 18:25:37 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-rockchip.git master
> 
> for you to fetch changes up to 021a8ae00a2f9adcba460add4b69da7bc569fd52:
> 
>   rockchip: remove SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR from defconfig 
> (2017-11-07 09:16:58 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 0/5] libfdt: Reduce duplicated copies of libfdt

[Tom Rini]

On Tue, Nov 07, 2017 at 12:12:03PM +0900, Masahiro Yamada wrote:
> 2017-10-17 22:30 GMT+09:00 Masahiro Yamada :
> > Recently, U-Boot switched to the bundled DTC approach.
> > This means we have two copies, lib/libfdt and scripts/dtc/libfdt.
> >
> > Ideally, we should change lib/libfdt to #include scripts/dtc/libfdt.
> >
> > One big problem is lib/libfdt is locally modified
> > (fdt_ro.c  fdt_wip.c fdt_rw.c) and makes our life difficult.
> >
> > For now I synced only 6 files.
> >
> > This series depends on
> > "pylibfdt: compile pylibfdt in scripts/dtc/pylibfdt only when necessary"
> > http://patchwork.ozlabs.org/project/uboot/list/?series=8554
> >
> >
> >
> > Masahiro Yamada (5):
> >   libfdt: change fdt.h to a wrapper of scripts/dtc/libfdt/*
> >   libfdt: change libfdt_internal.h to a wrapper of scripts/dtc/libfdt/*
> >   tools: use files from scripts/dtc/libfdt where possible
> >   linux/types.h: add typedef of uintptr_t
> >   lib: libfdt: wrap scripts/dtc/libfdt/* where possible
> 
> 
> This series does not cleanly apply any more.
> 
> Tom,
> Do you need v2?

I assume that it's failing now on the <...> -> "..." change, and that
there's been no changes in linux-next in this area since v1?  If so,
I'll just fix it when I apply after release, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] sunxi: a64: Add verified-boot support

[Jagan Teki]

Enable verified-boot support for sunxi a64, tested the
same in orangepi boards.

Signed-off-by: Jagan Teki 
---
 arch/arm/mach-sunxi/Kconfig| 2 ++
 include/configs/sunxi-common.h | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index 09cfec6..cf6b264 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -178,6 +178,8 @@ config MACH_SUN50I
select SUNXI_DRAM_DW
select SUNXI_DRAM_DW_32BIT
select FIT
+   select FIT_SIGNATURE
+   select FIT_VERBOSE
select SPL_LOAD_FIT
 
 config MACH_SUN50I_H5
diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 4207398..921eb4f 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -34,6 +34,8 @@
 
 #ifdef CONFIG_ARM64
 #define CONFIG_BUILD_TARGET "u-boot.itb"
+/* Extend size of kernel image for uncompression */
+#define CONFIG_SYS_BOOTM_LEN   (60 * 1024 * 1024)
 #endif
 
 /* Serial & console */
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[Baudouin, Charles]

I think the correct thing to do here is to set the flash up for uniform sector 
size of 64Kbytes.

CR3V[3] = 1

If I can get the code to work I will send up the updates for uboot.



Charles Baudouin
Research and Development Manager
Domo Tactical Communications
E: charles.baudo...@domotactical.com
T: +44 1489 884 430
M: +44 7973 146 671

DTC - Website
DTC - 
Linkedin
DTC - Twitter
DTC - YouTube

Domo Tactical Communications (DTC) LTD trading as DTC, Fusion 2, 1100 Parkway, 
Whiteley, Hampshire, PO15 7AB, United Kingdom. +44 (0) 1489 566750. 
www.domotactical.com

Registered office Fusion 2, 1100 Parkway, Solent Business Park, Whiteley, 
Hampshire, PO15 7AB. Registered in England and Wales, company number 1456922.

Please consider the environment before printing this email.

This e-mail and any files transmitted with it ("E-mail") is intended solely for 
the addressee(s) and may contain information that is proprietary, privileged, 
company confidential and/or exempt from disclosure under applicable law. If you 
are not the intended addressee(s), any disclosure, reproduction, copying, 
distribution or other use of the E-mail is strictly prohibited. It may also 
contain data subject to the International Traffic in Arms Regulations or United 
States Export Administration Regulations, particularly if this E-mail has been 
transmitted from a United States location, and cannot be disseminated, 
distributed or copied to foreign nationals, residing in the United States or 
abroad, without the prior approval of the U.S. Department of State or 
appropriate export licensing authority. If you have received this E-mail in 
error, please delete it and destroy all copies of this E-mail and notify the 
sender immediately via telephone call or return e-mail.

Neither the company nor any subsidiary or affiliate or associated company nor 
any individual sending this E-mail accepts any liability in respect of the 
content (including errors and omissions) nor shall this e-mail be deemed to 
enter the company or any subsidiary or affiliate or associated company into a 
contract or to create any legally binding obligations unless expressly agreed 
to in writing under separate cover and timeliness of the E-mail which arise as 
a result of transmission. If verification is required, please request a hard 
copy version from the sender.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v4 1/2] armv8: lsch3: Add imply SCSI for ls1088

[York Sun]

On 11/01/2017 09:20 PM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar 
> ---
> 
> v3: Change SCSI command to imply SCSI
> v4: No change
> 
>  arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig 
> b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> index 8bbc981..5daf79e 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> @@ -84,6 +84,7 @@ config ARCH_LS1088A
>   select FSL_TZASC_1
>   select ARCH_EARLY_INIT_R
>   select BOARD_EARLY_INIT_F
> + imply SCSI
>  
>  config ARCH_LS2080A
>   bool
> 

Did you test this patch alone? It causes compiling error for all LS1088
boards. You cannot enable CONFIG_SCSI without adding proper macros as
you did in your patch #2. I will squash these two patches for you. No
action required.

York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] armv8: ls1088ardb: Add distro boot support

[York Sun]

On 11/06/2017 10:37 PM, Ashish Kumar wrote:
> Hello York,
> 
> Please see inline.

Please avoid using this "inline" style and follow the list style when
you reply to any email.

> 
> -Original Message-
> From: York Sun 
> Sent: Tuesday, November 07, 2017 2:11 AM
> To: Ashish Kumar ; u-boot@lists.denx.de
> Cc: Zhang Ying 
> Subject: Re: [PATCH v2] armv8: ls1088ardb: Add distro boot support
> 
> On 11/05/2017 11:49 PM, Ashish Kumar wrote:
>> Distro boot support gives flexibility to run distro RFS like Ubuntu's 
>> being deployed from SD card or SATA drive. If it fails to detect 
>> external storage, fall back to qspi/sd boot.
>>
>> Enable this by default in RDB's defconfig by selecting 
>> CONFIG_DISTRO_DEFAULTS
>>
>> Signed-off-by: Ashish Kumar 
>> Signed-off-by: Zhang Ying 
>> ---
>>
>> v2:
>> 1. Fix typo in commit msg
>> 2. Fix indentation
>> 3. Squash patch-set to one
>> 4. Remove USB distro option as USB config are 
>> not supported in sd boot defconfig yet.
> 
> 
> 
>> diff --git a/include/configs/ls1088ardb.h 
>> b/include/configs/ls1088ardb.h index eef9a07..e6bf2b8 100644
>> --- a/include/configs/ls1088ardb.h
>> +++ b/include/configs/ls1088ardb.h
>> @@ -258,40 +258,102 @@
>>  
>>  /* Initial environment variables */
>>  #if defined(CONFIG_QSPI_BOOT)
>> -#undef CONFIG_EXTRA_ENV_SETTINGS
>> -#define CONFIG_EXTRA_ENV_SETTINGS   \
>> -"hwconfig=fsl_ddr:bank_intlv=auto\0"\
>> -"loadaddr=0x9010\0" \
>> -"kernel_addr=0x10\0"\
>> -"ramdisk_addr=0x80\0"   \
>> -"ramdisk_size=0x200\0"  \
>> -"fdt_high=0xa000\0" \
>> -"initrd_high=0x\0"  \
>> -"kernel_start=0x100\0"  \
>> -"kernel_load=0xa000\0"  \
>> -"kernel_size=0x280\0"   \
>> +#define MC_INIT_CMD \
>>  "mcinitcmd=sf probe 0:0;sf read 0x8000 0xA0 0x10;"  \
>> -"sf read 0x8010 0xE0 0x10;" \
>> -"fsl_mc start mc 0x8000 0x8010\0"   \
>> -"mcmemsize=0x7000 \0"
>> +"sf read 0x8010 0xE0 0x10;" \
>> +"fsl_mc start mc 0x8000 0x8010\0"   \
>> +"mcmemsize=0x7000\0"
>>  #elif defined(CONFIG_SD_BOOT)
>> +#define MC_INIT_CMD \
>> +"mcinitcmd=mmcinfo;mmc read 0x8000 0x5000 0x800;"   \
>> +"mmc read 0x8010 0x7000 0x800;" \
>> +"fsl_mc start mc 0x8000 0x8010\0"   \
>> +"mcmemsize=0x7000\0"
>> +#endif
>> +
>>  #undef CONFIG_EXTRA_ENV_SETTINGS
>>  #define CONFIG_EXTRA_ENV_SETTINGS   \
>> +"BOARD=ls1088ardb\0"\
>>  "hwconfig=fsl_ddr:bank_intlv=auto\0"\
>> -"loadaddr=0x9010\0" \
>> -"kernel_addr=0x800\0"   \
>>  "ramdisk_addr=0x80\0"   \
>>  "ramdisk_size=0x200\0"  \
>>  "fdt_high=0xa000\0" \
>>  "initrd_high=0x\0"  \
>> -"kernel_start=0x8000\0" \
>> -"kernel_load=0xa000\0"  \
>> -"kernel_size=0x14000\0" \
>> -"mcinitcmd=mmcinfo;mmc read 0x8000 0x5000 0x800;"   \
>> -"mmc read 0x8010 0x7000 0x800;" \
>> -"fsl_mc start mc 0x8000 0x8010\0"   \
>> -"mcmemsize=0x7000 \0"
>> -
>> +"fdt_addr=0x64f0\0" \
>> +"kernel_addr=0x100\0"   \
>> +"kernel_addr_sd=0x8000\0"   \
>> +"kernel_start=0x58010\0"\
>> +"kernelheader_start=0x58080\0"  \
>> +"scriptaddr=0x8000\0"   \
>> +"scripthdraddr=0x8008\0"\
>> +"fdtheader_addr_r=0x8010\0" \
>> +"kernelheader_addr=0x80\0"  \
>> +"kernelheader_addr_r=0x8020\0"  \
>> +"kernel_addr_r=0x8100\0"\
>> +"kernelheader_size=0x4\0"   \
>> +"fdt_addr_r=0x9000\0"   \
>> +"load_addr=0xa000\0"\
>> +"kernel_size=0x280\0"   \
>> +"kernel_size_sd=0x14000\0"  \
>> +MC_INIT_CMD \
>> +BOOTENV \
> 
> What do you do with BOOTENV? This causes compiling error. Please verify.
> I tested this patch on top of you v6 SD patches.
> 
>>> Sorry, for not highlighting the dependency, this distro patch also depends 
>>> upon the SCSI patch-set.
>And SD boot depends upon the 
> armv8-ls1088-CONFIG_SPI_SPANSON-to-defconfig.patch
> 
>Here is the order for application of these patch
> 
> git am 06-nov-17/0002-armv8-ls1088-Move-CONFIG_SPI_SPANSON-to-defconfig.patch
> Applying: armv8: 

[U-Boot] [PATCH RFC] Makefile: Extend PYTHONPATH rather than overriding it

[Tuomas Tynkkynen]

Currently, if the user has compiled the libfdt Python module from dtc
upstream to a non-default location, it cannot be used because the
'PYTHONPATH=tools' assignment wipes out the user's PYTHONPATH.
Instead, extend PYTHONPATH in the main Makefile instead of overriding it.

Signed-off-by: Tuomas Tynkkynen 
---
 Makefile | 10 --
 scripts/Makefile.spl |  6 ++
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 91f41fea84..58810a4308 100644
--- a/Makefile
+++ b/Makefile
@@ -348,10 +348,16 @@ OBJCOPY   = $(CROSS_COMPILE)objcopy
 OBJDUMP= $(CROSS_COMPILE)objdump
 AWK= awk
 PERL   = perl
-PYTHON ?= python
 DTC?= $(objtree)/scripts/dtc/dtc
 CHECK  = sparse
 
+PYTHON ?= python
+ifeq ($(PYTHONPATH),)
+PYTHONPATH := tools
+else
+PYTHONPATH := $(PYTHONPATH):tools
+endif
+
 CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
  -Wbitwise -Wno-return-void -D__CHECK_ENDIAN__ $(CF)
 
@@ -1380,7 +1386,7 @@ $(timestamp_h): $(srctree)/Makefile FORCE
$(call filechk,timestamp.h)
 
 checkbinman: tools
-   @if ! ( echo 'import libfdt' | ( PYTHONPATH=tools $(PYTHON) )); then \
+   @if ! ( echo 'import libfdt' | $(PYTHON) ); then \
echo >&2; \
echo >&2 '*** binman needs the Python libfdt library.'; \
echo >&2 '*** Either install it on your system, or try:'; \
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
index 49b27ac926..6a370bccf8 100644
--- a/scripts/Makefile.spl
+++ b/scripts/Makefile.spl
@@ -257,13 +257,11 @@ quiet_cmd_fdtgrep = FDTGREP $@
 $(obj)/$(SPL_BIN).dtb: dts/dt.dtb $(objtree)/tools/fdtgrep FORCE
$(call if_changed,fdtgrep)
 
-pythonpath = PYTHONPATH=tools
-
 quiet_cmd_dtocc = DTOC C  $@
-cmd_dtocc = $(pythonpath) $(srctree)/tools/dtoc/dtoc -d $(obj)/$(SPL_BIN).dtb 
-o $@ platdata
+cmd_dtocc = $(srctree)/tools/dtoc/dtoc -d $(obj)/$(SPL_BIN).dtb -o $@ platdata
 
 quiet_cmd_dtoch = DTOC H  $@
-cmd_dtoch = $(pythonpath) $(srctree)/tools/dtoc/dtoc -d $(obj)/$(SPL_BIN).dtb 
-o $@ struct
+cmd_dtoch = $(srctree)/tools/dtoc/dtoc -d $(obj)/$(SPL_BIN).dtb -o $@ struct
 
 quiet_cmd_plat = PLAT$@
 cmd_plat = $(CC) $(c_flags) -c $< -o $@
-- 
2.15.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/5] mmc: omap_hsmmc: Add support for ADMA

[Jean-Jacques Hiblot]

Hi Jaehoon


On 25/09/2017 07:26, Jaehoon Chung wrote:

Hi,

On 09/25/2017 11:15 AM, Simon Glass wrote:

Hi,

On 22 September 2017 at 08:20, Jaehoon Chung  wrote:

On 09/21/2017 11:51 PM, Jean-Jacques Hiblot wrote:

This series enables the ADMA present in some OMAP SOCs.
On a DRA7 the performances when reading from the eMMC go from 18MB/s
to 43MB/s.
Also while were at it, fix some incorrect bit operations

This series applies on top of the series that enables HS200 and UHS mode
"mmc: Add support for HS200 and UHS modes" but should be easy to use on top
of u-boot/master (just remove special handling of the tuning).

This is the first series of 3 which wille enable HS200 and UHS on the omap5
platforms (dra7 and am57).

I didn't have omap board...Can someone check this patchset with omap?
Then it's more clearly.

Possibly, but it should not hold up the series being applied IMO.
People tend to test mainline and it's good to apply these sorts of
things during the merge window so that problems are found during the
RC period.

This patch is depended on "HS200 an UHS modes" patches..
but i have replied with the some comment for them..so i will not apply this 
patches before applying them.

Thank you for merging the "HS200 and UHS modes" series.

Will you take this series also ? and the series actually implementing 
the missing pieces HS200 and UHS for omap5 (mmc: omap5: Add support for 
UHS and HS200 modes​) ?


Thanks,

Jean-Jacques


Best Regards,
Jaehoon Chung


Regards,
Simon







___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] Parallel make issue with helloworld.efi

[Tuomas Tynkkynen]

Hi,

Every now and then I see parallel builds failing, e.g. with
Linksprite_pcDuino3_Nano_defconfig:

  CC  lib/efi_loader/efi_bootmgr.o
  CC  lib/efi_loader/efi_disk.o
  CC  lib/efi_loader/efi_net.o
make[2]: *** No rule to make target 'lib/efi_loader/helloworld.efi', needed by 
'__build'.  Stop.
make[2]: *** Waiting for unfinished jobs
  CC  lib/efi_loader/efi_smbios.o
make[1]: *** [scripts/Makefile.build:425: lib/efi_loader] Error 2
make: *** [Makefile:1279: lib] Error 2

This has been going for a while now (since ~2017.03 or so).
Anybody have ideas on how to express the dependency properly?

Thanks!
- Tuomas
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 5/8] rockchip: dts: rk3328: enable the drivers need by tpl/spl

[Philipp Tomsich]

On Thu, 26 Oct 2017, Kever Yang wrote:


Enable the drivers need by TPL/SPL with 'u-boot,dm-pre-reloc'.

Signed-off-by: Kever Yang 
---

arch/arm/dts/rk3328-evb.dts | 2 ++
arch/arm/dts/rk3328.dtsi| 1 +
2 files changed, 3 insertions(+)

diff --git a/arch/arm/dts/rk3328-evb.dts b/arch/arm/dts/rk3328-evb.dts
index 7ab8c42..a944697 100644
--- a/arch/arm/dts/rk3328-evb.dts
+++ b/arch/arm/dts/rk3328-evb.dts
@@ -44,6 +44,7 @@
};

 {
+   u-boot,dm-pre-reloc;
status = "okay";
};

@@ -60,6 +61,7 @@
};

 {
+   u-boot,dm-pre-reloc;
bus-width = <8>;
cap-mmc-highspeed;
supports-emmc;


These should go into a "...-u-boot.dtsi" (for an example, please refer to
arch/arm/dts/rk3368-lion-u-boot.dtsi). Thanks.


diff --git a/arch/arm/dts/rk3328.dtsi b/arch/arm/dts/rk3328.dtsi
index b821c4c..2a4c492 100644
--- a/arch/arm/dts/rk3328.dtsi
+++ b/arch/arm/dts/rk3328.dtsi
@@ -366,6 +366,7 @@
};

cru: clock-controller@ff44 {
+   u-boot,dm-pre-reloc;
compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon";
reg = <0x0 0xff44 0x0 0x1000>;
rockchip,grf = <>;



Same as above.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 4/8] rockchip: rk3328-evb: add script for atf fit

[Philipp Tomsich]

On Thu, 26 Oct 2017, Kever Yang wrote:


Add a script to generate binaries from bl31.elf, and generate
u-boot.its file for FIT image including u-boot, dtb and atf
binaries.

Signed-off-by: Kever Yang 
---

board/rockchip/evb_rk3328/mk_fit_atf.sh | 108 
1 file changed, 108 insertions(+)
create mode 100755 board/rockchip/evb_rk3328/mk_fit_atf.sh

diff --git a/board/rockchip/evb_rk3328/mk_fit_atf.sh 
b/board/rockchip/evb_rk3328/mk_fit_atf.sh
new file mode 100755
index 000..192c303
--- /dev/null
+++ b/board/rockchip/evb_rk3328/mk_fit_atf.sh
@@ -0,0 +1,108 @@
+#!/bin/sh
+#
+# script to generate FIT image source for rk3399 boards with


Why the RK3399 here (no answer needed ... I know it's copied from the 
rk3399 file)?



+# ARM Trusted Firmware and multiple device trees (given on the command line)
+#
+# usage: $0  [ [&2
+   BL31=/dev/null
+fi
+
+cat << __HEADER_EOF
+/dts-v1/;
+
+/ {
+   description = "Configuration to load ATF before U-Boot";
+   #address-cells = <1>;
+
+   images {
+   uboot@1 {
+   description = "U-Boot (64-bit)";
+   data = /incbin/("u-boot-nodtb.bin");
+   type = "standalone";
+   arch = "arm64";
+   compression = "none";
+   load = <0x0020>;
+   };
+__HEADER_EOF
+
+atf_cnt=1
+
+for l in `readelf -l $BL31 | grep -A1 LOAD | gawk --non-decimal-data \
+   '{if (NR % 2) {printf "%d:0x%x:", $2,$4} else {printf "%d\n", $1}}'`
+do
+   offset=${l%%:*}
+   ll=${l#*:}
+   phy_offset=${ll%:*}
+   filesz=${ll##*:}
+
+   #echo "$offset/$phy_offset/$filesz"
+
+   of=bl31_${phy_offset}.bin
+   dd if=$BL31 of=$of bs=1 skip=$offset count=$filesz
+
+   out_string="${out_string}:${phy_offset}"
+
+   cat << __ATF1_EOF
+   atf@$atf_cnt {
+   description = "ARM Trusted Firmware";
+   data = /incbin/("$of");
+   type = "firmware";
+   arch = "arm64";
+   compression = "none";
+   load = <$phy_offset>;
+__ATF1_EOF
+   if [ "$atf_cnt" -eq 1 ]; then
+   cat << __ATF2_EOF
+   entry = <$phy_offset>;
+__ATF2_EOF
+   fi
+   cat << __ATF3_EOF
+   };
+__ATF3_EOF
+   atf_cnt=$((atf_cnt + 1))
+done
+
+cnt=1
+for dtname in $*
+do
+   cat << __FDT_IMAGE_EOF
+   fdt@$cnt {
+   description = "$(basename $dtname .dtb)";
+   data = /incbin/("$dtname");
+   type = "flat_dt";
+   compression = "none";
+   };
+__FDT_IMAGE_EOF
+   cnt=$((cnt+1))
+done
+
+cat << __CONF_HEADER_EOF
+   };
+   configurations {
+   default = "config@1";
+
+__CONF_HEADER_EOF
+
+cnt=1
+for dtname in $*
+do
+   cat << __CONF_SECTION_EOF
+   config@$cnt {
+   description = "$(basename $dtname .dtb)";
+   firmware = "uboot@1";
+   loadables = "atf@1","atf@2";
+   fdt = "fdt@1";
+   };
+__CONF_SECTION_EOF
+   cnt=$((cnt+1))
+done
+
+cat << __ITS_EOF
+   };
+};
+__ITS_EOF



Given that this is copied verbatim from the evb_rk3399/mk_fit_atf.sh file: 
please merge this and use a common file.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 3/8] rockchip: rk3328: add a link file for tpl

[Philipp Tomsich]

On Thu, 26 Oct 2017, Kever Yang wrote:


Rockchip TPL is not going to use both sram and dram, so
we will use a separate link file.

Signed-off-by: Kever Yang 
---

arch/arm/mach-rockchip/rk3328/u-boot-tpl.lds | 91 
1 file changed, 91 insertions(+)
create mode 100644 arch/arm/mach-rockchip/rk3328/u-boot-tpl.lds

diff --git a/arch/arm/mach-rockchip/rk3328/u-boot-tpl.lds 
b/arch/arm/mach-rockchip/rk3328/u-boot-tpl.lds
new file mode 100644
index 000..3fd50fd
--- /dev/null
+++ b/arch/arm/mach-rockchip/rk3328/u-boot-tpl.lds
@@ -0,0 +1,91 @@
+/*
+ * (C) Copyright 2013
+ * David Feng 
+ *
+ * (C) Copyright 2002
+ * Gary Jennejohn, DENX Software Engineering, 
+ *
+ * (C) Copyright 2010
+ * Texas Instruments, 
+ * Aneesh V 
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+OUTPUT_FORMAT("elf64-littleaarch64", "elf64-littleaarch64", 
"elf64-littleaarch64")
+OUTPUT_ARCH(aarch64)
+ENTRY(_start)
+SECTIONS
+{
+   . = 0x;
+
+   .text : {
+   . = ALIGN(8);
+   *(.__image_copy_start)
+   CPUDIR/start.o (.text*)
+   *(.text*)
+   }
+
+   .rodata : {
+   . = ALIGN(8);
+   *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
+   }
+
+   .data : {
+   . = ALIGN(8);
+   *(.data*)
+   }
+
+   .u_boot_list : {
+   . = ALIGN(8);
+   KEEP(*(SORT(.u_boot_list*)));
+   }
+
+   .image_copy_end : {
+   . = ALIGN(8);
+   *(.__image_copy_end)
+   }
+
+   .end : {
+   . = ALIGN(8);
+   *(.__end)
+   }
+
+   _image_binary_end = .;
+
+   .bss_start (NOLOAD) : {
+   . = ALIGN(8);
+   KEEP(*(.__bss_start));
+   }
+
+   .bss (NOLOAD) : {
+   *(.bss*)
+. = ALIGN(8);
+   }
+
+   .bss_end (NOLOAD) : {
+   KEEP(*(.__bss_end));
+   }
+
+   /DISCARD/ : { *(.dynsym) }
+   /DISCARD/ : { *(.dynstr*) }
+   /DISCARD/ : { *(.dynamic*) }
+   /DISCARD/ : { *(.plt*) }
+   /DISCARD/ : { *(.interp*) }
+   /DISCARD/ : { *(.gnu*) }
+}
+
+#if defined(CONFIG_TPL_MAX_SIZE)
+ASSERT(__image_copy_end - __image_copy_start < (CONFIG_TPL_MAX_SIZE), \
+   "TPL image too big");
+#endif
+
+#if defined(CONFIG_TPL_BSS_MAX_SIZE)
+ASSERT(__bss_end - __bss_start < (CONFIG_TPL_BSS_MAX_SIZE), \
+   "TPL image BSS too big");
+#endif
+
+#if defined(CONFIG_TPL_MAX_FOOTPRINT)
+ASSERT(__bss_end - _start < (CONFIG_TPL_MAX_FOOTPRINT), \
+   "TPL image plus BSS too big");
+#endif



Could this simply be merged with rk3368/boot-tpl.lds and could we use a
common file for both (and any future devices that follow the same boot 
model)?

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 2/8] rockchip: rk3328: add spl board file support

[Philipp Tomsich]

On Thu, 26 Oct 2017, Kever Yang wrote:


rk3328 spl is locate at dram, so do not have strict size limit,
suppose to enable storage media controller driver, load ATF and
U-Boot, then boot into ATF.

Signed-off-by: Kever Yang 
---

arch/arm/mach-rockchip/Makefile   |  1 +
arch/arm/mach-rockchip/rk3328-board-spl.c | 64 +++
2 files changed, 65 insertions(+)
create mode 100644 arch/arm/mach-rockchip/rk3328-board-spl.c

diff --git a/arch/arm/mach-rockchip/Makefile b/arch/arm/mach-rockchip/Makefile
index 49bdd36..56ba760 100644
--- a/arch/arm/mach-rockchip/Makefile
+++ b/arch/arm/mach-rockchip/Makefile
@@ -20,6 +20,7 @@ obj-spl-$(CONFIG_ROCKCHIP_RK3036) += rk3036-board-spl.o
obj-spl-$(CONFIG_ROCKCHIP_RK3188) += rk3188-board-spl.o
obj-spl-$(CONFIG_ROCKCHIP_RK322X) += rk322x-board-spl.o spl-boot-order.o
obj-spl-$(CONFIG_ROCKCHIP_RK3288) += rk3288-board-spl.o
+obj-spl-$(CONFIG_ROCKCHIP_RK3328) += rk3328-board-spl.o
obj-spl-$(CONFIG_ROCKCHIP_RK3368) += rk3368-board-spl.o spl-boot-order.o
obj-spl-$(CONFIG_ROCKCHIP_RK3399) += rk3399-board-spl.o spl-boot-order.o

diff --git a/arch/arm/mach-rockchip/rk3328-board-spl.c 
b/arch/arm/mach-rockchip/rk3328-board-spl.c
new file mode 100644
index 000..1f7274a
--- /dev/null
+++ b/arch/arm/mach-rockchip/rk3328-board-spl.c
@@ -0,0 +1,64 @@
+/*
+ * (C) Copyright 2016 Rockchip Electronics Co., Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+DECLARE_GLOBAL_DATA_PTR;
+
+void board_debug_uart_init(void)
+{
+}
+
+void board_init_f(ulong dummy)
+{
+   struct udevice *dev;
+   int ret;
+
+   ret = spl_early_init();
+   if (ret) {
+   debug("spl_early_init() failed: %d\n", ret);
+   hang();
+   }
+
+   preloader_console_init();
+
+   ret = uclass_get_device(UCLASS_RAM, 0, );
+   if (ret) {
+   debug("DRAM init failed: %d\n", ret);
+   return;
+   }
+}
+
+u32 spl_boot_mode(const u32 boot_device)
+{
+   return MMCSD_MODE_RAW;
+}
+
+u32 spl_boot_device(void)
+{
+   return BOOT_DEVICE_MMC1;
+}
+
+#ifdef CONFIG_SPL_LOAD_FIT
+int board_fit_config_name_match(const char *name)
+{
+   /* Just empty function now - can't decide what to choose */
+   debug("%s: %s\n", __func__, name);
+
+   return 0;
+}
+#endif



This file is identical to rk3368-board-spl.c ... can we merge these two
into a common file that is then used for both devices?
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 8/8] rockchip: rk3328: add config option for TPL/SPL

[Philipp Tomsich]

> Enable SPL_FRAMEWORK and TPL/SPL related base addr and size.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  include/configs/rk3328_common.h | 10 +-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 7/8] rockchip: evb-rk3328: enable defconfig options for TPL/SPL

[Philipp Tomsich]

> Enable driver options for TPL/SPL in evb-rk3328_defconfig.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  configs/evb-rk3328_defconfig | 47 
> +---
>  1 file changed, 44 insertions(+), 3 deletions(-)
> 

Reviewed-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 1/8] rockchip: rk3328: add tpl board file support

[Philipp Tomsich]

On Thu, 26 Oct 2017, Kever Yang wrote:


rk3328 tpl suppose to init ddr sdram and then back to bootrom.

Signed-off-by: Kever Yang 
Acked-by: Philipp Tomsich 
---

arch/arm/mach-rockchip/Makefile   |   1 +
arch/arm/mach-rockchip/rk3328-board-tpl.c | 114 ++
2 files changed, 115 insertions(+)
create mode 100644 arch/arm/mach-rockchip/rk3328-board-tpl.c

diff --git a/arch/arm/mach-rockchip/Makefile b/arch/arm/mach-rockchip/Makefile
index cc3a63e..49bdd36 100644
--- a/arch/arm/mach-rockchip/Makefile
+++ b/arch/arm/mach-rockchip/Makefile
@@ -14,6 +14,7 @@ obj-tpl-$(CONFIG_ROCKCHIP_BROM_HELPER) += bootrom.o 
save_boot_param.o
obj-tpl-$(CONFIG_ROCKCHIP_RK3188) += rk3188-board-tpl.o
obj-tpl-$(CONFIG_ROCKCHIP_RK3368) += rk3368-board-tpl.o
obj-tpl-$(CONFIG_ROCKCHIP_RK322X) += rk322x-board-tpl.o
+obj-tpl-$(CONFIG_ROCKCHIP_RK3328) += rk3328-board-tpl.o

obj-spl-$(CONFIG_ROCKCHIP_RK3036) += rk3036-board-spl.o
obj-spl-$(CONFIG_ROCKCHIP_RK3188) += rk3188-board-spl.o
diff --git a/arch/arm/mach-rockchip/rk3328-board-tpl.c 
b/arch/arm/mach-rockchip/rk3328-board-tpl.c
new file mode 100644
index 000..1c74ff2
--- /dev/null
+++ b/arch/arm/mach-rockchip/rk3328-board-tpl.c
@@ -0,0 +1,114 @@
+/*
+ * (C) Copyright 2016 Rockchip Electronics Co., Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#define CRU_BASE   0xFF44
+#define GRF_BASE   0xFF10
+#define UART2_BASE 0xFF13
+#define STIMER_BASE_ADDR   0xFF1d
+#define CPU_TIMER_BASE (STIMER_BASE_ADDR + 0x20)
+
+void board_timer_init(void)
+{
+   /* Initialize CNTFRQ */
+   __asm__ volatile ("LDR x0,=2400");
+   __asm__ volatile ("MSR CNTFRQ_EL0, x0");


This should be done by setting COUNTER_FREQUENCY and having start.s take
care of this...


+
+   /* Enable STimer1 for core */
+   writel(0x0, CPU_TIMER_BASE + 0x0010);
+   writel(0x, CPU_TIMER_BASE + 0x);
+   writel(0x, CPU_TIMER_BASE + 0x0004);
+   writel(0x1, CPU_TIMER_BASE + 0x0010);


Can we use the DM timer (same as for the RK3368) and not initialise the
secure timer here?  We should keep U-Boot and this initialisation 
separate, as ATF will take care of this (and U-Boot can just use a regular

tick timer).


+}
+
+void board_debug_uart_init(void)
+{
+   struct rk3328_grf_regs * const grf = (void *)GRF_BASE;
+   struct rk_uart * const uart = (void *)UART2_BASE;
+
+   /* uart_sel_clk default select 24MHz */
+   writel((3 << (8 + 16)) | (2 << 8), CRU_BASE + 0x148);
+
+   /* init uart baud rate 150 */
+   writel(0x83, >lcr);
+   writel(0x1, >rbr);
+   writel(0x3, >lcr);
+
+   /* Enable early UART2 */
+   rk_clrsetreg(>com_iomux,
+IOMUX_SEL_UART2_MASK,
+IOMUX_SEL_UART2_M1 << IOMUX_SEL_UART2_SHIFT);
+   rk_clrsetreg(>gpio2a_iomux,
+GPIO2A0_SEL_MASK,
+GPIO2A0_UART2_TX_M1 << GPIO2A0_SEL_SHIFT);
+   rk_clrsetreg(>gpio2a_iomux,
+GPIO2A1_SEL_MASK,
+GPIO2A1_UART2_RX_M1 << GPIO2A1_SEL_SHIFT);
+
+   /* enable FIFO */
+   writel(0x1, >sfe);
+}
+
+void board_return_to_bootrom(void)
+{
+   back_to_bootrom();
+}
+
+u32 spl_boot_device(void)
+{
+   return BOOT_DEVICE_BOOTROM;
+}
+
+
+void board_init_f(ulong dummy)
+{
+   struct udevice *dev;
+   int ret;
+
+#define EARLY_UART
+#ifdef EARLY_UART
+   debug_uart_init();
+   printascii("U-Boot TPL board init\n");
+#endif
+
+   board_timer_init();


If we use the DM timer, we don't have to do this any longer (see the 
RK3368 TPL support code).



+
+   ret = spl_early_init();
+   if (ret) {
+   printf("spl_early_init() failed: %d\n", ret);
+   hang();
+   }
+
+   ret = uclass_get_device(UCLASS_RAM, 0, );
+   if (ret) {
+   printf("DRAM init failed: %d\n", ret);
+   return;
+   }
+}


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 6/8] rockchip: Kconfig: enable TPL/SPL support for rk3328

[Philipp Tomsich]

> Enable TPL/SPL support and some related option in Kconfig.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  arch/arm/mach-rockchip/Kconfig | 14 +-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 8/8] rockchip: rk3328: add config option for TPL/SPL

[Philipp Tomsich]

> Enable SPL_FRAMEWORK and TPL/SPL related base addr and size.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  include/configs/rk3328_common.h | 10 +-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 6/8] rockchip: Kconfig: enable TPL/SPL support for rk3328

[Philipp Tomsich]

> Enable TPL/SPL support and some related option in Kconfig.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  arch/arm/mach-rockchip/Kconfig | 14 +-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 3/8] rockchip: rk3328: add a link file for tpl

[Philipp Tomsich]

> Rockchip TPL is not going to use both sram and dram, so
> we will use a separate link file.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  arch/arm/mach-rockchip/rk3328/u-boot-tpl.lds | 91 
> 
>  1 file changed, 91 insertions(+)
>  create mode 100644 arch/arm/mach-rockchip/rk3328/u-boot-tpl.lds
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 7/8] rockchip: evb-rk3328: enable defconfig options for TPL/SPL

[Philipp Tomsich]

> Enable driver options for TPL/SPL in evb-rk3328_defconfig.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  configs/evb-rk3328_defconfig | 47 
> +---
>  1 file changed, 44 insertions(+), 3 deletions(-)
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 5/8] rockchip: dts: rk3328: enable the drivers need by tpl/spl

[Philipp Tomsich]

> Enable the drivers need by TPL/SPL with 'u-boot,dm-pre-reloc'.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  arch/arm/dts/rk3328-evb.dts | 2 ++
>  arch/arm/dts/rk3328.dtsi| 1 +
>  2 files changed, 3 insertions(+)
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 2/8] rockchip: rk3328: add spl board file support

[Philipp Tomsich]

> rk3328 spl is locate at dram, so do not have strict size limit,
> suppose to enable storage media controller driver, load ATF and
> U-Boot, then boot into ATF.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  arch/arm/mach-rockchip/Makefile   |  1 +
>  arch/arm/mach-rockchip/rk3328-board-spl.c | 64 
> +++
>  2 files changed, 65 insertions(+)
>  create mode 100644 arch/arm/mach-rockchip/rk3328-board-spl.c
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 4/8] rockchip: rk3328-evb: add script for atf fit

[Philipp Tomsich]

> Add a script to generate binaries from bl31.elf, and generate
> u-boot.its file for FIT image including u-boot, dtb and atf
> binaries.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  board/rockchip/evb_rk3328/mk_fit_atf.sh | 108 
> 
>  1 file changed, 108 insertions(+)
>  create mode 100755 board/rockchip/evb_rk3328/mk_fit_atf.sh
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 1/8] rockchip: rk3328: add tpl board file support

[Philipp Tomsich]

> rk3328 tpl suppose to init ddr sdram and then back to bootrom.
> 
> Signed-off-by: Kever Yang 
> ---
> 
>  arch/arm/mach-rockchip/Makefile   |   1 +
>  arch/arm/mach-rockchip/rk3328-board-tpl.c | 114 
> ++
>  2 files changed, 115 insertions(+)
>  create mode 100644 arch/arm/mach-rockchip/rk3328-board-tpl.c
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 2/2] rockchip: clock: update sysreset driver bingding

[Philipp Tomsich]

> Using priv for new sysreset driver binding.
> 
> Signed-off-by: Kever Yang 
> Acked-by: Philipp Tomsich 
> Acked-by: Philipp Tomsich 
> Reviewed-by: Philipp Tomsich 
> ---
> 
> Changes in v3:
> - do not init priv if driver bind fail
> 
> Changes in v2:
> - use udev priv member instead of driver_data
> 
>  drivers/clk/rockchip/clk_rk3036.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3128.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3188.c | 17 ++---
>  drivers/clk/rockchip/clk_rk322x.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3288.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3328.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3368.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3399.c | 17 ++---
>  drivers/clk/rockchip/clk_rv1108.c | 17 ++---
>  9 files changed, 126 insertions(+), 27 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 1/2] rockchip: sysreset: merge into one common driver

[Philipp Tomsich]

> Use a common driver for all Rockchip SOC instead of one for each SoC.
> Use driver_data for reg offset.
> 
> Signed-off-by: Kever Yang 
> Acked-by: Philipp Tomsich 
> Acked-by: Philipp Tomsich 
> Reviewed-by: Philipp Tomsich 
> ---
> 
> Changes in v3: None
> Changes in v2:
> - use udev priv member instead of driver_data
> 
>  arch/arm/include/asm/arch-rockchip/clock.h |  5 +++
>  drivers/sysreset/Makefile  | 12 +-
>  drivers/sysreset/sysreset_rk3036.c | 45 --
>  drivers/sysreset/sysreset_rk3128.c | 45 --
>  drivers/sysreset/sysreset_rk3188.c | 62 
> --
>  drivers/sysreset/sysreset_rk322x.c | 45 --
>  drivers/sysreset/sysreset_rk3288.c | 47 --
>  drivers/sysreset/sysreset_rk3328.c | 45 --
>  drivers/sysreset/sysreset_rk3368.c | 62 
> --
>  drivers/sysreset/sysreset_rk3399.c | 45 --
>  drivers/sysreset/sysreset_rockchip.c   | 47 ++
>  drivers/sysreset/sysreset_rv1108.c | 46 --
>  12 files changed, 53 insertions(+), 453 deletions(-)
>  delete mode 100644 drivers/sysreset/sysreset_rk3036.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3128.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3188.c
>  delete mode 100644 drivers/sysreset/sysreset_rk322x.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3288.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3328.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3368.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3399.c
>  create mode 100644 drivers/sysreset/sysreset_rockchip.c
>  delete mode 100644 drivers/sysreset/sysreset_rv1108.c
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts

[Fabio Estevam]

Hi Vincent,

On Tue, Nov 7, 2017 at 11:26 AM, Vincent Prince
 wrote:
> Hi all,
>
> It's my first patch contribution, do I need to do anything more ?

Your patch looks good.

Maybe Stefano can apply it for 2017.11.

Thanks
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 17/18] rockchip: rk3188: move CONFIG_SPL_* entries from rk3188_common.h to Kconfig

[Philipp Tomsich]

> There still are a few CONFIG_SPL_* options selected using defines from
> rk3188_common.h instead of via Kconfig.  This migrates those over to
> Kconfig.
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/mach-rockchip/Kconfig  | 7 ++-
>  include/configs/rk3188_common.h | 6 --
>  2 files changed, 6 insertions(+), 7 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 15/18] rockchip: rk3188: use boot0 hook to load up SPL in 2 steps

[Philipp Tomsich]

> For the RK3188, the BROM will attempt to load up the first stage
> image (SPL for the RK3188) in two steps: first 1KB to offset 0x800
> in the SRAM and then the remainder to offset 0xc00 in the SRAM.
> It always enters at 0x804, though.
> 
> With this changeset, the RK3188 boot removes the TPL (stub) stage and
> builds a single SPL binary that utilizes the early back-to-bootrom via
> the boot0-hook.
> 
> Consequently, the passing of the saved boot params via pmu->os_reg[2]
> is also removed.
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4:
> - after merging the 'back-to-bootrom' series with the 'boot0-hook'
>   series, this drops the TPL stub and builds only a single SPL image
>   that uses the 'early back-to-bootrom' logic originally implemented
>   by Pawel for the RK3066.
> - changes the SPL_STACK_BASE to +0x800 (from +0x804), as the boot0
>   hook already reserves the space for the SPL magic (previously
>   inserted by mkimage)
> 
> Changes in v3: None
> Changes in v2:
> - [added in v2] chain back_to_bootrom calls for SPL, first returning
>   to the TPL (using the same mechanism) and the to the BROM from the
>   TPL
> 
>  arch/arm/mach-rockchip/Kconfig|  2 +-
>  arch/arm/mach-rockchip/Makefile   |  1 -
>  arch/arm/mach-rockchip/rk3188-board-spl.c | 10 
>  arch/arm/mach-rockchip/rk3188-board-tpl.c | 86 
> ---
>  doc/README.rockchip   | 10 ++--
>  include/configs/rk3188_common.h   | 12 ++---
>  6 files changed, 9 insertions(+), 112 deletions(-)
>  delete mode 100644 arch/arm/mach-rockchip/rk3188-board-tpl.c
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 13/18] arm: provide a PCS-compliant setjmp implementation

[Philipp Tomsich]

> The previous setjmp-implementation (as a static inline function that
> contained an 'asm volatile' sequence) was extremely fragile: (some
> versions of) GCC optimised the set of registers.  One critical example
> was the removal of 'r9' from the clobber list, if -ffixed-reg9 was
> supplied.
> 
> To increase robustness and ensure PCS-compliant behaviour, the setjmp
> and longjmp implementation are now in assembly and closely match what
> one would expect to find in a libc implementation.
> 
> Signed-off-by: Philipp Tomsich 
> Tested-by: Andy Yan 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - converted setjmp/longjmp from inline-assembly to separate .S files
>   to improve predicatability if emitted code
> 
> Changes in v2: None
> 
>  arch/arm/include/asm/setjmp.h | 94 
> ++-
>  arch/arm/lib/Makefile |  6 +++
>  arch/arm/lib/setjmp.S | 37 +
>  arch/arm/lib/setjmp_aarch64.S | 42 +++
>  4 files changed, 98 insertions(+), 81 deletions(-)
>  create mode 100644 arch/arm/lib/setjmp.S
>  create mode 100644 arch/arm/lib/setjmp_aarch64.S
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 11/18] arm: make save_boot_params_ret prototype visible for AArch64

[Philipp Tomsich]

> The save_boot_params_ret() prototype (for those of us, that have a
> valid SP on entry and can implement save_boot_params() in C), was
> previously only defined for !defined(CONFIG_ARM64).
> 
> This moves the declaration to a common block to ensure the prototype
> is available to everyone that might need it.
> 
> Signed-off-by: Philipp Tomsich 
> Tested-by: Andy Yan 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/system.h | 62 
> +--
>  1 file changed, 31 insertions(+), 31 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 16/18] rockchip: back-to-bootrom: allow passing a cmd to the bootrom

[Philipp Tomsich]

> The BROM supports forcing it to enter download-mode, if an appropriate
> result/cmd-word is returned to it.  There already is a series to
> support this in review, so this prepares the (newly C-version) of the
> back-to-bootrom code to accept a cmd to passed on to the BROM.
> 
> All the existing call-sites are adjusted to match the changed function
> signature.
> 
> Signed-off-by: Philipp Tomsich 
> Tested-by: Andy Yan 
> ---
> 
> Changes in v5: None
> Changes in v4:
> - no longer updates rk3188-board-tpl.c (as we have just removed it
>   in an earlier commit)
> 
> Changes in v3: None
> Changes in v2:
> - also covers the RK3188 (which I had originally missed)
> 
>  arch/arm/include/asm/arch-rockchip/bootrom.h | 5 -
>  arch/arm/mach-rockchip/bootrom.c | 4 ++--
>  arch/arm/mach-rockchip/rk3036-board-spl.c| 2 +-
>  arch/arm/mach-rockchip/rk3188-board-spl.c| 4 ++--
>  arch/arm/mach-rockchip/rk322x-board-spl.c| 2 +-
>  arch/arm/mach-rockchip/rk3288-board-spl.c| 4 ++--
>  arch/arm/mach-rockchip/rk3288-board-tpl.c| 2 +-
>  arch/arm/mach-rockchip/rk3368-board-tpl.c| 2 +-
>  arch/arm/mach-rockchip/rk3399-board-spl.c| 2 +-
>  9 files changed, 15 insertions(+), 12 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 12/18] arm: mark save_boot_params_ret as a function

[Philipp Tomsich]

> As no '.type' was set for save_boot_params_ret in start.S, binutils
> did not track whether it was emitted as A32 or T32.  By properly
> marking save_boot_params_ret as a potential function entry, we can
> make sure that the compiler will insert the appropriate instructions
> for branching to save_boot_params_ret both for call-sites emitted as
> A32 and T32.
> 
> Reported-by: Andy Yan 
> Signed-off-by: Philipp Tomsich 
> Tested-by: Andy Yan 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - tracked the root-cause why no interwork branch was emitted and fixed
>   it using a '.type'-directive in start.S to mark save_boot_params_ret
>   as a (possible) function-entry.
> 
> Changes in v2: None
> 
>  arch/arm/cpu/armv7/start.S | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 14/18] rockchip: back-to-bootrom: replace assembly-implementation with C-code

[Philipp Tomsich]

> The back-to-bootrom implementation for Rockchip has always relied on
> the stack-pointer being valid on entry, so there was little reason to
> have this as an assembly implementation.
> 
> This provides a new C-only implementation of save_boot_params and
> back_to_bootrom (relying on setjmp/longjmp) and removes the older
> assembly-only implementation.
> 
> Signed-off-by: Philipp Tomsich 
> Tested-by: Andy Yan 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-rockchip/bootrom.h | 27 ---
>  arch/arm/mach-rockchip/Makefile  |  4 +-
>  arch/arm/mach-rockchip/bootrom.c | 52 -
>  arch/arm/mach-rockchip/save_boot_param.S | 69 
> 
>  4 files changed, 73 insertions(+), 79 deletions(-)
>  delete mode 100644 arch/arm/mach-rockchip/save_boot_param.S
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 10/18] rockchip: boot0 hook: support early return for RK3188/RK3066-style BROM

[Philipp Tomsich]

> Some Rockchip BROM versions (e.g. the RK3188 and RK3066) first read 1KB data
> from NAND into SRAM and executes it. Then, following a return to bootrom, the
> BROM loads additional code to SRAM (not overwriting the first block read) and
> reenters at the same address as the first time.
> 
> To support booting either a TPL (on the RK3066) or SPL (on the RK3188) using
> this model of having to count entries, this commit adds code to the boot0
> hook to track the number of entries and handle them accordingly.
> 
> Signed-off-by: Philipp Tomsich 
> Signed-off-by: Paweł Jarosz 
> Tested-by: Andy Yan 
> ---
> 
> Changes in v5:
> - set return value to 0 before returning to the BROM
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-rockchip/boot0.h | 25 +++--
>  arch/arm/mach-rockchip/Kconfig | 28 
>  2 files changed, 47 insertions(+), 6 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 2/2] rockchip: clock: update sysreset driver bingding

[Philipp Tomsich]

> Using priv for new sysreset driver binding.
> 
> Signed-off-by: Kever Yang 
> Acked-by: Philipp Tomsich 
> Acked-by: Philipp Tomsich 
> ---
> 
> Changes in v3:
> - do not init priv if driver bind fail
> 
> Changes in v2:
> - use udev priv member instead of driver_data
> 
>  drivers/clk/rockchip/clk_rk3036.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3128.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3188.c | 17 ++---
>  drivers/clk/rockchip/clk_rk322x.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3288.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3328.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3368.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3399.c | 17 ++---
>  drivers/clk/rockchip/clk_rv1108.c | 17 ++---
>  9 files changed, 126 insertions(+), 27 deletions(-)
> 

Reviewed-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 1/2] rockchip: sysreset: merge into one common driver

[Philipp Tomsich]

> Use a common driver for all Rockchip SOC instead of one for each SoC.
> Use driver_data for reg offset.
> 
> Signed-off-by: Kever Yang 
> Acked-by: Philipp Tomsich 
> Acked-by: Philipp Tomsich 
> ---
> 
> Changes in v3: None
> Changes in v2:
> - use udev priv member instead of driver_data
> 
>  arch/arm/include/asm/arch-rockchip/clock.h |  5 +++
>  drivers/sysreset/Makefile  | 12 +-
>  drivers/sysreset/sysreset_rk3036.c | 45 --
>  drivers/sysreset/sysreset_rk3128.c | 45 --
>  drivers/sysreset/sysreset_rk3188.c | 62 
> --
>  drivers/sysreset/sysreset_rk322x.c | 45 --
>  drivers/sysreset/sysreset_rk3288.c | 47 --
>  drivers/sysreset/sysreset_rk3328.c | 45 --
>  drivers/sysreset/sysreset_rk3368.c | 62 
> --
>  drivers/sysreset/sysreset_rk3399.c | 45 --
>  drivers/sysreset/sysreset_rockchip.c   | 47 ++
>  drivers/sysreset/sysreset_rv1108.c | 46 --
>  12 files changed, 53 insertions(+), 453 deletions(-)
>  delete mode 100644 drivers/sysreset/sysreset_rk3036.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3128.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3188.c
>  delete mode 100644 drivers/sysreset/sysreset_rk322x.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3288.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3328.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3368.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3399.c
>  create mode 100644 drivers/sysreset/sysreset_rockchip.c
>  delete mode 100644 drivers/sysreset/sysreset_rv1108.c
> 

Reviewed-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 18/18] rockchip: mkimage: remove unused code-paths (spl_boot0 is now implied)

[Philipp Tomsich]

> With all targets converted to generate prepadded images, this removes
> the spl_boot0 field from our config structure and removes the unused
> code-path (for images that are not prepadded): i.e. spl_boot0 is now
> implied as 'true' and the code is specialised by removing the other
> case.
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  tools/rkcommon.c | 45 ++---
>  1 file changed, 14 insertions(+), 31 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 09/18] bcm281xx: boot0 hook: adjust to unified boot0 semantics

[Philipp Tomsich]

> This updates the BCM281xx boot0-hook to the updated boot0 semantics
> by emitting _start and the vector table before the boot0 hook (as
> was the case before).
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-bcm281xx/boot0.h | 2 ++
>  1 file changed, 2 insertions(+)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 07/18] socfpga: boot0 hook: adjust to unified boot0 semantics

[Philipp Tomsich]

> With the updated boot0 semantics (i.e. giving the boot0-hook control
> over when and where the vector table is emitted), the boot0-hook for
> the socfpga needs to be adjusted.
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/mach-socfpga/include/mach/boot0.h | 3 +++
>  1 file changed, 3 insertions(+)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 05/18] rockchip: rk3288: use aligned address for SPL_TEXT_BASE

[Philipp Tomsich]

> From: Kever Yang 
> 
> After we use boot0 hook, we can use offset '000' instead of '004' as
> SPL_TEXT_BASE.
> 
> Signed-off-by: Kever Yang 
> [Updated tag in commit summary:]
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  include/configs/rk3288_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 06/18] rockchip: rk3036: use aligned address for SPL_TEXT_BASE

[Philipp Tomsich]

> With the boot0-hook inserting the additional padding to receive our
> SPL magic, the SPL_TEXT_BASE can be aligned again.
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  include/configs/rk3036_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 04/18] rockchip: mkimage: use spl_boot0 for all Rockchip SoCs

[Philipp Tomsich]

> From: Kever Yang 
> 
> Enable the spl_boot0 in SPL and use the pre-padding TAG memory,
> the mkimage do not need to pad it but only need to replace the value
> with correct TAG value.
> 
> Signed-off-by: Kever Yang 
> [Updated:]
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  tools/rkcommon.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 02/18] rockchip: boot0: align to 0x20 for armv7 '_start'

[Philipp Tomsich]

> From: Kever Yang 
> 
> The '_start' is using as vector table base address, and will write
> to VBAR register, so it needs to be aligned to 0x20 for armv7.
> 
> Signed-off-by: Kever Yang 
> [Updated to current code base:]
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-rockchip/boot0.h | 14 --
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 08/18] bcm235xx: boot0 hook: adjust to unified boot0 semantics

[Philipp Tomsich]

> This updates the BCM235xx boot0-hook to the updated boot0 semantics
> by emitting _start and the vector table before the boot0 hook (as
> was the case before).
> 
> Signed-off-by: Philipp Tomsich 
> 
> Version-changes: 5
> - ran 'whitespace-cleanup'
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-bcm235xx/boot0.h | 2 ++
>  1 file changed, 2 insertions(+)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 03/18] rockchip: enable boot0-hook for all Rockchip SoCs

[Philipp Tomsich]

> Rockchip SoCs bootrom design is like this:
> - First 2KB or 4KB internal memory is for bootrom stack and heap;
> - Then the first 4-byte suppose to be a TAG like 'RK33';
> - The the following memory address end with '0004' is the first
>   instruction load and running by bootrom;
> 
> Let's use the boot0 hook to reserve the first 4-byte tag for all
> the Rockchip SoCs.
> 
> Signed-off-by: Philipp Tomsich 
> [Commit message:]
> Signed-off-by: Kever Yang 
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/Kconfig   | 1 +
>  arch/arm/mach-rockchip/Kconfig | 2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v5, 01/18] arm: boot0 hook: move boot0 hook before '_start'

[Philipp Tomsich]

> The boot0 hook on ARM does not insert its payload before the vector
> table. This is both a mismatch with thec comment above it and
> contradict usage of the boot0 hook on ARM64.
> 
> To fix this (and unify the semantics for ARM and ARM64), we change the
> boot0-hook semantics on ARM to match those on ARM64:
>   (1) if a boot0-hook is present it is inserted at the start of
>   the image
>   (2) if a boot0-hook is present, emitting the ARM vector table
>   (and the _start) symbol are suppressed in vectors.S and
>   the boot0-hook has full control over where and when it
>   wants to emit these
> 
> Signed-off-by: Philipp Tomsich 
> ---
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-rockchip/boot0.h |  1 -
>  arch/arm/lib/vectors.S | 54 
> +++---
>  2 files changed, 35 insertions(+), 20 deletions(-)
> 

Applied to u-boot-rockchip/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] Include FSP in u-boot.rom

[vnktux]

Hi guys,

I need to generate a u-boot.rom image of exactly 8Mb that include only fsp.bin 
and vga.bin. The reason is because in my company we will use an Intel tool that 
already contain descriptor and intel ME for our platform.
Has been already 1 week that I am struggling to do this, if I specify the build 
command  BUILD_ROM=y u-boot keep asking for descriptor, fsp and me.bin. And 
anyway if I give all the blobs in imput the building doesnt succed and it 
complain that the rom file is bigger than my flash (which is impossible since 
fsp=1.5Mb, vga=400Kb, me=8Mb, and the selected flash size is 16Mb).
Can someone please help me with this?

Best regards,
Vincenzo

Sent with [ProtonMail](https://protonmail.com) Secure Email.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, RESEND, 2/2] rockchip: clk: add device_bind_driver_to_node for reset driver

[Philipp Tomsich]

> From: Elaine Zhang 
> 
> all rockchip socs add device_bind_driver_to_node,
> to bound device rockchip reset to clock-controller.
> 
> Signed-off-by: Elaine Zhang 
> Signed-off-by: Kever Yang 
> ---
> 
>  arch/arm/include/asm/arch-rockchip/clock.h |  6 +
>  drivers/clk/rockchip/clk_rk3036.c  | 15 -
>  drivers/clk/rockchip/clk_rk3128.c  | 15 -
>  drivers/clk/rockchip/clk_rk3188.c  | 15 -
>  drivers/clk/rockchip/clk_rk322x.c  | 15 -
>  drivers/clk/rockchip/clk_rk3288.c  | 15 -
>  drivers/clk/rockchip/clk_rk3328.c  | 15 -
>  drivers/clk/rockchip/clk_rk3368.c  | 15 -
>  drivers/clk/rockchip/clk_rk3399.c  | 36 
> +-
>  drivers/clk/rockchip/clk_rv1108.c  | 15 -
>  10 files changed, 153 insertions(+), 9 deletions(-)
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 2/2] rockchip: clock: update sysreset driver bingding

[Philipp Tomsich]

> Using priv for new sysreset driver binding.
> 
> Signed-off-by: Kever Yang 
> Acked-by: Philipp Tomsich 
> ---
> 
> Changes in v3:
> - do not init priv if driver bind fail
> 
> Changes in v2:
> - use udev priv member instead of driver_data
> 
>  drivers/clk/rockchip/clk_rk3036.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3128.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3188.c | 17 ++---
>  drivers/clk/rockchip/clk_rk322x.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3288.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3328.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3368.c | 17 ++---
>  drivers/clk/rockchip/clk_rk3399.c | 17 ++---
>  drivers/clk/rockchip/clk_rv1108.c | 17 ++---
>  9 files changed, 126 insertions(+), 27 deletions(-)
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 1/2] rockchip: sysreset: merge into one common driver

[Philipp Tomsich]

> Use a common driver for all Rockchip SOC instead of one for each SoC.
> Use driver_data for reg offset.
> 
> Signed-off-by: Kever Yang 
> Acked-by: Philipp Tomsich 
> ---
> 
> Changes in v3: None
> Changes in v2:
> - use udev priv member instead of driver_data
> 
>  arch/arm/include/asm/arch-rockchip/clock.h |  5 +++
>  drivers/sysreset/Makefile  | 12 +-
>  drivers/sysreset/sysreset_rk3036.c | 45 --
>  drivers/sysreset/sysreset_rk3128.c | 45 --
>  drivers/sysreset/sysreset_rk3188.c | 62 
> --
>  drivers/sysreset/sysreset_rk322x.c | 45 --
>  drivers/sysreset/sysreset_rk3288.c | 47 --
>  drivers/sysreset/sysreset_rk3328.c | 45 --
>  drivers/sysreset/sysreset_rk3368.c | 62 
> --
>  drivers/sysreset/sysreset_rk3399.c | 45 --
>  drivers/sysreset/sysreset_rockchip.c   | 47 ++
>  drivers/sysreset/sysreset_rv1108.c | 46 --
>  12 files changed, 53 insertions(+), 453 deletions(-)
>  delete mode 100644 drivers/sysreset/sysreset_rk3036.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3128.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3188.c
>  delete mode 100644 drivers/sysreset/sysreset_rk322x.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3288.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3328.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3368.c
>  delete mode 100644 drivers/sysreset/sysreset_rk3399.c
>  create mode 100644 drivers/sysreset/sysreset_rockchip.c
>  delete mode 100644 drivers/sysreset/sysreset_rv1108.c
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, RESEND, 1/2] drivers/reset: support rockchip reset drivers

[Philipp Tomsich]

> From: Elaine Zhang 
> 
> Create driver to support all Rockchip SoCs soft reset.
> Example of usage:
> i2c driver:
>   ret = reset_get_by_name(dev, "i2c", _ctl);
>   if (ret) {
>   error("reset_get_by_name() failed: %d\n", ret);
>   }
> 
>   reset_assert(_ctl);
>   udelay(50);
>   reset_deassert(_ctl);
> 
> i2c dts node:
> resets = < SRST_P_I2C1>, < SRST_I2C1>;
> reset-names = "p_i2c", "i2c";
> 
> Signed-off-by: Elaine Zhang 
> Signed-off-by: Kever Yang 
> ---
> 
>  drivers/reset/Kconfig  |   8 
>  drivers/reset/Makefile |   1 +
>  drivers/reset/reset-rockchip.c | 104 
> +
>  3 files changed, 113 insertions(+)
>  create mode 100644 drivers/reset/reset-rockchip.c
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [RFC] efi_loader: frame buffers in EFI GOP and DM_VIDEO

[Simon Glass]

Hi Heinrich,

On 6 November 2017 at 18:36, Rob Clark  wrote:
> On Wed, Oct 25, 2017 at 3:45 PM, Heinrich Schuchardt  
> wrote:
>> Hello Alex, hello Simon,
>>
>> I have just been reading through efi_gop and video_uclass.c and there seems
>> to be something missing in the support of video modes.
>>
>> U-Boot configuration knows the following color models:
>>
>> 16-color
>> 256-color
>> 32k (1:5:5:5)
>> 64k (5:6:5)
>> 16.8M (8:8:8)
>>
>> In lib/efi_loader/efi_gop.c I only found
>>
>> VIDEO_BPP32
>> VIDEO_BPP16
>> Patch a812241091ce efi_loader: Add DM_VIDEO support (Alexander Graf)
>>
>> Shouldn't gop_blt differentiate between 32k and 64k color mode?
>> Unfortunately video_uclass.c cannot tell the difference!
>> What about 4 and 8 bit modes?
>>
>> When I look at the coding in video_uclass.c, function video_clear it seems
>> that this only correctly supports 32bit and 8bit mode.
>> Patch 1acafc73bfc7 dm: video: Add a video uclass (Simon Glass)
>>
>> Shouldn't 4, 15 and 16 bit modes be added here?
>>
>
> (apologies for being a bit behind on u-boot mails but been busy on
> other upstreams)
>
> iirc UEFI only supports a subset of what u-boot supports (and I think
> it is worse because u-boot doesn't do a good job of differentiating
> between different component orders of a given bpp).. but we could
> support more hw by not with the path that doesn't expose the scanout
> buffer address and only supports blitting to scanout buffer (and doing
> conversion as part of the blit).  I think it is mostly a matter of
> someone who has this hw writing and testing the appropriate blit
> paths..

Yes that seems right to me. I focussed originally on things I could
try on hardware, but we can do this with tests.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts

[Vincent Prince]

Hi all,

It's my first patch contribution, do I need to do anything more ?

Best regards,
Vincent

2017-10-26 13:52 GMT+02:00 Stefan Agner :

>
>
> On 26.10.2017 13:25, Lukasz Majewski wrote:
> > Hi Vincent,
> >
> >> This prevents board resets when calling sdp command on boards which
> >> have a watchdog.
> >>
> >> Signed-off-by: Vincent Prince 
> >> ---
> >>  drivers/usb/gadget/f_sdp.c | 4 
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
> >> index 0fae66b..c3eba6d 100644
> >> --- a/drivers/usb/gadget/f_sdp.c
> >> +++ b/drivers/usb/gadget/f_sdp.c
> >> @@ -32,6 +32,7 @@
> >>  #include 
> >>  #include 
> >>  #include 
> >> +#include 
> >>
> >>  #define HID_REPORT_ID_MASK  0x00ff
> >>
> >> @@ -602,6 +603,8 @@ int sdp_init(int controller_index)
> >>  puts("\rCTRL+C - Operation aborted.\n");
> >>  return 1;
> >>  }
> >> +
> >> +WATCHDOG_RESET();
> >>  usb_gadget_handle_interrupts(controller_index);
> >>  }
> >>
> >> @@ -712,6 +715,7 @@ void sdp_handle(int controller_index)
> >>  return;
> >>  }
> >>
> >> +WATCHDOG_RESET();
> >>  usb_gadget_handle_interrupts(controller_index);
> >>
> >>  sdp_handle_in_ep();
> > Reviewed-by: Lukasz Majewski 
>
> Thanks for the patch! Looks good to me too.
> Reviewed-by: Stefan Agner 
>
> Best regards,
> Stefan
>
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] sunxi: SATA link timeout fix

[Jagan Teki]

On Sun, Nov 5, 2017 at 7:11 PM, Werner Böllmann
 wrote:
> After updating u-boot from v2016.01 to 2017.09 i got a "SATA link 0 timeout." 
> on my Cubietruck board.
> I tracked this down to this patch.
>
> http://git.denx.de/?p=u-boot.git;a=commitdiff_plain;h=9fbb0c3aa49f4604b0342cb527a6bd099f92eaeb.

Look like mdelay missing while moving to board file.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v4 7/7] ls1088a: Add VID support for QDS and RDB platforms

[Rajesh Bhagat]

This patch adds the support for VID on LS1088AQDS and LS1088ARDB systems.
It reads the fusesr register and changes the VDD accordingly by adjusting the
voltage via LTC3882 regulator.

This patch also takes care of the special case of 0.9V VDD is present in
fusesr register. In that case,it also changes the SERDES voltage by disabling
the SERDES, changing the SVDD and then re-enabling SERDES.

Signed-off-by: Raghav Dogra 
Signed-off-by: Ashish Kumar 
Signed-off-by: Amrita Kumari 
Signed-off-by: Rajesh Bhagat 
---
Changes in v4:
 None

Changes in v3:
 Restructured LS1088A VID support to use common VID driver
 Removed APIs getLSB/MSB and used bit operations.

Changes in v2:
 Checkpatch errors fixed

 board/freescale/ls1088a/ls1088a.c | 120 ++
 include/configs/ls1088aqds.h  |  13 +
 include/configs/ls1088ardb.h  |  14 +
 3 files changed, 147 insertions(+)

diff --git a/board/freescale/ls1088a/ls1088a.c 
b/board/freescale/ls1088a/ls1088a.c
index 96d9ae7..8af7d33 100644
--- a/board/freescale/ls1088a/ls1088a.c
+++ b/board/freescale/ls1088a/ls1088a.c
@@ -18,9 +18,13 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include "../common/qixis.h"
 #include "ls1088a_qixis.h"
+#include "../common/vid.h"
+#include 
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -295,6 +299,120 @@ void board_retimer_init(void)
/*return the default channel*/
select_i2c_ch_pca9547(I2C_MUX_CH_DEFAULT);
 }
+int i2c_multiplexer_select_vid_channel(u8 channel)
+{
+   return select_i2c_ch_pca9547(channel);
+}
+
+#ifdef CONFIG_TARGET_LS1088AQDS
+/* read the current value(SVDD) of the LTM Regulator Voltage */
+int get_serdes_volt(void)
+{
+   int  ret, vcode = 0;
+   u8 chan = PWM_CHANNEL0;
+
+   /* Select the PAGE 0 using PMBus commands PAGE for VDD */
+   ret = i2c_write(I2C_SVDD_MONITOR_ADDR,
+   PMBUS_CMD_PAGE, 1, , 1);
+   if (ret) {
+   printf("VID: failed to select VDD Page 0\n");
+   return ret;
+   }
+
+   /* Read the output voltage using PMBus command READ_VOUT */
+   ret = i2c_read(I2C_SVDD_MONITOR_ADDR,
+  PMBUS_CMD_READ_VOUT, 1, (void *), 2);
+   if (ret) {
+   printf("VID: failed to read the volatge\n");
+   return ret;
+   }
+   return vcode;
+}
+
+int set_serdes_volt(int svdd)
+{
+   int ret, vdd_last;
+   u8 buff[5] = {0x04, PWM_CHANNEL0, PMBUS_CMD_VOUT_COMMAND,
+   svdd & 0xFF, (svdd & 0xFF00) >> 8};
+
+   /* Write the desired voltage code to the SVDD regulator */
+   ret = i2c_write(I2C_SVDD_MONITOR_ADDR,
+   PMBUS_CMD_PAGE_PLUS_WRITE, 1, (void *), 5);
+   if (ret) {
+   printf("VID: I2C failed to write to the volatge regulator\n");
+   return -1;
+   }
+
+   /* Wait for the volatge to get to the desired value */
+   do {
+   vdd_last = get_serdes_volt();
+   if (vdd_last < 0) {
+   printf("VID: Couldn't read sensor abort VID adjust\n");
+   return -1;
+   }
+   } while (vdd_last != svdd);
+
+   return 1;
+}
+#else
+int get_serdes_volt(void)
+{
+   return 0;
+}
+
+int set_serdes_volt(int svdd)
+{
+   int ret;
+   u8 brdcfg4;
+
+   printf("SVDD changing of RDB\n");
+
+   /* Read the BRDCFG54 via CLPD */
+   ret = i2c_read(CONFIG_SYS_I2C_FPGA_ADDR,
+   QIXIS_BRDCFG4_OFFSET, 1, (void *), 1);
+   if (ret) {
+   printf("VID: I2C failed to read the CPLD BRDCFG4\n");
+   return -1;
+   }
+
+   brdcfg4 = brdcfg4 | 0x08;
+
+   /* Write to the BRDCFG4 */
+   ret = i2c_write(CONFIG_SYS_I2C_FPGA_ADDR,
+   QIXIS_BRDCFG4_OFFSET, 1, (void *), 1);
+   if (ret) {
+   debug("VID: I2C failed to set the SVDD CPLD BRDCFG4\n");
+   return -1;
+   }
+
+   /* Wait for the volatge to get to the desired value */
+   udelay(1);
+
+   return 1;
+}
+#endif
+
+/* this function disables the SERDES, changes the SVDD Voltage and enables it*/
+int board_adjust_vdd(int vdd)
+{
+   int ret = 0;
+
+   debug("%s: vdd = %d\n", __func__, vdd);
+
+   /* Special settings to be performed when voltage is 900mV */
+   if (vdd == 900) {
+#ifdef CONFIG_SYS_FSL_DDR
+   ddr_enable_0v9_volt(true);
+#endif
+   ret = setup_serdes_volt(vdd);
+   if (ret < 0) {
+   ret = -1;
+   goto exit;
+   }
+   }
+exit:
+   return ret;
+}
 
 int board_init(void)
 {
@@ -314,6 +432,8 @@ int board_init(void)
/* invert AQR105 IRQ pins polarity */
out_le32(irq_ccsr + IRQCR_OFFSET / 4, AQR105_IRQ_MASK);
 #endif
+   if (adjust_vdd(0) < 0)
+   

[U-Boot] [PATCH v4 4/7] board: common: vid: Move IR chip specific code in flag

[Rajesh Bhagat]

Moves IR chip (IR36021) specific code in flag to resolve
compilation issue where it is not present. For example,
LS1088A is having a new LTC3882 voltage chip.

Signed-off-by: Ashish Kumar 
Signed-off-by: Rajesh Bhagat 
---
Changes in v4:  
 None

 board/freescale/common/vid.c | 19 ++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/board/freescale/common/vid.c b/board/freescale/common/vid.c
index 921841f..8acadc4 100644
--- a/board/freescale/common/vid.c
+++ b/board/freescale/common/vid.c
@@ -41,6 +41,8 @@ int __weak board_adjust_vdd(int vdd)
return 0;
 }
 
+#if defined(CONFIG_VOL_MONITOR_IR36021_SET) || \
+   defined(CONFIG_VOL_MONITOR_IR36021_READ)
 /*
  * Get the i2c address configuration for the IR regulator chip
  *
@@ -73,6 +75,7 @@ static int find_ir_chip_on_i2c(void)
}
return -1;
 }
+#endif
 
 /* Maximum loop count waiting for new voltage to take effect */
 #define MAX_LOOP_WAIT_NEW_VOL  100
@@ -184,6 +187,7 @@ static int read_voltage(int i2caddress)
return voltage_read;
 }
 
+#ifdef CONFIG_VOL_MONITOR_IR36021_SET
 /*
  * We need to calculate how long before the voltage stops to drop
  * or increase. It returns with the loop count. Each loop takes
@@ -243,7 +247,6 @@ static int wait_for_voltage_stable(int i2caddress)
return vdd_current;
 }
 
-#ifdef CONFIG_VOL_MONITOR_IR36021_SET
 /* Set the voltage to the IR chip */
 static int set_voltage_to_IR(int i2caddress, int vdd)
 {
@@ -298,7 +301,12 @@ int adjust_vdd(ulong vdd_override)
int re_enable = disable_interrupts();
struct ccsr_gur *gur = (void *)(CONFIG_SYS_FSL_GUTS_ADDR);
u32 fusesr;
+#if defined(CONFIG_VOL_MONITOR_IR36021_SET) || \
+   defined(CONFIG_VOL_MONITOR_IR36021_READ)
u8 vid, buf;
+#else
+   u8 vid;
+#endif
int vdd_target, vdd_current, vdd_last;
int ret, i2caddress;
unsigned long vdd_string_override;
@@ -369,6 +377,8 @@ int adjust_vdd(ulong vdd_override)
ret = -1;
goto exit;
}
+#if defined(CONFIG_VOL_MONITOR_IR36021_SET) || \
+   defined(CONFIG_VOL_MONITOR_IR36021_READ)
ret = find_ir_chip_on_i2c();
if (ret < 0) {
printf("VID: Could not find voltage regulator on I2C.\n");
@@ -393,6 +403,7 @@ int adjust_vdd(ulong vdd_override)
ret = -1;
goto exit;
}
+#endif
 
/* get the voltage ID from fuse status register */
fusesr = in_le32(>dcfg_fusesr);
@@ -532,6 +543,8 @@ int adjust_vdd(ulong vdd_override)
ret = -1;
goto exit;
}
+#if defined(CONFIG_VOL_MONITOR_IR36021_SET) || \
+   defined(CONFIG_VOL_MONITOR_IR36021_READ)
ret = find_ir_chip_on_i2c();
if (ret < 0) {
printf("VID: Could not find voltage regulator on I2C.\n");
@@ -556,6 +569,7 @@ int adjust_vdd(ulong vdd_override)
ret = -1;
goto exit;
}
+#endif
 
/* get the voltage ID from fuse status register */
fusesr = in_be32(>dcfg_fusesr);
@@ -666,6 +680,8 @@ static int print_vdd(void)
debug("VID : I2c failed to switch channel\n");
return -1;
}
+#if defined(CONFIG_VOL_MONITOR_IR36021_SET) || \
+   defined(CONFIG_VOL_MONITOR_IR36021_READ)
ret = find_ir_chip_on_i2c();
if (ret < 0) {
printf("VID: Could not find voltage regulator on I2C.\n");
@@ -674,6 +690,7 @@ static int print_vdd(void)
i2caddress = ret;
debug("VID: IR Chip found on I2C address 0x%02x\n", i2caddress);
}
+#endif
 
/*
 * Read voltage monitor to check real voltage.
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v4 6/7] board: common: vid: Add support for LTC3882 voltage regulator chip

[Rajesh Bhagat]

Restructures common driver to support LTC3882 voltage regulator
chip.

Signed-off-by: Ashish Kumar 
Signed-off-by: Rajesh Bhagat 
---
Changes in v4:
 None

Changes in v3:
 Restructured LS1088A VID support to use common VID driver
 Added the coding for voltage in comments i.e. 1/4096V
 Removed APIs getLSB/MSB and used bit operations.

Changes in v2:
 Checkpatch errors fixed

 .../include/asm/arch-fsl-layerscape/immap_lsch3.h  |  9 ++-
 board/freescale/common/vid.c   | 76 ++
 include/configs/ls1088aqds.h   | 16 +
 include/configs/ls1088ardb.h   | 15 +
 4 files changed, 114 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h 
b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h
index 47e8b5a..642df2f 100644
--- a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h
+++ b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h
@@ -201,10 +201,15 @@ struct ccsr_gur {
u32 gpporcr3;
u32 gpporcr4;
u8  res_030[0x60-0x30];
-#define FSL_CHASSIS3_DCFG_FUSESR_VID_SHIFT 2
 #define FSL_CHASSIS3_DCFG_FUSESR_VID_MASK  0x1F
-#define FSL_CHASSIS3_DCFG_FUSESR_ALTVID_SHIFT  7
 #define FSL_CHASSIS3_DCFG_FUSESR_ALTVID_MASK   0x1F
+#if defined(CONFIG_ARCH_LS1088A)
+#define FSL_CHASSIS3_DCFG_FUSESR_VID_SHIFT 25
+#define FSL_CHASSIS3_DCFG_FUSESR_ALTVID_SHIFT  20
+#else
+#define FSL_CHASSIS3_DCFG_FUSESR_VID_SHIFT 2
+#define FSL_CHASSIS3_DCFG_FUSESR_ALTVID_SHIFT  7
+#endif
u32 dcfg_fusesr;/* Fuse status register */
u8  res_064[0x70-0x64];
u32 devdisr;/* Device disable control 1 */
diff --git a/board/freescale/common/vid.c b/board/freescale/common/vid.c
index 8acadc4..871f92a 100644
--- a/board/freescale/common/vid.c
+++ b/board/freescale/common/vid.c
@@ -174,6 +174,36 @@ static int read_voltage_from_IR(int i2caddress)
 }
 #endif
 
+#ifdef CONFIG_VOL_MONITOR_LTC3882_READ
+/* read the current value of the LTC Regulator Voltage */
+static int read_voltage_from_LTC(int i2caddress)
+{
+   int  ret, vcode = 0;
+   u8 chan = PWM_CHANNEL0;
+
+   /* select the PAGE 0 using PMBus commands PAGE for VDD*/
+   ret = i2c_write(I2C_VOL_MONITOR_ADDR,
+   PMBUS_CMD_PAGE, 1, , 1);
+   if (ret) {
+   printf("VID: failed to select VDD Page 0\n");
+   return ret;
+   }
+
+   /*read the output voltage using PMBus command READ_VOUT*/
+   ret = i2c_read(I2C_VOL_MONITOR_ADDR,
+  PMBUS_CMD_READ_VOUT, 1, (void *), 2);
+   if (ret) {
+   printf("VID: failed to read the volatge\n");
+   return ret;
+   }
+
+   /* Scale down to the real mV as LTC resolution is 1/4096V,rounding up */
+   vcode = DIV_ROUND_UP(vcode * 1000, 4096);
+
+   return vcode;
+}
+#endif
+
 static int read_voltage(int i2caddress)
 {
int voltage_read;
@@ -181,6 +211,8 @@ static int read_voltage(int i2caddress)
voltage_read = read_voltage_from_INA220(i2caddress);
 #elif defined CONFIG_VOL_MONITOR_IR36021_READ
voltage_read = read_voltage_from_IR(i2caddress);
+#elif defined CONFIG_VOL_MONITOR_LTC3882_READ
+   voltage_read = read_voltage_from_LTC(i2caddress);
 #else
return -1;
 #endif
@@ -281,6 +313,42 @@ static int set_voltage_to_IR(int i2caddress, int vdd)
debug("VID: Current voltage is %d mV\n", vdd_last);
return vdd_last;
 }
+
+#endif
+
+#ifdef CONFIG_VOL_MONITOR_LTC3882_SET
+/* this function sets the VDD and returns the value set */
+static int set_voltage_to_LTC(int i2caddress, int vdd)
+{
+   int ret, vdd_last, vdd_target = vdd;
+
+   /* Scale up to the LTC resolution is 1/4096V */
+   vdd = (vdd * 4096) / 1000;
+
+   /* 5-byte buffer which needs to be sent following the
+* PMBus command PAGE_PLUS_WRITE.
+*/
+   u8 buff[5] = {0x04, PWM_CHANNEL0, PMBUS_CMD_VOUT_COMMAND,
+   vdd & 0xFF, (vdd & 0xFF00) >> 8};
+
+   /* Write the desired voltage code to the regulator */
+   ret = i2c_write(I2C_VOL_MONITOR_ADDR,
+   PMBUS_CMD_PAGE_PLUS_WRITE, 1, (void *), 5);
+   if (ret) {
+   printf("VID: I2C failed to write to the volatge regulator\n");
+   return -1;
+   }
+
+   /* Wait for the volatge to get to the desired value */
+   do {
+   vdd_last = read_voltage_from_LTC(i2caddress);
+   if (vdd_last < 0) {
+   printf("VID: Couldn't read sensor abort VID adjust\n");
+   return -1;
+   }
+   } while (vdd_last != vdd_target);
+   return vdd_last;
+}
 #endif
 
 static int set_voltage(int i2caddress, int vdd)
@@ -289,6 +357,8 @@ static int set_voltage(int i2caddress, int vdd)
 
 #ifdef CONFIG_VOL_MONITOR_IR36021_SET
vdd_last 

[U-Boot] [PATCH v4 3/7] board: common: vid: Add board specific vdd adjust API

[Rajesh Bhagat]

Adds a board specific API namely board_adjust_vdd which
is required to define the board VDD adjust settings.

Signed-off-by: Ashish Kumar 
Signed-off-by: Rajesh Bhagat 
---
Changes in v4:  
 None

 board/freescale/common/vid.c | 13 +
 1 file changed, 13 insertions(+)

diff --git a/board/freescale/common/vid.c b/board/freescale/common/vid.c
index f4fc95b..921841f 100644
--- a/board/freescale/common/vid.c
+++ b/board/freescale/common/vid.c
@@ -34,6 +34,14 @@ int __weak board_vdd_drop_compensation(void)
 }
 
 /*
+ * Board specific settings for specific voltage value
+ */
+int __weak board_adjust_vdd(int vdd)
+{
+   return 0;
+}
+
+/*
  * Get the i2c address configuration for the IR regulator chip
  *
  * There are some variance in the RDB HW regarding the I2C address 
configuration
@@ -453,6 +461,11 @@ int adjust_vdd(ulong vdd_override)
vdd_last = set_voltage(i2caddress, vdd_current);
}
 
+   if (board_adjust_vdd(vdd_target) < 0) {
+   ret = -1;
+   goto exit;
+   }
+
if (vdd_last > 0)
printf("VID: Core voltage after adjustment is at %d mV\n",
   vdd_last);
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v4 5/7] Kconfig: Add LTC3882 voltage regulator config

[Rajesh Bhagat]

Adds below LTC3882 voltage regulator config:
CONFIG_VOL_MONITOR_LTC3882_READ
CONFIG_VOL_MONITOR_LTC3882_SET

Signed-off-by: Ashish Kumar 
Signed-off-by: Rajesh Bhagat 
---
Changes in v4:  
 None

 board/freescale/common/Kconfig | 16 
 1 file changed, 16 insertions(+)

diff --git a/board/freescale/common/Kconfig b/board/freescale/common/Kconfig
index 8a5c456..3f44797 100644
--- a/board/freescale/common/Kconfig
+++ b/board/freescale/common/Kconfig
@@ -18,3 +18,19 @@ config CMD_ESBC_VALIDATE
 
esbc_validate - validate signature using RSA verification
esbc_halt - put the core in spin loop (Secure Boot Only)
+
+config VOL_MONITOR_LTC3882_READ
+   depends on VID
+   bool "Enable the LTC3882 voltage monitor read"
+   default n
+   help
+This option enables LTC3882 voltage monitor read
+functionality. It is used by common VID driver.
+
+config VOL_MONITOR_LTC3882_SET
+   depends on VID
+   bool "Enable the LTC3882 voltage monitor set"
+   default n
+   help
+This option enables LTC3882 voltage monitor set
+functionality. It is used by common VID driver.
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v4 2/7] board: common:vid: Add LS1088A VID Supported voltage values

[Rajesh Bhagat]

Adds below voltage values supported by LS1088A Soc:

1.025 V(default), 0.9875V, 0.9750 V, 0.9V, 1.0 V, 1.0125 V, 1.0250 V

Signed-off-by: Ashish Kumar 
Signed-off-by: Rajesh Bhagat 
---
Changes in v4:  
 None

 board/freescale/common/vid.c | 21 +
 1 file changed, 21 insertions(+)

diff --git a/board/freescale/common/vid.c b/board/freescale/common/vid.c
index d6d1bfc..f4fc95b 100644
--- a/board/freescale/common/vid.c
+++ b/board/freescale/common/vid.c
@@ -296,15 +296,28 @@ int adjust_vdd(ulong vdd_override)
unsigned long vdd_string_override;
char *vdd_string;
static const uint16_t vdd[32] = {
+#ifdef CONFIG_ARCH_LS1088A
+   10250,
+   9875,
+#else
10500,
0,  /* reserved */
+#endif
9750,
0,  /* reserved */
+#ifdef CONFIG_ARCH_LS1088A
+   0,  /* reserved */
+#else
9500,
+#endif
0,  /* reserved */
0,  /* reserved */
0,  /* reserved */
+#ifdef CONFIG_ARCH_LS1088A
+   9000,
+#else
0,  /* reserved */
+#endif
0,  /* reserved */
0,  /* reserved */
0,  /* reserved */
@@ -313,10 +326,18 @@ int adjust_vdd(ulong vdd_override)
0,  /* reserved */
0,  /* reserved */
1,  /* 1.V */
+#ifdef CONFIG_ARCH_LS1088A
+   10125,
+#else
0,  /* reserved */
+#endif
10250,
0,  /* reserved */
+#ifdef CONFIG_ARCH_LS1088A
+   0,  /* reserved */
+#else
10500,
+#endif
0,  /* reserved */
0,  /* reserved */
0,  /* reserved */
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v4 1/7] armv8: lsch3: Add serdes and DDR voltage setup

[Rajesh Bhagat]

Adds SERDES voltage and reset SERDES lanes API and makes
enable/disable DDR controller support 0.9V API common.

Signed-off-by: Ashish Kumar 
Signed-off-by: Rajesh Bhagat 
---
Changes in v4:  
  - Added local macros instead of magical numbers   
  - Created macros to remove duplicate code

Changes in v3:
 Restructured LS1088A VID support to use common VID driver
 Cosmetic review comments fixed
 Added __iomem for accessing registers

Changes in v2:
 Checkpatch errors fixed

 .../cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c| 263 +
 arch/arm/cpu/armv8/fsl-layerscape/soc.c|  34 +--
 .../include/asm/arch-fsl-layerscape/fsl_serdes.h   |   2 +-
 .../include/asm/arch-fsl-layerscape/immap_lsch3.h  |  34 +++
 arch/arm/include/asm/arch-fsl-layerscape/soc.h |   1 +
 5 files changed, 316 insertions(+), 18 deletions(-)

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c 
b/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c
index 179cac6..6fbfbed 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c
@@ -158,6 +158,269 @@ void serdes_init(u32 sd, u32 sd_addr, u32 rcwsr, u32 
sd_prctl_mask,
serdes_prtcl_map[NONE] = 1;
 }
 
+__weak int get_serdes_volt(void)
+{
+   return -1;
+}
+
+__weak int set_serdes_volt(int svdd)
+{
+   return -1;
+}
+
+#define LNAGCR0_RESET_MASK 0xFF9F
+#define LNAGCR0_RT_RSTB0x0060
+#define RSTCTL_RESET_MASK_10xFFBF
+#define RSTCTL_RESET_MASK_20xFF1F
+#define RSTCTL_RESET_MASK_30xFFEF
+#define RSTCTL_RSTREQ  0x8000
+#define RSTCTL_RSTERR  0x2000
+#define RSTCTL_SDEN0x0020
+#define RSTCTL_SDRST_B 0x0040
+#define RSTCTL_PLLRST_B0x0080
+#define RSTCTL_RST_DONE0x4000
+#define TCALCR_RESET_MASK  0xF7FF
+#define TCALCR_CALRST_B0x0800
+
+#define CAT2(x, y) CAT2_(x, y)
+#define CAT2_(x, y) x ## y
+
+#define CAT3(x, y, z) CAT3_(x, y, z)
+#define CAT3_(x, y, z) x ## y ## z
+
+#define DO_ENABLED_LANES_RESET(x) do { \
+   cfg_tmp = CAT2(cfg_rcwsrds, x) &\
+   CAT3(FSL_CHASSIS3_SRDS, x, _PRTCL_MASK);\
+   cfg_tmp >>= CAT3(FSL_CHASSIS3_SRDS, x, _PRTCL_SHIFT);   \
+   \
+   for (i = 0; i < 4 && cfg_tmp & (0xf << (3 - i)); i++) { \
+   reg = in_le32((serdes, x, _base)->lane[i].gcr0);   \
+   reg &= LNAGCR0_RESET_MASK;  \
+   out_le32((serdes, x, _base)->lane[i].gcr0, reg);   \
+   }   \
+} while (0)
+
+#define DO_PLL_RESET(cfg_tmp, x) do {  \
+   for (i = 0; i < 2 && !(cfg_tmp & (0x1 << (1 - i))); i++) {  \
+   reg = in_le32((serdes, x, _base)->bank[i].rstctl); \
+   reg &= RSTCTL_RESET_MASK_1; \
+   reg |= RSTCTL_RSTREQ;   \
+   out_le32((serdes, x, _base)->bank[i].rstctl, reg); \
+   }   \
+   udelay(1);  \
+   \
+   reg = in_le32((serdes, x, _base)->bank[i].rstctl); \
+   reg &= RSTCTL_RESET_MASK_2; \
+   out_le32((serdes, x, _base)->bank[i].rstctl, reg); \
+} while (0)
+
+#define DO_RX_TX_CAL_RESET(x) do { \
+   reg = in_le32((serdes, x, _base)->srdstcalcr); \
+   reg &= TCALCR_RESET_MASK;   \
+   out_le32((serdes, x, _base)->srdstcalcr, reg); \
+   reg = in_le32((serdes, x, _base)->srdsrcalcr); \
+   reg &= TCALCR_RESET_MASK;   \
+   out_le32((serdes, x, _base)->srdsrcalcr, reg); \
+} while (0)
+
+#define DO_RX_TX_CAL_RESET_COMP(x, i) do { \
+   if (!(cfg_tmp == 0x3 && i == 1)) {  \
+   udelay(1);  \
+   reg = in_le32((serdes, x, _base)->srdstcalcr); \
+   reg |= TCALCR_CALRST_B; \
+   out_le32((serdes, x, _base)->srdstcalcr, reg); \
+   reg = in_le32((serdes, x, _base)->srdsrcalcr); \
+   reg |= TCALCR_CALRST_B; \
+   

[U-Boot] [PATCH v4 0/7] Add VID support for QDS and RDB platforms

[Rajesh Bhagat]

Adds LTC3882 voltage regulator chip support in common VID driver.
And adds VID support for LS1088A QDS and RDB platforms.

Rajesh Bhagat (7):
  armv8: lsch3: Add serdes and DDR voltage setup
  board: common:vid: Add LS1088A VID Supported voltage values
  board: common: vid: Add board specific vdd adjust API
  board: common: vid: Move IR chip specific code in flag
  Kconfig: Add LTC3882 voltage regulator config
  board: common: vid: Add support for LTC3882 voltage regulator chip
  ls1088a: Add VID support for QDS and RDB platforms

 .../cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c| 263 +
 arch/arm/cpu/armv8/fsl-layerscape/soc.c|  34 +--
 .../include/asm/arch-fsl-layerscape/fsl_serdes.h   |   2 +-
 .../include/asm/arch-fsl-layerscape/immap_lsch3.h  |  43 +++-
 arch/arm/include/asm/arch-fsl-layerscape/soc.h |   1 +
 board/freescale/common/Kconfig |  16 ++
 board/freescale/common/vid.c   | 129 +-
 board/freescale/ls1088a/ls1088a.c  | 120 ++
 include/configs/ls1088aqds.h   |  29 +++
 include/configs/ls1088ardb.h   |  29 +++
 10 files changed, 645 insertions(+), 21 deletions(-)

-- 
Changes in v4:
  - Added local macros instead of magical numbers
  - Created macros to remove duplicate code

Changes in v3:
 Restructured LS1088A VID support to use common VID driver
 Cosmetic review comments fixed
 Added __iomem for accessing registers
 Added the coding for voltage in comments i.e. 1/4096V
 Removed APIs getLSB/MSB and used bit operations. 

Changes in v2:
 Checkpatch errors fixed

Depends on below patches:
http://patchwork.ozlabs.org/patch/831893/ 
http://patchwork.ozlabs.org/patch/833198/ 
http://patchwork.ozlabs.org/patch/833199/ 
http://patchwork.ozlabs.org/patch/834501/ 
http://patchwork.ozlabs.org/patch/834502/ 
http://patchwork.ozlabs.org/patch/834503/ 

2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 3/3] imx7: Add include guards for include/asm/arch-mx7/sys_proto.h file

[Lukasz Majewski]

Signed-off-by: Lukasz Majewski 
---

 arch/arm/include/asm/arch-mx7/sys_proto.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/include/asm/arch-mx7/sys_proto.h 
b/arch/arm/include/asm/arch-mx7/sys_proto.h
index fa624248b2..cd83662a78 100644
--- a/arch/arm/include/asm/arch-mx7/sys_proto.h
+++ b/arch/arm/include/asm/arch-mx7/sys_proto.h
@@ -3,8 +3,12 @@
  *
  * SPDX-License-Identifier:GPL-2.0+
  */
+#ifndef __SYS_PROTO_IMX7_
+#define __SYS_PROTO_IMX7_
 
 #include 
 
 void set_wdog_reset(struct wdog_regs *wdog);
 enum boot_device get_boot_device(void);
+
+#endif /* __SYS_PROTO_IMX7_ */
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/3] imx5: Add include guards for include/asm/arch-mx5/sys_proto.h file

[Lukasz Majewski]

Signed-off-by: Lukasz Majewski 
---

 arch/arm/include/asm/arch-mx5/sys_proto.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/include/asm/arch-mx5/sys_proto.h 
b/arch/arm/include/asm/arch-mx5/sys_proto.h
index 14f5d948c9..de19c45e09 100644
--- a/arch/arm/include/asm/arch-mx5/sys_proto.h
+++ b/arch/arm/include/asm/arch-mx5/sys_proto.h
@@ -4,5 +4,9 @@
  *
  * SPDX-License-Identifier:GPL-2.0+
  */
+#ifndef __SYS_PROTO_IMX5_
+#define __SYS_PROTO_IMX5_
 
 #include 
+
+#endif /* __SYS_PROTO_IMX5_ */
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/3] imx6: Add include guards for include/asm/arch-mx6/sys_proto.h file

[Lukasz Majewski]

Signed-off-by: Lukasz Majewski 
---

 arch/arm/include/asm/arch-mx6/sys_proto.h | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h 
b/arch/arm/include/asm/arch-mx6/sys_proto.h
index 72ab7d814f..33458cd000 100644
--- a/arch/arm/include/asm/arch-mx6/sys_proto.h
+++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
@@ -5,6 +5,9 @@
  * SPDX-License-Identifier:GPL-2.0+
  */
 
+#ifndef __SYS_PROTO_IMX6_
+#define __SYS_PROTO_IMX6_
+
 #include 
 #include 
 
@@ -27,3 +30,5 @@ static inline void iomuxc_set_rgmii_io_voltage(int io_vol)
 {
__raw_writel(io_vol, IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII);
 }
+
+#endif /* __SYS_PROTO_IMX6_ */
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] imx6: iomux: Add generic function to set RGMII IO voltage on IMX6 SoCs

[Lukasz Majewski]

Hi Stefano,

> On 07/11/2017 10:23, Stefano Babic wrote:
> > On 31/10/2017 13:26, Lukasz Majewski wrote:  
> >> This commit provides generic function to set the RGMII/HSIC IO
> >> voltage level on iMX6 devices.
> >>
> >> Signed-off-by: Lukasz Majewski 
> >> ---
> >>
> >>  arch/arm/include/asm/arch-mx6/iomux.h | 13 +
> >>  arch/arm/include/asm/arch-mx6/sys_proto.h | 11 +++
> >>  2 files changed, 24 insertions(+)
> >>
> >> diff --git a/arch/arm/include/asm/arch-mx6/iomux.h
> >> b/arch/arm/include/asm/arch-mx6/iomux.h index
> >> 907cb408ff..ee3a56583b 100644 ---
> >> a/arch/arm/include/asm/arch-mx6/iomux.h +++
> >> b/arch/arm/include/asm/arch-mx6/iomux.h @@ -178,4 +178,17 @@
> >>|IOMUXC_GPR13_SATA_PHY_3_MASK \
> >>|IOMUXC_GPR13_SATA_PHY_2_MASK \
> >>|IOMUXC_GPR13_SATA_PHY_1_MASK)
> >> +
> >> +/*
> >> + * Setup RGMII voltage levels on iMX6 SoC - the
> >> + *
> >> + * IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII - register
> >> + *
> >> + * 1P2V_IO - USB_HSIC, MIPI_HSI
> >> + * 1P5V_IO - ENET pins
> >> + */
> >> +#define IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII  0x020e0790
> >> +#define DDR_SEL_1P2V_IO (0x2 << 18)
> >> +#define DDR_SEL_1P5V_IO (0x3 << 18)
> >> +
> >>  #endif/* __ASM_ARCH_IOMUX_H__ */
> >> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h
> >> b/arch/arm/include/asm/arch-mx6/sys_proto.h index
> >> b22a7a0f8b..72ab7d814f 100644 ---
> >> a/arch/arm/include/asm/arch-mx6/sys_proto.h +++
> >> b/arch/arm/include/asm/arch-mx6/sys_proto.h @@ -6,6 +6,7 @@
> >>   */
> >>  
> >>  #include 
> >> +#include 
> >>  
> >>  #define USBPHY_PWD0x
> >>  
> >> @@ -16,3 +17,13 @@
> >>  
> >>  int imx6_pcie_toggle_power(void);
> >>  int imx6_pcie_toggle_reset(void);
> >> +
> >> +/**
> >> + * iomuxc_set_rgmii_io_voltage - set voltage level of RGMII/USB
> >> pins
> >> + *
> >> + * @param io_vol - the voltage IO level of pins
> >> + */
> >> +static inline void iomuxc_set_rgmii_io_voltage(int io_vol)
> >> +{
> >> +  __raw_writel(io_vol,
> >> IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII); +}
> >>  
> > 
> > Applied to u-boot-imx, -master, thanke !
> >   
> 
> I was too optimistic. This breaks the "marsboard" board (same name for
> function). Can you review this and fix it, please ?

I've just sent the fix for "marsboard" (double inclusion of sys_proto.h)

> 
> Thanks,
> Stefano
> 
> 



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de


pgp3YZvP6lsXx.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] board: imx6: marsboard: Remove doubled #include

[Lukasz Majewski]

The sys_proto.h file has been included earlier in this file.

Signed-off-by: Lukasz Majewski 

---

 board/embest/mx6boards/mx6boards.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/embest/mx6boards/mx6boards.c 
b/board/embest/mx6boards/mx6boards.c
index ae04f68445..965e4f1ec8 100644
--- a/board/embest/mx6boards/mx6boards.c
+++ b/board/embest/mx6boards/mx6boards.c
@@ -36,7 +36,7 @@
 #include 
 #include 
 #include 
-#include 
+
 DECLARE_GLOBAL_DATA_PTR;
 
 #define UART_PAD_CTRL  (PAD_CTL_PUS_100K_UP |  \
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v5 0/8] Add support for GE PPD

[Peter Robinson]

On Mon, Nov 6, 2017 at 7:14 PM, Martyn Welch  wrote:
> This series adds support for the GE PPD. The initial patches in this
> series resolve issues found during development and testing, extend
> existing support and add new support for devices in the PPD. The final
> patch in the series adds the board support for the PPD.
>
> Ian Ray (2):
>   ext4: recover from filesystem corruption when reading
>   bootcount: add support for bootcounter on EXT filesystem

Shouldn't the above two patches be sent separately, they're not really
part of adding a new board.

> Martyn Welch (3):
>   pwm: imx: Enable PWM support on i.MX53
>   arm: mx5: Add more register definitions
>   board: ge: make VPD code common
>
> Nandor Han (2):
>   imx: mxc_i2c: tweak the i2c transfer method
>   rtc: add support for s35392a
>
> Peter Senna Tschudin (1):
>   mx53: Add Board support for GE PPD
>
>  README   |   7 +
>  arch/arm/include/asm/arch-mx5/crm_regs.h |   8 +
>  arch/arm/include/asm/arch-mx5/imx-regs.h |  50 
>  arch/arm/mach-imx/mx5/Kconfig|   7 +
>  board/ge/bx50v3/Makefile |   2 +-
>  board/ge/bx50v3/bx50v3.c |   2 +-
>  board/ge/bx50v3/vpd_reader.c | 228 ---
>  board/ge/bx50v3/vpd_reader.h |  25 --
>  board/ge/common/Makefile |   7 +
>  board/ge/common/vpd_reader.c | 197 +
>  board/ge/common/vpd_reader.h |  17 ++
>  board/ge/mx53ppd/Kconfig |  17 ++
>  board/ge/mx53ppd/MAINTAINERS |   7 +
>  board/ge/mx53ppd/Makefile|  12 +
>  board/ge/mx53ppd/imximage.cfg|  87 ++
>  board/ge/mx53ppd/mx53ppd.c   | 457 
> +++
>  board/ge/mx53ppd/mx53ppd_video.c | 135 +
>  board/ge/mx53ppd/ppd_gpio.h  |  96 +++
>  configs/mx53ppd_defconfig|  39 +++
>  drivers/Kconfig  |   2 +
>  drivers/bootcount/Kconfig|  58 
>  drivers/bootcount/Makefile   |   1 +
>  drivers/bootcount/bootcount_ext.c|  62 +
>  drivers/i2c/mxc_i2c.c|  25 +-
>  drivers/pwm/pwm-imx-util.c   |   2 +
>  drivers/rtc/Kconfig  |   6 +
>  drivers/rtc/Makefile |   1 +
>  drivers/rtc/s35392a.c| 365 
>  fs/ext4/ext4_common.c|  10 +
>  fs/ext4/ext4fs.c |  10 +-
>  include/configs/mx53ppd.h| 248 +
>  lib/Kconfig  |   3 +
>  32 files changed, 1927 insertions(+), 266 deletions(-)
>  delete mode 100644 board/ge/bx50v3/vpd_reader.c
>  delete mode 100644 board/ge/bx50v3/vpd_reader.h
>  create mode 100644 board/ge/common/Makefile
>  create mode 100644 board/ge/common/vpd_reader.c
>  create mode 100644 board/ge/common/vpd_reader.h
>  create mode 100644 board/ge/mx53ppd/Kconfig
>  create mode 100644 board/ge/mx53ppd/MAINTAINERS
>  create mode 100644 board/ge/mx53ppd/Makefile
>  create mode 100644 board/ge/mx53ppd/imximage.cfg
>  create mode 100644 board/ge/mx53ppd/mx53ppd.c
>  create mode 100644 board/ge/mx53ppd/mx53ppd_video.c
>  create mode 100644 board/ge/mx53ppd/ppd_gpio.h
>  create mode 100644 configs/mx53ppd_defconfig
>  create mode 100644 drivers/bootcount/Kconfig
>  create mode 100644 drivers/bootcount/bootcount_ext.c
>  create mode 100644 drivers/rtc/s35392a.c
>  create mode 100644 include/configs/mx53ppd.h
>
> --
> 2.1.4
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 10/15] rockchip: dts: rk3399-puma: add /config/arm-trusted-firmware, reset-gpio property

[Dr. Philipp Tomsich]

> On 17 Sep 2017, at 19:54, Simon Glass  wrote:
> 
> On 13 September 2017 at 13:29, Philipp Tomsich
>  wrote:
>> With the ATF capable of accessing the FDT passed to the next stage,
>> we can specify configuration items for the ATF in the /config path.
>> 
>> This adds the arm-trusted-firmware,reset-gpio that conveys the number
>> of the GPIO used to reset the board (used, when a reboot is requested
>> from ATF via PSCI).
>> 
>> Signed-off-by: Philipp Tomsich 
>> ---
>> 
>> arch/arm/dts/rk3399-puma.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
>> index d33c710..70d551b 100644
>> --- a/arch/arm/dts/rk3399-puma.dtsi
>> +++ b/arch/arm/dts/rk3399-puma.dtsi
>> @@ -16,6 +16,7 @@
>>u-boot,mmc-env-offset = <0x4000>;  /* @  16KB */
>>u-boot,efi-partition-entries-offset = <0x20>; /* 2MB */
>>u-boot,boot-led = "module_led";
>> +   arm-trusted-firmware,reset-gpio = <38>;
>>};
>> 
>>chosen {
>> --
>> 2.1.4
>> 
> 
> How about putting this in an atf {} subnode?
> 
> That reminds me that these things should be documented in
> doc/device-tree-bindings/config.txt


This is in fact a good idea (as this allows to prefix the the reset-gpio with a 
board-specific prefix):
config {
arm-trusted-firmware {
rk3399,reset-gpio = ...
}
}

However, as we already have an ATF version floating around customers that
uses this, I will merge it as-is and submit a follow-up series that updates it 
to
the new model (together with proper documentation), so this is documented
in the git history.

Regards,
Philipp.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] common: Generic file system firmware loader

[Marek Vasut]

On 11/07/2017 10:03 AM, Chee, Tien Fong wrote:
> On Isn, 2017-11-06 at 11:56 +0100, Marek Vasut wrote:
>> On 11/06/2017 05:15 AM, Chee, Tien Fong wrote:
>>>
>>> On Ahd, 2017-11-05 at 17:43 +0100, Marek Vasut wrote:

 On 11/02/2017 09:20 AM, Chee, Tien Fong wrote:
>
>
> On Rab, 2017-11-01 at 10:26 +0100, Marek Vasut wrote:
>>
>>
>> On 11/01/2017 10:18 AM, tien.fong.c...@intel.com wrote:
>>>
>>>
>>>
>>> From: Tien Fong Chee 
>>>
>>> Generic firmware loader framework contains some common
>>> functionality
>>> which is factored out from splash loader. It is reusable by
>>> any
>>> specific driver file system firmware loader. Specific
>>> driver
>>> file
>>> system
>>> firmware loader handling can be defined with both weak
>>> function
>>> fsloader_preprocess and fs_loading.
>>>
>>> Signed-off-by: Tien Fong Chee 
>>> ---
>>>  common/Makefile   |   1 +
>>>  common/load_fs.c  | 217
>>> ++
>>>  include/load_fs.h |  38 ++
>>>  3 files changed, 256 insertions(+)
>>>  create mode 100644 common/load_fs.c
>>>  create mode 100644 include/load_fs.h
>> [...]
>>
>>>
>>>
>>>
>>> +int flash_select_fs_dev(struct flash_location *location)
>> Why does everything have flash_ prefix ?
>>
> I can remove the flash_ prefix, this generic FS loader should
> support
> for all filesystem instead of flash.
>
>>
>>
>> I also mentioned the API should copy the linux firmware
>> loader
>> API.
>>
> If i'm not mistaken, you are referring firmware loader API in
> this
> link https://github.com/torvalds/linux/blob/f007cad159e99fa2acd
> 3b2e
> 9364
> fbb32ad28b971/drivers/base/firmware_class.c#L1264.
>
>>> I would like to confirm with you whether we are talking to the same
>>> API
>>> above?
>> https://www.kernel.org/doc/html/v4.13/driver-api/firmware/index.html
>>
>> first link on google btw . You might be able to avoid the firmware
>> structure.
>>
> After assessment, i found that Linux loader is not suitable for fpga
> loader as fpga loader need
> 1) Able to program FPGA image in SPL chunk bu chunk with small memory
> allocatted.
> 2) Name of FPGA image defined in DTS, and path of FPGA image in FAT and
> UBI partition.
> 
> Linux loader is strongly designed based on Linux environment, always
> assume having RFF, env support(which SPL don't have), sysfs and udev
> feature.

Sigh, you can just have some additional function call to fetch smaller
chunks from a file, I don't think it's that hard of a problem ...

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v4] imx:display5: Add support for LWN's DISPLAY5 board (for v2017.11-rc2+)

[Lukasz Majewski]

Hi Stefano,

> Hi Lukasz,
> 
> On 31/10/2017 17:58, Lukasz Majewski wrote:
> > This commit provides support for LWN's IMX6Q based DISPLAY5 board.
> >   
> 
> I would merge it, but why the commit message is still "(for
> v2017.11-rc2+)" ? This goes into git history if I merge it.
> 
> Can I drop it by merging ?

Yes. Please.

(I should not put it there in a first place).

Thanks :-)

> 
> Best regards,
> Stefano
> 
> > Signed-off-by: Lukasz Majewski 
> > 
> > ---
> > 
> > Changes in v4:
> > - Refactor obscure sw/hw rev code for display5 board
> > - replace get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
> > with imx_ddr_size()
> > - remove PHYS_SDRAM_SIZE from display5.h
> > - Replace non generic setup of RGMII pins voltage levels with a
> > generic function
> > - Move displ5_set_iomux_uart() - non console UART init to
> > board_init()
> > - Disable board_early_init_f() calls (prod/factory)
> > - Move mtdparts to Kconfig for production and flash u-boot
> > 
> > Changes in v3:
> > - Remove ip custom data
> > - Cleanup SPL code
> > 
> > Changes in v2:
> > - Update to newest mainline u-boot
> > 
> >  arch/arm/dts/imx6q-display5.dts |  18 ++
> >  arch/arm/mach-imx/mx6/Kconfig   |   7 +
> >  board/liebherr/display5/Kconfig |  18 ++
> >  board/liebherr/display5/MAINTAINERS |   7 +
> >  board/liebherr/display5/Makefile|  11 +
> >  board/liebherr/display5/common.c| 111 ++
> >  board/liebherr/display5/common.h|  42 
> >  board/liebherr/display5/display5.c  | 384
> > +
> > board/liebherr/display5/spl.c   | 247 ++
> > configs/display5_defconfig  |  62 ++
> > configs/display5_factory_defconfig  |  76 +++
> > include/configs/display5.h  | 408
> >  12 files changed, 1391
> > insertions(+) create mode 100644 arch/arm/dts/imx6q-display5.dts
> > create mode 100644 board/liebherr/display5/Kconfig create mode
> > 100644 board/liebherr/display5/MAINTAINERS create mode 100644
> > board/liebherr/display5/Makefile create mode 100644
> > board/liebherr/display5/common.c create mode 100644
> > board/liebherr/display5/common.h create mode 100644
> > board/liebherr/display5/display5.c create mode 100644
> > board/liebherr/display5/spl.c create mode 100644
> > configs/display5_defconfig create mode 100644
> > configs/display5_factory_defconfig create mode 100644
> > include/configs/display5.h
> > 
> > diff --git a/arch/arm/dts/imx6q-display5.dts
> > b/arch/arm/dts/imx6q-display5.dts new file mode 100644
> > index 00..50347ff26b
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6q-display5.dts
> > @@ -0,0 +1,18 @@
> > +/*
> > + * Copyright 2017
> > + * Lukasz Majewski, DENX Software Engineering, lu...@denx.de
> > + *
> > + * This program is free software; you can redistribute it and/or
> > modify
> > + * it under the terms of the GNU General Public License version 2
> > as
> > + * published by the Free Software Foundation.
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "imx6q.dtsi"
> > +
> > +/ {
> > +   model = "Liebherr (LWN) display5 i.MX6 Quad Board";
> > +   compatible = "lwn,display5", "fsl,imx6q";
> > +};
> > diff --git a/arch/arm/mach-imx/mx6/Kconfig
> > b/arch/arm/mach-imx/mx6/Kconfig index b82db3af22..fd73c67fde 100644
> > --- a/arch/arm/mach-imx/mx6/Kconfig
> > +++ b/arch/arm/mach-imx/mx6/Kconfig
> > @@ -138,6 +138,12 @@ config TARGET_DHCOMIMX6
> > select DM_THERMAL
> > imply CMD_SPL
> >  
> > +config TARGET_DISPLAY5
> > +   bool "LWN DISPLAY5 board"
> > +   select SUPPORT_SPL
> > +   select DM
> > +   select DM_SERIAL
> > +
> >  config TARGET_EMBESTMX6BOARDS
> > bool "embestmx6boards"
> > select BOARD_LATE_INIT
> > @@ -459,6 +465,7 @@ source "board/phytec/pfla02/Kconfig"
> >  source "board/gateworks/gw_ventana/Kconfig"
> >  source "board/kosagi/novena/Kconfig"
> >  source "board/samtec/vining_2000/Kconfig"
> > +source "board/liebherr/display5/Kconfig"
> >  source "board/liebherr/mccmon6/Kconfig"
> >  source "board/logicpd/imx6/Kconfig"
> >  source "board/seco/Kconfig"
> > diff --git a/board/liebherr/display5/Kconfig
> > b/board/liebherr/display5/Kconfig new file mode 100644
> > index 00..b096c8917a
> > --- /dev/null
> > +++ b/board/liebherr/display5/Kconfig
> > @@ -0,0 +1,18 @@
> > +if TARGET_DISPLAY5
> > +
> > +config SYS_CPU
> > +   default "armv7"
> > +
> > +config SYS_BOARD
> > +   default "display5"
> > +
> > +config SYS_VENDOR
> > +   default "liebherr"
> > +
> > +config SYS_SOC
> > +   default "mx6"
> > +
> > +config SYS_CONFIG_NAME
> > +   default "display5"
> > +
> > +endif
> > diff --git a/board/liebherr/display5/MAINTAINERS
> > b/board/liebherr/display5/MAINTAINERS new file mode 100644
> > index 00..52178318b5
> > --- /dev/null
> > +++ b/board/liebherr/display5/MAINTAINERS
> > @@ -0,0 +1,7 @@
> > +DISPLAY5 BOARD
> > +M: Lukasz Majewski 
> > +S: 

Re: [U-Boot] [PATCH] imx6: iomux: Add generic function to set RGMII IO voltage on IMX6 SoCs

[Stefano Babic]

On 07/11/2017 10:23, Stefano Babic wrote:
> On 31/10/2017 13:26, Lukasz Majewski wrote:
>> This commit provides generic function to set the RGMII/HSIC IO voltage
>> level on iMX6 devices.
>>
>> Signed-off-by: Lukasz Majewski 
>> ---
>>
>>  arch/arm/include/asm/arch-mx6/iomux.h | 13 +
>>  arch/arm/include/asm/arch-mx6/sys_proto.h | 11 +++
>>  2 files changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-mx6/iomux.h 
>> b/arch/arm/include/asm/arch-mx6/iomux.h
>> index 907cb408ff..ee3a56583b 100644
>> --- a/arch/arm/include/asm/arch-mx6/iomux.h
>> +++ b/arch/arm/include/asm/arch-mx6/iomux.h
>> @@ -178,4 +178,17 @@
>>  |IOMUXC_GPR13_SATA_PHY_3_MASK \
>>  |IOMUXC_GPR13_SATA_PHY_2_MASK \
>>  |IOMUXC_GPR13_SATA_PHY_1_MASK)
>> +
>> +/*
>> + * Setup RGMII voltage levels on iMX6 SoC - the
>> + *
>> + * IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII - register
>> + *
>> + * 1P2V_IO - USB_HSIC, MIPI_HSI
>> + * 1P5V_IO - ENET pins
>> + */
>> +#define IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII0x020e0790
>> +#define DDR_SEL_1P2V_IO (0x2 << 18)
>> +#define DDR_SEL_1P5V_IO (0x3 << 18)
>> +
>>  #endif  /* __ASM_ARCH_IOMUX_H__ */
>> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h 
>> b/arch/arm/include/asm/arch-mx6/sys_proto.h
>> index b22a7a0f8b..72ab7d814f 100644
>> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h
>> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
>> @@ -6,6 +6,7 @@
>>   */
>>  
>>  #include 
>> +#include 
>>  
>>  #define USBPHY_PWD  0x
>>  
>> @@ -16,3 +17,13 @@
>>  
>>  int imx6_pcie_toggle_power(void);
>>  int imx6_pcie_toggle_reset(void);
>> +
>> +/**
>> + * iomuxc_set_rgmii_io_voltage - set voltage level of RGMII/USB pins
>> + *
>> + * @param io_vol - the voltage IO level of pins
>> + */
>> +static inline void iomuxc_set_rgmii_io_voltage(int io_vol)
>> +{
>> +__raw_writel(io_vol, IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII);
>> +}
>>
> 
> Applied to u-boot-imx, -master, thanke !
> 

I was too optimistic. This breaks the "marsboard" board (same name for
function). Can you review this and fix it, please ?

Thanks,
Stefano


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 07/15] spl: atf: introduce spl_invoke_atf and make bl31_entry private

[Dr. Philipp Tomsich]

> On 17 Sep 2017, at 19:53, Simon Glass  wrote:
> 
> Hi Philipp,
> 
> On 13 September 2017 at 13:29, Philipp Tomsich
>  > wrote:
>> This adds a new interface spl_invoke_atf() that takes a spl_image_info
>> argument and then derives the necessary parameters for the ATF entry.
>> Based on the additional information recorded (into /fit-images) from
>> the FIT loadables, we can now easily locate the next boot stage.
>> 
>> We now pass a pointer to a FDT as the platform-specific parameter
>> pointer to ATF (so we don't run into the future headache of every
>> board/platform defining their own proprietary tag-structure), as
>> FDT access is already available in ATF.
>> 
>> With the necessary infrastructure in place, we can now update the
>> support for the ARM Trusted Firmware to dispatch into the
>> spl_invoke_atf function only if a IH_OS_ARM_TRUSTED_FIRMWARE image is
>> loaded.
>> 
>> Signed-off-by: Philipp Tomsich 
>> ---
>> 
>> common/spl/spl.c | 11 +++
>> common/spl/spl_atf.c | 84 
>> +++-
>> 2 files changed, 82 insertions(+), 13 deletions(-)
> 
> Reviewed-by: Simon Glass >
> 
> Please see question below
> 
> [..]
> 
>> index 6e8f928..63557c0 100644
>> --- a/common/spl/spl_atf.c
>> +++ b/common/spl/spl_atf.c
>> @@ -5,6 +5,7 @@
>>  * reserved.
>>  * Copyright (C) 2016 Rockchip Electronic Co.,Ltd
>>  * Written by Kever Yang > >
>> + * Copyright (C) 2017 Theobroma Systems Design und Consulting GmbH
>>  *
>>  * SPDX-License-Identifier: BSD-3-Clause
>>  */
>> @@ -30,7 +31,7 @@ static struct bl31_params *bl2_to_bl31_params;
>>  *
>>  * @return bl31 params structure pointer
>>  */
>> -struct bl31_params *bl2_plat_get_bl31_params(void)
>> +static struct bl31_params *bl2_plat_get_bl31_params(uintptr_t bl33_entry)
>> {
>>struct entry_point_info *bl33_ep_info;
>> 
>> @@ -66,7 +67,7 @@ struct bl31_params *bl2_plat_get_bl31_params(void)
>> 
>>/* BL33 expects to receive the primary CPU MPID (through x0) */
>>bl33_ep_info->args.arg0 = 0x & read_mpidr();
>> -   bl33_ep_info->pc = CONFIG_SYS_TEXT_BASE;
>> +   bl33_ep_info->pc = bl33_entry;
>>bl33_ep_info->spsr = SPSR_64(MODE_EL2, MODE_SP_ELX,
>> DISABLE_ALL_EXECPTIONS);
>> 
>> @@ -77,21 +78,88 @@ struct bl31_params *bl2_plat_get_bl31_params(void)
>>return bl2_to_bl31_params;
>> }
>> 
>> -void raw_write_daif(unsigned int daif)
>> +static inline void raw_write_daif(unsigned int daif)
>> {
>>__asm__ __volatile__("msr DAIF, %0\n\t" : : "r" (daif) : "memory");
>> }
>> 
>> -void bl31_entry(void)
>> +typedef void (*atf_entry_t)(struct bl31_params *params, void *plat_params);
>> +
>> +static void bl31_entry(uintptr_t bl31_entry, uintptr_t bl33_entry,
>> +  uintptr_t fdt_addr)
>> {
>>struct bl31_params *bl31_params;
>> -   void (*entry)(struct bl31_params *params, void *plat_params) = NULL;
>> +   atf_entry_t  atf_entry = (atf_entry_t)bl31_entry;
>> 
>> -   bl31_params = bl2_plat_get_bl31_params();
>> -   entry = (void *)CONFIG_SPL_ATF_TEXT_BASE;
>> +   bl31_params = bl2_plat_get_bl31_params(bl33_entry);
>> 
>>raw_write_daif(SPSR_EXCEPTION_MASK);
>>dcache_disable();
>> 
>> -   entry(bl31_params, NULL);
>> +   atf_entry((void *)bl31_params, (void *)fdt_addr);
>> +}
>> +
>> +static int spl_fit_images_find_uboot(void *blob)
>> +{
>> +   int parent, node, ndepth;
>> +   const void *data;
>> +
>> +   if (!blob)
>> +   return -FDT_ERR_BADMAGIC;
>> +
>> +   parent = fdt_path_offset(blob, "/fit-images");
>> +   if (parent < 0)
>> +   return -FDT_ERR_NOTFOUND;
>> +
>> +   for (node = fdt_next_node(blob, parent, );
>> +(node >= 0) && (ndepth > 0);
>> +node = fdt_next_node(blob, node, )) {
>> +   if (ndepth != 1)
>> +   continue;
>> +
>> +   data = fdt_getprop(blob, node, FIT_OS_PROP, NULL);
>> +   if (!data)
>> +   continue;
>> +
>> +   if (genimg_get_os_id(data) == IH_OS_U_BOOT)
>> +   return node;
> 
> How come this is in 'data' instead of the 'type' property?

In fact it’s in FIT_OS_PROP (which expands to “os”).
Naming this variable ‘data' may have not been the best choice, but ‘prop’ didn’t
seem much better…

Regards,
Philipp.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v4] imx:display5: Add support for LWN's DISPLAY5 board (for v2017.11-rc2+)

[Stefano Babic]

Hi Lukasz,

On 31/10/2017 17:58, Lukasz Majewski wrote:
> This commit provides support for LWN's IMX6Q based DISPLAY5 board.
> 

I would merge it, but why the commit message is still "(for
v2017.11-rc2+)" ? This goes into git history if I merge it.

Can I drop it by merging ?

Best regards,
Stefano

> Signed-off-by: Lukasz Majewski 
> 
> ---
> 
> Changes in v4:
> - Refactor obscure sw/hw rev code for display5 board
> - replace get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE); with 
> imx_ddr_size()
> - remove PHYS_SDRAM_SIZE from display5.h
> - Replace non generic setup of RGMII pins voltage levels with a generic
> function
> - Move displ5_set_iomux_uart() - non console UART init to board_init()
> - Disable board_early_init_f() calls (prod/factory)
> - Move mtdparts to Kconfig for production and flash u-boot
> 
> Changes in v3:
> - Remove ip custom data
> - Cleanup SPL code
> 
> Changes in v2:
> - Update to newest mainline u-boot
> 
>  arch/arm/dts/imx6q-display5.dts |  18 ++
>  arch/arm/mach-imx/mx6/Kconfig   |   7 +
>  board/liebherr/display5/Kconfig |  18 ++
>  board/liebherr/display5/MAINTAINERS |   7 +
>  board/liebherr/display5/Makefile|  11 +
>  board/liebherr/display5/common.c| 111 ++
>  board/liebherr/display5/common.h|  42 
>  board/liebherr/display5/display5.c  | 384 +
>  board/liebherr/display5/spl.c   | 247 ++
>  configs/display5_defconfig  |  62 ++
>  configs/display5_factory_defconfig  |  76 +++
>  include/configs/display5.h  | 408 
> 
>  12 files changed, 1391 insertions(+)
>  create mode 100644 arch/arm/dts/imx6q-display5.dts
>  create mode 100644 board/liebherr/display5/Kconfig
>  create mode 100644 board/liebherr/display5/MAINTAINERS
>  create mode 100644 board/liebherr/display5/Makefile
>  create mode 100644 board/liebherr/display5/common.c
>  create mode 100644 board/liebherr/display5/common.h
>  create mode 100644 board/liebherr/display5/display5.c
>  create mode 100644 board/liebherr/display5/spl.c
>  create mode 100644 configs/display5_defconfig
>  create mode 100644 configs/display5_factory_defconfig
>  create mode 100644 include/configs/display5.h
> 
> diff --git a/arch/arm/dts/imx6q-display5.dts b/arch/arm/dts/imx6q-display5.dts
> new file mode 100644
> index 00..50347ff26b
> --- /dev/null
> +++ b/arch/arm/dts/imx6q-display5.dts
> @@ -0,0 +1,18 @@
> +/*
> + * Copyright 2017
> + * Lukasz Majewski, DENX Software Engineering, lu...@denx.de
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6q.dtsi"
> +
> +/ {
> + model = "Liebherr (LWN) display5 i.MX6 Quad Board";
> + compatible = "lwn,display5", "fsl,imx6q";
> +};
> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
> index b82db3af22..fd73c67fde 100644
> --- a/arch/arm/mach-imx/mx6/Kconfig
> +++ b/arch/arm/mach-imx/mx6/Kconfig
> @@ -138,6 +138,12 @@ config TARGET_DHCOMIMX6
>   select DM_THERMAL
>   imply CMD_SPL
>  
> +config TARGET_DISPLAY5
> + bool "LWN DISPLAY5 board"
> + select SUPPORT_SPL
> + select DM
> + select DM_SERIAL
> +
>  config TARGET_EMBESTMX6BOARDS
>   bool "embestmx6boards"
>   select BOARD_LATE_INIT
> @@ -459,6 +465,7 @@ source "board/phytec/pfla02/Kconfig"
>  source "board/gateworks/gw_ventana/Kconfig"
>  source "board/kosagi/novena/Kconfig"
>  source "board/samtec/vining_2000/Kconfig"
> +source "board/liebherr/display5/Kconfig"
>  source "board/liebherr/mccmon6/Kconfig"
>  source "board/logicpd/imx6/Kconfig"
>  source "board/seco/Kconfig"
> diff --git a/board/liebherr/display5/Kconfig b/board/liebherr/display5/Kconfig
> new file mode 100644
> index 00..b096c8917a
> --- /dev/null
> +++ b/board/liebherr/display5/Kconfig
> @@ -0,0 +1,18 @@
> +if TARGET_DISPLAY5
> +
> +config SYS_CPU
> + default "armv7"
> +
> +config SYS_BOARD
> + default "display5"
> +
> +config SYS_VENDOR
> + default "liebherr"
> +
> +config SYS_SOC
> + default "mx6"
> +
> +config SYS_CONFIG_NAME
> + default "display5"
> +
> +endif
> diff --git a/board/liebherr/display5/MAINTAINERS 
> b/board/liebherr/display5/MAINTAINERS
> new file mode 100644
> index 00..52178318b5
> --- /dev/null
> +++ b/board/liebherr/display5/MAINTAINERS
> @@ -0,0 +1,7 @@
> +DISPLAY5 BOARD
> +M:   Lukasz Majewski 
> +S:   Maintained
> +F:   board/liebherr/display5/
> +F:   include/configs/display5.h
> +F:   configs/display5_defconfig
> +F:   configs/display5_factory_defconfig
> diff --git a/board/liebherr/display5/Makefile 
> b/board/liebherr/display5/Makefile
> new file mode 100644
> index 00..f934672428
> --- /dev/null
> +++ 

Re: [U-Boot] [PATCH] imx6: iomux: Add generic function to set RGMII IO voltage on IMX6 SoCs

[Stefano Babic]

On 31/10/2017 13:26, Lukasz Majewski wrote:
> This commit provides generic function to set the RGMII/HSIC IO voltage
> level on iMX6 devices.
> 
> Signed-off-by: Lukasz Majewski 
> ---
> 
>  arch/arm/include/asm/arch-mx6/iomux.h | 13 +
>  arch/arm/include/asm/arch-mx6/sys_proto.h | 11 +++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-mx6/iomux.h 
> b/arch/arm/include/asm/arch-mx6/iomux.h
> index 907cb408ff..ee3a56583b 100644
> --- a/arch/arm/include/asm/arch-mx6/iomux.h
> +++ b/arch/arm/include/asm/arch-mx6/iomux.h
> @@ -178,4 +178,17 @@
>   |IOMUXC_GPR13_SATA_PHY_3_MASK \
>   |IOMUXC_GPR13_SATA_PHY_2_MASK \
>   |IOMUXC_GPR13_SATA_PHY_1_MASK)
> +
> +/*
> + * Setup RGMII voltage levels on iMX6 SoC - the
> + *
> + * IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII - register
> + *
> + * 1P2V_IO - USB_HSIC, MIPI_HSI
> + * 1P5V_IO - ENET pins
> + */
> +#define IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII 0x020e0790
> +#define DDR_SEL_1P2V_IO (0x2 << 18)
> +#define DDR_SEL_1P5V_IO (0x3 << 18)
> +
>  #endif   /* __ASM_ARCH_IOMUX_H__ */
> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h 
> b/arch/arm/include/asm/arch-mx6/sys_proto.h
> index b22a7a0f8b..72ab7d814f 100644
> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
> @@ -6,6 +6,7 @@
>   */
>  
>  #include 
> +#include 
>  
>  #define USBPHY_PWD   0x
>  
> @@ -16,3 +17,13 @@
>  
>  int imx6_pcie_toggle_power(void);
>  int imx6_pcie_toggle_reset(void);
> +
> +/**
> + * iomuxc_set_rgmii_io_voltage - set voltage level of RGMII/USB pins
> + *
> + * @param io_vol - the voltage IO level of pins
> + */
> +static inline void iomuxc_set_rgmii_io_voltage(int io_vol)
> +{
> + __raw_writel(io_vol, IOMUXC_SW_PAD_CTL_GRP_DDR_TYPE_RGMII);
> +}
> 

Applied to u-boot-imx, -master, thanke !

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 1/2] i.MX6: engicam: Fix MAINTAINERS/README

[Stefano Babic]

Hi Jagan,

On 30/10/2017 10:57, Jagan Teki wrote:
> - Update newly added include/configs file in MAINTAINERS
> - Update newly added defconfig file in README
> 
> Signed-off-by: Jagan Teki 
> ---

Applied to u-boot-imx, -master - thanks !

Patch 2/2 dropped as discussed in thread, issue already solved by
Fabio's patch.

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 1/3] mx25: Move MX25 selection to Kconfig

[Stefano Babic]

Hi Tom,

On 07/11/2017 02:22, Tom Rini wrote:
> On Mon, Nov 06, 2017 at 09:44:40PM -0200, Fabio Estevam wrote:
>> Hi Stefano and Tom,
>>
>> On Fri, Nov 3, 2017 at 1:40 PM, Fabio Estevam  wrote:
>>> From: Fabio Estevam 
>>>
>>> The motivation for moving MX25 selection to Kconfig is to be
>>> able to better handle MX25 specific errata, so that an errata option
>>> can be selected at SoC level instead of board level.
>>>
>>> This selection method also aligns with the way other i.MX SoCs are
>>> selected in U-Boot.
>>>
>>> Signed-off-by: Fabio Estevam 
>>> Acked-by: Sebastien Bourdelin 
>>
>> Could you please consider this series (bug fix) for 2017.11?
> 
> Otavio brought this up to me as well today, I would be happy to see this
> come in as a bugfix.  Thanks!
> 

I merge into u-boot-imx and I'll send my PR - thanks !

Best regards,
Stefano

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] common: Generic file system firmware loader

[Chee, Tien Fong]

On Isn, 2017-11-06 at 11:56 +0100, Marek Vasut wrote:
> On 11/06/2017 05:15 AM, Chee, Tien Fong wrote:
> > 
> > On Ahd, 2017-11-05 at 17:43 +0100, Marek Vasut wrote:
> > > 
> > > On 11/02/2017 09:20 AM, Chee, Tien Fong wrote:
> > > > 
> > > > 
> > > > On Rab, 2017-11-01 at 10:26 +0100, Marek Vasut wrote:
> > > > > 
> > > > > 
> > > > > On 11/01/2017 10:18 AM, tien.fong.c...@intel.com wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > From: Tien Fong Chee 
> > > > > > 
> > > > > > Generic firmware loader framework contains some common
> > > > > > functionality
> > > > > > which is factored out from splash loader. It is reusable by
> > > > > > any
> > > > > > specific driver file system firmware loader. Specific
> > > > > > driver
> > > > > > file
> > > > > > system
> > > > > > firmware loader handling can be defined with both weak
> > > > > > function
> > > > > > fsloader_preprocess and fs_loading.
> > > > > > 
> > > > > > Signed-off-by: Tien Fong Chee 
> > > > > > ---
> > > > > >  common/Makefile   |   1 +
> > > > > >  common/load_fs.c  | 217
> > > > > > ++
> > > > > >  include/load_fs.h |  38 ++
> > > > > >  3 files changed, 256 insertions(+)
> > > > > >  create mode 100644 common/load_fs.c
> > > > > >  create mode 100644 include/load_fs.h
> > > > > [...]
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > +int flash_select_fs_dev(struct flash_location *location)
> > > > > Why does everything have flash_ prefix ?
> > > > > 
> > > > I can remove the flash_ prefix, this generic FS loader should
> > > > support
> > > > for all filesystem instead of flash.
> > > > 
> > > > > 
> > > > > 
> > > > > I also mentioned the API should copy the linux firmware
> > > > > loader
> > > > > API.
> > > > > 
> > > > If i'm not mistaken, you are referring firmware loader API in
> > > > this
> > > > link https://github.com/torvalds/linux/blob/f007cad159e99fa2acd
> > > > 3b2e
> > > > 9364
> > > > fbb32ad28b971/drivers/base/firmware_class.c#L1264.
> > > > 
> > I would like to confirm with you whether we are talking to the same
> > API
> > above?
> https://www.kernel.org/doc/html/v4.13/driver-api/firmware/index.html
> 
> first link on google btw . You might be able to avoid the firmware
> structure.
> 
After assessment, i found that Linux loader is not suitable for fpga
loader as fpga loader need
1) Able to program FPGA image in SPL chunk bu chunk with small memory
allocatted.
2) Name of FPGA image defined in DTS, and path of FPGA image in FAT and
UBI partition.

Linux loader is strongly designed based on Linux environment, always
assume having RFF, env support(which SPL don't have), sysfs and udev
feature.

Thanks.
> [...]
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PULL] Please pull u-boot-rockchip

[Dr. Philipp Tomsich]

Tom,

Here’s another pull-request for u-boot-rockchip for some last-minute 
DTS-updates and
config-changes for the upcoming release.

Regards,
Philipp.


The following changes since commit 7a69604bce9a9a9476753af64e5a1870880c1333:

  Prepare v2017.11-rc4 (2017-11-06 18:25:37 -0500)

are available in the git repository at:

  git://git.denx.de/u-boot-rockchip.git master

for you to fetch changes up to 021a8ae00a2f9adcba460add4b69da7bc569fd52:

  rockchip: remove SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR from defconfig (2017-11-07 
09:16:58 +0100)


Kever Yang (6):
  rockchip: rock: remove CONFIG_ENV_OFFSET
  rockchip: config: sync the ENV offset from rockchip legacy U-Boot
  rockchip: config: use common CONFIG_ENV_SIZE for all SoCs
  spl: set SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR to 0x4000 for rockchip
  rockchip: doc: update U-Boot location info
  rockchip: remove SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR from defconfig

Klaus Goger (3):
  rockchip: dts: Use defines for pin names in rk3399-puma.dtsi and 
rk3368-lion.dts
  rockchip: dts: rk3399: change sd-card io voltage to 3.0V
  rockchip: board: puma_rk3399: make env location selectable via Kconfig

Philipp Tomsich (3):
  rockchip: dts: rk3399-puma: fix the modelling of BIOS_DISABLE
  rockchip: dts: rk3399-puma: update usbhub_enable regulator
  rockchip: dts: rk3399-puma: update USB configuration

 arch/arm/dts/rk3368-lion.dts  |  2 +-
 arch/arm/dts/rk3399-firefly.dts   |  4 ++--
 arch/arm/dts/rk3399-puma.dtsi | 64 

 common/spl/Kconfig|  3 ++-
 configs/evb-rk3399_defconfig  |  1 -
 configs/firefly-rk3399_defconfig  |  1 -
 doc/README.rockchip   |  6 +++---
 include/configs/evb_rk3229.h  |  2 --
 include/configs/kylin_rk3036.h|  2 --
 include/configs/lion_rk3368.h |  1 -
 include/configs/puma_rk3399.h |  8 
 include/configs/rk3036_common.h   |  1 -
 include/configs/rk3188_common.h   |  1 -
 include/configs/rk322x_common.h   |  1 -
 include/configs/rk3288_common.h   |  1 -
 include/configs/rk3328_common.h   |  1 -
 include/configs/rk3399_common.h   |  1 -
 include/configs/rock.h| 14 --
 include/configs/rockchip-common.h | 16 
 include/configs/sheep_rk3368.h|  1 -
 20 files changed, 52 insertions(+), 79 deletions(-)

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot