Re: [U-Boot] [PATCH 2/2] arm: k3: Use get_ti_sci_handle() where ever possible
On Mon, Sep 09, 2019 at 12:47:38PM +0530, Lokesh Vutla wrote: > Instead of calling uclass apis everywhere, use get_ti_sci_handle() > when ever ti_sci is needed. > > Signed-off-by: Lokesh Vutla Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] arm: k3: Fix getting ti_sci handle
On Mon, Sep 09, 2019 at 12:47:37PM +0530, Lokesh Vutla wrote: > API get_ti_sci_handle() is relying on the device-tree node name > to be "dmsc" for probing the ti_sci device. But with the introduction > of debug messages for dmsc, the node name changed to dmsc@44083000. > Because of this ti_sci is never probed cause a boot failure. Instead > of relying on device-tree node name, use the first available firmware > node for probing ti_sci. > > Signed-off-by: Lokesh Vutla Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH V2 4/4] ARM: omapl138_lcdk: Enable Pinctrl
On Mon, Sep 02, 2019 at 06:52:04AM -0500, Adam Ford wrote: > The single pinctrl supports the da8xx, so this patch enables > pinctrl in U-Boot. > > Signed-off-by: Adam Ford Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH V2 3/4] ARM: omapl138_lcdk: Enable DM_GPIO and DM and GPIO Commands
On Mon, Sep 02, 2019 at 06:52:03AM -0500, Adam Ford wrote: > The da8xx GPIO driver is available with DM_GPIO support. This > patch enables the CMD_GPIO, CMD_DM, and DM_GPIO and DA8XX_GPIO. > > Signed-off-by: Adam Ford Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH V2 1/4] ARM: omapl138_lcdk: Remove dead code
On Mon, Sep 02, 2019 at 06:52:01AM -0500, Adam Ford wrote: > The header it littered with #ifdefs and #defines and that appear > to be legacy associations to the older da850-evm and in some cases > obsolete with either Kconfig or DM migrations. This patch removes > these legacy references. > > Signed-off-by: Adam Ford Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] arm: am437x: cm-t43: Enable DM for MMC, USB, SPI, SPI_FLASH, enable BLK
On Sat, Aug 31, 2019 at 01:36:13AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Enable driver model for USB, MMC, SPI and SPI_FLASH. Also enable BLK. > This will remove the following compile warnings: > > = WARNING == > This board does not use CONFIG_DM_MMC. Please update > the board to use CONFIG_DM_MMC before the v2019.04 release. > > = WARNING == > This board does not use CONFIG_DM_USB. Please update > the board to use CONFIG_DM_USB before the v2019.07 release. > > = WARNING == > This board does not use CONFIG_DM_SPI_FLASH. Please update > the board to use CONFIG_SPI_FLASH before the v2019.07 release. > > Target was compile tested, build was clean. > > Signed-off-by: Suniel Mahesh Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH V2 2/4] ARM: omapl138_lcdk: Disable SPL_DM_USB
On Mon, Sep 02, 2019 at 06:52:02AM -0500, Adam Ford wrote: > The USB was just recently enabled, so it is unlikely anyone is > using it in SPL, so this patch removes it from SPL to further > reduce the SPL code size. > > Signed-off-by: Adam Ford Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] soc: ti: k3-navss-ringacc: fix k3_nav_ringacc_ring_reset_dma
On Fri, Aug 30, 2019 at 11:02:24AM +0530, Vignesh Raghavendra wrote: > In case dma_ring_reset_quirk is not set the k3_ringacc_ring_reset_dma will > just exit without ring reset. Fix it, by adding ring reset call in case > dma_ring_reset_quirk is not. > > Signed-off-by: Grygorii Strashko > Signed-off-by: Vignesh Raghavendra Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] arm: am437x: cm-t43: Add device tree, enable OF_CONTROL
On Sat, Aug 31, 2019 at 01:34:59AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Add device tree from Linux for driver model conversion > and enable OF_CONTROL. This will remove the following compile > warning: > == > Device Tree Source is not correctly specified. > Please define 'CONFIG_DEFAULT_DEVICE_TREE' > or build with 'DEVICE_TREE=' argument > === > Target was compile tested, build was clean. > > Signed-off-by: Suniel Mahesh Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: dts: dra74x: Fix iodelay configuration for mmc3
On Tue, Aug 27, 2019 at 01:41:23PM +0530, Faiz Abbas wrote: > According to the latest am572x[1] and dra74x[2] data manuals, mmc3 > default, hs, sdr12 and sdr25 modes use iodelay values given in > MMC3_MANUAL1. Set the MODE_SELECT bit for these so that manual mode is > selected and correct iodelay values are configured. > > [1] http://www.ti.com/lit/ds/symlink/am5728.pdf > [2] http://www.ti.com/lit/ds/symlink/dra746.pdf > > Signed-off-by: Faiz Abbas Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] configs: am65x_hs_evm: Use FIT images when booting HS devices
On Mon, Aug 26, 2019 at 05:51:01PM -0400, Andrew F. Davis wrote: > HS devices use the FIT post processing step to authenticate boot images. > Set the configured boot command to load FIT by default. > > Signed-off-by: Andrew F. Davis Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] configs: ti: Add environment support commands for FIT loading
On Mon, Aug 26, 2019 at 05:51:00PM -0400, Andrew F. Davis wrote: > Some parts of these commands can be reused, add them to common files. > > Signed-off-by: Andrew F. Davis Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 3/4] sh: r2dplus: Fix missing PCI range
Add missing PCI range for translating DRAM to bus addresses. This fixes e.g. PCI NIC interface and allows network to work in QEMU. Signed-off-by: Marek Vasut Cc: Nobuhiro Iwamatsu --- NOTE: Use qemu e.g. this way: qemu-system-sh4 -machine r2d -nographic \ -serial null -serial mon:stdio -kernel u-boot.bin \ -netdev user,id=n1,tftp=/srv/tftp \ -device rtl8139,netdev=n1,mac=00:aa:bb:cc:dd:ee NOTE: Tested with qemu 4.1.0 --- arch/sh/dts/sh7751-r2dplus.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/sh/dts/sh7751-r2dplus.dts b/arch/sh/dts/sh7751-r2dplus.dts index ecaf0772d8..efaeb33e36 100644 --- a/arch/sh/dts/sh7751-r2dplus.dts +++ b/arch/sh/dts/sh7751-r2dplus.dts @@ -21,6 +21,7 @@ #size-cells = <2>; #interrupt-cells = <1>; ranges = <0x0100 0 0xfe24 0 0xfe24 0 0x0004 - 0x0200 0 0xfd00 0 0xfd00 0 0x0100>; + 0x0200 0 0xfd00 0 0xfd00 0 0x0100 + 0x4200 0 0x0c00 0 0x8c00 0 0x0400>; }; }; -- 2.23.0.rc1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 4/4] sh: r2dplus: Enable DHCP command
Enable the "dhcp" command as a minor convenience. Signed-off-by: Marek Vasut Cc: Nobuhiro Iwamatsu --- configs/r2dplus_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/r2dplus_defconfig b/configs/r2dplus_defconfig index b2334affc3..e10ac939c5 100644 --- a/configs/r2dplus_defconfig +++ b/configs/r2dplus_defconfig @@ -12,6 +12,7 @@ CONFIG_CMD_DM=y CONFIG_CMD_IDE=y CONFIG_CMD_PCI=y # CONFIG_CMD_SETEXPR is not set +CONFIG_CMD_DHCP=y CONFIG_CMD_PING=y CONFIG_CMD_CACHE=y CONFIG_CMD_EXT2=y -- 2.23.0.rc1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 2/4] sh: Fix SH4 build with GCC versions without -m4-nofpu
Pass -m4 instead of -m4-nofpu to GCC versions which do not support the -m4-nofpu option. Signed-off-by: Marek Vasut Cc: Nobuhiro Iwamatsu --- arch/sh/cpu/sh4/config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/cpu/sh4/config.mk b/arch/sh/cpu/sh4/config.mk index d62d285e60..23fec66492 100644 --- a/arch/sh/cpu/sh4/config.mk +++ b/arch/sh/cpu/sh4/config.mk @@ -6,4 +6,4 @@ # (C) Copyright 2007 # Nobuhiro Iwamatsu # -PLATFORM_CPPFLAGS += -m4-nofpu +PLATFORM_CPPFLAGS += $(call cc-option,-m4-nofpu,-m4) -- 2.23.0.rc1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 1/4] sh: Fix incorrect linking with new binutils
Since binutils 2.30 , the resulting U-Boot binary was incorrectly linked
against address 0 instead of text base, fix it.
Signed-off-by: Marek Vasut
Cc: Nobuhiro Iwamatsu
---
arch/sh/cpu/u-boot.lds | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/cpu/u-boot.lds b/arch/sh/cpu/u-boot.lds
index 47302da252..4cc97737f1 100644
--- a/arch/sh/cpu/u-boot.lds
+++ b/arch/sh/cpu/u-boot.lds
@@ -25,6 +25,7 @@ ENTRY(_start)
SECTIONS
{
+ . = CONFIG_SYS_TEXT_BASE;
reloc_dst = .;
PROVIDE (_ftext = .);
--
2.23.0.rc1
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper
Joe Hershberger schrieb am Sa., 14. Sep. 2019, 20:46: > On Sat, Sep 14, 2019 at 1:32 PM Tom Rini wrote: > > > > On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > > > Hi, > > > > > > On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > > > > Part of the env cleanup moved this out of the environment code and > into > > > > the net code. However, this helper is sometimes needed even when the > net > > > > stack isn't included. > > > > > > > > Move the helper to lib/net_utils.c like it's similarly-purposed > > > > string_to_ip(). Also rename the moved function to similar naming. > > > > > > > > Signed-off-by: Joe Hershberger > > > > Reported-by: Ondrej Jirman > > > > > > I've tested the patch and it works, but I'be found other related > issue, where > > > u-boot thinks %pM will format a MAC address string, but it does just > > > print out the pointer due to relevant functions being gated by > CONFIG_CMD_NET > > > guard in lib/vsprintf.c. > > > > > > The gating should probably be done so that it panics/halts the u-boot > if gated > > > pointer flags are used by u-boot code, because that will clearly be > incorrect, > > > without calling code ever knowing. This way the user will know that > something > > > is wrong and will have to fix the code. > > > > I'm not in favor of panic because of calling an unimplemented print > > format character. I guess we'll need to see what the size increase is > > on un-guarding these formats and go from there. > > I'll look into it. I'm also not in favor of a panic. > In lwIP, we're using macros for such format characters. Would it work to do that here and make the compiler complain about an undefined symbol of the macro for this extended format character isn't defined? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper
On Sat, Sep 14, 2019 at 1:32 PM Tom Rini wrote: > > On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > > Hi, > > > > On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > > > Part of the env cleanup moved this out of the environment code and into > > > the net code. However, this helper is sometimes needed even when the net > > > stack isn't included. > > > > > > Move the helper to lib/net_utils.c like it's similarly-purposed > > > string_to_ip(). Also rename the moved function to similar naming. > > > > > > Signed-off-by: Joe Hershberger > > > Reported-by: Ondrej Jirman > > > > I've tested the patch and it works, but I'be found other related issue, > > where > > u-boot thinks %pM will format a MAC address string, but it does just > > print out the pointer due to relevant functions being gated by > > CONFIG_CMD_NET > > guard in lib/vsprintf.c. > > > > The gating should probably be done so that it panics/halts the u-boot if > > gated > > pointer flags are used by u-boot code, because that will clearly be > > incorrect, > > without calling code ever knowing. This way the user will know that > > something > > is wrong and will have to fix the code. > > I'm not in favor of panic because of calling an unimplemented print > format character. I guess we'll need to see what the size increase is > on un-guarding these formats and go from there. I'll look into it. I'm also not in favor of a panic. -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper
On Sat, Sep 14, 2019 at 04:05:44PM +0200, Ondřej Jirman wrote: > Hi, > > On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote: > > Part of the env cleanup moved this out of the environment code and into > > the net code. However, this helper is sometimes needed even when the net > > stack isn't included. > > > > Move the helper to lib/net_utils.c like it's similarly-purposed > > string_to_ip(). Also rename the moved function to similar naming. > > > > Signed-off-by: Joe Hershberger > > Reported-by: Ondrej Jirman > > I've tested the patch and it works, but I'be found other related issue, where > u-boot thinks %pM will format a MAC address string, but it does just > print out the pointer due to relevant functions being gated by CONFIG_CMD_NET > guard in lib/vsprintf.c. > > The gating should probably be done so that it panics/halts the u-boot if gated > pointer flags are used by u-boot code, because that will clearly be incorrect, > without calling code ever knowing. This way the user will know that something > is wrong and will have to fix the code. I'm not in favor of panic because of calling an unimplemented print format character. I guess we'll need to see what the size increase is on un-guarding these formats and go from there. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] ARMv7-a NEON optimizations
I was Googling ARM Neon optimizations, and I came across a pay-article written by someone who was talking about optimizing ECC using NEON. I didn't want to buy the article, nor would I understand it, but I was thinking about running some tests on whether or not NEON could be enabled in U-Boot. At least for the OMAP3 boards which have HW detection and SW correction, I was wondering if the enhanced integer math might be useful for increasing NAND flash performance by helping with ECC calculations on board without HW correction. I will admit that I don't know much about the NEON stuff or ECC, but when reading about it from GCC documentation, and it states: "For floating-point and Advanced SIMD (Neon) instructions, the settings of the options -mfloat-abi and -mfpu must also be considered: floating-point and Advanced SIMD instructions will only be used if -mfloat-abi is not set to ‘soft’; and any setting of -mfpu other than ‘auto’ will override the available floating-point and SIMD extension instructions." I looked through the build instructions, and it appears that we use: arch/arm/config.mk:PLATFORM_RELFLAGS += $(call cc-option, -msoft-float) \ I wasn't sure how -msoft-float compares to mfloat-abi, but when I tried to change msoft-float to mhard-float it stopped working. Can someone tell me if/why we still need to hard-code msoft-float? Maybe I am wasting my time, but it seems like if the NEON has the ability to accelerate integers and not just floating points, it seems like there might be some performance enhancements depending on how the math works. I was hoping to run some simple benchmarks, but I cannot even get u-boot or SPL if I play around with the msoft-float, but some platforms disable it. The Zynq platform seems to partially enable this, but it seems like it could be made more generic for any NEON enabled ARM. arch/arm/mach-zynq/Makefile:AFLAGS_lowlevel_init.o := -mfpu=neon adam ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] U-boot Tegra 3
Hi, can you help me to solve problem with u-boot. I have tegra30 board like (180-61852-1606-c00) it’s looks like cardhu one. But when I build(cardhu board) u-boot and run it, I have error when I want to select emmc card. Error: Card did not respond to voltage select! , mmc_init: -95, time 77. Can you help me or give advice how I can initialize this emmc. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper
Hi,
On Fri, Sep 13, 2019 at 07:40:22PM -0500, Joe Hershberger wrote:
> Part of the env cleanup moved this out of the environment code and into
> the net code. However, this helper is sometimes needed even when the net
> stack isn't included.
>
> Move the helper to lib/net_utils.c like it's similarly-purposed
> string_to_ip(). Also rename the moved function to similar naming.
>
> Signed-off-by: Joe Hershberger
> Reported-by: Ondrej Jirman
I've tested the patch and it works, but I'be found other related issue, where
u-boot thinks %pM will format a MAC address string, but it does just
print out the pointer due to relevant functions being gated by CONFIG_CMD_NET
guard in lib/vsprintf.c.
The gating should probably be done so that it panics/halts the u-boot if gated
pointer flags are used by u-boot code, because that will clearly be incorrect,
without calling code ever knowing. This way the user will know that something
is wrong and will have to fix the code.
I noticed be cause produced mac address is wrong.
Quick fix is to remove the CONFIG_CMD_NET gate.
regards,
o.
>
> ---
>
> arch/arm/mach-tegra/cboot.c | 2 +-
> board/renesas/sh7752evb/sh7752evb.c | 2 +-
> board/renesas/sh7753evb/sh7753evb.c | 2 +-
> board/renesas/sh7757lcr/sh7757lcr.c | 4 ++--
> cmd/ethsw.c | 2 +-
> cmd/nvedit.c| 2 +-
> doc/README.enetaddr | 4 ++--
> include/net.h | 24 +---
> lib/net_utils.c | 15 +++
> net/eth-uclass.c| 2 +-
> net/eth_legacy.c| 2 +-
> net/net.c | 12
> 12 files changed, 39 insertions(+), 34 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/cboot.c b/arch/arm/mach-tegra/cboot.c
> index 0433081c6c..0762144ecf 100644
> --- a/arch/arm/mach-tegra/cboot.c
> +++ b/arch/arm/mach-tegra/cboot.c
> @@ -495,7 +495,7 @@ static int cboot_get_ethaddr_legacy(const void *fdt,
> uint8_t mac[ETH_ALEN])
> return -ENOENT;
> }
>
> - eth_parse_enetaddr(prop, mac);
> + string_to_enetaddr(prop, mac);
>
> if (!is_valid_ethaddr(mac)) {
> printf("Invalid MAC address: %s\n", prop);
> diff --git a/board/renesas/sh7752evb/sh7752evb.c
> b/board/renesas/sh7752evb/sh7752evb.c
> index d0b850f35d..b4292b22e7 100644
> --- a/board/renesas/sh7752evb/sh7752evb.c
> +++ b/board/renesas/sh7752evb/sh7752evb.c
> @@ -93,7 +93,7 @@ static void set_mac_to_sh_giga_eth_register(int channel,
> char *mac_string)
> unsigned char mac[6];
> unsigned long val;
>
> - eth_parse_enetaddr(mac_string, mac);
> + string_to_enetaddr(mac_string, mac);
>
> if (!channel)
> ether = GETHER0_MAC_BASE;
> diff --git a/board/renesas/sh7753evb/sh7753evb.c
> b/board/renesas/sh7753evb/sh7753evb.c
> index e1bed7dcc3..5aebb041b0 100644
> --- a/board/renesas/sh7753evb/sh7753evb.c
> +++ b/board/renesas/sh7753evb/sh7753evb.c
> @@ -100,7 +100,7 @@ static void set_mac_to_sh_giga_eth_register(int channel,
> char *mac_string)
> unsigned char mac[6];
> unsigned long val;
>
> - eth_parse_enetaddr(mac_string, mac);
> + string_to_enetaddr(mac_string, mac);
>
> if (!channel)
> ether = GETHER0_MAC_BASE;
> diff --git a/board/renesas/sh7757lcr/sh7757lcr.c
> b/board/renesas/sh7757lcr/sh7757lcr.c
> index d2671202e9..662c435f7a 100644
> --- a/board/renesas/sh7757lcr/sh7757lcr.c
> +++ b/board/renesas/sh7757lcr/sh7757lcr.c
> @@ -140,7 +140,7 @@ static void set_mac_to_sh_eth_register(int channel, char
> *mac_string)
> unsigned char mac[6];
> unsigned long val;
>
> - eth_parse_enetaddr(mac_string, mac);
> + string_to_enetaddr(mac_string, mac);
>
> if (!channel)
> ether = ETHER0_MAC_BASE;
> @@ -159,7 +159,7 @@ static void set_mac_to_sh_giga_eth_register(int channel,
> char *mac_string)
> unsigned char mac[6];
> unsigned long val;
>
> - eth_parse_enetaddr(mac_string, mac);
> + string_to_enetaddr(mac_string, mac);
>
> if (!channel)
> ether = GETHER0_MAC_BASE;
> diff --git a/cmd/ethsw.c b/cmd/ethsw.c
> index 8846805799..8d271ce1f3 100644
> --- a/cmd/ethsw.c
> +++ b/cmd/ethsw.c
> @@ -864,7 +864,7 @@ static int keyword_match_mac_addr(enum ethsw_keyword_id
> key_id, int argc,
> return 0;
> }
>
> - eth_parse_enetaddr(argv[*argc_nr + 1], parsed_cmd->ethaddr);
> + string_to_enetaddr(argv[*argc_nr + 1], parsed_cmd->ethaddr);
>
> if (is_broadcast_ethaddr(parsed_cmd->ethaddr)) {
> memset(parsed_cmd->ethaddr, 0xFF, sizeof(parsed_cmd->ethaddr));
> diff --git a/cmd/nvedit.c b/cmd/nvedit.c
> index 1cb0bc1460..1e4b225a94 100644
> --- a/cmd/nvedit.c
> +++ b/cmd/nvedit.c
> @@ -360,7 +360,7 @@ ulong env_get_hex(const char *varname, ulong default_val)
>
> int eth_env_get_enetaddr(const char
Re: [U-Boot] [PATCH 1/2] dm: device: Request next sequence number
Hi Bin,
Bin Meng writes:
[...]
> On Fri, Sep 6, 2019 at 7:52 PM Thomas Fitzsimmons wrote:
>>
>> For CONFIG_OF_PRIOR_STAGE, in the absence of a device tree alias for a
>> given device, use the next request number for that type of device.
>> This allows aliases to be used when they're available, while still
>> allowing unaliased devices to be probed.
>>
>> Signed-off-by: Thomas Fitzsimmons
>> Cc: Bin Meng
>> Cc: Simon Glass
>> ---
>> drivers/core/device.c | 5 +
>> drivers/core/uclass.c | 4 +++-
>> 2 files changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/core/device.c b/drivers/core/device.c
>> index 474c1642ee..ca8be208a9 100644
>> --- a/drivers/core/device.c
>> +++ b/drivers/core/device.c
>> @@ -82,6 +82,11 @@ static int device_bind_common(struct udevice *parent,
>> const struct driver *drv,
>> if (CONFIG_IS_ENABLED(OF_CONTROL) &&
>> !CONFIG_IS_ENABLED(OF_PLATDATA)) {
>> if (uc->uc_drv->name && ofnode_valid(node))
>> dev_read_alias_seq(dev, >req_seq);
>> +#if CONFIG_IS_ENABLED(OF_PRIOR_STAGE)
>
> I was wondering whether we should limit such only for OF_PRIOR_STATE,
> instead change the behaviors for all DM devices.
Maybe, though I wouldn't want to break assumptions made in this area by
non-OF_PRIOR_STAGE boards.
> Because as I pointed out in
> https://lists.denx.de/pipermail/u-boot/2019-August/382368.html, it
> seems there are quite some codes in the existing code base that tried
> to workaround such limitation in their own way.
I could create a separate config option to control this behavior, and
document what it does in Kconfig. Then other ports could adopt it
gradually, and eventually we could make it unconditional. I think
OF_PRIOR_STAGE should select the new option, since I can confirm this is
an improvement for my OF_PRIOR_STAGE-using board.
Thomas
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
Hi Jagan
On Sat, Sep 14, 2019 at 2:17 PM Michael Trimarchi
wrote:
>
> On Fri, Sep 13, 2019 at 08:11:17AM +0530, Jagan Teki wrote:
> > On Thu, Sep 12, 2019 at 8:25 PM Tom Rini wrote:
> > >
> > > On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote:
> > >
> > > > I have seen this even on v2019.07 release, and the only release that
> > > > it got working with on v2019.01 (SPL, BROM_RETURN)
> > > >
> > > > Any idea? here is the log dump.
> > > >
> > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36)
> > > > Trying to boot from BOOTROM
> > > > Returning to boot ROM...
> > > >
> > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530)
> > > > Trying to boot from MMC1
> > > > spl: mmc init failed with error: -110
> > > > SPL: failed to boot from all boot devices
> > > > ### ERROR ### Please RESET the board ###
> > >
> > > Time to run 'git bisect' since you know when it worked last at least?
> >
> > Look hard to bisect, few of commits in between seems SPL size
> > blow-out, doesn't boot etc. May be verify with respect boards might
> > help.
>
> Well I think that ddr should follow the same rule of rk3399, but still
> the mmc is not working
>
We can skip this patch, memory is anyway initialized from TPL. without it
Michael
> From c457eb849ce31a75db50a9b99e09d2453ee40580 Mon Sep 17 00:00:00 2001
> From: Michael Trimarchi
> Date: Sat, 14 Sep 2019 13:34:08 +0200
> Subject: [PATCH 1/2] rockchip: ram: rk3288: Init ram in TPL when is configured
>
> Init the ddr sdram in TPL instead of SPL, update the code.
>
> Signed-off-by: Michael Trimarchi
> ---
> drivers/ram/rockchip/sdram_rk3288.c | 15 ++-
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3288.c
> b/drivers/ram/rockchip/sdram_rk3288.c
> index 6bb025a851..5775254007 100644
> --- a/drivers/ram/rockchip/sdram_rk3288.c
> +++ b/drivers/ram/rockchip/sdram_rk3288.c
> @@ -79,7 +79,8 @@ const int ddrconf_table[] = {
> #define DQS_GATE_TRAINING_ERROR_RANK0 (1 << 4)
> #define DQS_GATE_TRAINING_ERROR_RANK1 (2 << 4)
>
> -#ifdef CONFIG_SPL_BUILD
> +#if defined(CONFIG_TPL_BUILD) || \
> + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
> static void copy_to_reg(u32 *dest, const u32 *src, u32 n)
> {
> int i;
> @@ -1035,7 +1036,8 @@ static int conv_of_platdata(struct udevice *dev)
>
> static int rk3288_dmc_probe(struct udevice *dev)
> {
> -#ifdef CONFIG_SPL_BUILD
> +#if defined(CONFIG_TPL_BUILD) || \
> + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
> struct rk3288_sdram_params *plat = dev_get_platdata(dev);
> struct udevice *dev_clk;
> struct regmap *map;
> @@ -1044,7 +1046,8 @@ static int rk3288_dmc_probe(struct udevice *dev)
> struct dram_info *priv = dev_get_priv(dev);
>
> priv->pmu = syscon_get_first_range(ROCKCHIP_SYSCON_PMU);
> -#ifdef CONFIG_SPL_BUILD
> +#if defined(CONFIG_TPL_BUILD) || \
> + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
> #if CONFIG_IS_ENABLED(OF_PLATDATA)
> ret = conv_of_platdata(dev);
> if (ret)
> @@ -,12 +1114,14 @@ U_BOOT_DRIVER(dmc_rk3288) = {
> .id = UCLASS_RAM,
> .of_match = rk3288_dmc_ids,
> .ops = _dmc_ops,
> -#ifdef CONFIG_SPL_BUILD
> +#if defined(CONFIG_TPL_BUILD) || \
> + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
> .ofdata_to_platdata = rk3288_dmc_ofdata_to_platdata,
> #endif
> .probe = rk3288_dmc_probe,
> .priv_auto_alloc_size = sizeof(struct dram_info),
> -#ifdef CONFIG_SPL_BUILD
> +#if defined(CONFIG_TPL_BUILD) || \
> + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
> .platdata_auto_alloc_size = sizeof(struct rk3288_sdram_params),
> #endif
> };
> --
> 2.17.1
>
> > ___
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
>
> --
> | Michael Nazzareno Trimarchi Amarula Solutions BV |
> | COO - Founder Cruquiuskade 47 |
> | +31(0)851119172 Amsterdam 1018 AM NL |
> | [`as] http://www.amarulasolutions.com |
--
| Michael Nazzareno Trimarchi Amarula Solutions BV |
| COO - Founder Cruquiuskade 47 |
| +31(0)851119172 Amsterdam 1018 AM NL |
| [`as] http://www.amarulasolutions.com |
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] net: Always build the string_to_enetaddr() helper
On 9/14/19 2:40 AM, Joe Hershberger wrote:
Part of the env cleanup moved this out of the environment code and into
the net code. However, this helper is sometimes needed even when the net
stack isn't included.
Move the helper to lib/net_utils.c like it's similarly-purposed
string_to_ip(). Also rename the moved function to similar naming.
Signed-off-by: Joe Hershberger
Reported-by: Ondrej Jirman
Reviewed-by: Heinrich Schuchardt
---
arch/arm/mach-tegra/cboot.c | 2 +-
board/renesas/sh7752evb/sh7752evb.c | 2 +-
board/renesas/sh7753evb/sh7753evb.c | 2 +-
board/renesas/sh7757lcr/sh7757lcr.c | 4 ++--
cmd/ethsw.c | 2 +-
cmd/nvedit.c| 2 +-
doc/README.enetaddr | 4 ++--
include/net.h | 24 +---
lib/net_utils.c | 15 +++
net/eth-uclass.c| 2 +-
net/eth_legacy.c| 2 +-
net/net.c | 12
12 files changed, 39 insertions(+), 34 deletions(-)
diff --git a/arch/arm/mach-tegra/cboot.c b/arch/arm/mach-tegra/cboot.c
index 0433081c6c..0762144ecf 100644
--- a/arch/arm/mach-tegra/cboot.c
+++ b/arch/arm/mach-tegra/cboot.c
@@ -495,7 +495,7 @@ static int cboot_get_ethaddr_legacy(const void *fdt,
uint8_t mac[ETH_ALEN])
return -ENOENT;
}
- eth_parse_enetaddr(prop, mac);
+ string_to_enetaddr(prop, mac);
if (!is_valid_ethaddr(mac)) {
printf("Invalid MAC address: %s\n", prop);
diff --git a/board/renesas/sh7752evb/sh7752evb.c
b/board/renesas/sh7752evb/sh7752evb.c
index d0b850f35d..b4292b22e7 100644
--- a/board/renesas/sh7752evb/sh7752evb.c
+++ b/board/renesas/sh7752evb/sh7752evb.c
@@ -93,7 +93,7 @@ static void set_mac_to_sh_giga_eth_register(int channel, char
*mac_string)
unsigned char mac[6];
unsigned long val;
- eth_parse_enetaddr(mac_string, mac);
+ string_to_enetaddr(mac_string, mac);
if (!channel)
ether = GETHER0_MAC_BASE;
diff --git a/board/renesas/sh7753evb/sh7753evb.c
b/board/renesas/sh7753evb/sh7753evb.c
index e1bed7dcc3..5aebb041b0 100644
--- a/board/renesas/sh7753evb/sh7753evb.c
+++ b/board/renesas/sh7753evb/sh7753evb.c
@@ -100,7 +100,7 @@ static void set_mac_to_sh_giga_eth_register(int channel,
char *mac_string)
unsigned char mac[6];
unsigned long val;
- eth_parse_enetaddr(mac_string, mac);
+ string_to_enetaddr(mac_string, mac);
if (!channel)
ether = GETHER0_MAC_BASE;
diff --git a/board/renesas/sh7757lcr/sh7757lcr.c
b/board/renesas/sh7757lcr/sh7757lcr.c
index d2671202e9..662c435f7a 100644
--- a/board/renesas/sh7757lcr/sh7757lcr.c
+++ b/board/renesas/sh7757lcr/sh7757lcr.c
@@ -140,7 +140,7 @@ static void set_mac_to_sh_eth_register(int channel, char
*mac_string)
unsigned char mac[6];
unsigned long val;
- eth_parse_enetaddr(mac_string, mac);
+ string_to_enetaddr(mac_string, mac);
if (!channel)
ether = ETHER0_MAC_BASE;
@@ -159,7 +159,7 @@ static void set_mac_to_sh_giga_eth_register(int channel,
char *mac_string)
unsigned char mac[6];
unsigned long val;
- eth_parse_enetaddr(mac_string, mac);
+ string_to_enetaddr(mac_string, mac);
if (!channel)
ether = GETHER0_MAC_BASE;
diff --git a/cmd/ethsw.c b/cmd/ethsw.c
index 8846805799..8d271ce1f3 100644
--- a/cmd/ethsw.c
+++ b/cmd/ethsw.c
@@ -864,7 +864,7 @@ static int keyword_match_mac_addr(enum ethsw_keyword_id
key_id, int argc,
return 0;
}
- eth_parse_enetaddr(argv[*argc_nr + 1], parsed_cmd->ethaddr);
+ string_to_enetaddr(argv[*argc_nr + 1], parsed_cmd->ethaddr);
if (is_broadcast_ethaddr(parsed_cmd->ethaddr)) {
memset(parsed_cmd->ethaddr, 0xFF, sizeof(parsed_cmd->ethaddr));
diff --git a/cmd/nvedit.c b/cmd/nvedit.c
index 1cb0bc1460..1e4b225a94 100644
--- a/cmd/nvedit.c
+++ b/cmd/nvedit.c
@@ -360,7 +360,7 @@ ulong env_get_hex(const char *varname, ulong default_val)
int eth_env_get_enetaddr(const char *name, uint8_t *enetaddr)
{
- eth_parse_enetaddr(env_get(name), enetaddr);
+ string_to_enetaddr(env_get(name), enetaddr);
return is_valid_ethaddr(enetaddr);
}
diff --git a/doc/README.enetaddr b/doc/README.enetaddr
index f926485986..5baa9f2179 100644
--- a/doc/README.enetaddr
+++ b/doc/README.enetaddr
@@ -76,12 +76,12 @@ To assist in the management of these layers, a few helper
functions exist. You
should use these rather than attempt to do any kind of parsing/manipulation
yourself as many common errors have arisen in the past.
- * void eth_parse_enetaddr(const char *addr, uchar *enetaddr);
+ * void string_to_enetaddr(const char *addr, uchar *enetaddr);
Convert a string representation of a MAC address to the binary version.
char *addr =
[U-Boot] [PULL] u-boot-usb/master
The following changes since commit 001c8ea94ae710d8340829237a7d788b25ce2ae7: Merge https://gitlab.denx.de/u-boot/custodians/u-boot-x86 (2019-09-10 08:52:00 -0400) are available in the Git repository at: git://git.denx.de/u-boot-usb.git master for you to fetch changes up to e3e5825d0143c2b24583d256ef111ae9344382a2: usb: musb_hcd: fix compilation error (2019-09-11 10:11:39 +0200) Jean-Jacques Hiblot (1): usb: musb_hcd: fix compilation error Michal Suchanek (5): usb_kdb: only process events successfully received usb: usb_submit_int_msg -> usb_int_msg usb: storage: submit_int_msg -> usb_int_msg usb: Add nonblock argument to submit_int_msg dwc2: use the nonblock argument in submit_int_msg common/usb.c | 11 +++ common/usb_kbd.c | 11 +-- common/usb_storage.c | 4 ++-- drivers/usb/emul/sandbox_keyb.c| 3 ++- drivers/usb/emul/usb-emul-uclass.c | 6 -- drivers/usb/host/dwc2.c| 15 +-- drivers/usb/host/ehci-hcd.c| 13 - drivers/usb/host/ohci-hcd.c| 4 ++-- drivers/usb/host/sl811-hcd.c | 2 +- drivers/usb/host/usb-sandbox.c | 5 +++-- drivers/usb/host/usb-uclass.c | 5 +++-- drivers/usb/host/xhci.c| 13 - drivers/usb/musb-new/musb_uboot.c | 12 +++- drivers/usb/musb/musb_hcd.c| 4 ++-- include/usb.h | 11 ++- 15 files changed, 69 insertions(+), 50 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: fix pico-dwarf-imx6ul and pico-dwarf-imx7d build issues
Hi Fabio, Anatolji, thanks both. On 14/09/19 14:18, Fabio Estevam wrote: > Hi Anatolij, > > On Sat, Sep 14, 2019 at 8:43 AM Anatolij Gustschin wrote: >> >> Fixes: >> board/technexion/pico-imx6ul/spl.c: In function 'board_mmc_init': >> error: implicit declaration of function 'fsl_esdhc_initialize' >> >> and a simmilar error when building pico-dwarf-imx7d. >> >> Signed-off-by: Anatolij Gustschin >> Cc: Otavio Salvador >> --- >> configs/pico-dwarf-imx6ul_defconfig | 2 +- >> configs/pico-dwarf-imx7d_defconfig | 2 +- > > It seems that configs/pico-nymph-imx7d_defconfig conversion is missing. > > I haven't seen your patch earlier and also sent a fix: > https://lists.denx.de/pipermail/u-boot/2019-September/383582.html > > Thanks Yes, I applied Fabio's and I am letting now Travis running. Regards, Stefano -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: fix pico-dwarf-imx6ul and pico-dwarf-imx7d build issues
Hi Fabio, Stefano, On Sat, 14 Sep 2019 09:18:22 -0300 Fabio Estevam feste...@gmail.com wrote: ... > > configs/pico-dwarf-imx6ul_defconfig | 2 +- > > configs/pico-dwarf-imx7d_defconfig | 2 +- > > It seems that configs/pico-nymph-imx7d_defconfig conversion is missing. Yes, somehow I forgot to fix this one. Thanks for paying attention! > I haven't seen your patch earlier and also sent a fix: > https://lists.denx.de/pipermail/u-boot/2019-September/383582.html OK, thanks! -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: fix pico-dwarf-imx6ul and pico-dwarf-imx7d build issues
Hi Anatolij, On Sat, Sep 14, 2019 at 8:43 AM Anatolij Gustschin wrote: > > Fixes: > board/technexion/pico-imx6ul/spl.c: In function 'board_mmc_init': > error: implicit declaration of function 'fsl_esdhc_initialize' > > and a simmilar error when building pico-dwarf-imx7d. > > Signed-off-by: Anatolij Gustschin > Cc: Otavio Salvador > --- > configs/pico-dwarf-imx6ul_defconfig | 2 +- > configs/pico-dwarf-imx7d_defconfig | 2 +- It seems that configs/pico-nymph-imx7d_defconfig conversion is missing. I haven't seen your patch earlier and also sent a fix: https://lists.denx.de/pipermail/u-boot/2019-September/383582.html Thanks ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] pico-imx6ul: Add DWARF baseboard support
On 14/09/19 14:16, Otavio Salvador wrote: > On Sat, Sep 14, 2019 at 8:22 AM Stefano Babic wrote: > ... >> Otavio, I am also fine if you send a follow-up patch to fix it - your >> decision. > > Anatolij sent a fix already. I acked it and copied you. > Yes, thanks - I apply it directly on top ofimx tree. Regards, Stefano -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
On Fri, Sep 13, 2019 at 08:11:17AM +0530, Jagan Teki wrote:
> On Thu, Sep 12, 2019 at 8:25 PM Tom Rini wrote:
> >
> > On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote:
> >
> > > I have seen this even on v2019.07 release, and the only release that
> > > it got working with on v2019.01 (SPL, BROM_RETURN)
> > >
> > > Any idea? here is the log dump.
> > >
> > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36)
> > > Trying to boot from BOOTROM
> > > Returning to boot ROM...
> > >
> > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530)
> > > Trying to boot from MMC1
> > > spl: mmc init failed with error: -110
> > > SPL: failed to boot from all boot devices
> > > ### ERROR ### Please RESET the board ###
> >
> > Time to run 'git bisect' since you know when it worked last at least?
>
> Look hard to bisect, few of commits in between seems SPL size
> blow-out, doesn't boot etc. May be verify with respect boards might
> help.
Well I think that ddr should follow the same rule of rk3399, but still
the mmc is not working
From c457eb849ce31a75db50a9b99e09d2453ee40580 Mon Sep 17 00:00:00 2001
From: Michael Trimarchi
Date: Sat, 14 Sep 2019 13:34:08 +0200
Subject: [PATCH 1/2] rockchip: ram: rk3288: Init ram in TPL when is configured
Init the ddr sdram in TPL instead of SPL, update the code.
Signed-off-by: Michael Trimarchi
---
drivers/ram/rockchip/sdram_rk3288.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/ram/rockchip/sdram_rk3288.c
b/drivers/ram/rockchip/sdram_rk3288.c
index 6bb025a851..5775254007 100644
--- a/drivers/ram/rockchip/sdram_rk3288.c
+++ b/drivers/ram/rockchip/sdram_rk3288.c
@@ -79,7 +79,8 @@ const int ddrconf_table[] = {
#define DQS_GATE_TRAINING_ERROR_RANK0 (1 << 4)
#define DQS_GATE_TRAINING_ERROR_RANK1 (2 << 4)
-#ifdef CONFIG_SPL_BUILD
+#if defined(CONFIG_TPL_BUILD) || \
+ (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
static void copy_to_reg(u32 *dest, const u32 *src, u32 n)
{
int i;
@@ -1035,7 +1036,8 @@ static int conv_of_platdata(struct udevice *dev)
static int rk3288_dmc_probe(struct udevice *dev)
{
-#ifdef CONFIG_SPL_BUILD
+#if defined(CONFIG_TPL_BUILD) || \
+ (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
struct rk3288_sdram_params *plat = dev_get_platdata(dev);
struct udevice *dev_clk;
struct regmap *map;
@@ -1044,7 +1046,8 @@ static int rk3288_dmc_probe(struct udevice *dev)
struct dram_info *priv = dev_get_priv(dev);
priv->pmu = syscon_get_first_range(ROCKCHIP_SYSCON_PMU);
-#ifdef CONFIG_SPL_BUILD
+#if defined(CONFIG_TPL_BUILD) || \
+ (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
#if CONFIG_IS_ENABLED(OF_PLATDATA)
ret = conv_of_platdata(dev);
if (ret)
@@ -,12 +1114,14 @@ U_BOOT_DRIVER(dmc_rk3288) = {
.id = UCLASS_RAM,
.of_match = rk3288_dmc_ids,
.ops = _dmc_ops,
-#ifdef CONFIG_SPL_BUILD
+#if defined(CONFIG_TPL_BUILD) || \
+ (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
.ofdata_to_platdata = rk3288_dmc_ofdata_to_platdata,
#endif
.probe = rk3288_dmc_probe,
.priv_auto_alloc_size = sizeof(struct dram_info),
-#ifdef CONFIG_SPL_BUILD
+#if defined(CONFIG_TPL_BUILD) || \
+ (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD))
.platdata_auto_alloc_size = sizeof(struct rk3288_sdram_params),
#endif
};
--
2.17.1
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
--
| Michael Nazzareno Trimarchi Amarula Solutions BV |
| COO - Founder Cruquiuskade 47 |
| +31(0)851119172 Amsterdam 1018 AM NL |
| [`as] http://www.amarulasolutions.com |
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] pico-imx6ul: Add DWARF baseboard support
On Sat, Sep 14, 2019 at 8:22 AM Stefano Babic wrote: ... > Otavio, I am also fine if you send a follow-up patch to fix it - your > decision. Anatolij sent a fix already. I acked it and copied you. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] pico: Convert to CONFIG_FSL_USDHC
The eSDHC config symbol has been converted to CONFIG_FSL_USDHC, so adjust it accordingly in order to fix the build errors: https://travis-ci.org/sbabic/u-boot-imx/jobs/584781580#L1287 Reported-by: Anatolij Gustschin Signed-off-by: Fabio Estevam --- configs/pico-dwarf-imx6ul_defconfig | 2 +- configs/pico-dwarf-imx7d_defconfig | 2 +- configs/pico-nymph-imx7d_defconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configs/pico-dwarf-imx6ul_defconfig b/configs/pico-dwarf-imx6ul_defconfig index 33bb70bf1f..f1f6506868 100644 --- a/configs/pico-dwarf-imx6ul_defconfig +++ b/configs/pico-dwarf-imx6ul_defconfig @@ -44,7 +44,7 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y CONFIG_DM_GPIO=y CONFIG_DM_I2C=y CONFIG_DM_MMC=y -CONFIG_FSL_ESDHC=y +CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_PHY_MICREL=y CONFIG_MII=y diff --git a/configs/pico-dwarf-imx7d_defconfig b/configs/pico-dwarf-imx7d_defconfig index b8a5fb60ad..3ba7adcc25 100644 --- a/configs/pico-dwarf-imx7d_defconfig +++ b/configs/pico-dwarf-imx7d_defconfig @@ -52,7 +52,7 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y CONFIG_DM_GPIO=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y -CONFIG_FSL_ESDHC=y +CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_MII=y CONFIG_PINCTRL=y diff --git a/configs/pico-nymph-imx7d_defconfig b/configs/pico-nymph-imx7d_defconfig index b8a5fb60ad..3ba7adcc25 100644 --- a/configs/pico-nymph-imx7d_defconfig +++ b/configs/pico-nymph-imx7d_defconfig @@ -52,7 +52,7 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y CONFIG_DM_GPIO=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y -CONFIG_FSL_ESDHC=y +CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_MII=y CONFIG_PINCTRL=y -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: fix pico-dwarf-imx6ul and pico-dwarf-imx7d build issues
On Sat, Sep 14, 2019 at 8:43 AM Anatolij Gustschin wrote: > > Fixes: > board/technexion/pico-imx6ul/spl.c: In function 'board_mmc_init': > error: implicit declaration of function 'fsl_esdhc_initialize' > > and a simmilar error when building pico-dwarf-imx7d. > > Signed-off-by: Anatolij Gustschin > Cc: Otavio Salvador Acked-by: Otavio Salvador -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] imx: fix pico-dwarf-imx6ul and pico-dwarf-imx7d build issues
Fixes: board/technexion/pico-imx6ul/spl.c: In function 'board_mmc_init': error: implicit declaration of function 'fsl_esdhc_initialize' and a simmilar error when building pico-dwarf-imx7d. Signed-off-by: Anatolij Gustschin Cc: Otavio Salvador --- configs/pico-dwarf-imx6ul_defconfig | 2 +- configs/pico-dwarf-imx7d_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/pico-dwarf-imx6ul_defconfig b/configs/pico-dwarf-imx6ul_defconfig index 33bb70bf1f..f1f6506868 100644 --- a/configs/pico-dwarf-imx6ul_defconfig +++ b/configs/pico-dwarf-imx6ul_defconfig @@ -44,7 +44,7 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y CONFIG_DM_GPIO=y CONFIG_DM_I2C=y CONFIG_DM_MMC=y -CONFIG_FSL_ESDHC=y +CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_PHY_MICREL=y CONFIG_MII=y diff --git a/configs/pico-dwarf-imx7d_defconfig b/configs/pico-dwarf-imx7d_defconfig index b8a5fb60ad..3ba7adcc25 100644 --- a/configs/pico-dwarf-imx7d_defconfig +++ b/configs/pico-dwarf-imx7d_defconfig @@ -52,7 +52,7 @@ CONFIG_FASTBOOT_CMD_OEM_FORMAT=y CONFIG_DM_GPIO=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y -CONFIG_FSL_ESDHC=y +CONFIG_FSL_USDHC=y CONFIG_PHYLIB=y CONFIG_MII=y CONFIG_PINCTRL=y -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] imx: sksimx6_defconfig: remove SPL misc option to fix build error
Remove CONFIG_SPL_DRIVERS_MISC_SUPPORT since it is already defined in include/configs/mx6_common.h for SPL builds. When this option is in defconfig, we get build warnings (or errors when building with -Werror). Signed-off-by: Anatolij Gustschin --- Hi Stefano, This fixes build breakage seen here: https://travis-ci.org/sbabic/u-boot-imx/jobs/584781580#L1870 Please apply. Thanks! Anatolij configs/sksimx6_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/sksimx6_defconfig b/configs/sksimx6_defconfig index 7bc687f64d..7030438f08 100644 --- a/configs/sksimx6_defconfig +++ b/configs/sksimx6_defconfig @@ -8,7 +8,6 @@ CONFIG_MX6_DDRCAL=y CONFIG_TARGET_SKSIMX6=y CONFIG_SPL_MMC_SUPPORT=y CONFIG_SPL_SERIAL_SUPPORT=y -CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_NR_DRAM_BANKS=1 CONFIG_SPL=y CONFIG_SPL_LIBDISK_SUPPORT=y -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull pico-imx7d-2019.10-1 from https://github.com/OSSystems/u-boot
Hi Stefano, Thanks Best regards, Joris Le 14/09/2019 à 13:20, Stefano Babic a écrit : Hi Joris, I am pulling all patches for the release, I wil ltake care of yours, too. Regards, Stefano On 14/09/19 12:01, Joris Offouga wrote: +Stefano Babic Le 14/09/2019 à 11:56, Joris Offouga a écrit : Hi Otavio, I adjust my repo with your PR, you can find commits here: https://github.com/jorisoffouga/u-boot/commits/pico-imx7-2019.10-2 Best Regards, Joris Offouga Le 13/09/2019 à 16:36, Otavio Salvador a écrit : On Thu, Sep 12, 2019 at 6:27 PM Joris Offouga wrote: Just put CONFIG_DM_VIDEO in the defconfig Please adjust your PR and let me know; so I test it here. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] pico-imx6ul: Add DWARF baseboard support
Hi Anatolji, thanks, I have not sent an e-mail to Otavio after pulling his tree. On 14/09/19 12:47, Anatolij Gustschin wrote: > Hi Otavio, > > On Thu, 12 Sep 2019 16:01:50 -0300 > Otavio Salvador ota...@ossystems.com.br wrote: > ... >> configs/pico-dwarf-imx6ul_defconfig | 64 + > ... >> +CONFIG_FSL_ESDHC=y > > Please change this to CONFIG_FSL_USDHC=y > > Otherwise we get build warning/error [1]. > > [1] https://travis-ci.org/sbabic/u-boot-imx/jobs/584781580#L1287 > Otavio, I am also fine if you send a follow-up patch to fix it - your decision. Regards, Stefano -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull pico-imx7d-2019.10-1 from https://github.com/OSSystems/u-boot
Hi Joris, I am pulling all patches for the release, I wil ltake care of yours, too. Regards, Stefano On 14/09/19 12:01, Joris Offouga wrote: > +Stefano Babic > > Le 14/09/2019 à 11:56, Joris Offouga a écrit : >> Hi Otavio, >> >> I adjust my repo with your PR, you can find commits here: >> https://github.com/jorisoffouga/u-boot/commits/pico-imx7-2019.10-2 >> >> Best Regards, >> >> Joris Offouga >> >> Le 13/09/2019 à 16:36, Otavio Salvador a écrit : >>> On Thu, Sep 12, 2019 at 6:27 PM Joris Offouga >>> wrote: Just put CONFIG_DM_VIDEO in the defconfig >>> Please adjust your PR and let me know; so I test it here. >>> -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] pico-imx7d: Add NYMPH baseboard support
On Thu, 12 Sep 2019 16:04:59 -0300 Otavio Salvador ota...@ossystems.com.br wrote: ... > configs/pico-nymph-imx7d_defconfig | 68 ++ ... > +CONFIG_FSL_ESDHC=y Please change this to CONFIG_FSL_USDHC=y -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/5] pico-imx7d: Add DWARF baseboard support
On Thu, 12 Sep 2019 16:04:58 -0300 Otavio Salvador ota...@ossystems.com.br wrote: ... > configs/pico-dwarf-imx7d_defconfig | 68 ++ ... > +CONFIG_FSL_ESDHC=y Please change this to CONFIG_FSL_USDHC=y -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] pico-imx6ul: Add DWARF baseboard support
Hi Otavio, On Thu, 12 Sep 2019 16:01:50 -0300 Otavio Salvador ota...@ossystems.com.br wrote: ... > configs/pico-dwarf-imx6ul_defconfig | 64 + ... > +CONFIG_FSL_ESDHC=y Please change this to CONFIG_FSL_USDHC=y Otherwise we get build warning/error [1]. [1] https://travis-ci.org/sbabic/u-boot-imx/jobs/584781580#L1287 -- Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] rsa: Return immediately if required-key verification fails
Currently, if image verification with a required key fails, rsa_verify()
code tries to find another key to verify the FIT image. This however, is
not the intended behavior as the documentation says that required keys
"must be verified for the image / configuration to be considered valid".
This patch fixes the issue by making rsa_verify() return immediately if
the verification of a required key fails.
Signed-off-by: Daniele Alessandrelli
---
lib/rsa/rsa-verify.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
index 287fcc4d23..82dc513260 100644
--- a/lib/rsa/rsa-verify.c
+++ b/lib/rsa/rsa-verify.c
@@ -437,8 +437,7 @@ int rsa_verify(struct image_sign_info *info,
if (info->required_keynode != -1) {
ret = rsa_verify_with_keynode(info, hash, sig, sig_len,
info->required_keynode);
- if (!ret)
- return ret;
+ return ret;
}
/* Look for a key that matches our hint */
--
2.21.0
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] RSA verify code and required keys
Hi Simon, On Fri, Sep 13, 2019 at 5:36 PM Simon Glass wrote: > > Hi Daniele, > > > > > If I understand it correctly, at Line 440 we check if verification > > with the required key succeeded and if so we return otherwise we > > continue, trying other keys. > > Yes that's my understanding too. > > > > > Is that the intended behavior? Shouldn't the code return in any case > > (thus making the FIT verification process fail if the image couldn't > > be verified with the required key)? Or am I missing something? > > Yes I think you are right. The documentation says: > > - required: If present this indicates that the key must be verified for the > image / configuration to be considered valid. Only required keys are > normally verified by the FIT image booting algorithm. Valid values are > "image" to force verification of all images, and "conf" to force verification > of the selected configuration (which then relies on hashes in the images to > verify those). Thanks for confirming it. I'll prepare a small patch to fix it... that would be my first U-boot patch :D > > The test coverage does not handle that case at present, but it should. > I'm afraid I won't have time to fix that in my patch. I had a quick look at 'test_fit.py' and it looks like there is quite some code to write to add this test case. Regards, Daniele ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull pico-imx7d-2019.10-1 from https://github.com/OSSystems/u-boot
+Stefano Babic Le 14/09/2019 à 11:56, Joris Offouga a écrit : Hi Otavio, I adjust my repo with your PR, you can find commits here: https://github.com/jorisoffouga/u-boot/commits/pico-imx7-2019.10-2 Best Regards, Joris Offouga Le 13/09/2019 à 16:36, Otavio Salvador a écrit : On Thu, Sep 12, 2019 at 6:27 PM Joris Offouga wrote: Just put CONFIG_DM_VIDEO in the defconfig Please adjust your PR and let me know; so I test it here. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull pico-imx7d-2019.10-1 from https://github.com/OSSystems/u-boot
Hi Otavio, I adjust my repo with your PR, you can find commits here: https://github.com/jorisoffouga/u-boot/commits/pico-imx7-2019.10-2 Best Regards, Joris Offouga Le 13/09/2019 à 16:36, Otavio Salvador a écrit : On Thu, Sep 12, 2019 at 6:27 PM Joris Offouga wrote: Just put CONFIG_DM_VIDEO in the defconfig Please adjust your PR and let me know; so I test it here. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [U-Boot-Custodians] [PATCH 1/1] dm: MIGRATION: Add migration plan for CONFIG_DM
On Sat, Sep 14, 2019 at 1:38 PM Marek Vasut wrote: > > On 9/14/19 9:58 AM, Heinrich Schuchardt wrote: > > For many sub-systems we already require the driver model to be used. Yet > > there is still a handful of boards that do not have CONFIG_DM enabled. > > > > We should make CONFIG_DM compulsory with release v2020.01 > > > > Signed-off-by: Heinrich Schuchardt > > --- > > Makefile | 8 > > doc/driver-model/migration.rst | 8 > > 2 files changed, 16 insertions(+) > > > > diff --git a/Makefile b/Makefile > > index ae56e47b2c..69a6b503b7 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -936,6 +936,14 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) > > endif > > endif > > endif > > +ifneq ($(CONFIG_DM),y) > > + @echo >&2 "= WARNING ==" > > + @echo >&2 "This board does not use CONFIG_DM. CONFIG_DM will be" > > + @echo >&2 "compulsory starting with the v2020.01 release." > > + @echo >&2 "Failure to update may result in board removal." > > + @echo >&2 "See doc/driver-model/migration.rst for more info." > > + @echo >&2 "" > > +endif > > ifeq ($(CONFIG_MMC),y) > > ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) > > @echo >&2 "= WARNING ==" > > diff --git a/doc/driver-model/migration.rst b/doc/driver-model/migration.rst > > index 75b85235ef..23f3a61c0f 100644 > > --- a/doc/driver-model/migration.rst > > +++ b/doc/driver-model/migration.rst > > @@ -7,6 +7,14 @@ U-Boot has been migrating to a new driver model since its > > introduction in > > 2014. This file describes the schedule for deprecation of pre-driver-model > > features. > > > > +CONFIG_DM > > +- > > + > > +* Status: In progress > > +* Deadline: 2020.01 > > + > > +Starting with the 2010.01 release CONFIG_DM will be enabled for all boards. > > But only for U-Boot proper, not for SPL. And this should be explicitly > mentioned here. Make sense, even mention explicitly for "not possible SoCs/boards, due to foot-print blowout" or similar. otherwise DM with SPL would still valid by configuring OF_CONTROL or OF_PLATDATA. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [U-Boot-Custodians] [PATCH 1/1] dm: MIGRATION: Add migration plan for CONFIG_DM
On 9/14/19 9:58 AM, Heinrich Schuchardt wrote: > For many sub-systems we already require the driver model to be used. Yet > there is still a handful of boards that do not have CONFIG_DM enabled. > > We should make CONFIG_DM compulsory with release v2020.01 > > Signed-off-by: Heinrich Schuchardt > --- > Makefile | 8 > doc/driver-model/migration.rst | 8 > 2 files changed, 16 insertions(+) > > diff --git a/Makefile b/Makefile > index ae56e47b2c..69a6b503b7 100644 > --- a/Makefile > +++ b/Makefile > @@ -936,6 +936,14 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) > endif > endif > endif > +ifneq ($(CONFIG_DM),y) > + @echo >&2 "= WARNING ==" > + @echo >&2 "This board does not use CONFIG_DM. CONFIG_DM will be" > + @echo >&2 "compulsory starting with the v2020.01 release." > + @echo >&2 "Failure to update may result in board removal." > + @echo >&2 "See doc/driver-model/migration.rst for more info." > + @echo >&2 "" > +endif > ifeq ($(CONFIG_MMC),y) > ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) > @echo >&2 "= WARNING ==" > diff --git a/doc/driver-model/migration.rst b/doc/driver-model/migration.rst > index 75b85235ef..23f3a61c0f 100644 > --- a/doc/driver-model/migration.rst > +++ b/doc/driver-model/migration.rst > @@ -7,6 +7,14 @@ U-Boot has been migrating to a new driver model since its > introduction in > 2014. This file describes the schedule for deprecation of pre-driver-model > features. > > +CONFIG_DM > +- > + > +* Status: In progress > +* Deadline: 2020.01 > + > +Starting with the 2010.01 release CONFIG_DM will be enabled for all boards. But only for U-Boot proper, not for SPL. And this should be explicitly mentioned here. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 1/1] dm: MIGRATION: Add migration plan for CONFIG_DM
For many sub-systems we already require the driver model to be used. Yet there is still a handful of boards that do not have CONFIG_DM enabled. We should make CONFIG_DM compulsory with release v2020.01 Signed-off-by: Heinrich Schuchardt --- Makefile | 8 doc/driver-model/migration.rst | 8 2 files changed, 16 insertions(+) diff --git a/Makefile b/Makefile index ae56e47b2c..69a6b503b7 100644 --- a/Makefile +++ b/Makefile @@ -936,6 +936,14 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) endif endif endif +ifneq ($(CONFIG_DM),y) + @echo >&2 "= WARNING ==" + @echo >&2 "This board does not use CONFIG_DM. CONFIG_DM will be" + @echo >&2 "compulsory starting with the v2020.01 release." + @echo >&2 "Failure to update may result in board removal." + @echo >&2 "See doc/driver-model/migration.rst for more info." + @echo >&2 "" +endif ifeq ($(CONFIG_MMC),y) ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) @echo >&2 "= WARNING ==" diff --git a/doc/driver-model/migration.rst b/doc/driver-model/migration.rst index 75b85235ef..23f3a61c0f 100644 --- a/doc/driver-model/migration.rst +++ b/doc/driver-model/migration.rst @@ -7,6 +7,14 @@ U-Boot has been migrating to a new driver model since its introduction in 2014. This file describes the schedule for deprecation of pre-driver-model features. +CONFIG_DM +- + +* Status: In progress +* Deadline: 2020.01 + +Starting with the 2010.01 release CONFIG_DM will be enabled for all boards. + CONFIG_DM_MMC - -- 2.20.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] OMAP watchdog timer reset on BBB
Hi Grygorii,
On Fri, Sep 13, 2019 at 8:58 PM Grygorii Strashko
wrote:
>
>
>
> On 12/09/2019 19:33, Sam Protsenko wrote:
> > Hi Stefan,
> >
> > On Thu, Sep 12, 2019 at 5:38 PM Stefan Roese wrote:
> >>
> >> Hi Sam,
> >>
> >> On 12.09.19 15:45, Sam Protsenko wrote:
> >>> Hi Suniel,
> >>>
> >>> After transition to DM WDT, watchdog timer on BeagleBone Black resets
> >>> the board after 1 minute or so. I'm using this defconfig: [1]. After
> >>> disabling CONFIG_WDT and CONFIG_WATCHDOG options the board doesn't
> >>> reset. I guess it might be happening on other boards using
> >>> CONFIG_WDT_OMAP3 as well. The issue can be reproduced by stopping in
> >>> U-Boot shell (=>) and waiting for 1 minute.
> >>>
> >>> Do you know by chance why it might be happening, or maybe some fix
> >>> already exists?
> >>>
> >>> Thanks!
> >>>
> >>> [1] https://pastebin.ubuntu.com/p/Zz5bY6cYXS/
> >>
> >> So you have enabled the watchdog and should see something like this
> >> upon bootup:
> >>
> >> WDT: Started without servicing (60s timeout)
> >>
> >> Is this correct? Then you need to enable the U-Boot internal WDT
> >> servicing by enabling CONFIG_WATCHDOG as well, as this will
> >> result in the internal U-Boot servicing of the watchdog. Then
> >> you should see this upon bootup and no reset will appear in
> >> U-Boot:
> >>
> >> WDT: Started with servicing (60s timeout)
> >>
> >
> > I'm seeing this ("with servicing") line, and CONFIG_WATCHDOG is
> > already enabled in am335x_evm_defconfig. So I think it's an issue,
> > which *probably* appeared when watchdog drivers were converted to
> > Driver Model (this defconfig is using CONFIG_WDT + CONFIG_WDT_OMAP3
> > options). Any clues what can be wrong?
> >
> >> Does this help?
> It seems logic of hw_watchdog_reset() and omap3_wdt_reset() is different.
> Pay attention at wdt_trgr_pattern.
>
> It seems that
> priv->wdt_trgr_pattern = 0x1234;
> need to be moved in omap3_wdt_probe()
>
Thanks a lot for the investigation. I'll check that once I have some spare time.
>
> --
> Best regards,
> grygorii
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver to driver model
> -Original Message- > From: Prabhakar Kushwaha > Sent: 2019年9月13日 14:56 > To: Jagan Teki > Cc: Xiaowei Bao ; Priyanka Jain > ; w...@denx.de; Shengzhou Liu > ; Ruchika Gupta ; > s...@chromium.org; Chuanhua Han ; Jagdish > Gediya ; bmeng...@gmail.com; > u-boot@lists.denx.de; York Sun ; Jiafei Pan > > Subject: RE: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver to driver > model > > > > -Original Message- > > From: Jagan Teki > > Sent: Friday, September 13, 2019 7:58 AM > > To: Prabhakar Kushwaha > > Cc: Xiaowei Bao ; Priyanka Jain > > ; w...@denx.de; Shengzhou Liu > > ; Ruchika Gupta ; > > s...@chromium.org; Chuanhua Han ; Jagdish > Gediya > > ; bmeng...@gmail.com; u- b...@lists.denx.de; > > York Sun ; Jiafei Pan > > Subject: Re: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver to > > driver model > > > > On Mon, Sep 9, 2019 at 1:13 PM Prabhakar Kushwaha > > wrote: > > > > > > > > > > -Original Message- > > > > From: Jagan Teki > > > > Sent: Monday, September 9, 2019 11:37 AM > > > > To: Xiaowei Bao > > > > Cc: Prabhakar Kushwaha ; > > w...@denx.de; > > > > Shengzhou Liu ; Ruchika Gupta > > > > ; s...@chromium.org; Chuanhua Han > > > > ; Jagdish Gediya ; > > > > bmeng...@gmail.com; u-boot@lists.denx.de; York Sun > > > > ; Jiafei Pan > > > > Subject: Re: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI driver > > > > to driver model > > > > > > > > On Mon, Sep 9, 2019 at 9:27 AM Xiaowei Bao > > wrote: > > > > > > > > > > > > > > > > > > > > > -Original Message- > > > > > > From: Prabhakar Kushwaha > > > > > > Sent: 2019年8月26日 23:12 > > > > > > To: Xiaowei Bao ; w...@denx.de; Shengzhou > > Liu > > > > > > ; Ruchika Gupta > > ; > > > > > > ja...@amarulasolutions.com; s...@chromium.org; Chuanhua Han > > > > > > ; Jagdish Gediya > > ; > > > > > > bmeng...@gmail.com; u-boot@lists.denx.de > > > > > > Cc: York Sun ; Xiaowei Bao > > > > > > > > > > > > Subject: RE: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI > > > > > > driver to driver model > > > > > > > > > > > > Dear Jagan, > > > > > > > > > > > > > -Original Message- > > > > > > > From: Xiaowei Bao > > > > > > > Sent: Monday, August 26, 2019 2:55 PM > > > > > > > To: w...@denx.de; Shengzhou Liu ; > > Ruchika > > > > > > > Gupta ; ja...@amarulasolutions.com; > > > > > > s...@chromium.org; > > > > > > > Prabhakar Kushwaha ; > > Chuanhua Han > > > > > > > ; Jagdish Gediya > > > > > > > ; bmeng...@gmail.com; > > > > > > > u-boot@lists.denx.de > > > > > > > Cc: York Sun ; Xiaowei Bao > > > > > > > > > > > > > > Subject: [PATCH v6 1/4] dm: spi: Convert Freescale ESPI > > > > > > > driver to driver model > > > > > > > > > > > > > > From: Chuanhua Han > > > > > > > > > > > > > > Modify the Freescale ESPI driver to support the driver model. > > > > > > > Also resolved the following problems: > > > > > > > > > > > > > > = WARNING > > == This > > > > > > board does > > > > > > > not use CONFIG_DM_SPI. Please update the board before > > v2019.04 > > > > > > > for no dm conversion and v2019.07 for partially dm converted > > drivers. > > > > > > > Failure to update can lead to driver/board removal See > > > > > > > doc/driver- model/MIGRATION.txt for more info. > > > > > > > > > > > > > > > > = WARNING > > == This > > > > > > board does > > > > > > > not use CONFIG_DM_SPI_FLASH. Please update the board to use > > > > > > > CONFIG_SPI_FLASH before the v2019.07 release. > > > > > > > Failure to update by the deadline may result in board removal. > > > > > > > See doc/driver-model/MIGRATION.txt for more info. > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Chuanhua Han > > > > > > > Signed-off-by: Xiaowei Bao > > > > > > > --- > > > > > > > depends on: > > > > > > > https://patc > > > > > > > hwo > > > > > > > > > > > > > > > > > > > rk.ozlabs.org%2Fcover%2F1146494%2Fdata=02%7C01%7Cprabhaka > > r.k > > > > > > us > > > > > > > > > > > > > > > hwaha%40nxp.com%7Ccc2424972d4e4d6835f908d72a08b877%7C686ea1 > > d3 > > > > > > bc2 > > > > > > > > > > > > > > > b4c6fa92cd99c5c301635%7C0%7C0%7C637024089250212151sdat > > a= > > > > > > 3Ki9 > > > > > > > > > mrnn9YXWMR0vjoDmeE2eKBIn1RKlgnRC81SZQbU%3Dreserved=0 > > > > > > > Changes in v6: > > > > > > > - Change #ifndef CONFIG_DM_SPI to #if > > !CONFIG_IS_ENABLED(DM_SPI). > > > > > > > Changes in v5: > > > > > > > - Modify the function spi_cs_activate to fsl_spi_cs_activate. > > > > > > > - Move cs to the parameter of the fsl_spi_cs_activate > function. > > > > > > > Changes in v4: > > > > > > > - Update copyright information. > > > > > > > - Move the fsl_espi_platdata data structure to the > > > > > > > include/dm/platform_data/. > > > > > > > - Merge the contents of the fsl_espi_priv structure into > > > > > > > the fsl_spi_slave structure. > > >
