Re: [U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver
Am 13.02.2018 um 17:30 schrieb York Sun: On 02/13/2018 04:49 AM, Wolfgang Denk wrote: Dear York, In message <vi1pr04mb20785ef7d2578e39c048ee219a...@vi1pr04mb2078.eurprd04.prod.outlook.com> you wrote: Nobody said anything. Some addresses bounced. And most changes made out people outside Freescale/NXP are minor changes, except twice the files were moved during U-Boot structure change. What options do I have? Ask all people who contributed to that code for their explicit permission. Legally it is a huge difference between actively confirming approval and not reacting at all. All, If you haven't responded, please give your explicit approval to change Freescale DDR driver to dual-license so it can be re-used by other project(s) with BSD license. Here is the list I compiled from the git history. All commits made by Freescale/NXP employees are removed from this list. 00caae6 - Simon Glass, s...@chromium.org, 6 months ago : env: Rename getenv/_f() to env_get() 457e51c - Simon Glass, s...@chromium.org, 9 months ago : common: arm: freescale: layerscape: Move header files out of common.h 6e2941d - Simon Glass, s...@chromium.org, 9 months ago : common: freescale: Move arch-specific declarations 3c476d8 - Tom Rini, tr...@konsulko.com, 10 months ago : Merge git://git.denx.de/u-boot-fsl-qoriq 0e0de24 - xypron.g...@gmx.de, xypron.g...@gmx.de, 10 months ago : ddr: fsl: incorrect logical constraint in populate_memctl_options 97fbf26 - Thomas Schaefer, thomas.schae...@kontron.com, 11 months ago : drivers: ddr: fsl: fix unused-const-variable warnings f1683aa - Simon Glass, s...@chromium.org, 10 months ago : board_f: Rename initdram() to dram_init() 3eace37 - Simon Glass, s...@chromium.org, 10 months ago : arm: freescale: Rename initdram() to fsl_initdram() 088454c - Simon Glass, s...@chromium.org, 11 months ago : board_f: Drop return value from initdram() cbe7706 - Tom Rini, tr...@konsulko.com, 1 year, 5 months ago : Merge git://git.denx.de/u-boot-fsl-qoriq a4ca379 - Masahiro Yamada, yamada.masah...@socionext.com, 1 year, 5 months ago : drivers: squash lines for immediate return 62a3b7d - Robert P. J. Day, rpj...@crashcourse.ca, 1 year, 7 months ago : Various, unrelated tree-wide typo fixes. dd8d8da - Alexander Merkle, alexander.mer...@lauterbach.com, 1 year, 11 months ago : Fix typo choosen in comments and printf logs 5b8031c - Tom Rini, tr...@konsulko.com, 2 years, 1 month ago : Add more SPDX-License-Identifier tags da58dec - Tom Rini, tr...@konsulko.com, 2 years, 3 months ago : Various Makefiles: Add SPDX-License-Identifier tags e368c20 - Joakim Tjernlund, joakim.tjernl...@transmode.se, 2 years, 4 months ago : drivers/ddr/fsl_ddr: Make SR_IE configurable d7c865b - Curt Brune, c...@cumulusnetworks.com, 3 years ago : MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register b414119 - Masahiro Yamada, yamad...@jp.panasonic.com, 3 years, 3 months ago : linux/kernel.h: sync min, max, min3, max3 macros with Linux e1bf824 - Simon Glass, s...@chromium.org, 3 years, 10 months ago : Add cli_ prefix to readline functions 18d6653 - Simon Glass, s...@chromium.org, 3 years, 10 months ago : move CLI prototypes to cli.h and add comments 06c1411 - Masahiro Yamada, yamad...@jp.panasonic.com, 4 years, 4 months ago : powerpc: convert makefiles to Kbuild style 7e157b0 - Valentin Longchamp, valentin.longch...@keymile.com, 4 years, 4 months ago : mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it 0778bbe - Valentin Longchamp, valentin.longch...@keymile.com, 4 years, 4 months ago : mpc8xxx: call i2c_set_bus_num in __get_spd 2f848f9 - Shruti Kanetkar, shr...@freescale.com, 4 years, 6 months ago : powerpc: Use print_size() where appropriate 1a45966 - Wolfgang Denk, w...@denx.de, 4 years, 7 months ago : Add GPL-2.0+ SPDX-License-Identifier to source files 5b93394 - Anatolij Gustschin, ag...@denx.de, 5 years ago : mpc8xxx: fix DDR init value to use CONFIG_MEM_INIT_VALUE 411e150 - Kumar Gala, ga...@kernel.crashing.org, 6 years ago : arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning 2f3a71f - Ira W. Snyder, i...@ovro.caltech.edu, 6 years ago : mpc8xxx: update module_type values from JEDEC DDR3 SPD Specification dea7f88 - Kumar Gala, ga...@kernel.crashing.org, 6 years ago : arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c: Fix GCC 4.6 build warning 667bc17 - Kumar Gala, ga...@kernel.crashing.org, 6 years ago : arch/powerpc/cpu/mpc8xxx/ddr/options.c: Fix GCC 4.6 build warning cd84b1f - Marek Vasut, marek.va...@gmail.com, 6 years ago : GCC4.6: Squash warnings in ddr[123]_dimm_params.c a287963 - Kyle Moffett, kyle.d.moff...@boeing.com, 7 years ago : fsl-ddr: Fix mixed-case macro names c2a63f4 - Kumar Gala, ga...@kernel.crashing.org, 7 years ago : powerpc/8xxx: Fix typo for address hashing message c7fd27c - Kyle Moffett, kyle.d.moff...@boeing.com, 7 years ago : mpc8xxx: DDR2/DDR3: Clean up DIMM-type switch statements e820a13 - Kyle Moffett, kyle.d.moff...@boeing.com, 7 years ago : fsl_ddr: Don't use full
[U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs
Minor change: chosen is written with one "o".
No code change here, only comment & printf.
Signed-off-by: Alexander Merkle <alexander.mer...@lauterbach.com>
---
common/menu.c | 2 +-
drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/menu.c b/common/menu.c
index eda96d6..c53030f 100644
--- a/common/menu.c
+++ b/common/menu.c
@@ -350,7 +350,7 @@ int menu_item_add(struct menu *m, char *item_key, void
*item_data)
* make it obvious what the key for each entry is.
*
* item_choice - If not NULL, will be called when asking the user to choose an
- * item. Returns a key string corresponding to the choosen item or NULL if
+ * item. Returns a key string corresponding to the chosen item or NULL if
* no item has been selected.
*
* item_choice_data - Will be passed as the argument to the item_choice
function
diff --git a/drivers/ddr/fsl/lc_common_dimm_params.c
b/drivers/ddr/fsl/lc_common_dimm_params.c
index 47ad4e5..850c8f6 100644
--- a/drivers/ddr/fsl/lc_common_dimm_params.c
+++ b/drivers/ddr/fsl/lc_common_dimm_params.c
@@ -60,8 +60,8 @@ compute_cas_latency(const unsigned int ctrl_num,
* 18ns for all DDR4 speed grades.
*/
if (caslat_actual * mclk_ps > taamax) {
- printf("The choosen cas latency %d is too large\n",
- caslat_actual);
+ printf("The chosen cas latency %d is too large\n",
+ caslat_actual);
}
outpdimm->lowest_common_spd_caslat = caslat_actual;
debug("lowest_common_spd_caslat is 0x%x\n", caslat_actual);
--
2.7.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Fix typo in chosen parameter in vf610-twr.dts.
Signed-off-by: Alexander Merkle <alexander.mer...@lauterbach.com>
---
arch/arm/dts/vf610-twr.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/vf610-twr.dts b/arch/arm/dts/vf610-twr.dts
index a4ccbcb..237aa8d 100644
--- a/arch/arm/dts/vf610-twr.dts
+++ b/arch/arm/dts/vf610-twr.dts
@@ -11,7 +11,7 @@
model = "VF610 Tower Board";
compatible = "fsl,vf610-twr", "fsl,vf610";
- choosen {
+ chosen {
stdout-path =
};
--
2.7.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts
Fix typo "choosen" instead of "chosen" in vf610-twr.dts.
Fixes boot process and terminal output for Vybrid series.
Signed-off-by: Alexander Merkle <alexander.mer...@lauterbach.com>
---
arch/arm/dts/vf610-twr.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/vf610-twr.dts b/arch/arm/dts/vf610-twr.dts
index a4ccbcb..237aa8d 100644
--- a/arch/arm/dts/vf610-twr.dts
+++ b/arch/arm/dts/vf610-twr.dts
@@ -11,7 +11,7 @@
model = "VF610 Tower Board";
compatible = "fsl,vf610-twr", "fsl,vf610";
- choosen {
+ chosen {
stdout-path =
};
--
2.7.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts
Fix typo "choosen" instead of "chosen" in pcm052.dts.
Not tested but should fix boot process and terminal output.
Signed-off-by: Alexander Merkle <alexander.mer...@lauterbach.com>
---
arch/arm/dts/pcm052.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/pcm052.dts b/arch/arm/dts/pcm052.dts
index 0475f1f..0985587 100644
--- a/arch/arm/dts/pcm052.dts
+++ b/arch/arm/dts/pcm052.dts
@@ -11,7 +11,7 @@
model = "Phytec phyCORE-Vybrid";
compatible = "phytec,pcm052", "fsl,vf610";
- choosen {
+ chosen {
stdout-path =
};
--
2.7.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code
The dts files for NXP/Freescale Vybrid series were broken. Fixed some other typos in comments & printfs to. Alexander Merkle (3): Fix typo in chosen parameter in vf610-twr.dts Fix typo in chosen parameter of pcm052.dts Fix typo choosen in comments and printf logs arch/arm/dts/pcm052.dts | 2 +- arch/arm/dts/vf610-twr.dts | 2 +- common/menu.c | 2 +- drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) -- 2.7.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code
Hi,
may be the subject is misleading. The DTS/DTB entry should be named
"chosen"
but it was "choosen" with "oo" in the git master. Have a look to the
commits.
diff --git a/arch/arm/dts/vf610-twr.dts b/arch/arm/dts/vf610-twr.dts
index a4ccbcb..237aa8d 100644
--- a/arch/arm/dts/vf610-twr.dts
+++ b/arch/arm/dts/vf610-twr.dts
@@ -11,7 +11,7 @@
model = "VF610 Tower Board";
compatible = "fsl,vf610-twr", "fsl,vf610";
- choosen {
+ chosen {
stdout-path =
};
Regards,
Alex
Alexander Merkle
System Engineer
Lauterbach GmbH
Altlaufstraße 40
85635 Hoehenkirchen-Siegertsbrunn
Germany
Tel +49 8102 9876-147
mailto:alexander.mer...@lauterbach.com
http://www.lauterbach.com
On 17.03.2016 16:06, Bhuvanchandra DV wrote:
On 03/17/2016 08:14 PM, Alexander Merkle wrote:
The dts files for NXP/Freescale Vybrid series were broken.
Fixed some other typos in comments & printfs to.
I guess this is not typo the node name is 'chosen'.
Some documentation is here[1].
[1]
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/chosen.txt
Alexander Merkle (3):
Fix typo in chosen parameter in vf610-twr.dts
Fix typo in chosen parameter of pcm052.dts
Fix typo choosen in comments and printf logs
arch/arm/dts/pcm052.dts | 2 +-
arch/arm/dts/vf610-twr.dts | 2 +-
common/menu.c | 2 +-
drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2] [PATCH v2] fix ARM DCC support for ARMv7 based cores (e.g. CortexA)
Signed-off-by: Alexander Merkle alexander.mer...@lauterbach.com --- include/configs/zynq-common.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index 87b4fff..789e437 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -34,7 +34,6 @@ /* DCC driver */ #if defined(CONFIG_ZYNQ_DCC) # define CONFIG_ARM_DCC -# define CONFIG_CPU_V6 /* Required by CONFIG_ARM_DCC */ #else # define CONFIG_ZYNQ_SERIAL #endif -- 2.1.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] fix ARM DCC support for ARMv7 based cores (e.g. CortexA)
fix arm_dcc.c implementation for ARMv7 based cores. remove now obsolete workaround for ZYNQ Alexander Merkle (2): fix ARM DCC support for ARMv7 based cores (e.g. CortexA) fix ARM DCC support for ARMv7 based cores (e.g. CortexA) drivers/serial/arm_dcc.c | 4 ++-- include/configs/zynq-common.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) -- 2.1.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] fix ARM DCC support for ARMv7 based cores (e.g. CortexA)
Signed-off-by: Alexander Merkle alexander.mer...@lauterbach.com --- drivers/serial/arm_dcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/arm_dcc.c b/drivers/serial/arm_dcc.c index 5dfb02f..e37 100644 --- a/drivers/serial/arm_dcc.c +++ b/drivers/serial/arm_dcc.c @@ -29,9 +29,9 @@ #include common.h #include serial.h -#if defined(CONFIG_CPU_V6) +#if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_V7) /* - * ARMV6 + * ARMV6 ARMV7 */ #define DCC_RBIT (1 30) #define DCC_WBIT (1 29) -- 2.1.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] fix ARM DCC support for ARMv7 based cores (e.g. CortexA)
Signed-off-by: Alexander Merkle alexander.mer...@lauterbach.com --- drivers/serial/arm_dcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/arm_dcc.c b/drivers/serial/arm_dcc.c index 5dfb02f..e37 100644 --- a/drivers/serial/arm_dcc.c +++ b/drivers/serial/arm_dcc.c @@ -29,9 +29,9 @@ #include common.h #include serial.h -#if defined(CONFIG_CPU_V6) +#if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_V7) /* - * ARMV6 + * ARMV6 ARMV7 */ #define DCC_RBIT (1 30) #define DCC_WBIT (1 29) -- 2.1.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/1] fix ARM DCC support for ARMv7 based cores (e.g. CortexA)
arm_dcc.c supported ARMv4 (ARM7) to ARMv6 (ARM11) correctly. All recent CortexA/ARMv7 based cores share the mrc/mcr coprocessor calls of ARMv6. Due to the missing #ifdef the ARM7/ARMv4 calls are used as soon as CONFIG_CPU_V7 is defined. This results in an undefined instruction exception. Alexander Merkle (1): fix ARM DCC support for ARMv7 based cores (e.g. CortexA) drivers/serial/arm_dcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.1.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
