Re: [U-Boot] [PATCH v5 01/16] arm: ls102xa: Add Freescale LS102xA SoC support

2014-08-19 Thread AlisonWang 
Hi, Mark,

On Tue, Aug 19, 2014 at 03:54:50AM +0100, Alison Wang wrote:

 +int timer_init(void) 
 +{ 
 +   struct sctr_regs *sctr = (struct sctr_regs *)SCTR_BASE_ADDR; 
 +   unsigned long ctrl, val, freq; 
 + 
 +   /* Enable System Counter */ 
 +   writel(SYS_COUNTER_CTRL_ENABLE, sctr-cntcr); 
 + 
 +   freq = GENERIC_TIMER_CLK; 
 +   asm(mcr p15, 0, %0, c14, c0, 0 : : r (freq));

Is CNTFRQ initialised for both CPUs? 

[Alison Wang] No, only one CPU is booted now.

If the CPUs are booted at PL1 rather than PL2, is CNTVOFF initialised to 
the same value on both CPUs? 

[Alison Wang] CNTVOFF is not initialized in the current secure mode. When
we add virtualization support and switch to non-secure mode, we will
initialize CNTVOFF to zero on both CPUs.

Thanks.
Alison



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v5-0-16-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp186978p187075.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4 16/18] video: dcu: Add Sii9022A HDMI Transmitter support

2014-08-16 Thread AlisonWang 
On 08/13/2014 11:45 PM, Alison Wang wrote:

 On LS1021ATWR, Silicon's Sii9022A HDMI Transmitter 
 is used. This patch adds the common setting for this 
 chip. 
 

Shouldn't this driver stay under driver/video? It is for the HDMI
transmitter, 
not Freescale board specific, is it? 

[Alison Wang] It's just a simple register setting for Sii9022A on Freescale
board LS1021ATWR,
and not a regular video driver. I am not sure whether it should stay under
driver/video.

 
 diff --git a/board/freescale/common/Makefile
 b/board/freescale/common/Makefile 
 index 22b57cc..808ddd0 100644 
 --- a/board/freescale/common/Makefile 
 +++ b/board/freescale/common/Makefile 
 @@ -34,6 +34,8 @@ ifndef CONFIG_RAMBOOT_PBL 
  obj-$(CONFIG_FSL_FIXED_MMC_LOCATION) += sdhc_boot.o 
  endif 
   
 +obj-$(CONFIG_FSL_DCU_SII9022A)+= dcu_sii9022a.o 
 + 
  obj-$(CONFIG_MPC8541CDS) += cds_pci_ft.o 
  obj-$(CONFIG_MPC8548CDS) += cds_pci_ft.o 
  obj-$(CONFIG_MPC8555CDS) += cds_pci_ft.o 
 diff --git a/board/freescale/common/dcu_sii9022a.c
 b/board/freescale/common/dcu_sii9022a.c 
 new file mode 100644 
 index 000..2da627e 
 --- /dev/null 
 +++ b/board/freescale/common/dcu_sii9022a.c 
 @@ -0,0 +1,153 @@ 
 +/* 
 + * Copyright 2014 Freescale Semiconductor, Inc. 
 + * 
 + * SPDX-License-Identifier:  GPL-2.0+ 
 + */ 
 + 
 +#include asm/io.h 
 +#include common.h 
 +#include fsl_dcu_fb.h 

I think you put the patches in wrong order. DCU driver has not been added
before 
this patch. 

[Alison Wang] Ok, I will change the order in v5.

Alison



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v4-0-18-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp186703p186810.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4 04/18] net: mdio: Add private MDIO read/write function

2014-08-16 Thread AlisonWang 
On 08/13/2014 11:44 PM, Alison Wang wrote:

 As extra FPGA settings is needed for MDIO read/write 
 on LS1021AQDS, private MDIO read/write functions are 
 created. 
 
 Signed-off-by: Alison Wang [hidden email] 
 --- 
 Change log: 
  v4: No change. 
  v3: Split from the 0004-arm-ls102xa-Add-etsec-support-for-LS102xA patch. 
  v2: Add private mdio read and write support. 
 
  drivers/net/fsl_mdio.c | 9 +++-- 
  include/fsl_mdio.h | 4  
  2 files changed, 11 insertions(+), 2 deletions(-) 
 
 diff --git a/drivers/net/fsl_mdio.c b/drivers/net/fsl_mdio.c 
 index 8d09f5d..6eae78f 100644 
 --- a/drivers/net/fsl_mdio.c 
 +++ b/drivers/net/fsl_mdio.c 
 @@ -98,8 +98,13 @@ int fsl_pq_mdio_init(bd_t *bis, struct fsl_pq_mdio_info
 *info) 
   return -1; 
   } 
   
 - bus-read = tsec_phy_read; 
 - bus-write = tsec_phy_write; 
 + if (info-priv_mdio_read) { 
 + bus-read = info-priv_mdio_read; 
 + bus-write = info-priv_mdio_write; 
 + } else { 
 + bus-read = tsec_phy_read; 
 + bus-write = tsec_phy_write; 
 + } 
   bus-reset = fsl_pq_mdio_reset; 
   sprintf(bus-name, info-name); 
   
 diff --git a/include/fsl_mdio.h b/include/fsl_mdio.h 
 index a531edf..633123c 100644 
 --- a/include/fsl_mdio.h 
 +++ b/include/fsl_mdio.h 
 @@ -57,6 +57,10 @@ int memac_mdio_read(struct mii_dev *bus, int port_addr,
 int dev_addr, 
  struct fsl_pq_mdio_info { 
   struct tsec_mii_mng __iomem *regs; 
   char *name; 
 + int (*priv_mdio_read)(struct mii_dev *bus, int addr, 
 +  int devad, int reg); 
 + int (*priv_mdio_write)(struct mii_dev *bus, int addr, int devad, 
 +   int reg, u16 val); 
  }; 
  int fsl_pq_mdio_init(bd_t *bis, struct fsl_pq_mdio_info *info); 
   


Alison, 

Please check if Shaohui's comment on your v3 patch is valid. He suggested
you 
don't need to add a new private functions. 

[Alison Wang] His comment is valid. I will change in v5.

Best Regards,
Alison Wang



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v4-0-18-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp186703p186808.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4 02/18] ls102xa: i2c: Add i2c support for LS102xA

2014-08-16 Thread AlisonWang 
On 08/13/2014 11:44 PM, Alison Wang wrote: 
 This patch is to add I2C 1,2,3 support for LS102xA. 
 

I think the commit message should say which existing I2C driver is
compatible 
with the controller of LS201x. From the change, you are using the same
driver 
for i.MX. But it is not clear if you are using the 8-bit driver or the
32-bit 
driver. I can tell from your patch 01/18 that you enabled I2C_QUIRK_REG to
use 
8-bit driver. This should go into the commit message to help other follow
the 
suit if another SoC is added the same way. 

[Alison Wang] Yes, I will give a detailed commit message. Thanks.

Alison



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v4-0-18-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp186703p186809.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4 15/18] arm: ls102xa: Add LETECH support for LS1021AQDS/TWR board

2014-08-16 Thread AlisonWang 
 From: Wang Huan [hidden email] 
 
 This patch is to add LETECH support for LS1021AQDS/TWR board. 
 For LETECH, lpuart is used as console. 
 

I suggest you update README to add some information about this LETECH. I
have no 
idea what it is until I dig into some internal documents.

[Alison Wang] Ok, I will add. Thanks.

Alison 



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v4-0-18-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp186703p186811.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 09/10] arm: ls102xa: Add basic support for LS1021AQDS board

2014-08-11 Thread AlisonWang 
Hi, York,

On 07/03/2014 12:24 AM, Alison Wang wrote:
 diff --git a/lib/lmb.c b/lib/lmb.c
 index 081e418..0903222 100644
 --- a/lib/lmb.c
 +++ b/lib/lmb.c
 @@ -295,7 +295,7 @@ phys_addr_t __lmb_alloc_base(struct lmb *lmb,
 phys_size_t size, ulong align, phy
if (max_addr == LMB_ALLOC_ANYWHERE)
base = lmb_align_down(lmbbase + lmbsize - size,
 align);
else if (lmbbase  max_addr) {
 - base = min(lmbbase + lmbsize, max_addr);
 + base = min(lmbbase + lmbsize - 1, max_addr);
base = lmb_align_down(base - size, align);
} else
continue;
 
 
Alison,
 
You didn't mention the change to lmb.c. It looks like a bug fix.

[Alison Wang] Yes, I will prepare a separate patch for it and add the commit
message. Thanks.
 
Best Regards,
Alison Wang



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v2-0-9-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp183468p186445.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/9] arm: ls102xa: Add Freescale LS102xA SoC and LS1021AQDS/TWR board support

2014-08-11 Thread AlisonWang 
Hi, York,

On 07/03/2014 12:24 AM, Alison Wang wrote: 
 This series contain the support for Freescale LS102xA SoC and
 LS1021AQDS/TWR board. 
 
Alison, 

Please respin your patches. It has been a while since you submitted them.
For 
your convenience, I have rebased your patches to v2014.10-rc1 and converted
to 
the latest Kconfig. They can be compiled but I didn't verify on boards.
Please 
verify and address the review comments. 

http://git.denx.de/?p=u-boot/u-boot-fsl-qoriq.git;a=shortlog;h=refs/heads/test

Please submit your new patches based on u-boot-fsl-qoriq/master. 

[Alison Wang] Thanks for your help. I will respin the patches and send out
v3.

Best Regards,
Alison Wang



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v2-0-9-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp183468p186448.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 04/10] arm: ls102xa: Add etsec support for LS102xA

2014-08-11 Thread AlisonWang 
On 07/03/2014 12:24 AM, Alison Wang wrote: 

Missing commit message here. 

[Alison Wang] Yes, I will add in v3.

 Signed-off-by: Alison Wang [hidden email] 
 --- 
 Change log: 
  v2: Add private mdio read and write support. 
 
  drivers/net/fsl_mdio.c | 24 +++- 
  drivers/net/tsec.c |  7 +++ 
  include/fsl_mdio.h |  3 +++ 
  include/tsec.h |  7 ++- 
  4 files changed, 35 insertions(+), 6 deletions(-) 
 
 diff --git a/drivers/net/fsl_mdio.c b/drivers/net/fsl_mdio.c 
 index 8d09f5d..3081228 100644 
 --- a/drivers/net/fsl_mdio.c 
 +++ b/drivers/net/fsl_mdio.c 
 @@ -12,6 +12,15 @@ 
  #include asm/io.h 
  #include asm/errno.h 
   
 +void tsec_mdio_sync(void) 
 +{ 
 +#if defined(CONFIG_PPC) 
 + asm(sync); 
 +#elif defined(CONFIG_ARM) 
 + asm(dsb); 
 +#endif 
 +} 
 + 
  void tsec_local_mdio_write(struct tsec_mii_mng __iomem *phyregs, int
 port_addr, 
   int dev_addr, int regnum, int value) 
  { 
 @@ -19,7 +28,7 @@ void tsec_local_mdio_write(struct tsec_mii_mng __iomem
 *phyregs, int port_addr, 
   
   out_be32(phyregs-miimadd, (port_addr  8) | (regnum  0x1f)); 
   out_be32(phyregs-miimcon, value); 
 - asm(sync); 
 + tsec_mdio_sync(); 
  

Don't reinvent the wheel. You can use mb() where you use tsec_mdio_sync(); 

[Alison Wang] Yes, I will change in v3. Thanks.

Best Regards,
Alison Wang



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v2-0-9-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp183468p186446.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 05/10] arm: ls102xa: Add esdhc support for LS102xA

2014-08-11 Thread AlisonWang 
On 07/03/2014 12:24 AM, Alison Wang wrote: 

Missing commit message here. You should explain why we need this change. It
will 
help us search the log later. 

[Alison Wang] I will add commit message in v3.

 Signed-off-by: Alison Wang [hidden email] 
 ---

Best Regards,
Alison Wang



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v2-0-9-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp183468p186447.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/9] arm: ls102xa: Add Freescale LS102xA SoC and LS1021AQDS/TWR board support

2014-07-03 Thread AlisonWang 
Hi, Albert,

On Thu, 3 Jul 2014 15:24:14 +0800, Alison Wang
wrote: 

 This series contain the support for Freescale LS102xA SoC and
 LS1021AQDS/TWR board. 

The numbering in the cover letter (0/9) does not match that in the 
individual patches (n/10). Is this normal?

Sorry, it's my mistake. It should be 0/10 in the cover letter, not 0/9.

Best Regards,
Alison Wang



--
View this message in context: 
http://u-boot.10912.n7.nabble.com/PATCH-v2-0-9-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp183468p183492.html
Sent from the U-Boot mailing list archive at Nabble.com.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot