Thanks everyone for including me — I don’t have any code comments but I will say that this i2c driver, with the exception of the i2c default address (which looks like is being set via the device tree anyway), should also work with the ATECC508, ATECC608A, ATECC608B (which is the one of those three recommended for new designs) as I believe the interface at this level was not changed.
So that might be a nice comment or add to documentation. Otherwise, I’m glad to see y’all supporting this. Also, it’s been a while since I’ve been active on such mailing lists, so I can’t remember the reply etiquette exactly. Apologizes in advance for the naive top-post :) Josh > On Dec 21, 2021, at 9:17 AM, Adrian Fiergolski > <adrian.fiergol...@fastree3d.com> wrote: > > Series of patches fixing atsha204a driver. Partially inspired by Enclustra's > repo [1]. > > [1] https://github.com/enclustra-bsp/xilinx-uboot > > Adrian Fiergolski (3): > misc: atsha204a: return timeout from wakeup function > misc: atsha204a: add delay after sending the message > misc: atsha204a: fix i2c address readout from DTS > > drivers/misc/atsha204a-i2c.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > -- > 2.34.1 >
