Re: [U-Boot] [PATCH] powerpc/p5040: add serdes2 memory map register define
On Thu, Jan 17, 2013 at 9:26 AM, Roy Zang tie-fei.z...@freescale.com wrote: Signed-off-by: Roy Zang tie-fei.z...@freescale.com --- Why? We don't need this for P5040 support. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [PATCH 1/3] powerpc/p5040: enable NAND boot support
Xie Shaohui-B21989 wrote: [S.H] I thought one patch doing one thing even it's simple. I'm fine with the merge if you insist. Well, it is a matter of opinion. I don't insist, but I think it would be easier for everyone if you did merge these patches. Each one is very short, and they are all very similar. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/mpc85xx: Add BSC9132/BSC9232 processor support
On Mon, Jan 14, 2013 at 10:26 PM, Prabhakar Kushwaha prabha...@freescale.com wrote: #define SVR_9130 0x860001 #define SVR_9131 0x86 +#define SVR_9132 0x861000 +#define SVR_9132_E 0x861800 +#define SVR_9232 0x861400 Remove SVR_9132_E. See commit 48f6a5c348453fc3ab33aaa91e5e4198a28678ff -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/mpc85xx: Add property 'fsl, sec-era' in device tree node 'crypto'.
On Thu, Jan 10, 2013 at 5:49 AM, Vakul Garg va...@freescale.com wrote:
If property 'fsl,sec-era' is already present, it is updated.
This property is required so that applications can ascertain which
descriptor commands are supported on a particular CAAM version.
Signed-off-by: Vakul Garg va...@freescale.com
Cc: Andy Fleming aflem...@gmail.com
---
arch/powerpc/cpu/mpc85xx/fdt.c|8 +++
arch/powerpc/cpu/mpc8xxx/fdt.c| 78
-
arch/powerpc/include/asm/immap_85xx.h |6 +++
3 files changed, 91 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
index 5af2661..e7b5dfd 100644
--- a/arch/powerpc/cpu/mpc85xx/fdt.c
+++ b/arch/powerpc/cpu/mpc85xx/fdt.c
@@ -591,6 +591,14 @@ void ft_cpu_setup(void *blob, bd_t *bd)
/* delete crypto node if not on an E-processor */
if (!IS_E_PROCESSOR(get_svr()))
fdt_fixup_crypto_node(blob, 0);
+#if CONFIG_SYS_FSL_SEC_COMPAT = 4 /* SEC 4.x/5.x */
+ else {
+ ccsr_sec_t *sec;
ccsr_sec_t __iomem *sec;
+
+ sec = (void __iomem *)CONFIG_SYS_FSL_SEC_ADDR;
+ fdt_fixup_crypto_node(blob, in_be32(sec-secvid_ms));
+ }
+#endif
fdt_fixup_ethernet(blob);
diff --git a/arch/powerpc/cpu/mpc8xxx/fdt.c b/arch/powerpc/cpu/mpc8xxx/fdt.c
index 68db8e2..20cbb45 100644
--- a/arch/powerpc/cpu/mpc8xxx/fdt.c
+++ b/arch/powerpc/cpu/mpc8xxx/fdt.c
@@ -297,10 +297,86 @@ void fdt_fixup_crypto_node(void *blob, int sec_rev)
fdt_strerror(err));
}
#elif CONFIG_SYS_FSL_SEC_COMPAT = 4 /* SEC4 */
+static u8 caam_get_era(void)
+{
+ static const struct {
+ u16 ip_id;
+ u8 maj_rev;
+ u8 era;
+ } caam_eras[] = {
+ {0x0A10, 1, 1},
+ {0x0A10, 2, 2},
+ {0x0A12, 1, 3},
+ {0x0A14, 1, 3},
+ {0x0A14, 2, 4},
+ {0x0A16, 1, 4},
+ {0x0A10, 3, 4},
+ {0x0A11, 1, 4},
+ {0x0A18, 1, 4},
+ {0x0A11, 2, 5},
+ {0x0A12, 2, 5},
+ {0x0A13, 1, 5},
+ {0x0A1C, 1, 5}
+ };
+
+ ccsr_sec_t *sec = (void __iomem *)CONFIG_SYS_FSL_SEC_ADDR;
same here
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Introduce a global bool type
On Mon, Jan 7, 2013 at 4:39 PM, Wolfgang Denk w...@denx.de wrote: This seems broken to me. Can we rather try8 and get rid of all this bool stuff instead? It's just obfuscating the code... Like Scott said, we sometimes copy code from Linux that uses 'bool', so it's simpler if we just retain this commonly-used type. If it's part of the language, how is it obfuscating? Maybe the Linux developers should have used _Bool instead of bool, but they didn't, and so here we are. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-mpc85xx.git
On Wed, Nov 28, 2012 at 1:39 AM, Andy Fleming aflem...@freescale.com wrote: Timur Tabi (5): powerpc/85xx/p5040: add CONFIG_SYS_PPC64, del CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC powerpc/85xx: add support for the Freescale P5040DS Superhydra reference board powerpc/85xx: implement check for erratum A-004849 work-around powerpc/85xx: implement check for erratum A-004580 work-around powerpc/85xx: update the work-around for P4080 erratum SERDES-9 You forgot this patch again: http://patchwork.ozlabs.org/patch/170753/ -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration
On Thu, Nov 1, 2012 at 3:13 AM, Roy Zang tie-fei.z...@freescale.com wrote: board configuration file is included before asm/config_mpc85xx.h. however, CONFIG_FSL_SATA_V2 is defined in asm/config_mpc85xx.h. it will never take effective in the board configuration file for this kind of code : #ifdef CONFIG_FSL_SATA_V2 ... #endif To solve this problem, move CONFIG_FSL_SATA_V2 to board configuration header file. http://patchwork.ozlabs.org/patch/126958/ -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration
On Thu, Nov 1, 2012 at 11:20 AM, Tabi Timur-B04825 b04...@freescale.com wrote: To solve this problem, move CONFIG_FSL_SATA_V2 to board configuration header file. http://patchwork.ozlabs.org/patch/126958/ To be clear, I think you should say in the patch description that your patch effectively reverts mine. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 22/22] powerpc/mpc85xx/p2020rdb-pca: Use L2 SRAM for SPL boot
On Mon, Oct 29, 2012 at 9:05 PM, Scott Wood scottw...@freescale.com wrote: diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h index ba7a364..f02ba2b 100644 --- a/include/configs/p1_p2_rdb_pc.h +++ b/include/configs/p1_p2_rdb_pc.h @@ -38,6 +38,7 @@ #define __SW_BOOT_MASK 0x03 #define __SW_BOOT_NOR 0xe4 #define __SW_BOOT_SD 0x54 +#define CONFIG_SYS_L2_SIZE (256 10) Shouldn't this be in config_mpc85xx.h? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-mpc85xx.git
On Mon, Oct 22, 2012 at 5:36 PM, Andy Fleming aflem...@freescale.com wrote: Timur Tabi (4): powerpc/mpc85xx: fix Unicode characters in release.S powerpc/85xx: define SRIO LIODN functions only if SRIO is defined powerpc/85xx: move SRIO configuration out of corenet_ds.h powerpc/85xx: Add P5040 processor support There are two other patches in Patchwork from me that are delegated to you. What about those? http://patchwork.ozlabs.org/patch/189587/ http://patchwork.ozlabs.org/patch/170753/ -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/fm: fix TBI PHY address settings
On Fri, Oct 12, 2012 at 1:25 AM, Shaohui Xie shaohui@freescale.com wrote: From: shaohui xie shaohui@freescale.com TBI PHY address (TBIPA) register is set in general frame manager phy init funciton dtsec_init_phy() in drivers/net/fm/eth.c, and it is supposed to set TBIPA on FM1@DTSEC1 in case of FM1@DTSEC1 isn't used directly, which provides MDIO for other ports. So following code is wrong in case of FM2, which has a different mac base. Is this still true with Fman v3? Does this patch fix any known bugs? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] SBx81CFC960: embed Fman microcode in the bootloader
judge.pack...@gmail.com wrote: .../SBx81CFC960/fsl_fman_ucode_P2041_101_8.bin | Bin 0 - 7240 bytes .../SBx81CFC960/fsl_fman_ucode_P2041_101_8.c | 607 Including the firmware itself in the patch is a bad idea. I do not want any Freescale firmware to be included in the U-Boot source tree itself. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] arch/powerpc/lib/board.c:get_effective_memsize() for 4GB+ systems
Robert Thorhuus wrote: I really see the advantage of keeping this map you have. It is of course more compatible with different OSEs and you do not need to do anything special with 32/64 bit cores. But at the same time you never take advantage of a 64 bit core with this approach. U-Boot is a boot loader, not an operating system. What is U-Boot supposed to do with more than 2GB of RAM? How should I access my 24GB in U-Boot? You should not! So really you are saying that I should have a 2GB map window in my 32-bit address space and then move this window depending on what memory I want to access? A bit cumbersome I must say. But ok. Again, you're doing the wrong thing with U-Boot. It's a boot loader. It's supposed to find your OS, load it into memory, and then boot it. How about the U-Boot relocation? As I see the code, it is not easy to decide where it should relocate. It will be either relocated to end of RAM or if we have more than 4G it will be at 4GB end. It relocates to the end of RAM or the end of 2GB, whichever is lower. It ignores all memory above 2GB. What if you want to place U-Boot at 16MB for instance? Or if you do not want a memory map hole at 4GB just because U-Boot doesn't handle more than that? Again, you're missing the point about U-boot. Last AND least I just want to say I'm used to creating memory maps in bootloader which holds for the OS. It seems the time has come to annihilate my illusion... Yes, please kill it with fire! -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] arch/powerpc/lib/board.c:get_effective_memsize() for 4GB+ systems
On Thu, Sep 20, 2012 at 3:24 PM, Robert Thorhuus robert.thorh...@ericsson.com wrote: I'm using 64 bit mpc85xx cores. U-Boot runs in 32-bit mode even on a 64-bit code. Mapping the whole memory from the beginning was of course just an initial thought. But for me it looks like the code is just not able to deal with more than 3.99GB mapped. U-Boot will not be able to be relocated. I would be very surprised if U-Boot could handle a value of CONFIG_MAX_MEM_MAPPED larger than 2GB, no matter what. We use the address space above 2GB for I/O addresses, like CCSR and PCI memory. You would need to reshuffle your I/O memory mappings to use a larger value. And even then, we've never tested that, and so who knows what obscure bugs are in the code. Is there a reason why you need access to more than 2GB of RAM from within U-Boot? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] libfdt: Add support for appending the values to a existing property
On Sat, Sep 15, 2012 at 9:36 AM, Jerry Van Baren gvb.ub...@gmail.com wrote: Queued up 2 of 2 patches to the u-boot-fdt next branch. I'll issue a pull request when the merge window opens. I thought libfdt patches were suppose to go to dtc.git? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [PATCH 4/5] powerpc/85xx: Add P5040 processor support
Kim Phillips wrote:
Cryptography acceleration (SEC 5.0) at up to 40 Gbps SerDes
it's a SEC 5.2, but...
Ok.
Dual four channel
Support for hardware virtualization and partitioning enforcement
Extra privileged level for hypervisor support
QorIQ Trust Architecture 1.1
Secure boot, secure debug, tamper detection, volatile key storage
...do we really need all this marketing text duplication anyway?
I like to provide this information when introducing new boards.
How about mentioning supported components in u-boot, as of this
patch?
Ok.
+struct liodn_id_table sec_liodn_tbl[] = {
+SET_SEC_JR_LIODN_ENTRY(0, 129, 130),
+SET_SEC_JR_LIODN_ENTRY(1, 131, 132),
+SET_SEC_JR_LIODN_ENTRY(2, 133, 134),
+SET_SEC_JR_LIODN_ENTRY(3, 135, 136),
+SET_SEC_RTIC_LIODN_ENTRY(a, 154),
+SET_SEC_RTIC_LIODN_ENTRY(b, 155),
+SET_SEC_RTIC_LIODN_ENTRY(c, 156),
+SET_SEC_RTIC_LIODN_ENTRY(d, 157),
+SET_SEC_DECO_LIODN_ENTRY(0, 97, 98),
+SET_SEC_DECO_LIODN_ENTRY(1, 99, 100),
+};
The SEC on the P5040 has four DECOs, not two. Plus, AFAICT, these
aren't the right values for these LIODN assignments.
This is the latest code from the SDK that we've been using for months. I
thought you reviewed these values already.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] powerpc/mpc8xxx: fix core id for multicore booting
On Fri, Aug 17, 2012 at 1:20 PM, York Sun york...@freescale.com wrote: + * 8-19 CHIP_ID,2’b00 - SoC 1 + * all others - reserved + * 20-24 CLUSTER_ID 5’b0 - CCM 1 + * all others - reserved + * 25-26 CORE_CLUSTER_ID 2’b00 - cluster 1 + * 2’b01 - cluster 2 + * 2’b10 - cluster 3 + * 2’b11 - cluster 4 + * 27-28 CORE_ID 2’b00 - core 0 + * 2’b01 - core 1 + * 2’b10 - core 2 + * 2’b11 - core 3 + * 29-31 THREAD_ID 3’b000 - thread 0 + * 3’b001 - thread 1 It's too bad no one noticed the Unicode characters in this comment before the patch was applied. http://www.fileformat.info/info/unicode/char/2019/index.htm -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc: Fix declaration type for I/O functions
On Thu, Aug 23, 2012 at 12:24 PM, Andy Fleming aflem...@gmail.com wrote: I'm guessing this change increased the amount of inlining. Sadly, the subsequent patches, which were intended to shrink the SPL build, were not enough to fix this problem. Maybe there are places where we can use raw I/O instead of accessors? Matt posted a patch like that a few weeks ago. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
Or Yoram-R56270 wrote: 1. Correct the v1 documentation to specify 23 MAC addresses and placing the CRC at 0xCC. 2. Create a new code and documentation for v2, specifying 31 MAC addresses and placing the CRC at 0xFC. Both of these are unnecessary. My patch fixes the code to match the spec *and* handles the CRC problem transparently. It also doesn't do anything controversial that the current code doesn't already do. Really, this is a non-issue. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
Wolfgang Denk wrote: This is a totally broken design then, when you have a growing data structure where vital information fields get shifted. In such case, the CRC should have been at the beginning, so it never changes location. Or even better, you should not have used a binary data structure at all (guess why the environment in U-Boot has been implemented the way it is). York is mistaken. The CRC was always at location 0xFC, but for some reason, when I wrote the code, I put it at 0xCC. Now I'm fixing it, and providing some backwards compatibility to avoid causing problems for people who upgrade U-Boot on existing boards. I don't see how this is controversial in any way. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
Wolfgang Denk wrote: My patch provides transparent updates to handle it. It will read broken EEPROMs and verify the CRC in the old location, and if you have re-save the EEPROM, it will put the CRC in the right place. It will work by chance, accessing random data. This is crap. It is not crap, and it will not work by chance. It is not accessing random data, it is accessing the CRC in the old location, just like the current code does today. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
sun york-R58495 wrote: I agree it was a broken design. Now we are using all available space and put CRC to the very end. It is not perfect but should work. *sigh* The design was never broken, the code was just wrong. The CRC has always supposed to have been at the end. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] net: abort network initialization if the PHY driver fails
Nobuhiro Iwamatsu wrote:
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index eee41d7..7a3d16b 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -510,7 +510,12 @@ static int fec_open(struct eth_device *edev)
fec_eth_phy_config(edev);
if (fec-phydev) {
/* Start up the PHY */
- phy_startup(fec-phydev);
+ int ret = phy_startup(fec-phydev);
+ if (ret) {
+ printf(Could not initialize PHY %s\n,
+ fm_eth-phydev-dev-name);
Probably this is fec, not fm_eth.
Thanks. I thought I was being diligent, and I ran MAKEALL, but I guess it
wasn't enough.
diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
index 7854a04..d777144 100644
--- a/drivers/net/xilinx_axi_emac.c
+++ b/drivers/net/xilinx_axi_emac.c
@@ -272,7 +272,11 @@ static int setup_phy(struct eth_device *dev)
phydev-advertising = phydev-supported;
priv-phydev = phydev;
phy_config(phydev);
- phy_startup(phydev);
+ if (phy_startup(phydev)) {
+ printf(axiemac: could not initialize PHY %s\n,
+ phydev-dev-name);
+ return 0;
+ }
switch (phydev-speed) {
case 1000:
Why doesn't this driver use a ret variable?
Other driver's patch used this.
Because setup_phy() returns either 0 (failure) or 1 (success).
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 18/24] mxc_i2c.c: finish adding CONFIG_I2C_MULTI_BUS support
On Fri, Jun 22, 2012 at 2:41 PM, Troy Kisky troy.ki...@boundarydevices.com wrote: Correct and correct. If you need i2c working before relocation, you cannot enable MULTI_BUS. That sounds like a really strong limitation of MULTI_BUS. i2c is necessary for SPD, which is needed to initialize DDR. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/CoreNet: add tool to support pbl image build.
On Jun 12, 2012, at 7:54 PM, Wood Scott-B07421 b07...@freescale.com wrote: You mean to replace this tool? There are other PBL things that may need to be done, such as reconfiguring the SPI speed so it doesn't take forever to read out the rest of the PBL image. My tool builds and RCW image. I could change it so that it also understands the PBL language, but that's not trivial. For now, it would be easy to add a feature to only embed the PBL binary into the RCW binary. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/CoreNet: add tool to support pbl image build.
On Jun 8, 2012, at 6:09 PM, Wood Scott-B07421 b07...@freescale.com wrote: I have two questions: 1. Is there a plan that we submit Timur' tool to open source? I hope so. If not, the RCW will have to be provided directly as a hexdump/binary/etc. Where do you think my compiler should go? 2. If yes, should I combine Timur's tool with my tool or I just tell user They should use Timur's tool to produce the RCW and then use it in my tool? They should be separate, since there are situations where you just want the RCW and not the PBL image loading -- but it should all be an automatic part of the U-Boot bulid process for targets that require it. I can add a parameter or command to embed a pbl image into an rcw binary during the compilation. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment
Scott Wood wrote: Well, as with most of our boards, NOR is the default configuration. Also, there's no NAND support upstream yet. What isn't upstream, besides the muxing hack? Does it need the 4K page hack? There's no NAND support at all. However, I just tried the two SDK patches that add it, and they apply cleanly, so that's an easy fix. I guess we can drop patches #5 and #6, and just use the existing code to support NOR flash. I'll add NAND flash support. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] powerpc/p1022ds: Add sdcard and spi boot support to P1022DS
On Thu, Apr 26, 2012 at 8:57 AM, Dirk Eibach eib...@gdsys.de wrote:
Signed-off-by: Dirk Eibach eib...@gdsys.de
Cc: Timur Tabi ti...@freescale.com
---
Changes in v2:
- add Cc
- split up original patch series
board/freescale/p1022ds/p1022ds.c | 4 ++
board/freescale/p1022ds/tlb.c | 10 ++
boards.cfg | 4 ++
include/configs/P1022DS.h | 63
++---
4 files changed, 76 insertions(+), 5 deletions(-)
diff --git a/board/freescale/p1022ds/p1022ds.c
b/board/freescale/p1022ds/p1022ds.c
index 456d9b0..c4bdbad 100644
--- a/board/freescale/p1022ds/p1022ds.c
+++ b/board/freescale/p1022ds/p1022ds.c
@@ -37,6 +37,10 @@ int board_early_init_f(void)
{
ccsr_gur_t *gur = (void *)CONFIG_SYS_MPC85xx_GUTS_ADDR;
+ /* Reset eLBC_DIU and SPI_eLBC in case we are booting from SD */
+ clrbits_be32(gur-pmuxcr, 0x0060);
+ setbits_be32(gur-pmuxcr, 0x8000);
Please use clrsetbits_be32().
+
/* Set pmuxcr to allow both i2c1 and i2c2 */
setbits_be32(gur-pmuxcr, 0x1000);
diff --git a/board/freescale/p1022ds/tlb.c b/board/freescale/p1022ds/tlb.c
index e620112..1e9969f 100644
--- a/board/freescale/p1022ds/tlb.c
+++ b/board/freescale/p1022ds/tlb.c
@@ -71,6 +71,16 @@ struct fsl_e_tlb_entry tlb_table[] = {
SET_TLB_ENTRY(1, PIXIS_BASE, PIXIS_BASE_PHYS,
MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
0, 7, BOOKE_PAGESZ_4K, 1),
+
+#if defined(CONFIG_SYS_RAMBOOT)
+ SET_TLB_ENTRY(1, CONFIG_SYS_DDR_SDRAM_BASE, CONFIG_SYS_DDR_SDRAM_BASE,
+ MAS3_SX|MAS3_SW|MAS3_SR, 0,
+ 0, 8, BOOKE_PAGESZ_1G, 1),
+ SET_TLB_ENTRY(1, CONFIG_SYS_DDR_SDRAM_BASE + 0x4000,
+ CONFIG_SYS_DDR_SDRAM_BASE + 0x4000,
+ MAS3_SX|MAS3_SW|MAS3_SR, 0,
+ 0, 9, BOOKE_PAGESZ_1G, 1)
+#endif
};
int num_tlb_entries = ARRAY_SIZE(tlb_table);
diff --git a/boards.cfg b/boards.cfg
index 24c5879..8de4235 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -700,6 +700,10 @@ P1021RDB-PC_SDCARD powerpc mpc85xx
p1_p2_rdb_pc freesca
P1021RDB-PC_SPIFLASH powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1021RDB,SPIFLASH
P1022DS powerpc mpc85xx p1022ds
freescale
P1022DS_36BIT powerpc mpc85xx p1022ds
freescale - P1022DS:36BIT
+P1022DS_36BIT_SDCARD powerpc mpc85xx p1022ds
freescale - P1022DS:36BIT,SDCARD
+P1022DS_36BIT_SPIFLASH powerpc mpc85xx p1022ds
freescale - P1022DS:36BIT,SPIFLASH
+P1022DS_SDCARD powerpc mpc85xx p1022ds
freescale - P1022DS:SDCARD
+P1022DS_SPIFLASH powerpc mpc85xx p1022ds
freescale - P1022DS:SPIFLASH
P1023RDS powerpc mpc85xx p1023rds
freescale - P1023RDS
P1023RDS_NAND powerpc mpc85xx p1023rds
freescale - P1023RDS:NAND
P1024RDB powerpc mpc85xx p1_p2_rdb_pc
freescale - p1_p2_rdb_pc:P1024RDB
diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h
index 70d751d..73a56a6 100644
--- a/include/configs/P1022DS.h
+++ b/include/configs/P1022DS.h
@@ -26,6 +26,18 @@
#define CONFIG_P1022DS
#define CONFIG_MP /* support multiple processors */
+#ifdef CONFIG_SDCARD
+#define CONFIG_RAMBOOT_SDCARD 1
+#define CONFIG_SYS_TEXT_BASE 0x1100
+#define CONFIG_RESET_VECTOR_ADDRESS 0x1107fffc
+#endif
+
+#ifdef CONFIG_SPIFLASH
+#define CONFIG_RAMBOOT_SPIFLASH 1
+#define CONFIG_SYS_TEXT_BASE 0x1100
+#define CONFIG_RESET_VECTOR_ADDRESS 0x1107fffc
+#endif
+
#ifndef CONFIG_SYS_TEXT_BASE
#define CONFIG_SYS_TEXT_BASE 0xeff8
#endif
@@ -52,8 +64,14 @@
#define CONFIG_FSL_LAW /* Use common FSL init code */
+#if 0
+#define CONFIG_SYS_CLK_FREQ 9000 /* get_board_sys_clk() */
+#define CONFIG_DDR_CLK_FREQ 9000 /* get_board_ddr_clk() */
+#else
Why add these lines?
#define CONFIG_SYS_CLK_FREQ get_board_sys_clk()
#define CONFIG_DDR_CLK_FREQ get_board_ddr_clk()
+#endif
+
#define CONFIG_ICS307_REFCLK_HZ 3000 /* ICS307 clock chip ref
freq */
/*
@@ -138,6 +156,14 @@
#define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_TEXT_BASE /*
start of monitor */
+#if defined(CONFIG_RAMBOOT_NAND) || defined(CONFIG_RAMBOOT_SDCARD) || \
+ defined(CONFIG_RAMBOOT_SPIFLASH)
+#define CONFIG_SYS_RAMBOOT
+#define CONFIG_SYS_EXTRA_ENV_RELOC
+#else
+#undef CONFIG_SYS_RAMBOOT
Re: [U-Boot] [PATCH] powerpc/83xx: increment malloc heap size for the MPC832x MDS boards
On Sat, Mar 17, 2012 at 6:19 PM, Wolfgang Denk w...@denx.de wrote: Doubling it is kind of aggressive strategy. You know exactly how much free room needs to be guaranteed, so why don't you auto-adjust the size? -#define CONFIG_SYS_MALLOC_LEN (128 * 1024) /* Reserved for malloc */ +#define CONFIG_SYS_MALLOC_LEN (256 * 1024) /* Reserved for malloc */ How about: #define CONFIG_SYS_MALLOC_LEN (128 * 1024 + CONFIG_ENV_SECT_SIZE) That's the same thing. CONFIG_ENV_SECT_SIZE is 128KB. Plus, as you realized, this will not work if CONFIG_SYS_RAMBOOT is defined. Yes, your board config file is kind of broken and will need more cleanup to facilitate this, but that should be done anyway. Well, I have no desire to do that. I'm just fixing one bug. A major cleanup of the board file is not on my to-do list. Why exactly don't you support NOR flash for RAM-booting configurations? I have no idea. I just noticed this one bug. I don't support the board. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] PowerPC: enable the SATA for p1/p2 rdb-pc platform
On Fri, Mar 9, 2012 at 1:54 AM, chang-ming.hu...@freescale.com wrote: -#define CONFIG_SATA_SIL3114 +#define CONFIG_SATA_SIL This is not enabling SATA. This is choosing the correct driver. You can only use the word enable if the feature was intentionally disabled before, e.g. because the driver did not exist yet. Your patch description is fine. The subject line, however, is wrong. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH][v2]powerpc/8xxx:Add MPH controller support in USB device-tree fixup
On Mon, Feb 6, 2012 at 11:17 PM, Ramneek Mehresh
ramneek.mehr...@freescale.com wrote:
+ start_offset, compat_mph);
if (node_offset 0) {
- printf(WARNING: could not find compatible node %s: %s.\n,
- compat, fdt_strerror(node_offset));
- return -1;
- }
+ node_offset = fdt_node_offset_by_compatible(blob,
+ start_offset, compat_dr);
+ if (node_offset 0) {
+ printf(WARNING: could not find compatible
+ node %s or %s: %s.\n, compat_mph,
+ compat_dr, fdt_strerror(node_offset));
+ return -1;
+ } else
+ node_type = (char *)compat_dr;
+ } else
+ node_type = (char *)compat_mph;
If you make node_type into a const char *, can you remove these typecasts?
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] i2c: add i2c_core and prepare for new multibus support
On Tue, Jan 17, 2012 at 1:12 AM, Simon Glass s...@chromium.org wrote:
From: Heiko Schocher h...@denx.de
This Patch introduce the new i2c_core file, which holds
the I2C core functions, for the rework of the multibus/
multiadapter support.
Also adds changes in i2c.h for the new I2C multibus/multiadapter
support. This new support can be activated with the
CONFIG_SYS_I2C define.
Signed-off-by: Heiko Schocher h...@denx.de
Signed-off-by: Simon Glass s...@chromium.org
---
arch/arm/include/asm/global_data.h | 3 +
arch/avr32/include/asm/global_data.h | 3 +
arch/blackfin/include/asm/global_data.h | 4 +-
arch/m68k/include/asm/global_data.h | 3 +
arch/microblaze/include/asm/global_data.h | 3 +
arch/mips/include/asm/global_data.h | 3 +
arch/nios2/include/asm/global_data.h | 3 +
arch/powerpc/include/asm/global_data.h | 3 +
arch/sh/include/asm/global_data.h | 3 +
arch/sparc/include/asm/global_data.h | 3 +
arch/x86/include/asm/global_data.h | 3 +
drivers/i2c/Makefile | 1 +
drivers/i2c/i2c_core.c | 360
+
include/i2c.h | 199 +++-
14 files changed, 584 insertions(+), 10 deletions(-)
create mode 100644 drivers/i2c/i2c_core.c
diff --git a/arch/arm/include/asm/global_data.h
b/arch/arm/include/asm/global_data.h
index 23a6077..924cea2 100644
--- a/arch/arm/include/asm/global_data.h
+++ b/arch/arm/include/asm/global_data.h
@@ -87,6 +87,9 @@ typedef struct global_data {
unsigned long post_log_res; /* success of POST test */
unsigned long post_init_f_time; /* When post_init_f started */
#endif
+#if defined(CONFIG_SYS_I2C)
+ void *cur_adap; /* current used i2c adapter */
+#endif
I was really hoping we could get rid of the concept of a current i2c
adapter, and just force all drivers to specify the I2C adapter they
want to use for a given I2C operation. That's how Linux operates, and
it will prevent stuff like this:
void *old;
void *new;
old = get_current_i2c_adapter();
set_i2c_adapter(new);
// do I2C stuff
set_i2c_adapter(old);
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] please pull u-boot-mpc85xx
On Thu, Jan 12, 2012 at 5:49 PM, Tabi Timur-B04825 b04...@freescale.com wrote: Are you going to make another pull request before the window closes? The reason I ask is that you're missing some of my patches. http://patchwork.ozlabs.org/project/uboot/list/?submitter=timur -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/8] powerpc/env: Correct the compilation errors when defined CONFIG_ENV_IS_NOWHERE
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang gang@freescale.com wrote: There will be a confict if defined CONFIG_ENV_IS_NOWHERE and CONFIG_ENV_IS_IN_FLASH. This doesn't make any sense. How can the environment be nowhere *and* also in flash, at the same time? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/8] powerpc/boot: Slave module for boot from SRIO
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang gang@freescale.com wrote: +#define CONFIG_SYS_QE_FMAN_FW_IN_REMOTE +#define CONFIG_SYS_QE_FMAN_FW_ADDR 0 Where is CONFIG_SYS_QE_FMAN_FW_IN_REMOTE documented? And where is the code that uses it? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/8] powerpc/boot: Slave uploads ucode when boot from SRIO
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang gang@freescale.com wrote: When boot from SRIO, slave's ucode can be stored in master's memory space, then slave can fetch the ucode image through SRIO interface. What kind of ucode is this? Fman or QE? + + /* configure inbound window for slave's ucode */ + printf(SRIOBOOT - MASTER: Inbound window for slave's ucode; + Local = 0x%llx, Srio = 0x%llx, Size = 0x%x\n, + (u64)CONFIG_SRIOBOOT_SLAVE_UCODE_LAW_PHYS, + (u64)CONFIG_SRIOBOOT_SLAVE_UCODE_SRIO_PHYS, + CONFIG_SRIOBOOT_SLAVE_UCODE_SIZE); + out_be32((u32)srio-riwtar3 + CONFIG_SRIOBOOT_MASTER_PORT * 0x200, These should be (void *) instead of (u32). -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/8] powerpc/boot: Slave module for boot from SRIO
Liu Gang-B34182 wrote: Where is CONFIG_SYS_QE_FMAN_FW_IN_REMOTE documented? And where is the code that uses it? [Liu Gang-B34182] Sorry I documented this definition in [PATCH 6/8] powerpc/boot: Slave uploads ucode when boot from SRIO, You need to update the README. That's where all the other CONFIG_SYS_QE_FMAN_FW_xxx macros are documented. I'll add descriptions about this definition in PATCH 5/8. The function fm_init_common in the file drivers/net/fm/fm.c uses the CONFIG_SYS_QE_FMAN_FW_IN_REMOTE. The code which adds CONFIG_SYS_QE_FMAN_FW_IN_REMOTE support should be its own patch. And the patch summary should say CONFIG_SYS_QE_FMAN_FW_IN_REMOTE. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/bootm: Flush ramdisk and device tree image when booting on MP
On Wed, Dec 7, 2011 at 8:42 AM, Kumar Gala ga...@kernel.crashing.org wrote:
+ if (flag BOOTM_STATE_OS_PREP) {
+ boot_prep_linux(images);
return 0;
+ }
if (flag BOOTM_STATE_OS_GO) {
boot_jump_linux(images);
return 0;
}
+ boot_prep_linux(images);
Why are we calling boot_prep_linux(images) when flag
BOOTM_STATE_OS_PREP is zero? If we don't want the OS to be PREPped,
then why call a function named boot_prep_linux()?
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/p3060qds: Add board related support for P3060QDS platform
On Tue, Nov 22, 2011 at 2:51 AM, Shengzhou Liu shengzhou@freescale.com wrote: +#ifdef CONFIG_PHYS_64BIT + puts(36-bit Addressing\n); +#endif We're not doing this any more. The 'bdinfo' command will be updated to display this information instead. Since Kumar already applied this patch, please post a follow-up patch that removes these three lines. Thank you. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: clean up and document the QE/FMAN microcode macros
Kumar Gala wrote: #ifdef CONFIG_QE /* QE microcode/firmware address */ -#define CONFIG_SYS_QE_FW_ADDR0xefec -#define CONFIG_SYS_QE_FW_LENGTH 0x1 +#define CONFIG_SYS_QE_FMAN_FW_IN_NOR +#define CONFIG_SYS_QE_FMAN_FW_ADDR 0xefec +#define CONFIG_SYS_QE_FMAN_FW_LENGTH 0x1 this is wrong, there is no FMAN on this device. Macros that have QE_FMAN are used for QE and Fman. Does this device have a QE? Keep in mind that I'm just cleaning up existing usage. I'm not adding any functionality to any board. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] mpc83xx: Implement interrupt support for mpc83xx
On Wed, Oct 5, 2011 at 6:14 PM, Joe Hershberger joe.hershber...@ni.com wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Kim Phillips kim.phill...@freescale.com --- Where's the patch description? You need to explain how this patch works. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/5] e1000: Export core EEPROM access functions for SPI support
On Tue, Oct 18, 2011 at 4:05 PM, Kyle Moffett kyle.d.moff...@boeing.com wrote:
A followup patch will be adding a configurable feature to enable
programming of E1000 EEPROMs from the command line or via the generic
U-Boot SPI interface.
In order for it to work it needs access to certain E1000-internal
functions, so export those in the e1000.h header file.
Signed-off-by: Kyle Moffett kyle.d.moff...@boeing.com
Cc: Ben Warren biggerbadder...@gmail.com
This patches causes a ton of build warnings:
/home/b04825/vslick/bin/vsbuild -signal 39610 -command make -s -j 3
O=1022 syncp 1022/u-boot.bin /tftpboot/timur/1022/
VSLICKERRORPATH=/home/b04825/git/u-boot.jerry
make -s -j 3 O=1022
Generating /home/b04825/git/u-boot.jerry/1022/include/generated/asm-offsets.h
e1000.c: In function 'e1000_raise_ee_clk':
e1000.c:155:2: warning: unused variable 'x'
e1000.c: In function 'e1000_lower_ee_clk':
e1000.c:172:2: warning: unused variable 'x'
e1000.c: In function 'e1000_shift_out_ee_bits':
e1000.c:208:3: warning: unused variable 'x'
e1000.c: In function 'e1000_standby_eeprom':
e1000.c:279:3: warning: unused variable 'x'
e1000.c:285:3: warning: unused variable 'x'
e1000.c:291:3: warning: unused variable 'x'
e1000.c:297:3: warning: unused variable 'x'
e1000.c:303:3: warning: unused variable 'x'
e1000.c:307:3: warning: unused variable 'x'
e1000.c: In function 'e1000_release_eeprom':
e1000.c:689:3: warning: unused variable 'x'
e1000.c:695:3: warning: unused variable 'x'
e1000.c: In function 'e1000_reset_hw':
e1000.c:1401:2: warning: unused variable 'x'
e1000.c:1428:3: warning: unused variable 'x'
e1000.c: In function 'e1000_init_hw':
e1000.c:1635:3: warning: unused variable 'x'
e1000.c:1647:3: warning: unused variable 'x'
e1000.c:1661:3: warning: unused variable 'x'
e1000.c: In function 'e1000_setup_fiber_link':
e1000.c:2029:2: warning: unused variable 'x'
e1000.c: In function 'e1000_config_collision_dist':
e1000.c:3235:2: warning: unused variable 'x'
e1000.c: In function 'e1000_raise_mdi_clk':
e1000.c:3960:2: warning: unused variable 'x'
e1000.c: In function 'e1000_lower_mdi_clk':
e1000.c:3977:2: warning: unused variable 'x'
e1000.c: In function 'e1000_shift_out_mdi_bits':
e1000.c:4020:3: warning: unused variable 'x'
e1000.c: In function 'e1000_shift_in_mdi_bits':
e1000.c:4059:2: warning: unused variable 'x'
e1000.c: In function 'e1000_phy_hw_reset':
e1000.c:4341:3: warning: unused variable 'x'
e1000.c:4349:3: warning: unused variable 'x'
e1000.c:4362:3: warning: unused variable 'x'
e1000.c:4366:3: warning: unused variable 'x'
e1000.c: In function 'e1000_configure_rx':
e1000.c:4991:3: warning: unused variable 'x'
e1000.c: In function 'e1000_transmit':
e1000.c:5049:2: warning: unused variable 'x'
e1000.c: In function 'e1000_initialize':
e1000.c:869:14: warning: 'checksum' may be used uninitialized in this function
The problem is this macro:
#define E1000_WRITE_FLUSH(a) \
do { uint32_t x = E1000_READ_REG(a, STATUS); } while (0)
The 'x' is never used.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] MPC8360EMDS: 512MB DDR and 33.33MHz oscillator support
On Tue, Nov 1, 2011 at 9:08 PM, Huang Changming-R66093 r66...@freescale.com wrote: Kim, Since 2008, the boards shipped to customer are the new boards with 33.33MHz oscillator and 512MB DDR. How can I deal with the new board and old board? Check the board revision at runtime. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Powerpc/DIU: Fixed the 800x600 and 1024x768 resolution bug
On Mon, Oct 31, 2011 at 1:19 AM, chang-ming.hu...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com When the resolution is set to 800x600 and 1024x768, but, the driver will use 1280x1024 resolution to set the DIU register Signed-off-by: Jerry Huang chang-ming.hu...@freescale.com Acked-by: Timur Tabi ti...@freescale.com Thanks, Jerry. I'm amazed that I didn't notice this mistake earlier. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] miiphy: Note that miiphy_* API is deprecated
On Mon, Oct 31, 2011 at 9:46 AM, Andy Fleming aflem...@freescale.com wrote: We want to move everything to phylib, and we definitely don't want new drivers using the miiphy infrastructure. How about using gcc's deprecated function feature? Or is that too aggressive? http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd_bdinfo: simplify local static funcs a bit
On Sun, Oct 30, 2011 at 7:54 PM, Mike Frysinger vap...@gentoo.org wrote:
-static void print_num(const char *, ulong);
+__maybe_unused
+static void print_num(const char *name, ulong value)
+{
+ printf(%-12s= 0x%08lX\n, name, value);
+}
Will the linker remove the functions from the binary if they are unusued?
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] [v2] powerpc/85xx: wait for alignment before resetting SERDES RX lanes (SERDES9)
Kumar Gala wrote: Rather than looking at tn2020_driver.uid lets just do something like: if ((phydev-drv-uid phydev-drv-mask) == TN2020_UID) And add a #define in phy.h: #define TN2020_UID0x00a19410 I guess that makes more sense. I thought my original version was cooler, though. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] [v2] powerpc/85xx: don't display address map size (32-bit vs. 36-bit) during boot
Kumar Gala wrote: For the FSL boards, lets add 'bdinfo' to 'preboot' and enable CONFIG_PREBOOT I don't think that's a good idea. bdinfo display about a dozen lines of text, most of it is not generally useful. Plus, this would make preboot unavailable for everyone else. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request u-boot-85xx.git
On Fri, Oct 14, 2011 at 2:34 AM, Kumar Gala ga...@kernel.crashing.org wrote: The following changes since commit d8fffa057c9430fd0c5104ab6ff7db4cdb03db51: Merge branch 'master' of git://git.denx.de/u-boot-mips (2011-10-12 22:47:15 +0200) are available in the git repository at: git://git.denx.de/u-boot-mpc85xx master Can you pick up this patch, as well: http://patchwork.ozlabs.org/patch/109631/ It fixes a real bug. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v4] powerpc/eeprom: cleanup mac command
On Fri, Oct 14, 2011 at 4:32 PM, Wolfgang Denk w...@denx.de wrote: These changes silently change the behaviour of the command. So far, an argument line 24 would be parsed as hex number (i. e. result in decimal value 36); with this change it suddenly becomes devcimal 24, which is quite unexpected. Support for numbers larger than 9 is new, so very few people would be affected. There are very few exceptions wher eU-Boot uses and expects decimal numbers, and I strongly recommend not to add any new such inconsistencies. I understand, except that in this case, it's counter-intuitive. No one is going to think to do this: mac ports b to set the number of ports to 11, but that's what you have to do. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] powerpc/p3060qds: Add board related support for P3060QDS platform
On Thu, Oct 6, 2011 at 4:23 PM, Wolfgang Denk w...@denx.de wrote:
Checkpatch says:
WARNING: static const char * array should probably be static const
char * const
#1511: FILE: board/freescale/p3060qds/p3060qds.c:84:
+ static const char *freq[] = {100, 125, Reserved,
Please clean up and resubmit. Thanks.
I also get this when I apply the patch:
Applying: powerpc/p3060qds: Add board related support for P3060QDS platform
/home/b04825/git/u-boot.28/.git/rebase-apply/patch:1622: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function
On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic sba...@denx.de wrote: New default, weak i2c_set_bus_num() function. Signed-off-by: Stefano Babic sba...@denx.de Cc: Heiko Schocher h...@denx.de I would prefer to see a new set of I2C functions that take a bus number as a parameter, so that we can eliminate i2c_set_bus_num() (and the global variable it modifies) altogether. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] powerpc/mpc8548cds: Update config file
On Sun, Oct 9, 2011 at 5:55 PM, Kumar Gala ga...@kernel.crashing.org wrote: - Increase the size of malloc space. - Enable e1000 network card. - Show pci devices on startup. - Change the location of env address. - Use hwconfig to turn off ECC by default. This patch is missing all of the explanations that were provided by the developer on the internal mailing list. In particular, Wolfgang previously stated that he did not want CONFIG_PCI_SCAN_SHOW enabled by default. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] powerpc/mpc8548cds: Update config file
Kumar Gala wrote: * The only things not explained is the env address change. I can see it matches our other boards MPC8572DS, etc. So not exactly critical to me. There's no explanation for increasing the malloc size. * If Wolfgang wants to remove CONFIG_PCI_SCAN_SHOW so be it, but as long as it exists I think its the board maintainers purview if they want it enabled. Seriously? I've lost count the number of times I've been bitch-slapped by Wolfgang for adding a board-specific patch that he didn't like. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 8/9 v2] powerpc/mpc8548cds: Fix config according to system address map
On Sat, Oct 8, 2011 at 2:33 AM, Zhao Chenhui chenhui.z...@freescale.com wrote: - Fix config according to system address map in the manual. - Rework tlb and law tables. - Remove unnecessary macros. You're making a lot of changes here. The device tree needs to match the U-Boot configuration. Are you changing U-Boot to match the device tree, or will this patch break Linux because the device tree no longer matches? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: fix null pointer dereference when initializing the SGMII TBI PHY
Kumar Gala wrote: Note: I'm not sure of my change to struct fm_mdio. It works, but it doesn't smell right. What exactly is the concern? Nothing specific, just a gut feeling. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/mpc8xxx: Fix ddr build error
On Mon, Oct 3, 2011 at 6:59 PM, Becky Bruce bec...@kernel.crashing.org wrote:
-#ifdef DEBUG
const char *step_string_tbl[] = {
STEP_GET_SPD,
STEP_COMPUTE_DIMM_PARMS,
@@ -153,7 +152,6 @@ const char * step_to_string(unsigned int step) {
return step_string_tbl[s];
}
-#endif
How big is this array? It looks like it's going to add a bunch of
data to the u-boot image that will typically never be used, since
DEBUG is usually not defined.
There should be an easy way to keep this array defined only when DEBUG
is defined.
--
1.5.6.5
Your version of git is outdated, BTW.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request u-boot-85xx.git (master)
On Mon, Oct 3, 2011 at 9:44 AM, Kumar Gala ga...@kernel.crashing.org wrote: Timur Tabi (4): powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros powerpc/85xx: relocate CCSR before creating the initial RAM area powerpc/mp: add support for discontiguous cores powerpc/hydra: Add ethernet support on P5020/P3041 DS boards How about these: http://patchwork.ozlabs.org/patch/115647/ http://patchwork.ozlabs.org/patch/113570/ http://patchwork.ozlabs.org/patch/113569/ -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file
On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui chenhui.z...@freescale.com wrote: From: chenhui zhao chenhui.z...@freescale.com -Increase the size of malloc space. -Enable e1000 network card. -Change the location of env address. -Use hwconfig to turn off ECC. Please repost this patch with a detailed explanation as to why these changes are being made. Why do you need more malloc space? Why enable only the E1000 card? What's wrong with the current environment address? And why does the default hwconfig need to turn off ECC? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/9] powerpc/mpc85xxcds: Fix PCI speed
On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui chenhui.z...@freescale.com wrote: @@ -222,8 +222,8 @@ int checkboard (void) printf(PCI1: %d bit, %s MHz, %s\n, (pci1_32) ? 32 : 64, - (pci1_speed == 3300) ? 33 : - (pci1_speed == 6600) ? 66 : unknown, + (pci1_speed == ) ? 33 : + (pci1_speed == ) ? 66 : unknown, I already told you on the internal mailing list to fix this, because it can never say unknown. pci1_speed will always equal either or . There is no way it can be set to anything else. And Wolfgang is right -- this patch doesn't make any sense. Is the problem that pci1_speed is wrong, or is the problem that it's displaying the wrong value? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] powerpc/85xx: standardize display of address map size (32-bit vs. 36-bit)
Kumar Gala wrote: 1. We reduce the amount printed in the default case 2. First choice should always be to have a command the print status info 3. Allow a board port to makes its own decision if it wants to do something like enable CONFIG_PCI_SCAN_SHOW Any concerns w/that proposal? Are you talking about my patch, or about CONFIG_PCI_SCAN_SHOW? The reason I like my patch as-is is because it completely eliminates the board from the decision. It's only one line, and it's CONSISTENT. That's the key part. We have not been consistent about this, and it seems silly for each board to implement the same feature. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Enable CMD_REGINFO on corenet boards
Kumar Gala wrote: On Aug 31, 2011, at 12:14 PM, Tabi Timur-B04825 wrote: On Wed, Aug 31, 2011 at 9:16 AM, Kumar Galaga...@kernel.crashing.org wrote: Signed-off-by: Kumar Galaga...@kernel.crashing.org --- Why are we enabling this? because its a useful command that helps w/debugging things from time to time. Please put this in the git description. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] ns16550: change to allow 32 bit access to registers
On Thu, Sep 1, 2011 at 6:40 AM, Dave Aldridge fovs...@gmail.com wrote: #if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE == 0) #error Please define NS16550 registers size. +#elif defined(CONFIG_SYS_NS16550_MEM32) +#define UART_REG(x) unsigned int x; Shouldn't this be #define UART_REG(x) u32 x For one thing, I think you want a sized integer. Secondly, does the semicolon at the end belong there? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Enable CMD_REGINFO on corenet boards
On Wed, Aug 31, 2011 at 9:16 AM, Kumar Gala ga...@kernel.crashing.org wrote: Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- Why are we enabling this? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2 v4] powerpc/p1023rds: Disable nor flash node and enable nand flash node
On Mon, Aug 29, 2011 at 2:15 AM, Chunhe Lan chunhe@freescale.com wrote: In the p1023rds, accessing exclusively nor flash or nand flash device by BR0/OR0. This is not an English sentence. I do not understand what you're saying. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] gcc-4.6 warnings
On Thu, Aug 25, 2011 at 9:51 AM, Mike Frysinger vap...@gentoo.org wrote: i feel like some (many?) #ifdef's in the tree could be done without ifdefs (by relying on gcc's DCE) thus improving overall code quality What's DCE? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] README: clean up and document the Freescale QE/FMAN firmware macros
On Mon, Aug 22, 2011 at 4:45 PM, Timur Tabi ti...@freescale.com wrote: The Freescale QE and FMAN devices support uploading of firmware, and U-Boot can locate that firmware on different types of storage media. However, the current macros used for this code are inconsistent and poorly documented. Note that some of the code managed by these macros have not yet been posted externally. Such code will be posted, but properly documenting the macros is the first step. Wolfgang, if you're okay with the text in this patch, I will go ahead and make the corresponding changes to the code. I just want to make sure that there are no objections to these definitions before I work on the code itself. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] fdt: Add a fdt_set_node_status function
On Thu, Aug 11, 2011 at 11:18 PM, Chunhe Lan chunhe@freescale.com wrote:
+/*
+ * Sets the specified node's status to the value contained in status.
+ * If the first character of the specified path is / then we use
+ * alias as a path. Otherwise, we look for an alias of that name.
+ */
+void fdt_set_node_status(void *fdt, const char *alias, const char *status)
+{
+ const char *path = fdt_get_alias(fdt, alias);
+
+ if (!path)
+ path = alias;
+
+ do_fixup_by_path(fdt, path, status, status, strlen(status) + 1, 1);
+}
If you're going to take some internal code and post it upstream, you
should at least use the latest version of that code. The latest
version of this function has this comment:
/*
* Given an alias or a path for a node, set the status of that node.
*
* If 'alias' is not a valid alias, then it is treated as a full path to the
* node. No error checking is performed.
*
* This function is normally called to set the status for a virtual MDIO node.
*/
However, since you're moving this function to fdt_support, the last
sentence should be dropped.
+++ b/include/fdt_support.h
@@ -2,6 +2,8 @@
* (C) Copyright 2007
* Gerald Van Baren, Custom IDEAS, vanba...@cideas.com
*
+ * Copyright (C) 2011 Freescale Semiconductor, Inc.
+ *
Like Scott said, adding a single function prototype is not sufficient
for a new copyright claim. You have to add a significant amount of
original code in order to add a new copyright line.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command
York Sun wrote: - e.mac_count = simple_strtoul(argv[2], NULL, 16); + e.mac_count = simple_strtoul(argv[2], NULL, 10); You forgot the MAC address index. There's another use of strtoul in the code that needs to be fixed. Also, if you use 0 instead of 10, then it should be able to handle hex as well, just in case someone wants to use it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command
I see two calls to simple_stroul, and both have 16 in them. -- Timur Tabi Linux kernel developer at Freescale From: sun york-R58495 Sent: Thursday, August 11, 2011 10:03 AM To: Tabi Timur-B04825 Cc: u-boot@lists.denx.de Subject: Re: [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command On Thu, 2011-08-11 at 09:55 -0500, Tabi Timur-B04825 wrote: York Sun wrote: - e.mac_count = simple_strtoul(argv[2], NULL, 16); + e.mac_count = simple_strtoul(argv[2], NULL, 10); You forgot the MAC address index. There's another use of strtoul in the code that needs to be fixed. I didn't forget the index. It is base 10 already. Also, if you use 0 instead of 10, then it should be able to handle hex as well, just in case someone wants to use it. That's not a bad idea. I will change to 0 but leave the mac address as hex. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command
York Sun wrote: Change the help message to be more helpful. Print argument format. Fix MAX_NUM_PORTS to comply with v1 NXID format. Signed-off-by: York Sunyork...@freescale.com Could you also fix the commands so that they take a number in decimal instead of hex? e.mac[index][i] = simple_strtoul(p, p, 16); ... e.mac_count = simple_strtoul(argv[2], NULL, 16); I know U-Boot uses hex for everything, but it doesn't make sense for this command. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [PATCH 7/7] powerpc/8xxx: Add support for interactive DDR programming interface
York Sun wrote:
+/* Option parameter Structures */
+typedef struct {
+ const char *option_name;
+ size_t offset;
+ unsigned int size;
+ const char printHex;
+} options_strings_t;
Does it make sense for only printHex (which should be print_hex) and
option_name to be const, but nothing else?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] [v3] powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros
Kumar Gala wrote: Why didn't we do in include/mpc85xx.h: #ifndef CONFIG_SYS_CCSRBAR_PHYS_LOW #define CONFIG_SYS_CCSRBAR_PHYS_LOW CONFIG_SYS_CCSRBAR #endif Thus removing that line from every board file? That might make more sense, but that will break other boards where virtual != physical but CCSR is not relocated, which means another round of testing. MAKEALL takes a long time to run. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] [v3] powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros
Kumar Gala wrote: ok. Sounds fine to leave as it, just wondering. Also, I want people to specifically set the physical address in the board header file if they want to relocate CCSR. Anyway, I'll post a new version that reduces the merge conflicts. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] [v2] powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros
Kumar Gala wrote: What changed in v2? I fixed the problem on several boards where I wasn't setting the relocated physical address properly. For instance, on the P2020DS, the original code moved CCSR from ff7 to ffe, but my v1 patch left it at ff7 because I didn't notice that the device tree was expecting it at ffe. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Add support for new P102x/P2020 RDB style boards
On Tue, Jul 26, 2011 at 9:52 PM, Kumar Gala ga...@kernel.crashing.org wrote: +/* CCSRBAR PHYSICAL Address */ +/* IN case of NAND bootloader relocate CCSRBAR in RAMboot code not in the 4k + SPL code*/ +#if defined(CONFIG_NAND_U_BOOT) defined(CONFIG_NAND_SPL) +#define CONFIG_SYS_CCSRBAR_PHYS CONFIG_SYS_CCSRBAR_DEFAULT +#else +#ifdef CONFIG_PHYS_64BIT +#define CONFIG_SYS_CCSRBAR_PHYS 0xfffe0ull +#else +#define CONFIG_SYS_CCSRBAR_PHYS CONFIG_SYS_CCSRBAR /* physical addr of */ + /* CCSRBAR */ +#endif +#endif +#define CONFIG_SYS_IMMR CONFIG_SYS_CCSRBAR /* PQII uses */ + /* CONFIG_SYS_IMMR */ This conflicts with the CCSR patch I posted a couple days ago. What order are you going to be applying these patches? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT pull] Please pull u-boot-mpc85xx
On Fri, Jul 22, 2011 at 2:55 AM, Kumar Gala ga...@kernel.crashing.org wrote: The following changes since commit 74fac70084bb040342fafc3b0d2ef50fbe35646f: Merge branch 'master' of git://git.denx.de/u-boot-mmc (2011-07-19 22:27:07 +0200) are available in the git repository at: git://git.denx.de/u-boot-mpc85xx.git master What about this patch: http://patchwork.ozlabs.org/patch/93875/ -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Author search of git.denx.de does not work
The following URL doesn't show anything: http://git.denx.de/?p=u-boot.gita=searchh=HEADst=authors=Timur+Tabi No matter what I put after the s=, I get nothing. I think it should work, because this URL, which has the same search string, does work: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.gita=searchh=HEADst=authors=Timur+Tabi -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] powerpc/85xx: Fix the work-arounds for errata SERDES-8 SERDES-A001 on p4080
Kumar Gala wrote: Erratum SERDES-8 says that the clocks for bank 3 needs to be enabled if bank 2 is enabled, but this was not being done for SERDES protocols 0xF and 0x10. The bank reset that was being done for erratum SERDES4 (a left-over work-around that was removed in powerpc/85xx: remove SERDES4 soft-reset work-around) also happened to enable bank 3 (apparently an undocumented feature). Now that the reset has been removed, bank 3 was not being enabled for these two SERDES protocols. Kumar, these two patches should be merged, since the first one breaks SERDES, and this one fixes the problem that the first one exposes. If you add them as separate commits, then you'll break git-bisect. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] powerpc/85xx: Fix the work-arounds for errata SERDES-8 SERDES-A001 on p4080
Kumar Gala wrote: Ok, Can you send a commit message for when I merge them or repost a merged patch. powerpc/85xx: remove SERDES4 soft-reset work-around Some P4080 rev1 errata work-arounds, notably erratum SERDES4, required a bank soft-reset after the bank was configured and enabled, even though enabling a bank causes it to reset. Because the reset was required for multiple errata, it was not properly enclosed in an #ifdef, and so was not removed with all the other rev1 errata work-arounds. Erratum SERDES-8 says that the clocks for bank 3 needs to be enabled if bank 2 is enabled, but this was not being done for SERDES protocols 0xF and 0x10. The bank reset also happened to enable bank 3 (apparently an undocumented feature). Simply removing the reset breaks these two protocols. It turns out that every time we call enable_bank(), we do want at least one lane of the bank enabled, either because the bank is supposed to be enabled, or because we need the clock from that bank enabled. For erratum SERDES-A001, we don't want to modify srds_lpd_b[] when we call enable_bank(), because that array is used elsewhere to determine if the bank is available. Note that the side effect of these changes is that the work-arounds for these two errata are now linked. Specifically, if SERDES-A001 is enabled, then we need SERDES-8 enabled as well. Because this was the only SERDES bank soft-reset, there is no need to implement a work-around for erratum SERDES-A003. Also fix an off-by-one error in a printf(). -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please update libfdt for U-Boot
Jerry, Now that the merge window is open, could you please update libfdt? The version in U-Boot hasn't been updated in over a year, and there are new features that I need to have. Specifically, this commit: http://git.jdl.com/gitweb/?p=dtc.git;a=commit;h=d75b33af676d0beac8398651a7f09037555a550b -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [u-boot-release] [PATCH 1/7] powerpc/i2c: introduce CONFIG_I2C_TWR for setting tWR value
York Sun wrote: From: york york...@freescale.com You should fix this so that it includes your full name. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request u-boot-mpc85xx.git
On Mon, May 2, 2011 at 10:00 AM, Kumar Gala ga...@kernel.crashing.org wrote: I thought that was less of an issue because of our use of patchworks. How? Patchwork uses the same subject line as the email. There's still the problem of trying to correlate the actual commit to the entry in patchwork. On the other hand, I don't know of any good way to correct a patch's subject line without having the patch re-submitted to the mailing list. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message
On Mon, May 2, 2011 at 8:51 PM, York Sun york...@freescale.com wrote: - printf(The DIMM max tCKmin is %d ps, + printf(The combined minimum tCKmin is %d ps, doesn't support the MCLK cycle %d ps\n, That still needs some work, IMHO. I think you might need the word which before doesn't. However, even with that, it's not clear what's wrong. Where does the bad value of mclk_ps come from? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address
Mike Frysinger wrote:
so implement this in your board file in misc_init_r or board_eth_init. have
the code do something like:
uchar enetaddr[6];
if (!eth_getenv_enetaddr(ethaddr, enetaddr)) {
/* ... read current MAC out of the driver's registers ... */
eth_setenv_enetaddr(ethaddr, enetaddr);
}
then you dont need ugly config hacks in random drivers
This is a feature that could be applied to the e1000 drivers. The current
situation is a mess. Some drivers ignore the environment, some of them always
use it. This should probably be standardized.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request u-boot-mpc85xx.git (updated)
On Fri, Apr 29, 2011 at 10:34 AM, Kumar Gala ga...@kernel.crashing.org wrote: Timur Tabi (7): powerpc/86xx: remove empty board_early_init_f() powerpc/fsl: add 'pixis_reset dump' command powerpc/85xx: Implement work-around for P4080 erratum SERDES-A005 powerpc/85xx: Display SERDES 8 erratum warning if banks are not disabled powerpc/85xx: Extend SERDES9 erratum work-around to SGMII, SRIO, and AURORA powerpc/85xx: Implement work-around for P4080 erratum SERDES-A001 powerpc/85xx: fix compatible property for the L2 cache node What about this patch: http://patchwork.ozlabs.org/patch/71614/ It was ACK'd by gvb: http://lists.denx.de/pipermail/u-boot/2011-April/089791.html -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [v4] powerpc/85xx: fix compatible property for the L2 cache node
Wolfgang Denk wrote: Why do we need this if at all? tolower() on a digit is a nop, so you can omit the first branch. Because cpu-name looks like one of two ways: 8578 or P4080 In the case of 8578, we want to convert that to mpc8578. In the case of P4080, we want to convert that to p4080. The if is need to determine whether to prepend the mpc. + /* append cache to the string */ + len += sprintf(buf + len, cache) + 1; This is wrong and misleading. This is not an operation on a C string. You do not append (or concatenate) the string cache. You build a specifically structured data set, which is not a C string. So please don't call it a string. Ok. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [v4] powerpc/85xx: fix compatible property for the L2 cache node
Wolfgang Denk wrote: This gets lost in the code. That's why I added the comments: /* MPC, where == 4-digit number */ If you keep the if / else, you have to add braces for the multiline statements. Ok. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request for u-boot-video?
Anatolij Gustschin wrote: it turns out that your patches broke DIU support on mpc5121. I need to fix it first before sending a pull request. I'm planning to work on fixes and hope to resolve the issue this week. Anything I can do to help, please just let me know. We don't have any 5121s here any more. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Bump up the CONFIG_SYS_BOOTM_LEN to 64M on FSL 85xx boards
On Thu, Apr 28, 2011 at 9:55 PM, Kumar Gala ga...@kernel.crashing.org wrote: CONFIG_SYS_BOOTMAPSZ has been 64M on these boards for some time so we should also allow the kernel image to be up to 64M decompressed. This also matches what we pass to the OS based on the ePAPR specification. Is there any e500-based board for which we don't want 64MB? Why not just put this in some common 85xx.h file? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] boot-up time optimization. Where to start?
On Wed, Apr 27, 2011 at 8:39 AM, Simon Schwarz simonschwarz...@googlemail.com wrote: So here is my question: Where do you see the most potential to optimize u-boot? I'm sure many of the timeouts could be optimized. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address
On Sun, Apr 24, 2011 at 6:50 PM, Wolfgang Denk w...@denx.de wrote: And please add documentation for the new CONFIG_PRESERVE_LOCAL_MAC to the README. We have something similar already on Freescale parts, but it does sometimes cause problems. If the environment ethaddr is already set, it is left alone. Otherwise, the MAC address is read from EEPROM. So we could use CONFIG_PRESERVE_LOCAL_MAC to alter this behavior (i.e. always use the EEPROM). However, the current default is already CONFIG_PRESERVE_LOCAL_MAC, so can we change this to something like CONFIG_OVERRIDE_LOCAL_MAC? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request for u-boot-video?
Anatolij, Are you planning on making a pull request for u-boot-video soon? The merge window closed last week, but I have some pending video patches that I would like to see included. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Change timebase divisor to be defined per processor
On Thu, Apr 21, 2011 at 1:59 PM, Kumar Gala ga...@kernel.crashing.org wrote: Introduce new CONFIG_SYS_FSL_TBCLK_DIV on 85xx platforms because different SoCs have different divisor amounts. All the PQ3 parts are /8, the P4080/P4080 is /16, and P2040/P3041/P5020 are /32. Shouldn't there also be a README update to document this option? + unsigned long tbclk_div = CONFIG_SYS_FSL_TBCLK_DIV; + + return (gd-bus_clk + (tbclk_div 1)) / tbclk_div; Why not just: return (gd-bus_clk + (CONFIG_SYS_FSL_TBCLK_DIV / 2)) / CONFIG_SYS_FSL_TBCLK_DIV; -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/4] powerpc/85xx: Implement work-around for P4080 erratum SERDES-A001
Kumar Gala wrote: The work-around is to enable and then disable bank two after bank three is disabled. That should say, after bank three is enabled. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Change timebase divisor to be defined per processor
On Fri, Apr 22, 2011 at 8:26 AM, Kumar Gala ga...@kernel.crashing.org wrote: Shouldn't there also be a README update to document this option? I think its self evident what it is. I have to disagree. Without reading the patch description, it's hard to know what value to choose for this macro. Besides, Wolfgang is already annoyed with the number of CONFIG_ options that are not documented, so I can't imagine he would accept another one. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mpc83xx fdt: do not adjust clock frequency of external UARTs
David Müller (ELSOFT AG) wrote: Just out of curiosity -- do you have an example of a device tree with an external UART? Yes. May I see it? -- Timur Tabi Linux kernel developer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/6] powerpc/85xx: Added DIU configs for P1022DS and fixed LVDS config
Kumar Gala wrote: I'll deal with merge issues, can you ack or provide feedback on this patch My patch, [v3] powerpc: user 'video-mode' environment variable to configure DIU (user should be use) should be applied instead. -- Timur Tabi Linux kernel developer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] powerpc/85xx: Add SHARP LQ084S3LG01 LCD support on P1022DS
Kumar Gala wrote: what about this patch? I missed this one. Unfortunately, it conflicts with my patch. I'll have to rewrite this one to make it work. Plus, there were problems with it. For instance, I'm not crazy about the setenv() calls (I NAK'd an earlier internal version of this patch that had similar calls). I'll take care of it next week. -- Timur Tabi Linux kernel developer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [v4] powerpc: clean up DIU macro definitions for Freescale reference boards
Wolfgang Denk wrote: Software cursor support should be split off into a separate patch. And CONFIG_VIDEO_SW_CURSOR needs to be documented. That feature is already in U-Boot. All I'm doing is adding a #define CONFIG_VIDEO_SW_CURSOR to the header file. I thought it was already documented somewhere. + '0' Output video to the DVI connector + '1' Output video to the LVDS connector + '2' Output video to the Dual-Link LVDS connector Maybe it would be more user-friendly if we used easy to remember names instead of some magic numbers, like dvi, lvds resp. dlvds (or whatever) ? That's already fixed in my follow-up patch that is waiting for Anatolij's ACK. -- Timur Tabi Linux kernel developer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
