Re: [U-Boot] [PATCH v1 6/7] mmc: fsl_esdhc: Add emmc hs200 support
Yinbo,
Priyanka is the maintainer now for NXP platforms.
York
> On Sep 9, 2019, at 20:10, Yinbo Zhu wrote:
>
> Hi York Sun,
>
> Could you help me merge that series patch to uboot upstream tree.
>
> Regards,
> Yinbo Zhu
> Original Message-
> From: Peng Fan
> Sent: 2019年8月28日 9:04
> To: Yinbo Zhu ; York Sun ;
> u-boot@lists.denx.de
> Cc: Jiafei Pan ; Yinbo Zhu ; Xiaobo
> Xie
> Subject: RE: [U-Boot] [PATCH v1 6/7] mmc: fsl_esdhc: Add emmc hs200 support
>
>> Subject: [U-Boot] [PATCH v1 6/7] mmc: fsl_esdhc: Add emmc hs200
>> support
>>
>> Add eMMC hs200 mode support for increasing ls1028/ls1012/lx2160 eMMC
>> work performance, but without tuning procedure which will cause mmc
>> doesn't work. and this should be TODO work.
>>
>> Signed-off-by: Yinbo Zhu
>
> Acked-by: Peng Fan
>
>> ---
>> drivers/mmc/fsl_esdhc.c | 34 +++---
>> include/fsl_esdhc.h | 4
>> 2 files changed, 23 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index
>> 07318472a7..28d2312ef7 100644
>> --- a/drivers/mmc/fsl_esdhc.c
>> +++ b/drivers/mmc/fsl_esdhc.c
>> @@ -395,10 +395,6 @@ static int esdhc_send_cmd_common(struct
>> fsl_esdhc_priv *priv, struct mmc *mmc,
>>esdhc_write32(>cmdarg, cmd->cmdarg);
>>esdhc_write32(>xfertyp, xfertyp);
>>
>> -if ((cmd->cmdidx == MMC_CMD_SEND_TUNING_BLOCK) ||
>> -(cmd->cmdidx == MMC_CMD_SEND_TUNING_BLOCK_HS200))
>> -flags = IRQSTAT_BRR;
>> -
>>/* Wait for the command to complete */
>>start = get_timer(0);
>>while (!(esdhc_read32(>irqstat) & flags)) { @@ -458,12 +454,6
>> @@ static int esdhc_send_cmd_common(struct fsl_esdhc_priv *priv,
>> struct mmc *mmc, #ifdef CONFIG_SYS_FSL_ESDHC_USE_PIO
>>esdhc_pio_read_write(priv, data);
>> #else
>> -flags = DATA_COMPLETE;
>> -if ((cmd->cmdidx == MMC_CMD_SEND_TUNING_BLOCK) ||
>> -(cmd->cmdidx == MMC_CMD_SEND_TUNING_BLOCK_HS200))
>> {
>> -flags = IRQSTAT_BRR;
>> -}
>> -
>>do {
>>irqstat = esdhc_read32(>irqstat);
>>
>> @@ -476,7 +466,7 @@ static int esdhc_send_cmd_common(struct
>> fsl_esdhc_priv *priv, struct mmc *mmc,
>>err = -ECOMM;
>>goto out;
>>}
>> -} while ((irqstat & flags) != flags);
>> +} while ((irqstat & DATA_COMPLETE) != DATA_COMPLETE);
>>
>>/*
>> * Need invalidate the dcache here again to avoid any @@ -517,7
>> +507,9 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, struct
>> +mmc
>> *mmc, uint clock)
>>int div = 1;
>>int pre_div = 2;
>>int ddr_pre_div = mmc->ddr_mode ? 2 : 1;
>> -int sdhc_clk = priv->sdhc_clk;
>> +unsigned int sdhc_clk = priv->sdhc_clk;
>> +u32 time_out;
>> +u32 value;
>>uint clk;
>>
>>if (clock < mmc->cfg->f_min)
>> @@ -538,11 +530,18 @@ static void set_sysctl(struct fsl_esdhc_priv
>> *priv, struct mmc *mmc, uint clock)
>>
>>esdhc_clrsetbits32(>sysctl, SYSCTL_CLOCK_MASK, clk);
>>
>> -udelay(1);
>> +time_out = 20;
>> +value = PRSSTAT_SDSTB;
>> +while (!(esdhc_read32(>prsstat) & value)) {
>> +if (time_out == 0) {
>> +printf("fsl_esdhc: Internal clock never stabilised.\n");
>> +break;
>> +}
>> +time_out--;
>> +mdelay(1);
>> +}
>>
>>esdhc_setbits32(>sysctl, SYSCTL_PEREN | SYSCTL_CKEN);
>> -
>> -priv->clock = clock;
>> }
>>
>> #ifdef CONFIG_FSL_ESDHC_USE_PERIPHERAL_CLK
>> @@ -1024,6 +1023,8 @@ static int fsl_esdhc_probe(struct udevice *dev)
>>return ret;
>>}
>>
>> +mmc_of_parse(dev, >cfg);
>> +
>>mmc = >mmc;
>>mmc->cfg = >cfg;
>>mmc->dev = dev;
>> @@ -1081,6 +1082,9 @@ static const struct dm_mmc_ops fsl_esdhc_ops = {
>>.get_cd= fsl_esdhc_get_cd,
>>.send_cmd= fsl_esdhc_send_cmd,
>>.set_ios= fsl_esdhc_set_ios,
>> +#ifdef MMC_SUPPORTS_TUNING
>> +.execute_tuning = fsl_esdhc_execute_tuning, #endif
>> };
>> #endif
>>
>> diff --git a/include/fsl_esdhc.h b/include/fsl_esdhc.h index
>> 7d7e946ab3..3f496b4cea 100644
&g
Re: [U-Boot] mpc85xx, mpc86xx: device tree model
> @York: Do you work on such an adaption? May we can share efforts? Heiko, I am off software team for the time being. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v2] MAINTAINERS: Change fsl-qoriq, mpc85xx, mpc86xx maintainers
From 19d9e77a6df1f1820f0e8a2bd987849bce14625e Mon Sep 17 00:00:00 2001 From: York Sun Date: Mon, 4 Feb 2019 08:22:58 -0800 Subject: [PATCH v2] MAINTAINERS: Change fsl-qoriq, mpc85xx, mpc86xx maintainers Change maintainers to Prabhakar Kushwaha for fsl-qoriq, mpc85xx and mpc86xx. Signed-off-by: York Sun --- Change log v2: Remove yorksun from architecture aliases. MAINTAINERS | 6 +++--- board/freescale/ls2080a/MAINTAINERS | 3 ++- board/freescale/mpc8536ds/MAINTAINERS | 2 +- board/freescale/mpc8541cds/MAINTAINERS | 2 +- board/freescale/mpc8544ds/MAINTAINERS | 2 +- board/freescale/mpc8548cds/MAINTAINERS | 2 +- board/freescale/mpc8555cds/MAINTAINERS | 2 +- board/freescale/mpc8568mds/MAINTAINERS | 2 +- board/freescale/mpc8569mds/MAINTAINERS | 2 +- board/freescale/mpc8572ds/MAINTAINERS | 2 +- board/freescale/mpc8610hpcd/MAINTAINERS | 2 +- board/freescale/mpc8641hpcn/MAINTAINERS | 2 +- doc/git-mailrc | 10 +- 13 files changed, 20 insertions(+), 19 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 95e9bda09d..e05f4c2868 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -497,7 +497,7 @@ S: Maintained T: git git://git.denx.de/u-boot-freebsd.git FREESCALE QORIQ -M: York Sun +M: Prabhakar Kushwaha S: Maintained T: git git://git.denx.de/u-boot-fsl-qoriq.git @@ -646,13 +646,13 @@ F:arch/powerpc/cpu/mpc83xx/ F: arch/powerpc/include/asm/arch-mpc83xx/ POWERPC MPC85XX -M: York Sun +M: Prabhakar Kushwaha S: Maintained T: git git://git.denx.de/u-boot-mpc85xx.git F: arch/powerpc/cpu/mpc85xx/ POWERPC MPC86XX -M: York Sun +M: Prabhakar Kushwaha S: Maintained T: git git://git.denx.de/u-boot-mpc86xx.git F: arch/powerpc/cpu/mpc86xx/ diff --git a/board/freescale/ls2080a/MAINTAINERS b/board/freescale/ls2080a/MAINTAINERS index de137ef64f..e0e4e3f83e 100644 --- a/board/freescale/ls2080a/MAINTAINERS +++ b/board/freescale/ls2080a/MAINTAINERS @@ -1,5 +1,6 @@ LS2080A BOARD -M: York Sun , Priyanka Jain +M: Prabhakar Kushwaha +M: Priyanka Jain S: Maintained F: board/freescale/ls2080a/ F: include/configs/ls2080a_emu.h diff --git a/board/freescale/mpc8536ds/MAINTAINERS b/board/freescale/mpc8536ds/MAINTAINERS index af221f9cad..d640f89845 100644 --- a/board/freescale/mpc8536ds/MAINTAINERS +++ b/board/freescale/mpc8536ds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8536DS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8536ds/ F: include/configs/MPC8536DS.h diff --git a/board/freescale/mpc8541cds/MAINTAINERS b/board/freescale/mpc8541cds/MAINTAINERS index 1d969f1107..100077608b 100644 --- a/board/freescale/mpc8541cds/MAINTAINERS +++ b/board/freescale/mpc8541cds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8541CDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8541cds/ F: include/configs/MPC8541CDS.h diff --git a/board/freescale/mpc8544ds/MAINTAINERS b/board/freescale/mpc8544ds/MAINTAINERS index 3c6f80e6e3..78019fbfea 100644 --- a/board/freescale/mpc8544ds/MAINTAINERS +++ b/board/freescale/mpc8544ds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8544DS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8544ds/ F: include/configs/MPC8544DS.h diff --git a/board/freescale/mpc8548cds/MAINTAINERS b/board/freescale/mpc8548cds/MAINTAINERS index a99f84bc87..385dc85576 100644 --- a/board/freescale/mpc8548cds/MAINTAINERS +++ b/board/freescale/mpc8548cds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8548CDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8548cds/ F: include/configs/MPC8548CDS.h diff --git a/board/freescale/mpc8555cds/MAINTAINERS b/board/freescale/mpc8555cds/MAINTAINERS index 3be1598c40..815cffec1b 100644 --- a/board/freescale/mpc8555cds/MAINTAINERS +++ b/board/freescale/mpc8555cds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8555CDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8555cds/ F: include/configs/MPC8555CDS.h diff --git a/board/freescale/mpc8568mds/MAINTAINERS b/board/freescale/mpc8568mds/MAINTAINERS index 56c5373c07..79f04d1a90 100644 --- a/board/freescale/mpc8568mds/MAINTAINERS +++ b/board/freescale/mpc8568mds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8568MDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8568mds/ F: include/configs/MPC8568MDS.h diff --git a/board/freescale/mpc8569mds/MAINTAINERS b/board/freescale/mpc8569mds/MAINTAINERS index 49a9361575..b2e3bdfa11 100644 --- a/board/freescale/mpc8569mds/MAINTAINERS +++ b/board/freescale/mpc8569mds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8569MDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8569mds/ F: include/configs/MPC8569MDS.h diff
Re: [U-Boot] [PATCH] MAINTAINERS: Change fsl-qoriq, mpc85xx, mpc86xx maintainers
On 2/4/19 9:02 AM, Tom Rini wrote: > Oh probably me hoping to keep someone who knows something in the loop > prior to Mario stepping up. Thanks again! > NP. I will remove myself but keep afleming unchanged. Replace myself with Prabhakar for powerpc, 85xx and 86xx. I couldn't send email using office365 SMTP service any more. Patch will be sent using Thunderbird client. Please forgive me if the patch is broken. I do my best to disable wrapping and use plain text. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] MAINTAINERS: Change fsl-qoriq, mpc85xx, mpc86xx maintainers
On 2/4/19 8:49 AM, Baruch Siach wrote: > Hi York, > > On Mon, Feb 04, 2019 at 04:44:36PM +0000, York Sun wrote: >> From aae114b0344ee5648f236a26a6d44f8ace547d62 Mon Sep 17 00:00:00 2001 >> From: York Sun >> Date: Mon, 4 Feb 2019 08:22:58 -0800 >> Subject: [PATCH] MAINTAINERS: Change fsl-qoriq, mpc85xx, mpc86xx maintainers >> >> Change maintainers to Prabhakar Kushwaha for fsl-qoriq, mpc85xx >> and mpc86xx. >> >> Signed-off-by: York Sun >> --- > > [...] > >> diff --git a/doc/git-mailrc b/doc/git-mailrc >> index 5d835d4de5..d127b6a41f 100644 >> --- a/doc/git-mailrc >> +++ b/doc/git-mailrc >> @@ -44,7 +44,7 @@ alias smcnuttScott McNutt >> alias stroeseStefan Roese >> alias trini Tom Rini >> alias wd Wolfgang Denk >> -alias yorksunYork Sun >> +alias prabhu_kushPrabhakar Kushwaha > > A few other aliases still refer to 'yorksun', e.g. powerpc, mpc83xx, etc. > That's the part I didn't quite understand. I didn't maintain 83xx. afleming has been away for years. But our names are there. I will update the patch to remote myself. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] MAINTAINERS: Change fsl-qoriq, mpc85xx, mpc86xx maintainers
From aae114b0344ee5648f236a26a6d44f8ace547d62 Mon Sep 17 00:00:00 2001 From: York Sun Date: Mon, 4 Feb 2019 08:22:58 -0800 Subject: [PATCH] MAINTAINERS: Change fsl-qoriq, mpc85xx, mpc86xx maintainers Change maintainers to Prabhakar Kushwaha for fsl-qoriq, mpc85xx and mpc86xx. Signed-off-by: York Sun --- MAINTAINERS | 6 +++--- board/freescale/ls2080a/MAINTAINERS | 3 ++- board/freescale/mpc8536ds/MAINTAINERS | 2 +- board/freescale/mpc8541cds/MAINTAINERS | 2 +- board/freescale/mpc8544ds/MAINTAINERS | 2 +- board/freescale/mpc8548cds/MAINTAINERS | 2 +- board/freescale/mpc8555cds/MAINTAINERS | 2 +- board/freescale/mpc8568mds/MAINTAINERS | 2 +- board/freescale/mpc8569mds/MAINTAINERS | 2 +- board/freescale/mpc8572ds/MAINTAINERS | 2 +- board/freescale/mpc8610hpcd/MAINTAINERS | 2 +- board/freescale/mpc8641hpcn/MAINTAINERS | 2 +- doc/git-mailrc | 2 +- 13 files changed, 16 insertions(+), 15 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 95e9bda09d..e05f4c2868 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -497,7 +497,7 @@ S: Maintained T: git git://git.denx.de/u-boot-freebsd.git FREESCALE QORIQ -M: York Sun +M: Prabhakar Kushwaha S: Maintained T: git git://git.denx.de/u-boot-fsl-qoriq.git @@ -646,13 +646,13 @@ F:arch/powerpc/cpu/mpc83xx/ F: arch/powerpc/include/asm/arch-mpc83xx/ POWERPC MPC85XX -M: York Sun +M: Prabhakar Kushwaha S: Maintained T: git git://git.denx.de/u-boot-mpc85xx.git F: arch/powerpc/cpu/mpc85xx/ POWERPC MPC86XX -M: York Sun +M: Prabhakar Kushwaha S: Maintained T: git git://git.denx.de/u-boot-mpc86xx.git F: arch/powerpc/cpu/mpc86xx/ diff --git a/board/freescale/ls2080a/MAINTAINERS b/board/freescale/ls2080a/MAINTAINERS index de137ef64f..e0e4e3f83e 100644 --- a/board/freescale/ls2080a/MAINTAINERS +++ b/board/freescale/ls2080a/MAINTAINERS @@ -1,5 +1,6 @@ LS2080A BOARD -M: York Sun , Priyanka Jain +M: Prabhakar Kushwaha +M: Priyanka Jain S: Maintained F: board/freescale/ls2080a/ F: include/configs/ls2080a_emu.h diff --git a/board/freescale/mpc8536ds/MAINTAINERS b/board/freescale/mpc8536ds/MAINTAINERS index af221f9cad..d640f89845 100644 --- a/board/freescale/mpc8536ds/MAINTAINERS +++ b/board/freescale/mpc8536ds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8536DS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8536ds/ F: include/configs/MPC8536DS.h diff --git a/board/freescale/mpc8541cds/MAINTAINERS b/board/freescale/mpc8541cds/MAINTAINERS index 1d969f1107..100077608b 100644 --- a/board/freescale/mpc8541cds/MAINTAINERS +++ b/board/freescale/mpc8541cds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8541CDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8541cds/ F: include/configs/MPC8541CDS.h diff --git a/board/freescale/mpc8544ds/MAINTAINERS b/board/freescale/mpc8544ds/MAINTAINERS index 3c6f80e6e3..78019fbfea 100644 --- a/board/freescale/mpc8544ds/MAINTAINERS +++ b/board/freescale/mpc8544ds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8544DS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8544ds/ F: include/configs/MPC8544DS.h diff --git a/board/freescale/mpc8548cds/MAINTAINERS b/board/freescale/mpc8548cds/MAINTAINERS index a99f84bc87..385dc85576 100644 --- a/board/freescale/mpc8548cds/MAINTAINERS +++ b/board/freescale/mpc8548cds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8548CDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8548cds/ F: include/configs/MPC8548CDS.h diff --git a/board/freescale/mpc8555cds/MAINTAINERS b/board/freescale/mpc8555cds/MAINTAINERS index 3be1598c40..815cffec1b 100644 --- a/board/freescale/mpc8555cds/MAINTAINERS +++ b/board/freescale/mpc8555cds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8555CDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8555cds/ F: include/configs/MPC8555CDS.h diff --git a/board/freescale/mpc8568mds/MAINTAINERS b/board/freescale/mpc8568mds/MAINTAINERS index 56c5373c07..79f04d1a90 100644 --- a/board/freescale/mpc8568mds/MAINTAINERS +++ b/board/freescale/mpc8568mds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8568MDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8568mds/ F: include/configs/MPC8568MDS.h diff --git a/board/freescale/mpc8569mds/MAINTAINERS b/board/freescale/mpc8569mds/MAINTAINERS index 49a9361575..b2e3bdfa11 100644 --- a/board/freescale/mpc8569mds/MAINTAINERS +++ b/board/freescale/mpc8569mds/MAINTAINERS @@ -1,5 +1,5 @@ MPC8569MDS BOARD -M: York Sun +M: Prabhakar Kushwaha S: Maintained F: board/freescale/mpc8569mds/ F: include/configs/MPC8569MDS.h diff --git a/board/freescale/mpc8572ds/MAINTAINERS b/board/freescale/mpc8572ds/MAINTAINERS index
Re: [U-Boot] [PATCH] configs: fsl: move DDR specific defines to Kconfig
On 1/31/19 9:22 PM, Rajesh Bhagat wrote: > Moves below DDR specific defines to Kconfig: > > CONFIG_FSL_DDR_BIST > CONFIG_FSL_DDR_FIRST_SLOT_QUAD_CAPABLE > CONFIG_FSL_DDR_INTERACTIVE > CONFIG_FSL_DDR_SYNC_REFRESH > > Signed-off-by: Rajesh Bhagat > --- This is a good progress. You can move other DDR macros as well. Reviewed-by: York Sun ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Please pull u-boot-mpc85xx master
Tom, The following changes since commit 7794fe2c8c1303d303dbc515955c6c5be706da88: Merge git://git.denx.de/u-boot-nds32 (2019-01-22 22:00:20 -0500) are available in the Git repository at: git://git.denx.de/u-boot-mpc85xx.git tags/mpc85xx-for-v2019.04-rc1 for you to fetch changes up to 45e81f9ab3e97aec8e8744b23589bc21086cfd43: mpc85xx: Add support for -msingle-pic-base (2019-01-23 10:48:48 -0800) mpc85xx config.mk: Add support for -msingle-pic-base Travis build log is https://travis-ci.org/yorksun/u-boot/builds/483544380 Joakim Tjernlund (1): mpc85xx: Add support for -msingle-pic-base arch/powerpc/cpu/mpc85xx/config.mk | 1 + arch/powerpc/cpu/mpc85xx/start.S | 3 +++ 2 files changed, 4 insertions(+) Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] mpc85xx: Add support for -msingle-pic-base
On 12/6/18 8:20 AM, Joakim Tjernlund wrote: > -msingle-pic-base is a new gcc(from 4.6) option for ppc and > it reduces the size of my u-boot with about 4-5 KB. > While at it, add -fno-jump-tables too to save a > few more bytes. > > e5500 core: > size u-boot.bef >text data bss dec hex filename > 473043 23772 307104 803919 c444f u-boot.bef > size u-boot.aft >text data bss dec hex filename > 453195 23772 307104 784071 bf6c7 u-boot.aft > > e500 core: > size u-boot.bef >text data bss dec hex filename > 292998 17868 24968 335834 51fda u-boot.bef > size u-boot.aft >text data bss dec hex filename > 288002 17868 24968 330838 50c56 u-boot.aft > > Signed-off-by: Joakim Tjernlund > --- Applied to u-boot-mpc85xx, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3 01/60] mpc83xx: Introduce ARCH_MPC830*
On 1/21/19 12:19 AM, Mario Six wrote: > Replace CONFIG_MPC830* with proper CONFIG_ARCH_MPC830* Kconfig options. > > Signed-off-by: Mario Six > > --- I browse through the entire patch set. The patches look good. Since NXP doesn't make new mpc83xx SoCs and I have no board to verify, I don't comment on specific changes. There were many config macros which have been replace with hard-coded value inline by you. That's OK. The original plan was to allow different config but that didn't happen mostly. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] armv8: ls1088ardb: Update MAINTAINERS
On 1/16/19 7:49 AM, Rajesh Bhagat wrote: > From: York Sun > > Signed-off-by: York Sun > CC: Rajesh Bhagat > --- This set is applied to fsl-qoriq master, awaiting upstream. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] armv7: dts: ls1021a: Remove aliases property name warning
On 1/5/19 12:06 AM, Rajesh Bhagat wrote: > Remove aliases property name warning while compilation: > Warning (alias_paths): /aliases: aliases property name must > include only lowercase and '-' > > Signed-off-by: Rajesh Bhagat > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [u-boot][PATCH] ls1046aqds: Bypass xfi port fixup for KR mode
On 12/10/18 1:27 AM, Florinel Iordache wrote: > u-boot makes a fixup for LS1046AQDS board to setup the properties > 'fixed-link' and 'phy-connection-type' to 'xgmii' but in case of > backplane mode this fixup is not correct because it causes the KR link > to fail and so it must be bypassed in order to keep the link in KR mode > as it is defined in DTS. > > Signed-off-by: Florinel Iordache > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] armv8: fsl-layerscape: properly configure qdma ICID
On 12/12/18 3:45 AM, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > The ICIDs for the qdma device are not configured through SCFG but > through some registers found in the actual device register block. > > Signed-off-by: Laurentiu Tudor > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [U-Boot, v1] mmc: fsl_esdhc: make get_cd work well in dm_mmc_ops
On 12/14/18 2:02 AM, Yinbo Zhu wrote: > This patch is to make get_cd work well when DM_MMC enabled > > Signed-off-by: Yinbo Zhu > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] fsl-layerscape: dpaa: fix fsl-mc status in fdt with bootefi
On 12/18/18 5:01 AM, Mian Yousaf Kaukab wrote: > fsl-mc lazyapply command applies dpl from efi_exit_boot_services(). > Status of fsl-mc node in working fdt is updated at this stage. > However, an efi application like grub may already have copied the fdt. > So the updates to fdt done at efi_exit_boot_services() may not be visible > to the OS. Fix it by updating fdt earlier if fsl-mc lazyapply command is > used. > > Fixes: b7b8410a8f (ls2080: Exit dpaa only right before exiting U-Boot) > Signed-off-by: Mian Yousaf Kaukab > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] armv8: ls1043a: add SVR definitions for 23x23 package silicon
On 12/19/18 10:31 PM, Z.q. Hou wrote: > From: Hou Zhiqiang > > LS1043A/LS1023A 23x23 package silicon has different SVR:VAR_PER. > > Signed-off-by: Hou Zhiqiang This set has been applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH 1/2] env: fix allow to build multiple environments
On 1/11/19 11:30 PM, Rajesh Bhagat wrote: > Patch fixes build error when enabling CONFIG_ENV_IS_IN_SPI_FLAS > and CONFIG_ENV_IS_IN_MMC at the same time mentioned issue in > below link: > > Refer: https://lists.denx.de/pipermail/u-boot/2018-February/319565.html > > build error when enabling CONFIG_ENV_IS_IN_SPI_FLASH and > CONFIG_ENV_IS_IN_MMC at the same time. > > Signed-off-by: Rajesh Bhagat > --- > Depends on: > https://patchwork.ozlabs.org/project/uboot/list/?series=83635 > This set has been applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/7] armv8: fsl-layerscape: fixes for TFABOOT framework
On 12/26/18 8:37 PM, Rajesh Bhagat wrote: > Fixes for TFABOOT framework > - update eMMC bootsrc to SD_MMC > - Increase buffer size for mcinitcmd from 256 to 512 > - Fix mcinitcmd and bootcmd for Secure Boot > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- This set has been applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Please pull u-boot-fsl-qoriq master
Tom, The following changes since commit d3689267f92c5956e09cc7d1baa4700141662bff: Prepare v2019.01 (2019-01-14 17:02:36 -0500) are available in the Git repository at: git://git.denx.de/u-boot-fsl-qoriq.git tags/fsl-qoriq-for-v2019.04-rc1 for you to fetch changes up to a200ebea630002b14def4a015642fa341dc9cd11: armv8: ls2088ardb: Update MAINTAINERS (2019-01-17 13:17:51 -0800) Add TFA boot flow for more boards Add TFA boot defconfig for ls1088a and ls2088a. Add dts fixup for PCIe endpoint and root complex. Travis build log is https://travis-ci.org/yorksun/u-boot/builds/481076641 Florinel Iordache (1): ls1046aqds: Bypass xfi port fixup for KR mode Hou Zhiqiang (2): armv8: ls1043a: add SVR definitions for 23x23 package silicon armv8: ls1043a: correct the PCIe INTx fixup Laurentiu Tudor (1): armv8: fsl-layerscape: properly configure qdma ICID Mian Yousaf Kaukab (1): fsl-layerscape: dpaa: fix fsl-mc status in fdt with bootefi Pankit Garg (3): ls1043a: add support for nand-boot cmd for TFA armv8: ls1088ardb: Add TFABOOT support armv8: ls1088aqds: Add TFABOOT support Rajesh Bhagat (7): armv8: fsl-layerscape: fixes for TFABOOT framework drivers: ifc: restore the legacy flow for IFC config armv8: ls2088ardb: Add TFABOOT support armv8: ls2088aqds: Add TFABOOT support env: fix allow to build multiple environments configs: update TFABOOT defconfigs for SD boot support armv7: dts: ls1021a: Remove aliases property name warning Xiaowei Bao (3): pci: layerscape: Modify the EP and RC mode judge method pci: layerscape: Do not scan when PEX work in EP mode pci: layerscape: Add the dts fixup for EP and RC Yinbo Zhu (1): mmc: fsl_esdhc: make get_cd work well in dm_mmc_ops York Sun (2): armv8: ls1088ardb: Update MAINTAINERS armv8: ls2088ardb: Update MAINTAINERS arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 26 +-- arch/arm/cpu/armv8/fsl-layerscape/cpu.c| 4 +- arch/arm/cpu/armv8/fsl-layerscape/fdt.c| 2 +- arch/arm/cpu/armv8/fsl-layerscape/soc.c| 13 +- arch/arm/dts/fsl-ls2088a-rdb-qspi.dts | 4 + arch/arm/dts/ls1021a-iot.dtsi | 6 +- arch/arm/dts/ls1021a-qds.dtsi | 10 +- arch/arm/dts/ls1021a-twr.dtsi | 6 +- .../arm/include/asm/arch-fsl-layerscape/fsl_icid.h | 6 +- .../include/asm/arch-fsl-layerscape/immap_lsch2.h | 1 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 3 + board/freescale/ls1046aqds/eth.c | 35 ++-- board/freescale/ls1088a/MAINTAINERS| 5 + board/freescale/ls1088a/ddr.c | 11 ++ board/freescale/ls1088a/ls1088a.c | 196 - board/freescale/ls2080a/ls2080a.c | 10 +- board/freescale/ls2080aqds/MAINTAINERS | 2 + board/freescale/ls2080aqds/ddr.c | 12 ++ board/freescale/ls2080aqds/ls2080aqds.c| 3 +- board/freescale/ls2080ardb/MAINTAINERS | 3 + board/freescale/ls2080ardb/ddr.c | 12 ++ board/freescale/ls2080ardb/ls2080ardb.c| 40 - configs/ls1043aqds_tfa_defconfig | 1 + configs/ls1043ardb_tfa_defconfig | 1 + configs/ls1046aqds_tfa_defconfig | 1 + configs/ls1046ardb_tfa_defconfig | 1 + configs/ls1088aqds_tfa_defconfig | 70 configs/ls1088ardb_tfa_SECURE_BOOT_defconfig | 64 +++ configs/ls1088ardb_tfa_defconfig | 62 +++ configs/ls2088aqds_tfa_defconfig | 64 +++ configs/ls2088ardb_tfa_SECURE_BOOT_defconfig | 74 configs/ls2088ardb_tfa_defconfig | 73 drivers/misc/fsl_ifc.c | 173 ++ drivers/mmc/fsl_esdhc.c| 1 - drivers/net/fsl-mc/mc.c| 5 + drivers/pci/pcie_layerscape.c | 21 +-- drivers/pci/pcie_layerscape.h | 1 + drivers/pci/pcie_layerscape_fixup.c| 25 ++- include/configs/ls1043a_common.h | 2 + include/configs/ls1088a_common.h | 11 +- include/configs/ls1088aqds.h | 99 ++- include/configs/ls1088ardb.h | 137 +- include/configs/ls2080a_common.h | 8 + include/configs/ls2080aqds.h | 40 - include/configs/ls2080ardb.h | 137 +- include/environment.h | 9 - include/fsl-mc/fsl_mc.h
Re: [U-Boot] [PATCH 2/7] drivers: ifc: restore the legacy flow for IFC config
On 12/26/18 8:37 PM, Rajesh Bhagat wrote: > Restore the legacy flow along with TFABOOT flow for > IFC configuration. What's the reason to go back to old flow? York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [u-boot][PATCH] ls1046aqds: Bypass xfi port fixup for KR mode
On 12/10/18 1:27 AM, Florinel Iordache wrote:
> u-boot makes a fixup for LS1046AQDS board to setup the properties
> 'fixed-link' and 'phy-connection-type' to 'xgmii' but in case of
> backplane mode this fixup is not correct because it causes the KR link
> to fail and so it must be bypassed in order to keep the link in KR mode
> as it is defined in DTS.
>
> Signed-off-by: Florinel Iordache
> ---
> board/freescale/ls1046aqds/eth.c | 35 +--
> 1 file changed, 25 insertions(+), 10 deletions(-)
>
> diff --git a/board/freescale/ls1046aqds/eth.c
> b/board/freescale/ls1046aqds/eth.c
> index d3e8831..1fd755c 100644
> --- a/board/freescale/ls1046aqds/eth.c
> +++ b/board/freescale/ls1046aqds/eth.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0+
> /*
> * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> */
>
> #include
> @@ -153,6 +154,9 @@ void board_ft_fman_fixup_port(void *fdt, char *compat,
> phys_addr_t addr,
> enum fm_port port, int offset)
> {
> struct fixed_link f_link;
> + u32 *handle;
> + char *prop = NULL;
> + int off;
>
> if (fm_info_get_enet_if(port) == PHY_INTERFACE_MODE_SGMII) {
> switch (port) {
> @@ -208,16 +212,27 @@ void board_ft_fman_fixup_port(void *fdt, char *compat,
> phys_addr_t addr,
> "qsgmii");
> } else if (fm_info_get_enet_if(port) == PHY_INTERFACE_MODE_XGMII &&
> (port == FM1_10GEC1 || port == FM1_10GEC2)) {
> - /* XFI interface */
> - f_link.phy_id = cpu_to_fdt32(port);
> - f_link.duplex = cpu_to_fdt32(1);
> - f_link.link_speed = cpu_to_fdt32(1);
> - f_link.pause = 0;
> - f_link.asym_pause = 0;
> - /* no PHY for XFI */
> - fdt_delprop(fdt, offset, "phy-handle");
> - fdt_setprop(fdt, offset, "fixed-link", _link, sizeof(f_link));
> - fdt_setprop_string(fdt, offset, "phy-connection-type", "xgmii");
> + handle = fdt_getprop(fdt, offset, "phy-handle", NULL);
warning: assignment discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
Pleas fix.
York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] env: fix allow to build multiple environments
On 1/2/19 8:37 PM, Rajesh Bhagat wrote: > Patch fixes build error when enabling CONFIG_ENV_IS_IN_SPI_FLASH > and CONFIG_ENV_IS_IN_MMC at the same time mentioned issue in > below link: > > Refer: https://lists.denx.de/pipermail/u-boot/2018-February/319565.html > > build error when enabling CONFIG_ENV_IS_IN_SPI_FLASH and > CONFIG_ENV_IS_IN_MMC at the same time. > > Signed-off-by: Rajesh Bhagat > --- > Depends on: > https://patchwork.ozlabs.org/project/uboot/list/?series=83635 Rajesh, Please resend this set and CC maintainers. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] armv8: ls2080ardb: enable eSDHC pin mux support
On 11/22/18 1:06 AM, Yinbo Zhu wrote: > CONFIG_FSL_ESDHC_PIN_MUX should be enabled for ls2080ardb > whose eSDHC has pin mux with DSPI. This config makes sure > esdhc dts node would be fixed with disabled status if > DSPI is used, in case of any mmc issue in linux. Also, > esdhc should be added in default hwconfig since eSDHC is > used in default. > > Signed-off-by: Yinbo Zhu > --- > Change in v2: > Update the commit information. > > include/configs/ls2080ardb.h |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h > index f6aa4ed..d2e80a8 100644 > --- a/include/configs/ls2080ardb.h > +++ b/include/configs/ls2080ardb.h > @@ -331,6 +331,7 @@ unsigned long get_board_sys_clk(void); > /* MMC */ > #ifdef CONFIG_MMC > #define CONFIG_SYS_FSL_MMC_HAS_CAPBLT_VS33 > +#define CONFIG_FSL_ESDHC_PIN_MUX > #endif > Please consider to detect pin mux at run time. We are moving to TFA boot flow. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1] LS2080ardb: MMC: disable esdhc for dspi
On 11/22/18 12:23 AM, Yinbo Zhu wrote: > esdhc and dspi have Multiplexed pins, if dspi is enabled > and esdhc need to be disabled, This patch is to disable > esdhc when rcw config dspi enabled. > > Signed-off-by: Yinbo Zhu > --- > include/configs/ls2080ardb.h |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h > index f6aa4ed..d2e80a8 100644 > --- a/include/configs/ls2080ardb.h > +++ b/include/configs/ls2080ardb.h > @@ -331,6 +331,7 @@ unsigned long get_board_sys_clk(void); > /* MMC */ > #ifdef CONFIG_MMC > #define CONFIG_SYS_FSL_MMC_HAS_CAPBLT_VS33 > +#define CONFIG_FSL_ESDHC_PIN_MUX > #endif > We are moving to TFA boot flow. Please consider to detect the pin mux at runtime. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] armv8: Secure Boot: Modify boot_a_script definition
On 11/8/18 9:23 PM, Vinitha V Pillai wrote: > boot_script_hdr does not exist, it should not continue to > boot. So adding separate validation after loading boot_script If boot_script_hdr doesn't exist, the "load" command will fail. Why do you expect "esbc_validate" command to run without loading script header? York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull fsl-qoriq master
On 12/10/18 1:22 PM, York Sun wrote: > Tom, > > The following changes since commit d452f27b3ea806fd99aee4b73a723318032c1d5c: > > Prepare v2019.01-rc1 (2018-12-03 23:50:13 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-fsl-qoriq.git tags/fsl-qoriq-for-v2019.01-rc2 > > for you to fetch changes up to 4909b89ec763f0c7030fa8474f9b6c5df866b01f: > > armv8: lx2160a: Add LX2160A SoC Support (2018-12-06 14:37:19 -0800) > Travis build log is here https://travis-ci.org/yorksun/u-boot/builds/466070252 York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Please pull fsl-qoriq master
Tom, The following changes since commit d452f27b3ea806fd99aee4b73a723318032c1d5c: Prepare v2019.01-rc1 (2018-12-03 23:50:13 -0500) are available in the Git repository at: git://git.denx.de/u-boot-fsl-qoriq.git tags/fsl-qoriq-for-v2019.01-rc2 for you to fetch changes up to 4909b89ec763f0c7030fa8474f9b6c5df866b01f: armv8: lx2160a: Add LX2160A SoC Support (2018-12-06 14:37:19 -0800) Add TFA boot flow for some Layerscape platforms Add support for lx2160a SoC Alison Wang (1): arm: ls1021a: Add timer_init() in board_init_f for SPL Ashish Kumar (1): ls1088a: Move CONFIG_FSL_QSPI to defconfig Pankit Garg (5): armv8: fsl-layerscape: change tlb base from OCRAM to DDR in EL < 3 drivers: ifc: dynamic chipselect mapping support armv8: fsl-layerscape: bootcmd identification for TFABOOT armv8: sec_firmware: return job ring status as true in TFABOOT armv8: fsl-layerscape: add support of MC framework for TFA Peng Ma (10): scsi: ceva: add ls1046a soc support armv8: dts: fsl-ls1046a: add sata node support arm64: ls1046ardb: enable DM support for sata arm64: ls1046aqds: enable DM support for sata scsi: ceva: add ls1088a soc support armv8: dts: fsl-ls1088a: add sata node support arm64: ls1088a: enable DM support for sata scsi: ceva: add ls2080a soc support armv8: dts: fsl-ls2080a: add sata node support arm64: ls2080a: enable DM support for sata Pramod Kumar (1): armv8: ls1088ardb_pb: Add support for board detection Priyanka Jain (5): board/freescale/vid: Add correction for ltc3882 read error. armv8: lsch3: Add support of serdes3 module board/freescale/vid: Add vdd table for NXP LX2160A SoC armv8:fsl-layerscape: Add support for Chassis 3.2 armv8: lx2160a: Add LX2160A SoC Support Rajesh Bhagat (19): env: allow flash and nand env driver to compile together env: sf: define API to override sf environment address driver/ifc: replace __ilog2 with LOG2 macro armv8: layerscape: Add TFABOOT support armv8: fsl-layerscape: identify boot source from PORSR register armv8: layerscape: remove EL3 specific erratas for TFABOOT armv8: layerscape: add SMC calls for DDR size and bank info armv8: layerscape: skip OCRAM init for TFABOOT armv8: sec_firmware: change el2_to_aarch32 SMC ID net: fm: add TFABOOT support drivers: qe: add TFABOOT support armv8: ls1046ardb: Add TFABOOT support armv8: ls1046aqds: Add TFABOOT support armv8: ls1043ardb: Add TFABOOT support armv8: ls1043aqds: Add TFABOOT support armv8: ls1012ardb: Add TFABOOT support armv8: ls1012aqds: fix secure boot compilation armv8: ls1012aqds: Add TFABOOT support armv8: ls1012afrx: Add TFABOOT support York Sun (3): move data structure out of cpu.h armv8: layerscape: Enable routing SError exception armv8: fsl-layerscape: Update parsing boot source arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 89 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 6 +- arch/arm/cpu/armv8/fsl-layerscape/cpu.c| 639 - .../cpu/armv8/fsl-layerscape/doc/README.lsch3_2| 27 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 57 ++ .../cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c| 107 arch/arm/cpu/armv8/fsl-layerscape/lowlevel.S | 14 +- arch/arm/cpu/armv8/fsl-layerscape/lx2160a_serdes.c | 132 + arch/arm/cpu/armv8/fsl-layerscape/soc.c| 128 + arch/arm/cpu/armv8/sec_firmware.c | 4 + arch/arm/cpu/armv8/sec_firmware_asm.S | 2 +- arch/arm/dts/fsl-ls1046a-qds.dtsi | 4 + arch/arm/dts/fsl-ls1046a-rdb.dts | 4 + arch/arm/dts/fsl-ls1046a.dtsi | 8 + arch/arm/dts/fsl-ls1088a-qds.dts | 4 + arch/arm/dts/fsl-ls1088a-rdb.dts | 4 + arch/arm/dts/fsl-ls1088a.dtsi | 8 + arch/arm/dts/fsl-ls2080a-qds.dts | 4 + arch/arm/dts/fsl-ls2080a-rdb.dts | 4 + arch/arm/dts/fsl-ls2080a.dtsi | 8 + arch/arm/dts/fsl-lx2160a.dtsi | 118 arch/arm/include/asm/arch-fsl-layerscape/config.h | 56 ++ arch/arm/include/asm/arch-fsl-layerscape/cpu.h | 313 +- .../include/asm/arch-fsl-layerscape/fsl_serdes.h | 30 + .../include/asm/arch-fsl-layerscape/immap_lsch2.h | 20 + .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 85 ++- arch/arm/include/asm/arch-fsl-layerscape/soc.h | 28 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 9 +- board/freescale/common/vid.c | 42 +- board/freescale/ls1012afrdm/MAINTAINERS| 3 + bo
Re: [U-Boot] [PATCH][v2] armv8:fsl-layerscape: Add support for Chassis 3.2
On 10/29/18 2:11 AM, Priyanka Jain wrote: > NXP layerscape architecture Chassis 3.2 builds upon chassis3 > architecture with changes like DDR Memory map change, > removal of IFC and support of upto 8 I2C controller. > > Patch add README.lsch3_2 and the above changes under > macro CONFIG_NXP_LSCH3_2. > > Signed-off-by: Sriram Dash > Signed-off-by: Priyanka Jain > --- > Changes for v2: > Rebased on top of test_qoriq branch of u-boot-fsl-qoriq.git > Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH][v3] armv8: lx2160a: Add LX2160A SoC Support
On 10/29/18 2:17 AM, Priyanka Jain wrote: > LX2160A Soc is based on Layerscape Chassis Generation 3.2 Architecture. > Features: > 16 ARM v8 Cortex-A72 cores in 8 cluster, CCN508, SEC, > two 64-bit DDR4 memory controller, RGMII, 8 I2C controllers, > 3 serdes modules, USB 3.0, SATA, 4 PL011 SBSA UARTs, > 4 TZASC instances, etc. > > SoC personalites: > LX2120A is SoC with Twelve 64-bit ARM v8 Cortex-A72 CPUs > LX2080A is SoC with Eight 64-bit ARM v8 Cortex-A72 CPUs > > Signed-off-by: Bao Xiaowei > Signed-off-by: Hou Zhiqiang > Signed-off-by: Meenakshi Aggarwal > Signed-off-by: Vabhav Sharma > Signed-off-by: Sriram Dash > Signed-off-by: Priyanka Jain > --- > Changes for v3: > Add CONFIG_SYS_FSL_RST_ADDR define > Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] board/freescale/vid: Add vdd table for NXP LX2160A SoC
On 10/10/18 10:22 PM, Priyanka Jain wrote: > Signed-off-by: Priyanka Jain > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH][v2] armv8: lsch3: Add support of serdes3 module
On 9/26/18 10:02 PM, Priyanka Jain wrote: > Some lsch3 based SoCs like lx2160a contains three > serdes modules. > Add support for third serdes protocol in lsch3 > > Signed-off-by: Priyanka Jain > --- > Changes for v2: > Updated copyright > Renamed CONFIG_SYS_FSL_SRDS_3 to CONFIG_SYS_NXP_SRDS_3 > Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] board/freescale/vid: Add correction for ltc3882 read error.
On 10/10/18 10:11 PM, Priyanka Jain wrote: > Voltage regulator LTC3882 device has 0.5% voltage read error. > So for NXP SoC devices this generally equates to 2mV > > Update set_voltage_to_LTC for below: > 1.Add coorection of upto 2mV in voltage comparison > to take care of voltage read error of voltage regulator > 2.Add loop max count kept as 100 to avoid infinte loop. > > Signed-off-by: Priyanka Jain > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ls1088a: Move CONFIG_FSL_QSPI to defconfig
On 10/12/18 2:18 AM, Ashish Kumar wrote: > Signed-off-by: Rajat Srivastava > Signed-off-by: Ashish Kumar > --- This set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] armv8: ls1088ardb_pb: Add support for board detection
On 10/12/18 7:04 AM, Pramod Kumar wrote: > ls1088ardb-pb and ls1088ardb both boards are ls1088a based soc, > board type detection is dynamic at boot time > > Signed-off-by: Pramod Kumar > --- This set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: ls1021a: Add timer_init() in board_init_f for SPL
On 10/16/18 1:23 AM, Alison Wang wrote: > I2C is used to access DDR SPD in the DDR initialization for SPL. In > i2c_write process, get_timer() will be called. In board_init_f for SPL, > timer_init() is not called before. The system counter is not enabled and > the counter frequency is not set to 12.5MHz in SPL. The parameters for > do_div() are zero too. > > It could not be found until CONFIG_USE_PRIVATE_LIBGCC is enabled in > default. When CONFIG_USE_PRIVATE_LIBGCC is enabled, U-Boot will use its > own set of libgcc functions. As the parameters for do_div() are zero, > __div0 will be called. Then the processor will stay in an endless loop > after calling hang(). > > This patch will add timer_init() in board_init_f for SPL and fix a > series of issues it caused. > > Signed-off-by: Alison Wang > --- This set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] scsi: ceva: add ls2080a soc support
On 10/21/18 7:47 PM, Peng Ma wrote: > Add ahci compatible support for ls2080a soc. > > Signed-off-by: Peng Ma > --- This set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] scsi: ceva: add ls1088a soc support
On 10/21/18 7:43 PM, Peng Ma wrote: > Add ahci compatible support for ls1088a soc. > > Signed-off-by: Peng Ma > --- This set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] scsi: ceva: add ls1046a soc support
On 10/11/18 3:38 AM, Peng Ma wrote: > Add ahci compatible support for ls1046a soc. > > Signed-off-by: Peng Ma > --- Please remember to sort defconfig using moveconfig.py in the future. This set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 00/27] TF-A Boot support for NXP Chassis 2 platforms
On 11/5/18 10:01 AM, Rajesh Bhagat wrote: > Includes changes in u-boot framework to support TF-A for NXP Chassis 2 > platforms. A new defconfig is added namely ls*_tfa_defconfig which will > be used for all boot sources when TF-A is used. > > > > Tested on LS1043A, LS1046A and LS1012A platforms. > > Changes in v6: > - Rebased to master Fixed multiple issues found by checkpatch. Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] mpc85xx: Add support for -msingle-pic-base
On 12/6/18 8:20 AM, Joakim Tjernlund wrote: > -msingle-pic-base is a new gcc(from 4.6) option for ppc and > it reduces the size of my u-boot with about 4-5 KB. > While at it, add -fno-jump-tables too to save a > few more bytes. > > e5500 core: > size u-boot.bef >text data bss dec hex filename > 473043 23772 307104 803919 c444f u-boot.bef > size u-boot.aft >text data bss dec hex filename > 453195 23772 307104 784071 bf6c7 u-boot.aft > > e500 core: > size u-boot.bef >text data bss dec hex filename > 292998 17868 24968 335834 51fda u-boot.bef > size u-boot.aft >text data bss dec hex filename > 288002 17868 24968 330838 50c56 u-boot.aft > > Signed-off-by: Joakim Tjernlund > --- Tested on e500mc, e5500, e6500 platforms. Acked-by: York Sun ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] AQUANTIA USXGMII autoneg enable
On 10/30/18 2:54 AM, Valentin-catalin Neacsu wrote:
> If System interface protocol is USXGMII then enable USXGMII autoneg
> Signed-off-by: Valentin Catalin Neacsu
> ---
> drivers/net/phy/aquantia.c | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
> index 6678147545..603abb5a7f 100644
> --- a/drivers/net/phy/aquantia.c
> +++ b/drivers/net/phy/aquantia.c
> @@ -4,6 +4,7 @@
> * SPDX-License-Identifier: GPL-2.0+
> *
> * Copyright 2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> */
> #include
> #include
> @@ -20,6 +21,13 @@
> #define AQUNTIA_SPEED_LSB_MASK 0x2000
> #define AQUNTIA_SPEED_MSB_MASK 0x40
>
> +#define AQUANTIA_SYSTEM_INTERFACE_SR 0xe812
> +#define AQUANTIA_VENDOR_PROVISIONING_REG 0xC441
> +
> +#define AQUANTIA_USX_AUTONEG_CONTROL_ENA 0x0008
> +#define AQUANTIA_SI_IN_USE_MASK 0x0078
> +#define AQUANTIA_SI_USXGMII 0x0018
> +
> int aquantia_config(struct phy_device *phydev)
> {
> u32 val = phy_read(phydev, MDIO_MMD_PMAPMD, MII_BMCR);
> @@ -41,6 +49,16 @@ int aquantia_config(struct phy_device *phydev)
> phy_write(phydev, MDIO_MMD_PMAPMD, MII_BMCR,
> AQUNTIA_SPEED_LSB_MASK |
> AQUNTIA_SPEED_MSB_MASK);
> +
> + val = phy_read(phydev, MDIO_MMD_PHYXS,
> +AQUANTIA_SYSTEM_INTERFACE_SR);
> + /* If SI is USXGMII then start USXGMII autoneg*/
> + if ((val & AQUANTIA_SI_IN_USE_MASK) == AQUANTIA_SI_USXGMII) {
> + phy_write(phydev, MDIO_MMD_PHYXS,
> + AQUANTIA_VENDOR_PROVISIONING_REG,
> + AQUANTIA_USX_AUTONEG_CONTROL_ENA);
> + }
> +
> } else if (phydev->interface == PHY_INTERFACE_MODE_SGMII_2500) {
> /* 2.5GBASE-T mode */
> phydev->advertising = SUPPORTED_1000baseT_Full;
>
This should be sent to Joe.
York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 03/27] env: sf: define API to override sf environment address
Maintainers,
Please review this patch as it slightly changes common code for ENV.
Rajesh,
If you run get_maintainers, or use patman, you would have expanded the
CC list.
York
On 11/5/18 10:01 AM, Rajesh Bhagat wrote:
> Defines env_sf_get_env_addr API to override sf environment address,
> required to support multiple environment.
>
> Signed-off-by: Rajesh Bhagat
> ---
> Change in v6: None
> Change in v5: None
> Change in v4: None
> Change in v3: None
> Change in v2: None
>
> env/sf.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/env/sf.c b/env/sf.c
> index 2e3c600483..23cbad5d88 100644
> --- a/env/sf.c
> +++ b/env/sf.c
> @@ -298,10 +298,17 @@ out:
> }
> #endif
>
> +#ifdef CONFIG_ENV_ADDR
> +__weak void *env_sf_get_env_addr(void)
> +{
> + return (void *)CONFIG_ENV_ADDR;
> +}
> +#endif
> +
> #if defined(INITENV) && defined(CONFIG_ENV_ADDR)
> static int env_sf_init(void)
> {
> - env_t *env_ptr = (env_t *)(CONFIG_ENV_ADDR);
> + env_t *env_ptr = (env_t *)env_sf_get_env_addr();
>
> if (crc32(0, env_ptr->data, ENV_SIZE) == env_ptr->crc) {
> gd->env_addr= (ulong)&(env_ptr->data);
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 02/27] env: allow flash and nand env driver to compile together
Maintainers, Please review this patch as it slightly changes common code for ENV. Rajesh, If you run get_maintainers, or use patman, you would have expanded the CC list. York On 11/5/18 10:01 AM, Rajesh Bhagat wrote: > Define env_ptr as static in flash and nand env driver to > allow these to compile together. > > Signed-off-by: Rajesh Bhagat > --- > Change in v6: None > > Change in v5: > - Solved compilation warning for boards mccmon6_sd and mccmon6_nor > > Change in v4: None > > Change in v3: > - Merged env nand specific patches to remove compilation warning > > Change in v2: None > > > > env/flash.c | 12 ++-- > env/nand.c| 6 ++ > include/environment.h | 1 - > 3 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/env/flash.c b/env/flash.c > index 32236c716e..dca6567a09 100644 > --- a/env/flash.c > +++ b/env/flash.c > @@ -44,16 +44,16 @@ DECLARE_GLOBAL_DATA_PTR; > #define INITENV > #endif > > +#if defined(CONFIG_ENV_ADDR_REDUND) && defined(CMD_SAVEENV) || \ > + !defined(CONFIG_ENV_ADDR_REDUND) && defined(INITENV) > #ifdef ENV_IS_EMBEDDED > -env_t *env_ptr = > - > -static __maybe_unused env_t *flash_addr = (env_t *)CONFIG_ENV_ADDR; > - > +static env_t *env_ptr = > #else /* ! ENV_IS_EMBEDDED */ > > -env_t *env_ptr = (env_t *)CONFIG_ENV_ADDR; > -static __maybe_unused env_t *flash_addr = (env_t *)CONFIG_ENV_ADDR; > +static env_t *env_ptr = (env_t *)CONFIG_ENV_ADDR; > #endif /* ENV_IS_EMBEDDED */ > +#endif > +static __maybe_unused env_t *flash_addr = (env_t *)CONFIG_ENV_ADDR; > > /* CONFIG_ENV_ADDR is supposed to be on sector boundary */ > static ulong __maybe_unused end_addr = > diff --git a/env/nand.c b/env/nand.c > index 3698e68957..29eda66fad 100644 > --- a/env/nand.c > +++ b/env/nand.c > @@ -40,11 +40,9 @@ > #endif > > #if defined(ENV_IS_EMBEDDED) > -env_t *env_ptr = > +static env_t *env_ptr = > #elif defined(CONFIG_NAND_ENV_DST) > -env_t *env_ptr = (env_t *)CONFIG_NAND_ENV_DST; > -#else /* ! ENV_IS_EMBEDDED */ > -env_t *env_ptr; > +static env_t *env_ptr = (env_t *)CONFIG_NAND_ENV_DST; > #endif /* ENV_IS_EMBEDDED */ > > DECLARE_GLOBAL_DATA_PTR; > diff --git a/include/environment.h b/include/environment.h > index 5e90f157e8..7da1291d5b 100644 > --- a/include/environment.h > +++ b/include/environment.h > @@ -157,7 +157,6 @@ extern env_t environment; > #endif /* ENV_IS_EMBEDDED */ > > extern const unsigned char default_environment[]; > -extern env_t *env_ptr; > > #if defined(CONFIG_NEEDS_MANUAL_RELOC) > extern void env_reloc(void); > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] armv8: ls1043aqds: modify the qspi_bootcmd definition
On 11/20/18 12:55 AM, Wen He wrote:
> Fix the kernel offset of qspi_bootcmd scripts, followed
> the qoriq_memory_layout definition.
>
> Signed-off-by: Wen He
> ---
> include/configs/ls1043a_common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/ls1043a_common.h
> b/include/configs/ls1043a_common.h
> index 795e904..7b2f31c 100644
> --- a/include/configs/ls1043a_common.h
> +++ b/include/configs/ls1043a_common.h
> @@ -302,8 +302,8 @@
> "source ${scriptaddr}\0"\
> "qspi_bootcmd=echo Trying load from qspi..;"\
> "sf probe && sf read $load_addr " \
> - "$kernel_addr $kernel_size; env exists secureboot " \
> - "&& sf read $kernelheader_addr_r $kernelheader_addr " \
> + "$kernel_start $kernel_size; env exists secureboot "\
> + "&& sf read $kernelheader_addr_r $kernelheader_start " \
> "$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
> "bootm $load_addr#$board\0" \
> "nor_bootcmd=echo Trying load from nor..;" \
>
Why do you need to copy the images from QSPI flash? It is directly
readable. It has been this way and it is not your fault. Can you fix it?
York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] fsl-lsch3: soc: Enable AHB read support for Flexspi controller
On 11/20/18 1:24 AM, Ashish Kumar wrote: > > >> -Original Message----- >> From: York Sun >> Sent: Tuesday, November 20, 2018 2:13 AM >> To: Ashish Kumar ; u-boot@lists.denx.de >> Cc: Yogesh Narayan Gaur ; Rajat Srivastava >> >> Subject: Re: [PATCH v3] fsl-lsch3: soc: Enable AHB read support for Flexspi >> controller >> >> On 11/12/18 11:26 PM, Ashish Kumar wrote: >>> Enable AHB support for Flexspi controller interface meaning memory can >>> be accessed via md command using absolute addresses >>> >>> Signed-off-by: Yogesh Gaur >>> Signed-off-by: Rajat Srivastava >>> Signed-off-by: Ashish Kumar >>> --- >>> v3: >>> Depends upon http://patchwork.ozlabs.org/patch/975009/ > Hi York, > > Sorry that was typo, it was meant to be > http://patchwork.ozlabs.org/patch/974301/. > But unfortunately after lot of delay in review on NXP-FlexSPI driver, it has > been asked to re-write to a new frame-work. I think I should defer this > http://patchwork.ozlabs.org/patch/975008/ and > http://patchwork.ozlabs.org/patch/996846/ for the time being until 974301 is > re-written. What do you suggest? > You still need FlexSPI driver, don't you? Please work with Jagan on the driver. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH][v2] armv8: lx2160ardb : Add support for LX2160ARDB platform
On 10/29/18 2:30 AM, Priyanka Jain wrote: > LX2160ARDB is an evaluation board that supports LX2160A > family SoCs. This patch add base support for this board. > > Signed-off-by: Wasim Khan > Signed-off-by: Yogesh Gaur > Signed-off-by: Meenakshi Aggarwal > Signed-off-by: Vabhav Sharma > Signed-off-by: Sriram Dash > Signed-off-by: Rajesh Bhagat > Signed-off-by: Pankit Garg > Signed-off-by: Priyanka Jain > --- > Changes for v2: > Rebased on top of test_qoriq branch of u-boot-fsl-qoriq.git > > Corrected line > seria01.clock = get_serial_clock -> serial1.clock = get_serial_clock(); > > Corrected CONFIG_ENV_OFFSET to 0x50 [Thanks to Ashish K for pointing > this] > Priyanka, I am seeing compiling error ../board/freescale/lx2160a/eth_lx2160ardb.c:71:3: error: too few arguments to function ?wriop_set_phy_address? Please also check the patches I collected here http://patchwork.ozlabs.org/bundle/yorksun/lx2/ and confirm the dependency and order. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] fsl-lsch3: soc: Enable AHB read support for Flexspi controller
On 11/12/18 11:26 PM, Ashish Kumar wrote: > Enable AHB support for Flexspi controller interface meaning > memory can be accessed via md command using absolute addresses > > Signed-off-by: Yogesh Gaur > Signed-off-by: Rajat Srivastava > Signed-off-by: Ashish Kumar > --- > v3: > Depends upon http://patchwork.ozlabs.org/patch/975009/ Your v3 patch depends on its v2 version. This doesn't make sense. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 00/27] TF-A Boot support for NXP Chassis 2 platforms
On 11/5/18 10:01 AM, Rajesh Bhagat wrote: > Includes changes in u-boot framework to support TF-A for NXP Chassis 2 > platforms. A new defconfig is added namely ls*_tfa_defconfig which will > be used for all boot sources when TF-A is used. > > > > Tested on LS1043A, LS1046A and LS1012A platforms. > > Changes in v6: > - Rebased to master Rajesh, I suggest you resend this set with patman, or manually run get_maintainer.pl for each patch. There are several patches change common files for env. It is good to keep other maintainers in the loop. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] spi: Zap fsl_espi driver-related code
On 11/14/18 7:46 AM, Jagan Teki wrote: > + Simon > > On Wed, Nov 14, 2018 at 9:00 PM York Sun wrote: >> >> On 11/14/18 6:57 AM, Jagan Teki wrote: >>> Dropped >>> - fsl_espi driver >>> - SPI, SPI flash CONFIG-items >>> - CMD_SF..etc >>> >>> Dropped becuase >>> - No proper changes related to since from 2015 >>> - no dm conversion. >>> >>> Cc: Tom Rini >>> Cc: York Sun >>> Signed-off-by: Jagan Teki >>> --- >>> Note: >>> - This certainly break many board, but it's too late >>> - I have seen spi is using in net, mmc [1] will remove those >>> as well if none can answer this patch. >>> >>> [1] >>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fopenedev%2Fu-boot-amarula%2Fbuilds%2F454923826data=02%7C01%7Cyork.sun%40nxp.com%7C5783a0a22ff84433058e08d64a485bb5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636778071970654553sdata=q%2FXUyAdc6rvwSSOlTyxR2%2BlITFQn67EP9K1X5f6iM5o%3Dreserved=0 >>> >>> arch/powerpc/include/asm/config.h | 2 +- >>> configs/B4420QDS_NAND_defconfig | 5 - >>> configs/B4420QDS_SPIFLASH_defconfig | 8 +- >>> configs/B4420QDS_defconfig| 5 - >>> configs/B4860QDS_NAND_defconfig | 5 - >>> configs/B4860QDS_SECURE_BOOT_defconfig| 5 - >>> configs/B4860QDS_SPIFLASH_defconfig | 7 - >>> configs/B4860QDS_SRIO_PCIE_BOOT_defconfig | 5 - >>> configs/B4860QDS_defconfig| 5 - >>> configs/BSC9131RDB_NAND_SYSCLK100_defconfig | 5 - >>> configs/BSC9131RDB_NAND_defconfig | 5 - >>> .../BSC9131RDB_SPIFLASH_SYSCLK100_defconfig | 7 - >>> configs/BSC9131RDB_SPIFLASH_defconfig | 7 - >>> ...BSC9132QDS_NAND_DDRCLK100_SECURE_defconfig | 4 - >>> configs/BSC9132QDS_NAND_DDRCLK100_defconfig | 5 - >>> ...BSC9132QDS_NAND_DDRCLK133_SECURE_defconfig | 5 - >>> configs/BSC9132QDS_NAND_DDRCLK133_defconfig | 5 - >>> .../BSC9132QDS_NOR_DDRCLK100_SECURE_defconfig | 5 - >>> configs/BSC9132QDS_NOR_DDRCLK100_defconfig| 5 - >>> .../BSC9132QDS_NOR_DDRCLK133_SECURE_defconfig | 5 - >>> configs/BSC9132QDS_NOR_DDRCLK133_defconfig| 5 - >>> ...C9132QDS_SDCARD_DDRCLK100_SECURE_defconfig | 5 - >>> configs/BSC9132QDS_SDCARD_DDRCLK100_defconfig | 5 - >>> ...C9132QDS_SDCARD_DDRCLK133_SECURE_defconfig | 5 - >>> configs/BSC9132QDS_SDCARD_DDRCLK133_defconfig | 5 - >>> ...132QDS_SPIFLASH_DDRCLK100_SECURE_defconfig | 6 - >>> .../BSC9132QDS_SPIFLASH_DDRCLK100_defconfig | 7 - >>> ...132QDS_SPIFLASH_DDRCLK133_SECURE_defconfig | 6 - >>> .../BSC9132QDS_SPIFLASH_DDRCLK133_defconfig | 7 - >>> configs/C29XPCIE_NAND_defconfig | 6 - >>> configs/C29XPCIE_NOR_SECBOOT_defconfig| 6 - >>> configs/C29XPCIE_SPIFLASH_SECBOOT_defconfig | 7 - >>> configs/C29XPCIE_SPIFLASH_defconfig | 8 - >>> configs/C29XPCIE_defconfig| 6 - >>> configs/Cyrus_P5020_defconfig | 2 - >>> configs/Cyrus_P5040_defconfig | 2 - >>> configs/MPC8536DS_36BIT_defconfig | 5 - >>> configs/MPC8536DS_SDCARD_defconfig| 5 - >>> configs/MPC8536DS_SPIFLASH_defconfig | 7 - >>> configs/MPC8536DS_defconfig | 5 - >>> .../P1010RDB-PA_36BIT_NAND_SECBOOT_defconfig | 5 - >>> configs/P1010RDB-PA_36BIT_NAND_defconfig | 5 - >>> .../P1010RDB-PA_36BIT_NOR_SECBOOT_defconfig | 5 - >>> configs/P1010RDB-PA_36BIT_NOR_defconfig | 5 - >>> configs/P1010RDB-PA_36BIT_SDCARD_defconfig| 5 - >>> ...010RDB-PA_36BIT_SPIFLASH_SECBOOT_defconfig | 6 - >>> configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig | 9 - >>> configs/P1010RDB-PA_NAND_SECBOOT_defconfig| 5 - >>> configs/P1010RDB-PA_NAND_defconfig| 5 - >>> configs/P1010RDB-PA_NOR_SECBOOT_defconfig | 5 - >>> configs/P1010RDB-PA_NOR_defconfig | 5 - >>> configs/P1010RDB-PA_SDCARD_defconfig | 5 - >>> .../P1010RDB-PA_SPIFLASH_SECBOOT_defconfig| 6 - >>> configs/P1010RDB-PA_SPIFLASH_defconfig| 9 - >>> .../P1010RDB-PB_36BIT_NAND_SECBOOT_defconfig | 5 - >>> configs/P1010RDB-PB_36BIT_NAND_defconfig | 5 - >>> .
Re: [U-Boot] [PATCH v2] spi: Zap fsl_espi driver-related code
On 11/14/18 6:57 AM, Jagan Teki wrote: > Dropped > - fsl_espi driver > - SPI, SPI flash CONFIG-items > - CMD_SF..etc > > Dropped becuase > - No proper changes related to since from 2015 > - no dm conversion. > > Cc: Tom Rini > Cc: York Sun > Signed-off-by: Jagan Teki > --- > Note: > - This certainly break many board, but it's too late > - I have seen spi is using in net, mmc [1] will remove those > as well if none can answer this patch. > > [1] > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fopenedev%2Fu-boot-amarula%2Fbuilds%2F454923826data=02%7C01%7Cyork.sun%40nxp.com%7Ccc76c039ad8e45f6705908d64a41860c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636778042646476028sdata=RZwMInnXsCeR6whjXMTsb9uRX7l1lDjySgh8wB0eMTU%3Dreserved=0 > > arch/powerpc/include/asm/config.h | 2 +- > configs/B4420QDS_NAND_defconfig | 5 - > configs/B4420QDS_SPIFLASH_defconfig | 8 +- > configs/B4420QDS_defconfig| 5 - > configs/B4860QDS_NAND_defconfig | 5 - > configs/B4860QDS_SECURE_BOOT_defconfig| 5 - > configs/B4860QDS_SPIFLASH_defconfig | 7 - > configs/B4860QDS_SRIO_PCIE_BOOT_defconfig | 5 - > configs/B4860QDS_defconfig| 5 - > configs/BSC9131RDB_NAND_SYSCLK100_defconfig | 5 - > configs/BSC9131RDB_NAND_defconfig | 5 - > .../BSC9131RDB_SPIFLASH_SYSCLK100_defconfig | 7 - > configs/BSC9131RDB_SPIFLASH_defconfig | 7 - > ...BSC9132QDS_NAND_DDRCLK100_SECURE_defconfig | 4 - > configs/BSC9132QDS_NAND_DDRCLK100_defconfig | 5 - > ...BSC9132QDS_NAND_DDRCLK133_SECURE_defconfig | 5 - > configs/BSC9132QDS_NAND_DDRCLK133_defconfig | 5 - > .../BSC9132QDS_NOR_DDRCLK100_SECURE_defconfig | 5 - > configs/BSC9132QDS_NOR_DDRCLK100_defconfig| 5 - > .../BSC9132QDS_NOR_DDRCLK133_SECURE_defconfig | 5 - > configs/BSC9132QDS_NOR_DDRCLK133_defconfig| 5 - > ...C9132QDS_SDCARD_DDRCLK100_SECURE_defconfig | 5 - > configs/BSC9132QDS_SDCARD_DDRCLK100_defconfig | 5 - > ...C9132QDS_SDCARD_DDRCLK133_SECURE_defconfig | 5 - > configs/BSC9132QDS_SDCARD_DDRCLK133_defconfig | 5 - > ...132QDS_SPIFLASH_DDRCLK100_SECURE_defconfig | 6 - > .../BSC9132QDS_SPIFLASH_DDRCLK100_defconfig | 7 - > ...132QDS_SPIFLASH_DDRCLK133_SECURE_defconfig | 6 - > .../BSC9132QDS_SPIFLASH_DDRCLK133_defconfig | 7 - > configs/C29XPCIE_NAND_defconfig | 6 - > configs/C29XPCIE_NOR_SECBOOT_defconfig| 6 - > configs/C29XPCIE_SPIFLASH_SECBOOT_defconfig | 7 - > configs/C29XPCIE_SPIFLASH_defconfig | 8 - > configs/C29XPCIE_defconfig| 6 - > configs/Cyrus_P5020_defconfig | 2 - > configs/Cyrus_P5040_defconfig | 2 - > configs/MPC8536DS_36BIT_defconfig | 5 - > configs/MPC8536DS_SDCARD_defconfig| 5 - > configs/MPC8536DS_SPIFLASH_defconfig | 7 - > configs/MPC8536DS_defconfig | 5 - > .../P1010RDB-PA_36BIT_NAND_SECBOOT_defconfig | 5 - > configs/P1010RDB-PA_36BIT_NAND_defconfig | 5 - > .../P1010RDB-PA_36BIT_NOR_SECBOOT_defconfig | 5 - > configs/P1010RDB-PA_36BIT_NOR_defconfig | 5 - > configs/P1010RDB-PA_36BIT_SDCARD_defconfig| 5 - > ...010RDB-PA_36BIT_SPIFLASH_SECBOOT_defconfig | 6 - > configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig | 9 - > configs/P1010RDB-PA_NAND_SECBOOT_defconfig| 5 - > configs/P1010RDB-PA_NAND_defconfig| 5 - > configs/P1010RDB-PA_NOR_SECBOOT_defconfig | 5 - > configs/P1010RDB-PA_NOR_defconfig | 5 - > configs/P1010RDB-PA_SDCARD_defconfig | 5 - > .../P1010RDB-PA_SPIFLASH_SECBOOT_defconfig| 6 - > configs/P1010RDB-PA_SPIFLASH_defconfig| 9 - > .../P1010RDB-PB_36BIT_NAND_SECBOOT_defconfig | 5 - > configs/P1010RDB-PB_36BIT_NAND_defconfig | 5 - > .../P1010RDB-PB_36BIT_NOR_SECBOOT_defconfig | 5 - > configs/P1010RDB-PB_36BIT_NOR_defconfig | 5 - > configs/P1010RDB-PB_36BIT_SDCARD_defconfig| 5 - > ...010RDB-PB_36BIT_SPIFLASH_SECBOOT_defconfig | 6 - > configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig | 9 - > configs/P1010RDB-PB_NAND_SECBOOT_defconfig| 5 - > configs/P1010RDB-PB_NAND_defconfig| 5 - > configs/P1010RDB-PB_NOR_SECBOOT_defconfig | 5 - > configs/P1010RDB-PB_NOR_defconfig | 5 - > configs/P1010RDB-PB_SDCARD_defconfig | 5 - > .../P1010RDB-PB_SPIFLASH_SECBOOT_defconfig| 6 - > configs/P1010RDB-PB_SPIFLASH_defconfig| 9 - > configs/P1020MBG-PC_36BIT_SDCARD_defconfig| 2 - >
Re: [U-Boot] [PATCH v2] fsl-lsch3: soc: Enable AHB read support for Flexspi controller
On 11/2/18 8:59 AM, York Sun wrote: > On 9/26/18 4:10 AM, Ashish Kumar wrote: >> Enable AHB support for Flexspi controller interface meaning >> memory can be accessed via md command using absolute addresses >> >> Signed-off-by: Yogesh Gaur >> Signed-off-by: Rajat Srivastava >> Signed-off-by: Ashish Kumar >> --- >> v2: >> 1. Rename FSPI to FlexSPI in description and comments >> 2. s/cmd/command >> 3. Add macro and comments to improve readablity of code in soc.c >> 4. Add declaration in soc.h for fspi_ahb_init() >> >> arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 10 + >> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 44 +++ >> .../arm/include/asm/arch-fsl-layerscape/soc.h | 7 +++ >> 3 files changed, 61 insertions(+) >> >> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig >> b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig >> index 5280d33ec8..70f26973e9 100644 >> --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig >> +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig >> @@ -327,6 +327,16 @@ config SYS_FSPI_AHB_INIT >>performed. Default LUT programmed in AHB mode is Fast Read command >>with 4-byte addressing enabled. > > SYS_FSPI_AHB_INIT doesn't exist yet. > >> >> +config FSPI_AHB_EN_4BYTE >> +bool "Enable 4-byte Fast Read command for AHB mode" >> +depends on NXP_FSPI >> +default n >> +help >> + The default setting for FlexSPI AHB bus just supports 3-byte >> addressing. >> + But some FlexSPI flash sizes are up to 64MBytes. >> + This flag enables fast read command for AHB mode and modifies required >> + LUT to support full FlexSPI flash. >> + > > NXP_FSPI doesn't exist yet. > > Do you have dependency I missed? > Please fix your patch asap. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] fsl-lsch3: soc: Enable AHB read support for Flexspi controller
On 9/26/18 4:10 AM, Ashish Kumar wrote: > Enable AHB support for Flexspi controller interface meaning > memory can be accessed via md command using absolute addresses > > Signed-off-by: Yogesh Gaur > Signed-off-by: Rajat Srivastava > Signed-off-by: Ashish Kumar > --- > v2: > 1. Rename FSPI to FlexSPI in description and comments > 2. s/cmd/command > 3. Add macro and comments to improve readablity of code in soc.c > 4. Add declaration in soc.h for fspi_ahb_init() > > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 10 + > arch/arm/cpu/armv8/fsl-layerscape/soc.c | 44 +++ > .../arm/include/asm/arch-fsl-layerscape/soc.h | 7 +++ > 3 files changed, 61 insertions(+) > > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > index 5280d33ec8..70f26973e9 100644 > --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > @@ -327,6 +327,16 @@ config SYS_FSPI_AHB_INIT > performed. Default LUT programmed in AHB mode is Fast Read command > with 4-byte addressing enabled. SYS_FSPI_AHB_INIT doesn't exist yet. > > +config FSPI_AHB_EN_4BYTE > + bool "Enable 4-byte Fast Read command for AHB mode" > + depends on NXP_FSPI > + default n > + help > + The default setting for FlexSPI AHB bus just supports 3-byte > addressing. > + But some FlexSPI flash sizes are up to 64MBytes. > + This flag enables fast read command for AHB mode and modifies required > + LUT to support full FlexSPI flash. > + NXP_FSPI doesn't exist yet. Do you have dependency I missed? York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] armv8: ls1012afrwy: update of env board variables
On 10/12/18 4:01 AM, Pramod Kumar wrote:
> ls1012afrwy and ls1012afrdm both boards are variant
> of ls1012a based SoC, by default board and board_name
> uboot env variables are set as ls1012afrdm. whenever board
> is detected as ls1012afrwy, uboot env variables are updated to
> ls1012afrwy if it set as other than ls1012afrwy
>
> Signed-off-by: Pramod Kumar
> ---
> Changes in v2:
> - fix subject and commit message
>
> board/freescale/ls1012afrdm/ls1012afrdm.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/board/freescale/ls1012afrdm/ls1012afrdm.c
> b/board/freescale/ls1012afrdm/ls1012afrdm.c
> index 5db1027717..d149d489d5 100644
> --- a/board/freescale/ls1012afrdm/ls1012afrdm.c
> +++ b/board/freescale/ls1012afrdm/ls1012afrdm.c
> @@ -42,6 +42,7 @@ int checkboard(void)
> puts("Board: LS1012AFRDM ");
> #else
> int rev;
> + const char *b_name, *board;
>
> rev = get_board_version();
>
> @@ -60,6 +61,14 @@ int checkboard(void)
> puts(": unknown");
> break;
> }
> +
> + board = env_get("board");
> + if (strncmp(board, "ls1012afrwy", strlen("ls1012afrwy")) != 0)
> + env_set("board", "ls1012afrwy");
> +
> + b_name = env_get("board_name");
> + if (strncmp(b_name, "ls1012afrwy", strlen("ls1012afrwy")) != 0)
> + env_set("board_name", "ls1012afrwy");
> #endif
>
> return 0;
>
I don't see how you detect the board. You only check if the variables
were set. By the way, where do you use "board_name"?
York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] pci: layerscape: Add the dts fixup for EP and RC
On 10/25/18 7:01 PM, Xiaowei Bao wrote:
> Add the dts fixup when PCI controller work diffferent mode.
>
> Signed-off-by: Xiaowei Bao
> ---
> drivers/pci/pcie_layerscape_fixup.c | 25 +++--
> 1 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie_layerscape_fixup.c
> b/drivers/pci/pcie_layerscape_fixup.c
> index 1a17bd9..089e031 100644
> --- a/drivers/pci/pcie_layerscape_fixup.c
> +++ b/drivers/pci/pcie_layerscape_fixup.c
> @@ -218,7 +218,7 @@ static void fdt_fixup_pcie(void *blob)
> }
> #endif
>
> -static void ft_pcie_ls_setup(void *blob, struct ls_pcie *pcie)
> +static void ft_pcie_rc_fix(void *blob, struct ls_pcie *pcie)
> {
> int off;
> uint svr;
> @@ -243,12 +243,33 @@ static void ft_pcie_ls_setup(void *blob, struct ls_pcie
> *pcie)
> return;
> }
>
> - if (pcie->enabled)
> + if (pcie->enabled && pcie->mode == PCI_HEADER_TYPE_BRIDGE)
> + fdt_set_node_status(blob, off, FDT_STATUS_OKAY, 0);
> + else
> + fdt_set_node_status(blob, off, FDT_STATUS_DISABLED, 0);
> +}
> +
> +static void ft_pcie_ep_fix(void *blob, struct ls_pcie *pcie)
> +{
> + int off;
> +
> + off = fdt_node_offset_by_compat_reg(blob, "fsl,ls-pcie-ep",
> + pcie->dbi_res.start);
> + if (off < 0)
> + return;
> +
> + if (pcie->enabled && pcie->mode == PCI_HEADER_TYPE_NORMAL)
> fdt_set_node_status(blob, off, FDT_STATUS_OKAY, 0);
> else
> fdt_set_node_status(blob, off, FDT_STATUS_DISABLED, 0);
> }
>
> +static void ft_pcie_ls_setup(void *blob, struct ls_pcie *pcie)
> +{
> + ft_pcie_ep_fix(blob, pcie);
> + ft_pcie_rc_fix(blob, pcie);
> +}
Wouldn't it be faster to check the result of first call before entering
the second function? One cannot be both EP and RC, right?
York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] driver/spi: Add FSPI driver for NXP FlexSPI controller
On 9/25/18 1:41 AM, Ashish Kumar wrote: > Add nxp_fspi driver for NXP FlexSPI controller. > This driver supports both IP Mode read/write and > AHB mode READ. > > It supports Single Bit mode read along with Fast Read cmd support. > Octal bit mode is supported for read. > Multi CS are supported tested until 4. > > Signed-off-by: Suresh Gupta > Signed-off-by: Yogesh Gaur > Signed-off-by: Rajat Srivastava > Signed-off-by: Ashish Kumar > --- > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 10 + > drivers/spi/Kconfig |7 + > drivers/spi/Makefile |1 + > drivers/spi/nxp_fspi.c| 1088 + > drivers/spi/nxp_fspi.h| 422 > 5 files changed, 1528 insertions(+) > create mode 100644 drivers/spi/nxp_fspi.c > create mode 100644 drivers/spi/nxp_fspi.h Jagan, I don't see any comment on this patch. Please review. This patch blocks SoC and board patches in my queue. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Please pull u-boot-mpc85xx master
Tom, The following changes since commit 454cf76184c65426b68033a23da086e73663f2fc: Prepare v2018.11-rc3 (2018-10-29 16:04:26 -0400) are available in the Git repository at: git://git.denx.de/u-boot-mpc85xx.git tags/mpc85xx-for-v2018.11 for you to fetch changes up to db148f2a6938b47cf26c5fd11481e7462a6a793a: powerpc: t1040: Correct RCW EC2 settings (2018-10-29 13:19:43 -0700) Travis build log is https://travis-ci.org/yorksun/u-boot/builds/448003795 Workaround and bug fix for Freescale PowerPC Add workaround for Freescale USB erratum A005275. Correct RCW macros for T1080. Bin Meng (2): powerpc: t1040: Correct RCW MAC2_GMII_SEL value powerpc: t1040: Correct RCW EC2 settings Chris Packham (1): fsl/usb: Workaround for USB erratum-A005275 arch/powerpc/cpu/mpc85xx/Kconfig | 8 arch/powerpc/cpu/mpc85xx/cmd_errata.c | 4 arch/powerpc/include/asm/immap_85xx.h | 5 ++--- drivers/net/fm/t1040.c| 3 --- drivers/usb/common/fsl-errata.c | 28 drivers/usb/host/ehci-fsl.c | 7 +++ drivers/usb/host/ehci-hcd.c | 12 +++- drivers/usb/host/ehci.h | 4 include/fsl_usb.h | 1 + 9 files changed, 65 insertions(+), 7 deletions(-) Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL value
On 10/8/18 6:51 AM, Bin Meng wrote: > Per T1040RM (Rev. 1, 08/2015), the value of > FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT is wrong > and should be 0x0080 (bit 440 in the RCW). > > Signed-off-by: Bin Meng > --- This set is applied to u-boot-mpc85xx master, awaiting upstream. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] fsl/usb: Workaround for USB erratum-A005275
On 10/4/18 12:04 AM, Chris Packham wrote: > Workaround makes FS as default mode on all affected socs. > > Add support to check erratum-A005275 validity for an soc. This info is > required to determine whether a given soc is affected by this erratum. > Add quirk for this erratum "has_fsl_erratum_a005275" . This quirk is used > to enable workaround for the errata > > Force FS mode as default by: > - making EPS as FS > - setting PFSC bit to disable HS chirping > > This workaround can be disabled by mentioning "no_erratum_a005275" in > hwconfig string > > Signed-off-by: Chris Packham > --- > This is based on a patch form Freescale's public git repo[1]. I'm not > sure why it never made it upstream but I have P2041RDB boards that are > affected as well as custom designs using the same SoC. > > I've cleaned things up a bit to fit with the other errata. > > [1] - > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.freescale.com%2Fgit%2Fcgit.cgi%2Fppc%2Fsdk%2Fu-boot.git%2Fcommit%2F%3Fh%3Dsdk-v1.4.x%26id%3Df490f1e68af52c8fa68407d23a8ab77886b51106data=02%7C01%7Cyork.sun%40nxp.com%7C5a8f27ab9a234d619cf108d629c79312%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636742334476613659sdata=IbKJWdPgBx1SRMtdVwXjyISCtXBkcOoHEybGXwvByNM%3Dreserved=0 > > > Changes in v2: > - Fix compile error when using DM_USB (thanks Marek) Applied to u-boot-mpc85xx master, awaiting upstream. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL value
On 10/28/18 06:01, Bin Meng wrote: > On Thu, Oct 25, 2018 at 2:46 PM Poonam Aggrwal wrote: > > Thanks Poonam! > > York, I believe these 2 patches need be included in the v2018.11 release. > They are in my queue. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)
On 10/26/18 03:36, Rajat Srivastava wrote: > Spansion flashes (on our boards) support both 3-byte and 4-byte addressing > modes which needs active switching. What could be added to your patch is > already supported in SFDP method. SFDP also provides information about page > size, flash density, read/write/erase commands, etc, in addition to getting > information about address width supported by flash. > >> >>> The flashes on our >>> boards (and also other vendor's board) will not work with Stefan's >>> patch. >>> >>> My patch can handle flashes with address widths of 3-byte, 4-byte or >>> both. It also takes a more generic path (as opposed to supporting only >>> specific flash models) by parsing SFDP standard parameters and then >>> deciding what address width is to be used. >> >> I still don't see why each and every SPI controller driver needs to be >> extended to support this SFDP parameter reading. Can't this be handled by >> some generic (read common) code part in the SPI flash infrastructure? > > The generic (read common) code part in the SPI flash infrastructure also > lands on respective SPI drivers which ultimately sends the commands to flash. > Currently every SPI driver has support for basic read command (which is > called after "generic read common code") but no driver has support for SFDP > reading, which is what needs to be added. > Also, only the drivers that want to make use of SFDP needs to extend support > for SFDP parameter reading. > > I am reiterating that this is how SFDP parsing has been implemented in Linux > as well and this is the generic way. Driver support is absolutely required > because SPI framework cannot directly send any command to any flash. > It sounds like your difference is how to detect 4-byte addressing should be used. Stefan's method is from the flash chip side, to check status register. The benefit is to preserve setting before U-Boot. I am not sure if it is necessary to preserve previous setting though. Rajat's method is from the controller side, to read SFDP. It can support all flash chips I presume. I guess Stefan's method will not determine Rajat's flash as 4-byte addressing because it indeed supports both 3- and 4-byte. To make Rajat's method work on Stefan's board, SFDP needs to be extended to the controller driver Stefan uses, is that right? I also guess reading SFDP is controller-specific and cannot be done in a generic way. If the new feature is useful and can be gradually extended to other controllers, it sounds good to me. My guesses could wrong though. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Pull request: u-boot-net.git master
On 10/26/18 04:52, Tom Rini wrote: > This passed travis at the time, but now it fails on vf610twr for me: > https://travis-ci.org/trini/u-boot/jobs/446449322 so I've cc'd Alison if > there's anything we can easily turn off in the defconfig. But I'm also > cc'ing York since I thought I saw Alison say they didn't have the board > anymore? Should we mark it orphan? Drop it from CI for now and fully > soon? Or does someone else want to take it? > Alison, I don't see vf610twr anywhere. Can you find out if this board is still shipping or actively being used? York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 02/27] env: allow flash and nand env driver to compile together
On 10/12/18 07:45, Rajesh Bhagat wrote: > Define env_ptr as static in flash and nand env driver to > allow these to compile together. > > Signed-off-by: Rajesh Bhagat > --- > Change in v4: None > > Change in v3: > - Merged env nand specific patches to remove compilation warning > > Change in v2: None > > env/flash.c | 4 ++-- > env/nand.c| 6 ++ > include/environment.h | 1 - > 3 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/env/flash.c b/env/flash.c > index 32236c716e..33b199f05b 100644 > --- a/env/flash.c > +++ b/env/flash.c > @@ -45,13 +45,13 @@ DECLARE_GLOBAL_DATA_PTR; > #endif > > #ifdef ENV_IS_EMBEDDED > -env_t *env_ptr = > +static env_t *env_ptr = > > static __maybe_unused env_t *flash_addr = (env_t *)CONFIG_ENV_ADDR; > > #else /* ! ENV_IS_EMBEDDED */ > > -env_t *env_ptr = (env_t *)CONFIG_ENV_ADDR; > +static env_t *env_ptr = (env_t *)CONFIG_ENV_ADDR; > static __maybe_unused env_t *flash_addr = (env_t *)CONFIG_ENV_ADDR; > #endif /* ENV_IS_EMBEDDED */ > Compiling warning env_ptr defined but not used for boards mccmon6_sd and mccmon6_nor. Please check. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)
On 10/25/18 08:59, Stefan Roese wrote: > Hi York, > > On 25.10.18 17:49, York Sun wrote: >> Guys, >> >> Let get back to the original thread. Since Rajat's first reply, the >> message id has been changed. All the comments were not captured by >> patchwork. > > I also wondered about this. Seems to have happened at some top-posting > quite at the beginning of this thread. > I am having trouble recently with office365. It seems breaking all my email threads if senders use outlook. >> >> From what I read, Rajat's method is to extend the controller driver to >> support read SFDP and default to 4-byte mode if supported, or >> overwritten by user's flag. Stefan's method is to read 4-byte status bit >> and doesn't change controller driver. > > Yes, the last sentence it correct. > >> Is the default value of this 4-byte status bit valid and correct for all >> cases? > > This 4-byte address status bit implementation is SPI NOR chip > specific (vendor specific?). With Simon's help we already support > 2 vendors now. Extending for other vendors / chips is fairly > easy. Let's wait for Rajat's comment. If this method doesn't work for his boards or his controllers, he still needs to extend controller's driver feature. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 18/27] drivers: qe: add TFABOOT support
On 10/25/18 01:34, Rajesh Bhagat wrote: > > >> -Original Message----- >> From: York Sun >> Sent: Monday, October 22, 2018 9:55 PM >> To: Rajesh Bhagat ; u-boot@lists.denx.de >> Cc: Prabhakar Kushwaha ; Pankit Garg >> >> Subject: Re: [PATCH v4 18/27] drivers: qe: add TFABOOT support >> >> On 10/12/18 07:45, Rajesh Bhagat wrote: >>> Adds TFABOOT support and allows to pick QE firmware on basis of boot >>> source. >>> >>> Signed-off-by: Pankit Garg >>> Signed-off-by: Rajesh Bhagat >>> --- >>> Change in v4: None >>> >>> Change in v3: None >>> >>> Change in v2: >>> - Removed extra CONFIG_TFABOOT flag usage >>> >>> drivers/qe/qe.c | 81 >>> + >>> 1 file changed, 81 insertions(+) >>> >>> diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index >>> 7010bbc230..daefb5aa07 100644 >>> --- a/drivers/qe/qe.c >>> +++ b/drivers/qe/qe.c >>> @@ -17,9 +17,17 @@ >>> #include >>> #endif >>> >>> +#ifdef CONFIG_TFABOOT >>> +#include >>> +/* required to include IFC and QSPI base address */ #include >>> + #include #include >> >>> +#else >>> #ifdef CONFIG_SYS_QE_FMAN_FW_IN_MMC >>> #include >>> #endif >>> +#endif >>> >> >> >> Would there be any conflict if you drop the #ifdef here? No need to respin >> the >> patch set for this change. I can fix it for you if you confirm. >> > > AFAIR, there was some conflict. Shall I check it again. Please check. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)
Guys, Let get back to the original thread. Since Rajat's first reply, the message id has been changed. All the comments were not captured by patchwork. On 10/11/18 07:50, Stefan Roese wrote: > Some SPI NOR chips only support 4-byte mode addressing. Here the default > 3-byte mode does not work and leads to incorrect accesses. This patch > now reads the 4-byte mode status bit (in this case in the CR register > of the Macronix SPI NOR) and configures the SPI transfers accordingly. > > This was noticed on the LinkIt Smart 7688 modul, which is equipped with > an Macronix MX25L25635F device. But this device does *NOT* support > switching to 3-byte mode via the EX4B command. > > This should also work when the bootrom configures the SPI flash to > 4-byte mode and runs U-Boot after this. U-Boot should dectect this > mode (if the 4-byte mode detection is available for this chip) and > use the correct OPs in this case. From what I read, Rajat's method is to extend the controller driver to support read SFDP and default to 4-byte mode if supported, or overwritten by user's flag. Stefan's method is to read 4-byte status bit and doesn't change controller driver. Is the default value of this 4-byte status bit valid and correct for all cases? Rajat, without your patch set, does Stefan's solution work for your board? York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/27] TF-A Boot support for NXP Chassis 2 platforms
On 10/12/18 07:45, Rajesh Bhagat wrote: > Includes changes in u-boot framework to support TF-A for NXP Chassis 2 > platforms. A new defconfig is added namely ls*_tfa_defconfig which will > be used for all boot sources when TF-A is used. > > > > Tested on LS1043A, LS1046A and LS1012A platforms. > > Changes in v4: > - Changed order of patches to solve compilation issue and warning > - Added support for additional ls1012a boards > This version is pretty good. It is in my queue, waiting for merge window opens. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 18/27] drivers: qe: add TFABOOT support
On 10/12/18 07:45, Rajesh Bhagat wrote: > Adds TFABOOT support and allows to pick QE firmware > on basis of boot source. > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > Change in v4: None > > > Change in v3: None > > > > Change in v2: > > - Removed extra CONFIG_TFABOOT flag usage > > drivers/qe/qe.c | 81 + > 1 file changed, 81 insertions(+) > > diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c > index 7010bbc230..daefb5aa07 100644 > --- a/drivers/qe/qe.c > +++ b/drivers/qe/qe.c > @@ -17,9 +17,17 @@ > #include > #endif > > +#ifdef CONFIG_TFABOOT > +#include > +/* required to include IFC and QSPI base address */ > +#include > +#include > +#include > +#else > #ifdef CONFIG_SYS_QE_FMAN_FW_IN_MMC > #include > #endif > +#endif > Would there be any conflict if you drop the #ifdef here? No need to respin the patch set for this change. I can fix it for you if you confirm. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] watchdog: driver support for fsl-lsch2
On 10/16/18 20:06, Xiaoliang Yang wrote: > Hi York, > > The old version of this patch is: http://patchwork.ozlabs.org/patch/918957/ > There is a little mistake about LSCH3 not support for imx-watchdog in old > version patch, I have fixed it. > If there is a need to rewrite CONFIG_IMX_WATCHDOG to Kconfig file, I will > pull a new patch to do this. It doesn't affect this patch. Let's focus on this version. I see you are targeting lsch2. What you should have done was to update the revision number and add change log. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ls1012afrwy:update ls1012afrwy env board variable
On 10/10/2018 11:40 PM, Pramod Kumar wrote: > ls1012afrwy and ls1012afrdm both boards are varinat of ls1012a based > SoC board. > By default board and board_name uboot env variables are set as > ls1012afrdm. > whenever board is detected as ls1012afrwy, uboot env > variables are upadted to ls1012afrwy if it set as ls1012afrdm. Please reformat your subject and commit message, as described as https://www.denx.de/wiki/view/U-Boot/Patches#Commit_message_conventions York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH v3 25/26] armv8: ls1012aqds: Add TFABOOT support
On 10/09/2018 06:20 AM, Rajesh Bhagat wrote: > TFABOOT support includes: > - ls1012aqds_tfa_defconfig to be loaded by trusted firmware > - environment address and size changes for TFABOOT > - define BOOTCOMMAND for TFABOOT > > Signed-off-by: Rajesh Bhagat > Signed-off-by: Vinitha V Pillai > Signed-off-by: Pankit Garg > --- > Change in v3: > > - Added ls1012aqds_tfa_SECURE_BOOT_defconfig > > > > Change in v2: > > - Merged ls1012aqds TFA boot support patches > > - Removed extra CONFIG_TFABOOT flag usage > > board/freescale/ls1012aqds/ls1012aqds.c | 17 - > configs/ls1012aqds_tfa_SECURE_BOOT_defconfig | 65 > configs/ls1012aqds_tfa_defconfig | 62 +++ > 3 files changed, 141 insertions(+), 3 deletions(-) > create mode 100644 configs/ls1012aqds_tfa_SECURE_BOOT_defconfig > create mode 100644 configs/ls1012aqds_tfa_defconfig > Seeing compiling error for ls1012aqds_tfa_SECURE_BOOT. Please check. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH v3 24/26] armv8: ls1012ardb: Add TFABOOT support
On 10/09/2018 06:20 AM, Rajesh Bhagat wrote: > TFABOOT support includes: > - ls1012ardb_tfa_defconfig to be loaded by trusted firmware > - environment address and size changes for TFABOOT > - define BOOTCOMMAND for TFABOOT > > Signed-off-by: Rajesh Bhagat > Signed-off-by: Vinitha V Pillai > Signed-off-by: Pankit Garg > --- > Change in v3: > > - Added ls1012ardb_tfa_SECURE_BOOT_defconfig > > > > Change in v2: > > - Merged ls1012ardb TFA boot support patches > > - Removed extra CONFIG_TFABOOT flag usage > > board/freescale/ls1012ardb/ls1012ardb.c | 16 - > configs/ls1012ardb_tfa_SECURE_BOOT_defconfig | 62 > configs/ls1012ardb_tfa_defconfig | 56 ++ > include/configs/ls1012a_common.h | 16 - > include/configs/ls1012ardb.h | 6 ++ > 5 files changed, 154 insertions(+), 2 deletions(-) > create mode 100644 configs/ls1012ardb_tfa_SECURE_BOOT_defconfig > create mode 100644 configs/ls1012ardb_tfa_defconfig > Seeing this compiling warning for ls1012ardb_tfa_SECURE_BOOT ../include/netdev.h:127:41: warning: ?struct eth_device? declared inside parameter list will not be visible outside of this definition or declaration Please check. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/33] TF-A Boot support for NXP Chassis 2 platforms
On 10/07/2018 03:21 AM, Rajesh Bhagat wrote: > Includes changes in u-boot framework to support TF-A for NXP Chassis 2 > > platforms. A new defconfig is added namely ls*_ram_defconfig which will > > be used for all boot sources when TF-A is used. > > > > Tested on LS1043A, LS1046A and LS1012A platforms. > > Changes in v2: > - Patch subject and description changes > - Removed extra CONFIG_TFABOOT flag usage > - Merged board specific TFA boot support patches > > - Checked compilation using buildman tool for each commit Please check again. I see compiling warning on ls2080aqds_nand ls1046aqds_nand ls1043aqds_nand ls1043ardb_nand ls2080ardb_nand after patch #2, seems to be fix by patch #4. You may squash these two patches. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL value
On 10/08/2018 06:51 AM, Bin Meng wrote: > Per T1040RM (Rev. 1, 08/2015), the value of > FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT is wrong > and should be 0x0080 (bit 440 in the RCW). > > Signed-off-by: Bin Meng > --- Poonam, Please review and confirm on T1040. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 21/33] armv8: ls1046ardb: Add TFABOOT support
On 10/07/2018 03:22 AM, Rajesh Bhagat wrote: > TFABOOT support includes: > - ls1046ardb_tfa_defconfig to be loaded by trusted firmware > - environment address and size changes for TFABOOT > - FMAN address changes for TFABOOT > - define BOOTCOMMAND for TFABOOT > > Signed-off-by: York Sun > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > Change in v2: > - Merged ls1046ardb TFA boot support patches > - Removed extra CONFIG_TFABOOT flag usage > > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 7 > arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 9 +++-- > board/freescale/ls1046ardb/ddr.c | 12 ++ > configs/ls1046ardb_tfa_defconfig | 49 +++ > include/configs/ls1046a_common.h | 12 ++ > include/configs/ls1046ardb.h | 15 +++ > 6 files changed, 101 insertions(+), 3 deletions(-) > create mode 100644 configs/ls1046ardb_tfa_defconfig Separate changes to add TFABOOT and put it into a standalone patch. Leave the rest in this patch, and squash with patch #22. Do the same squash for every board, i.e. to keep on patch per board. This reduces the total number of compiling tests. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 10/33] armv8: layerscape: remove EL3 specific erratas for TFABOOT
On 10/07/2018 03:21 AM, Rajesh Bhagat wrote: > Removes EL3 specific erratas for TFABOOT, And now taken care in TFA. > > ARM_ERRATA_855873, SYS_FSL_ERRATUM_A008850, SYS_FSL_ERRATUM_A008511, > SYS_FSL_ERRATUM_A008336, SYS_FSL_ERRATUM_A009663, SYS_FSL_ERRATUM_A009803 > SYS_FSL_ERRATUM_A009942, SYS_FSL_ERRATUM_A010165 > > Signed-off-by: Rajesh Bhagat > --- > Change in v2: None > > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 24 +++ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > index f2111fadc0..1b84da5f66 100644 > --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > @@ -1,7 +1,7 @@ > config ARCH_LS1012A > bool > select ARMV8_SET_SMPEN > - select ARM_ERRATA_855873 > + select ARM_ERRATA_855873 if !TFABOOT > select FSL_LSCH2 > select SYS_FSL_SRDS_1 > select SYS_HAS_SERDES > @@ -22,22 +22,22 @@ config ARCH_LS1012A > config ARCH_LS1043A > bool > select ARMV8_SET_SMPEN > - select ARM_ERRATA_855873 > + select ARM_ERRATA_855873 if !TFABOOT This seems to be an error of reordering the patches. TFABOOT has not beed added at this point. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 01/33] move data structure out of cpu.h
On 10/07/2018 03:21 AM, Rajesh Bhagat wrote: > From: York Sun > > Move static definitions to cpu.c file, as it doesn't allow > the cpu.h file to be included in multiple c files. > > Signed-off-by: York Sun > --- > Change in v2: None > Rajesh, Did you send your patch set twice? I received two copies. The first one has Message-Id: <20181007095929.17876-2-rajesh.bha...@nxp.com>, sent on 7 Oct 2018 15:28:57 +0530. The second one has Message-Id: <20181007102131.19159-2-rajesh.bha...@nxp.com>, sent on 7 Oct 2018 15:50:59 +0530. You also sent two copies of your v1 patch. Please do not send more than one. If some error happened and you have to send them again, make sure you put "resend" in the subject to be easily identified. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 29/53] armv8: layerscape: add SMC calls for DDR size and bank info.
On 10/03/2018 04:39 AM, Rajesh Bhagat wrote: > From: Pankit Garg > > Adds SMC calls for getting DDR size and bank info for TFABOOT. This patch should be put before enabling TFA boot flow. I am going to stop here. Please fix and reorganize your patch set. Make sure U-Boot still works after every single patch. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 26/53] armv8: layerscape: remove EL3 specific erratas for TFABOOT
On 10/03/2018 04:39 AM, Rajesh Bhagat wrote: > Removes EL3 specific erratas for TFABOOT, And now taken care in TFA. > > ARM_ERRATA_855873, SYS_FSL_ERRATUM_A008850, SYS_FSL_ERRATUM_A008511, > SYS_FSL_ERRATUM_A008336, SYS_FSL_ERRATUM_A009663, SYS_FSL_ERRATUM_A009803 > SYS_FSL_ERRATUM_A009942, SYS_FSL_ERRATUM_A010165 > > Signed-off-by: Rajesh Bhagat > --- > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 24 +++ > 1 file changed, 12 insertions(+), 12 deletions(-) This patch should be put before any patch enabling TFABOOT. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 20/53] armv8: ls1046a: define BOOTCOMMAND for TFABOOT
On 10/03/2018 04:39 AM, Rajesh Bhagat wrote: > Defines BOOTCOMMAND for TFABOOT configuration for > supported boot sources. Please keep the commit message format consistent, to wrap back at or near 70th characters through the entire patch set. > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > include/configs/ls1046aqds.h | 9 + > include/configs/ls1046ardb.h | 7 +++ > 2 files changed, 16 insertions(+) > > diff --git a/include/configs/ls1046aqds.h b/include/configs/ls1046aqds.h > index 765a21e00f..2a30cef0e4 100644 > --- a/include/configs/ls1046aqds.h > +++ b/include/configs/ls1046aqds.h > @@ -432,6 +432,14 @@ unsigned long get_board_ddr_clk(void); > #define CONFIG_CMDLINE_TAG > > #undef CONFIG_BOOTCOMMAND > +#ifdef CONFIG_TFABOOT > +#define QSPI_NOR_BOOTCOMMAND "sf probe && sf read $kernel_load "\ > + "e f0 && bootm $kernel_load" > +#define IFC_NOR_BOOTCOMMAND "cp.b $kernel_start $kernel_load " \ > + "$kernel_size && bootm $kernel_load" > +#define SD_BOOTCOMMAND "mmc info; mmc read $kernel_load" \ > + "$kernel_addr_sd $kernel_size_sd && > bootm $kernel_load" > +#else > #if defined(CONFIG_QSPI_BOOT) || defined(CONFIG_SD_BOOT_QSPI) > #define CONFIG_BOOTCOMMAND "sf probe && sf read $kernel_load "\ > "e f0 && bootm $kernel_load" > @@ -439,6 +447,7 @@ unsigned long get_board_ddr_clk(void); > #define CONFIG_BOOTCOMMAND "cp.b $kernel_start $kernel_load " \ > "$kernel_size && bootm $kernel_load" > #endif > +#endif > > #include > > diff --git a/include/configs/ls1046ardb.h b/include/configs/ls1046ardb.h > index b8d9419b48..cc1f5f5f55 100644 > --- a/include/configs/ls1046ardb.h > +++ b/include/configs/ls1046ardb.h > @@ -216,6 +216,12 @@ > > #ifndef SPL_NO_MISC > #undef CONFIG_BOOTCOMMAND > +#ifdef CONFIG_TFABOOT > +#define QSPI_NOR_BOOTCOMMAND "run distro_bootcmd; run qspi_bootcmd; " > \ > +"env exists secureboot && esbc_halt;;" > +#define SD_BOOTCOMMAND "run distro_bootcmd;run sd_bootcmd; " \ > +"env exists secureboot && esbc_halt;" > +#else > #if defined(CONFIG_QSPI_BOOT) > #define CONFIG_BOOTCOMMAND "run distro_bootcmd; run qspi_bootcmd; " \ > "env exists secureboot && esbc_halt;;" > @@ -224,6 +230,7 @@ > "env exists secureboot && esbc_halt;" > #endif > #endif > +#endif > > #include > > Shouldn't this patch be put before patch #19? Did you compile each patch incrementally? York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 19/53] armv8: fsl-layerscape: bootcmd identification for TFABOOT.
First, remove the period in subject.
On 10/03/2018 04:39 AM, Rajesh Bhagat wrote:
> From: Pankit Garg
>
> Adds bootcmd identificaton on basis on boot source, valid
> in TFABOOT configuration.
>
> Signed-off-by: Rajesh Bhagat
> Signed-off-by: Pankit Garg
> ---
> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 69 +
> 1 file changed, 69 insertions(+)
>
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> index 3f15cb08ff..1e701c58df 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> @@ -679,12 +679,81 @@ int qspi_ahb_init(void)
> }
> #endif
>
> +#ifdef CONFIG_TFABOOT
> +#define MAX_BOOTCMD_SIZE 256
> +
> +int fsl_setenv_bootcmd(void)
> +{
> + int ret;
> + enum boot_src src = get_boot_src();
> + char bootcmd_str[MAX_BOOTCMD_SIZE];
> +
> + switch (src) {
> +#ifdef IFC_NOR_BOOTCOMMAND
> + case BOOT_SOURCE_IFC_NOR:
> + sprintf(bootcmd_str, IFC_NOR_BOOTCOMMAND);
> + break;
> +#endif
> +#ifdef QSPI_NOR_BOOTCOMMAND
> + case BOOT_SOURCE_QSPI_NOR:
> + sprintf(bootcmd_str, QSPI_NOR_BOOTCOMMAND);
> + break;
> +#endif
> +#ifdef XSPI_NOR_BOOTCOMMAND
> + case BOOT_SOURCE_XSPI_NOR:
> + sprintf(bootcmd_str, XSPI_NOR_BOOTCOMMAND);
> + break;
> +#endif
> +#ifdef IFC_NAND_BOOTCOMMAND
> + case BOOT_SOURCE_IFC_NAND:
> + sprintf(bootcmd_str, IFC_NAND_BOOTCOMMAND);
> + break;
> +#endif
> +#ifdef QSPI_NAND_BOOTCOMMAND
> + case BOOT_SOURCE_QSPI_NAND:
> + sprintf(bootcmd_str, QSPI_NAND_BOOTCOMMAND);
> + break;
> +#endif
> +#ifdef XSPI_NAND_BOOTCOMMAND
> + case BOOT_SOURCE_XSPI_NAND:
> + sprintf(bootcmd_str, XSPI_NAND_BOOTCOMMAND);
> + break;
> +#endif
> +#ifdef SD_BOOTCOMMAND
> + case BOOT_SOURCE_SD_MMC:
> + sprintf(bootcmd_str, SD_BOOTCOMMAND);
> + break;
> +#endif
> +#ifdef SD2_BOOTCOMMAND
> + case BOOT_SOURCE_SD_MMC2:
> + sprintf(bootcmd_str, SD2_BOOTCOMMAND);
> + break;
> +#endif
> + default:
> +#ifdef QSPI_NOR_BOOTCOMMAND
> + sprintf(bootcmd_str, QSPI_NOR_BOOTCOMMAND);
> +#endif
> + break;
> + }
> +
> + ret = env_set("bootcmd", bootcmd_str);
> + if (ret) {
> + printf("Failed to set bootcmd: ret = %d\n", ret);
> + return ret;
> + }
> + return 0;
> +}
> +#endif
> +
> #ifdef CONFIG_BOARD_LATE_INIT
> int board_late_init(void)
> {
> #ifdef CONFIG_CHAIN_OF_TRUST
> fsl_setenv_chain_of_trust();
> #endif
> +#ifdef CONFIG_TFABOOT
> + fsl_setenv_bootcmd();
> +#endif
> #ifdef CONFIG_QSPI_AHB_INIT
> qspi_ahb_init();
> #endif
>
Shouldn't you check if such variable is valid? I think you should not
overwrite this variable if user has already set it.
York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 18/53] armv8: ls1043a: make FMAN and QE address common
On 10/03/2018 04:39 AM, Rajesh Bhagat wrote: > CONFIG_SYS_FMAN_FW_ADDR and CONFIG_SYS_QE_FW_ADDR made common > to support all boot sources. > The subject implies you change something to make the macros common, but actually you only add common macros for TFABOOT. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 16/53] drivers: qe: add TFABOOT support
On 10/03/2018 04:39 AM, Rajesh Bhagat wrote: > Adds TFABOOT support and allows to pick QE firmware > on basis of boot source. > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > drivers/qe/qe.c | 81 + > 1 file changed, 81 insertions(+) > > diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c > index 7654df8008..d7e3a1b923 100644 > --- a/drivers/qe/qe.c > +++ b/drivers/qe/qe.c > @@ -17,9 +17,17 @@ > #include > #endif > > +#ifdef CONFIG_TFABOOT > +#include > +/* required to include IFC and QSPI base address */ > +#include > +#include > +#include > +#else You have many of this ifdef. Please fix all if you don't have to use ifdef. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 15/53] net: fm: add TFABOOT support
On 10/03/2018 04:39 AM, Rajesh Bhagat wrote: > Adds TFABOOT support and allows to pick FMAN firmware > on basis of boot source. > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > drivers/net/fm/fm.c | 104 > 1 file changed, 104 insertions(+) > > diff --git a/drivers/net/fm/fm.c b/drivers/net/fm/fm.c > index 3327073bf1..427ea1a627 100644 > --- a/drivers/net/fm/fm.c > +++ b/drivers/net/fm/fm.c > @@ -11,6 +11,15 @@ > #include "fm.h" > #include /* For struct qe_firmware */ > > +#ifdef CONFIG_TFABOOT Same here. Do not use ifdef if you don't have to. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 13/53] armv8: ls1043aqds: define environment address for QSPI boot
On 10/03/2018 04:38 AM, Rajesh Bhagat wrote: > Defines environment address for QSPI boot > > Signed-off-by: Rajesh Bhagat > --- > board/freescale/ls1043aqds/ls1043aqds.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/board/freescale/ls1043aqds/ls1043aqds.c > b/board/freescale/ls1043aqds/ls1043aqds.c > index 5247d9ac14..1f317a4574 100644 > --- a/board/freescale/ls1043aqds/ls1043aqds.c > +++ b/board/freescale/ls1043aqds/ls1043aqds.c > @@ -13,6 +13,9 @@ > #include > #include > #include > +#ifdef CONFIG_TFABOOT Do you have to use ifdef here? > +#include > +#endif York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 10/53] armv8: ls1043ardb: Add TFABOOT defconfig
On 10/03/2018 04:38 AM, Rajesh Bhagat wrote: > This defconfig is for TFABOOT, to be loaded by trusted firmware. > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > board/freescale/ls1043ardb/ddr.c| 6 ++- > board/freescale/ls1043ardb/ls1043ardb.c | 12 ++ > configs/ls1043ardb_ram_defconfig| 49 + In this and other patches, you said "add TFABOOT defconfig", but you use "ram_defconfig" in the file name. If this boot method is only for TFA boot, maybe you should consider to rename the file. If the ram boot can work without TFA, you need to rewrite your commit subject and message. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 09/53] armv8: ls1046a: make environment address and size common
On 10/03/2018 04:38 AM, Rajesh Bhagat wrote: > CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE and CONFIG_ENV_SECT_SIZE made common > to support all boot sources. It is not clear how you made these macros common in your change below. > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > include/configs/ls1046aqds.h | 9 + > include/configs/ls1046ardb.h | 8 > 2 files changed, 17 insertions(+) > > diff --git a/include/configs/ls1046aqds.h b/include/configs/ls1046aqds.h > index 07e21469c8..765a21e00f 100644 > --- a/include/configs/ls1046aqds.h > +++ b/include/configs/ls1046aqds.h > @@ -403,6 +403,14 @@ unsigned long get_board_ddr_clk(void); > */ > #define CONFIG_ENV_OVERWRITE > > +#ifdef CONFIG_TFABOOT > +#define CONFIG_SYS_MMC_ENV_DEV 0 > + > +#define CONFIG_ENV_SIZE 0x2000 > +#define CONFIG_ENV_OFFSET0x50/* 5MB */ > +#define CONFIG_ENV_ADDR (CONFIG_SYS_FLASH_BASE + > 0x50) > +#define CONFIG_ENV_SECT_SIZE 0x2 > +#else > #ifdef CONFIG_NAND_BOOT > #define CONFIG_ENV_SIZE 0x2000 > #define CONFIG_ENV_OFFSET(12 * CONFIG_SYS_NAND_BLOCK_SIZE) > @@ -419,6 +427,7 @@ unsigned long get_board_ddr_clk(void); > #define CONFIG_ENV_SECT_SIZE 0x2 > #define CONFIG_ENV_SIZE 0x2 > #endif > +#endif > > #define CONFIG_CMDLINE_TAG > > diff --git a/include/configs/ls1046ardb.h b/include/configs/ls1046ardb.h > index ffca410b1a..b8d9419b48 100644 > --- a/include/configs/ls1046ardb.h > +++ b/include/configs/ls1046ardb.h > @@ -160,6 +160,13 @@ > #define CONFIG_ENV_OVERWRITE > #endif > > +#ifdef CONFIG_TFABOOT > +#define CONFIG_SYS_MMC_ENV_DEV 0 > + > +#define CONFIG_ENV_SIZE 0x2000 /* 8KB */ > +#define CONFIG_ENV_OFFSET0x50/* 5MB */ > +#define CONFIG_ENV_SECT_SIZE 0x4 /* 256KB */ > +#else > #if defined(CONFIG_SD_BOOT) > #define CONFIG_SYS_MMC_ENV_DEV 0 > #define CONFIG_ENV_OFFSET(3 * 1024 * 1024) > @@ -169,6 +176,7 @@ > #define CONFIG_ENV_OFFSET0x30/* 3MB */ > #define CONFIG_ENV_SECT_SIZE 0x4 /* 256KB */ > #endif > +#endif > > #define AQR105_IRQ_MASK 0x8000 > /* FMan */ > You didn't add to common file, or move them out. How do you make them common? York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 07/53] armv8: ls1046ardb: Add TFABOOT defconfig
On 10/03/2018 04:38 AM, Rajesh Bhagat wrote: > This defconfig is for TFABOOT, to be loaded by trusted firmware. > > Signed-off-by: York Sun > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 9 +++-- These changes are better moved into patch #5. > board/freescale/ls1046ardb/ddr.c| 3 +- > configs/ls1046ardb_ram_defconfig| 49 + > include/configs/ls1046a_common.h| 4 ++ > 4 files changed, 61 insertions(+), 4 deletions(-) > create mode 100644 configs/ls1046ardb_ram_defconfig York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 03/18] armv8: ls1043ardb: Enable GPIO driver
On 08/22/2018 06:15 PM, ying.zhang22...@nxp.com wrote: > From: Zhang Ying-22455 > > Signed-off-by: Zhang Ying-22455 > --- > configs/ls1043ardb_SECURE_BOOT_defconfig| 2 ++ > configs/ls1043ardb_defconfig| 2 ++ > configs/ls1043ardb_nand_SECURE_BOOT_defconfig | 2 ++ > configs/ls1043ardb_nand_defconfig | 2 ++ > configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig | 2 ++ > configs/ls1043ardb_sdcard_defconfig | 2 ++ > 6 files changed, 12 insertions(+) > > diff --git a/configs/ls1043ardb_SECURE_BOOT_defconfig > b/configs/ls1043ardb_SECURE_BOOT_defconfig > index 478fdc8..44b8702 100644 > --- a/configs/ls1043ardb_SECURE_BOOT_defconfig > +++ b/configs/ls1043ardb_SECURE_BOOT_defconfig > @@ -44,3 +44,5 @@ CONFIG_USB_STORAGE=y > CONFIG_RSA=y > CONFIG_SPL_RSA=y > CONFIG_RSA_SOFTWARE_EXP=y > +CONFIG_DM_GPIO=y > +CONFIG_MPC8XXX_GPIO=y > diff --git a/configs/ls1043ardb_defconfig b/configs/ls1043ardb_defconfig > index c308882..4ee6346 100644 > --- a/configs/ls1043ardb_defconfig > +++ b/configs/ls1043ardb_defconfig > @@ -42,3 +42,5 @@ CONFIG_DM_USB=y > CONFIG_USB_XHCI_HCD=y > CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_STORAGE=y > +CONFIG_DM_GPIO=y > +CONFIG_MPC8XXX_GPIO=y > diff --git a/configs/ls1043ardb_nand_SECURE_BOOT_defconfig > b/configs/ls1043ardb_nand_SECURE_BOOT_defconfig > index ec90e48..496f646 100644 > --- a/configs/ls1043ardb_nand_SECURE_BOOT_defconfig > +++ b/configs/ls1043ardb_nand_SECURE_BOOT_defconfig > @@ -61,3 +61,5 @@ CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_STORAGE=y > CONFIG_RSA=y > CONFIG_SPL_RSA=y > +CONFIG_DM_GPIO=y > +CONFIG_MPC8XXX_GPIO=y > diff --git a/configs/ls1043ardb_nand_defconfig > b/configs/ls1043ardb_nand_defconfig > index 04d2934..413ef56 100644 > --- a/configs/ls1043ardb_nand_defconfig > +++ b/configs/ls1043ardb_nand_defconfig > @@ -59,3 +59,5 @@ CONFIG_DM_USB=y > CONFIG_USB_XHCI_HCD=y > CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_STORAGE=y > +CONFIG_DM_GPIO=y > +CONFIG_MPC8XXX_GPIO=y > diff --git a/configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig > b/configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig > index 4bce1a9..0e8e088 100644 > --- a/configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig > +++ b/configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig > @@ -60,3 +60,5 @@ CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_STORAGE=y > CONFIG_RSA=y > CONFIG_SPL_RSA=y > +CONFIG_DM_GPIO=y > +CONFIG_MPC8XXX_GPIO=y > diff --git a/configs/ls1043ardb_sdcard_defconfig > b/configs/ls1043ardb_sdcard_defconfig > index 09ff4c3..05c73c4 100644 > --- a/configs/ls1043ardb_sdcard_defconfig > +++ b/configs/ls1043ardb_sdcard_defconfig > @@ -57,3 +57,5 @@ CONFIG_DM_USB=y > CONFIG_USB_XHCI_HCD=y > CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_STORAGE=y > +CONFIG_DM_GPIO=y > +CONFIG_MPC8XXX_GPIO=y > Please keep the config option sorted. You can use tools/moveconfig.py. This applies to all your patches to defconfig. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 15/18] armv8: ls1088a: add i2c entry
On 08/22/2018 06:15 PM, ying.zhang22...@nxp.com wrote:
> From: Zhang Ying-22455
>
> Signed-off-by: Zhang Ying-22455
> ---
> arch/arm/dts/fsl-ls1088a-qds.dts | 57
>
> arch/arm/dts/fsl-ls1088a-rdb.dts | 40
> arch/arm/dts/fsl-ls1088a.dtsi| 55 ++
> 3 files changed, 152 insertions(+)
>
> diff --git a/arch/arm/dts/fsl-ls1088a-qds.dts
> b/arch/arm/dts/fsl-ls1088a-qds.dts
> index 36116f7..3913621 100644
> --- a/arch/arm/dts/fsl-ls1088a-qds.dts
> +++ b/arch/arm/dts/fsl-ls1088a-qds.dts
> @@ -18,6 +18,63 @@
> };
> };
>
> + {
> + status = "okay";
> +
> + i2c-switch@77 {
> + compatible = "nxp,pca9547";
> + reg = <0x77>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x2>;
> +
> + ina220@40 {
> + compatible = "ti,ina220";
> + reg = <0x40>;
> + shunt-resistor = <1000>;
> + };
> +
> + ina220@41 {
> + compatible = "ti,ina220";
> + reg = <0x41>;
> + shunt-resistor = <1000>;
> + };
> + };
> +
> + i2c@3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x3>;
> +
> + temp-sensor@4c {
> + compatible = "adi,adt7461a";
> + reg = <0x4c>;
> + };
> +
> + rtc@51 {
> + compatible = "nxp,pcf2129";
> + reg = <0x51>;
> + /* IRQ10_B */
> + interrupts = <0 150 4>;
> + };
> +
> + eeprom@56 {
> + compatible = "atmel,24c512";
> + reg = <0x56>;
> + };
> +
> + eeprom@57 {
> + compatible = "atmel,24c512";
> + reg = <0x57>;
> + };
> + };
> + };
> +};
> +
> {
> #address-cells = <2>;
> #size-cells = <1>;
> diff --git a/arch/arm/dts/fsl-ls1088a-rdb.dts
> b/arch/arm/dts/fsl-ls1088a-rdb.dts
> index 0be3f8d..6eb0560 100644
> --- a/arch/arm/dts/fsl-ls1088a-rdb.dts
> +++ b/arch/arm/dts/fsl-ls1088a-rdb.dts
> @@ -17,6 +17,46 @@
> };
> };
>
> + {
> + status = "okay";
> +
> + i2c-switch@77 {
> + compatible = "nxp,pca9547";
> + reg = <0x77>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x2>;
> +
> + ina220@40 {
> + compatible = "ti,ina220";
> + reg = <0x40>;
> + shunt-resistor = <1000>;
> + };
> + };
> +
> + i2c@3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x3>;
> +
> + temp-sensor@4c {
> + compatible = "adi,adt7461a";
> + reg = <0x4c>;
> + };
> +
> + rtc@51 {
> + compatible = "nxp,pcf2129";
> + reg = <0x51>;
> + /* IRQ10_B */
> + interrupts = <0 150 4>;
> + };
> + };
> + };
> +};
> {
> bus-num = <0>;
> status = "okay";
> diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi
> index acc63be..7178b68 100644
> --- a/arch/arm/dts/fsl-ls1088a.dtsi
> +++ b/arch/arm/dts/fsl-ls1088a.dtsi
> @@ -26,6 +26,13 @@
> interrupts = <1 9 0x4>;
> };
>
> + sysclk: sysclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <1>;
> + clock-output-names = "sysclk";
> +};
You have space instead of tab here.
> +
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
> @@ -34,6 +41,54 @@
><1 10 0x8>; /* Hypervisor PPI, active-low */
> };
>
> +
You have extra blank line here.
Did you run checkpatch?
York
___
U-Boot mailing list
Re: [U-Boot] [PATCH 01/18] gpio: mpc8xxx: add support for Layerscape SoC
On 08/22/2018 06:15 PM, ying.zhang22...@nxp.com wrote: > From: Zhang Ying-22455 > > * Add mpc8xxx_gpio_plat for for Layerscape SoC > * Make the mpc8xxx driver capable of handling Layerscape Soc. > > Signed-off-by: Zhang Ying-22455 > --- > arch/arm/include/asm/arch-fsl-layerscape/gpio.h| 24 > ++ > .../include/asm/arch-fsl-layerscape/immap_lsch2.h | 2 ++ > arch/arm/include/asm/arch-ls102xa/gpio.h | 6 ++ > drivers/gpio/mpc8xxx_gpio.c| 1 + > 4 files changed, 33 insertions(+) > create mode 100644 arch/arm/include/asm/arch-fsl-layerscape/gpio.h > > diff --git a/arch/arm/include/asm/arch-fsl-layerscape/gpio.h > b/arch/arm/include/asm/arch-fsl-layerscape/gpio.h > new file mode 100644 > index 000..b6afcaa > --- /dev/null > +++ b/arch/arm/include/asm/arch-fsl-layerscape/gpio.h > @@ -0,0 +1,24 @@ > +/* > + * Copyright 2008-2016 Freescale Semiconductor, Inc. > + * Copyright 2017-2018 NXP Semiconductor > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ > + Please use the new SPDX format. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 01/18] gpio: mpc8xxx: add support for Layerscape SoC
On 08/22/2018 06:15 PM, ying.zhang22...@nxp.com wrote:
> From: Zhang Ying-22455
>
> * Add mpc8xxx_gpio_plat for for Layerscape SoC
> * Make the mpc8xxx driver capable of handling Layerscape Soc.
>
> Signed-off-by: Zhang Ying-22455
> ---
> arch/arm/include/asm/arch-fsl-layerscape/gpio.h| 24
> ++
> .../include/asm/arch-fsl-layerscape/immap_lsch2.h | 2 ++
> arch/arm/include/asm/arch-ls102xa/gpio.h | 6 ++
> drivers/gpio/mpc8xxx_gpio.c| 1 +
> 4 files changed, 33 insertions(+)
> create mode 100644 arch/arm/include/asm/arch-fsl-layerscape/gpio.h
>
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/gpio.h
> b/arch/arm/include/asm/arch-fsl-layerscape/gpio.h
> new file mode 100644
> index 000..b6afcaa
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/gpio.h
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright 2008-2016 Freescale Semiconductor, Inc.
> + * Copyright 2017-2018 NXP Semiconductor
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */
> +
> +#ifndef _ASM_ARCH_LAYERSCAPE_GPIO_H_
> +#define _ASM_ARCH_LAYERSCAPE_GPIO_H_
> +
> +#ifdef CONFIG_FSL_LSCH2
> +#include
> +#endif
> +#ifdef CONFIG_FSL_LSCH3
> +#include
> +#endif
> +
> +struct mpc8xxx_gpio_plat {
> + ulong addr;
> + unsigned long size;
> + uint ngpios;
> +};
> +
> +#endif
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> index be0a6ae..18f6875 100644
> --- a/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/immap_lsch2.h
> @@ -650,6 +650,7 @@ struct ccsr_serdes {
> u8 res_19a0[0x2000-0x19a0];/* from 0x19a0 to 0x1fff */
> };
>
> +#ifndef CONFIG_MPC8XXX_GPIO
> struct ccsr_gpio {
> u32 gpdir;
> u32 gpodr;
> @@ -659,6 +660,7 @@ struct ccsr_gpio {
> u32 gpicr;
> u32 gpibe;
> };
> +#endif
Why do you need to keep this code?
York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/8] powerpc/dts: Define '_end' symbol in mpc85xx U-Boot lds files
On 09/02/2018 10:08 PM, Jagdish Gediya wrote: > 'board_fdt_blob_setup' function sets up fdt blob at '&_end' so > define '_end' symbol in mpc85xx lds files. > > Signed-off-by: Jagdish Gediya > --- > Changes for v2: > - Define '_end' symbol in lds file instead of defining new > 'board_fdt_blob_setup' function using existing '_init_end' symbol. > > Changes for v3: > - Define '_end' symbol in spl lds files too. > This patch set has been applied to mpc85xx master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/2] qe: Kconfig: Move CONFIG_U_QE to Kconfig
On 09/25/2018 10:46 PM, Ran Wang wrote: > This patch moves CONFIG_U_QE to Kconfig > > Signed-off-by: Ran Wang > --- > Change in v3: > - Combine 1/3 and 2/3 patch of v2 > - Remove unnecessary space in front of U-QE in drivers/qe/Kconfig > - Remove CONFIG_U_QE in scripts/config_whitelist.txt > > Change in v2: > Add more conditional define to support more platforms. > This patch set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [v3 patch] net: fman: Support both new and legacy FMan Compatibles
On 08/28/2018 08:49 PM, Zhao Qiang wrote: > Recently the FMan Port and MAC compatibles were changed. > This patch aligns the FMan Port and MAC compatibles > to the new FMan device tree binding document. > The FMan device tree binding document can be found in the Linux > kernel: > version 3.18.0 > commit 297d35fd2a7d3fbd4e5c0f0c1c18213117ba11ba > ./Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > This patch doesn't affect legacy compatibles support. > > Signed-off-by: Zhao Qiang > --- > Changes for v2 > - add kernel version and commit id modifing the binding > Changes for v3 > - put "fsl,fman-xgec" before "fsl,fman-tgec" > - because it use the former in latest kernel version > Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ls2080ardb: remove dhcp function from env as boot source
On 09/17/2018 10:29 PM, Priyanka Jain wrote: > Signed-off-by: Priyanka Jain > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ls1088a: remove dhcp function from u-boot env as boot source
On 09/14/2018 04:24 AM, Pramod Kumar wrote: > Signed-off-by: Pramod Kumar > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ls1012a: remove debug info from u-boot log.
On 09/12/2018 01:46 AM, Pramod Kumar wrote: > Signed-off-by: Pramod Kumar > --- Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] armv8: fsl-layerscape: add missing qe base address define
On 08/27/2018 07:34 AM, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Add define for quiccengine register block base address. > > Signed-off-by: Laurentiu Tudor > --- This patch set is applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH][v3] driver: net: fsl-mc: Memset MC reserve ram memory before usage
On 08/27/2018 12:29 AM, Prabhakar Kushwaha wrote: > It is required to clean Management Complex reserve memory before any > usage. > So memset MC reserve memory. > > Signed-off-by: Prabhakar Kushwaha > --- > Changes for v2: > - updated patch subject > - Consider case of dpl apply and mc_boot failure > Changes for v3 > - updated mc_boot failure case for more clarity > > Applied to fsl-qoriq master, awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
