Re: [PATCH] binman: bintool: Change make target arg type from string to list
On Wed, 4 Oct 2023 at 02:56, wrote: > > From: Lukas Funke > > The argument type of `build_from_git` was changed from string to list > in d71e7116997f14097735f04cc7847f0a68dbc485. > > This commit adapts the argument type of all bintools using this > function. > > Signed-off-by: Lukas Funke > > --- > > tools/binman/btool/bootgen.py | 2 +- > tools/binman/btool/fiptool.py | 2 +- > tools/binman/btool/futility.py | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass Tested-by: Simon Glass Thank you. Can you please resolve the test-coverage issue, too? It is the one line in the whole of binman with no coverage. If it is not needed, we can delete the line, perhaps? tools/binman/etype/xilinx_bootgen.py 72 199% The offending line is 216: data = tools.read_file(bootbin_fname) Regards, Simon Applied to u-boot-dm, thanks!
Re: [PATCH] binman: bintool: Change make target arg type from string to list
On Wed, 4 Oct 2023 at 02:56, wrote: > > From: Lukas Funke > > The argument type of `build_from_git` was changed from string to list > in d71e7116997f14097735f04cc7847f0a68dbc485. > > This commit adapts the argument type of all bintools using this > function. > > Signed-off-by: Lukas Funke > > --- > > tools/binman/btool/bootgen.py | 2 +- > tools/binman/btool/fiptool.py | 2 +- > tools/binman/btool/futility.py | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass Tested-by: Simon Glass Thank you. Can you please resolve the test-coverage issue, too? It is the one line in the whole of binman with no coverage. If it is not needed, we can delete the line, perhaps? tools/binman/etype/xilinx_bootgen.py 72 199% The offending line is 216: data = tools.read_file(bootbin_fname) Regards, Simon
[PATCH] binman: bintool: Change make target arg type from string to list
From: Lukas Funke The argument type of `build_from_git` was changed from string to list in d71e7116997f14097735f04cc7847f0a68dbc485. This commit adapts the argument type of all bintools using this function. Signed-off-by: Lukas Funke --- tools/binman/btool/bootgen.py | 2 +- tools/binman/btool/fiptool.py | 2 +- tools/binman/btool/futility.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/binman/btool/bootgen.py b/tools/binman/btool/bootgen.py index f2ca552dc2..1bc9f0aa96 100644 --- a/tools/binman/btool/bootgen.py +++ b/tools/binman/btool/bootgen.py @@ -132,6 +132,6 @@ class Bintoolbootgen(bintool.Bintool): result = self.build_from_git( 'https://github.com/Xilinx/bootgen', -'all', +['all'], 'bootgen') return result diff --git a/tools/binman/btool/fiptool.py b/tools/binman/btool/fiptool.py index c80f8275c4..34002f54af 100644 --- a/tools/binman/btool/fiptool.py +++ b/tools/binman/btool/fiptool.py @@ -109,6 +109,6 @@ class Bintoolfiptool(bintool.Bintool): return None result = self.build_from_git( 'https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git', -'fiptool', +['fiptool'], 'tools/fiptool/fiptool') return result diff --git a/tools/binman/btool/futility.py b/tools/binman/btool/futility.py index 04c9aefe9b..0d3980d071 100644 --- a/tools/binman/btool/futility.py +++ b/tools/binman/btool/futility.py @@ -170,7 +170,7 @@ class Bintoolfutility(bintool.Bintool): # .gitcookies file. So use a mirror instead. result = self.build_from_git( 'https://github.com/sjg20/vboot_reference.git', -'all', +['all'], 'build/futility/futility', flags=['USE_FLASHROM=0']) return result -- 2.30.2
