Re: [PATCH] cmd: net: nfs: Enable the NFS command by default

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 12:04:12PM +0530, Tejas Bhumkar wrote:

> Activated the default use of NFS command for booting
> images via network using the NFS protocol.
> 
> Signed-off-by: Tejas Bhumkar 
> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index df6d71c103..a51b2d532f 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1905,6 +1905,7 @@ config CMD_RARP
>  
>  config CMD_NFS
>   bool "nfs"
> + default y
>   help
> Boot image via network using NFS protocol.

NAK, this is basically a revert of:
commit 10de1257079905ac383e7abf346a04221cafa620
Author: Peter Robinson 
Date:   Wed Jun 14 15:41:10 2023 +0100

disable NFS support by default

While NFS is widely used in data centres, and private
networks it's quite a nuanced usecase for device firmware.
A lot of devices already disable it.

Various network protocols should really be opt in, not opt
out, because they add extra size and are potential attack
vectors from a security PoV. In the NFS case it doesn't
really make sense for a lot of devices like tables, SBCs etc.
It's also something we don't really want for SystemReady-IR
due to security concerns.

Signed-off-by: Peter Robinson 
Reviewed-by: Tom Rini 
Reviewed-by: Ilias Apalodimas 

So please enable this in the configs that you need this enabled in by
default, thanks.

-- 
Tom


signature.asc
Description: PGP signature


[PATCH] cmd: net: nfs: Enable the NFS command by default

2023-12-27 Thread Tejas Bhumkar
Activated the default use of NFS command for booting
images via network using the NFS protocol.

Signed-off-by: Tejas Bhumkar 
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index df6d71c103..a51b2d532f 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1905,6 +1905,7 @@ config CMD_RARP
 
 config CMD_NFS
bool "nfs"
+   default y
help
  Boot image via network using NFS protocol.
 
-- 
2.27.0