Hi Udit,
Subject: Re: [PATCH] dma: ti: k3-udma: Fix ring_idx to pair k3 nav
rings"
Trailing quote in the subject
On Feb 21, 2024 at 12:58:25 +0530, Udit Kumar wrote:
> ring_idx was not correctly assigned in case of tflow_id is zero.
> Which leads to wrong pairing of DMA for drivers like OSPI.
>
> Fixes: 4312a1dfca26 ("dma: ti: k3-udma: Use ring_idx to pair k3 nav rings")
> Signed-off-by: Udit Kumar
With the subject change,
Reviewed-by: Jai Luthra
> ---
> drivers/dma/ti/k3-udma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index eea9ec9659..398668 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -884,10 +884,10 @@ static int udma_alloc_tx_resources(struct udma_chan *uc)
> return ret;
>
> tchan = uc->tchan;
> - if (tchan->tflow_id >= 0)
> + if (tchan->tflow_id > 0)
> ring_idx = tchan->tflow_id;
> else
> - ring_idx = ud->bchan_cnt + tchan->id;
> + ring_idx = tchan->id;
>
> ret = k3_nav_ringacc_request_rings_pair(ud->ringacc, ring_idx, -1,
> >tchan->t_ring,
> --
> 2.34.1
>
--
Thanks,
Jai
GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145
signature.asc
Description: PGP signature
