Re: [PATCH] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells

[Marek Vasut]

On 10/18/23 19:21, Fabio Estevam wrote:

From: Fabio Estevam 

Pass #address-cells/size-cells in the mdio node to avoid the following
DTC warning:

   DTCOarch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo
Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length 
(4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default 
#address-cells value
Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default 
#size-cells value

Signed-off-by: Fabio Estevam 
---
  arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts | 11 +--
  1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts 
b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
index f27e6429ab..94bee3c508 100644
--- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
+++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
@@ -5,6 +5,13 @@
  /dts-v1/;
  /plugin/;
  
- {

-   reg = <7>;
+ {
+   mdio {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   ethphy0g: ethernet-phy@7 {


I think the ethphy0g: label shouldn't be needed, in fact it would 
override whatever label is already in the base DT. So please drop that 
one. With that fixed:


Reviewed-by: Marek Vasut 

[PATCH] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells

[Fabio Estevam]

From: Fabio Estevam 

Pass #address-cells/size-cells in the mdio node to avoid the following
DTC warning:

  DTCOarch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo
Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length 
(4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default 
#address-cells value
Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default 
#size-cells value

Signed-off-by: Fabio Estevam 
---
 arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts 
b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
index f27e6429ab..94bee3c508 100644
--- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
+++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts
@@ -5,6 +5,13 @@
 /dts-v1/;
 /plugin/;
 
- {
-   reg = <7>;
+ {
+   mdio {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   ethphy0g: ethernet-phy@7 {
+   reg = <7>;
+   };
+   };
 };
-- 
2.34.1