Re: [PATCH] mtd: nand: complete nand_register() arguments check

2023-11-13 Thread Michael Nazzareno Trimarchi
On Thu, Nov 2, 2023 at 12:27 PM Dario Binacchi
 wrote:
>
> The patch checks that the "mtd" parameter is accessible before
> proceeding.
>
> Signed-off-by: Dario Binacchi 
>
> ---
>
>  drivers/mtd/nand/raw/nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/nand.c b/drivers/mtd/nand/raw/nand.c
> index eacd99c4e275..d31bb580c46a 100644
> --- a/drivers/mtd/nand/raw/nand.c
> +++ b/drivers/mtd/nand/raw/nand.c
> @@ -52,7 +52,7 @@ int nand_mtd_to_devnum(struct mtd_info *mtd)
>  /* Register an initialized NAND mtd device with the U-Boot NAND command. */
>  int nand_register(int devnum, struct mtd_info *mtd)
>  {
> -   if (devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
> +   if (!mtd || devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
> return -EINVAL;
>
> nand_info[devnum] = mtd;
> --
> 2.42.0
>

Reviewed-by: Michael Trimarchi 


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com


[PATCH] mtd: nand: complete nand_register() arguments check

2023-11-02 Thread Dario Binacchi
The patch checks that the "mtd" parameter is accessible before
proceeding.

Signed-off-by: Dario Binacchi 

---

 drivers/mtd/nand/raw/nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/nand.c b/drivers/mtd/nand/raw/nand.c
index eacd99c4e275..d31bb580c46a 100644
--- a/drivers/mtd/nand/raw/nand.c
+++ b/drivers/mtd/nand/raw/nand.c
@@ -52,7 +52,7 @@ int nand_mtd_to_devnum(struct mtd_info *mtd)
 /* Register an initialized NAND mtd device with the U-Boot NAND command. */
 int nand_register(int devnum, struct mtd_info *mtd)
 {
-   if (devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
+   if (!mtd || devnum >= CONFIG_SYS_MAX_NAND_DEVICE)
return -EINVAL;
 
nand_info[devnum] = mtd;
-- 
2.42.0