Re: [PATCH] net: phy: the NC-SI phy device do not require mdio bus
On Mon, Jan 15, 2024 at 06:34:47PM +0800, Jacky Chou wrote: > As with fixed-link phy device, the NC-SI phy devive does not > require an mdio bus. So, a condition is added to check the > NC-SI phy id to avoid accessing the bus pointer that is NULL. > > Signed-off-by: Jacky Chou Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature
[PATCH] net: phy: the NC-SI phy device do not require mdio bus
As with fixed-link phy device, the NC-SI phy devive does not require an mdio bus. So, a condition is added to check the NC-SI phy id to avoid accessing the bus pointer that is NULL. Signed-off-by: Jacky Chou --- drivers/net/phy/phy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 63b3e46f10..9991d86037 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -566,7 +566,8 @@ struct phy_device *phy_device_create(struct mii_dev *bus, int addr, return NULL; } - if (addr >= 0 && addr < PHY_MAX_ADDR && phy_id != PHY_FIXED_ID) + if (addr >= 0 && addr < PHY_MAX_ADDR && phy_id != PHY_FIXED_ID && + phy_id != PHY_NCSI_ID) bus->phymap[addr] = dev; return dev; -- 2.34.1
Re: [PATCH] net: phy: the NC-SI phy device do not require mdio bus
On 1/15/24 11:34, Jacky Chou wrote: As with fixed-link phy device, the NC-SI phy devive does not require an mdio bus. So, a condition is added to check the NC-SI phy id to avoid accessing the bus pointer that is NULL. Signed-off-by: Jacky Chou Reviewed-by: Marek Vasut Thanks !
