Re: [PATCH] nvme: Remove the redundant aqa value setting
On Wed, Jun 23, 2021 at 5:14 PM Bin Meng wrote: > > On Tue, Jun 22, 2021 at 11:35 AM Wesley Sheng wrote: > > > > From: Wesley Sheng > > > > AQA (Admin Queue Attributes) register is a dword size with > > lower word of ASQS, and higher word of ACQS. > > > > The code set the variable aqa twice, but it is redundant. > > > > Signed-off-by: Wesley Sheng > > --- > > drivers/nvme/nvme.c | 1 - > > 1 file changed, 1 deletion(-) > > > > Reviewed-by: Bin Meng applied to u-boot-x86, thanks!
Re: [PATCH] nvme: Remove the redundant aqa value setting
On Tue, Jun 22, 2021 at 11:35 AM Wesley Sheng wrote: > > From: Wesley Sheng > > AQA (Admin Queue Attributes) register is a dword size with > lower word of ASQS, and higher word of ACQS. > > The code set the variable aqa twice, but it is redundant. > > Signed-off-by: Wesley Sheng > --- > drivers/nvme/nvme.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng
[PATCH] nvme: Remove the redundant aqa value setting
From: Wesley Sheng AQA (Admin Queue Attributes) register is a dword size with lower word of ASQS, and higher word of ACQS. The code set the variable aqa twice, but it is redundant. Signed-off-by: Wesley Sheng --- drivers/nvme/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index fc64d93ab8..a062234163 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -379,7 +379,6 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev) aqa = nvmeq->q_depth - 1; aqa |= aqa << 16; - aqa |= aqa << 16; dev->page_size = 1 << page_shift; -- 2.25.1
Re: [PATCH] nvme: Remove the redundant aqa value setting
On Wed, Jun 16, 2021 at 12:09 PM Wesley Sheng wrote: > > From: wesleywesley > > AQA (Admin Queue Attributes) register is a dword size with > lower word of ASQS, and higher word of ACQS. > > The code set the variable aqa twice, but it is redundant. > > Signed-off-by: wesleywesley > --- > drivers/nvme/nvme.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng
[PATCH] nvme: Remove the redundant aqa value setting
From: wesleywesley AQA (Admin Queue Attributes) register is a dword size with lower word of ASQS, and higher word of ACQS. The code set the variable aqa twice, but it is redundant. Signed-off-by: wesleywesley --- drivers/nvme/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index fc64d93ab8..a062234163 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -379,7 +379,6 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev) aqa = nvmeq->q_depth - 1; aqa |= aqa << 16; - aqa |= aqa << 16; dev->page_size = 1 << page_shift; -- 2.25.1
