Re: [PATCH] remoteproc: uclass: Clean up a return

[Tom Rini]

On Wed, Jul 26, 2023 at 10:00:33AM +0300, Dan Carpenter wrote:

> We know that "pa" is non-NULL so it's nicer to just return zero instead
> of return !pa.  This has no effect on runtime behavior.
> 
> Signed-off-by: Dan Carpenter 
> Reviewed-by: Simon Glass 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH] remoteproc: uclass: Clean up a return

[Simon Glass]

On Wed, 26 Jul 2023 at 10:50, Dan Carpenter  wrote:
>
> We know that "pa" is non-NULL so it's nicer to just return zero instead
> of return !pa.  This has no effect on runtime behavior.
>
> Signed-off-by: Dan Carpenter 
> ---
>  drivers/remoteproc/rproc-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass 

[PATCH] remoteproc: uclass: Clean up a return

[Dan Carpenter]

We know that "pa" is non-NULL so it's nicer to just return zero instead
of return !pa.  This has no effect on runtime behavior.

Signed-off-by: Dan Carpenter 
---
 drivers/remoteproc/rproc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/rproc-uclass.c 
b/drivers/remoteproc/rproc-uclass.c
index 50bcc9030e98..19fe4053be81 100644
--- a/drivers/remoteproc/rproc-uclass.c
+++ b/drivers/remoteproc/rproc-uclass.c
@@ -689,7 +689,7 @@ static int alloc_vring(struct udevice *dev, struct 
fw_rsc_vdev *rsc, int i)
debug("alloc_mem(%#x, %d): %p\n", size, order, pa);
vring->da = (uintptr_t)pa;
 
-   return !pa;
+   return 0;
 }
 
 static int handle_vdev(struct udevice *dev, struct fw_rsc_vdev *rsc,
-- 
2.39.2