Re: [Uboot-stm32] [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter

2020-08-13 Thread Patrice CHOTARD 

On 8/3/20 9:37 AM, Patrice CHOTARD wrote:
> On 7/31/20 7:47 PM, Marek Vasut wrote:
>> On 7/31/20 9:45 AM, Patrice Chotard wrote:
>>> node varaible is used as iterator into ofnode_for_each_subnode()
>>> loop, when exiting of it, node is no more a valid ofnode.
>>> Use dwc3_node instead as parameter of ofnode_valid()
>>>
>>> Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
>> Looks OK to me, feel free to pick it via ST tree.

Applied on u-boot-stm/master

Thanks

> Ok thanks
>
> Patrice
> ___
> Uboot-stm32 mailing list
> uboot-st...@st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32

Re: [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter

2020-08-03 Thread Patrice CHOTARD 

On 7/31/20 7:47 PM, Marek Vasut wrote:
> On 7/31/20 9:45 AM, Patrice Chotard wrote:
>> node varaible is used as iterator into ofnode_for_each_subnode()
>> loop, when exiting of it, node is no more a valid ofnode.
>> Use dwc3_node instead as parameter of ofnode_valid()
>>
>> Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
> Looks OK to me, feel free to pick it via ST tree.

Ok thanks

Patrice

Re: [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter

2020-07-31 Thread Marek Vasut 
On 7/31/20 9:45 AM, Patrice Chotard wrote:
> node varaible is used as iterator into ofnode_for_each_subnode()
> loop, when exiting of it, node is no more a valid ofnode.
> Use dwc3_node instead as parameter of ofnode_valid()
> 
> Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")

Looks OK to me, feel free to pick it via ST tree.

[RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter

2020-07-31 Thread Patrice Chotard 
node varaible is used as iterator into ofnode_for_each_subnode()
loop, when exiting of it, node is no more a valid ofnode.
Use dwc3_node instead as parameter of ofnode_valid()

Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
Signed-off-by: Patrice Chotard 
Cc: Kever Yang 
---

 drivers/usb/host/dwc3-sti-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/dwc3-sti-glue.c b/drivers/usb/host/dwc3-sti-glue.c
index a72ab20168..3e6c1429d6 100644
--- a/drivers/usb/host/dwc3-sti-glue.c
+++ b/drivers/usb/host/dwc3-sti-glue.c
@@ -159,7 +159,7 @@ static int sti_dwc3_glue_bind(struct udevice *dev)
dwc3_node = node;
}
 
-   if (!ofnode_valid(node)) {
+   if (!ofnode_valid(dwc3_node)) {
pr_err("Can't find dwc3 subnode for %s\n", dev->name);
return -ENODEV;
}
-- 
2.17.1

Re: [PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter

2020-07-28 Thread Patrice CHOTARD 
Hi

Just a gentle reminder as this patch is present on mailing list since 2 months.

Regards

Patrice

On 6/29/20 11:26 AM, Patrice Chotard wrote:
> node varaible is used as iterator into ofnode_for_each_subnode()
> loop, when exiting of it, node is no more a valid ofnode.
> Use dwc3_node instead as parameter of ofnode_valid()
>
> Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
> Signed-off-by: Patrice Chotard 
> ---
>
>  drivers/usb/host/dwc3-sti-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/dwc3-sti-glue.c 
> b/drivers/usb/host/dwc3-sti-glue.c
> index a72ab20168..3e6c1429d6 100644
> --- a/drivers/usb/host/dwc3-sti-glue.c
> +++ b/drivers/usb/host/dwc3-sti-glue.c
> @@ -159,7 +159,7 @@ static int sti_dwc3_glue_bind(struct udevice *dev)
>   dwc3_node = node;
>   }
>  
> - if (!ofnode_valid(node)) {
> + if (!ofnode_valid(dwc3_node)) {
>   pr_err("Can't find dwc3 subnode for %s\n", dev->name);
>   return -ENODEV;
>   }

[PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter

2020-06-29 Thread Patrice Chotard 
node varaible is used as iterator into ofnode_for_each_subnode()
loop, when exiting of it, node is no more a valid ofnode.
Use dwc3_node instead as parameter of ofnode_valid()

Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
Signed-off-by: Patrice Chotard 
---

 drivers/usb/host/dwc3-sti-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/dwc3-sti-glue.c b/drivers/usb/host/dwc3-sti-glue.c
index a72ab20168..3e6c1429d6 100644
--- a/drivers/usb/host/dwc3-sti-glue.c
+++ b/drivers/usb/host/dwc3-sti-glue.c
@@ -159,7 +159,7 @@ static int sti_dwc3_glue_bind(struct udevice *dev)
dwc3_node = node;
}
 
-   if (!ofnode_valid(node)) {
+   if (!ofnode_valid(dwc3_node)) {
pr_err("Can't find dwc3 subnode for %s\n", dev->name);
return -ENODEV;
}
-- 
2.17.1