Re: [PATCH] x86: Revert "x86: minnowmax: Adjust CONFIG_TEXT_BASE"

2023-03-10 Thread Simon Glass
Hi Bin,

On Sun, 5 Feb 2023 at 19:35, Bin Meng  wrote:
>
> Hi Simon,
>
> On Mon, Feb 6, 2023 at 8:54 AM Simon Glass  wrote:
> >
> > This causes Minnowmax to stop booting. I am not sure why though.
> >
> > Drop the EFI_LOADER feature instead, since it is not needed.
> >
> > This reverts commit 66e2c665f3b60d726e1c26ad44ac97aa76ead6f5.
> >
> > Signed-off-by: Simon Glass 
> > ---
> >
> >  configs/minnowmax_defconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
> This is weird. Can you do some debugging?

I think I got to the bottom of it. I sent a v2.

Regards,
Simon


Re: [PATCH] x86: Revert "x86: minnowmax: Adjust CONFIG_TEXT_BASE"

2023-02-05 Thread Bin Meng
Hi Simon,

On Mon, Feb 6, 2023 at 8:54 AM Simon Glass  wrote:
>
> This causes Minnowmax to stop booting. I am not sure why though.
>
> Drop the EFI_LOADER feature instead, since it is not needed.
>
> This reverts commit 66e2c665f3b60d726e1c26ad44ac97aa76ead6f5.
>
> Signed-off-by: Simon Glass 
> ---
>
>  configs/minnowmax_defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

This is weird. Can you do some debugging?

Regards,
Bin


[PATCH] x86: Revert "x86: minnowmax: Adjust CONFIG_TEXT_BASE"

2023-02-05 Thread Simon Glass
This causes Minnowmax to stop booting. I am not sure why though.

Drop the EFI_LOADER feature instead, since it is not needed.

This reverts commit 66e2c665f3b60d726e1c26ad44ac97aa76ead6f5.

Signed-off-by: Simon Glass 
---

 configs/minnowmax_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 679b6e3de53..0d7f55a651f 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -1,5 +1,5 @@
 CONFIG_X86=y
-CONFIG_TEXT_BASE=0xFFE0
+CONFIG_TEXT_BASE=0xFFF0
 CONFIG_NR_DRAM_BANKS=8
 CONFIG_ENV_SIZE=0x1000
 CONFIG_ENV_OFFSET=0x6EF000
@@ -74,3 +74,4 @@ CONFIG_VIDEO_COPY=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_GENERATE_ACPI_TABLE=y
 # CONFIG_GZIP is not set
+# CONFIG_EFI_LOADER is not set
-- 
2.39.1.519.gcb327c4b5f-goog