Re: [PATCH] x86: Update docs link in bootparam header
On 09/07/2023 02:47, Heinrich Schuchardt wrote: On 7/7/23 17:41, Tom Rini wrote: On Fri, Jul 07, 2023 at 07:51:42AM +0100, Paul Barker wrote: After Linux commit ff61f0791ce9, x86 documentation was moved to arch/x86 and the link in bootparam.h was broken. Signed-off-by: Paul Barker --- arch/x86/include/asm/bootparam.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/bootparam.h b/arch/x86/include/asm/bootparam.h index ea816ca74698..1f8ca569b880 100644 --- a/arch/x86/include/asm/bootparam.h +++ b/arch/x86/include/asm/bootparam.h @@ -62,7 +62,7 @@ struct setup_indirect { /** * struct setup_header - Information needed by Linux to boot * - * See https://www.kernel.org/doc/html/latest/x86/boot.html + * See https://docs.kernel.org/arch/x86/boot.html This is also now: https://www.kernel.org/doc/html/latest/arch/x86/boot.html And tree-wide we have two examples of docs.kernel.org and the rest are www.kernel.org/doc/html/latest for the base. We should be consistent here, so I'm deferring to Heinrich. In Linux' /Documentation/ they always uses https://www.kernel.org/doc/html/latest. So let's stick to this. Ok, I'll send a v2. Thanks, Paul
Re: [PATCH] x86: Update docs link in bootparam header
On 7/7/23 17:41, Tom Rini wrote: On Fri, Jul 07, 2023 at 07:51:42AM +0100, Paul Barker wrote: After Linux commit ff61f0791ce9, x86 documentation was moved to arch/x86 and the link in bootparam.h was broken. Signed-off-by: Paul Barker --- arch/x86/include/asm/bootparam.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/bootparam.h b/arch/x86/include/asm/bootparam.h index ea816ca74698..1f8ca569b880 100644 --- a/arch/x86/include/asm/bootparam.h +++ b/arch/x86/include/asm/bootparam.h @@ -62,7 +62,7 @@ struct setup_indirect { /** * struct setup_header - Information needed by Linux to boot * - * See https://www.kernel.org/doc/html/latest/x86/boot.html + * See https://docs.kernel.org/arch/x86/boot.html This is also now: https://www.kernel.org/doc/html/latest/arch/x86/boot.html And tree-wide we have two examples of docs.kernel.org and the rest are www.kernel.org/doc/html/latest for the base. We should be consistent here, so I'm deferring to Heinrich. In Linux' /Documentation/ they always uses https://www.kernel.org/doc/html/latest. So let's stick to this. Best regards Heinrich
Re: [PATCH] x86: Update docs link in bootparam header
On Fri, Jul 07, 2023 at 07:51:42AM +0100, Paul Barker wrote: > After Linux commit ff61f0791ce9, x86 documentation was moved to > arch/x86 and the link in bootparam.h was broken. > > Signed-off-by: Paul Barker > --- > arch/x86/include/asm/bootparam.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/bootparam.h > b/arch/x86/include/asm/bootparam.h > index ea816ca74698..1f8ca569b880 100644 > --- a/arch/x86/include/asm/bootparam.h > +++ b/arch/x86/include/asm/bootparam.h > @@ -62,7 +62,7 @@ struct setup_indirect { > /** > * struct setup_header - Information needed by Linux to boot > * > - * See https://www.kernel.org/doc/html/latest/x86/boot.html > + * See https://docs.kernel.org/arch/x86/boot.html This is also now: https://www.kernel.org/doc/html/latest/arch/x86/boot.html And tree-wide we have two examples of docs.kernel.org and the rest are www.kernel.org/doc/html/latest for the base. We should be consistent here, so I'm deferring to Heinrich. -- Tom signature.asc Description: PGP signature
[PATCH] x86: Update docs link in bootparam header
After Linux commit ff61f0791ce9, x86 documentation was moved to arch/x86 and the link in bootparam.h was broken. Signed-off-by: Paul Barker --- arch/x86/include/asm/bootparam.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/bootparam.h b/arch/x86/include/asm/bootparam.h index ea816ca74698..1f8ca569b880 100644 --- a/arch/x86/include/asm/bootparam.h +++ b/arch/x86/include/asm/bootparam.h @@ -62,7 +62,7 @@ struct setup_indirect { /** * struct setup_header - Information needed by Linux to boot * - * See https://www.kernel.org/doc/html/latest/x86/boot.html + * See https://docs.kernel.org/arch/x86/boot.html */ struct setup_header { __u8setup_sects; base-commit: 923de765ee1a5b26310f02cb42dcbad9e2b011c5 -- 2.34.1