Re: [PATCH 0/2] qcom: ehci: enable core + iface clocks
On Thu, May 2, 2024 at 3:41 PM Caleb Connolly wrote: > > Hi Sam, > > On 02/05/2024 15:16, Sam Day wrote: > > These clocks are mandatory, as can be seen in msm_hsusb driver in the > > Linux kernel. > > > > The appropriate HS_USB AHB/SYSTEM clocks were added to gcc_apq8016. > > > > Technically there's other adjacent SoC families that can use the > > msm_hsusb driver with different clocks, but only msm8916/apq8016 are > > currently making use of it so I think this change shouldn't break > > anything elsewhere. > > Thanks for the patches. I have a feeling this might break IPQ4019, you > might need to stub the clks there (cc Robert). Hi, IPQ4019 does not use ehci-msm, but rather DWC3 so it should be fine. Regards, Robert > > Seems like the To: and Cc: addresses aren't all quite right still. > > > > Signed-off-by: Sam Day > > --- > > Sam Day (2): > >clk/qcom: apq8016: add support for USB_HS clocks > >ehci: msm: bring up iface + core clocks > > > > drivers/clk/qcom/clock-apq8016.c | 31 +++ > > drivers/usb/host/ehci-msm.c | 37 > > +++-- > > 2 files changed, 66 insertions(+), 2 deletions(-) > > --- > > base-commit: ff0de1f0557ed7d2dab47ba976a37347a1fdc432 > > change-id: 20240502-msm8916-hs-usb-clocks-34bc22b03f3d > > > > Best regards, > > -- > // Caleb (they/them) -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 1 Zagreb, Croatia Email: robert.ma...@sartura.hr Web: www.sartura.hr
Re: [PATCH 0/2] qcom: ehci: enable core + iface clocks
Hi Sam, On 02/05/2024 15:16, Sam Day wrote: These clocks are mandatory, as can be seen in msm_hsusb driver in the Linux kernel. The appropriate HS_USB AHB/SYSTEM clocks were added to gcc_apq8016. Technically there's other adjacent SoC families that can use the msm_hsusb driver with different clocks, but only msm8916/apq8016 are currently making use of it so I think this change shouldn't break anything elsewhere. Thanks for the patches. I have a feeling this might break IPQ4019, you might need to stub the clks there (cc Robert). Seems like the To: and Cc: addresses aren't all quite right still. Signed-off-by: Sam Day --- Sam Day (2): clk/qcom: apq8016: add support for USB_HS clocks ehci: msm: bring up iface + core clocks drivers/clk/qcom/clock-apq8016.c | 31 +++ drivers/usb/host/ehci-msm.c | 37 +++-- 2 files changed, 66 insertions(+), 2 deletions(-) --- base-commit: ff0de1f0557ed7d2dab47ba976a37347a1fdc432 change-id: 20240502-msm8916-hs-usb-clocks-34bc22b03f3d Best regards, -- // Caleb (they/them)
[PATCH 0/2] qcom: ehci: enable core + iface clocks
These clocks are mandatory, as can be seen in msm_hsusb driver in the Linux kernel. The appropriate HS_USB AHB/SYSTEM clocks were added to gcc_apq8016. Technically there's other adjacent SoC families that can use the msm_hsusb driver with different clocks, but only msm8916/apq8016 are currently making use of it so I think this change shouldn't break anything elsewhere. Signed-off-by: Sam Day --- Sam Day (2): clk/qcom: apq8016: add support for USB_HS clocks ehci: msm: bring up iface + core clocks drivers/clk/qcom/clock-apq8016.c | 31 +++ drivers/usb/host/ehci-msm.c | 37 +++-- 2 files changed, 66 insertions(+), 2 deletions(-) --- base-commit: ff0de1f0557ed7d2dab47ba976a37347a1fdc432 change-id: 20240502-msm8916-hs-usb-clocks-34bc22b03f3d Best regards, -- Sam Day
