Re: [PATCH 0/3] test/py: Rewrite SquashFS commands test suite
Hi, Le 24/05/2021 à 04:31, Joao Marcos Costa a écrit : Hello, This patch series fixes the following issues: - poor strategy to check if files were properly loaded - wrong quoting style for strings - tests failing at the second run because of a wrong clean-up strategy Finally, it improves: - code overall documentation level, with more comments and better naming for functions and variables - code readability by adding more helper functions - completeness: more test cases were added for both sqfsls and sqfsload commands The sqfsload new test suite may fail when testing images with fragmented files if the patch I previously sent (fs/squashfs: fix reading of fragmented files) is not applied, so this patch series depends on it. Best regards, Joao Joao Marcos Costa (3): test/py: rewrite common tools for SquashFS tests test/py: rewrite sqfsload command test suite test/py: rewrite sqfsls command test suite .../test_fs/test_squashfs/sqfs_common.py | 198 -- .../test_fs/test_squashfs/test_sqfs_load.py | 99 ++--- .../test_fs/test_squashfs/test_sqfs_ls.py | 80 +-- 3 files changed, 264 insertions(+), 113 deletions(-) Tested-by: Richard Genoud Thanks !
[PATCH 0/3] test/py: Rewrite SquashFS commands test suite
Hello, This patch series fixes the following issues: - poor strategy to check if files were properly loaded - wrong quoting style for strings - tests failing at the second run because of a wrong clean-up strategy Finally, it improves: - code overall documentation level, with more comments and better naming for functions and variables - code readability by adding more helper functions - completeness: more test cases were added for both sqfsls and sqfsload commands The sqfsload new test suite may fail when testing images with fragmented files if the patch I previously sent (fs/squashfs: fix reading of fragmented files) is not applied, so this patch series depends on it. Best regards, Joao Joao Marcos Costa (3): test/py: rewrite common tools for SquashFS tests test/py: rewrite sqfsload command test suite test/py: rewrite sqfsls command test suite .../test_fs/test_squashfs/sqfs_common.py | 198 -- .../test_fs/test_squashfs/test_sqfs_load.py | 99 ++--- .../test_fs/test_squashfs/test_sqfs_ls.py | 80 +-- 3 files changed, 264 insertions(+), 113 deletions(-) -- 2.25.1
