Re: [PATCH 0/5] Convert the LS208xA RDB/QDS boards to DM_SERIAL

2023-02-28 Thread Peng Fan

Hi Ioana,

Thanks for working on this.

On 3/1/2023 12:32 AM, Ioana Ciornei wrote:

This patch set converts the LS208xA based boards to DM_SERIAL.

Since we don't want to introduce even more differences between the
U-Boot's and Linux's device trees the first 4 patches make the necessary
updates so that the serial nodes are synced with their counterpart.

The last patch just enables DM_SERIAL in the associated configs.


LGTM: Reviewed-by: Peng Fan 

Thanks,
Peng.



Ioana Ciornei (5):
   arch: arm: dst: fsl-ls2080a.dtsi: add an 'soc' node
   arch: arm: dst: fsl-ls2080a.dtsi: move the serial nodes under soc
   arch: arm: dst: fsl-ls2080a.dts: sync serial nodes with Linux
   arch: arm: dst: fsl-ls2080a.dts: tag serial nodes with bootph-all
   configs: ls208x: enable DM_SERIAL

  arch/arm/dts/fsl-ls2080a.dtsi| 57 +++-
  configs/ls2088aqds_tfa_defconfig |  5 +-
  configs/ls2088ardb_tfa_SECURE_BOOT_defconfig |  4 +-
  configs/ls2088ardb_tfa_defconfig |  4 +-
  4 files changed, 53 insertions(+), 17 deletions(-)



Re: [PATCH 0/5] Convert the LS208xA RDB/QDS boards to DM_SERIAL

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 06:47:04PM +0200, Ioana Ciornei wrote:
> On Tue, Feb 28, 2023 at 11:40:15AM -0500, Tom Rini wrote:
> > On Tue, Feb 28, 2023 at 06:32:07PM +0200, Ioana Ciornei wrote:
> > > This patch set converts the LS208xA based boards to DM_SERIAL.
> > > 
> > > Since we don't want to introduce even more differences between the
> > > U-Boot's and Linux's device trees the first 4 patches make the necessary
> > > updates so that the serial nodes are synced with their counterpart.
> > > 
> > > The last patch just enables DM_SERIAL in the associated configs.
> > > 
> > > Ioana Ciornei (5):
> > >   arch: arm: dst: fsl-ls2080a.dtsi: add an 'soc' node
> > >   arch: arm: dst: fsl-ls2080a.dtsi: move the serial nodes under soc
> > >   arch: arm: dst: fsl-ls2080a.dts: sync serial nodes with Linux
> > >   arch: arm: dst: fsl-ls2080a.dts: tag serial nodes with bootph-all
> > >   configs: ls208x: enable DM_SERIAL
> > > 
> > >  arch/arm/dts/fsl-ls2080a.dtsi| 57 +++-
> > >  configs/ls2088aqds_tfa_defconfig |  5 +-
> > >  configs/ls2088ardb_tfa_SECURE_BOOT_defconfig |  4 +-
> > >  configs/ls2088ardb_tfa_defconfig |  4 +-
> > >  4 files changed, 53 insertions(+), 17 deletions(-)
> > 
> > This is good to see.  My main question is, can we do a more complete
> > sync with the upstream dts files?
> > 
> 
> Sure, that would be the plan. Not in this patch set though.

OK. It is future work I would very much like to see, thanks.

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH 0/5] Convert the LS208xA RDB/QDS boards to DM_SERIAL

2023-02-28 Thread Ioana Ciornei
On Tue, Feb 28, 2023 at 11:40:15AM -0500, Tom Rini wrote:
> On Tue, Feb 28, 2023 at 06:32:07PM +0200, Ioana Ciornei wrote:
> > This patch set converts the LS208xA based boards to DM_SERIAL.
> > 
> > Since we don't want to introduce even more differences between the
> > U-Boot's and Linux's device trees the first 4 patches make the necessary
> > updates so that the serial nodes are synced with their counterpart.
> > 
> > The last patch just enables DM_SERIAL in the associated configs.
> > 
> > Ioana Ciornei (5):
> >   arch: arm: dst: fsl-ls2080a.dtsi: add an 'soc' node
> >   arch: arm: dst: fsl-ls2080a.dtsi: move the serial nodes under soc
> >   arch: arm: dst: fsl-ls2080a.dts: sync serial nodes with Linux
> >   arch: arm: dst: fsl-ls2080a.dts: tag serial nodes with bootph-all
> >   configs: ls208x: enable DM_SERIAL
> > 
> >  arch/arm/dts/fsl-ls2080a.dtsi| 57 +++-
> >  configs/ls2088aqds_tfa_defconfig |  5 +-
> >  configs/ls2088ardb_tfa_SECURE_BOOT_defconfig |  4 +-
> >  configs/ls2088ardb_tfa_defconfig |  4 +-
> >  4 files changed, 53 insertions(+), 17 deletions(-)
> 
> This is good to see.  My main question is, can we do a more complete
> sync with the upstream dts files?
> 

Sure, that would be the plan. Not in this patch set though.

Ioana


Re: [PATCH 0/5] Convert the LS208xA RDB/QDS boards to DM_SERIAL

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 06:32:07PM +0200, Ioana Ciornei wrote:
> This patch set converts the LS208xA based boards to DM_SERIAL.
> 
> Since we don't want to introduce even more differences between the
> U-Boot's and Linux's device trees the first 4 patches make the necessary
> updates so that the serial nodes are synced with their counterpart.
> 
> The last patch just enables DM_SERIAL in the associated configs.
> 
> Ioana Ciornei (5):
>   arch: arm: dst: fsl-ls2080a.dtsi: add an 'soc' node
>   arch: arm: dst: fsl-ls2080a.dtsi: move the serial nodes under soc
>   arch: arm: dst: fsl-ls2080a.dts: sync serial nodes with Linux
>   arch: arm: dst: fsl-ls2080a.dts: tag serial nodes with bootph-all
>   configs: ls208x: enable DM_SERIAL
> 
>  arch/arm/dts/fsl-ls2080a.dtsi| 57 +++-
>  configs/ls2088aqds_tfa_defconfig |  5 +-
>  configs/ls2088ardb_tfa_SECURE_BOOT_defconfig |  4 +-
>  configs/ls2088ardb_tfa_defconfig |  4 +-
>  4 files changed, 53 insertions(+), 17 deletions(-)

This is good to see.  My main question is, can we do a more complete
sync with the upstream dts files?

-- 
Tom


signature.asc
Description: PGP signature


[PATCH 0/5] Convert the LS208xA RDB/QDS boards to DM_SERIAL

2023-02-28 Thread Ioana Ciornei
This patch set converts the LS208xA based boards to DM_SERIAL.

Since we don't want to introduce even more differences between the
U-Boot's and Linux's device trees the first 4 patches make the necessary
updates so that the serial nodes are synced with their counterpart.

The last patch just enables DM_SERIAL in the associated configs.

Ioana Ciornei (5):
  arch: arm: dst: fsl-ls2080a.dtsi: add an 'soc' node
  arch: arm: dst: fsl-ls2080a.dtsi: move the serial nodes under soc
  arch: arm: dst: fsl-ls2080a.dts: sync serial nodes with Linux
  arch: arm: dst: fsl-ls2080a.dts: tag serial nodes with bootph-all
  configs: ls208x: enable DM_SERIAL

 arch/arm/dts/fsl-ls2080a.dtsi| 57 +++-
 configs/ls2088aqds_tfa_defconfig |  5 +-
 configs/ls2088ardb_tfa_SECURE_BOOT_defconfig |  4 +-
 configs/ls2088ardb_tfa_defconfig |  4 +-
 4 files changed, 53 insertions(+), 17 deletions(-)

-- 
2.25.1