Re: [PATCH 00/15] nand: Add sandbox tests

2023-11-09 Thread Dario Binacchi
Sean, All

On Sat, Nov 4, 2023 at 8:46 PM Sean Anderson  wrote:
>
> On 11/2/23 10:18, Dario Binacchi wrote:
> > On Thu, Nov 2, 2023 at 3:13 PM Sean Anderson  wrote:
> >>
> >> On 11/2/23 10:08, Dario Binacchi wrote:
> >>> On Thu, Nov 2, 2023 at 3:06 PM Sean Anderson  wrote:
> 
>  On 11/2/23 10:01, Dario Binacchi wrote:
> > Sean, All,
> >
> > On Sun, Oct 29, 2023 at 4:48 AM Sean Anderson  wrote:
> >>
> >> This series tests raw nand flash in sandbox and fixes various bugs 
> >> discovered in
> >> the process. I've tried to do things in a contemporary manner, 
> >> avoiding the
> >> (numerous) variations present on only a few boards. The test is pretty 
> >> minimal.
> >> Future work could test the rest of the nand API as well as the MTD API.
> >>
> >> Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
> >> everything grows by a few bytes due to nand_page_size. A few boards 
> >> grow more,
> >> mostly those using nand_spl_loaders.c.
> >>
> >> [1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2
> >>
> >>
> >> Sean Anderson (15):
> >>  spl: nand: Fix NULL-pointer dereference
> >>  nand: Don't dereference NULL manufacturer_desc
> >>  nand: Calculate SYS_NAND_PAGE_COUNT automatically
> >>  nand: spl_loaders: Only read enough pages to load the image
> >>  spl: legacy: Honor bl_len when decompressing
> >>  spl: nand: Set bl_len to page size
> >>  cmd: nand: Map memory before accessing it
> >>  spl: nand: Map memory before accessing it
> >>  mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
> >>  mtd: Add some fallbacks for add/del_mtd_device
> >>  nand: Add function to unregister NAND devices
> >>  nand: Allow reinitialization
> >>  arch: sandbox: Add function to create temporary files
> >>  nand: Add sandbox driver
> >>  test: spl: Add a test for NAND
> >>
> >> README|   9 +-
> >> arch/sandbox/cpu/os.c |  17 +
> >> arch/sandbox/dts/test.dts |  67 ++
> >> arch/sandbox/include/asm/spl.h|   1 +
> >> cmd/nand.c|  26 +-
> >> common/spl/Kconfig|   2 +-
> >> common/spl/spl_legacy.c   |  18 +-
> >> common/spl/spl_nand.c |  22 +-
> >> configs/am335x_baltos_defconfig   |   3 +-
> >> configs/am335x_evm_defconfig  |   3 +-
> >> configs/am335x_evm_spiboot_defconfig  |   2 +-
> >> configs/am335x_guardian_defconfig |   1 -
> >> configs/am335x_hs_evm_defconfig   |   2 +-
> >> configs/am335x_hs_evm_uart_defconfig  |   2 +-
> >> configs/am335x_igep003x_defconfig |   3 +-
> >> configs/am335x_sl50_defconfig |   2 +-
> >> configs/am3517_evm_defconfig  |   3 +-
> >> configs/am43xx_evm_defconfig  |   3 +-
> >> configs/am43xx_evm_rtconly_defconfig  |   3 +-
> >> configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
> >> configs/am43xx_hs_evm_defconfig   |   3 +-
> >> configs/am62ax_evm_r5_defconfig   |   2 +-
> >> configs/am65x_evm_a53_defconfig   |   2 +-
> >> configs/axm_defconfig |   1 -
> >> configs/chiliboard_defconfig  |   1 -
> >> configs/cm_t43_defconfig  |   2 +-
> >> configs/corvus_defconfig  |   1 -
> >> configs/da850evm_nand_defconfig   |   1 -
> >> configs/devkit3250_defconfig  |   1 -
> >> configs/devkit8000_defconfig  |   1 -
> >> configs/dra7xx_evm_defconfig  |   1 -
> >> configs/draco_defconfig   |   1 -
> >> configs/etamin_defconfig  |   1 -
> >> .../gardena-smart-gateway-at91sam_defconfig   |   1 -
> >> configs/igep00x0_defconfig|   3 +-
> >> configs/imx6ulz_smm_m2_defconfig  |   2 +-
> >> configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
> >> configs/j7200_evm_a72_defconfig   |   2 +-
> >> configs/j7200_evm_r5_defconfig|   2 +-
> >> configs/j721e_evm_a72_defconfig   |   2 +-
> >> configs/j721e_evm_r5_defconfig|   2 +-
> >> configs/j721s2_evm_a72_defconfig  |   2 +-
> >> configs/j721s2_evm_r5_defconfig   |   2 +-
> >> configs/m53menlo_defconfig|   1 -
> >>>

Re: [PATCH 00/15] nand: Add sandbox tests

2023-11-04 Thread Sean Anderson

On 11/2/23 10:18, Dario Binacchi wrote:

On Thu, Nov 2, 2023 at 3:13 PM Sean Anderson  wrote:


On 11/2/23 10:08, Dario Binacchi wrote:

On Thu, Nov 2, 2023 at 3:06 PM Sean Anderson  wrote:


On 11/2/23 10:01, Dario Binacchi wrote:

Sean, All,

On Sun, Oct 29, 2023 at 4:48 AM Sean Anderson  wrote:


This series tests raw nand flash in sandbox and fixes various bugs discovered in
the process. I've tried to do things in a contemporary manner, avoiding the
(numerous) variations present on only a few boards. The test is pretty minimal.
Future work could test the rest of the nand API as well as the MTD API.

Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
everything grows by a few bytes due to nand_page_size. A few boards grow more,
mostly those using nand_spl_loaders.c.

[1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2


Sean Anderson (15):
 spl: nand: Fix NULL-pointer dereference
 nand: Don't dereference NULL manufacturer_desc
 nand: Calculate SYS_NAND_PAGE_COUNT automatically
 nand: spl_loaders: Only read enough pages to load the image
 spl: legacy: Honor bl_len when decompressing
 spl: nand: Set bl_len to page size
 cmd: nand: Map memory before accessing it
 spl: nand: Map memory before accessing it
 mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
 mtd: Add some fallbacks for add/del_mtd_device
 nand: Add function to unregister NAND devices
 nand: Allow reinitialization
 arch: sandbox: Add function to create temporary files
 nand: Add sandbox driver
 test: spl: Add a test for NAND

README|   9 +-
arch/sandbox/cpu/os.c |  17 +
arch/sandbox/dts/test.dts |  67 ++
arch/sandbox/include/asm/spl.h|   1 +
cmd/nand.c|  26 +-
common/spl/Kconfig|   2 +-
common/spl/spl_legacy.c   |  18 +-
common/spl/spl_nand.c |  22 +-
configs/am335x_baltos_defconfig   |   3 +-
configs/am335x_evm_defconfig  |   3 +-
configs/am335x_evm_spiboot_defconfig  |   2 +-
configs/am335x_guardian_defconfig |   1 -
configs/am335x_hs_evm_defconfig   |   2 +-
configs/am335x_hs_evm_uart_defconfig  |   2 +-
configs/am335x_igep003x_defconfig |   3 +-
configs/am335x_sl50_defconfig |   2 +-
configs/am3517_evm_defconfig  |   3 +-
configs/am43xx_evm_defconfig  |   3 +-
configs/am43xx_evm_rtconly_defconfig  |   3 +-
configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
configs/am43xx_hs_evm_defconfig   |   3 +-
configs/am62ax_evm_r5_defconfig   |   2 +-
configs/am65x_evm_a53_defconfig   |   2 +-
configs/axm_defconfig |   1 -
configs/chiliboard_defconfig  |   1 -
configs/cm_t43_defconfig  |   2 +-
configs/corvus_defconfig  |   1 -
configs/da850evm_nand_defconfig   |   1 -
configs/devkit3250_defconfig  |   1 -
configs/devkit8000_defconfig  |   1 -
configs/dra7xx_evm_defconfig  |   1 -
configs/draco_defconfig   |   1 -
configs/etamin_defconfig  |   1 -
.../gardena-smart-gateway-at91sam_defconfig   |   1 -
configs/igep00x0_defconfig|   3 +-
configs/imx6ulz_smm_m2_defconfig  |   2 +-
configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
configs/j7200_evm_a72_defconfig   |   2 +-
configs/j7200_evm_r5_defconfig|   2 +-
configs/j721e_evm_a72_defconfig   |   2 +-
configs/j721e_evm_r5_defconfig|   2 +-
configs/j721s2_evm_a72_defconfig  |   2 +-
configs/j721s2_evm_r5_defconfig   |   2 +-
configs/m53menlo_defconfig|   1 -
configs/omap35_logic_defconfig|   3 +-
configs/omap35_logic_somlv_defconfig  |   3 +-
configs/omap3_beagle_defconfig|   3 +-
configs/omap3_evm_defconfig   |   3 +-
configs/omap3_logic_defconfig |   3 +-
configs/omap3_logic_somlv_defconfig   |   3 +-
configs/omapl138_lcdk_defconfig   |   1 -
configs/phycore-am335x-r2-regor_defconfig |   3 +-
configs/phycore-am335x-r2-wega_defconfig  |   3 +-
configs/pxm2_defconfig|   1 -
configs/rastaban_defconfig|   1 -
configs/rut_defconfig |   1 -
configs/sama5d3_xplained_nandflash_defconfig  |   1 -
configs/sama5d3xek_nandflash_defconfig|   1 -
 

Re: [PATCH 00/15] nand: Add sandbox tests

2023-11-02 Thread Dario Binacchi
On Thu, Nov 2, 2023 at 3:13 PM Sean Anderson  wrote:
>
> On 11/2/23 10:08, Dario Binacchi wrote:
> > On Thu, Nov 2, 2023 at 3:06 PM Sean Anderson  wrote:
> >>
> >> On 11/2/23 10:01, Dario Binacchi wrote:
> >>> Sean, All,
> >>>
> >>> On Sun, Oct 29, 2023 at 4:48 AM Sean Anderson  wrote:
> 
>  This series tests raw nand flash in sandbox and fixes various bugs 
>  discovered in
>  the process. I've tried to do things in a contemporary manner, avoiding 
>  the
>  (numerous) variations present on only a few boards. The test is pretty 
>  minimal.
>  Future work could test the rest of the nand API as well as the MTD API.
> 
>  Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
>  everything grows by a few bytes due to nand_page_size. A few boards grow 
>  more,
>  mostly those using nand_spl_loaders.c.
> 
>  [1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2
> 
> 
>  Sean Anderson (15):
>  spl: nand: Fix NULL-pointer dereference
>  nand: Don't dereference NULL manufacturer_desc
>  nand: Calculate SYS_NAND_PAGE_COUNT automatically
>  nand: spl_loaders: Only read enough pages to load the image
>  spl: legacy: Honor bl_len when decompressing
>  spl: nand: Set bl_len to page size
>  cmd: nand: Map memory before accessing it
>  spl: nand: Map memory before accessing it
>  mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
>  mtd: Add some fallbacks for add/del_mtd_device
>  nand: Add function to unregister NAND devices
>  nand: Allow reinitialization
>  arch: sandbox: Add function to create temporary files
>  nand: Add sandbox driver
>  test: spl: Add a test for NAND
> 
> README|   9 +-
> arch/sandbox/cpu/os.c |  17 +
> arch/sandbox/dts/test.dts |  67 ++
> arch/sandbox/include/asm/spl.h|   1 +
> cmd/nand.c|  26 +-
> common/spl/Kconfig|   2 +-
> common/spl/spl_legacy.c   |  18 +-
> common/spl/spl_nand.c |  22 +-
> configs/am335x_baltos_defconfig   |   3 +-
> configs/am335x_evm_defconfig  |   3 +-
> configs/am335x_evm_spiboot_defconfig  |   2 +-
> configs/am335x_guardian_defconfig |   1 -
> configs/am335x_hs_evm_defconfig   |   2 +-
> configs/am335x_hs_evm_uart_defconfig  |   2 +-
> configs/am335x_igep003x_defconfig |   3 +-
> configs/am335x_sl50_defconfig |   2 +-
> configs/am3517_evm_defconfig  |   3 +-
> configs/am43xx_evm_defconfig  |   3 +-
> configs/am43xx_evm_rtconly_defconfig  |   3 +-
> configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
> configs/am43xx_hs_evm_defconfig   |   3 +-
> configs/am62ax_evm_r5_defconfig   |   2 +-
> configs/am65x_evm_a53_defconfig   |   2 +-
> configs/axm_defconfig |   1 -
> configs/chiliboard_defconfig  |   1 -
> configs/cm_t43_defconfig  |   2 +-
> configs/corvus_defconfig  |   1 -
> configs/da850evm_nand_defconfig   |   1 -
> configs/devkit3250_defconfig  |   1 -
> configs/devkit8000_defconfig  |   1 -
> configs/dra7xx_evm_defconfig  |   1 -
> configs/draco_defconfig   |   1 -
> configs/etamin_defconfig  |   1 -
> .../gardena-smart-gateway-at91sam_defconfig   |   1 -
> configs/igep00x0_defconfig|   3 +-
> configs/imx6ulz_smm_m2_defconfig  |   2 +-
> configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
> configs/j7200_evm_a72_defconfig   |   2 +-
> configs/j7200_evm_r5_defconfig|   2 +-
> configs/j721e_evm_a72_defconfig   |   2 +-
> configs/j721e_evm_r5_defconfig|   2 +-
> configs/j721s2_evm_a72_defconfig  |   2 +-
> configs/j721s2_evm_r5_defconfig   |   2 +-
> configs/m53menlo_defconfig|   1 -
> configs/omap35_logic_defconfig|   3 +-
> configs/omap35_logic_somlv_defconfig  |   3 +-
> configs/omap3_beagle_defconfig|   3 +-
> configs/omap3_evm_defconfig   |   3 +-
> configs/omap3_logic_defconfig |   3 +-
> configs/omap3_l

Re: [PATCH 00/15] nand: Add sandbox tests

2023-11-02 Thread Dario Binacchi
On Thu, Nov 2, 2023 at 3:06 PM Sean Anderson  wrote:
>
> On 11/2/23 10:01, Dario Binacchi wrote:
> > Sean, All,
> >
> > On Sun, Oct 29, 2023 at 4:48 AM Sean Anderson  wrote:
> >>
> >> This series tests raw nand flash in sandbox and fixes various bugs 
> >> discovered in
> >> the process. I've tried to do things in a contemporary manner, avoiding the
> >> (numerous) variations present on only a few boards. The test is pretty 
> >> minimal.
> >> Future work could test the rest of the nand API as well as the MTD API.
> >>
> >> Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
> >> everything grows by a few bytes due to nand_page_size. A few boards grow 
> >> more,
> >> mostly those using nand_spl_loaders.c.
> >>
> >> [1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2
> >>
> >>
> >> Sean Anderson (15):
> >>spl: nand: Fix NULL-pointer dereference
> >>nand: Don't dereference NULL manufacturer_desc
> >>nand: Calculate SYS_NAND_PAGE_COUNT automatically
> >>nand: spl_loaders: Only read enough pages to load the image
> >>spl: legacy: Honor bl_len when decompressing
> >>spl: nand: Set bl_len to page size
> >>cmd: nand: Map memory before accessing it
> >>spl: nand: Map memory before accessing it
> >>mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
> >>mtd: Add some fallbacks for add/del_mtd_device
> >>nand: Add function to unregister NAND devices
> >>nand: Allow reinitialization
> >>arch: sandbox: Add function to create temporary files
> >>nand: Add sandbox driver
> >>test: spl: Add a test for NAND
> >>
> >>   README|   9 +-
> >>   arch/sandbox/cpu/os.c |  17 +
> >>   arch/sandbox/dts/test.dts |  67 ++
> >>   arch/sandbox/include/asm/spl.h|   1 +
> >>   cmd/nand.c|  26 +-
> >>   common/spl/Kconfig|   2 +-
> >>   common/spl/spl_legacy.c   |  18 +-
> >>   common/spl/spl_nand.c |  22 +-
> >>   configs/am335x_baltos_defconfig   |   3 +-
> >>   configs/am335x_evm_defconfig  |   3 +-
> >>   configs/am335x_evm_spiboot_defconfig  |   2 +-
> >>   configs/am335x_guardian_defconfig |   1 -
> >>   configs/am335x_hs_evm_defconfig   |   2 +-
> >>   configs/am335x_hs_evm_uart_defconfig  |   2 +-
> >>   configs/am335x_igep003x_defconfig |   3 +-
> >>   configs/am335x_sl50_defconfig |   2 +-
> >>   configs/am3517_evm_defconfig  |   3 +-
> >>   configs/am43xx_evm_defconfig  |   3 +-
> >>   configs/am43xx_evm_rtconly_defconfig  |   3 +-
> >>   configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
> >>   configs/am43xx_hs_evm_defconfig   |   3 +-
> >>   configs/am62ax_evm_r5_defconfig   |   2 +-
> >>   configs/am65x_evm_a53_defconfig   |   2 +-
> >>   configs/axm_defconfig |   1 -
> >>   configs/chiliboard_defconfig  |   1 -
> >>   configs/cm_t43_defconfig  |   2 +-
> >>   configs/corvus_defconfig  |   1 -
> >>   configs/da850evm_nand_defconfig   |   1 -
> >>   configs/devkit3250_defconfig  |   1 -
> >>   configs/devkit8000_defconfig  |   1 -
> >>   configs/dra7xx_evm_defconfig  |   1 -
> >>   configs/draco_defconfig   |   1 -
> >>   configs/etamin_defconfig  |   1 -
> >>   .../gardena-smart-gateway-at91sam_defconfig   |   1 -
> >>   configs/igep00x0_defconfig|   3 +-
> >>   configs/imx6ulz_smm_m2_defconfig  |   2 +-
> >>   configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
> >>   configs/j7200_evm_a72_defconfig   |   2 +-
> >>   configs/j7200_evm_r5_defconfig|   2 +-
> >>   configs/j721e_evm_a72_defconfig   |   2 +-
> >>   configs/j721e_evm_r5_defconfig|   2 +-
> >>   configs/j721s2_evm_a72_defconfig  |   2 +-
> >>   configs/j721s2_evm_r5_defconfig   |   2 +-
> >>   configs/m53menlo_defconfig|   1 -
> >>   configs/omap35_logic_defconfig|   3 +-
> >>   configs/omap35_logic_somlv_defconfig  |   3 +-
> >>   configs/omap3_beagle_defconfig|   3 +-
> >>   configs/omap3_evm_defconfig   |   3 +-
> >>   configs/omap3_logic_defconfig |   3 +-
> >>   configs/omap3_logic_somlv_defconfig   |   3 +-
> >>   configs/omapl138_lcdk_defconfig   |   1 -
> >>   configs/phycore-am335x-r2-regor_defconfig |   3 +-
> >>   configs/phycore-am335x-r2-wega_defconfig  |   3 +-
> >>   configs/pxm2_defconfig|   1 -
> >>   configs/rastaban_defconfig|   1 -
> >> 

Re: [PATCH 00/15] nand: Add sandbox tests

2023-11-02 Thread Sean Anderson

On 11/2/23 10:08, Dario Binacchi wrote:

On Thu, Nov 2, 2023 at 3:06 PM Sean Anderson  wrote:


On 11/2/23 10:01, Dario Binacchi wrote:

Sean, All,

On Sun, Oct 29, 2023 at 4:48 AM Sean Anderson  wrote:


This series tests raw nand flash in sandbox and fixes various bugs discovered in
the process. I've tried to do things in a contemporary manner, avoiding the
(numerous) variations present on only a few boards. The test is pretty minimal.
Future work could test the rest of the nand API as well as the MTD API.

Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
everything grows by a few bytes due to nand_page_size. A few boards grow more,
mostly those using nand_spl_loaders.c.

[1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2


Sean Anderson (15):
spl: nand: Fix NULL-pointer dereference
nand: Don't dereference NULL manufacturer_desc
nand: Calculate SYS_NAND_PAGE_COUNT automatically
nand: spl_loaders: Only read enough pages to load the image
spl: legacy: Honor bl_len when decompressing
spl: nand: Set bl_len to page size
cmd: nand: Map memory before accessing it
spl: nand: Map memory before accessing it
mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
mtd: Add some fallbacks for add/del_mtd_device
nand: Add function to unregister NAND devices
nand: Allow reinitialization
arch: sandbox: Add function to create temporary files
nand: Add sandbox driver
test: spl: Add a test for NAND

   README|   9 +-
   arch/sandbox/cpu/os.c |  17 +
   arch/sandbox/dts/test.dts |  67 ++
   arch/sandbox/include/asm/spl.h|   1 +
   cmd/nand.c|  26 +-
   common/spl/Kconfig|   2 +-
   common/spl/spl_legacy.c   |  18 +-
   common/spl/spl_nand.c |  22 +-
   configs/am335x_baltos_defconfig   |   3 +-
   configs/am335x_evm_defconfig  |   3 +-
   configs/am335x_evm_spiboot_defconfig  |   2 +-
   configs/am335x_guardian_defconfig |   1 -
   configs/am335x_hs_evm_defconfig   |   2 +-
   configs/am335x_hs_evm_uart_defconfig  |   2 +-
   configs/am335x_igep003x_defconfig |   3 +-
   configs/am335x_sl50_defconfig |   2 +-
   configs/am3517_evm_defconfig  |   3 +-
   configs/am43xx_evm_defconfig  |   3 +-
   configs/am43xx_evm_rtconly_defconfig  |   3 +-
   configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
   configs/am43xx_hs_evm_defconfig   |   3 +-
   configs/am62ax_evm_r5_defconfig   |   2 +-
   configs/am65x_evm_a53_defconfig   |   2 +-
   configs/axm_defconfig |   1 -
   configs/chiliboard_defconfig  |   1 -
   configs/cm_t43_defconfig  |   2 +-
   configs/corvus_defconfig  |   1 -
   configs/da850evm_nand_defconfig   |   1 -
   configs/devkit3250_defconfig  |   1 -
   configs/devkit8000_defconfig  |   1 -
   configs/dra7xx_evm_defconfig  |   1 -
   configs/draco_defconfig   |   1 -
   configs/etamin_defconfig  |   1 -
   .../gardena-smart-gateway-at91sam_defconfig   |   1 -
   configs/igep00x0_defconfig|   3 +-
   configs/imx6ulz_smm_m2_defconfig  |   2 +-
   configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
   configs/j7200_evm_a72_defconfig   |   2 +-
   configs/j7200_evm_r5_defconfig|   2 +-
   configs/j721e_evm_a72_defconfig   |   2 +-
   configs/j721e_evm_r5_defconfig|   2 +-
   configs/j721s2_evm_a72_defconfig  |   2 +-
   configs/j721s2_evm_r5_defconfig   |   2 +-
   configs/m53menlo_defconfig|   1 -
   configs/omap35_logic_defconfig|   3 +-
   configs/omap35_logic_somlv_defconfig  |   3 +-
   configs/omap3_beagle_defconfig|   3 +-
   configs/omap3_evm_defconfig   |   3 +-
   configs/omap3_logic_defconfig |   3 +-
   configs/omap3_logic_somlv_defconfig   |   3 +-
   configs/omapl138_lcdk_defconfig   |   1 -
   configs/phycore-am335x-r2-regor_defconfig |   3 +-
   configs/phycore-am335x-r2-wega_defconfig  |   3 +-
   configs/pxm2_defconfig|   1 -
   configs/rastaban_defconfig|   1 -
   configs/rut_defconfig |   1 -
   configs/sama5d3_xplained_nandflash_defconfig  |   1 -
   configs/sama5d3xek_nandflash_defconfig|   1 -
   configs/sama5d4_xplained_nandflash_defconfig  |   1 -
   configs/sama5d4ek_nandflash_defconfig |   1 -
   configs/sandbox64_defconfig   |  10 +

Re: [PATCH 00/15] nand: Add sandbox tests

2023-11-02 Thread Sean Anderson

On 11/2/23 10:01, Dario Binacchi wrote:

Sean, All,

On Sun, Oct 29, 2023 at 4:48 AM Sean Anderson  wrote:


This series tests raw nand flash in sandbox and fixes various bugs discovered in
the process. I've tried to do things in a contemporary manner, avoiding the
(numerous) variations present on only a few boards. The test is pretty minimal.
Future work could test the rest of the nand API as well as the MTD API.

Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
everything grows by a few bytes due to nand_page_size. A few boards grow more,
mostly those using nand_spl_loaders.c.

[1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2


Sean Anderson (15):
   spl: nand: Fix NULL-pointer dereference
   nand: Don't dereference NULL manufacturer_desc
   nand: Calculate SYS_NAND_PAGE_COUNT automatically
   nand: spl_loaders: Only read enough pages to load the image
   spl: legacy: Honor bl_len when decompressing
   spl: nand: Set bl_len to page size
   cmd: nand: Map memory before accessing it
   spl: nand: Map memory before accessing it
   mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
   mtd: Add some fallbacks for add/del_mtd_device
   nand: Add function to unregister NAND devices
   nand: Allow reinitialization
   arch: sandbox: Add function to create temporary files
   nand: Add sandbox driver
   test: spl: Add a test for NAND

  README|   9 +-
  arch/sandbox/cpu/os.c |  17 +
  arch/sandbox/dts/test.dts |  67 ++
  arch/sandbox/include/asm/spl.h|   1 +
  cmd/nand.c|  26 +-
  common/spl/Kconfig|   2 +-
  common/spl/spl_legacy.c   |  18 +-
  common/spl/spl_nand.c |  22 +-
  configs/am335x_baltos_defconfig   |   3 +-
  configs/am335x_evm_defconfig  |   3 +-
  configs/am335x_evm_spiboot_defconfig  |   2 +-
  configs/am335x_guardian_defconfig |   1 -
  configs/am335x_hs_evm_defconfig   |   2 +-
  configs/am335x_hs_evm_uart_defconfig  |   2 +-
  configs/am335x_igep003x_defconfig |   3 +-
  configs/am335x_sl50_defconfig |   2 +-
  configs/am3517_evm_defconfig  |   3 +-
  configs/am43xx_evm_defconfig  |   3 +-
  configs/am43xx_evm_rtconly_defconfig  |   3 +-
  configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
  configs/am43xx_hs_evm_defconfig   |   3 +-
  configs/am62ax_evm_r5_defconfig   |   2 +-
  configs/am65x_evm_a53_defconfig   |   2 +-
  configs/axm_defconfig |   1 -
  configs/chiliboard_defconfig  |   1 -
  configs/cm_t43_defconfig  |   2 +-
  configs/corvus_defconfig  |   1 -
  configs/da850evm_nand_defconfig   |   1 -
  configs/devkit3250_defconfig  |   1 -
  configs/devkit8000_defconfig  |   1 -
  configs/dra7xx_evm_defconfig  |   1 -
  configs/draco_defconfig   |   1 -
  configs/etamin_defconfig  |   1 -
  .../gardena-smart-gateway-at91sam_defconfig   |   1 -
  configs/igep00x0_defconfig|   3 +-
  configs/imx6ulz_smm_m2_defconfig  |   2 +-
  configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
  configs/j7200_evm_a72_defconfig   |   2 +-
  configs/j7200_evm_r5_defconfig|   2 +-
  configs/j721e_evm_a72_defconfig   |   2 +-
  configs/j721e_evm_r5_defconfig|   2 +-
  configs/j721s2_evm_a72_defconfig  |   2 +-
  configs/j721s2_evm_r5_defconfig   |   2 +-
  configs/m53menlo_defconfig|   1 -
  configs/omap35_logic_defconfig|   3 +-
  configs/omap35_logic_somlv_defconfig  |   3 +-
  configs/omap3_beagle_defconfig|   3 +-
  configs/omap3_evm_defconfig   |   3 +-
  configs/omap3_logic_defconfig |   3 +-
  configs/omap3_logic_somlv_defconfig   |   3 +-
  configs/omapl138_lcdk_defconfig   |   1 -
  configs/phycore-am335x-r2-regor_defconfig |   3 +-
  configs/phycore-am335x-r2-wega_defconfig  |   3 +-
  configs/pxm2_defconfig|   1 -
  configs/rastaban_defconfig|   1 -
  configs/rut_defconfig |   1 -
  configs/sama5d3_xplained_nandflash_defconfig  |   1 -
  configs/sama5d3xek_nandflash_defconfig|   1 -
  configs/sama5d4_xplained_nandflash_defconfig  |   1 -
  configs/sama5d4ek_nandflash_defconfig |   1 -
  configs/sandbox64_defconfig   |  10 +-
  configs/sandbox_defconfig |   9 +
  configs/sandbox_noinst_defconfig  |  21 +-
  configs/smartweb_defconfig|   1 -
 

Re: [PATCH 00/15] nand: Add sandbox tests

2023-11-02 Thread Dario Binacchi
Sean, All,

On Sun, Oct 29, 2023 at 4:48 AM Sean Anderson  wrote:
>
> This series tests raw nand flash in sandbox and fixes various bugs discovered 
> in
> the process. I've tried to do things in a contemporary manner, avoiding the
> (numerous) variations present on only a few boards. The test is pretty 
> minimal.
> Future work could test the rest of the nand API as well as the MTD API.
>
> Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
> everything grows by a few bytes due to nand_page_size. A few boards grow more,
> mostly those using nand_spl_loaders.c.
>
> [1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2
>
>
> Sean Anderson (15):
>   spl: nand: Fix NULL-pointer dereference
>   nand: Don't dereference NULL manufacturer_desc
>   nand: Calculate SYS_NAND_PAGE_COUNT automatically
>   nand: spl_loaders: Only read enough pages to load the image
>   spl: legacy: Honor bl_len when decompressing
>   spl: nand: Set bl_len to page size
>   cmd: nand: Map memory before accessing it
>   spl: nand: Map memory before accessing it
>   mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
>   mtd: Add some fallbacks for add/del_mtd_device
>   nand: Add function to unregister NAND devices
>   nand: Allow reinitialization
>   arch: sandbox: Add function to create temporary files
>   nand: Add sandbox driver
>   test: spl: Add a test for NAND
>
>  README|   9 +-
>  arch/sandbox/cpu/os.c |  17 +
>  arch/sandbox/dts/test.dts |  67 ++
>  arch/sandbox/include/asm/spl.h|   1 +
>  cmd/nand.c|  26 +-
>  common/spl/Kconfig|   2 +-
>  common/spl/spl_legacy.c   |  18 +-
>  common/spl/spl_nand.c |  22 +-
>  configs/am335x_baltos_defconfig   |   3 +-
>  configs/am335x_evm_defconfig  |   3 +-
>  configs/am335x_evm_spiboot_defconfig  |   2 +-
>  configs/am335x_guardian_defconfig |   1 -
>  configs/am335x_hs_evm_defconfig   |   2 +-
>  configs/am335x_hs_evm_uart_defconfig  |   2 +-
>  configs/am335x_igep003x_defconfig |   3 +-
>  configs/am335x_sl50_defconfig |   2 +-
>  configs/am3517_evm_defconfig  |   3 +-
>  configs/am43xx_evm_defconfig  |   3 +-
>  configs/am43xx_evm_rtconly_defconfig  |   3 +-
>  configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
>  configs/am43xx_hs_evm_defconfig   |   3 +-
>  configs/am62ax_evm_r5_defconfig   |   2 +-
>  configs/am65x_evm_a53_defconfig   |   2 +-
>  configs/axm_defconfig |   1 -
>  configs/chiliboard_defconfig  |   1 -
>  configs/cm_t43_defconfig  |   2 +-
>  configs/corvus_defconfig  |   1 -
>  configs/da850evm_nand_defconfig   |   1 -
>  configs/devkit3250_defconfig  |   1 -
>  configs/devkit8000_defconfig  |   1 -
>  configs/dra7xx_evm_defconfig  |   1 -
>  configs/draco_defconfig   |   1 -
>  configs/etamin_defconfig  |   1 -
>  .../gardena-smart-gateway-at91sam_defconfig   |   1 -
>  configs/igep00x0_defconfig|   3 +-
>  configs/imx6ulz_smm_m2_defconfig  |   2 +-
>  configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
>  configs/j7200_evm_a72_defconfig   |   2 +-
>  configs/j7200_evm_r5_defconfig|   2 +-
>  configs/j721e_evm_a72_defconfig   |   2 +-
>  configs/j721e_evm_r5_defconfig|   2 +-
>  configs/j721s2_evm_a72_defconfig  |   2 +-
>  configs/j721s2_evm_r5_defconfig   |   2 +-
>  configs/m53menlo_defconfig|   1 -
>  configs/omap35_logic_defconfig|   3 +-
>  configs/omap35_logic_somlv_defconfig  |   3 +-
>  configs/omap3_beagle_defconfig|   3 +-
>  configs/omap3_evm_defconfig   |   3 +-
>  configs/omap3_logic_defconfig |   3 +-
>  configs/omap3_logic_somlv_defconfig   |   3 +-
>  configs/omapl138_lcdk_defconfig   |   1 -
>  configs/phycore-am335x-r2-regor_defconfig |   3 +-
>  configs/phycore-am335x-r2-wega_defconfig  |   3 +-
>  configs/pxm2_defconfig|   1 -
>  configs/rastaban_defconfig|   1 -
>  configs/rut_defconfig |   1 -
>  configs/sama5d3_xplained_nandflash_defconfig  |   1 -
>  configs/sama5d3xek_nandflash_defconfig|   1 -
>  configs/sama5d4_xplained_nandflash_defconfig  |   1 -
>  configs/sama5d4ek_nandflash_defconfig |   1 -
>  configs/sandbox64_defconfig   |  10 +-
>  configs/sandbox_defconfig |   9 +
>  configs/sandbox_noinst_defconfig  |

[PATCH 00/15] nand: Add sandbox tests

2023-10-28 Thread Sean Anderson
This series tests raw nand flash in sandbox and fixes various bugs discovered in
the process. I've tried to do things in a contemporary manner, avoiding the
(numerous) variations present on only a few boards. The test is pretty minimal.
Future work could test the rest of the nand API as well as the MTD API.

Bloat at [1] (for boards with SPL_NAND_SUPPORT enabled). Almost
everything grows by a few bytes due to nand_page_size. A few boards grow more,
mostly those using nand_spl_loaders.c.

[1] https://gist.github.com/Forty-Bot/9694f3401893c9e706ccc374922de6c2


Sean Anderson (15):
  spl: nand: Fix NULL-pointer dereference
  nand: Don't dereference NULL manufacturer_desc
  nand: Calculate SYS_NAND_PAGE_COUNT automatically
  nand: spl_loaders: Only read enough pages to load the image
  spl: legacy: Honor bl_len when decompressing
  spl: nand: Set bl_len to page size
  cmd: nand: Map memory before accessing it
  spl: nand: Map memory before accessing it
  mtd: Rename SPL_MTD_SUPPORT to SPL_MTD
  mtd: Add some fallbacks for add/del_mtd_device
  nand: Add function to unregister NAND devices
  nand: Allow reinitialization
  arch: sandbox: Add function to create temporary files
  nand: Add sandbox driver
  test: spl: Add a test for NAND

 README|   9 +-
 arch/sandbox/cpu/os.c |  17 +
 arch/sandbox/dts/test.dts |  67 ++
 arch/sandbox/include/asm/spl.h|   1 +
 cmd/nand.c|  26 +-
 common/spl/Kconfig|   2 +-
 common/spl/spl_legacy.c   |  18 +-
 common/spl/spl_nand.c |  22 +-
 configs/am335x_baltos_defconfig   |   3 +-
 configs/am335x_evm_defconfig  |   3 +-
 configs/am335x_evm_spiboot_defconfig  |   2 +-
 configs/am335x_guardian_defconfig |   1 -
 configs/am335x_hs_evm_defconfig   |   2 +-
 configs/am335x_hs_evm_uart_defconfig  |   2 +-
 configs/am335x_igep003x_defconfig |   3 +-
 configs/am335x_sl50_defconfig |   2 +-
 configs/am3517_evm_defconfig  |   3 +-
 configs/am43xx_evm_defconfig  |   3 +-
 configs/am43xx_evm_rtconly_defconfig  |   3 +-
 configs/am43xx_evm_usbhost_boot_defconfig |   3 +-
 configs/am43xx_hs_evm_defconfig   |   3 +-
 configs/am62ax_evm_r5_defconfig   |   2 +-
 configs/am65x_evm_a53_defconfig   |   2 +-
 configs/axm_defconfig |   1 -
 configs/chiliboard_defconfig  |   1 -
 configs/cm_t43_defconfig  |   2 +-
 configs/corvus_defconfig  |   1 -
 configs/da850evm_nand_defconfig   |   1 -
 configs/devkit3250_defconfig  |   1 -
 configs/devkit8000_defconfig  |   1 -
 configs/dra7xx_evm_defconfig  |   1 -
 configs/draco_defconfig   |   1 -
 configs/etamin_defconfig  |   1 -
 .../gardena-smart-gateway-at91sam_defconfig   |   1 -
 configs/igep00x0_defconfig|   3 +-
 configs/imx6ulz_smm_m2_defconfig  |   2 +-
 configs/imx8mn_bsh_smm_s2_defconfig   |   2 +-
 configs/j7200_evm_a72_defconfig   |   2 +-
 configs/j7200_evm_r5_defconfig|   2 +-
 configs/j721e_evm_a72_defconfig   |   2 +-
 configs/j721e_evm_r5_defconfig|   2 +-
 configs/j721s2_evm_a72_defconfig  |   2 +-
 configs/j721s2_evm_r5_defconfig   |   2 +-
 configs/m53menlo_defconfig|   1 -
 configs/omap35_logic_defconfig|   3 +-
 configs/omap35_logic_somlv_defconfig  |   3 +-
 configs/omap3_beagle_defconfig|   3 +-
 configs/omap3_evm_defconfig   |   3 +-
 configs/omap3_logic_defconfig |   3 +-
 configs/omap3_logic_somlv_defconfig   |   3 +-
 configs/omapl138_lcdk_defconfig   |   1 -
 configs/phycore-am335x-r2-regor_defconfig |   3 +-
 configs/phycore-am335x-r2-wega_defconfig  |   3 +-
 configs/pxm2_defconfig|   1 -
 configs/rastaban_defconfig|   1 -
 configs/rut_defconfig |   1 -
 configs/sama5d3_xplained_nandflash_defconfig  |   1 -
 configs/sama5d3xek_nandflash_defconfig|   1 -
 configs/sama5d4_xplained_nandflash_defconfig  |   1 -
 configs/sama5d4ek_nandflash_defconfig |   1 -
 configs/sandbox64_defconfig   |  10 +-
 configs/sandbox_defconfig |   9 +
 configs/sandbox_noinst_defconfig  |  21 +-
 configs/smartweb_defconfig|   1 -
 configs/socfpga_secu1_defconfig   |   2 +-
 configs/stm32746g-eval_spl_defconfig  |   2 +-
 configs/stm32f746-disco_spl_defconfig |   2 +-
 configs/stm32f769-dis