RE: [PATCH 01/10] ARM: dts: ast2600: Add I2C pinctrl

2022-06-20 Thread Ryan Chen 
> -Original Message-
> From: joel.s...@gmail.com  On Behalf Of Joel Stanley
> Sent: Monday, June 20, 2022 3:25 PM
> To: Ryan Chen ; BMC-SW
> ; Heiko Schocher 
> Cc: Eddie James ; u-boot@lists.denx.de; Cédric Le
> Goater 
> Subject: [PATCH 01/10] ARM: dts: ast2600: Add I2C pinctrl
> 
> From: Eddie James 
> 
> Set the pinctrl groups for each I2C bus. These are essential to I2C operating
> correctly.
> 
> Signed-off-by: Eddie James 
> Signed-off-by: Joel Stanley 

Review-by: Ryan Chen 
> ---
>  arch/arm/dts/ast2600.dtsi | 33 +
>  1 file changed, 33 insertions(+)
> 
> diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi index
> 64074309b7b2..ef5b131ac0af 100644
> --- a/arch/arm/dts/ast2600.dtsi
> +++ b/arch/arm/dts/ast2600.dtsi
> @@ -833,6 +833,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c1_default>;
>   status = "disabled";
>   };
> 
> @@ -846,6 +848,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c2_default>;
>   status = "disabled";
>   };
> 
> @@ -859,6 +863,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c3_default>;
>   };
> 
>   i2c3: i2c@200 {
> @@ -871,6 +877,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c4_default>;
>   };
> 
>   i2c4: i2c@280 {
> @@ -883,6 +891,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c5_default>;
>   };
> 
>   i2c5: i2c@300 {
> @@ -895,6 +905,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c6_default>;
>   };
> 
>   i2c6: i2c@380 {
> @@ -907,6 +919,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c7_default>;
>   };
> 
>   i2c7: i2c@400 {
> @@ -919,6 +933,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c8_default>;
>   };
> 
>   i2c8: i2c@480 {
> @@ -931,6 +947,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c9_default>;
>   };
> 
>   i2c9: i2c@500 {
> @@ -943,6 +961,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c10_default>;
>   status = "disabled";
>   };
> 
> @@ -956,6 +976,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c11_default>;
>   status = "disabled";
>   };
> 
> @@ -969,6 +991,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK_APB2>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c12_default>;
>   status = "disabled";
>   };
> 
> @@ -982,6 +1006,8 @@
>   bus-frequency = <10>;
>   interrupts = ;
>   clocks = < ASPEED_CLK

[PATCH 01/10] ARM: dts: ast2600: Add I2C pinctrl

2022-06-20 Thread Joel Stanley 
From: Eddie James 

Set the pinctrl groups for each I2C bus. These are essential to
I2C operating correctly.

Signed-off-by: Eddie James 
Signed-off-by: Joel Stanley 
---
 arch/arm/dts/ast2600.dtsi | 33 +
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi
index 64074309b7b2..ef5b131ac0af 100644
--- a/arch/arm/dts/ast2600.dtsi
+++ b/arch/arm/dts/ast2600.dtsi
@@ -833,6 +833,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c1_default>;
status = "disabled";
};
 
@@ -846,6 +848,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c2_default>;
status = "disabled";
};
 
@@ -859,6 +863,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c3_default>;
};
 
i2c3: i2c@200 {
@@ -871,6 +877,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c4_default>;
};
 
i2c4: i2c@280 {
@@ -883,6 +891,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c5_default>;
};
 
i2c5: i2c@300 {
@@ -895,6 +905,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c6_default>;
};
 
i2c6: i2c@380 {
@@ -907,6 +919,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c7_default>;
};
 
i2c7: i2c@400 {
@@ -919,6 +933,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c8_default>;
};
 
i2c8: i2c@480 {
@@ -931,6 +947,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c9_default>;
};
 
i2c9: i2c@500 {
@@ -943,6 +961,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c10_default>;
status = "disabled";
};
 
@@ -956,6 +976,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c11_default>;
status = "disabled";
};
 
@@ -969,6 +991,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c12_default>;
status = "disabled";
};
 
@@ -982,6 +1006,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c13_default>;
status = "disabled";
};
 
@@ -995,6 +1021,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c14_default>;
status = "disabled";
};
 
@@ -1008,6 +1036,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c15_default>;
status = "disabled";
};
 
@@ -1021,6 +1051,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c16_default>;
status = "disabled";
};
 
@@ -1246,6 +1278,7 @@
function = "I2C1";
groups = "I2C1";
};
+
pinctrl_i2c2_default: i2c2_default {
function = "I2C2";
groups = "I2C2";