RE: [PATCH 01/15] i2c: muxes: pca954x: add PCA9847 variant

[Priyanka Jain]

>-Original Message-
>From: Vladimir Oltean 
>Sent: Thursday, December 2, 2021 8:24 PM
>To: u-boot@lists.denx.de
>Cc: Michael Walle ; Tom Rini ;
>Priyanka Jain ; Leo Li ; Heiko
>Schocher 
>Subject: [PATCH 01/15] i2c: muxes: pca954x: add PCA9847 variant
>
>This seems to be very similar to the already existing PCA9547, save for the 
>fact
>that it supports 0.8V and doesn't support 5V. In fact, it is so similar to the
>PCA9547 that the NXP LS1028A-RDB board has been driving this chip using a
>"nxp,pca9547" compatible string.
>
>Create a new compatible for the PCA9847 (which is the same as in Linux) and
>define the same operating parameters for it as for PCA9547.
>
>Cc: Heiko Schocher 
>Signed-off-by: Vladimir Oltean 
>---

Reviewed-by: Priyanka Jain 

Re: [PATCH 01/15] i2c: muxes: pca954x: add PCA9847 variant

[Heiko Schocher]

Hello Vladimir,

On 02.12.21 15:53, Vladimir Oltean wrote:
> This seems to be very similar to the already existing PCA9547, save for
> the fact that it supports 0.8V and doesn't support 5V. In fact, it is so
> similar to the PCA9547 that the NXP LS1028A-RDB board has been driving
> this chip using a "nxp,pca9547" compatible string.
> 
> Create a new compatible for the PCA9847 (which is the same as in Linux)
> and define the same operating parameters for it as for PCA9547.
> 
> Cc: Heiko Schocher 
> Signed-off-by: Vladimir Oltean 
> ---
>  drivers/i2c/muxes/pca954x.c | 9 -
>  1 file changed, 8 insertions(+), 1 deletion(-)

Reviewed-by: Heiko Schocher 

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de

[PATCH 01/15] i2c: muxes: pca954x: add PCA9847 variant

[Vladimir Oltean]

This seems to be very similar to the already existing PCA9547, save for
the fact that it supports 0.8V and doesn't support 5V. In fact, it is so
similar to the PCA9547 that the NXP LS1028A-RDB board has been driving
this chip using a "nxp,pca9547" compatible string.

Create a new compatible for the PCA9847 (which is the same as in Linux)
and define the same operating parameters for it as for PCA9547.

Cc: Heiko Schocher 
Signed-off-by: Vladimir Oltean 
---
 drivers/i2c/muxes/pca954x.c | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c
index 55858cf653f2..0034dfbf6daf 100644
--- a/drivers/i2c/muxes/pca954x.c
+++ b/drivers/i2c/muxes/pca954x.c
@@ -23,7 +23,8 @@ enum pca_type {
PCA9546,
PCA9547,
PCA9548,
-   PCA9646
+   PCA9646,
+   PCA9847,
 };
 
 struct chip_desc {
@@ -68,6 +69,11 @@ static const struct chip_desc chips[] = {
.muxtype = pca954x_isswi,
.width = 4,
},
+   [PCA9847] = {
+   .enable = 0x8,
+   .muxtype = pca954x_ismux,
+   .width = 8,
+   },
 };
 
 static int pca954x_deselect(struct udevice *mux, struct udevice *bus,
@@ -106,6 +112,7 @@ static const struct udevice_id pca954x_ids[] = {
{ .compatible = "nxp,pca9547", .data = PCA9547 },
{ .compatible = "nxp,pca9548", .data = PCA9548 },
{ .compatible = "nxp,pca9646", .data = PCA9646 },
+   { .compatible = "nxp,pca9847", .data = PCA9847 },
{ }
 };
 
-- 
2.25.1