Re: [PATCH 06/10] pinctrl: qcom: Add support for 'pull-down'

[Caleb Connolly]

On 26/02/2024 10:08, Varadarajan Narayanan wrote:
> Add support for 'pull-down' needed for IPQ9574.
'bias-pull-down'
> 
> Signed-off-by: Varadarajan Narayanan 
Reviewed-by: Caleb Connolly 
> ---
> 
>  drivers/pinctrl/qcom/pinctrl-qcom.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c 
> b/drivers/pinctrl/qcom/pinctrl-qcom.c
> index dc3d8c4d90..ba53b6f290 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qcom.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qcom.c
> @@ -37,6 +37,7 @@ static const struct pinconf_param msm_conf_params[] = {
>   { "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 2 },
>   { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 },
>   { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 3 },
> + { "bias-pull-down", PIN_CONFIG_BIAS_PULL_DOWN, 1 },
>  };
>  
>  static int msm_get_functions_count(struct udevice *dev)
> @@ -104,6 +105,7 @@ static int msm_pinconf_set(struct udevice *dev, unsigned 
> int pin_selector,
>   clrbits_le32(priv->base + GPIO_CONFIG_REG(priv, pin_selector),
>TLMM_GPIO_PULL_MASK);
>   break;
> + case PIN_CONFIG_BIAS_PULL_DOWN:
>   case PIN_CONFIG_BIAS_PULL_UP:
>   clrsetbits_le32(priv->base + GPIO_CONFIG_REG(priv, 
> pin_selector),
>   TLMM_GPIO_PULL_MASK, argument);

-- 
// Caleb (they/them)

[PATCH 06/10] pinctrl: qcom: Add support for 'pull-down'

[Varadarajan Narayanan]

Add support for 'pull-down' needed for IPQ9574.

Signed-off-by: Varadarajan Narayanan 
---

 drivers/pinctrl/qcom/pinctrl-qcom.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c 
b/drivers/pinctrl/qcom/pinctrl-qcom.c
index dc3d8c4d90..ba53b6f290 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcom.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcom.c
@@ -37,6 +37,7 @@ static const struct pinconf_param msm_conf_params[] = {
{ "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 2 },
{ "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 },
{ "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 3 },
+   { "bias-pull-down", PIN_CONFIG_BIAS_PULL_DOWN, 1 },
 };
 
 static int msm_get_functions_count(struct udevice *dev)
@@ -104,6 +105,7 @@ static int msm_pinconf_set(struct udevice *dev, unsigned 
int pin_selector,
clrbits_le32(priv->base + GPIO_CONFIG_REG(priv, pin_selector),
 TLMM_GPIO_PULL_MASK);
break;
+   case PIN_CONFIG_BIAS_PULL_DOWN:
case PIN_CONFIG_BIAS_PULL_UP:
clrsetbits_le32(priv->base + GPIO_CONFIG_REG(priv, 
pin_selector),
TLMM_GPIO_PULL_MASK, argument);
-- 
2.34.1