Re: [PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Simon Glass
Hi Caleb,

On Tue, 21 Nov 2023 at 13:21, Caleb Connolly  wrote:
>
>
>
> On 21/11/2023 19:08, Tom Rini wrote:
> > On Tue, Nov 21, 2023 at 05:09:32PM +, Caleb Connolly wrote:
> >
> >> Revive support for booting db410c using the Linux kernel header, this
> >> allows for testing the board more easily via `fastboot`.
> >>
> >> Signed-off-by: Caleb Connolly 
> >> ---
> >>  board/qualcomm/dragonboard410c/MAINTAINERS|  1 +
> >>  configs/dragonboard410c_chainloaded_defconfig | 75 
> >> +++
> >>  2 files changed, 76 insertions(+)
> >
> > How different is this from the regular defconfig, and assuming this is
> > also a partial answer to my question about "why not select?", why is
> > this not just a config fragment instead of a whole new defconfig to keep
> > in sync?
>
> Oh, I was totally unaware of the concept of board config fragments in
> U-Boot. That's definitely a much cleaner solution.

Can you make a single image that handles both?

There is ll_boot_init()

Regards,
Simon


Re: [PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Caleb Connolly



On 21/11/2023 19:08, Tom Rini wrote:
> On Tue, Nov 21, 2023 at 05:09:32PM +, Caleb Connolly wrote:
> 
>> Revive support for booting db410c using the Linux kernel header, this
>> allows for testing the board more easily via `fastboot`.
>>
>> Signed-off-by: Caleb Connolly 
>> ---
>>  board/qualcomm/dragonboard410c/MAINTAINERS|  1 +
>>  configs/dragonboard410c_chainloaded_defconfig | 75 
>> +++
>>  2 files changed, 76 insertions(+)
> 
> How different is this from the regular defconfig, and assuming this is
> also a partial answer to my question about "why not select?", why is
> this not just a config fragment instead of a whole new defconfig to keep
> in sync?

Oh, I was totally unaware of the concept of board config fragments in
U-Boot. That's definitely a much cleaner solution.
> 

-- 
// Caleb (they/them)


Re: [PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 05:09:32PM +, Caleb Connolly wrote:

> Revive support for booting db410c using the Linux kernel header, this
> allows for testing the board more easily via `fastboot`.
> 
> Signed-off-by: Caleb Connolly 
> ---
>  board/qualcomm/dragonboard410c/MAINTAINERS|  1 +
>  configs/dragonboard410c_chainloaded_defconfig | 75 
> +++
>  2 files changed, 76 insertions(+)

How different is this from the regular defconfig, and assuming this is
also a partial answer to my question about "why not select?", why is
this not just a config fragment instead of a whole new defconfig to keep
in sync?

-- 
Tom


signature.asc
Description: PGP signature


[PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Caleb Connolly
Revive support for booting db410c using the Linux kernel header, this
allows for testing the board more easily via `fastboot`.

Signed-off-by: Caleb Connolly 
---
 board/qualcomm/dragonboard410c/MAINTAINERS|  1 +
 configs/dragonboard410c_chainloaded_defconfig | 75 +++
 2 files changed, 76 insertions(+)

diff --git a/board/qualcomm/dragonboard410c/MAINTAINERS 
b/board/qualcomm/dragonboard410c/MAINTAINERS
index e78f5b2d6421..653b91b44377 100644
--- a/board/qualcomm/dragonboard410c/MAINTAINERS
+++ b/board/qualcomm/dragonboard410c/MAINTAINERS
@@ -4,4 +4,5 @@ S:  Maintained
 F: board/qualcomm/dragonboard410c/
 F: include/configs/dragonboard410c.h
 F: configs/dragonboard410c_defconfig
+F: configs/dragonboard410c_chainloaded_defconfig
 F: doc/board/qualcomm/dragonboard410c.rst
diff --git a/configs/dragonboard410c_chainloaded_defconfig 
b/configs/dragonboard410c_chainloaded_defconfig
new file mode 100644
index ..d6860f546e9e
--- /dev/null
+++ b/configs/dragonboard410c_chainloaded_defconfig
@@ -0,0 +1,75 @@
+CONFIG_ARM=y
+CONFIG_COUNTER_FREQUENCY=1900
+CONFIG_ARCH_SNAPDRAGON=y
+CONFIG_TARGET_QCOM=y
+CONFIG_POSITION_INDEPENDENT=y
+CONFIG_SYS_MALLOC_LEN=0x802000
+CONFIG_ENV_SIZE=0x2000
+CONFIG_ENV_OFFSET=0x0
+CONFIG_DEFAULT_DEVICE_TREE="dragonboard410c"
+CONFIG_SYS_BOARD="dragonboard410c"
+CONFIG_OF_LIBFDT_OVERLAY=y
+CONFIG_IDENT_STRING="\nQualcomm-DragonBoard 410C"
+CONFIG_SYS_LOAD_ADDR=0x8008
+CONFIG_REMAKE_ELF=y
+# CONFIG_ANDROID_BOOT_IMAGE is not set
+CONFIG_FIT=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_OF_BOARD_SETUP=y
+CONFIG_USE_PREBOOT=y
+# CONFIG_DISPLAY_CPUINFO is not set
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_MISC_INIT_R=y
+CONFIG_LINUX_KERNEL_IMAGE_HEADER=y
+CONFIG_SYS_PROMPT="dragonboard410c => "
+CONFIG_SYS_MAXARGS=64
+CONFIG_SYS_CBSIZE=512
+CONFIG_SYS_PBSIZE=548
+# CONFIG_CMD_IMI is not set
+CONFIG_CMD_MD5SUM=y
+CONFIG_CMD_MEMINFO=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
+CONFIG_BOOTP_BOOTFILESIZE=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_TIMER=y
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_SYS_MMC_ENV_PART=2
+CONFIG_CLK=y
+CONFIG_CLK_QCOM_APQ8016=y
+CONFIG_USB_FUNCTION_FASTBOOT=y
+CONFIG_FASTBOOT_BUF_ADDR=0x9100
+CONFIG_FASTBOOT_FLASH=y
+CONFIG_FASTBOOT_FLASH_MMC_DEV=0
+CONFIG_MSM_GPIO=y
+CONFIG_QCOM_PMIC_GPIO=y
+CONFIG_LED=y
+CONFIG_LED_GPIO=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_MSM=y
+CONFIG_PHY=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_QCOM_APQ8016=y
+CONFIG_PINCONF=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_QCOM=y
+CONFIG_MSM_SERIAL=y
+CONFIG_SPMI_MSM=y
+CONFIG_BUTTON_QCOM_PMIC=y
+CONFIG_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_MSM=y
+CONFIG_USB_ULPI_VIEWPORT=y
+CONFIG_USB_ULPI=y
+CONFIG_USB_HOST_ETHER=y
+CONFIG_USB_ETHER_ASIX=y
+CONFIG_USB_ETHER_ASIX88179=y
+CONFIG_USB_ETHER_MCS7830=y
+CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
+CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
+CONFIG_CI_UDC=y

-- 
2.42.1