Re: [PATCH 1/1] Dockerfile: add imagemagick

2020-02-21 Thread Tom Rini
On Fri, Feb 21, 2020 at 06:14:44AM +0100, Heinrich Schuchardt wrote:

> In reStructured text documentation we sometimes find formatting problems.
> So we should add 'make htmldocs' to our Gitlab Ci steps and let all
> warning result in a build failure.
> 
> For building the htmldocs target without warnings we need the ImageMagick
> package.
> 
> Reviewed-by: Bin Meng 
> Signed-off-by: Heinrich Schuchardt 

Applied to gitlab-ci-runner/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH 1/1] Dockerfile: add imagemagick

2020-02-21 Thread Bin Meng
On Fri, Feb 21, 2020 at 1:15 PM Heinrich Schuchardt  wrote:
>
> In reStructured text documentation we sometimes find formatting problems.
> So we should add 'make htmldocs' to our Gitlab Ci steps and let all
> warning result in a build failure.
>
> For building the htmldocs target without warnings we need the ImageMagick
> package.
>
> Signed-off-by: Heinrich Schuchardt 
> ---
>  Dockerfile | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng 


[PATCH 1/1] Dockerfile: add imagemagick

2020-02-20 Thread Heinrich Schuchardt
In reStructured text documentation we sometimes find formatting problems.
So we should add 'make htmldocs' to our Gitlab Ci steps and let all
warning result in a build failure.

For building the htmldocs target without warnings we need the ImageMagick
package.

Signed-off-by: Heinrich Schuchardt 
---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Dockerfile b/Dockerfile
index 1f8f7a4..32d43f7 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -53,6 +53,7 @@ RUN apt-get update && apt-get install -y \
grub-efi-amd64-bin \
grub-efi-ia32-bin \
iasl \
+   imagemagick \
iputils-ping \
libisl15 \
liblz4-tool \
--
2.25.0