Re: [PATCH 1/1] mtd: misplaced log.h and dm/devres.h
On Sun, Jan 03, 2021 at 04:10:45PM +0100, Heinrich Schuchardt wrote: > log.h and dm/devres.h are U-Boot includes. So placing them > behind #ifndef __UBOOT__ does not make any sense. > > Fixes: f7ae49fc4f36 ("common: Drop log.h from common header") > Fixes: 61b29b826838 ("dm: core: Require users of devres to include the > header") > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH 1/1] mtd: misplaced log.h and dm/devres.h
On Sun, 3 Jan 2021 at 08:10, Heinrich Schuchardt wrote: > > log.h and dm/devres.h are U-Boot includes. So placing them > behind #ifndef __UBOOT__ does not make any sense. > > Fixes: f7ae49fc4f36 ("common: Drop log.h from common header") > Fixes: 61b29b826838 ("dm: core: Require users of devres to include the > header") > Signed-off-by: Heinrich Schuchardt > --- > drivers/mtd/mtdcore.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Simon Glass
[PATCH 1/1] mtd: misplaced log.h and dm/devres.h
log.h and dm/devres.h are U-Boot includes. So placing them behind #ifndef __UBOOT__ does not make any sense. Fixes: f7ae49fc4f36 ("common: Drop log.h from common header") Fixes: 61b29b826838 ("dm: core: Require users of devres to include the header") Signed-off-by: Heinrich Schuchardt --- drivers/mtd/mtdcore.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 1a4dec34d9..0d1f94c6cb 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -9,8 +9,6 @@ */ #ifndef __UBOOT__ -#include -#include #include #include #include -- 2.29.2