Re: [PATCH 1/2] CI: Allow job tag to be optionally set globally

2023-03-22 Thread Tom Rini
On Fri, Mar 10, 2023 at 09:53:02AM +, Peter Hoyes wrote:

> From: Peter Hoyes 
> 
> The default behavior of Gitlab runners is to only run jobs which match
> the configured tag, although there is an option to run untagged jobs
> [1].
> 
> To support running the CI in more complex environments where different
> types of runners may be present that support different tags, allow the
> DEFAULT_TAG for all jobs in the pipeline to be set globally using an
> environment variable. An empty default value is provided to retain
> support for untagged runners.
> 
> [1] 
> https://docs.gitlab.com/ee/ci/runners/configure_runners.html#use-tags-to-control-which-jobs-a-runner-can-run
> 
> Signed-off-by: Peter Hoyes 
> Reviewed-by: Simon Glass 
> Reviewed-by: Tom Rini 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH 1/2] CI: Allow job tag to be optionally set globally

2023-03-17 Thread Tom Rini
On Fri, Mar 10, 2023 at 09:53:02AM +, Peter Hoyes wrote:

> From: Peter Hoyes 
> 
> The default behavior of Gitlab runners is to only run jobs which match
> the configured tag, although there is an option to run untagged jobs
> [1].
> 
> To support running the CI in more complex environments where different
> types of runners may be present that support different tags, allow the
> DEFAULT_TAG for all jobs in the pipeline to be set globally using an
> environment variable. An empty default value is provided to retain
> support for untagged runners.
> 
> [1] 
> https://docs.gitlab.com/ee/ci/runners/configure_runners.html#use-tags-to-control-which-jobs-a-runner-can-run
> 
> Signed-off-by: Peter Hoyes 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH 1/2] CI: Allow job tag to be optionally set globally

2023-03-10 Thread Simon Glass
On Fri, 10 Mar 2023 at 01:54, Peter Hoyes  wrote:
>
> From: Peter Hoyes 
>
> The default behavior of Gitlab runners is to only run jobs which match
> the configured tag, although there is an option to run untagged jobs
> [1].
>
> To support running the CI in more complex environments where different
> types of runners may be present that support different tags, allow the
> DEFAULT_TAG for all jobs in the pipeline to be set globally using an
> environment variable. An empty default value is provided to retain
> support for untagged runners.
>
> [1] 
> https://docs.gitlab.com/ee/ci/runners/configure_runners.html#use-tags-to-control-which-jobs-a-runner-can-run
>
> Signed-off-by: Peter Hoyes 
> ---
>  .gitlab-ci.yml | 7 +++
>  1 file changed, 7 insertions(+)

Reviewed-by: Simon Glass 


[PATCH 1/2] CI: Allow job tag to be optionally set globally

2023-03-10 Thread Peter Hoyes
From: Peter Hoyes 

The default behavior of Gitlab runners is to only run jobs which match
the configured tag, although there is an option to run untagged jobs
[1].

To support running the CI in more complex environments where different
types of runners may be present that support different tags, allow the
DEFAULT_TAG for all jobs in the pipeline to be set globally using an
environment variable. An empty default value is provided to retain
support for untagged runners.

[1] 
https://docs.gitlab.com/ee/ci/runners/configure_runners.html#use-tags-to-control-which-jobs-a-runner-can-run

Signed-off-by: Peter Hoyes 
---
 .gitlab-ci.yml | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 272d69e220..d54694e016 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,5 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0+
 
+variables:
+  DEFAULT_TAG: ""
+
+default:
+  tags:
+- ${DEFAULT_TAG}
+
 # Grab our configured image.  The source for this is found
 # in the u-boot tree at tools/docker/Dockerfile
 image: trini/u-boot-gitlab-ci-runner:jammy-20230126-10Feb2023
-- 
2.34.1