On 08/09/21 05:47PM, tkuw584...@gmail.com wrote:
> From: Takahiro Kuwano
>
> The S25FL256L is a part of the S25FL-L family and has the same feature set
> as S25FL128L except the density.
>
> The datasheet can be found in the following link.
> https://www.cypress.com/file/316171/download
>
> Tested on Xilinx Zynq-7000 FPGA board.
I think you should add fixups and the flash entry in the same commit
instead of adding them in separate ones. This would make sure the flash
works correctly if someone lands on this commit when bisecting.
The patch LGTM otherwise.
>
> Signed-off-by: Takahiro Kuwano
> ---
> drivers/mtd/spi/spi-nor-ids.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e..11d7d4fcaa 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -227,6 +227,7 @@ const struct flash_info spi_nor_ids[] = {
> { INFO("s25fl208k", 0x014014, 0, 64 * 1024, 16, SECT_4K |
> SPI_NOR_DUAL_READ) },
> { INFO("s25fl064l", 0x016017, 0, 64 * 1024, 128, SECT_4K |
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> { INFO("s25fl128l", 0x016018, 0, 64 * 1024, 256, SECT_4K |
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> + { INFO("s25fl256l", 0x016019, 0, 64 * 1024, 512, SECT_4K |
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> { INFO6("s25hl512t", 0x342a1a, 0x0f0390, 256 * 1024, 256,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES |
> USE_CLSR) },
> --
> 2.25.1
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
