Re: [PATCH 1/2] test/py: efi_secboot should not assume sbin is in the path

2020-05-17 Thread AKASHI Takahiro 
On Fri, May 15, 2020 at 05:39:31PM +0200, Heinrich Schuchardt wrote:
> On 22.04.20 17:52, Heinrich Schuchardt wrote:
> > For non-root users /sbin is typically not in the path. So use absolute
> > paths to mkfs.vfat and sgdisk.
> 
> Ilias pointed me to virt-make-fs (Debian package libguestfs-tools). With
> this command the creation of file systems would become much easier.

Okay, and are you going to revert this change and submit another patch?

-Takahiro Akashi

> Best regards
> 
> Heinrich
> 
> >
> > Signed-off-by: Heinrich Schuchardt 
> > ---
> >  test/py/tests/test_efi_secboot/conftest.py | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/test/py/tests/test_efi_secboot/conftest.py 
> > b/test/py/tests/test_efi_secboot/conftest.py
> > index e542fef6e8..40cdf15bf2 100644
> > --- a/test/py/tests/test_efi_secboot/conftest.py
> > +++ b/test/py/tests/test_efi_secboot/conftest.py
> > @@ -48,12 +48,12 @@ def efi_boot_env(request, u_boot_config):
> >  # create a disk/partition
> >  check_call('dd if=/dev/zero of=%s bs=1MiB count=%d'
> >  % (image_path, image_size), shell=True)
> > -check_call('sgdisk %s -n 1:0:+%dMiB'
> > +check_call('/sbin/sgdisk %s -n 1:0:+%dMiB'
> >  % (image_path, part_size), shell=True)
> >  # create a file system
> >  check_call('dd if=/dev/zero of=%s.tmp bs=1MiB count=%d'
> >  % (image_path, part_size), shell=True)
> > -check_call('mkfs -t %s %s.tmp' % (fs_type, image_path), shell=True)
> > +check_call('/sbin/mkfs.%s %s.tmp' % (fs_type, image_path), 
> > shell=True)
> >  check_call('dd if=%s.tmp of=%s bs=1MiB seek=1 count=%d 
> > conv=notrunc'
> >  % (image_path, image_path, 1), shell=True)
> >  check_call('rm %s.tmp' % image_path, shell=True)
> > --
> > 2.26.1
> >
> 
>

Re: [PATCH 1/2] test/py: efi_secboot should not assume sbin is in the path

2020-05-15 Thread Heinrich Schuchardt 
On 22.04.20 17:52, Heinrich Schuchardt wrote:
> For non-root users /sbin is typically not in the path. So use absolute
> paths to mkfs.vfat and sgdisk.

Ilias pointed me to virt-make-fs (Debian package libguestfs-tools). With
this command the creation of file systems would become much easier.

Best regards

Heinrich

>
> Signed-off-by: Heinrich Schuchardt 
> ---
>  test/py/tests/test_efi_secboot/conftest.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/py/tests/test_efi_secboot/conftest.py 
> b/test/py/tests/test_efi_secboot/conftest.py
> index e542fef6e8..40cdf15bf2 100644
> --- a/test/py/tests/test_efi_secboot/conftest.py
> +++ b/test/py/tests/test_efi_secboot/conftest.py
> @@ -48,12 +48,12 @@ def efi_boot_env(request, u_boot_config):
>  # create a disk/partition
>  check_call('dd if=/dev/zero of=%s bs=1MiB count=%d'
>  % (image_path, image_size), shell=True)
> -check_call('sgdisk %s -n 1:0:+%dMiB'
> +check_call('/sbin/sgdisk %s -n 1:0:+%dMiB'
>  % (image_path, part_size), shell=True)
>  # create a file system
>  check_call('dd if=/dev/zero of=%s.tmp bs=1MiB count=%d'
>  % (image_path, part_size), shell=True)
> -check_call('mkfs -t %s %s.tmp' % (fs_type, image_path), shell=True)
> +check_call('/sbin/mkfs.%s %s.tmp' % (fs_type, image_path), 
> shell=True)
>  check_call('dd if=%s.tmp of=%s bs=1MiB seek=1 count=%d conv=notrunc'
>  % (image_path, image_path, 1), shell=True)
>  check_call('rm %s.tmp' % image_path, shell=True)
> --
> 2.26.1
>

Re: [PATCH 1/2] test/py: efi_secboot should not assume sbin is in the path

2020-04-22 Thread AKASHI Takahiro 
Heinrich,

On Wed, Apr 22, 2020 at 05:52:54PM +0200, Heinrich Schuchardt wrote:
> For non-root users /sbin is typically not in the path. So use absolute
> paths to mkfs.vfat and sgdisk.

As Stephen pointed out somewhere else else before, you should
set $PATH properly instead of using an absolute path directly.

Thanks,
-Takahiro Akashi



> Signed-off-by: Heinrich Schuchardt 
> ---
>  test/py/tests/test_efi_secboot/conftest.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/py/tests/test_efi_secboot/conftest.py 
> b/test/py/tests/test_efi_secboot/conftest.py
> index e542fef6e8..40cdf15bf2 100644
> --- a/test/py/tests/test_efi_secboot/conftest.py
> +++ b/test/py/tests/test_efi_secboot/conftest.py
> @@ -48,12 +48,12 @@ def efi_boot_env(request, u_boot_config):
>  # create a disk/partition
>  check_call('dd if=/dev/zero of=%s bs=1MiB count=%d'
>  % (image_path, image_size), shell=True)
> -check_call('sgdisk %s -n 1:0:+%dMiB'
> +check_call('/sbin/sgdisk %s -n 1:0:+%dMiB'
>  % (image_path, part_size), shell=True)
>  # create a file system
>  check_call('dd if=/dev/zero of=%s.tmp bs=1MiB count=%d'
>  % (image_path, part_size), shell=True)
> -check_call('mkfs -t %s %s.tmp' % (fs_type, image_path), shell=True)
> +check_call('/sbin/mkfs.%s %s.tmp' % (fs_type, image_path), 
> shell=True)
>  check_call('dd if=%s.tmp of=%s bs=1MiB seek=1 count=%d conv=notrunc'
>  % (image_path, image_path, 1), shell=True)
>  check_call('rm %s.tmp' % image_path, shell=True)
> --
> 2.26.1
>

[PATCH 1/2] test/py: efi_secboot should not assume sbin is in the path

2020-04-22 Thread Heinrich Schuchardt 
For non-root users /sbin is typically not in the path. So use absolute
paths to mkfs.vfat and sgdisk.

Signed-off-by: Heinrich Schuchardt 
---
 test/py/tests/test_efi_secboot/conftest.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/py/tests/test_efi_secboot/conftest.py 
b/test/py/tests/test_efi_secboot/conftest.py
index e542fef6e8..40cdf15bf2 100644
--- a/test/py/tests/test_efi_secboot/conftest.py
+++ b/test/py/tests/test_efi_secboot/conftest.py
@@ -48,12 +48,12 @@ def efi_boot_env(request, u_boot_config):
 # create a disk/partition
 check_call('dd if=/dev/zero of=%s bs=1MiB count=%d'
 % (image_path, image_size), shell=True)
-check_call('sgdisk %s -n 1:0:+%dMiB'
+check_call('/sbin/sgdisk %s -n 1:0:+%dMiB'
 % (image_path, part_size), shell=True)
 # create a file system
 check_call('dd if=/dev/zero of=%s.tmp bs=1MiB count=%d'
 % (image_path, part_size), shell=True)
-check_call('mkfs -t %s %s.tmp' % (fs_type, image_path), shell=True)
+check_call('/sbin/mkfs.%s %s.tmp' % (fs_type, image_path), shell=True)
 check_call('dd if=%s.tmp of=%s bs=1MiB seek=1 count=%d conv=notrunc'
 % (image_path, image_path, 1), shell=True)
 check_call('rm %s.tmp' % image_path, shell=True)
--
2.26.1