Re: [PATCH 1/3] common: Makefile: drop duplicated line

2021-01-18 Thread Tom Rini 
On Mon, Dec 28, 2020 at 08:13:11PM +0800, Peng Fan (OSS) wrote:

> From: Peng Fan 
> 
> obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there,
> no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
> 
> Signed-off-by: Peng Fan 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH 1/3] common: Makefile: drop duplicated line

2020-12-28 Thread Simon Glass 
On Mon, 28 Dec 2020 at 04:44, Peng Fan (OSS)  wrote:
>
> From: Peng Fan 
>
> obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there,
> no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
>
> Signed-off-by: Peng Fan 
> ---
>  common/Makefile | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Simon Glass

[PATCH 1/3] common: Makefile: drop duplicated line

2020-12-28 Thread Peng Fan (OSS) 
From: Peng Fan 

obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there,
no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o

Signed-off-by: Peng Fan 
---
 common/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/common/Makefile b/common/Makefile
index bcf352d016..daeea67cf2 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -68,7 +68,6 @@ obj-$(CONFIG_DFU_OVER_USB) += dfu.o
 endif
 obj-$(CONFIG_SPL_HASH_SUPPORT) += hash.o
 obj-$(CONFIG_TPL_HASH_SUPPORT) += hash.o
-obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
 obj-$(CONFIG_SPL_LOAD_FIT) += common_fit.o
 obj-$(CONFIG_SPL_NET_SUPPORT) += miiphyutil.o
 obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += fdt_support.o
-- 
2.28.0