Re: [PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods

2020-06-01 Thread Bin Meng 
On Mon, Jun 1, 2020 at 12:15 PM Bin Meng  wrote:
>
> Create buffers outside of the methods as ACPICA 20200430 complains
> about this:
>
>   Remark 2173 - Creation of named objects within a method is highly
>   inefficient, use globals or method local variables instead
>   (\_SB.PCI0.LPCB.IURT._CRS)
>
> Signed-off-by: Bin Meng 
> ---
>
>  arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 
>  1 file changed, 12 insertions(+), 12 deletions(-)
>

applied to u-boot-x86, thanks!

[PATCH 1/3] x86: baytrail: acpi: Create buffers outside of the methods

2020-05-31 Thread Bin Meng 
Create buffers outside of the methods as ACPICA 20200430 complains
about this:

  Remark 2173 - Creation of named objects within a method is highly
  inefficient, use globals or method local variables instead
  (\_SB.PCI0.LPCB.IURT._CRS)

Signed-off-by: Bin Meng 
---

 arch/x86/include/asm/arch-baytrail/acpi/lpc.asl | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl 
b/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl
index 08b2f53..69455d9 100644
--- a/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl
+++ b/arch/x86/include/asm/arch-baytrail/acpi/lpc.asl
@@ -136,20 +136,20 @@ Device (LPCB)
Store(0, C1EN)
}
 
-   Method(_CRS, 0, Serialized)
+   Name(BUF0, ResourceTemplate()
{
-   Name(BUF0, ResourceTemplate()
-   {
-   IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
-   IRQNoFlags() { 3 }
-   })
-
-   Name(BUF1, ResourceTemplate()
-   {
-   IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
-   IRQNoFlags() { 4 }
-   })
+   IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
+   IRQNoFlags() { 3 }
+   })
 
+   Name(BUF1, ResourceTemplate()
+   {
+   IO(Decode16, 0x03f8, 0x03f8, 0x01, 0x08)
+   IRQNoFlags() { 4 }
+   })
+
+   Method(_CRS, 0, Serialized)
+   {
If (LLessEqual(SRID, 0x04)) {
Return (BUF0)
} Else {
-- 
2.7.4