Re: [PATCH 1/4] serial: serial_xen: print U-Boot banner and others

2020-10-23 Thread Anastasiia Lukianenko 
Hello,

On Thu, 2020-10-22 at 18:49 +0900, takahiro.aka...@linaro.org wrote:
> On Thu, Oct 22, 2020 at 09:18:02AM +, Anastasiia Lukianenko
> wrote:
> > Hi,
> > 
> > On Thu, 2020-10-15 at 13:25 +0900, AKASHI Takahiro wrote:
> > > At present, DM_FLAG_PRE_RELOC is set only if !OF_CONTROL.
> > > It doesn't make sense for this para-virtualized driver.
> > > 
> > > With this patch applied, you will be able to see early boot
> > > messages:
> > > 
> > > U-Boot 2020.10-1-ge442e71a6c52-dirty (Oct 15 2020 - 11:02:25
> > > +0900)
> > > xenguest
> > > 
> > > Xen virtual CPU
> > > Model: XENVM-4.15
> > > DRAM:  128 MiB
> > > PVBLOCK:
> > > (XEN) gnttab_mark_dirty not implemented yet
> > > pvblock: 0
> > > In:hypervisor
> > > Out:   hypervisor
> > > Err:   hypervisor
> > > xenguest#
> > > 
> > > Signed-off-by: AKASHI Takahiro 
> > > ---
> > >  drivers/serial/serial_xen.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/serial/serial_xen.c
> > > b/drivers/serial/serial_xen.c
> > > index ba6504b94796..ed191829f059 100644
> > > --- a/drivers/serial/serial_xen.c
> > > +++ b/drivers/serial/serial_xen.c
> > > @@ -175,8 +175,6 @@ U_BOOT_DRIVER(serial_xen) = {
> > >   .priv_auto_alloc_size   = sizeof(struct xen_uart_priv),
> > >   .probe  = xen_serial_probe,
> > >   .ops= _serial_ops,
> > > -#if !CONFIG_IS_ENABLED(OF_CONTROL)
> > >   .flags  = DM_FLAG_PRE_RELOC,
> > > -#endif
> > >  };
> > >  
> > 
> > I applied this patch and unfortunately on ARM there were no logs. I
> > think this series should be improved a little.
> 
> I will check.
> Please tell me
>  - the board that you're using
>  - the version of Xen
>(and .config)
> 
Board is based on imx8qm
Xen version 4.13.0
.config:
#
# Automatically generated file; DO NOT EDIT.
# U-Boot 2020.10 Configuration
#

#
# Compiler: aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
7.5.0
#
CONFIG_CREATE_ARCH_SYMLINK=y
# CONFIG_ARC is not set
CONFIG_ARM=y
# CONFIG_M68K is not set
# CONFIG_MICROBLAZE is not set
# CONFIG_MIPS is not set
# CONFIG_NDS32 is not set
# CONFIG_NIOS2 is not set
# CONFIG_PPC is not set
# CONFIG_RISCV is not set
# CONFIG_SANDBOX is not set
# CONFIG_SH is not set
# CONFIG_X86 is not set
# CONFIG_XTENSA is not set
CONFIG_SYS_ARCH="arm"
CONFIG_SYS_CPU="armv8"
CONFIG_SYS_VENDOR="xen"
CONFIG_SYS_BOARD="xenguest_arm64"
CONFIG_SYS_CONFIG_NAME="xenguest_arm64"
# CONFIG_SYS_ICACHE_OFF is not set
# CONFIG_SYS_DCACHE_OFF is not set

#
# ARM architecture
#
CONFIG_ARM64=y
CONFIG_POSITION_INDEPENDENT=y
CONFIG_INIT_SP_RELATIVE=y
CONFIG_SYS_INIT_SP_BSS_OFFSET=524288
CONFIG_LINUX_KERNEL_IMAGE_HEADER=y
# CONFIG_GIC_V3_ITS is not set
CONFIG_STATIC_RELA=y
CONFIG_DMA_ADDR_T_64BIT=y
CONFIG_ARM_ASM_UNIFIED=y
# CONFIG_SYS_ARM_CACHE_CP15 is not set
# CONFIG_SYS_ARM_MMU is not set
# CONFIG_SYS_ARM_MPU is not set
CONFIG_SYS_ARM_ARCH=8
CONFIG_SYS_CACHE_SHIFT_6=y
CONFIG_SYS_CACHELINE_SIZE=64
CONFIG_SYS_ARM_CACHE_WRITEBACK=y
# CONFIG_SYS_ARM_CACHE_WRITETHROUGH is not set
# CONFIG_SYS_ARM_CACHE_WRITEALLOC is not set
# CONFIG_ARCH_CPU_INIT is not set
CONFIG_SYS_ARCH_TIMER=y
CONFIG_ARM_SMCCC=y
# CONFIG_SEMIHOSTING is not set
# CONFIG_SYS_L2CACHE_OFF is not set
# CONFIG_ENABLE_ARM_SOC_BOOT0_HOOK is not set
CONFIG_ARM64_SUPPORT_AARCH32=y
# CONFIG_ARCH_AT91 is not set
# CONFIG_TARGET_EDB93XX is not set
# CONFIG_TARGET_ASPENITE is not set
# CONFIG_TARGET_GPLUGD is not set
# CONFIG_ARCH_DAVINCI is not set
# CONFIG_ARCH_KIRKWOOD is not set
# CONFIG_ARCH_MVEBU is not set
# CONFIG_TARGET_APF27 is not set
# CONFIG_ARCH_ORION5X is not set
# CONFIG_TARGET_SPEAR300 is not set
# CONFIG_TARGET_SPEAR310 is not set
# CONFIG_TARGET_SPEAR320 is not set
# CONFIG_TARGET_SPEAR600 is not set
# CONFIG_TARGET_STV0991 is not set
# CONFIG_TARGET_X600 is not set
# CONFIG_TARGET_FLEA3 is not set
# CONFIG_TARGET_MX35PDK is not set
# CONFIG_ARCH_BCM283X is not set
# CONFIG_ARCH_BCM63158 is not set
# CONFIG_ARCH_BCM68360 is not set
# CONFIG_ARCH_BCM6858 is not set
# CONFIG_TARGET_VEXPRESS_CA15_TC2 is not set
# CONFIG_ARCH_BCMSTB is not set
# CONFIG_TARGET_VEXPRESS_CA5X2 is not set
# CONFIG_TARGET_VEXPRESS_CA9X4 is not set
# CONFIG_TARGET_BCM23550_W1D is not set
# CONFIG_TARGET_BCM28155_AP is not set
# CONFIG_TARGET_BCMCYGNUS is not set
# CONFIG_TARGET_BCMNSP is not set
# CONFIG_TARGET_BCMNS2 is not set
# CONFIG_TARGET_BCMNS3 is not set
# CONFIG_ARCH_EXYNOS is not set
# CONFIG_ARCH_S5PC1XX is not set
# CONFIG_ARCH_HIGHBANK is not set
# CONFIG_ARCH_INTEGRATOR is not set
# CONFIG_ARCH_IPQ40XX is not set
# CONFIG_ARCH_KEYSTONE is not set
# CONFIG_ARCH_K3 is not set
# CONFIG_ARCH_OMAP2PLUS is not set
# CONFIG_ARCH_MESON is not set
# CONFIG_ARCH_MEDIATEK is not set
# CONFIG_ARCH_LPC32XX is not set
# CONFIG_ARCH_IMX8 is not set
# CONFIG_ARCH_IMX8M is not set
# CONFIG_ARCH_IMXRT is not set
# CONFIG_ARCH_MX23 is not set
# CONFIG_ARCH_MX25 is not set
# CONFIG_ARCH_MX28 is not set
# CONFIG_ARCH_MX31 is not set
# CONFIG_ARCH_MX7ULP is

Re: [PATCH 1/4] serial: serial_xen: print U-Boot banner and others

2020-10-22 Thread Tom Rini 
On Thu, Oct 15, 2020 at 01:25:13PM +0900, AKASHI Takahiro wrote:

> At present, DM_FLAG_PRE_RELOC is set only if !OF_CONTROL.
> It doesn't make sense for this para-virtualized driver.
> 
> With this patch applied, you will be able to see early boot messages:
> 
> U-Boot 2020.10-1-ge442e71a6c52-dirty (Oct 15 2020 - 11:02:25 +0900)
> xenguest
> 
> Xen virtual CPU
> Model: XENVM-4.15
> DRAM:  128 MiB
> PVBLOCK:
> (XEN) gnttab_mark_dirty not implemented yet
> pvblock: 0
> In:hypervisor
> Out:   hypervisor
> Err:   hypervisor
> xenguest#
> 
> Signed-off-by: AKASHI Takahiro 
> Reviewed-by: Peng Fan 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH 1/4] serial: serial_xen: print U-Boot banner and others

2020-10-22 Thread takahiro.aka...@linaro.org 
On Thu, Oct 22, 2020 at 09:18:02AM +, Anastasiia Lukianenko wrote:
> Hi,
> 
> On Thu, 2020-10-15 at 13:25 +0900, AKASHI Takahiro wrote:
> > At present, DM_FLAG_PRE_RELOC is set only if !OF_CONTROL.
> > It doesn't make sense for this para-virtualized driver.
> > 
> > With this patch applied, you will be able to see early boot messages:
> > 
> > U-Boot 2020.10-1-ge442e71a6c52-dirty (Oct 15 2020 - 11:02:25
> > +0900)
> > xenguest
> > 
> > Xen virtual CPU
> > Model: XENVM-4.15
> > DRAM:  128 MiB
> > PVBLOCK:
> > (XEN) gnttab_mark_dirty not implemented yet
> > pvblock: 0
> > In:hypervisor
> > Out:   hypervisor
> > Err:   hypervisor
> > xenguest#
> > 
> > Signed-off-by: AKASHI Takahiro 
> > ---
> >  drivers/serial/serial_xen.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/serial/serial_xen.c
> > b/drivers/serial/serial_xen.c
> > index ba6504b94796..ed191829f059 100644
> > --- a/drivers/serial/serial_xen.c
> > +++ b/drivers/serial/serial_xen.c
> > @@ -175,8 +175,6 @@ U_BOOT_DRIVER(serial_xen) = {
> > .priv_auto_alloc_size   = sizeof(struct xen_uart_priv),
> > .probe  = xen_serial_probe,
> > .ops= _serial_ops,
> > -#if !CONFIG_IS_ENABLED(OF_CONTROL)
> > .flags  = DM_FLAG_PRE_RELOC,
> > -#endif
> >  };
> >  
> 
> I applied this patch and unfortunately on ARM there were no logs. I
> think this series should be improved a little.

I will check.
Please tell me
 - the board that you're using
 - the version of Xen
   (and .config)

Thanks,
-Takahiro Akashi

> Regards,
> Anastasiia

Re: [PATCH 1/4] serial: serial_xen: print U-Boot banner and others

2020-10-22 Thread Anastasiia Lukianenko 
Hi,

On Thu, 2020-10-15 at 13:25 +0900, AKASHI Takahiro wrote:
> At present, DM_FLAG_PRE_RELOC is set only if !OF_CONTROL.
> It doesn't make sense for this para-virtualized driver.
> 
> With this patch applied, you will be able to see early boot messages:
> 
> U-Boot 2020.10-1-ge442e71a6c52-dirty (Oct 15 2020 - 11:02:25
> +0900)
> xenguest
> 
> Xen virtual CPU
> Model: XENVM-4.15
> DRAM:  128 MiB
> PVBLOCK:
> (XEN) gnttab_mark_dirty not implemented yet
> pvblock: 0
> In:hypervisor
> Out:   hypervisor
> Err:   hypervisor
> xenguest#
> 
> Signed-off-by: AKASHI Takahiro 
> ---
>  drivers/serial/serial_xen.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/serial/serial_xen.c
> b/drivers/serial/serial_xen.c
> index ba6504b94796..ed191829f059 100644
> --- a/drivers/serial/serial_xen.c
> +++ b/drivers/serial/serial_xen.c
> @@ -175,8 +175,6 @@ U_BOOT_DRIVER(serial_xen) = {
>   .priv_auto_alloc_size   = sizeof(struct xen_uart_priv),
>   .probe  = xen_serial_probe,
>   .ops= _serial_ops,
> -#if !CONFIG_IS_ENABLED(OF_CONTROL)
>   .flags  = DM_FLAG_PRE_RELOC,
> -#endif
>  };
>  

I applied this patch and unfortunately on ARM there were no logs. I
think this series should be improved a little.

Regards,
Anastasiia

RE: [PATCH 1/4] serial: serial_xen: print U-Boot banner and others

2020-10-15 Thread Peng Fan 
> Subject: [PATCH 1/4] serial: serial_xen: print U-Boot banner and others
> 
> At present, DM_FLAG_PRE_RELOC is set only if !OF_CONTROL.
> It doesn't make sense for this para-virtualized driver.
> 
> With this patch applied, you will be able to see early boot messages:
> 
> U-Boot 2020.10-1-ge442e71a6c52-dirty (Oct 15 2020 - 11:02:25 +0900)
> xenguest
> 
> Xen virtual CPU
> Model: XENVM-4.15
> DRAM:  128 MiB
> PVBLOCK:
> (XEN) gnttab_mark_dirty not implemented yet
> pvblock: 0
> In:hypervisor
> Out:   hypervisor
> Err:   hypervisor
> xenguest#
> 
> Signed-off-by: AKASHI Takahiro 
> ---
>  drivers/serial/serial_xen.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/serial/serial_xen.c b/drivers/serial/serial_xen.c index
> ba6504b94796..ed191829f059 100644
> --- a/drivers/serial/serial_xen.c
> +++ b/drivers/serial/serial_xen.c
> @@ -175,8 +175,6 @@ U_BOOT_DRIVER(serial_xen) = {
>   .priv_auto_alloc_size   = sizeof(struct xen_uart_priv),
>   .probe  = xen_serial_probe,
>   .ops= _serial_ops,
> -#if !CONFIG_IS_ENABLED(OF_CONTROL)
>   .flags  = DM_FLAG_PRE_RELOC,
> -#endif
>  };
> 

Reviewed-by: Peng Fan 

> --
> 2.28.0

[PATCH 1/4] serial: serial_xen: print U-Boot banner and others

2020-10-14 Thread AKASHI Takahiro 
At present, DM_FLAG_PRE_RELOC is set only if !OF_CONTROL.
It doesn't make sense for this para-virtualized driver.

With this patch applied, you will be able to see early boot messages:

U-Boot 2020.10-1-ge442e71a6c52-dirty (Oct 15 2020 - 11:02:25 +0900)
xenguest

Xen virtual CPU
Model: XENVM-4.15
DRAM:  128 MiB
PVBLOCK:
(XEN) gnttab_mark_dirty not implemented yet
pvblock: 0
In:hypervisor
Out:   hypervisor
Err:   hypervisor
xenguest#

Signed-off-by: AKASHI Takahiro 
---
 drivers/serial/serial_xen.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/serial/serial_xen.c b/drivers/serial/serial_xen.c
index ba6504b94796..ed191829f059 100644
--- a/drivers/serial/serial_xen.c
+++ b/drivers/serial/serial_xen.c
@@ -175,8 +175,6 @@ U_BOOT_DRIVER(serial_xen) = {
.priv_auto_alloc_size   = sizeof(struct xen_uart_priv),
.probe  = xen_serial_probe,
.ops= _serial_ops,
-#if !CONFIG_IS_ENABLED(OF_CONTROL)
.flags  = DM_FLAG_PRE_RELOC,
-#endif
 };
 
-- 
2.28.0