Re: [PATCH 13/17] x86: coreboot: Enable the cbsysinfo command

2021-04-07 Thread Bin Meng 
Hi Simon,

On Wed, Apr 7, 2021 at 12:33 PM Simon Glass  wrote:
>
> Enable this by default on coreboot, since it is quite useful there.
>
> Signed-off-by: Simon Glass 
> ---
>
>  arch/x86/cpu/coreboot/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/cpu/coreboot/Kconfig b/arch/x86/cpu/coreboot/Kconfig
> index b97c2779041..11385918d83 100644
> --- a/arch/x86/cpu/coreboot/Kconfig
> +++ b/arch/x86/cpu/coreboot/Kconfig
> @@ -26,5 +26,6 @@ config SYS_COREBOOT
> imply CBMEM_CONSOLE
> imply X86_TSC_READ_BASE
> select BINMAN if X86_64
> +   imply CMD_CBSYSINFO

This is not needed as in cmd/Kconfig, we have:

config CMD_CBSYSINFO
default y if SYS_COREBOOT

Regards,
Bin

[PATCH 13/17] x86: coreboot: Enable the cbsysinfo command

2021-04-06 Thread Simon Glass 
Enable this by default on coreboot, since it is quite useful there.

Signed-off-by: Simon Glass 
---

 arch/x86/cpu/coreboot/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/cpu/coreboot/Kconfig b/arch/x86/cpu/coreboot/Kconfig
index b97c2779041..11385918d83 100644
--- a/arch/x86/cpu/coreboot/Kconfig
+++ b/arch/x86/cpu/coreboot/Kconfig
@@ -26,5 +26,6 @@ config SYS_COREBOOT
imply CBMEM_CONSOLE
imply X86_TSC_READ_BASE
select BINMAN if X86_64
+   imply CMD_CBSYSINFO
 
 endif
-- 
2.31.0.208.g409f899ff0-goog