Re: [PATCH 13/33] watchdog: stm32mp: migrate trace to dev macro

[Patrice CHOTARD]

Hi Patrick

On 10/14/20 11:16 AM, Patrick Delaunay wrote:
> Change debug and pr_err to dev macro and define LOG_CATEGORY.
>
> Signed-off-by: Patrick Delaunay 
> ---
>
>  drivers/watchdog/stm32mp_wdt.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/stm32mp_wdt.c b/drivers/watchdog/stm32mp_wdt.c
> index f673fce327..109adc8332 100644
> --- a/drivers/watchdog/stm32mp_wdt.c
> +++ b/drivers/watchdog/stm32mp_wdt.c
> @@ -3,6 +3,8 @@
>   * Copyright (C) 2019, STMicroelectronics - All Rights Reserved
>   */
>  
> +#define LOG_CATEGORY UCLASS_WDT
> +
>  #include 
>  #include 
>  #include 
> @@ -10,6 +12,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  
> @@ -77,7 +80,7 @@ static int stm32mp_wdt_start(struct udevice *dev, u64 
> timeout_ms, ulong flags)
>val & (SR_PVU | SR_RVU), CONFIG_SYS_HZ);
>  
>   if (ret < 0) {
> - pr_err("Updating IWDG registers timeout");
> + dev_err(dev, "Updating IWDG registers timeout");
>   return -ETIMEDOUT;
>   }
>  
> @@ -90,7 +93,7 @@ static int stm32mp_wdt_probe(struct udevice *dev)
>   struct clk clk;
>   int ret;
>  
> - debug("IWDG init\n");
> + dev_dbg(dev, "IWDG init\n");
>  
>   priv->base = dev_read_addr(dev);
>   if (priv->base == FDT_ADDR_T_NONE)
> @@ -112,7 +115,7 @@ static int stm32mp_wdt_probe(struct udevice *dev)
>  
>   priv->wdt_clk_rate = clk_get_rate();
>  
> - debug("IWDG init done\n");
> + dev_dbg(dev, "IWDG init done\n");
>  
>   return 0;
>  }

Reviewed-by: Patrice Chotard 

Thanks

[PATCH 13/33] watchdog: stm32mp: migrate trace to dev macro

[Patrick Delaunay]

Change debug and pr_err to dev macro and define LOG_CATEGORY.

Signed-off-by: Patrick Delaunay 
---

 drivers/watchdog/stm32mp_wdt.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/stm32mp_wdt.c b/drivers/watchdog/stm32mp_wdt.c
index f673fce327..109adc8332 100644
--- a/drivers/watchdog/stm32mp_wdt.c
+++ b/drivers/watchdog/stm32mp_wdt.c
@@ -3,6 +3,8 @@
  * Copyright (C) 2019, STMicroelectronics - All Rights Reserved
  */
 
+#define LOG_CATEGORY UCLASS_WDT
+
 #include 
 #include 
 #include 
@@ -10,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -77,7 +80,7 @@ static int stm32mp_wdt_start(struct udevice *dev, u64 
timeout_ms, ulong flags)
 val & (SR_PVU | SR_RVU), CONFIG_SYS_HZ);
 
if (ret < 0) {
-   pr_err("Updating IWDG registers timeout");
+   dev_err(dev, "Updating IWDG registers timeout");
return -ETIMEDOUT;
}
 
@@ -90,7 +93,7 @@ static int stm32mp_wdt_probe(struct udevice *dev)
struct clk clk;
int ret;
 
-   debug("IWDG init\n");
+   dev_dbg(dev, "IWDG init\n");
 
priv->base = dev_read_addr(dev);
if (priv->base == FDT_ADDR_T_NONE)
@@ -112,7 +115,7 @@ static int stm32mp_wdt_probe(struct udevice *dev)
 
priv->wdt_clk_rate = clk_get_rate();
 
-   debug("IWDG init done\n");
+   dev_dbg(dev, "IWDG init done\n");
 
return 0;
 }
-- 
2.17.1