Re: [PATCH 15/17] binman: cbfs: Refactor the init process

2021-12-02 Thread Simon Glass
Update the constructor to work in the recommended way, where the node
properties are read in a separate function. This makes it more similar to
entry_Section.

Signed-off-by: Simon Glass 
---

 tools/binman/etype/cbfs.py | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied to u-boot-dm/next, thanks!


[PATCH 15/17] binman: cbfs: Refactor the init process

2021-11-23 Thread Simon Glass
Update the constructor to work in the recommended way, where the node
properties are read in a separate function. This makes it more similar to
entry_Section.

Signed-off-by: Simon Glass 
---

 tools/binman/etype/cbfs.py | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/binman/etype/cbfs.py b/tools/binman/etype/cbfs.py
index 873b199a91d..a5120127059 100644
--- a/tools/binman/etype/cbfs.py
+++ b/tools/binman/etype/cbfs.py
@@ -168,12 +168,16 @@ class Entry_cbfs(Entry):
 from binman import state
 
 super().__init__(section, etype, node)
-self._cbfs_arg = fdt_util.GetString(node, 'cbfs-arch', 'x86')
 self.align_default = None
 self._entries = OrderedDict()
-self.ReadEntries()
 self.reader = None
 
+def ReadNode(self):
+"""Read properties from the atf-fip node"""
+super().ReadNode()
+self._cbfs_arg = fdt_util.GetString(self._node, 'cbfs-arch', 'x86')
+self.ReadEntries()
+
 def ReadEntries(self):
 """Read the subnodes to find out what should go in this CBFS"""
 for node in self._node.subnodes:
-- 
2.34.0.rc2.393.gf8c9666880-goog