Re: [PATCH 15/33] misc: rcc: migrate trace to dev macro

[Patrice CHOTARD]

Hi Patrick

On 10/14/20 11:16 AM, Patrick Delaunay wrote:
> Change debug and pr_err to dev macro and define LOG_CATEGORY.
>
> Signed-off-by: Patrick Delaunay 
> ---
>
>  drivers/misc/stm32_rcc.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/stm32_rcc.c b/drivers/misc/stm32_rcc.c
> index b82fe54c60..c1a99d78e2 100644
> --- a/drivers/misc/stm32_rcc.c
> +++ b/drivers/misc/stm32_rcc.c
> @@ -4,6 +4,8 @@
>   * Author(s): Patrice Chotard,  for 
> STMicroelectronics.
>   */
>  
> +#define LOG_CATEGORY UCLASS_NOP
> +
>  #include 
>  #include 
>  #include 
> @@ -45,10 +47,10 @@ static int stm32_rcc_bind(struct udevice *dev)
>   (struct stm32_rcc_clk *)dev_get_driver_data(dev);
>   int ret;
>  
> - debug("%s(dev=%p)\n", __func__, dev);
> + dev_dbg(dev, "RCC bind\n");
>   drv = lists_driver_lookup_name(rcc_clk->drv_name);
>   if (!drv) {
> - debug("Cannot find driver '%s'\n", rcc_clk->drv_name);
> + dev_err(dev, "Cannot find driver '%s'\n", rcc_clk->drv_name);
>   return -ENOENT;
>   }
>  

Reviewed-by: Patrice Chotard 

Thanks

[PATCH 15/33] misc: rcc: migrate trace to dev macro

[Patrick Delaunay]

Change debug and pr_err to dev macro and define LOG_CATEGORY.

Signed-off-by: Patrick Delaunay 
---

 drivers/misc/stm32_rcc.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/stm32_rcc.c b/drivers/misc/stm32_rcc.c
index b82fe54c60..c1a99d78e2 100644
--- a/drivers/misc/stm32_rcc.c
+++ b/drivers/misc/stm32_rcc.c
@@ -4,6 +4,8 @@
  * Author(s): Patrice Chotard,  for STMicroelectronics.
  */
 
+#define LOG_CATEGORY UCLASS_NOP
+
 #include 
 #include 
 #include 
@@ -45,10 +47,10 @@ static int stm32_rcc_bind(struct udevice *dev)
(struct stm32_rcc_clk *)dev_get_driver_data(dev);
int ret;
 
-   debug("%s(dev=%p)\n", __func__, dev);
+   dev_dbg(dev, "RCC bind\n");
drv = lists_driver_lookup_name(rcc_clk->drv_name);
if (!drv) {
-   debug("Cannot find driver '%s'\n", rcc_clk->drv_name);
+   dev_err(dev, "Cannot find driver '%s'\n", rcc_clk->drv_name);
return -ENOENT;
}
 
-- 
2.17.1