Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay
Hi Maxime, Le 25/02/2021 à 21:58, Maxime Ripard a écrit : > On Thu, Feb 25, 2021 at 05:02:40PM +, André Przywara wrote: >> On 20/02/2021 12:14, Nicolas Boulenguez wrote: >>> From: Arnaud Ferraris >>> >>> On a cellular phone, the vast majority of users can be expected to >>> have no serial console connected and prefer a short boot. >> >> It's a bit tricky to break in with a delay of 0, but indeed most users >> won't care, so looks fine to me. >> >> But it's missing a Signed-off-by: line. > > I'm not sure we should start accepting custom boards changes like it's > done here, this will only lead to inconsistencies between boards in the > long run. The original reasoning behind this was, the PinePhone (and PineTab) is both a dev board and a consumer device, which is why I assumed it could use some kind of "special treatment". However, I don't have a strong opinion on that matter and can certainly live with the default boot delay. Regards, Arnaud > > And a defconfig is really easy to change anyway, even when it's > integrated in build systems > > Maxime >
Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay
> Nicolas, could you live with: > $ sed -i s/^CONFIG_BOOTDELAY=2/CONFIG_BOOTDELAY=0/ .config > in your build system? Or is the U-Boot build generic? No practical issue, the patch is already applied by Mobian. My concern was only to reduce divergence between redistributors. Anyway, thanks for asking before taking the decision.
Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay
On Thu, 25 Feb 2021 21:58:38 +0100 Maxime Ripard wrote: Hi, > On Thu, Feb 25, 2021 at 05:02:40PM +, André Przywara wrote: > > On 20/02/2021 12:14, Nicolas Boulenguez wrote: > > > From: Arnaud Ferraris > > > > > > On a cellular phone, the vast majority of users can be expected to > > > have no serial console connected and prefer a short boot. > > > > It's a bit tricky to break in with a delay of 0, but indeed most users > > won't care, so looks fine to me. > > > > But it's missing a Signed-off-by: line. > > I'm not sure we should start accepting custom boards changes like it's > done here, this will only lead to inconsistencies between boards in the > long run. I am a bit undecided, I see merits in both arguments. > And a defconfig is really easy to change anyway, even when it's > integrated in build systems Nicolas, could you live with: $ sed -i s/^CONFIG_BOOTDELAY=2/CONFIG_BOOTDELAY=0/ .config in your build system? Or is the U-Boot build generic? Cheers, Andre
Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay
On Thu, Feb 25, 2021 at 05:02:40PM +, André Przywara wrote: > On 20/02/2021 12:14, Nicolas Boulenguez wrote: > > From: Arnaud Ferraris > > > > On a cellular phone, the vast majority of users can be expected to > > have no serial console connected and prefer a short boot. > > It's a bit tricky to break in with a delay of 0, but indeed most users > won't care, so looks fine to me. > > But it's missing a Signed-off-by: line. I'm not sure we should start accepting custom boards changes like it's done here, this will only lead to inconsistencies between boards in the long run. And a defconfig is really easy to change anyway, even when it's integrated in build systems Maxime signature.asc Description: PGP signature
Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay
On 20/02/2021 12:14, Nicolas Boulenguez wrote: > From: Arnaud Ferraris > > On a cellular phone, the vast majority of users can be expected to > have no serial console connected and prefer a short boot. It's a bit tricky to break in with a delay of 0, but indeed most users won't care, so looks fine to me. But it's missing a Signed-off-by: line. Cheers, Andre > --- > configs/pinephone_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig > index 9967cddab9..9b51a7a100 100644 > --- a/configs/pinephone_defconfig > +++ b/configs/pinephone_defconfig > @@ -10,4 +10,5 @@ > CONFIG_PINEPHONE_DT_SELECTION=y > CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pinephone-1.2" > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > +CONFIG_BOOTDELAY=0 > CONFIG_OF_LIST="sun50i-a64-pinephone-1.1 sun50i-a64-pinephone-1.2" >
[PATCH 2/4] pinephone_defconfig: reduce boot delay
From: Arnaud Ferraris On a cellular phone, the vast majority of users can be expected to have no serial console connected and prefer a short boot. --- configs/pinephone_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig index 9967cddab9..9b51a7a100 100644 --- a/configs/pinephone_defconfig +++ b/configs/pinephone_defconfig @@ -10,4 +10,5 @@ CONFIG_PINEPHONE_DT_SELECTION=y CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pinephone-1.2" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set +CONFIG_BOOTDELAY=0 CONFIG_OF_LIST="sun50i-a64-pinephone-1.1 sun50i-a64-pinephone-1.2" -- 2.20.1
