Re: [PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-03-22 Thread Tom Rini
On Mon, Feb 27, 2023 at 05:08:34PM -0500, Tom Rini wrote:

> With clang-15 we now will get warnings such as:
> 
> warning: a function declaration without a prototype is deprecated in all
> versions of C [-Wstrict-prototypes]
> 
> And it is easy enough to address this warning here, as we aren't
> concerned with re-syncing with an upstream.
> 
> Signed-off-by: Tom Rini 
> Reviewed-by: Simon Glass 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 05:35:30PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, 27 Feb 2023 at 15:08, Tom Rini  wrote:
> >
> > With clang-15 we now will get warnings such as:
> >
> > warning: a function declaration without a prototype is deprecated in all
> > versions of C [-Wstrict-prototypes]
> >
> > And it is easy enough to address this warning here, as we aren't
> > concerned with re-syncing with an upstream.
> >
> > Signed-off-by: Tom Rini 
> > ---
> >  common/dlmalloc.c | 8 
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Reviewed-by: Simon Glass 
> 
> >
> > diff --git a/common/dlmalloc.c b/common/dlmalloc.c
> > index 41c7230424cc..0f9b7262d512 100644
> > --- a/common/dlmalloc.c
> > +++ b/common/dlmalloc.c
> > @@ -80,7 +80,7 @@ GmListElement* makeGmListElement (void* bas)
> > return this;
> >  }
> >
> > -void gcleanup ()
> > +void gcleanup (void)
> 
> drop space before ( ?

The file is so badly out of sync with our coding style I literally just
went and did %s/()$/(void)/ to move on to the next sets of problems. So
I'd rather not fix one more style issue here when I suspect there's a
barely exaggerated thousand more.

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Simon Glass
Hi Tom,

On Mon, 27 Feb 2023 at 15:08, Tom Rini  wrote:
>
> With clang-15 we now will get warnings such as:
>
> warning: a function declaration without a prototype is deprecated in all
> versions of C [-Wstrict-prototypes]
>
> And it is easy enough to address this warning here, as we aren't
> concerned with re-syncing with an upstream.
>
> Signed-off-by: Tom Rini 
> ---
>  common/dlmalloc.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass 

>
> diff --git a/common/dlmalloc.c b/common/dlmalloc.c
> index 41c7230424cc..0f9b7262d512 100644
> --- a/common/dlmalloc.c
> +++ b/common/dlmalloc.c
> @@ -80,7 +80,7 @@ GmListElement* makeGmListElement (void* bas)
> return this;
>  }
>
> -void gcleanup ()
> +void gcleanup (void)

drop space before ( ?

>  {
> BOOL rval;
> assert ( (head == NULL) || (head->base == (void*)gAddressBase));
> @@ -2340,7 +2340,7 @@ size_t malloc_usable_size(mem) Void_t* mem;
>  /* Utility to update current_mallinfo for malloc_stats and mallinfo() */
>
>  #ifdef DEBUG
> -static void malloc_update_mallinfo()
> +static void malloc_update_mallinfo(void)
>  {
>int i;
>mbinptr b;
> @@ -2397,7 +2397,7 @@ static void malloc_update_mallinfo()
>  */
>
>  #ifdef DEBUG
> -void malloc_stats()
> +void malloc_stats(void)
>  {
>malloc_update_mallinfo();
>printf("max system bytes = %10u\n",
> @@ -2418,7 +2418,7 @@ void malloc_stats()
>  */
>
>  #ifdef DEBUG
> -struct mallinfo mALLINFo()
> +struct mallinfo mALLINFo(void)
>  {
>malloc_update_mallinfo();
>return current_mallinfo;
> --
> 2.34.1
>

Regards,
Simon


[PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
With clang-15 we now will get warnings such as:

warning: a function declaration without a prototype is deprecated in all
versions of C [-Wstrict-prototypes]

And it is easy enough to address this warning here, as we aren't
concerned with re-syncing with an upstream.

Signed-off-by: Tom Rini 
---
 common/dlmalloc.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/common/dlmalloc.c b/common/dlmalloc.c
index 41c7230424cc..0f9b7262d512 100644
--- a/common/dlmalloc.c
+++ b/common/dlmalloc.c
@@ -80,7 +80,7 @@ GmListElement* makeGmListElement (void* bas)
return this;
 }
 
-void gcleanup ()
+void gcleanup (void)
 {
BOOL rval;
assert ( (head == NULL) || (head->base == (void*)gAddressBase));
@@ -2340,7 +2340,7 @@ size_t malloc_usable_size(mem) Void_t* mem;
 /* Utility to update current_mallinfo for malloc_stats and mallinfo() */
 
 #ifdef DEBUG
-static void malloc_update_mallinfo()
+static void malloc_update_mallinfo(void)
 {
   int i;
   mbinptr b;
@@ -2397,7 +2397,7 @@ static void malloc_update_mallinfo()
 */
 
 #ifdef DEBUG
-void malloc_stats()
+void malloc_stats(void)
 {
   malloc_update_mallinfo();
   printf("max system bytes = %10u\n",
@@ -2418,7 +2418,7 @@ void malloc_stats()
 */
 
 #ifdef DEBUG
-struct mallinfo mALLINFo()
+struct mallinfo mALLINFo(void)
 {
   malloc_update_mallinfo();
   return current_mallinfo;
-- 
2.34.1