Re: [PATCH 3/7] libavb: Fix a warning with clang-15

[Tom Rini]

On Mon, Feb 27, 2023 at 05:08:35PM -0500, Tom Rini wrote:

> With clang-15 we now will get warnings such as:
> 
> warning: a function declaration without a prototype is deprecated in all
> versions of C [-Wstrict-prototypes]
> 
> And it is easy enough to address this warning here, as we aren't
> concerned with re-syncing with an upstream.
> 
> Signed-off-by: Tom Rini 
> Reviewed-by: Simon Glass 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH 3/7] libavb: Fix a warning with clang-15

[Simon Glass]

On Mon, 27 Feb 2023 at 15:09, Tom Rini  wrote:
>
> With clang-15 we now will get warnings such as:
>
> warning: a function declaration without a prototype is deprecated in all
> versions of C [-Wstrict-prototypes]
>
> And it is easy enough to address this warning here, as we aren't
> concerned with re-syncing with an upstream.
>
> Signed-off-by: Tom Rini 
> ---
> Cc: Igor Opaniuk 
> ---
>  lib/libavb/avb_cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass 

[PATCH 3/7] libavb: Fix a warning with clang-15

[Tom Rini]

With clang-15 we now will get warnings such as:

warning: a function declaration without a prototype is deprecated in all
versions of C [-Wstrict-prototypes]

And it is easy enough to address this warning here, as we aren't
concerned with re-syncing with an upstream.

Signed-off-by: Tom Rini 
---
Cc: Igor Opaniuk 
---
 lib/libavb/avb_cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/libavb/avb_cmdline.c b/lib/libavb/avb_cmdline.c
index cb54e658c487..a58ce6c48c01 100644
--- a/lib/libavb/avb_cmdline.c
+++ b/lib/libavb/avb_cmdline.c
@@ -394,7 +394,7 @@ out:
   return ret;
 }
 
-AvbCmdlineSubstList* avb_new_cmdline_subst_list() {
+AvbCmdlineSubstList* avb_new_cmdline_subst_list(void) {
   return (AvbCmdlineSubstList*)avb_calloc(sizeof(AvbCmdlineSubstList));
 }
 
-- 
2.34.1