Re: [PATCH 3/9] scripts: Makefile.lib: Pass __UBOOT__ to DTC's CPP

2022-03-17 Thread Pierre-Clément Tosi
On Wed, Mar 16, 2022 at 01:23:43PM -0600, Simon Glass wrote:
> Hi Pierre-Clément,
> 
> On Wed, 16 Mar 2022 at 09:40, Pierre-Clément Tosi  wrote:
> >
> > Some headers included (possibly indirectly) from .dts files might have
> > U-Boot specific content relying on the __UBOOT__ macro passed to CPP
> > when building C code. In that case, it would be sensible for DTC to see
> > that content instead of the non-U-Boot one. To do so, pass the macro to
> > the pre-processor when generate DTC inputs.
> 
> Can you give an example of such a situation?

This patch isn't fixing an existing issue. Instead, it preempts one that
following patches, adding "#ifndef __UBOOT__/{code not supported in U-Boot}" in
Linux headers, would bring. But IMO (and IIUC), it makes sense on its own given
the meaning that CPP macro has in C code and how it's systematically set through
KBUILD_CPPFLAGS.

> 
> >
> > Signed-off-by: Pierre-Clément Tosi 
> > Cc: Simon Glass 
> > ---
> >  scripts/Makefile.lib | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Simon Glass 
> 
> 
> >
> > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> > index c14da10de7..d7b548dce8 100644
> > --- a/scripts/Makefile.lib
> > +++ b/scripts/Makefile.lib
> > @@ -192,6 +192,7 @@ dtc_cpp_flags  = -Wp,-MD,$(depfile).pre.tmp -nostdinc   
> >  \
> >  -I$(srctree)/arch/$(ARCH)/include   \
> >  -include $(srctree)/include/linux/kconfig.h \
> >  -D__ASSEMBLY__  \
> > +-D__UBOOT__ \
> >  -undef -D__DTS__
> >
> >  # Finds the multi-part object the current object will be linked into
> > --
> > 2.35.1.723.g4982287a31-goog
> >

-- 
Pierre


Re: [PATCH 3/9] scripts: Makefile.lib: Pass __UBOOT__ to DTC's CPP

2022-03-16 Thread Simon Glass
Hi Pierre-Clément,

On Wed, 16 Mar 2022 at 09:40, Pierre-Clément Tosi  wrote:
>
> Some headers included (possibly indirectly) from .dts files might have
> U-Boot specific content relying on the __UBOOT__ macro passed to CPP
> when building C code. In that case, it would be sensible for DTC to see
> that content instead of the non-U-Boot one. To do so, pass the macro to
> the pre-processor when generate DTC inputs.

Can you give an example of such a situation?

>
> Signed-off-by: Pierre-Clément Tosi 
> Cc: Simon Glass 
> ---
>  scripts/Makefile.lib | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass 


>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index c14da10de7..d7b548dce8 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -192,6 +192,7 @@ dtc_cpp_flags  = -Wp,-MD,$(depfile).pre.tmp -nostdinc 
>\
>  -I$(srctree)/arch/$(ARCH)/include   \
>  -include $(srctree)/include/linux/kconfig.h \
>  -D__ASSEMBLY__  \
> +-D__UBOOT__ \
>  -undef -D__DTS__
>
>  # Finds the multi-part object the current object will be linked into
> --
> 2.35.1.723.g4982287a31-goog
>