Re: [PATCH V2 02/13] net: smc911x: Replace malloc()+memset() with calloc()

[Marek Vasut]

On 3/22/20 6:38 PM, Masahiro Yamada wrote:
> On Sun, Mar 22, 2020 at 2:06 AM Marek Vasut  wrote:
>>
>> Replace combination of malloc()+memset() with calloc() as the behavior
> 
> calloc() -> kzalloc()
> 
> to sync with the actual code.
> 
> Please fix the subject as well.

I'm switching this back to calloc(), it's not worth pulling in all the
linux compat stuff for one single function.

Re: [PATCH V2 02/13] net: smc911x: Replace malloc()+memset() with calloc()

[Masahiro Yamada]

On Sun, Mar 22, 2020 at 2:06 AM Marek Vasut  wrote:
>
> Replace combination of malloc()+memset() with calloc() as the behavior

calloc() -> kzalloc()

to sync with the actual code.

Please fix the subject as well.





> is exactly the same and the amount of code is reduced.
>
> Signed-off-by: Marek Vasut 
> Cc: Joe Hershberger 
> Cc: Masahiro Yamada 
> ---
> V2: - Use kzalloc()
> - Return -ENOMEM on alloc fail
> ---
>  drivers/net/smc911x.c | 8 +++-
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index 24b4eaeb3f..9a2a0f4435 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -242,11 +242,9 @@ int smc911x_initialize(u8 dev_num, int base_addr)
> unsigned long addrl, addrh;
> struct eth_device *dev;
>
> -   dev = malloc(sizeof(*dev));
> -   if (!dev) {
> -   return -1;
> -   }
> -   memset(dev, 0, sizeof(*dev));
> +   dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> +   if (!dev)
> +   return -ENOMEM;
>
> dev->iobase = base_addr;
>
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada

[PATCH V2 02/13] net: smc911x: Replace malloc()+memset() with calloc()

[Marek Vasut]

Replace combination of malloc()+memset() with calloc() as the behavior
is exactly the same and the amount of code is reduced.

Signed-off-by: Marek Vasut 
Cc: Joe Hershberger 
Cc: Masahiro Yamada 
---
V2: - Use kzalloc()
- Return -ENOMEM on alloc fail
---
 drivers/net/smc911x.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 24b4eaeb3f..9a2a0f4435 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -242,11 +242,9 @@ int smc911x_initialize(u8 dev_num, int base_addr)
unsigned long addrl, addrh;
struct eth_device *dev;
 
-   dev = malloc(sizeof(*dev));
-   if (!dev) {
-   return -1;
-   }
-   memset(dev, 0, sizeof(*dev));
+   dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+   if (!dev)
+   return -ENOMEM;
 
dev->iobase = base_addr;
 
-- 
2.25.1