Re: [PATCH u-boot-dm + u-boot-spi v3 09/11] cmd: mtd: print device OF path in listing

2021-02-25 Thread Simon Glass
Hi Marek,

On Thu, 25 Feb 2021 at 09:14, Marek Behún  wrote:
>
> Print MTD's device OF path in the output of `mtd list` command.
>
> Signed-off-by: Marek Behún 
> Cc: Jagan Teki 
> Cc: Priyanka Jain 
> Cc: Simon Glass 
> Cc: Heiko Schocher 
> Cc: Jagan Teki 
> Cc: Patrick Delaunay 
> Cc: Patrice CHOTARD 
> Cc: Miquel Raynal 
> ---
>  cmd/mtd.c | 9 +
>  1 file changed, 9 insertions(+)
>
> diff --git a/cmd/mtd.c b/cmd/mtd.c
> index 485a963bdd..446cbc1038 100644
> --- a/cmd/mtd.c
> +++ b/cmd/mtd.c
> @@ -126,6 +126,15 @@ static void mtd_show_device(struct mtd_info *mtd)
> printf("  - driver: %s\n", mtd->dev->driver->name);
> }
>  #endif
> +#if defined(CONFIG_OF_CONTROL)
> +   if (mtd->dev) {

Can you do:

if (IS_ENABLED(CONFIG_OF_CONTROL) && mtd->dev)

?

> +   char buf[256];
> +   int res;
> +
> +   res = ofnode_get_path(mtd_get_ofnode(mtd), buf, 256);
> +   printf("  - path: %s\n", res == 0 ? buf : "unavailable");
> +   }
> +#endif
>
> /* MTD device information */
> printf("  - type: ");
> --
> 2.26.2
>

Regards,
Simon


[PATCH u-boot-dm + u-boot-spi v3 09/11] cmd: mtd: print device OF path in listing

2021-02-25 Thread Marek Behún
Print MTD's device OF path in the output of `mtd list` command.

Signed-off-by: Marek Behún 
Cc: Jagan Teki 
Cc: Priyanka Jain 
Cc: Simon Glass 
Cc: Heiko Schocher 
Cc: Jagan Teki 
Cc: Patrick Delaunay 
Cc: Patrice CHOTARD 
Cc: Miquel Raynal 
---
 cmd/mtd.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/cmd/mtd.c b/cmd/mtd.c
index 485a963bdd..446cbc1038 100644
--- a/cmd/mtd.c
+++ b/cmd/mtd.c
@@ -126,6 +126,15 @@ static void mtd_show_device(struct mtd_info *mtd)
printf("  - driver: %s\n", mtd->dev->driver->name);
}
 #endif
+#if defined(CONFIG_OF_CONTROL)
+   if (mtd->dev) {
+   char buf[256];
+   int res;
+
+   res = ofnode_get_path(mtd_get_ofnode(mtd), buf, 256);
+   printf("  - path: %s\n", res == 0 ? buf : "unavailable");
+   }
+#endif
 
/* MTD device information */
printf("  - type: ");
-- 
2.26.2