Re: [PATCH u-boot v4 02/36] checkpatch: require quotes around section name in the __section() macro
On Thu, May 20, 2021 at 01:23:51PM +0200, Marek Behún wrote: > This is how Linux does this now, see Linux commit 339f29d91acf. > > Signed-off-by: Marek Behún > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH u-boot v4 02/36] checkpatch: require quotes around section name in the __section() macro
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > This is how Linux does this now, see Linux commit 339f29d91acf. > > Signed-off-by: Marek Behún > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass
[PATCH u-boot v4 02/36] checkpatch: require quotes around section name in the __section() macro
This is how Linux does this now, see Linux commit 339f29d91acf.
Signed-off-by: Marek Behún
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 59a714a95f..08a827535a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6073,7 +6073,7 @@ sub process {
my $old = substr($rawline, $-[1], $+[1] - $-[1]);
my $new = substr($old, 1, -1);
if (WARN("PREFER_SECTION",
-"__section($new) is preferred over
__attribute__((section($old)))\n" . $herecurr) &&
+"__section(\"$new\") is preferred over
__attribute__((section($old)))\n" . $herecurr) &&
$fix) {
$fixed[$fixlinenr] =~
s/\b__attribute__\s*\(\s*\(\s*_*section_*\s*\(\s*\Q$old\E\s*\)\s*\)\s*\)/__section($new)/;
}
--
2.26.3
