Re: [PATCH v1 6/7] toradex: common: Use random mac address if toradex config block is missing

2024-02-23 Thread Francesco Dolcini
On Tue, Feb 20, 2024 at 07:29:25PM +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli 
> 
> Set CONFIG_NET_RANDOM_ETHADDR=y, which sets random eth address in
> case there is no toradex config block programmed.
> In case of missing toradex config block the generated mac address was
> always the same, linked to serial number 0.
> Use random generated mac address instead.
> 
> Signed-off-by: Emanuele Ghidoli 
> Signed-off-by: Francesco Dolcini 
> ---
>  board/toradex/common/tdx-common.c  | 1 -
>  configs/apalis-imx8_defconfig  | 1 +
>  configs/apalis-tk1_defconfig   | 1 +
>  configs/apalis_imx6_defconfig  | 1 +
>  configs/apalis_t30_defconfig   | 1 +
>  configs/colibri-imx6ull-emmc_defconfig | 1 +
>  configs/colibri-imx6ull_defconfig  | 1 +
>  configs/colibri-imx8x_defconfig| 1 +
>  configs/colibri_imx6_defconfig | 1 +
>  configs/colibri_imx7_defconfig | 1 +
>  configs/colibri_imx7_emmc_defconfig| 1 +
>  configs/colibri_t20_defconfig  | 1 +
>  configs/colibri_t30_defconfig  | 1 +
>  configs/colibri_vf_defconfig   | 1 +
>  configs/verdin-am62_a53_defconfig  | 1 +
>  configs/verdin-am62_r5_defconfig   | 1 +
>  configs/verdin-imx8mm_defconfig| 1 +
>  configs/verdin-imx8mp_defconfig| 1 +
>  18 files changed, 17 insertions(+), 1 deletion(-)

...

> diff --git a/configs/verdin-am62_r5_defconfig 
> b/configs/verdin-am62_r5_defconfig
> index a3febdcb6941..910340ea5a41 100644
> --- a/configs/verdin-am62_r5_defconfig
> +++ b/configs/verdin-am62_r5_defconfig
> @@ -65,6 +65,7 @@ CONFIG_SPL_OF_CONTROL=y
>  CONFIG_SPL_MULTI_DTB_FIT=y
>  CONFIG_SPL_MULTI_DTB_FIT_NO_COMPRESSION=y
>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> +CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_SPL_DM=y
>  CONFIG_SPL_DM_SEQ_ALIAS=y
>  CONFIG_REGMAP=y

This change here is not required, it has no effect since there is no
network available on the verdin am62 r5, however it is just confusing to
have it enabled.

I will send a v2 with this removed.

Francesco



[PATCH v1 6/7] toradex: common: Use random mac address if toradex config block is missing

2024-02-20 Thread Francesco Dolcini
From: Emanuele Ghidoli 

Set CONFIG_NET_RANDOM_ETHADDR=y, which sets random eth address in
case there is no toradex config block programmed.
In case of missing toradex config block the generated mac address was
always the same, linked to serial number 0.
Use random generated mac address instead.

Signed-off-by: Emanuele Ghidoli 
Signed-off-by: Francesco Dolcini 
---
 board/toradex/common/tdx-common.c  | 1 -
 configs/apalis-imx8_defconfig  | 1 +
 configs/apalis-tk1_defconfig   | 1 +
 configs/apalis_imx6_defconfig  | 1 +
 configs/apalis_t30_defconfig   | 1 +
 configs/colibri-imx6ull-emmc_defconfig | 1 +
 configs/colibri-imx6ull_defconfig  | 1 +
 configs/colibri-imx8x_defconfig| 1 +
 configs/colibri_imx6_defconfig | 1 +
 configs/colibri_imx7_defconfig | 1 +
 configs/colibri_imx7_emmc_defconfig| 1 +
 configs/colibri_t20_defconfig  | 1 +
 configs/colibri_t30_defconfig  | 1 +
 configs/colibri_vf_defconfig   | 1 +
 configs/verdin-am62_a53_defconfig  | 1 +
 configs/verdin-am62_r5_defconfig   | 1 +
 configs/verdin-imx8mm_defconfig| 1 +
 configs/verdin-imx8mp_defconfig| 1 +
 18 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/board/toradex/common/tdx-common.c 
b/board/toradex/common/tdx-common.c
index 1f3253f4222e..9f09788137d5 100644
--- a/board/toradex/common/tdx-common.c
+++ b/board/toradex/common/tdx-common.c
@@ -126,7 +126,6 @@ static int settings_r(void)
 
if (read_tdx_cfg_block()) {
printf("MISSING TORADEX CONFIG BLOCK\n");
-   get_mac_from_serial(tdx_serial, &tdx_eth_addr);
 
/* Board can run even if config block is not present */
return 0;
diff --git a/configs/apalis-imx8_defconfig b/configs/apalis-imx8_defconfig
index 982098d81420..da3b0e254899 100644
--- a/configs/apalis-imx8_defconfig
+++ b/configs/apalis-imx8_defconfig
@@ -52,6 +52,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_PART=1
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
 CONFIG_TFTP_BLOCKSIZE=4096
 CONFIG_TFTP_TSIZE=y
diff --git a/configs/apalis-tk1_defconfig b/configs/apalis-tk1_defconfig
index 6ed3898b60c3..20c9c06cdeac 100644
--- a/configs/apalis-tk1_defconfig
+++ b/configs/apalis-tk1_defconfig
@@ -52,6 +52,7 @@ CONFIG_ENV_OVERWRITE=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_PART=1
 CONFIG_VERSION_VARIABLE=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
 CONFIG_TFTP_BLOCKSIZE=16352
 CONFIG_TFTP_TSIZE=y
diff --git a/configs/apalis_imx6_defconfig b/configs/apalis_imx6_defconfig
index 05ff6fa115ce..492550607035 100644
--- a/configs/apalis_imx6_defconfig
+++ b/configs/apalis_imx6_defconfig
@@ -75,6 +75,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_PART=1
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
 CONFIG_TFTP_BLOCKSIZE=4096
 CONFIG_USE_IPADDR=y
diff --git a/configs/apalis_t30_defconfig b/configs/apalis_t30_defconfig
index 0a27509a97e6..03a1f2c23906 100644
--- a/configs/apalis_t30_defconfig
+++ b/configs/apalis_t30_defconfig
@@ -45,6 +45,7 @@ CONFIG_OF_LIVE=y
 CONFIG_ENV_OVERWRITE=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_PART=1
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
 CONFIG_TFTP_BLOCKSIZE=16352
 CONFIG_TFTP_TSIZE=y
diff --git a/configs/colibri-imx6ull-emmc_defconfig 
b/configs/colibri-imx6ull-emmc_defconfig
index 285fed9e4faf..2b04855770ab 100644
--- a/configs/colibri-imx6ull-emmc_defconfig
+++ b/configs/colibri-imx6ull-emmc_defconfig
@@ -51,6 +51,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_PART=1
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
 CONFIG_TFTP_BLOCKSIZE=16352
 CONFIG_TFTP_TSIZE=y
diff --git a/configs/colibri-imx6ull_defconfig 
b/configs/colibri-imx6ull_defconfig
index a8a633063d00..959930cf2e31 100644
--- a/configs/colibri-imx6ull_defconfig
+++ b/configs/colibri-imx6ull_defconfig
@@ -60,6 +60,7 @@ CONFIG_ENV_RANGE=0x8
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
 CONFIG_TFTP_BLOCKSIZE=16352
 CONFIG_TFTP_TSIZE=y
diff --git a/configs/colibri-imx8x_defconfig b/configs/colibri-imx8x_defconfig
index aa18d28d3e6d..88928b0e4bc5 100644
--- a/configs/colibri-imx8x_defconfig
+++ b/configs/colibri-imx8x_defconfig
@@ -52,6 +52,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_PART=1
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_VERSION_VARIABLE=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
 CONFIG_TFTP_BLOCKSIZE=4096
 CONFIG_TFTP_TSIZE=y
diff --git a/configs/colibri_imx6_defconfig b/configs/colibri_imx6_defconfig
index 70cb79531e92..55c71a000d00 100644
--- a/configs/colibri_imx6_defconfig
+++ b/configs/colibri_imx6_defconfig
@@ -74,6 +74,7 @@ CONFIG_SYS_RELOC_